Re: [PATCH 00/22] KEYS: Support TPM-wrapped key and crypto ops

2018-09-18 Thread David Woodhouse
On Wed, 2018-09-05 at 22:54 +0100, David Howells wrote: > > Example usage for a PKCS#8 blob: > > j=`openssl pkcs8 -in private_key.pem -topk8 -nocrypt -outform DER | \ >     keyctl padd asymmetric foo @s` > > Example usage for a TPM wrapped blob: > > openssl genrsa -out /

Re: [PATCH 00/22] KEYS: Support TPM-wrapped key and crypto ops

2018-09-18 Thread David Woodhouse
On Sat, 2018-09-08 at 16:26 +0100, David Howells wrote: > Marcel Holtmann wrote: > > > > > so I have reviewed and tested this code. In addition, we have test cases for > > it in ELL (embedded linux library). > > I wonder if there's any practical way to add a test for this to the keyutils > tes

Re: [patch V3 02/11] x86/mm/cpa: Split, rename and clean up try_preserve_large_page()

2018-09-18 Thread Peter Zijlstra
On Mon, Sep 17, 2018 at 04:29:08PM +0200, Thomas Gleixner wrote: > Avoid the extra variable and gotos by splitting the function into the > actual algorithm and a callable function which contains the lock > protection. > > Rename it to should_split_large_page() while at it so the return values make

Re: [PATCH v2] fanotify reports the thread id of the event trigger

2018-09-18 Thread Amir Goldstein
On Tue, Sep 18, 2018 at 6:01 AM Nixiaoming wrote: > > On Mon, Sep 17, 2018 11:51 PM Amir Goldstein wrote: > >On Mon, Sep 17, 2018 at 6:05 PM nixiaoming wrote: ... > >> diff --git a/include/linux/fsnotify_backend.h > >> b/include/linux/fsnotify_backend.h > >> index b8f4182..44c659f 100644 > >> -

Re: [PATCH 5/6] arm64/io: Add header for instrumentation of io operations

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 5:09 AM, Steven Rostedt wrote: On Sun, 9 Sep 2018 01:57:06 +0530 Sai Prakash Ranjan wrote: The new asm-generic/io-instrumented.h will keep arch code clean and separate from instrumented version which traces io register accesses. This instrumented header can later be included in a

Re: [patch V3 08/11] x86/mm/cpa: Add sanity check for existing mappings

2018-09-18 Thread Peter Zijlstra
On Mon, Sep 17, 2018 at 04:29:14PM +0200, Thomas Gleixner wrote: > +static void split_set_pte(struct cpa_data *cpa, pte_t *pte, unsigned long > pfn, > + pgprot_t ref_prot, unsigned long address, > + unsigned long size) > +{ > + unsigned int npg = PFN

Re: [PATCH v2 3/3] tpm: retrieve digest size of unknown algorithms with PCR read

2018-09-18 Thread Roberto Sassu
On 9/17/2018 11:16 PM, Jarkko Sakkinen wrote: On Mon, Sep 17, 2018 at 12:02:56PM +0200, Roberto Sassu wrote: This code has the same behavior of tpm2_get_pcr_allocation(). If some banks are not used, set the algorithm of the first unused to TPM_ALG_ERROR. My point is that maybe it would sense t

Re: [PATCH 1/2] string: make kmemdup_nul take and return void*, not char*

2018-09-18 Thread Rasmus Villemoes
On 7 September 2018 at 09:46, Rasmus Villemoes wrote: > This allows kmemdup_nul to be used in cases where the source pointer is > not a char* or const char*, but the result should nevertheless have a > nul char after the memcpy'ed data. ping

Re: linux-next: manual merge of the staging tree with the at91 tree

2018-09-18 Thread Nicolas Ferre
On 18/09/2018 at 05:12, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the staging tree got a conflict in: MAINTAINERS between commit: 5ae2f1f30197 ("MAINTAINERS: move former ATMEL entries to proper MICROCHIP locatioat91n") from the at91 tree and commit: 010de20412fc

[PATCH v2] ASoC: AMD: Fix capture unstable in beginning for some runs

2018-09-18 Thread Akshu Agrawal
alsa_conformance_test -C hw:0,4 -p 1024 --debug would sometime show: TIME_DIFF(s)HW_LEVEL READ RATE 0.95970 1024 102410670001.041992 0.042609555 1024 2048 24032.168372 0.021330364 1024 3072 48006.681930 0.021339559

Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global

2018-09-18 Thread Greg Kroah-Hartman
On Tue, Sep 18, 2018 at 12:28:39PM +0530, Sai Prakash Ranjan wrote: > On 9/18/2018 11:41 AM, Jiri Slaby wrote: > > On 09/17/2018, 11:33 PM, Matthias Kaehlcke wrote: > > > sysrq_handle_crash() dereferences a NULL pointer on purpose to force > > > an exception, the local variable 'killer' is assigned

Re: [PATCH 2/2] Compiler Attributes: naked can be shared

2018-09-18 Thread Greg Kroah-Hartman
On Mon, Sep 17, 2018 at 08:19:50PM -0700, Stefan Agner wrote: > On 13.09.2018 16:59, Miguel Ojeda wrote: > > The naked attribute is supported by at least gcc >= 4.6 (for ARM, > > which is the only current user), gcc >= 8 (for x86), clang >= 3.1 > > and icc >= 13. See https://godbolt.org/z/350Dyc >

Re: linux-next: manual merge of the staging tree with the at91 tree

2018-09-18 Thread Greg KH
On Tue, Sep 18, 2018 at 01:12:38PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the staging tree got a conflict in: > > MAINTAINERS > > between commit: > > 5ae2f1f30197 ("MAINTAINERS: move former ATMEL entries to proper MICROCHIP > locatioat91n") > > from the a

[PATCH] drm: sun4i: Fix a uninitialized variable warning.

2018-09-18 Thread zhong jiang
Fix the following compile warning: drivers/gpu/drm/sun4i/sun4i_tcon.c:1088: warning: 'has_lvds_alt' may be used uninitialized in this function [-Wmaybe-uninitialized] bool has_lvds_rst, has_lvds_alt, can_lvds; Signed-off-by: zhong jiang --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 +- 1 file cha

Re: [PATCH v5 03/27] arm64: alternative: Apply alternatives early in boot process

2018-09-18 Thread Julien Thierry
On 18/09/18 00:44, Daniel Thompson wrote: On Wed, Sep 12, 2018 at 05:49:09PM +0100, Julien Thierry wrote: + __apply_alternatives(®ion, false, boot_capabilities); +} + #ifdef CONFIG_MODULES void apply_alternatives_module(void *start, size_t length) { diff --git a/arch/arm64/k

Re: [PATCH 0/4] Add i.MX6ULZ SoC support

2018-09-18 Thread Stefan Wahren
Hi Anson, Am 18.09.2018 um 08:19 schrieb Anson Huang: > This patch set adds i.MX6ULZ SoC support, i.MX6ULZ is a new SoC of > i.MX6 family, compared to i.MX6ULL, it removes below modules: > > - UART5/UART6/UART7/UART8; > - PWM5/PWM6/PWM7/PWM8; > - eCSPI3/eCSPI4; > - CAN1/CAN2; >

Re: [PATCH 4.14 000/126] 4.14.71-stable review

2018-09-18 Thread Greg Kroah-Hartman
On Mon, Sep 17, 2018 at 04:59:49PM -0700, Nathan Chancellor wrote: > On Tue, Sep 18, 2018 at 12:40:48AM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.71 release. > > There are 126 patches in this series, all will be posted as a response > > to this o

Re: [PATCH] kbuild: allow to use GCC toolchain not in Clang search path

2018-09-18 Thread Masahiro Yamada
Hi Stefan, 2018-09-18 12:11 GMT+09:00 Stefan Agner : > On 17.09.2018 20:06, Masahiro Yamada wrote: >> Hi Stefan, >> >> 2018-09-18 11:31 GMT+09:00 Stefan Agner : >>> When using a GCC cross toolchain which is not in a compiled in >>> Clang search path, Clang reverts to the system assembler and >>> l

Re: [PATCH v7 1/7] edac: synopsys: Fix code comments and naming convention

2018-09-18 Thread Borislav Petkov
On Mon, Sep 17, 2018 at 07:54:59PM +0530, Manish Narani wrote: > Update the comments in the Synopsys EDAC driver. Minor changes to function > names and return types are also included. > > Signed-off-by: Manish Narani > --- > drivers/edac/synopsys_edac.c | 176 > -

Re: [LKP] [ipc] 61224adcd2: general_protection_fault:#[##]

2018-09-18 Thread Li Zhijian
On 9/18/2018 3:23 PM, David Howells wrote: Still not sure what I'm meant to be seeing. Note that there are a number of "Not found" and "No such file or directory" errors appearing. I've attached the console log for you. David --- warthog>sudo bin/lkp qemu -k /data/fs/linux-next/build2/arch/x

Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller

2018-09-18 Thread Borislav Petkov
On Mon, Sep 17, 2018 at 07:55:00PM +0530, Manish Narani wrote: > Add platform specific structures, so that we can add different IP > support later using quirks. > > Signed-off-by: Manish Narani > --- > drivers/edac/synopsys_edac.c | 91 > +++- > 1 file ch

[PATCH v2 1/8] staging: rtl8188eu: simplify calculation

2018-09-18 Thread Michael Straube
Simplify calcualation: * 10 / 2 can be reduced to * 5 Also cleans missing spaces checkpatch issues. Signed-off-by: Michael Straube --- changes in v2: fixed typo in patch 1/8 commit message Simpliy -> Simplify drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 2 +- 1 file change

[PATCH v2 6/8] staging: rtl8188eu: add missing spaces around operators

2018-09-18 Thread Michael Straube
Add missing spaces around '|', '-', and '&' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/r

[PATCH v2 7/8] staging: rtl8188eu: fix lines over 80 characters

2018-09-18 Thread Michael Straube
Wrap lines over 80 characters where appropriate to clear checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/d

[PATCH v2 8/8] staging: rtl8188eu: simplify function comments

2018-09-18 Thread Michael Straube
Simplify function comments to a single line. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core/rtw

[PATCH v2 2/8] staging: rtl8188eu: remove unnecessary parentheses

2018-09-18 Thread Michael Straube
Remove unnecessary parentheses as reported by checkpatch and from conditionals. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_ioctl_set.c| 50 +-- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.

[PATCH v2 4/8] staging: rtl8188eu: fix comparsions to true

2018-09-18 Thread Michael Straube
Use if(x) instead of if(x == true). Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_ioctl_set.c| 26 +-- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core/rtw_ioct

[PATCH v2 5/8] staging: rtl8188eu: fix comparsions to false

2018-09-18 Thread Michael Straube
Use if(!x) instead of if(x == false). Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c index b

[PATCH v2 3/8] staging: rtl8188eu: remove whitespace

2018-09-18 Thread Michael Straube
Replace tabs with spaces or just remove spaces in declarations. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_ioctl_set.c| 34 +-- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/sta

Re: [PATCH 08/19] vmw_balloon: refactor change size from vmballoon_work

2018-09-18 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Nadav-Amit/vmw_balloon-compaction-shrinker-64-bit-etc/20180918-152302 config: x86_64-randconfig-x007-201837 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings

Re: [patch V3 02/11] x86/mm/cpa: Split, rename and clean up try_preserve_large_page()

2018-09-18 Thread Peter Zijlstra
On Mon, Sep 17, 2018 at 04:29:08PM +0200, Thomas Gleixner wrote: > @@ -1288,23 +1287,23 @@ static int __change_page_attr(struct cpa > err = split_large_page(cpa, kpte, address); > if (!err) { > /* > + * Do a global flush tlb after splitting the large page > +

Re: [PATCH 2/9] ARM: change NR_IPIS to 8

2018-09-18 Thread Chunyan Zhang
Hi, Any conclusion on this patch? The coverity tool is still complaining error on the issue which this patch can fix. Thanks, Chunyan On 18 February 2016 at 23:18, Arnd Bergmann wrote: > On Thursday 18 February 2016 14:37:09 Russell King - ARM Linux wrote: >> On Thu, Feb 18, 2016 at 03:01:54PM

Re: [PATCH] samples: disable CONFIG_SAMPLES for UML

2018-09-18 Thread Richard Weinberger
Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada: > Some samples require headers installation, so commit 3fca1700c4c3 > ("kbuild: make samples really depend on headers_install") added > such dependency in the top Makefile. However, UML fails to build > with CONFIG_SAMPLES=y b

[PATCH v6 2/2] iio: proximity: vl53l0x: add interrupt support

2018-09-18 Thread Song Qiang
The first version of this driver issues a measuring request and polling for a status register in the device for measuring completes. vl53l0x support configuring GPIO1 on it to generate interrupt to indicate that new measurement is ready. This patch adds support for using this mechanisim to reduce c

[PATCH v6 1/2] iio: proximity: Add driver support for ST's VL53L0X ToF ranging sensor.

2018-09-18 Thread Song Qiang
This driver was originally written by ST in 2016 as a misc input device driver, and hasn't been maintained for a long time. I grabbed some code from it's API and reformed it into an iio proximity device driver. This version of driver uses i2c bus to talk to the sensor and polling for measuring comp

[PATCH] PCI/AER: Clear uncorrectable error status for device

2018-09-18 Thread Oza Pawandeep
PCI based device drivers handles ERR_NONFATAL by registering pci_error_handlers. some of the drivers clear AER uncorrectable status in slot_reset while some in resume. Drivers should not have responsibility of clearing the AER status, instead shall be done by error and recovery framework defined

RE: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Yogesh Narayan Gaur
Hi Frieder, > -Original Message- > From: Frieder Schrempf [mailto:frieder.schre...@exceet.de] > Sent: Tuesday, September 18, 2018 1:52 PM > To: Boris Brezillon ; Yogesh Narayan Gaur > > Cc: linux-...@lists.infradead.org; marek.va...@gmail.com; linux- > s...@vger.kernel.org; devicet...@vge

[PATCH] ASoC: remove redundant include

2018-09-18 Thread zhong jiang
module.h already contained moduleparam.h, so it is safe to remove the redundant include. The issue is detected with the help of Coccinelle. Signed-off-by: zhong jiang --- sound/soc/codecs/rt5651.c | 1 - sound/soc/codecs/wm8904.c | 1 - sound/soc/codecs/wm8974.c | 1 - sound/soc/soc-dapm.c

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-18 Thread Mika Westerberg
On Mon, Sep 17, 2018 at 11:16:41AM -0700, Rajat Jain wrote: > On Mon, Sep 17, 2018 at 1:13 AM Mika Westerberg > wrote: > > > > On Fri, Sep 14, 2018 at 05:18:34PM -0700, Rajat Jain wrote: > > > This is to report what I think is a problem in the pinctrl-icelake > > > driver. It seems that when tryin

Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-09-18 Thread Frieder Schrempf
Hi Boris, Yogesh, On 17.09.2018 13:37, Boris Brezillon wrote: Hi Yogesh, On Mon, 17 Sep 2018 15:18:26 +0530 Yogesh Gaur wrote: + + /* +* R/W functions for big- or little-endian registers: +* The FSPI controller's endianness is independent of +* the CPU core's en

Re: [PATCH] md: bitmap: use mddev_suspend/resume instead of ->quiesce()

2018-09-18 Thread Gi-Oh Kim
On Thu, Sep 13, 2018 at 5:35 PM, Jack Wang wrote: > From: Jack Wang > > After 9e1cc0a54556 ("md: use mddev_suspend/resume instead of ->quiesce()") > We still have similar left in bitmap functions. > > Replace quiesce() with mddev_suspend/resume. > > Also move md_bitmap_create out of mddev_suspend

Re: [PATCH RESEND 3/6] arm64: add sysfs vulnerability show for spectre v1

2018-09-18 Thread Will Deacon
On Mon, Sep 17, 2018 at 07:22:07PM +0200, Robert Richter wrote: > On 27.08.18 16:33:07, Mian Yousaf Kaukab wrote: > > Hard-coded since patches are merged and there are no configuration > > options. > > Could you add a list of upstream patches to the description that are > required to solve this? T

Re: [PATCH] ASoC: remove redundant include

2018-09-18 Thread Charles Keepax
On Tue, Sep 18, 2018 at 04:16:24PM +0800, zhong jiang wrote: > module.h already contained moduleparam.h, so it is safe to remove > the redundant include. > > The issue is detected with the help of Coccinelle. > > Signed-off-by: zhong jiang > --- For the Wolfson bits: Acked-by: Charles Keepax

Re: [PATCH V5 1/3] irqchip: add C-SKY irqchip drivers

2018-09-18 Thread Guo Ren
On Mon, Sep 17, 2018 at 02:27:31PM +0100, Marc Zyngier wrote: > On Mon, 17 Sep 2018 03:09:29 +0100, > Guo Ren wrote: > > [...] > > > > > + > > > > + irq_set_default_host(root_domain); > > > > > > Please drop this. There is no reason to use this on any modern, DT > > > based architecture.

Re: linux-next: manual merge of the net-next tree with the net tree

2018-09-18 Thread Daniel Borkmann
On 09/18/2018 02:11 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > tools/testing/selftests/net/tls.c > > between commit: > > 50c6b58a814d ("tls: fix currently broken MSG_PEEK behavior") > > from the net tree and commit: > >

[PATCH 1/4] kbuild: remove VERSION and PATCHLEVEL from $(objtree)/Makefile

2018-09-18 Thread Masahiro Yamada
Neither VERSION nor PATCHLEVEL is used in any useful way. Signed-off-by: Masahiro Yamada --- Makefile | 3 +-- scripts/mkmakefile | 6 -- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/Makefile b/Makefile index d2976b5..6e1a059 100644 --- a/Makefile +++ b/Makefile @

[PATCH 4/4] kbuild: simplify command line creation in scripts/mkmakefile

2018-09-18 Thread Masahiro Yamada
Assuming we never invoke the generated Makefile from outside of the $(objtree) directory, $(CURDIR) points to the absolute path of $(objtree). BTW, 'lastword' is natively supported by GNU Make 3.81+, which is the current requirement for building the kernel. Signed-off-by: Masahiro Yamada --- s

[PATCH 3/4] kbuild: do not pass $(objtree) to scripts/mkmakefile

2018-09-18 Thread Masahiro Yamada
Since $(objtree) is always '.', it is not useful to pass it to scripts/mkmakefile. I assume nobody wants to run this script directly. Signed-off-by: Masahiro Yamada --- Makefile | 2 +- scripts/mkmakefile | 7 +++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Mak

[PATCH 2/4] kbuild: remove user ID check in scripts/mkmakefile

2018-09-18 Thread Masahiro Yamada
This line was added by commit fd5f0cd6b0ce ("kbuild: Do not overwrite makefile as anohter user"). Its commit description says the intention was to prevent $(objtree)/Makefile from being owned by root when e.g. running 'make install'. However, as commit 19514fc665ff ("arm, kbuild: make "make insta

[PATCH] misc: remove redundant include moduleparam.h

2018-09-18 Thread zhong jiang
module.h already contains moduleparam.h, so it is safe to remove the redundant include. The issue is detected with the help of Coccinelle. eePlease enter the commit message for your changes. Lines starting Signed-off-by: zhong jiang --- drivers/misc/mei/bus-fixup.c | 1 - drivers/misc/vm

RE: [PATCH] misc: remove redundant include moduleparam.h

2018-09-18 Thread Winkler, Tomas
> module.h already contains moduleparam.h, so it is safe to remove the > redundant include. > > The issue is detected with the help of Coccinelle. > > eePlease enter the commit message for your changes. Lines starting > > Signed-off-by: zhong jiang > --- > drivers/misc/mei/bus-fixup.c |

[LKP] [vfree, kvfree] a79ed8bfb2: BUG:sleeping_function_called_from_invalid_context_at_mm/util.c

2018-09-18 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-6): commit: a79ed8bfb24e899aa55de42703ae4508ff016311 ("[PATCH 3/3] vfree, kvfree: Add debug might sleeps.") url: https://github.com/0day-ci/linux/commits/Andrey-Ryabinin/kvfree-Fix-misleading-comment/20180915-094734 in testcase: trinity with

Re: [PATCH] misc: remove redundant include moduleparam.h

2018-09-18 Thread Greg KH
On Tue, Sep 18, 2018 at 04:34:42PM +0800, zhong jiang wrote: > module.h already contains moduleparam.h, so it is safe to remove > the redundant include. > > The issue is detected with the help of Coccinelle. > > eePlease enter the commit message for your changes. Lines starting Odd line to have

Re: [RFC/PATCH 4/5] gpiolib: add support for fetching descriptors from static properties

2018-09-18 Thread Mika Westerberg
Hi, On Mon, Sep 17, 2018 at 11:16:02AM -0700, Dmitry Torokhov wrote: > Now that static device properties understand notion of child nodes, let's > teach gpiolib to tie such children and machine GPIO descriptor tables. > We will continue using a single table for entire device, but instead of > usin

Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 12:50 PM, Greg Kroah-Hartman wrote: On Tue, Sep 18, 2018 at 12:28:39PM +0530, Sai Prakash Ranjan wrote: On 9/18/2018 11:41 AM, Jiri Slaby wrote: On 09/17/2018, 11:33 PM, Matthias Kaehlcke wrote: sysrq_handle_crash() dereferences a NULL pointer on purpose to force an exception, the

Re: [PATCH 14/33] vfs: Implement a filesystem superblock creation/configuration context [ver #11]

2018-09-18 Thread Sergey Senozhatsky
Hi, On (09/11/18 16:54), Guenter Roeck wrote: > On Wed, Sep 12, 2018 at 12:17:35AM +0100, David Howells wrote: > > Guenter Roeck wrote: > > > > > [8.507672] RIP: 0010:reconfigure_super+0x47/0x210 > > > > Can you tell me the file and line this corresponds to? > > > I don't know, but some de

Re: [PATCH] misc: remove redundant include moduleparam.h

2018-09-18 Thread zhong jiang
On 2018/9/18 16:55, Greg KH wrote: > On Tue, Sep 18, 2018 at 04:34:42PM +0800, zhong jiang wrote: >> module.h already contains moduleparam.h, so it is safe to remove >> the redundant include. >> >> The issue is detected with the help of Coccinelle. >> >> eePlease enter the commit message for your

[PATCH v2] misc: remove redundant include moduleparam.h

2018-09-18 Thread zhong jiang
module.h already contains moduleparam.h, so it is safe to remove the redundant include. The issue is detected with the help of Coccinelle. Signed-off-by: zhong jiang --- drivers/misc/mei/bus-fixup.c | 1 - drivers/misc/vmw_vmci/vmci_host.c | 1 - 2 files changed, 2 deletions(-) diff --gi

Re: soundwire fixes for v4.19

2018-09-18 Thread Greg KH
On Wed, Sep 12, 2018 at 03:27:42PM +0530, Vinod wrote: > Hi Greg, > > Please pull to receive soundwire fixes for 4.19, these include stream > state and lock fix on release. > > The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: > > Linux 4.19-rc1 (2018-08-26 14:11:59

Re: [BUG] mm: direct I/O (using GUP) can write to COW anonymous pages

2018-09-18 Thread Konstantin Khlebnikov
On 18.09.2018 03:35, Jann Horn wrote: On Tue, Sep 18, 2018 at 2:05 AM Hugh Dickins wrote: Hi Jann, On Mon, 17 Sep 2018, Jann Horn wrote: [I'm not sure who the best people to ask about this are, I hope the recipient list resembles something reasonable...] I have noticed that the dup_mmap()

Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global

2018-09-18 Thread Greg Kroah-Hartman
On Tue, Sep 18, 2018 at 02:35:02PM +0530, Sai Prakash Ranjan wrote: > On 9/18/2018 12:50 PM, Greg Kroah-Hartman wrote: > > On Tue, Sep 18, 2018 at 12:28:39PM +0530, Sai Prakash Ranjan wrote: > > > On 9/18/2018 11:41 AM, Jiri Slaby wrote: > > > > On 09/17/2018, 11:33 PM, Matthias Kaehlcke wrote: > >

Re: [PATCH] docs: fix some broken documentation references

2018-09-18 Thread Jan Kara
On Mon 17-09-18 15:02:34, Mauro Carvalho Chehab wrote: > Some documentation files received recent changes and are > pointing to wrong places. > > Those references can easily fixed with the help of a > script: > > $ ./scripts/documentation-file-ref-check --fix > > Signed-off-by: Mauro Carva

[PATCH 1/5] RISC-V: Build tishift only on 64-bit

2018-09-18 Thread Zong Li
Only RV64 supports 128 integer size. Signed-off-by: Zong Li --- arch/riscv/lib/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/riscv/lib/Makefile b/arch/riscv/lib/Makefile index 445ec84..5739bd0 100644 --- a/arch/riscv/lib/Makefile +++ b/arch/riscv/lib/Makefil

[PATCH 0/5] Fix some bugs on RV32 build fail and issue.

2018-09-18 Thread Zong Li
This patches fix up the building fail, less function and other issue on RV32. Vincent Chen (1): RISC-V: Avoid corrupting the upper 32-bit of phys_addr_t in ioremap Zong Li (4): RISC-V: Build tishift only on 64-bit RISC-V: Use swiotlb on RV64 only lib: Add umoddi3 and udivmoddi4 of GCC lib

[PATCH 2/5] RISC-V: Use swiotlb on RV64 only

2018-09-18 Thread Zong Li
Only RV64 supports swiotlb. Signed-off-by: Zong Li --- arch/riscv/kernel/setup.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c index aee6031..872a280 100644 --- a/arch/riscv/kernel/setup.c +++ b/arch/riscv/kernel/setup.c @@ -227,7 +2

[PATCH 3/5] lib: Add umoddi3 and udivmoddi4 of GCC library routines

2018-09-18 Thread Zong Li
Add umoddi3 and udivmoddi4 support for 32-bit. Signed-off-by: Zong Li --- lib/Kconfig | 3 + lib/Makefile | 1 + lib/udivmoddi4.c | 291 +++ lib/umoddi3.c| 16 +++ 4 files changed, 311 insertions(+) create mode 100644 lib/udi

[PATCH 4/5] RISC-V: Select GENERIC_LIB_UMODDI3 on RV32

2018-09-18 Thread Zong Li
On 32-bit, it need to use __umoddi3 by some drivers. Signed-off-by: Zong Li --- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index a344980..dc262fa 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -108,6 +108,7 @@ confi

[PATCH 5/5] RISC-V: Avoid corrupting the upper 32-bit of phys_addr_t in ioremap

2018-09-18 Thread Zong Li
From: Vincent Chen For 32bit, the upper 32-bit of phys_addr_t will be flushed to zero after AND with PAGE_MASK because the data type of PAGE_MASK is unsigned long. To fix this problem, the page alignment is done by subtracting the page offset instead of AND with PAGE_MASK. Signed-off-by: Vincent

[PATCH 1/3] dt-bindings: spi: Provide bindings for fsl dspi working in slave mode

2018-09-18 Thread Lukasz Majewski
This commit provides the description of new property: "fsl,spi-slave-mode" which enables support for DSPI driver working in slave mode. As the new compatible shall be used with SPI bus equipped with master device a new "spidev" based node has been introduced to avoid confusion. Signed-off-by: Luk

[PATCH 0/3] ARM: dspi: Provide slave mode support for Vybryd vf610

2018-09-18 Thread Lukasz Majewski
This patch series provides support for DSPI slave mode operation. It tries to maximally reuse current DMA driver (including its limitations). For testing the spidev_test program has been used. Test script for this patch can be found here: https://github.com/lmajewski/tests-spi/blob/master/tests/sp

[PATCH 3/3] ARM: dspi: Provide support for DSPI slave more operation (Vybryd vf610)

2018-09-18 Thread Lukasz Majewski
The NXP's Vybryd vf610 can work as a SPI slave device (the CS and clock signal are provided by master). It is possible to specify a single device to work in that mode. As we do use DMA for transferring data, the RX channel must be prepared for incoming data. Moreover, in slave mode we just set a s

Re: [PATCH v4] USB: serial: ftdi_sio: implement GPIO support for FT-X devices

2018-09-18 Thread Karoly Pados
>> + goto out_free; >> + >> + /* Chip-type guessing logic based on libftdi. */ >> + priv->gc.ngpio = 4; /* FT230X, FT231X */ >> + if (le16_to_cpu(serial->dev->descriptor.bcdDevice) != 0x1000) >> + priv->gc.ngpio = 1; /* FT234XD */ > > As I mentioned in my last mail: I've asked FTDI about this, but

[PATCH 2/3] ARM: dspi: Provide per DSPI instance of the MCR register (SLAVE mode)

2018-09-18 Thread Lukasz Majewski
The vf610 Vybryd can work in two DSPI modes - namely master and slave. Already we do support master mode. This commit serves as a prerequisite to add support for slave mode. For slave mode we do need to preserve the MCR register value to change its "mode" bit (31) according to the supported state.

[PATCH v3 00/20] tpm: separate tpm 1.x and tpm 2.x commands

2018-09-18 Thread Tomas Winkler
This patch series provides initial separation of tpm 1.x and tpm 2.x commands, in foresight that the tpm 1.x chips will eventually phase out and can be compiled out for modern systems. A new file is added tpm1-cmd.c that contains tpm 1.x specific commands. In addition, tpm 1.x commands are now imp

[PATCH v3 18/20] tpm: use u32 instead of int for pcr index

2018-09-18 Thread Tomas Winkler
TPM pcr indices cannot be negative, also the tpm commands accept u32 number as a pcr index. 1. Adjust the API to use u32 instead of int in all pcr related functions. 2. Rename tpm1_pcr_read_dev to tpm1_pcr_read() to match the counterpart tpm2_pcr_read() 3. Remove redundant constants in tpm1_pcr_ex

[PATCH v3 05/20] tpm: factor out tpm_get_timeouts

2018-09-18 Thread Tomas Winkler
Factor out tpm_get_timeouts into tpm2_get_timeouts and tpm1_get_timeouts. Signed-off-by: Tomas Winkler --- V2-V3: Rebase drivers/char/tpm/tpm-interface.c | 127 ++- drivers/char/tpm/tpm.h | 5 +- drivers/char/tpm/tpm1-cmd.c | 106 +

[PATCH v3 20/20] tpm1: reimplement tpm1_continue_selftest() using tpm_buf

2018-09-18 Thread Tomas Winkler
Reimplement tpm1_continue_selftest() using tpm_buf structure. This is the last command using the old tpm_cmd_t structure and now the structure can be removed. Signed-off-by: Tomas Winkler --- V3: new in the series drivers/char/tpm/tpm.h | 9 - drivers/char/tpm/tpm1-cmd.c | 16 +

[PATCH v3 09/20] tpm: move tpm1 selftest code from tpm-interface tpm1-cmd.c

2018-09-18 Thread Tomas Winkler
Move the tpm1 selftest code functions to tpm1-cmd.c and adjust callers to use the new function names. 1. tpm_pcr_read_dev to tpm1_pcr_read_dev 2. tpm_continue_selftest to tpm1_continue_selftest 3. tpm_do_selftest to tpm1_do_selftest Signed-off-by: Tomas Winkler --- V2-V3: Rebase drivers/char

[PATCH v3 03/20] tpm: factor out tpm 1.x duration calculation to tpm1-cmd.c

2018-09-18 Thread Tomas Winkler
Factor out tpm 1.x commands calculation into tpm1-cmd.c file. and change the prefix from tpm_ to tpm1_. No functional change is done here. Signed-off-by: Tomas Winkler --- V2-V3: Rebase drivers/char/tpm/Makefile| 1 + drivers/char/tpm/st33zp24/st33zp24.c | 2 +- drivers/char/tpm/

[PATCH v3 02/20] tpm: sort objects in the Makefile

2018-09-18 Thread Tomas Winkler
Make the tpm Makefile a bit more in order by putting objects in one column and group together tpm2 modules Signed-off-by: Tomas Winkler --- V2: 1. back to tpm-y notation 2. Partially sort files alphanumerically. V3: Rebase drivers/char/tpm/Makefile | 15 --- 1 file changed, 12 i

[PATCH v3 16/20] tpm: tpm1: rewrite tpm1_get_random() using tpm_buf structure

2018-09-18 Thread Tomas Winkler
1. Use tpm_buf in tpm1_get_random() 2. Fix comment in tpm_get_random() so it is clear that the function is expected to return number of random bytes. Signed-off-by: Tomas Winkler --- V3: new in the series drivers/char/tpm/tpm-interface.c | 2 +- drivers/char/tpm/tpm.h | 11 -- dri

[PATCH v3 15/20] tpm: tpm-space.c remove unneeded semicolon

2018-09-18 Thread Tomas Winkler
Remove unneeded semicolon in tpm2_map_response_header() Signed-off-by: Tomas Winkler --- V3: new in the series drivers/char/tpm/tpm2-space.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm2-space.c b/drivers/char/tpm/tpm2-space.c index d2e101b32482..dcdfd

[PATCH v3 01/20] tpm2: add new tpm2 commands according to TCG 1.36

2018-09-18 Thread Tomas Winkler
1. TPM2_CC_LAST has moved from 182 to 193 2. Convert tpm2_ordinal_duration from an array into a switch statement, as there are not so many commands that require special duration relative to a number of commands. Signed-off-by: Tomas Winkler --- V2-V3: Rebase. drivers/char/tpm/tpm.h |

[PATCH v3 19/20] tpm1: reimplement SAVESTATE using tpm_buf

2018-09-18 Thread Tomas Winkler
In tpm1_pm_suspend() function reimplement, TPM_ORD_SAVESTATE comamnd using tpm_buf. Signed-off-by: Tomas Winkler --- V3: new in the series drivers/char/tpm/tpm1-cmd.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/char/tpm/tpm1-cmd.c b/drive

[PATCH v3 17/20] tpm1: implement tpm1_pcr_read_dev() using tpm_buf structure

2018-09-18 Thread Tomas Winkler
Implement tpm1_pcr_read_dev() using tpm_buf and remove now unneeded structures from tpm.h Signed-off-by: Tomas Winkler --- V3: new in the series drivers/char/tpm/tpm.h | 18 ++ drivers/char/tpm/tpm1-cmd.c | 38 +- 2 files changed, 23 inser

[PATCH v3 04/20] tpm: add tpm_calc_ordinal_duration wrapper

2018-09-18 Thread Tomas Winkler
Add convenient wrapper for ordinal duration computation to remove boiler plate if else statement over TPM2. if (chip->flags & TPM_CHIP_FLAG_TPM2) tpm2_calc_ordinal_duration(chip, ordinal); else tpm1_calc_ordinal_duration(chip, ordinal); Signed-off-by: Tomas Winkler --- V2-V3: Reb

[PATCH v3 14/20] tpm: tpm-interface.c drop unused macros

2018-09-18 Thread Tomas Winkler
The code movement left some macros unused. Signed-off-by: Tomas Winkler --- V3: new in the series drivers/char/tpm/tpm-interface.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c index a8f8e0bcb434..358ef5bd601e 100644 -

[PATCH v3 07/20] tpm: move tpm_getcap to tpm1-cmd.c

2018-09-18 Thread Tomas Winkler
1. Move tpm_getcap to tpm1-cmd. Rename the function to tpm1_getcap. 2. Remove unused tpm_getcap_header with unused constant as this functionality is already implemented using tpm_buf construct. Fixes warning: drivers/char/tpm/tpm-interface.c:452:38: warning: ‘tpm_getcap_header’ defined but not us

[PATCH v3 12/20] tpm: move pcr extend code to tpm2-cmd.c

2018-09-18 Thread Tomas Winkler
Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required by tpm-interface.c. It wraps the original open code implementation. The original original tpm2_pcr_extend() function is renamed and made static, called only from new tpm2_pcr_extend() Signed-off-by: Tomas Winkler --- V3: fix com

[PATCH v3 10/20] tpm: factor out tpm1 pm suspend flow into tpm1-cmd.c

2018-09-18 Thread Tomas Winkler
Factor out tpm1 suspend flow from tpm-interface.c into a new function tpm1_pm_suspend in tpm1-cmd.c Signed-off-by: Tomas Winkler --- V2-V3: Rebase drivers/char/tpm/tpm-interface.c | 55 drivers/char/tpm/tpm.h | 1 + drivers/char/tpm/tpm1-cmd.c

[PATCH v3 06/20] tpm: move tpm1_pcr_extend to tpm1-cmd.c

2018-09-18 Thread Tomas Winkler
Move tpm1_pcr_extend to tpm1-cmd.c and remove unused pcrextend_header structure. Fixes warning: drivers/char/tpm/tpm-interface.c:609:38: warning: ‘pcrextend_header’ defined but not used [-Wunused-const-variable=] static const struct tpm_input_header pcrextend_header = {

[PATCH v3 11/20] tpm: factor out tpm_startup function

2018-09-18 Thread Tomas Winkler
tpm manual startup is used only from within tpm1 or tpm2 code, hence remove tpm_startup function from tpm-interface.c and add two static functions implementations tpm1_startup and tpm2_startup into to tpm1-cmd.c and tpm2-cmd.c respectively. Signed-off-by: Tomas Winkler --- V2-V3: Rebase drivers

[PATCH v3 08/20] tpm: factor out tpm1_get_random into tpm1-cmd.c

2018-09-18 Thread Tomas Winkler
Factor out get random implementation from tpm-interface.c into tpm1_get_random function in tpm1-cmd.c. No functional changes. Signed-off-by: Tomas Winkler --- V2-V3: Rebase drivers/char/tpm/tpm-interface.c | 58 +--- drivers/char/tpm/tpm.h | 1 + d

[PATCH v3 13/20] tpm: add tpm_auto_startup into tpm-interface

2018-09-18 Thread Tomas Winkler
Add wrapper tpm_auto_startup() to tpm-interface.c instead of open coded decision between tpm 1.2 and tpm 2.0 in tpm-chip.c Signed-off-by: Tomas Winkler --- V3: new in the series drivers/char/tpm/tpm-chip.c | 11 +++ drivers/char/tpm/tpm-interface.c | 15 +++ drivers/cha

Re: [PATCH 14/33] vfs: Implement a filesystem superblock creation/configuration context [ver #11]

2018-09-18 Thread Sergey Senozhatsky
On (09/18/18 18:07), Sergey Senozhatsky wrote: > emergency_remount() > do_emergency_remount() > do_emergency_remount_callback() >reconfigure_super() > > At fc->ops dereference: > > 981 if (fc->ops->reconfigure) { > ^ > 982 retval = fc->ops->r

Re: [PATCH v4 2/2] pci: dwc: pci-dra7xx: Enable errata i870 for both EP and RC mode

2018-09-18 Thread Lorenzo Pieralisi
On Mon, Sep 17, 2018 at 11:36:35PM +0530, Vignesh R wrote: > Errata i870 is applicable in both EP and RC mode. Therefore rename > function dra7xx_pcie_ep_unaligned_memaccess(), that implements errata > workaround, to dra7xx_pcie_unaligned_memaccess() and call it from a > common place. So, that erra

Re: [PATCH v3 2/2] [media] videobuf2-dc: Support cacheable MMAP

2018-09-18 Thread Tomasz Figa
Hi Hans, On Mon, Sep 17, 2018 at 11:41 PM Hans Verkuil wrote: > > I'm going through old patches in patchwork that fell through the > cracks, and this is one of them. > > If this is still desired, please rebase and repost. > > I'm marking this series as Obsoleted in patchwork, since it no longer >

Re: [PATCH 0/3] ARM: dspi: Provide slave mode support for Vybryd vf610

2018-09-18 Thread Lukasz Majewski
Dear All, By a mistake I've forgotten to add (to CC/TO) some developers who worked on this driver before (they were not generated from get_maintainers.py script). I'm sending the notification now. > This patch series provides support for DSPI slave mode operation. > It tries to maximally reuse c

Re: [LKP] [vfree, kvfree] a79ed8bfb2: BUG:sleeping_function_called_from_invalid_context_at_mm/util.c

2018-09-18 Thread Andrey Ryabinin
On 09/18/2018 11:52 AM, kernel test robot wrote: > > [3.265372] BUG: sleeping function called from invalid context at > mm/util.c:449 > [3.288552] in_atomic(): 0, irqs_disabled(): 0, pid: 142, name: > rhashtable_thra > [3.301548] INFO: lockdep is turned off. > [3.302214] Preempt

RE: [PATCH v2] fanotify reports the thread id of the event trigger

2018-09-18 Thread Nixiaoming
On Tue, Sep 18, 2018 3:07 PM Amir Goldstein >On Tue, Sep 18, 2018 at 6:01 AM Nixiaoming wrote: >> >> On Mon, Sep 17, 2018 11:51 PM Amir Goldstein wrote: >> >On Mon, Sep 17, 2018 at 6:05 PM nixiaoming wrote: >... >> >> diff --git a/include/linux/fsnotify_backend.h >> >> b/include/linux/fsnotify

  1   2   3   4   5   6   7   >