Re: [PATCH v5 18/20] iommu/mediatek: Fix VLD_PA_RANGE register backup when suspend

2019-01-30 Thread Evan Green
On Mon, Dec 31, 2018 at 8:00 PM Yong Wu wrote: > > The register VLD_PA_RNG(0x118) was forgot to backup while adding 4GB > mode support for mt2712. this patch add it. > > Fixes: 30e2fccf9512 ("iommu/mediatek: Enlarge the validate PA range > for 4GB mode") > Signed-off-by: Yong Wu Reviewed-by:

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 06:56:59PM +, Jason Gunthorpe wrote: > On Wed, Jan 30, 2019 at 10:17:27AM -0700, Logan Gunthorpe wrote: > > > > > > On 2019-01-29 9:18 p.m., Jason Gunthorpe wrote: > > > Every attempt to give BAR memory to struct page has run into major > > > trouble, IMHO, so I like

Re: [PATCH 2/2] mm: Consider subtrees in memory.events

2019-01-30 Thread Johannes Weiner
On Mon, Jan 28, 2019 at 01:51:51PM +0100, Michal Hocko wrote: > On Fri 25-01-19 10:28:08, Tejun Heo wrote: > > On Fri, Jan 25, 2019 at 06:37:13PM +0100, Michal Hocko wrote: > > > Please note that I understand that this might be confusing with the rest > > > of the cgroup APIs but considering that

Re: [PATCH v5 19/20] iommu/mediatek: Add shutdown callback

2019-01-30 Thread Evan Green
On Mon, Dec 31, 2018 at 8:00 PM Yong Wu wrote: > > In the reboot burning test, if some Multimedia HW has something wrong, > It may keep send the invalid request to IOMMU. In order to avoid > affect the reboot flow, we add the shutdown callback to disable > M4U HW when shutdown. Sounds

Re: [PATCH 7/7] arm64: dts: qcom: qcs404: Add PCIe related nodes

2019-01-30 Thread Stephen Boyd
Quoting Bjorn Andersson (2019-01-25 15:45:09) > @@ -771,6 +788,56 @@ > status = "disabled"; > }; > }; > + > + pcie: pci@1000 { > + compatible = "qcom,pcie-qcs404", "snps,dw-pcie"; > +

Re: [PATCH 1/7] clk: gcc-qcs404: Add PCIe resets

2019-01-30 Thread Stephen Boyd
Quoting Bjorn Andersson (2019-01-25 15:45:03) > Enabling PCIe requires several of the PCIe related resets from GCC, so > add them all. > > Signed-off-by: Bjorn Andersson > --- Acked-by: Stephen Boyd

Re: [PATCH v5 17/20] memory: mtk-smi: Get rid of need_larbid

2019-01-30 Thread Evan Green
On Mon, Dec 31, 2018 at 7:59 PM Yong Wu wrote: > > The "mediatek,larb-id" has already been parsed in MTK IOMMU driver. > It's no need to parse it again in SMI driver. Only clean some codes. > This patch is fit for all the current mt2701, mt2712, mt7623, mt8173 > and mt8183. > > After this patch,

Re: [PATCH v9 3/3] mm: Maintain randomization of page free lists

2019-01-30 Thread Dan Williams
On Wed, Jan 30, 2019 at 11:11 AM Michal Hocko wrote: > > On Tue 29-01-19 21:02:26, Dan Williams wrote: > > When freeing a page with an order >= shuffle_page_order randomly select > > the front or back of the list for insertion. > > > > While the mm tries to defragment physical pages into huge

Re: [PATCH v3 0/3] update infiniband uverbs documentation

2019-01-30 Thread Jonathan Corbet
On Wed, 30 Jan 2019 14:57:21 +0200 "Joel Nider" wrote: > Have you had a chance to review this patchset? I've been mostly away from the keyboard for the last week; will be back and dealing with things soon. Thanks, jon

Re: [PATCH] MAINTAINERS: add myself as maintainer of ibmvmc driver

2019-01-30 Thread Steven Royer
Thanks for taking over Brad! On 2019-01-25 17:36, Brad Warrum wrote: Steve Royer has moved on to another project and has requested that I maintain the IBM Power Virtual Management Channel driver in his stead. Cc: Steve Royer Signed-off-by: Brad Warrum --- MAINTAINERS | 2 +- 1 file changed,

Re: [PATCH 2/2] mm: Consider subtrees in memory.events

2019-01-30 Thread Johannes Weiner
On Wed, Jan 30, 2019 at 11:11:44AM -0800, Shakeel Butt wrote: > Hi Tejun, > > On Wed, Jan 30, 2019 at 9:07 AM Tejun Heo wrote: > > > > Hello, Michal. > > > > On Wed, Jan 30, 2019 at 05:50:58PM +0100, Michal Hocko wrote: > > > > Yeah, cgroup.events and .stat files as some of the local stats would

Re: [PATCH 2/2] clk: aspeed: Setup video engine clocking

2019-01-30 Thread Stephen Boyd
Quoting Eddie James (2018-12-14 07:47:53) > > > On 12/13/2018 07:02 PM, Joel Stanley wrote: > > > > >> + { 0x0, 2 }, > >> + { 0x1, 2 }, > >> + { 0x2, 3 }, > >> + { 0x3, 4 }, > >> + { 0x4, 5 }, > >> + { 0x5, 6 }, > >> + { 0x6, 7 }, > >> + { 0x7, 8

Re: [PATCH 2/2] mm: Consider subtrees in memory.events

2019-01-30 Thread Johannes Weiner
On Wed, Jan 30, 2019 at 02:27:12PM -0500, Johannes Weiner wrote: > On Wed, Jan 30, 2019 at 11:11:44AM -0800, Shakeel Butt wrote: > > Hi Tejun, > > > > On Wed, Jan 30, 2019 at 9:07 AM Tejun Heo wrote: > > > > > > Hello, Michal. > > > > > > On Wed, Jan 30, 2019 at 05:50:58PM +0100, Michal Hocko

Re: [PATCH 4.14 00/68] 4.14.97-stable review

2019-01-30 Thread Greg Kroah-Hartman
On Wed, Jan 30, 2019 at 08:49:34PM +0200, Amir Goldstein wrote: > On Wed, Jan 30, 2019 at 2:55 PM Naresh Kamboju > wrote: > > > > On Tue, 29 Jan 2019 at 17:19, Greg Kroah-Hartman > > wrote: > > > > > > This is the start of the stable review cycle for the 4.14.97 release. > > > There are 68

Re: [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions

2019-01-30 Thread Greg Kroah-Hartman
On Wed, Jan 30, 2019 at 06:21:02PM +, Will Deacon wrote: > Hi Greg, > > On Tue, Jan 22, 2019 at 03:41:11PM +0100, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > >

Re: ARM64 suggestion: reduce the compat address limit (currently 0x100000000)?

2019-01-30 Thread Jann Horn
On Wed, Jan 30, 2019 at 7:22 PM Will Deacon wrote: > On Wed, Jan 30, 2019 at 05:32:00PM +0100, Jann Horn wrote: > > At the moment, compat tasks running on ARM64 can allocate memory up to > > 0x1 (TASK_SIZE_32). Testing on an Android device (with an > > admittedly somewhat old kernel): > >

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-30 Thread Jacek Anaszewski
Hi Dan, Thank you for the RFC. One vital thing is missing - documentation of brightness file must be updated to define its semantics for LED multi color class. Either we need brightness-model file returning only "onoff" option available, or, for time being, fix the max_brightness for LED multi

Re: [PATCH 2/2] mm: Consider subtrees in memory.events

2019-01-30 Thread Shakeel Butt
On Wed, Jan 30, 2019 at 11:30 AM Johannes Weiner wrote: > > On Wed, Jan 30, 2019 at 02:27:12PM -0500, Johannes Weiner wrote: > > On Wed, Jan 30, 2019 at 11:11:44AM -0800, Shakeel Butt wrote: > > > Hi Tejun, > > > > > > On Wed, Jan 30, 2019 at 9:07 AM Tejun Heo wrote: > > > > > > > > Hello,

Re: [PATCH] nfit: Collect shutdown status for NVDIMM_FAMILY_HYPERV

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 06:48:40PM +, Dexuan Cui wrote: > > See http://www.uefi.org/RFIC_LIST ("Virtual NVDIMM 0x1901"): > "Get Unsafe Shutdown Count (Function Index 2)". > > Let's expose the info to the userspace (e.g. ntctl) via sysfs. If you add a new sysfs file, you need to add a new

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jason Gunthorpe
On Wed, Jan 30, 2019 at 02:22:34PM -0500, Jerome Glisse wrote: > For GPU it would not work, GPU might want to use main memory (because > it is running out of BAR space) it is a lot easier if the p2p_map > callback calls the right dma map function (for page or io) rather than > having to define

Re: [PATCH v2 ] PM-runtime: fix deadlock with ktime

2019-01-30 Thread Ladislav Michl
On Wed, Jan 30, 2019 at 02:18:49PM +0100, Vincent Guittot wrote: > On Wed, 30 Jan 2019 at 14:06, Rafael J. Wysocki wrote: > > > > On Wed, Jan 30, 2019 at 12:16 PM Vincent Guittot > > wrote: > > > > > > A deadlock has been seen when swicthing clocksources which use PM runtime. > > > The call path

Re: [PATCH v2] mic: vop: Fix broken virtqueues

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 05:28:09PM +0100, Vincent Whitchurch wrote: > VOP is broken in mainline since commit 1ce9e6055fa0a9043 ("virtio_ring: > introduce packed ring support"); attempting to use the virtqueues leads > to various kernel crashes. I'm testing it with my not-yet-merged > loopback

Re: [PATCH v2 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-01-30 Thread Rob Herring
On Fri, Jan 25, 2019 at 11:22:56PM +0530, Vishal Sagar wrote: > Add bindings documentation for Xilinx MIPI CSI-2 Rx Subsystem. > > The Xilinx MIPI CSI-2 Rx Subsystem consists of a CSI-2 Rx controller, a > DPHY in Rx mode, an optional I2C controller and a Video Format Bridge. > > Signed-off-by:

Re: [PATCH v2 0/2] eeprom: at25: SPI transfer improvements

2019-01-30 Thread Greg Kroah-Hartman
On Wed, Jan 30, 2019 at 04:08:39PM +0100, Boris Brezillon wrote: > Hi Greg, > > On Wed, 30 Jan 2019 15:50:54 +0100 > Greg Kroah-Hartman wrote: > > > On Tue, Jan 29, 2019 at 08:02:37PM +0100, Geert Uytterhoeven wrote: > > > Hi Boris, > > > > > > On Fri, Jan 18, 2019 at 11:07 PM Boris Brezillon

Re: [PATCH v2 4/4] Irqchip: Ingenic: Add support for the X1000.

2019-01-30 Thread Rob Herring
On Sun, 27 Jan 2019 23:50:32 +0800, Zhou Yanjie wrote: > Add support for probing the irq-ingenic driver on the X1000 Soc. > > Signed-off-by: Zhou Yanjie > --- > Documentation/devicetree/bindings/interrupt-controller/ingenic,intc.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Logan Gunthorpe
On 2019-01-30 12:06 p.m., Jason Gunthorpe wrote: >> Way less problems than not having struct page for doing anything >> non-trivial. If you map the BAR to userspace with remap_pfn_range >> and friends the mapping is indeed very simple. But any operation >> that expects a page structure, which

Re: [PATCH v2 3/3] dt-bindings: clock: Add loongson-1 clock bindings

2019-01-30 Thread Rob Herring
On Mon, Jan 28, 2019 at 11:20:52PM +0800, Jiaxun Yang wrote: > Loongson-1 is a series of MIPS MCUs. > This patch add the clock bindings for loongson-1b and > loongson-1c clock subsystem. > > Signed-off-by: Jiaxun Yang > --- > .../bindings/clock/loongson1-clock.txt| 11 ++ >

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Logan Gunthorpe
On 2019-01-30 12:19 p.m., Jason Gunthorpe wrote: > On Wed, Jan 30, 2019 at 11:13:11AM -0700, Logan Gunthorpe wrote: >> >> >> On 2019-01-30 10:44 a.m., Jason Gunthorpe wrote: >>> I don't see why a special case with a VMA is really that different. >> >> Well one *really* big difference is the VMA

Re: [PATCH v2 1/2] dt-bindings: iio: imu: add icm20602 bindings to mpu6050

2019-01-30 Thread Rob Herring
On Mon, 28 Jan 2019 19:50:02 +0100, =?UTF-8?q?Randolph=20Maa=C3=9Fen?= wrote: > Adding the invensense ICM-20602 to the compatible list of the mpu6050 > driver > > Signed-off-by: Randolph Maaßen > > --- > Changes in v2: > - write i2c disable register using reg_set instead of define > - decide to

Re: [PATCH v2 2/4] mfd: max77620: add documentation for backup battery charging

2019-01-30 Thread Rob Herring
On Tue, Jan 29, 2019 at 04:55:29PM +0800, Mark Zhang wrote: > Adding documentation for 3 new backup battery charging dts > properties: > - maxim,backup-battery-charging-current > - maxim,backup-battery-charging-voltage > - maxim,backup-battery-output-resister > > Signed-off-by: Mark Zhang > ---

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Logan Gunthorpe
On 2019-01-30 12:22 p.m., Jerome Glisse wrote: > On Wed, Jan 30, 2019 at 06:56:59PM +, Jason Gunthorpe wrote: >> On Wed, Jan 30, 2019 at 10:17:27AM -0700, Logan Gunthorpe wrote: >>> >>> >>> On 2019-01-29 9:18 p.m., Jason Gunthorpe wrote: Every attempt to give BAR memory to struct page

Re: [PATCH v2 4/4] mfd: max77620: add documentation for low battery monitoring

2019-01-30 Thread Rob Herring
On Tue, Jan 29, 2019 at 04:55:31PM +0800, Mark Zhang wrote: > Adding documentation for low battery monitor properties: > - maxim,low-battery-dac-enable > - maxim,low-battery-dac-disable > - maxim,low-battery-shutdown-enable > - maxim,low-battery-shutdown-disable > - maxim,low-battery-reset-enable

Re: [PATCH] x86: avoid confusion over the new RESCTRL config prompt

2019-01-30 Thread Johannes Weiner
On Wed, Jan 30, 2019 at 06:19:33PM +0100, Borislav Petkov wrote: > On Wed, Jan 30, 2019 at 11:46:26AM -0500, Johannes Weiner wrote: > > This is still awefully close to the cgroup CPU resource > > controller. Since it's more hardware-specific, and the config symbol > > also has the x86 in it, how

Re: [PATCH v2 05/13] dt-bindings: leds: add DT bindings for max77650

2019-01-30 Thread Jacek Anaszewski
Hi Bartosz, Thank you for addressing my remarks. On 1/29/19 2:35 PM, Bartosz Golaszewski wrote: From: Bartosz Golaszewski Add the DT binding document for the LEDs module of max77650. Signed-off-by: Bartosz Golaszewski --- .../bindings/leds/leds-max77650.txt | 57

Re: [PATCH v2 0/2] USB SS PHY for Qualcomm's QCS404

2019-01-30 Thread Rob Herring
On Tue, Jan 29, 2019 at 12:35:13PM +0100, Jorge Ramirez-Ortiz wrote: > This set adds USB SS PHY support to Qualcomm's QCS404 SoC > The PHY is implemented using Synopsys SS PHY 1.0.0 IP > > The code is losely based on Sriharsha Allenki's > original implementation. > > v2: > enable OTG mode

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-30 Thread Dan Murphy
Jacek On 1/30/19 1:37 PM, Jacek Anaszewski wrote: > Hi Dan, > > Thank you for the RFC. > > One vital thing is missing - documentation of brightness file must > be updated to define its semantics for LED multi color class. > > Either we need brightness-model file returning only "onoff" option >

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jason Gunthorpe
On Wed, Jan 30, 2019 at 12:45:46PM -0700, Logan Gunthorpe wrote: > > > On 2019-01-30 12:06 p.m., Jason Gunthorpe wrote: > >> Way less problems than not having struct page for doing anything > >> non-trivial. If you map the BAR to userspace with remap_pfn_range > >> and friends the mapping is

Re: [PATCH v2 11/13] leds: max77650: add LEDs support

2019-01-30 Thread Jacek Anaszewski
Hi Bartosz, Thank you for the update. One more thing drew my attention, please refer below. On 1/29/19 2:35 PM, Bartosz Golaszewski wrote: From: Bartosz Golaszewski This adds basic support for LEDs for the max77650 PMIC. The device has three current sinks for driving LEDs. Signed-off-by:

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Logan Gunthorpe
On 2019-01-30 12:38 p.m., Jason Gunthorpe wrote: > On Wed, Jan 30, 2019 at 02:22:34PM -0500, Jerome Glisse wrote: > >> For GPU it would not work, GPU might want to use main memory (because >> it is running out of BAR space) it is a lot easier if the p2p_map >> callback calls the right dma map

Re: [PATCH v2 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings

2019-01-30 Thread Rob Herring
On Tue, Jan 29, 2019 at 12:35:14PM +0100, Jorge Ramirez-Ortiz wrote: > Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY > controller embedded in QCS404. > > Based on Sriharsha Allenki's original > definitions. > > Signed-off-by: Jorge Ramirez-Ortiz > --- >

RE: [PATCH] nfit: Collect shutdown status for NVDIMM_FAMILY_HYPERV

2019-01-30 Thread Dexuan Cui
> From: Greg KH > Sent: Wednesday, January 30, 2019 11:38 AM > > On Wed, Jan 30, 2019 at 06:48:40PM +, Dexuan Cui wrote: > > > > Let's expose the info to the userspace (e.g. ntctl) via sysfs. > > If you add a new sysfs file, you need to add a new Documentation/ABI/ > update as well :( It's

Re: [PATCH 2/2] mm: Consider subtrees in memory.events

2019-01-30 Thread Michal Hocko
On Wed 30-01-19 14:23:45, Johannes Weiner wrote: > On Mon, Jan 28, 2019 at 01:51:51PM +0100, Michal Hocko wrote: > > On Fri 25-01-19 10:28:08, Tejun Heo wrote: > > > On Fri, Jan 25, 2019 at 06:37:13PM +0100, Michal Hocko wrote: > > > > Please note that I understand that this might be confusing

RE: [PATCH] nfit: Collect shutdown status for NVDIMM_FAMILY_HYPERV

2019-01-30 Thread Dexuan Cui
> From: Linux-nvdimm On Behalf Of > Dexuan Cui > Sent: Wednesday, January 30, 2019 12:03 PM > To: Greg KH > Cc: Josh Poulson ; linux-nvd...@lists.01.org; > Haiyang Zhang ; > driverdev-de...@linuxdriverproject.org; Rafael J. Wysocki > ; linux-kernel@vger.kernel.org; Michael Kelley > ; Sasha Levin

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jason Gunthorpe
On Wed, Jan 30, 2019 at 01:00:02PM -0700, Logan Gunthorpe wrote: > We never changed SGLs. We still use them to pass p2pdma pages, only we > need to be a bit careful where we send the entire SGL. I see no reason > why we can't continue to be careful once their in userspace if there's > something

Re: [Letux-kernel] [PATCH] arm: dts: gta04: add gps support

2019-01-30 Thread Andreas Kemnade
On Wed, 30 Jan 2019 15:06:12 +0100 "H. Nikolaus Schaller" wrote: > Hi Andreas, > > > Am 30.01.2019 um 10:02 schrieb Johan Hovold : > > > > On Mon, Jan 28, 2019 at 05:44:29PM +0100, Andreas Kemnade wrote: > >> On Mon, 28 Jan 2019 08:53:56 +0100 > >> Johan Hovold wrote: > >> > >>> On Fri,

Re: [PATCH] sched/debug: initialize sd_sysctl_cpus if !CONFIG_CPUMASK_OFFSTACK

2019-01-30 Thread Peter Zijlstra
On Tue, Jan 29, 2019 at 10:12:45AM -0500, Masayoshi Mizuma wrote: > From: Hidetoshi Seto > > register_sched_domain_sysctl() copies the cpu_possible_mask into > sd_sysctl_cpus, but only if sd_sysctl_cpus hasn't already been > allocated (ie, CONFIG_CPUMASK_OFFSTACK is set). However, when >

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-30 Thread Jacek Anaszewski
Dan, On 1/30/19 8:59 PM, Dan Murphy wrote: Jacek On 1/30/19 1:37 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the RFC. One vital thing is missing - documentation of brightness file must be updated to define its semantics for LED multi color class. Either we need brightness-model file

Re: [PATCH RFC 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan

2019-01-30 Thread Stefan Wahren
Hi Guenter, > Guenter Roeck hat am 30. Januar 2019 um 18:28 > geschrieben: > > > On Wed, Jan 30, 2019 at 04:07:05PM +0100, Stefan Wahren wrote: > > This adds the tachometer interrupt to the pwm-fan binding, which is > > necessary for RPM support. > > > > Signed-off-by: Stefan Wahren > > ---

[PATCH] gfs2: Revert "Fix loop in gfs2_rbm_find"

2019-01-30 Thread Andreas Gruenbacher
This reverts commit 2d29f6b96d8f80322ed2dd895bca590491c38d34. It turns out that the fix can lead to a ~20 percent performance regression in initial writes to the page cache according to iozone. Let's revert this for now to have more time for a proper fix. Cc: sta...@vger.kernel.org # v3.13+

Re: [PATCH RFC 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan

2019-01-30 Thread Guenter Roeck
On Wed, Jan 30, 2019 at 09:23:31PM +0100, Stefan Wahren wrote: > Hi Guenter, > > > Guenter Roeck hat am 30. Januar 2019 um 18:28 > > geschrieben: > > > > > > On Wed, Jan 30, 2019 at 04:07:05PM +0100, Stefan Wahren wrote: > > > This adds the tachometer interrupt to the pwm-fan binding, which

[PATCH] nfit: Document sysfs interface dirty_shutdown

2019-01-30 Thread Dexuan Cui
The new sysfs node was added in Sep 2018 in: commit 0ead11181fe0 ("acpi, nfit: Collect shutdown status") Now let's document it. Signed-off-by: Dexuan Cui --- Documentation/ABI/testing/sysfs-bus-nfit | 8 1 file changed, 8 insertions(+) diff --git

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 12:52:44PM -0700, Logan Gunthorpe wrote: > > > On 2019-01-30 12:22 p.m., Jerome Glisse wrote: > > On Wed, Jan 30, 2019 at 06:56:59PM +, Jason Gunthorpe wrote: > >> On Wed, Jan 30, 2019 at 10:17:27AM -0700, Logan Gunthorpe wrote: > >>> > >>> > >>> On 2019-01-29 9:18

Re: System crash with perf_fuzzer (kernel: 5.0.0-rc3)

2019-01-30 Thread Andi Kleen
Jiri Olsa writes: > > the patch adds check_eriod pmu callback.. I need to check if there's > better way to do this, but so far it fixes the crash for me > > if you guys could check this patch, that'd be great There's already a limit_period callback, perhaps that could be extended. But ok, can do

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 08:11:19PM +, Jason Gunthorpe wrote: > On Wed, Jan 30, 2019 at 01:00:02PM -0700, Logan Gunthorpe wrote: > > > We never changed SGLs. We still use them to pass p2pdma pages, only we > > need to be a bit careful where we send the entire SGL. I see no reason > > why we

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jason Gunthorpe
On Wed, Jan 30, 2019 at 12:48:33PM -0700, Logan Gunthorpe wrote: > > > On 2019-01-30 12:19 p.m., Jason Gunthorpe wrote: > > On Wed, Jan 30, 2019 at 11:13:11AM -0700, Logan Gunthorpe wrote: > >> > >> > >> On 2019-01-30 10:44 a.m., Jason Gunthorpe wrote: > >>> I don't see why a special case with a

RE: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-01-30 Thread Liming Sun
Thanks Andy for the comments! Please also see my response inline. I do have a question about the "return value shadow an error" comment. Could you help take a look if I understand it correctly? Regards, Liming > -Original Message- > From: Andy Shevchenko > Sent: Tuesday, January 29,

[PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-01-30 Thread Callum Sinclair
Created a way to clear the multicast forwarding cache on a socket without having to either remove the entries manually using the delete entry socket option or destroy and recreate the multicast socket. Patch Set 2: - Fix Compile Errors Callum Sinclair (1): ipmr: ip6mr: Create new sockopt to

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jason Gunthorpe
On Wed, Jan 30, 2019 at 03:43:32PM -0500, Jerome Glisse wrote: > On Wed, Jan 30, 2019 at 08:11:19PM +, Jason Gunthorpe wrote: > > On Wed, Jan 30, 2019 at 01:00:02PM -0700, Logan Gunthorpe wrote: > > > > > We never changed SGLs. We still use them to pass p2pdma pages, only we > > > need to be

[PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-01-30 Thread Callum Sinclair
Currently the only way to clear the mfc cache was to delete the entries one by one using the MRT_DEL_MFC socket option or to destroy and recreate the socket. Create a new socket option which will clear the multicast forwarding cache on the socket without destroying the socket. Signed-off-by:

[PATCH net-next 06/12] net: hns3: Fix NULL deref when unloading driver

2019-01-30 Thread Huazhong Tan
When the driver is unloading, if there is a calling of ndo_open occurs between phy_disconnect() and unregister_netdev(), it will end up causing the kernel to eventually hit a NULL deref: [14942.417828] Unable to handle kernel NULL pointer dereference at virtual address 0048

RE: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-01-30 Thread Liming Sun
Thanks Vadim. Please see my response and questions below. Regards, Liming > -Original Message- > From: Vadim Pasternak > Sent: Wednesday, January 30, 2019 1:24 AM > To: Andy Shevchenko ; Liming Sun > > Cc: Andy Shevchenko ; Darren Hart ; > David Woods ; Platform > Driver ; Linux

[PATCH net-next 12/12] net: hns3: keep flow director state unchanged when reset

2019-01-30 Thread Huazhong Tan
From: Jian Shen In orginal codes, driver always enables flow director when intializing. When user disable flow director with command ethtool -K, the flow director will be enabled again after resetting. This patch fixes it by only enabling it when first initialzing. Fixes: 6871af29b3ab ("net:

[PATCH net-next 05/12] net: hns3: only support tc 0 for VF

2019-01-30 Thread Huazhong Tan
From: Yunsheng Lin When the VF shares the same TC config as PF, the business running on PF and VF must have samiliar module. For simplicity, we are not considering VF sharing the same tc configuration as PF use case, so this patch removes the support of TC configuration from VF and forcing VF

[PATCH net-next 02/12] net: hns3: fix VF dump register issue

2019-01-30 Thread Huazhong Tan
From: Jian Shen In original codes, the .get_regs_len and .get_regs were missed assigned. This patch fixes it. Fixes: 1600c3e5f23e ("net: hns3: Support "ethtool -d" for HNS3 VF driver") Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c

[PATCH net-next 01/12] net: hns3: reuse the definition of l3 and l4 header info union

2019-01-30 Thread Huazhong Tan
From: liyongxin Union l3_hdr_info and l4_hdr_info have already been defined in the hns3_enet.h, so it is unnecessary to define them elsewhere. This patch removes the redundant definition, and reuses the one defined in the hns3_enet.h. Signed-off-by: liyongxin Signed-off-by: Peng Li

[PATCH net-next 10/12] net: hns3: fix an issue for hclgevf_ae_get_hdev

2019-01-30 Thread Huazhong Tan
From: Peng Li HNS3 VF driver support NIC and Roce, hdev stores NIC handle and Roce handle, should use correct parameter for container_of. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 7 ++- 1 file changed, 6

[PATCH net-next 09/12] net: hns3: fix improper error handling in the hclge_init_ae_dev()

2019-01-30 Thread Huazhong Tan
While hclge_init_umv_space() failed in the hclge_init_ae_dev(), we should undo all the operation which has been done successfully, the last success operation maybe hclge_mac_mdio_config(), so if hclge_init_umv_space() failed, we also need to undo it. Fixes: 288475b2ad01 ("{topost} net: hns3:

[PATCH net-next 07/12] net: hns3: fix netif_napi_del() not do problem when unloading

2019-01-30 Thread Huazhong Tan
When the driver is unloading, if a global reset occurs, unmap_ring_from_vector() in the hns3_nic_uninit_vector_data() will fail, and hns3_nic_uninit_vector_data() just return. There may be some netif_napi_del() not be done. Since hardware will unmap all ring while resetting, so

[PATCH] crypto: ccp: fix the SEV probe in kexec boot path

2019-01-30 Thread Singh, Brijesh
A kexec reboot may leave the firmware in INIT or WORKING state. Currently, we issue PLATFORM_INIT command during the probe without checking the current state. The PLATFORM_INIT command fails if the FW is already in INIT state. Lets check the current state, if FW is not in UNINIT state then

[PATCH net-next 08/12] net: hns3: fix for rss result nonuniform

2019-01-30 Thread Huazhong Tan
From: Jian Shen The rss result is more uniform when use recommended hash key from microsoft, instead of the one generated by netdev_rss_key_fill(). Also using hash algorithm "xor" is better than "toeplitz". This patch modifies the default hash key and hash algorithm. Signed-off-by: Jian Shen

[PATCH net-next 11/12] net: hns3: stop sending keep alive msg to PF when VF is resetting

2019-01-30 Thread Huazhong Tan
From: Jian Shen When VF is resetting, it can't communicate to PF with mailbox msg. This patch adds reset state checking before sending keep alive msg to PF. Fixes: a6d818e31d08 ("net: hns3: Add vport alive state checking support") Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by:

[PATCH net-next 03/12] net: hns3: use the correct interface to stop|open port

2019-01-30 Thread Huazhong Tan
From: Peng Li dev_close() stop the netdev and the service base on the netdev will stop. But ndev->netdev_ops->ndo_stop() may only stop HW and stack queue, the service base on the netdev can still work. Fixes: 5668abda0931 ("net: hns3: add support for set_ringparam") Signed-off-by: Peng Li

KASAN: use-after-free Read in selinux_netlbl_socket_setsockopt

2019-01-30 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:62967898789d Merge git://git.kernel.org/pub/scm/linux/kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=167fdef8c0 kernel config: https://syzkaller.appspot.com/x/.config?x=4fceea9e2d99ac20

Re: [PATCH v3] remoteproc: qcom: Add support for parsing fw dt bindings

2019-01-30 Thread Bjorn Andersson
On Mon 14 Jan 11:50 PST 2019, Sibi Sankar wrote: > Add support for parsing "firmware-name" dt bindings which specifies > the relative paths of mba/modem/pas image as strings. Fallback to > the default paths for mba/modem/pas image on -EINVAL. > > Signed-off-by: Sibi Sankar Applied, Thanks,

KASAN: use-after-free Read in __wake_up_common_lock

2019-01-30 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:62967898789d Merge git://git.kernel.org/pub/scm/linux/kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10f0bf08c0 kernel config: https://syzkaller.appspot.com/x/.config?x=4fceea9e2d99ac20

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Logan Gunthorpe
On 2019-01-30 12:59 p.m., Jason Gunthorpe wrote: > On Wed, Jan 30, 2019 at 12:45:46PM -0700, Logan Gunthorpe wrote: >> >> >> On 2019-01-30 12:06 p.m., Jason Gunthorpe wrote: Way less problems than not having struct page for doing anything non-trivial. If you map the BAR to userspace

[PATCH net-next 00/12] code optimizations & bugfixes for HNS3 driver

2019-01-30 Thread Huazhong Tan
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver Huazhong Tan (4): net: hns3: change hnae3_register_ae_dev() to int net: hns3: Fix NULL deref when unloading driver net: hns3: fix netif_napi_del() not do problem when unloading net: hns3: fix

[PATCH net-next 04/12] net: hns3: change hnae3_register_ae_dev() to int

2019-01-30 Thread Huazhong Tan
hnae3_register_ae_dev() may fail, and it should return a error code to its caller, so change hnae3_register_ae_dev() return type to int. Also, when hnae3_register_ae_dev() return error, hns3_probe() should do some error handling and return the error code. Signed-off-by: Huazhong Tan

Re: [PATCH][RFC] module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity

2019-01-30 Thread Alan Cox
> > > +"GPL and additional rights" Historical variant of expressing that > > > the > > > + module source is dual licensed under a > > > + GPL v2 variant and MIT license. Please do > > > + not use in new code.

Re: [PATCH][RFC] module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity

2019-01-30 Thread Alan Cox
On Wed, 30 Jan 2019 15:31:20 +1030 Rusty Russell wrote: > Thanks taking on such a thankless task Thomas, > > Might have been overzealous in assuming a verionless GPL string meant > "or later" (I'm happy for that for my own code, FWIW). My memory is > fuzzy, but I don't think anyone cared at

Re: [PATCH] remoteproc: qcom_q6v5: don't auto boot remote processor

2019-01-30 Thread Bjorn Andersson
On Thu 24 May 12:21 PDT 2018, Ramon Fried wrote: > Sometimes that rmtfs userspace module is not brought > up fast enough and the modem crashes. > disabling automated boot in the driver and triggering > the boot from user-space sovles the problem. > > Signed-off-by: Ramon Fried While I don't

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-30 Thread Dan Murphy
Jacek On 1/30/19 2:20 PM, Jacek Anaszewski wrote: > Dan, > > On 1/30/19 8:59 PM, Dan Murphy wrote: >> Jacek >> >> On 1/30/19 1:37 PM, Jacek Anaszewski wrote: >>> Hi Dan, >>> >>> Thank you for the RFC. >>> >>> One vital thing is missing - documentation of brightness file must >>> be updated to

Re: WARN_ON_ONCE(!new_owner) within wake_futex_pi() triggered

2019-01-30 Thread Sebastian Sewior
On 2019-01-30 18:56:54 [+0100], Thomas Gleixner wrote: > TBH, no clue. Below are some more traceprintks which hopefully shed some > light on that mystery. See kernel/futex.c line 30 ... The robust list it somehow buggy. In the last trace we had the handle_futex_death() of uaddr 3ff9e880140 as

Re: [RFC PATCH glibc 1/4] glibc: Perform rseq(2) registration at C startup and thread creation (v6)

2019-01-30 Thread Joseph Myers
On Wed, 30 Jan 2019, Mathieu Desnoyers wrote: > #if defined (__NR_rseq) && !defined (RSEQ_SIG) > # error "UAPI headers support rseq system call, but glibc does not define > RSEQ_SIG." > #endif > > Would that take care of your concerns ? That would of course need appropriate conditionals based

Re: [PATCH v3] mm: Make memory.emin the baseline for utilisation determination

2019-01-30 Thread Roman Gushchin
On Tue, Jan 29, 2019 at 02:15:25PM -0500, Chris Down wrote: > Roman points out that when when we do the low reclaim pass, we scale the > reclaim pressure relative to position between 0 and the maximum > protection threshold. > > However, if the maximum protection is based on memory.elow, and >

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 08:01:13PM +, Carlos Henrique Lima Melara wrote: > On 30/01/2019 13:29, gre...@linuxfoundation.org wrote: > > On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > >>This patch fix the checkpatch.p1 warning: > >> > >>WARNING: Missing or

[PATCH] huegtlbfs: fix page leak during migration of file pages

2019-01-30 Thread Mike Kravetz
Files can be created and mapped in an explicitly mounted hugetlbfs filesystem. If pages in such files are migrated, the filesystem usage will not be decremented for the associated pages. This can result in mmap or page allocation failures as it appears there are fewer pages in the filesystem

Re: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-01-30 Thread Andy Shevchenko
On Wed, Jan 30, 2019 at 10:47 PM Liming Sun wrote: > > First of all, is it a real watchdog with a driver? I think watchdog in > > that case should be set up through standard watchdog facilities. > > This is not a watchdog driver itself. Instead, it provides interface to > user-space and use ARM

Re: [PATCH 2/2] binderfs: remove separate device_initcall()

2019-01-30 Thread Greg KH
On Wed, Jan 30, 2019 at 06:01:02PM +0100, Christian Brauner wrote: > On Wed, Jan 30, 2019 at 03:24:12PM +0100, Greg KH wrote: > > On Wed, Jan 23, 2019 at 12:41:16PM +0100, Christian Brauner wrote: > > > binderfs should not have a separate device_initcall(). When a kernel is > > > compiled with

Re: [PATCH] tpm: don't print error message in tpm_transmit_cmd when tpm still testing

2019-01-30 Thread Jarkko Sakkinen
On Tue, Jan 29, 2019 at 11:59:11AM -0700, Jerry Snitselaar wrote: > Currently tpm_transmit_cmd will print an error message if the tpm > returns something other than TPM2_RC_SUCCESS. This means that if the > tpm returns that it is testing an error message will be printed, and > this can cause

Re: [PATCH 5/5] RDMA/uverbs: add UVERBS_METHOD_REG_REMOTE_MR

2019-01-30 Thread Jason Gunthorpe
On Wed, Jan 30, 2019 at 10:34:02AM +0200, Joel Nider wrote: > linux-rdma-ow...@vger.kernel.org wrote on 01/29/2019 07:04:06 PM: > > > On Tue, Jan 29, 2019 at 03:26:26PM +0200, Joel Nider wrote: > > > Add a new handler for new uverb reg_remote_mr. The purpose is to > register > > > a memory

Re: [PATCH v2] doc: Change LXR references to elixir.bootlin.com

2019-01-30 Thread Federico Vaga
On 2019-01-30 18:25, Jonathan Neuschäfer wrote: Recently, Free Electrons was renamed to Bootlin[1]. Less recently, the Linux Cross Reference (LXR) at lxr.free-electrons.com was replaced by Elixir[2], and lxr.free-electrons.com redirected first to elixir.free-electrons.com and now to

Re: [patch 2/2] proc/stat: Make the interrupt statistics more efficient

2019-01-30 Thread Alexey Dobriyan
On Wed, Jan 30, 2019 at 01:31:32PM +0100, Thomas Gleixner wrote: > +static void show_irq_gap(struct seq_file *p, int gap) > +{ > + static const char zeros[] = " 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0"; > + > + while (gap > 0) { > + int inc = min_t(int, gap, ARRAY_SIZE(zeros) / 2); > +

Re: [patch 2/2] proc/stat: Make the interrupt statistics more efficient

2019-01-30 Thread Thomas Gleixner
On Thu, 31 Jan 2019, Alexey Dobriyan wrote: > On Wed, Jan 30, 2019 at 01:31:32PM +0100, Thomas Gleixner wrote: > > +static void show_irq_gap(struct seq_file *p, int gap) > > +{ > > + static const char zeros[] = " 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0"; > > + > > + while (gap > 0) { > > +

Re: [PATCH 20/22] x86/fpu: Let __fpu__restore_sig() restore the !32bit+fxsr frame from kernel memory

2019-01-30 Thread Borislav Petkov
On Wed, Jan 09, 2019 at 12:47:42PM +0100, Sebastian Andrzej Siewior wrote: > The !32bit+fxsr case loads the new state from user memory. In case we ^^^ Let's "decrypt" that: "The 64-bit case where fast FXSAVE/FXRSTOR are used... " But looking at the patch, it is not only about the

Re: KASAN: use-after-free Read in selinux_netlbl_socket_setsockopt

2019-01-30 Thread Paul Moore
On Wed, Jan 30, 2019 at 4:01 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:62967898789d Merge git://git.kernel.org/pub/scm/linux/kern.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=167fdef8c0 > kernel config:

Re: [PATCH 2/9] clk: Introduce get_parent_hw clk op

2019-01-30 Thread Stephen Boyd
Quoting Jerome Brunet (2019-01-30 01:53:41) > > It is the value we find in the register after the bootloader. Since we have no > idea what it is, we must assume it is invalid. Ok, so my understanding is correct. > > The problem was that there only one known parent for this particular clock, >

Re: [PATCH] lib/ubsan: default UBSAN_ALIGNMENT to not set

2019-01-30 Thread Arnd Bergmann
On Wed, Jan 30, 2019 at 6:12 PM Andrey Ryabinin wrote: > On 1/30/19 4:36 AM, Andrew Morton wrote: > > On Fri, 11 Jan 2019 22:01:16 +0300 Andrey Ryabinin > > wrote: > >> On 12/17/18 6:03 PM, Anders Roxell wrote: > >>> When booting an allmodconfig kernel, there are a lot of false-positives. > >>>

Re: [PATCH 2/2] mm: Consider subtrees in memory.events

2019-01-30 Thread Johannes Weiner
On Wed, Jan 30, 2019 at 09:05:59PM +0100, Michal Hocko wrote: > On Wed 30-01-19 14:23:45, Johannes Weiner wrote: > > On Mon, Jan 28, 2019 at 01:51:51PM +0100, Michal Hocko wrote: > > > On Fri 25-01-19 10:28:08, Tejun Heo wrote: > > > > On Fri, Jan 25, 2019 at 06:37:13PM +0100, Michal Hocko wrote:

Re: [PATCH v2 ] PM-runtime: fix deadlock with ktime

2019-01-30 Thread Ladislav Michl
On Wed, Jan 30, 2019 at 02:06:07PM +0100, Rafael J. Wysocki wrote: > On Wed, Jan 30, 2019 at 12:16 PM Vincent Guittot > wrote: > > > > A deadlock has been seen when swicthing clocksources which use PM runtime. > > The call path is: > > change_clocksource > > ... > > write_seqcount_begin >

<    4   5   6   7   8   9   10   11   12   13   >