Re: [PATCH bpf-next] xsk: proper socket state check in xsk_poll

2019-08-20 Thread Björn Töpel
On Tue, 20 Aug 2019 at 16:30, Daniel Borkmann wrote: > > On 8/20/19 12:04 PM, Björn Töpel wrote: > > From: Björn Töpel > > > > The poll() implementation for AF_XDP sockets did not perform the > > proper state checks, prior accessing the socket umem. This patch fixes > > that by performing a xsk_i

Re: [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz

2019-08-20 Thread Andrew Lunn
On Mon, Aug 19, 2019 at 08:08:04PM -0700, Andrey Smirnov wrote: > Fiber-optic module attached to the bus is only rated to work at > 100kHz, so drop the bus frequncy to accomodate that. Hi Andrey Did you review all the other ZII platforms? I could imaging the same problem happening else where. Th

Re: [PATCH] Tools: hv: kvp: eliminate 'may be used uninitialized' warning

2019-08-20 Thread Sasha Levin
On Mon, Aug 19, 2019 at 04:44:09PM +0200, Vitaly Kuznetsov wrote: When building hv_kvp_daemon GCC-8.3 complains: hv_kvp_daemon.c: In function ‘kvp_get_ip_info.constprop’: hv_kvp_daemon.c:812:30: warning: ‘ip_buffer’ may be used uninitialized in this function [-Wmaybe-uninitialized] struct hv_k

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-20 Thread Peter Zijlstra
On Thu, Aug 15, 2019 at 10:22:07PM +0200, Thomas Gleixner wrote: > On Thu, 15 Aug 2019, Luck, Tony wrote: > > On Thu, Aug 15, 2019 at 07:54:55PM +0200, Borislav Petkov wrote: > > @@ -11,6 +11,21 @@ > > * While adding a new CPUID for a new microarchitecture, add a new > > * group to keep logical

Re: [PATCH] libperf: Fix arch include paths

2019-08-20 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 20, 2019 at 08:26:45AM -0700, Guenter Roeck escreveu: > On 8/20/19 5:46 AM, Jiri Olsa wrote: > > version) and we don't get the proper include path. > > > > Reported-by: Guenter Roeck > > Link: http://lkml.kernel.org/n/tip-408wq8mtajlvs9iir7qo9...@git.kernel.org > > Signed-off-by: Jiri

Re: [PATCH] PCI: Add PCIE ACS quirk for IPROC PAXB

2019-08-20 Thread Scott Branden
Looks good. On 2019-08-19 9:39 p.m., Srinath Mannam wrote: From: Abhinav Ratna IPROC PAXB RC doesn't support ACS capabilities and control registers. Add quirk to have separate IOMMU groups for all EPs and functions connected to root port, by masking RR/CR/SV/UF bits. Signed-off-by: Abhinav Ra

Re: [PATCH V2 2/4] watchdog: Add i.MX7ULP watchdog support

2019-08-20 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 04:53:19PM +0800, anson.hu...@nxp.com wrote: > From: Anson Huang > > The i.MX7ULP Watchdog Timer (WDOG) module is an independent timer > that is available for system use. > It provides a safety feature to ensure that software is executing > as planned and that the CPU is n

Re: [PATCH v5 2/6] vfio: Introduce vGPU display irq type

2019-08-20 Thread Alex Williamson
On Tue, 20 Aug 2019 02:12:10 + "Zhang, Tina" wrote: > BTW, IIRC, we might also have one question waiting to be replied: > - Can we just use VFIO_IRQ_TYPE_GFX w/o proposing a new sub type > (i.e. VFIO_IRQ_SUBTYPE_GFX_DISPLAY_IRQ)? Well, only if we can agree > on that we don't have any other GF

[PATCH] staging: comedi: ni_mio_common: Fix a typo in ni_mio_common.c

2019-08-20 Thread Masanari Iida
This patch fix a spelling typo in ni_mio_common.c Signed-off-by: Masanari Iida --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c i

[PATCH] mfd: htc-i2cpld: drop check because i2c_unregister_device() is NULL safe

2019-08-20 Thread Wolfram Sang
No need to check the argument of i2c_unregister_device() because the function itself does it. Signed-off-by: Wolfram Sang --- Build tested only, buildbot is happy, too. Please apply to your tree. drivers/mfd/htc-i2cpld.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dri

[PATCH 1/2] media: i2c: adv7511-v4l2: drop check because i2c_unregister_device() is NULL safe

2019-08-20 Thread Wolfram Sang
No need to check the argument of i2c_unregister_device() because the function itself does it. Signed-off-by: Wolfram Sang --- Build tested only, buildbot is happy, too. Please apply to your tree. drivers/media/i2c/adv7511-v4l2.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 2/2] media: i2c: adv7842: drop check because i2c_unregister_device() is NULL safe

2019-08-20 Thread Wolfram Sang
No need to check the argument of i2c_unregister_device() because the function itself does it. Signed-off-by: Wolfram Sang --- Build tested only, buildbot is happy, too. Please apply to your tree. drivers/media/i2c/adv7842.c | 33 +++-- 1 file changed, 11 insertions(

[PATCH] i2c: cht-wc: drop check because i2c_unregister_device() is NULL safe

2019-08-20 Thread Wolfram Sang
No need to check the argument of i2c_unregister_device() because the function itself does it. Signed-off-by: Wolfram Sang --- Build tested only, buildbot is happy, too. Please apply to your tree. drivers/i2c/busses/i2c-cht-wc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --gi

[PATCH] platform: chrome: chromeos_laptop: drop checks of NULL-safe functions

2019-08-20 Thread Wolfram Sang
No need to check the argument of i2c_unregister_device() and property_entries_free() because the functions do check it. Signed-off-by: Wolfram Sang --- Build tested only, buildbot is happy, too. Please apply to your tree. drivers/platform/chrome/chromeos_laptop.c | 10 +++--- 1 file change

Re: [PATCH v3 3/5] arm64: pmu: Add function implementation to update event index in userpage.

2019-08-20 Thread Mark Rutland
On Fri, Aug 16, 2019 at 01:59:32PM +0100, Raphael Gault wrote: > In order to be able to access the counter directly for userspace, > we need to provide the index of the counter using the userpage. > We thus need to override the event_idx function to retrieve and > convert the perf_event index to ar

[PATCH] video: backlight: tosa_lcd: drop check because i2c_unregister_device() is NULL safe

2019-08-20 Thread Wolfram Sang
No need to check the argument of i2c_unregister_device() because the function itself does it. Signed-off-by: Wolfram Sang --- Build tested only, buildbot is happy, too. Please apply to your tree. drivers/video/backlight/tosa_lcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -

[PATCH v6 1/4] dt-bindings: vendor-prefixes: Add Anvo-Systems

2019-08-20 Thread Krzysztof Kozlowski
Add vendor prefix for Anvo-Systems Dresden GmbH. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Rob Herring --- Changes since v4: None Changes since v3: 1. Add Rob's tag, 2. Remove Admatec (not needed anymore). Changes since v2: 1. Use admatecde vendor prefix. 2. Add Anvo-Systems Dresden Gm

[PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles

2019-08-20 Thread Krzysztof Kozlowski
Add the compatibles for Kontron i.MX6UL N6310 SoM and boards. Signed-off-by: Krzysztof Kozlowski --- Changes since v5: New patch --- Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documenta

[PATCH v6 2/4] dt-bindings: eeprom: at25: Add Anvo ANV32E61W

2019-08-20 Thread Krzysztof Kozlowski
Document the compatible for ANV32E61W 64kb Serial SPI non-volatile SRAM. Although it is a SRAM device, it can be accessed through EEPROM interface. At least until there is no proper SRAM driver support for it. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Fabio Estevam --- Changes since v4:

Re: [PATCH net] ixgbe: fix double clean of tx descriptors with xdp

2019-08-20 Thread Alexander Duyck
On Tue, Aug 20, 2019 at 8:18 AM Ilya Maximets wrote: > > Tx code doesn't clear the descriptor status after cleaning. > So, if the budget is larger than number of used elems in a ring, some > descriptors will be accounted twice and xsk_umem_complete_tx will move > prod_tail far beyond the prod_head

[PATCH v6 4/4] ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards

2019-08-20 Thread Krzysztof Kozlowski
Add support for i.MX6UL modules from Kontron Electronics GmbH (before acquisition: Exceet Electronics) and evalkit boards based on it: 1. N6310 SOM: i.MX6 UL System-on-Module, a 25x25 mm solderable module (LGA pads and pin castellations) with 256 MB RAM, 1 MB NOR-Flash, 256 MB NAND and other

[PATCH] selftests: kvm: fix state save/load on processors without XSAVE

2019-08-20 Thread Paolo Bonzini
state_test and smm_test are failing on older processors that do not have xcr0. This is because on those processor KVM does provide support for KVM_GET/SET_XSAVE (to avoid having to rely on the older KVM_GET/SET_FPU) but not for KVM_GET/SET_XCRS. Signed-off-by: Paolo Bonzini --- tools/testing/se

Re: [PATCH 3/6] net: stmmac: sun8i: Use devm_regulator_get for PHY regulator

2019-08-20 Thread Andrew Lunn
On Tue, Aug 20, 2019 at 04:53:40PM +0200, meg...@megous.com wrote: > From: Ondrej Jirman > > Use devm_regulator_get instead of devm_regulator_get_optional and rely > on dummy supply. This avoids NULL checks before regulator_enable/disable > calls. Hi Ondrej What do you mean by a dummy supply? I

Re: [PATCH 2/2] reset: meson-audio-arb: add sm1 support

2019-08-20 Thread Philipp Zabel
Hi Jerome, thank you for the patch. Just one nitpick and one real issue below: On Tue, 2019-08-20 at 11:46 +0200, Jerome Brunet wrote: > Add the new arb reset lines of the SM1 SoC family > > Signed-off-by: Jerome Brunet > --- > drivers/reset/reset-meson-audio-arb.c | 28 +++

Re: [PATCH net-next v3 2/4] net: mdio: add PTP offset compensation to mdiobus_write_sts

2019-08-20 Thread Miroslav Lichvar
On Tue, Aug 20, 2019 at 05:23:06PM +0200, Andrew Lunn wrote: > > - take a second "post" system timestamp after the completion > > For this hardware, completion is an interrupt, which has a lot of > jitter on it. But this hardware is odd, in that it uses an > interrupt. Every other MDIO bus control

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-20 Thread Peter Zijlstra
On Tue, Aug 20, 2019 at 12:48:05PM +, Luck, Tony wrote: > > >> +#define INTEL_FAM6_ATOM_AIRMONT_NP0x75 /* Lightning Mountain */ > > > > What's _NP ? > > Network Processor. But that is too narrow a descriptor. This is going to be > used in > other areas besides networking. > > I’m cont

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-20 Thread Peter Zijlstra
On Thu, Aug 15, 2019 at 10:22:07PM +0200, Thomas Gleixner wrote: > We have the following existing _SHORT variants: > _G > _GT3E Those two are special SOCs due to 'extra graphics bits on', and I suppose we could collate them. That said; I'm not sure NHM_G ever shipped, I'm looking at a wikipedia

Re: linux-next: Tree for Aug 20 (mm/memcontrol)

2019-08-20 Thread Randy Dunlap
On 8/20/19 12:09 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190819: > on i386 or x86_64: ../mm/memcontrol.c: In function ‘__mem_cgroup_free’: ../mm/memcontrol.c:4885:2: error: implicit declaration of function ‘memcg_flush_percpu_vmstats’; did you mean ‘qdisc_is_percpu_stats’? [

[PATCH 1/2] rtc: max77686: convert to devm_i2c_new_dummy_device()

2019-08-20 Thread Wolfram Sang
I was about to simplify the call to i2c_unregister_device() when I realized that converting to devm_i2c_new_dummy_device() will simplify the driver a lot. So I took this approach. Signed-off-by: Wolfram Sang --- Build tested only, buildbot is happy, too. Please apply to your tree. drivers/rtc/

[PATCH 0/2] rtc: convert two drivers to devm_i2c_new_dummy_device()

2019-08-20 Thread Wolfram Sang
I was about to simplify the call to i2c_unregister_device() when I realized that converting to devm_i2c_new_dummy_device() will simplify the drivers a lot. So I took this approach. Only build tested, but visually reviewed multiple times. Wolfram Sang (2): rtc: max77686: convert to devm_i2c_new_

[PATCH 2/2] rtc: s35390a: convert to devm_i2c_new_dummy_device()

2019-08-20 Thread Wolfram Sang
I was about to simplify the call to i2c_unregister_device() when I realized that converting to devm_i2c_new_dummy_device() will simplify the driver a lot. So I took this approach. Signed-off-by: Wolfram Sang --- Build tested only, buildbot is happy, too. Please apply to your tree. drivers/rtc/

Re: [PATCH v2 2/3] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE

2019-08-20 Thread Philipp Zabel
On Tue, 2019-08-20 at 11:40 +0200, Ricardo Ribalda Delgado wrote: > New control to pass to userspace the width/height of a pixel. Which is > needed for calibration and lens selection. > > Signed-off-by: Ricardo Ribalda Delgado > --- > Documentation/media/uapi/v4l/ext-ctrls-camera.rst | 8 +++

Re: [ANNOUNCE] v5.2.9-rt3

2019-08-20 Thread Alexandre Belloni
Hi, On 19/08/2019 13:03:51+0200, Alexander Dahl wrote: > Hei hei, > > just tried to compile this v5.2.9-rt3 for SAMA5D27-SOM1-EK1 based on > arch/arm/configs/sama5_defconfig and with running oldconfig and selecting > defaults, but that fails if CONFIG_ATMEL_TCB_CLKSRC_USE_SLOW_CLOCK is not > s

Re: [RFC,v2 3/6] media: dt-bindings: add DS90UB954-Q1 video deserializer

2019-08-20 Thread Rob Herring
On Mon, Aug 19, 2019 at 5:41 PM Luca Ceresoli wrote: > > Hi Rob, > > thanks for your review. > > On 13/08/19 17:44, Rob Herring wrote: > > On Tue, Jul 23, 2019 at 10:37:20PM +0200, Luca Ceresoli wrote: > >> Describe the Texas Instruments DS90UB954-Q1, a 2-input video deserializer > >> with I2C Add

Re: [PATCH 3/6] net: stmmac: sun8i: Use devm_regulator_get for PHY regulator

2019-08-20 Thread Ondřej Jirman
Hi Andrew, On Tue, Aug 20, 2019 at 05:39:39PM +0200, Andrew Lunn wrote: > On Tue, Aug 20, 2019 at 04:53:40PM +0200, meg...@megous.com wrote: > > From: Ondrej Jirman > > > > Use devm_regulator_get instead of devm_regulator_get_optional and rely > > on dummy supply. This avoids NULL checks before

Re: [PATCH V2 2/4] watchdog: Add i.MX7ULP watchdog support

2019-08-20 Thread Guenter Roeck
On Tue, Aug 20, 2019 at 08:31:55AM -0700, Guenter Roeck wrote: > On Mon, Aug 12, 2019 at 04:53:19PM +0800, anson.hu...@nxp.com wrote: > > From: Anson Huang > > > > The i.MX7ULP Watchdog Timer (WDOG) module is an independent timer > > that is available for system use. > > It provides a safety feat

Re: [PATCH v3 2/5] arm64: cpufeature: Add feature to detect heterogeneous systems

2019-08-20 Thread Mark Rutland
On Tue, Aug 20, 2019 at 04:23:17PM +0100, Mark Rutland wrote: > Hi Raphael, > > On Fri, Aug 16, 2019 at 01:59:31PM +0100, Raphael Gault wrote: > > This feature is required in order to enable PMU counters direct > > access from userspace only when the system is homogeneous. > > This feature checks

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-20 Thread Peter Zijlstra
On Tue, Aug 20, 2019 at 05:40:11PM +0200, Peter Zijlstra wrote: > > _CORE > > _DESKTOP > > These two and no _SHORT should/could be collated, I think. for i in `git grep -l "INTEL_FAM6_.*_\(CORE\|DESKTOP\)"` do sed -i -e 's/\(INTEL_FAM6_.*\)_\(CORE\|DESKTOP\)/\1/g' ${i} done --- arch/x8

Re: [PATCH v3 0/3] genirq/vfio: Introduce update_irq_devid and optimize VFIO irq ops

2019-08-20 Thread luoben
在 2019/8/20 下午11:22, Alex Williamson 写道: On Tue, 20 Aug 2019 12:03:50 +0800 luoben wrote: 在 2019/8/20 上午4:51, Alex Williamson 写道: On Thu, 15 Aug 2019 21:02:58 +0800 Ben Luo wrote: Currently, VFIO takes a lot of free-then-request-irq actions whenever a VM (with device passthru via VFIO)

Re: [PATCH v2 4/4] leds: lm3532: Add full scale current configuration

2019-08-20 Thread Dan Murphy
Pavel Thanks for the review On 8/19/19 5:55 AM, Pavel Machek wrote: Hi! Allow the full scale current to be configured at init. Valid rangles are 5mA->29.8mA. Signed-off-by: Dan Murphy @@ -121,6 +125,7 @@ struct lm3532_als_data { * @mode - Mode of the LED string * @ctrl_brt_pointer - Z

Re: [PATCH v2 1/2] dt-bindings: media: Add YAML schemas for the generic RC bindings

2019-08-20 Thread Rob Herring
On Tue, Aug 20, 2019 at 4:50 AM Maxime Ripard wrote: > > Hi Sean, > > On Tue, Aug 20, 2019 at 09:15:26AM +0100, Sean Young wrote: > > On Mon, Aug 19, 2019 at 08:26:18PM +0200, Maxime Ripard wrote: > > > From: Maxime Ripard > > > > > > The RC controllers have a bunch of generic properties that are

Re: [PATCH v2 1/4] leds: lm3532: Fix brightness control for i2c mode

2019-08-20 Thread Dan Murphy
Pavel On 8/19/19 5:48 AM, Pavel Machek wrote: On Tue 2019-08-13 13:11:51, Dan Murphy wrote: Fix the brightness control for I2C mode. Instead of changing the full scale current register update the ALS target register for the appropriate banks. In addition clean up some code errors and random m

Re: [PATCH] sched/core: Schedule new worker even if PI-blocked

2019-08-20 Thread Sebastian Andrzej Siewior
On 2019-08-20 17:20:25 [+0200], Peter Zijlstra wrote: > > There isc RCU (boosting) and futex. I'm sceptical about the i2c users… > > Well, yes, I too was/am sceptical, but it was tglx who twisted my arm > and said the i2c people were right and rt_mutex is/should-be a generic > usable interface. I

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-20 Thread Peter Zijlstra
On Tue, Aug 20, 2019 at 05:40:11PM +0200, Peter Zijlstra wrote: > > _ULT > > _MOBILE > > I suspect these two are the same. for i in `git grep -l "INTEL_FAM6_.*_MOBILE"` do sed -i -e 's/\(INTEL_FAM6_.*\)_MOBILE/\1_ULT/g' ${i} done --- arch/x86/events/intel/core.c | 16 +++---

Re: [PATCH v2 1/2] dt-bindings: phy: intel-emmc-phy: Add YAML schema for LGM eMMC PHY

2019-08-20 Thread Rob Herring
On Tue, Aug 20, 2019 at 5:31 AM Ramuthevar,Vadivel MuruganX wrote: > > From: Ramuthevar Vadivel Murugan > > Add a YAML schema to use the host controller driver with the > eMMC PHY on Intel's Lightning Mountain SoC. > > Signed-off-by: Ramuthevar Vadivel Murugan > > --- > changes in v2: > As pe

Re: [PATCH v2 1/6] dt-bindings: watchdog: Add YAML schemas for the generic watchdog bindings

2019-08-20 Thread Guenter Roeck
On 8/19/19 11:20 AM, Maxime Ripard wrote: From: Maxime Ripard The watchdogs have a bunch of generic properties that are needed in a device tree. Add a YAML schemas for those. Signed-off-by: Maxime Ripard What is the target subsystem for this series ? You didn't copy the watchdog mailing lis

Re: [PATCH 3/3] firmware: add mutex fw_lock_fallback for race condition

2019-08-20 Thread Scott Branden
Hi Luis, I'm glad you are a subject expert in this area. Some more comments inline. On 2019-08-19 6:26 p.m., Luis Chamberlain wrote: On Mon, Aug 19, 2019 at 09:19:51AM -0700, Scott Branden wrote: To be honest, I find the entire firmware code sloppy. And that is after years of cleanup on my

Re: [PATCH v3 2/5] arm64: cpufeature: Add feature to detect heterogeneous systems

2019-08-20 Thread Raphael Gault
Hi Mark, Thank you for your comments. On 8/20/19 4:49 PM, Mark Rutland wrote: On Tue, Aug 20, 2019 at 04:23:17PM +0100, Mark Rutland wrote: Hi Raphael, On Fri, Aug 16, 2019 at 01:59:31PM +0100, Raphael Gault wrote: This feature is required in order to enable PMU counters direct access from u

Re: [PATCH 3/6] net: stmmac: sun8i: Use devm_regulator_get for PHY regulator

2019-08-20 Thread Ondřej Jirman
On Tue, Aug 20, 2019 at 05:39:39PM +0200, Andrew Lunn wrote: > On Tue, Aug 20, 2019 at 04:53:40PM +0200, meg...@megous.com wrote: > > From: Ondrej Jirman > > > > Use devm_regulator_get instead of devm_regulator_get_optional and rely > > on dummy supply. This avoids NULL checks before regulator_en

[PATCH] arm64: perf_event: Add missing header needed for smp_processor_id()

2019-08-20 Thread Raphael Gault
Acked-by: Mark Rutland Signed-off-by: Raphael Gault --- arch/arm64/kernel/perf_event.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c index 96e90e270042..24575c0a0065 100644 --- a/arch/arm64/kernel/perf_event.c +++ b/arch/arm64

Re: [PATCH 3/6] net: stmmac: sun8i: Use devm_regulator_get for PHY regulator

2019-08-20 Thread Andrew Lunn
On Tue, Aug 20, 2019 at 05:47:14PM +0200, Ondřej Jirman wrote: > Hi Andrew, > > On Tue, Aug 20, 2019 at 05:39:39PM +0200, Andrew Lunn wrote: > > On Tue, Aug 20, 2019 at 04:53:40PM +0200, meg...@megous.com wrote: > > > From: Ondrej Jirman > > > > > > Use devm_regulator_get instead of devm_regulat

Re: [PATCH 2/2] reset: meson-audio-arb: add sm1 support

2019-08-20 Thread Jerome Brunet
On Tue 20 Aug 2019 at 17:39, Philipp Zabel wrote: > Hi Jerome, > > thank you for the patch. Just one nitpick and one real issue below: > > On Tue, 2019-08-20 at 11:46 +0200, Jerome Brunet wrote: >> Add the new arb reset lines of the SM1 SoC family >> >> Signed-off-by: Jerome Brunet >> --- >> d

Re: [PATCH net] ixgbe: fix double clean of tx descriptors with xdp

2019-08-20 Thread Ilya Maximets
On 20.08.2019 18:35, Alexander Duyck wrote: > On Tue, Aug 20, 2019 at 8:18 AM Ilya Maximets wrote: >> >> Tx code doesn't clear the descriptor status after cleaning. >> So, if the budget is larger than number of used elems in a ring, some >> descriptors will be accounted twice and xsk_umem_complete

Re: [PATCH v5] ata/pata_buddha: Probe via modalias instead of initcall

2019-08-20 Thread Max Staudt
Hi Bartlomiej, Thank you very much for your review! Question below. On 08/20/2019 02:06 PM, Bartlomiej Zolnierkiewicz wrote: >> +/* Workaround for X-Surf: Save drvdata in case zorro8390 has set it */ >> +old_drvdata = dev_get_drvdata(&z->dev); > > This should be done only for type == B

Re: [PATCH v2 2/2] dt-bindings: lantiq: Update for new SoC

2019-08-20 Thread Rob Herring
On Tue, Aug 20, 2019 at 3:29 AM Rahul Tanwar wrote: > > Intel Lightning Mountain(LGM) SoC reuses Lantiq ASC serial controller IP. > Update the dt bindings to support LGM as well. > > Signed-off-by: Rahul Tanwar > --- > .../devicetree/bindings/serial/lantiq_asc.yaml | 17 > +

Re: [PATCH] sched/core: Schedule new worker even if PI-blocked

2019-08-20 Thread Peter Zijlstra
On Tue, Aug 20, 2019 at 05:54:01PM +0200, Sebastian Andrzej Siewior wrote: > On 2019-08-20 17:20:25 [+0200], Peter Zijlstra wrote: > > And am I right in thinking that that, again, is specific to the > > sleeping-spinlocks from PREEMPT_RT? Is there really nothing else that > > identifies those more

[PATCH] userfaultfd_release: always remove uffd flags and clear vm_userfaultfd_ctx

2019-08-20 Thread Oleg Nesterov
userfaultfd_release() should clear vm_flags/vm_userfaultfd_ctx even if mm->core_state != NULL. Otherwise a page fault can see userfaultfd_missing() == T and use an already freed userfaultfd_ctx. Reported-by: Kefeng Wang Fixes: 04f5866e41fb ("coredump: fix race condition between mmget_not_zero()

Re: [PATCH v3 2/5] arm64: cpufeature: Add feature to detect heterogeneous systems

2019-08-20 Thread Mark Rutland
On Tue, Aug 20, 2019 at 04:55:24PM +0100, Raphael Gault wrote: > Hi Mark, > > Thank you for your comments. > > On 8/20/19 4:49 PM, Mark Rutland wrote: > > On Tue, Aug 20, 2019 at 04:23:17PM +0100, Mark Rutland wrote: > > > Hi Raphael, > > > > > > On Fri, Aug 16, 2019 at 01:59:31PM +0100, Raphael

Re: [PATCH] userfaultfd_release: always remove uffd flags and clear vm_userfaultfd_ctx

2019-08-20 Thread Andrea Arcangeli
On Tue, Aug 20, 2019 at 06:02:38PM +0200, Oleg Nesterov wrote: > userfaultfd_release() should clear vm_flags/vm_userfaultfd_ctx even > if mm->core_state != NULL. > > Otherwise a page fault can see userfaultfd_missing() == T and use an > already freed userfaultfd_ctx. > > Reported-by: Kefeng Wang

Re: [PATCH] x86/mm/pti: in pti_clone_pgtable() don't increase addr by PUD_SIZE

2019-08-20 Thread Song Liu
> On Aug 20, 2019, at 7:18 AM, Dave Hansen wrote: > > On 8/20/19 7:14 AM, Song Liu wrote: >>> *But*, that shouldn't get hit on a Skylake CPU since those have PCIDs >>> and shouldn't have a global kernel image. Could you confirm whether >>> PCIDs are supported on this CPU? >> Yes, pcid is list

Re: [PATCH] arm64: perf_event: Add missing header needed for smp_processor_id()

2019-08-20 Thread Mark Rutland
On Tue, Aug 20, 2019 at 04:57:45PM +0100, Raphael Gault wrote: It would be worth having a body for the commit message like: | in perf_event.c we use smp_processor_id(), but we haven't included | where it is defined, and rely on this being pulled in | via a transitive include. Let's make this m

Re: [PATCH v3] dt-bindings: arm: Convert Actions Semi bindings to jsonschema

2019-08-20 Thread Manivannan Sadhasivam
On Fri, Jun 14, 2019 at 01:33:47PM -0600, Rob Herring wrote: > On Fri, Jun 14, 2019 at 11:07 AM Andreas Färber wrote: > > > > Am 14.06.19 um 19:04 schrieb Manivannan Sadhasivam: > > > On Thu, Jun 13, 2019 at 04:44:35PM -0600, Rob Herring wrote: > > >> On Fri, May 17, 2019 at 10:32:23AM -0500, Rob

Re: [PATCH v2 1/2] dt-bindings: serial: lantiq: Convert to YAML schema

2019-08-20 Thread Rob Herring
On Tue, Aug 20, 2019 at 3:29 AM Rahul Tanwar wrote: > > Convert the existing DT binding document for Lantiq SoC ASC serial controller > from txt format to YAML format. > > Signed-off-by: Rahul Tanwar > --- > .../devicetree/bindings/serial/lantiq_asc.txt | 31 -- > .../devicetree/bin

Re: [v5 PATCH 3/4] mm: shrinker: make shrinker not depend on memcg kmem

2019-08-20 Thread Yang Shi
On 8/20/19 4:01 AM, Kirill Tkhai wrote: On 07.08.2019 05:17, Yang Shi wrote: Currently shrinker is just allocated and can work when memcg kmem is enabled. But, THP deferred split shrinker is not slab shrinker, it doesn't make too much sense to have such shrinker depend on memcg kmem. It shou

Re: [Question-kvm] Can hva_to_pfn_fast be executed in interrupt context?

2019-08-20 Thread Bharath Vedartham
On Thu, Aug 15, 2019 at 08:26:43PM +0200, Paolo Bonzini wrote: > Oh, I see. Sorry I didn't understand the question. In the case of KVM, > there's simply no code that runs in interrupt context and needs to use > virtual addresses. > > In fact, there's no code that runs in interrupt context at all.

Re: [v5 PATCH 4/4] mm: thp: make deferred split shrinker memcg aware

2019-08-20 Thread Yang Shi
On 8/20/19 4:06 AM, Kirill Tkhai wrote: On 07.08.2019 05:17, Yang Shi wrote: Currently THP deferred split shrinker is not memcg aware, this may cause premature OOM with some configuration. For example the below test would run into premature OOM easily: $ cgcreate -g memory:thp $ echo 4G > /s

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-20 Thread Peter Zijlstra
On Thu, Aug 15, 2019 at 10:22:07PM +0200, Thomas Gleixner wrote: > We have the following existing _SHORT variants: > > _G > _EP > _EX > _CORE > _ULT > _GT3E > _XEON_D > _MOBILE > _DESKTOP > _NNPI > _MID > _TABLET > _PLUS Your list is missing: _L and _X. _X is the generic 'server' And we have o

Re: [PATCH] arm64: perf_event: Add missing header needed for smp_processor_id()

2019-08-20 Thread Will Deacon
On Tue, Aug 20, 2019 at 05:06:29PM +0100, Mark Rutland wrote: > On Tue, Aug 20, 2019 at 04:57:45PM +0100, Raphael Gault wrote: > > It would be worth having a body for the commit message like: > > | in perf_event.c we use smp_processor_id(), but we haven't included > | where it is defined, and r

Re: linux-next: Tree for Aug 20 (mm/memcontrol)

2019-08-20 Thread Roman Gushchin
On Tue, Aug 20, 2019 at 07:59:54AM -0700, Randy Dunlap wrote: > On 8/20/19 12:09 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20190819: > > > > on i386 or x86_64: > > ../mm/memcontrol.c: In function ‘__mem_cgroup_free’: > ../mm/memcontrol.c:4885:2: error: implicit declaration o

[PATCH] iommu/vt-d: Fix wrong analysis whether devices share the same bus

2019-08-20 Thread Nadav Amit
set_msi_sid_cb() is used to determine whether device aliases share the same bus, but it can provide false indications that aliases use the same bus when in fact they do not. The reason is that set_msi_sid_cb() assumes that pdev is fixed, while actually pci_for_each_dma_alias() can call fn() when pd

Re: [PATCH] sched/core: Schedule new worker even if PI-blocked

2019-08-20 Thread Sebastian Andrzej Siewior
On 2019-08-20 18:02:17 [+0200], Peter Zijlstra wrote: > On Tue, Aug 20, 2019 at 05:54:01PM +0200, Sebastian Andrzej Siewior wrote: > > On 2019-08-20 17:20:25 [+0200], Peter Zijlstra wrote: > > > > And am I right in thinking that that, again, is specific to the > > > sleeping-spinlocks from PREEMPT

Re: [PATCH 4/6] dt-bindings: arm: amlogic: add SM1 bindings

2019-08-20 Thread Rob Herring
On Tue, Aug 20, 2019 at 9:41 AM Neil Armstrong wrote: > > Add bindings for the new Amlogic SM1 SoC Family. > > It a derivative of the G12A SoC Family with : > - Cortex-A55 core instead of A53 > - more power domains > - a neural network co-processor > - a CSI input and image processor > > Signed-of

Re: [PATCH 1/1] netfilter: nf_tables: fib: Drop IPV6 packages if IPv6 is disabled on boot

2019-08-20 Thread Leonardo Bras
On Tue, 2019-08-20 at 07:36 +0200, Florian Westphal wrote: > Wouldn't fib_netdev.c have the same problem? Probably, but I haven't hit this issue yet. > If so, might be better to place this test in both > nft_fib6_eval_type and nft_fib6_eval. I think that is possible, and not very hard to do. But

Re: [PATCH 5/6] dt-bindings: arm: amlogic: add SEI Robotics SEI610 bindings

2019-08-20 Thread Rob Herring
On Tue, Aug 20, 2019 at 9:41 AM Neil Armstrong wrote: > > Add the compatible for the Amlogic SM1 Based SEI610 board. > > Signed-off-by: Neil Armstrong > --- > Documentation/devicetree/bindings/arm/amlogic.yaml | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Rob Herring

Re: [PATCH 1/6] dt-bindings: net: sun8i-a83t-emac: Add phy-supply property

2019-08-20 Thread Rob Herring
On Tue, Aug 20, 2019 at 9:53 AM wrote: > > From: Ondrej Jirman > > This is already supported by the driver, but is missing from the > bindings. Really, the supply for the phy should be in the phy's node... > > Signed-off-by: Ondrej Jirman > --- > .../devicetree/bindings/net/allwinner,sun8i-a8

Re: [PATCH 3/6] net: stmmac: sun8i: Use devm_regulator_get for PHY regulator

2019-08-20 Thread Ondřej Jirman
Hi, On Tue, Aug 20, 2019 at 05:57:44PM +0200, Andrew Lunn wrote: > On Tue, Aug 20, 2019 at 05:47:14PM +0200, Ondřej Jirman wrote: > > Hi Andrew, > > > > On Tue, Aug 20, 2019 at 05:39:39PM +0200, Andrew Lunn wrote: > > > On Tue, Aug 20, 2019 at 04:53:40PM +0200, meg...@megous.com wrote: > > > > Fr

Re: [PATCH 2/6] dt-bindings: net: sun8i-a83t-emac: Add phy-io-supply property

2019-08-20 Thread Rob Herring
On Tue, Aug 20, 2019 at 9:53 AM wrote: > > From: Ondrej Jirman > > Some PHYs require separate power supply for I/O pins in some modes > of operation. Add phy-io-supply property, to allow enabling this > power supply. Perhaps since this is new, such phys should have *-supply in their nodes. > >

Re: [PATCH v2 1/2] dt-bindings: media: Add YAML schemas for the generic RC bindings

2019-08-20 Thread Sean Young
On Tue, Aug 20, 2019 at 10:52:29AM -0500, Rob Herring wrote: > On Tue, Aug 20, 2019 at 4:50 AM Maxime Ripard wrote: > > On Tue, Aug 20, 2019 at 09:15:26AM +0100, Sean Young wrote: > > > On Mon, Aug 19, 2019 at 08:26:18PM +0200, Maxime Ripard wrote: > > > > From: Maxime Ripard > > > > > > > > The

[PATCH 0/3] ASoC: mchp-i2s-mcc: Several fixes

2019-08-20 Thread Codrin Ciubotariu
This pathset fixes some issues detected while testing some more the Microchip I2S multichannel controller. The first two patches fix some issues that appear mostly when hw_free() and hw_params() callbacks are called multiple times. The third patch fixes a problem caused when the controller is in ma

Re: [Linux-kernel-mentees][PATCH v6 1/2] sgi-gru: Convert put_page() to put_user_page*()

2019-08-20 Thread Bharath Vedartham
On Mon, Aug 19, 2019 at 12:30:18PM -0700, John Hubbard wrote: > On 8/19/19 12:06 PM, Bharath Vedartham wrote: > >On Mon, Aug 19, 2019 at 07:56:11AM -0500, Dimitri Sivanich wrote: > >>Reviewed-by: Dimitri Sivanich > >Thanks! > > > >John, would you like to take this patch into your miscellaneous > >

Re: [PATCH v8 11/28] x86/asm/head: annotate data appropriatelly

2019-08-20 Thread Borislav Petkov
> Subject: Re: [PATCH v8 11/28] x86/asm/head: annotate data appropriatelly appropriately On Thu, Aug 08, 2019 at 12:38:37PM +0200, Jiri Slaby wrote: > Use the new SYM_DATA, SYM_DATA_START, and SYM_DATA_END in both 32 and 64 > bit heads. In the 64-bit version, define also > SYM_DATA_START_PAGE_AL

[PATCH 2/3] ASoC: mchp-i2s-mcc: Fix unprepare of GCLK

2019-08-20 Thread Codrin Ciubotariu
If hw_free() gets called after hw_params(), GCLK remains prepared, preventing further use of it. This patch fixes this by unpreparing the clock in hw_free() or if hw_params() gets an error. Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller") Signed-off-by: Cod

[PATCH 1/3] ASoC: mchp-i2s-mcc: Wait for RX/TX RDY only if controller is running

2019-08-20 Thread Codrin Ciubotariu
Since hw_free() can be called multiple times and not just after a stop trigger command, we should check whether the RX or TX ready interrupt was truly enabled previously. For this, we assure that the condition of the wait event is always true, except when RX/TX interrupts are enabled. Fixes: 7e0cd

[PATCH 3/3] ASoC: mchp-i2s-mcc: Fix simultaneous capture and playback in master mode

2019-08-20 Thread Codrin Ciubotariu
This controller supports capture and playback running at the same time, with the limitation that both capture and playback must be configured the same way (sample rate, sample format, number of channels, etc). For this, we have to assure that the configuration registers look the same when capture a

Re: [PATCH v4 1/2] dt-bindings: arm: imx: add imx8mq nitrogen support

2019-08-20 Thread Dafna Hirschfeld
On Mon, 2019-08-19 at 14:08 -0500, Rob Herring wrote: > On Mon, Aug 19, 2019 at 12:26 PM Dafna Hirschfeld > wrote: > > From: Gary Bisson > > > > The Nitrogen8M is an ARM based single board computer (SBC) > > designed to leverage the full capabilities of NXP’s i.MX8M > > Quad processor. > > > >

Re: [PATCH v8 08/20] adfs: Fill in max and min timestamps in sb

2019-08-20 Thread Matthew Wilcox
On Sun, Aug 18, 2019 at 09:58:05AM -0700, Deepa Dinamani wrote: > Note that the min timestamp is assumed to be > 01 Jan 1970 00:00:00 (Unix epoch). This is consistent > with the way we convert timestamps in adfs_adfs2unix_time(). That's not actually correct. RISC OS timestamps are centiseconds si

Re: [PATCH v2 4/4] leds: lm3532: Add full scale current configuration

2019-08-20 Thread Pavel Machek
Hi! > >No need to move ctrl_brt_pointer... to keep order consistent with docs. > > OK I will reset the patches and get rid of that change.  I think this got > moved when I applied the v1 patch. > > > >>+ fs_current_val = led->full_scale_current - LM3532_FS_CURR_MIN / > >>+

RE: [PATCH] net/ncsi: add control packet payload to NC-SI commands from netlink

2019-08-20 Thread Justin.Lee1
Hi Ben, > Hi Justin, > > > Hi Ben, > > > > I have similar fix locally with different approach as the command handler > > may have some expectation for those byes. > > We can use NCSI_PKT_CMD_OEM handler as it only copies data based on the > > payload length. > > Great! Yes I was thinking the

Re: [PATCH] powerpc: Allow flush_(inval_)dcache_range to work across ranges >4GB

2019-08-20 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2019 at 09:14:12AM +0200, Greg Kroah-Hartman wrote: > On Fri, Aug 16, 2019 at 11:42:22AM +1000, Michael Ellerman wrote: > > Greg Kroah-Hartman writes: > > > On Thu, Aug 15, 2019 at 02:55:42PM +1000, Alastair D'Silva wrote: > > >> From: Alastair D'Silva > > >> > > >> Heads Up: Thi

Re: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Cornelia Huck
On Tue, 20 Aug 2019 11:25:05 + Parav Pandit wrote: > > -Original Message- > > From: Christophe de Dinechin > > Subject: Re: [PATCH v2 0/2] Simplify mtty driver and mdev core > > > > > > Parav Pandit writes: > > > > > + Dave. > > > > > > Hi Jiri, Dave, Alex, Kirti, Cornelia, > >

Re: [PATCH 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-20 Thread Kees Cook
On Tue, Aug 20, 2019 at 12:58:49PM +0200, Christophe Leroy wrote: > Le 20/08/2019 à 12:06, Peter Zijlstra a écrit : > > On Mon, Aug 19, 2019 at 04:41:11PM -0700, Kees Cook wrote: > > > > > diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h > > > index 588dd59a5b72..da471fcc5487 100

Re: [PATCH 2/6] dt-bindings: net: sun8i-a83t-emac: Add phy-io-supply property

2019-08-20 Thread Ondřej Jirman
On Tue, Aug 20, 2019 at 11:20:22AM -0500, Rob Herring wrote: > On Tue, Aug 20, 2019 at 9:53 AM wrote: > > > > From: Ondrej Jirman > > > > Some PHYs require separate power supply for I/O pins in some modes > > of operation. Add phy-io-supply property, to allow enabling this > > power supply. > >

[PATCH] mm/balloon_compaction: suppress allocation warnings

2019-08-20 Thread Nadav Amit
There is no reason to print warnings when balloon page allocation fails, as they are expected and can be handled gracefully. Since VMware balloon now uses balloon-compaction infrastructure, and suppressed these warnings before, it is also beneficial to suppress these warnings to keep the same beha

Re: [PATCH] x86/mm/pti: in pti_clone_pgtable() don't increase addr by PUD_SIZE

2019-08-20 Thread Song Liu
> On Aug 20, 2019, at 9:05 AM, Song Liu wrote: > > > >> On Aug 20, 2019, at 7:18 AM, Dave Hansen wrote: >> >> On 8/20/19 7:14 AM, Song Liu wrote: *But*, that shouldn't get hit on a Skylake CPU since those have PCIDs and shouldn't have a global kernel image. Could you confirm whe

Re: [PATCH v2 1/8] arm64: dts: qcom: sm8150: add base dts file

2019-08-20 Thread Vinod Koul
On 20-08-19, 19:03, Amit Kucheria wrote: > On Tue, Aug 20, 2019 at 12:14 PM Vinod Koul wrote: > > > > This add base DTS file with cpu, psci, firmware, clock, tlmm and > > spmi nodes which enables boot to console > > > > Signed-off-by: Vinod Koul > > --- > > arch/arm64/boot/dts/qcom/sm8150.dtsi |

Re: [PATCH V40 19/29] lockdown: Lock down module params that specify hardware parameters (eg. ioport)

2019-08-20 Thread Jessica Yu
+++ Matthew Garrett [19/08/19 17:17 -0700]: From: David Howells Provided an annotation for module parameters that specify hardware parameters (such as io ports, iomem addresses, irqs, dma channels, fixed dma buffers and other types). Suggested-by: Alan Cox Signed-off-by: David Howells Signed

Re: [PATCH RFC] dt-bindings: regulator: define a mux regulator

2019-08-20 Thread Rob Herring
On Tue, Aug 20, 2019 at 10:25 AM Uwe Kleine-König wrote: > > A mux regulator is used to provide current on one of several outputs. It > might look as follows: > > ,. > -- -- -- -- -- -- -- -- `' > > Depending on which address is e

Re: [PATCH v5] ata/pata_buddha: Probe via modalias instead of initcall

2019-08-20 Thread Max Staudt
Hi Bartlomiej, On 08/20/2019 02:06 PM, Bartlomiej Zolnierkiewicz wrote: > WARNING: line over 80 characters > #354: FILE: drivers/ata/pata_buddha.c:287: > +while ((z = > zorro_find_device(ZORRO_PROD_INDIVIDUAL_COMPUTERS_X_SURF, z))) { I see no good way to shorten this one. I think it's ob

Re: [PATCH 4.14 04/33] tcp: be more careful in tcp_fragment()

2019-08-20 Thread Matthieu Baerts
Hi Eric, On 08/08/2019 21:05, Greg Kroah-Hartman wrote: > commit b617158dc096709d8600c53b6052144d12b89fab upstream. > > Some applications set tiny SO_SNDBUF values and expect > TCP to just work. Recent patches to address CVE-2019-11478 > broke them in case of losses, since retransmits might > be

[PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-20 Thread Kees Cook
The original clean up of "cut here" missed the WARN_ON() case (that does not have a printk message), which was fixed recently by adding an explicit printk of "cut here". This had the downside of adding a printk() to every WARN_ON() caller, which reduces the utility of using an instruction exception

<    4   5   6   7   8   9   10   11   12   >