Re: [PATCH v2 00/16] Remove uninitialized_var() macro

2020-06-20 Thread Sedat Dilek
On Sat, Jun 20, 2020 at 5:30 AM Kees Cook wrote: > > v2: > - more special-cased fixes > - add reviews > v1: > https://lore.kernel.org/lkml/20200603233203.1695403-1-keesc...@chromium.org > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppres

[PATCH 03/10] fs: remove an unused block_device_operations forward declaration

2020-06-20 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/linux/fs.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index b1c960e9b84e3a..0d282c853691a3 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1774,8 +1774,6 @@ struct dir_context { lof

[PATCH 04/10] fs: remove the HAVE_UNLOCKED_IOCTL and HAVE_COMPAT_IOCTL defines

2020-06-20 Thread Christoph Hellwig
These are not defined anywhere, and contrary to the comments we really do not care about out of tree code at all. Signed-off-by: Christoph Hellwig --- include/linux/fs.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 0d282c853691a3..224edcc

[PATCH 10/10] block: move struct block_device to blk_types.h

2020-06-20 Thread Christoph Hellwig
Move the struct block_device definition together with most of the block layer definitions, as it has nothing to do with the rest of fs.h. Signed-off-by: Christoph Hellwig --- fs/adfs/super.c | 1 + fs/befs/linuxvfs.c| 1 + fs/efs/super.c| 1 + fs/jfs/jfs_mount.c

[PATCH 06/10] block: simplify sb_is_blkdev_sb

2020-06-20 Thread Christoph Hellwig
Just use IS_ENABLED instead of providing a stub for !CONFIG_BLOCK. Signed-off-by: Christoph Hellwig --- include/linux/fs.h | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 9ee09e2b5a9716..7f3ae38335d4b3 100644 -

[PATCH 02/10] block: mark bd_finish_claiming static

2020-06-20 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/block_dev.c | 5 ++--- include/linux/fs.h | 2 -- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index 0ae656e022fd57..0e0d43dc27d331 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -1187,8 +1187,8 @@

[PATCH 09/10] block: reduce ifdef CONFIG_BLOCK madness in headers

2020-06-20 Thread Christoph Hellwig
Large part of bio.h, blkdev.h and genhd.h are under ifdef CONFIG_BLOCK for no good reason. Only stub out function that are called from code that is not dependent on CONFIG_BLOCK and leave the harmless other declarations around. Signed-off-by: Christoph Hellwig --- include/linux/bio.h| 3 --

[PATCH 01/10] tty/sysrq: emergency_thaw_all does not depend on CONFIG_BLOCK

2020-06-20 Thread Christoph Hellwig
We can also thaw non-block file systems. Remove the CONFIG_BLOCK in sysrq.c after making the prototype available unconditionally. Signed-off-by: Christoph Hellwig --- drivers/tty/sysrq.c | 2 -- include/linux/fs.h | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tt

[PATCH 08/10] fs: move the buffer_heads_over_limit stub to buffer_head.h

2020-06-20 Thread Christoph Hellwig
Move the !CONFIG_BLOCK stub to the same place as the non-stub declaration. Signed-off-by: Christoph Hellwig --- include/linux/blkdev.h | 1 - include/linux/buffer_head.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index

move block bits out of fs.h

2020-06-20 Thread Christoph Hellwig
Hi Jens, this series removes various remaining block bits out of fs.h and cleans up a few loose ends around that. Diffstat: drivers/tty/sysrq.c |2 fs/adfs/super.c |1 fs/affs/file.c |1 fs/befs/linuxvfs.c |1 fs/block_dev.c

[PATCH 07/10] block: move block-related definitions out of fs.h

2020-06-20 Thread Christoph Hellwig
Move most of the block related definition out of fs.h into more suitable headers. Signed-off-by: Christoph Hellwig --- fs/affs/file.c | 1 + fs/hfs/inode.c | 1 + fs/internal.h | 17 ++- fs/ntfs/dir.c | 1 + fs/proc/devices.c | 1

[PATCH 05/10] fs: remove the mount_bdev and kill_block_super stubs

2020-06-20 Thread Christoph Hellwig
No one calls these functions without CONFIG_BLOCK, so don't bother stubbing them out. Signed-off-by: Christoph Hellwig --- include/linux/fs.h | 16 1 file changed, 16 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 224edcc5b56e62..9ee09e2b5a9716 100644 -

Re: [PATCH 01/10] tty/sysrq: emergency_thaw_all does not depend on CONFIG_BLOCK

2020-06-20 Thread Greg Kroah-Hartman
On Sat, Jun 20, 2020 at 09:16:35AM +0200, Christoph Hellwig wrote: > We can also thaw non-block file systems. Remove the CONFIG_BLOCK in > sysrq.c after making the prototype available unconditionally. > > Signed-off-by: Christoph Hellwig > --- > drivers/tty/sysrq.c | 2 -- > include/linux/fs.h

Re: [PATCH] i2c: mediatek: Add to support continuous mode

2020-06-20 Thread Yingjoe Chen
On Fri, 2020-06-19 at 16:06 +0800, Qiangming Xia wrote: > From: "qiangming.xia" Please make 'From:' the same to Signed-off-by. > Mediatek i2c controller support for continuous mode, > it allow to transfer once multiple writing messages of equal length. So the limitations are writing to s

Re: [PATCH v7 6/8] blktrace: fix debugfs use after free

2020-06-20 Thread Christoph Hellwig
Still not a fan of the wall of text in the commit log, but the changes look good: Reviewed-by: Christoph Hellwig

Re: [PATCH v7 7/8] blktrace: ensure our debugfs dir exists

2020-06-20 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v7 8/8] block: create the request_queue debugfs_dir on registration

2020-06-20 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: Parallel compilation performance regression

2020-06-20 Thread Sedat Dilek
On Sat, Jun 20, 2020 at 5:53 AM Derrick, Jonathan wrote: > > On Thu, 2020-06-18 at 18:05 -0700, Matthew Wilcox wrote: > > On Thu, Jun 18, 2020 at 11:52:55PM +, Derrick, Jonathan wrote: > > > Hi David, > > > > > > I've been experiencing a performance regression when running a parallel > > > com

Re: [PATCH 4.4 000/101] 4.4.228-rc1 review

2020-06-20 Thread Greg Kroah-Hartman
On Fri, Jun 19, 2020 at 09:40:55AM -0700, Guenter Roeck wrote: > On Fri, Jun 19, 2020 at 04:31:49PM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.4.228 release. > > There are 101 patches in this series, all will be posted as a response > > to this one.

Re: [PATCH v2 2/2] i2c: mediatek: Add i2c ac-timing adjust support

2020-06-20 Thread Yingjoe Chen
Sorry for late review. On Thu, 2020-05-14 at 21:09 +0800, Qii Wang wrote: > This patch adds a algorithm to calculate some ac-timing parameters > which can fully meet I2C Spec. > > Signed-off-by: Qii Wang > --- > drivers/i2c/busses/i2c-mt65xx.c | 328 > +---

Re: debugfs_create_u32_array() memory leaks

2020-06-20 Thread Greg Kroah-Hartman
On Fri, Jun 19, 2020 at 04:17:34PM -0700, Jakub Kicinski wrote: > Hi! > > I'm trying to use debugfs_create_u32_array() in drivers/net/netdevsim > and it causes memory leaks: > > unreferenced object 0x8880546642a0 (size 16): > comm "test_udp_tuns.s", pid 2146, jiffies 4294928368 (age 3772.43

[PATCH] Replace HTTP links with HTTPS ones: Documentation/sphinx/parse-headers.pl

2020-06-20 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: If both the HTTP and

Re: [PATCH] linux++, this: rename "struct notifier_block *this"

2020-06-20 Thread Alexey Dobriyan
On Fri, Jun 19, 2020 at 11:37:47AM -0700, Linus Torvalds wrote: > On Thu, Jun 18, 2020 at 2:06 PM Alexey Dobriyan wrote: > > > > Rename > > struct notifier_block *this > > to > > struct notifier_block *nb > > > > "nb" is arguably a better name for notifier block. > > Maybe it's a

Re: [PATCH 5.4 000/261] 5.4.48-rc1 review

2020-06-20 Thread Greg Kroah-Hartman
On Fri, Jun 19, 2020 at 09:01:18AM -0700, Guenter Roeck wrote: > On Fri, Jun 19, 2020 at 04:30:11PM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.48 release. > > There are 261 patches in this series, all will be posted as a response > > to this one.

Re: [PATCH 4.19 172/267] net: ethernet: fec: move GPR register offset and bit into DT

2020-06-20 Thread Greg Kroah-Hartman
On Fri, Jun 19, 2020 at 11:04:32PM +0200, Pavel Machek wrote: > Hi! > > > [ Upstream commit 8a448bf832af537d26aa557d183a16943dce4510 ] > > > > The commit da722186f654 (net: fec: set GPR bit on suspend by DT > > configuration) set the GPR reigster offset and bit in driver for > > wake on lan featu

Re: [EXT] Re: stress-ng --hrtimers hangs system

2020-06-20 Thread Kurt Kanzenbach
Hi Jiafei, On Friday, June 12, 2020 2:49:17 AM CEST Jiafei Pan wrote: > Hi, Kurt, > > May I know whether you used "root" user to run stress-ng? using "root" > user will change the scheduler to be "SCHED_RR", so would you please > share test result with root and non-root users? Thanks. Performed

cc1: warning: drivers/staging/media/atomisp//pci/hive_isp_css_include/memory_access/: No such file or directory

2020-06-20 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4333a9b0b67bb4e8bcd91bdd80da80b0ec151162 commit: 08fef4fa947ba75cbf59d67c6be75223c6471a88 media: atomisp: get rid of memory_access.c date: 9 days ago config: i386-allyesconfig (attached as .config) compile

Re: [PATCH 4.4 000/101] 4.4.228-rc1 review

2020-06-20 Thread Naresh Kamboju
On Fri, 19 Jun 2020 at 20:07, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.4.228 release. > There are 101 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Re

[PATCH 4.19 000/265] 4.19.129-rc2 review

2020-06-20 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.129 release. There are 265 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Mon, 22 Jun 2020 08:21:23 +. Anything r

[PATCH 5.4 000/259] 5.4.48-rc2 review

2020-06-20 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.4.48 release. There are 259 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Mon, 22 Jun 2020 08:21:26 +. Anything rec

Re: [PATCH 5.4 000/261] 5.4.48-rc1 review

2020-06-20 Thread Greg Kroah-Hartman
On Sat, Jun 20, 2020 at 10:00:06AM +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 19, 2020 at 09:01:18AM -0700, Guenter Roeck wrote: > > On Fri, Jun 19, 2020 at 04:30:11PM +0200, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 5.4.48 release. > > > There are 261

Re: [PATCH] perf list: Fix memory leak in print_sdt_events()

2020-06-20 Thread Markus Elfring
> Valgrind check info: I suggest to improve this change description a bit. * Would an additional imperative wording be nice (despite of the presented “leak summary”)? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=4333a

ERROR: modpost: "__mulsi3" undefined!

2020-06-20 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4333a9b0b67bb4e8bcd91bdd80da80b0ec151162 commit: f23efcbcc523b09c2ee359a35eb3897dc1764fd3 crypto: ctr - no longer needs CRYPTO_SEQIV date: 7 weeks ago config: openrisc-randconfig-c003-20200620 (attached

[PATCH v2] nbd: Fix memory leak in nbd_add_socket

2020-06-20 Thread Zheng Bin
If we add first socket to nbd, config->socks is malloced but num_connections does not update(nsock's allocation fail), the memory is leaked. Cause in later nbd_config_put(), will only free config->socks when num_connections is not 0. Let nsock's allocation first to avoid this. Fixes: 03bf73c315ed

[PATCH v2] drm/amd: fix potential memleak in err branch

2020-06-20 Thread Bernard Zhao
The function kobject_init_and_add alloc memory like: kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller ->kmalloc_slab, in err branch this memory not free. If use kmemleak, this path maybe catched. These changes are to add

Re: [PATCH v7 2/3] serial: 8250_dw: Simplify the ref clock rate setting procedure

2020-06-20 Thread Russell King - ARM Linux admin
On Fri, Jun 19, 2020 at 11:02:50PM +0300, Serge Semin wrote: > Really instead of twice checking the clk_round_rate() return value > we could do it once, and if it isn't error the clock rate can be changed. > By doing so we decrease a number of ret-value tests and remove a weird > goto-based constru

xilinx_axienet_main.c:undefined reference to `devm_ioremap_resource'

2020-06-20 Thread kernel test robot
Hi Brendan, It's probably a bug fix that unveils the link errors. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4333a9b0b67bb4e8bcd91bdd80da80b0ec151162 commit: 1af73a25e6e7d9f2f1e2a14259cc9ffce6d8f6d4 staging: exfat: fix multiple definition error of

Re: [PATCH 2/2] riscv: Use PUD/PGDIR entries for linear mapping when possible

2020-06-20 Thread Alex Ghiti
Hi Atish, Le 6/19/20 à 2:16 PM, Atish Patra a écrit : On Thu, Jun 18, 2020 at 9:28 PM Alex Ghiti wrote: Hi Atish, Le 6/18/20 à 8:47 PM, Atish Patra a écrit : On Wed, Jun 3, 2020 at 8:38 AM Alexandre Ghiti wrote: Improve best_map_size so that PUD or PGDIR entries are used for linear mapping

Re: [PATCH 2/2] PCI: pciehp: Fix wrong failure check on pcie_capability_read_*()

2020-06-20 Thread Lukas Wunner
On Fri, Jun 19, 2020 at 10:12:19PM +0200, refactormys...@gmail.com wrote: > On failure, pcie_capabiility_read_*() will set the status value, > its last parameter to 0 and not ~0. > This bug fix checks for the proper value. If a config space read times out, the PCIe controller fabricates an "all on

[PATCH v3] drm/amd: fix potential memleak in err branch

2020-06-20 Thread Bernard Zhao
The function kobject_init_and_add alloc memory like: kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller ->kmalloc_slab, in err branch this memory not free. If use kmemleak, this path maybe catched. These changes are to add

Re: [PATCH 7/8] scsi: storvsc: Introduce the per-storvsc_device spinlock

2020-06-20 Thread Wei Liu
On Fri, Jun 19, 2020 at 10:58:40PM -0400, Martin K. Petersen wrote: > > Andrea, > > >> This patch should go via the hyperv tree because a later patch is > >> dependent on it. It requires and ack from SCSI maintainers though. > > Looks OK to me. > > Acked-by: Martin K. Petersen Thanks Martin.

Re: [PATCH v2] drm/amdkfd: Fix memory leaks according to error branches

2020-06-20 Thread Markus Elfring
> The function kobject_init_and_add alloc memory like: > kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs > ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller > ->kmalloc_slab, in err branch this memory not free. If use > kmemleak, this path maybe catched. > These change

[tip:auto-latest] BUILD SUCCESS 03e5e9954269d02edd5f6d3a73d579a60dd38c38

2020-06-20 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git auto-latest branch HEAD: 03e5e9954269d02edd5f6d3a73d579a60dd38c38 Merge branch 'locking/core' elapsed time: 730m configs tested: 115 configs skipped: 10 The following configs have been built successfully. More conf

[PATCH mips-next 0/3] MIPS: fix the two most annoying sparse floods

2020-06-20 Thread Alexander Lobakin
This set addresses the two most annoying sparse floods when building the tree with C={1,2}: one in asm/io.h (in several mangle-port.h actually), and one in asm/checksum.h. Both of these comes from lack of forced typecasting and hence harmless, but complicates real bug hunting, as asm/io.h is includ

[PATCH mips-next 2/3] MIPS: io: fix sparse flood on asm/io.h

2020-06-20 Thread Alexander Lobakin
MIPS MMIO macros for byteswapping from/to hardware endianness are a bit tricky because they use cpu_to_le{16,32,64}() in both directions. This generates a lot of questions from sparse as __le{16,32,64} types are 'restricted' and direct cast is forbidden in order to prevent messing up the byteorder.

[PATCH mips-next 1/3] MIPS: generic/ip32: io: fix __mem_ioswabq()

2020-06-20 Thread Alexander Lobakin
*readq() family operates with u64 arguments, so they need 64-bit byteswaps. Correct macros for Generic MIPS and IP-32 to match other machines' implementations. Signed-off-by: Alexander Lobakin --- arch/mips/include/asm/mach-generic/mangle-port.h | 2 +- arch/mips/include/asm/mach-ip32/mangle-por

[PATCH mips-next 3/3] MIPS: checksum: fix sparse flooding on asm/checksum.h

2020-06-20 Thread Alexander Lobakin
csum_fold() in MIPS' asm/checksum.h is another source of sparse flooding when building different networking source code. The thing is that only half of __wsum <--> u32 casts inside the funtion is forced, which is insufficient. Add all necessary forced typecasting to stop floods and simplify actual

Re: [PATCH v2] drm/amdkfd: Fix memory leaks according to error branches

2020-06-20 Thread Julia Lawall
On Sat, 20 Jun 2020, Markus Elfring wrote: > > The function kobject_init_and_add alloc memory like: > > kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs > > ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller > > ->kmalloc_slab, in err branch this memory not free. If u

[PATCH net-next v1 2/5] hinic: add support to set and get irq coalesce

2020-06-20 Thread Luo bin
add support to set TX/RX irq coalesce params with ethtool -C and get these params with ethtool -c. Signed-off-by: Luo bin --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 8 + .../net/ethernet/huawei/hinic/hinic_ethtool.c | 294 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.

[PATCH net-next v1 3/5] hinic: add self test support

2020-06-20 Thread Luo bin
add support to excute internal and external loopback test with ethtool -t cmd. Signed-off-by: Luo bin --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 6 + .../net/ethernet/huawei/hinic/hinic_ethtool.c | 178 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 3 + .../net/

[PATCH net-next v1 4/5] hinic: add support to identify physical device

2020-06-20 Thread Luo bin
add support to identify physical device by flashing an LED attached to it with ethtool -p cmd. Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 41 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 2 + .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 1 +

[PATCH net-next v1 0/5] hinic: add some ethtool ops support

2020-06-20 Thread Luo bin
patch #1: support to set and get pause params with "ethtool -A/a" cmd patch #2: support to set and get irq coalesce params with "ethtool -C/c" cmd patch #3: support to do self test with "ethtool -t" cmd patch #4: support to identify physical device with "ethtool -p" cmd patch #5

[PATCH net-next v1 1/5] hinic: add support to set and get pause params

2020-06-20 Thread Luo bin
add support to set pause params with ethtool -A and get pause params with ethtool -a. Also remove set_link_ksettings ops for VF and enable pause by default. Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 96 ++- .../net/ethernet/huawei/hinic/hinic_hw_d

[PATCH net-next v1 5/5] hinic: add support to get eeprom information

2020-06-20 Thread Luo bin
add support to get eeprom information from the plug-in module with ethtool -m cmd. Signed-off-by: Luo bin --- V0->V1: remove unused variable port_id .../net/ethernet/huawei/hinic/hinic_ethtool.c | 68 + .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 4 + .../net/ethernet/huawe

Re: [PATCH 4.4 000/101] 4.4.228-rc1 review

2020-06-20 Thread Jon Hunter
On 19/06/2020 15:31, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.228 release. > There are 101 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses s

Re: [PATCH 4.9 000/128] 4.9.228-rc1 review

2020-06-20 Thread Jon Hunter
On 19/06/2020 15:31, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.228 release. > There are 128 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses s

Re: [PATCH 4.14 000/190] 4.14.185-rc1 review

2020-06-20 Thread Jon Hunter
On 19/06/2020 15:30, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.185 release. > There are 190 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [PATCH 4.19 000/265] 4.19.129-rc2 review

2020-06-20 Thread Jon Hunter
On 20/06/2020 09:22, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.129 release. > There are 265 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [PATCH 5.4 000/259] 5.4.48-rc2 review

2020-06-20 Thread Jon Hunter
On 20/06/2020 09:23, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.4.48 release. > There are 259 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses sh

Re: [PATCH 5.7 000/376] 5.7.5-rc1 review

2020-06-20 Thread Jon Hunter
On 19/06/2020 15:28, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.7.5 release. > There are 376 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses sho

Re: [PATCH] [v3] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-06-20 Thread Jon Hunter
On 19/06/2020 02:59, dinghao@zju.edu.cn wrote: >> >> Why noidle? >> > > _noidle is enough for fixing this bug. _sync may suspend > the device beyond expectation. In that case, then the other instance you are fixing with this patch is not correct. Jon -- nvpublic

[tip: x86/cleanups] x86/idt: Make idt_descr static

2020-06-20 Thread tip-bot2 for Jason Andryuk
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: 286d966b21587b6303081b902f5c5e30b691baf5 Gitweb: https://git.kernel.org/tip/286d966b21587b6303081b902f5c5e30b691baf5 Author:Jason Andryuk AuthorDate:Fri, 19 Jun 2020 16:51:02 -04:00 Commit

Re: [PATCH v3 2/2] media: vimc: Add a control to display info on test image

2020-06-20 Thread Dafna Hirschfeld
Hi, thanks for the patch On 18.06.20 21:05, Kaaira Gupta wrote: Add a control in VIMC to display information such as the correct oder of colors for a given test pattern, brightness, hue, saturation, contrast and, width and height at sensor over test image; and display that information. Signed-o

Re: [PATCH v1 0/6] mfd: Make use of software nodes

2020-06-20 Thread Andy Shevchenko
On Sat, Jun 20, 2020 at 1:12 AM Serge Semin wrote: > On Thu, Jun 18, 2020 at 11:56:54AM +0300, Andy Shevchenko wrote: > > On Wed, Jun 17, 2020 at 01:56:48AM +0300, Serge Semin wrote: > > > On Wed, Jun 17, 2020 at 12:40:35AM +0300, Andy Shevchenko wrote: > > > > On Tue, Jun 16, 2020 at 11:03 PM Ser

riscv64-linux-objcopy: 'arch/riscv/kernel/vdso/vdso.so.dbg': No such file

2020-06-20 Thread kernel test robot
Hi Vincent, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4333a9b0b67bb4e8bcd91bdd80da80b0ec151162 commit: ad5d1122b82fbd6a816d1b9d26ee01a6dbc2d757 riscv: use vDSO common flow to reduce the latency of the time-rel

Re: [PATCH] drm/msm/dpu: Fix usage of ERR_PTR()

2020-06-20 Thread Zenghui Yu
ping for this obvious fix... On 2020/5/28 21:08, Zenghui Yu wrote: ERR_PTR() is used in the kernel to encode an usual *negative* errno code into a pointer. Passing a positive value (ENOMEM) to it will break the following IS_ERR() check. Though memory allocation is unlikely to fail, it's still

[PATCH net-next v5 0/3] net: dsa: qca8k: Improve SGMII interface handling

2020-06-20 Thread Jonathan McDowell
This 3 patch series migrates the qca8k switch driver over to PHYLINK, and then adds the SGMII clean-ups (i.e. the missing initialisation) on top of that as a second patch. The final patch is a simple spelling fix in a comment. As before, tested with a device where the CPU connection is RGMII (i.e.

[PATCH net-next v5 2/3] net: dsa: qca8k: Improve SGMII interface handling

2020-06-20 Thread Jonathan McDowell
This patch improves the handling of the SGMII interface on the QCA8K devices. Previously the driver did no configuration of the port, even if it was selected. We now configure it up in the appropriate PHY/MAC/Base-X mode depending on what phylink tells us we are connected to and ensure it is enable

[PATCH net-next v5 3/3] net: dsa: qca8k: Minor comment spelling fix

2020-06-20 Thread Jonathan McDowell
Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 11d1c290d90f..4acad5fa0c84 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -647,7 +647,7 @

Re: [PATCH v3 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-06-20 Thread Sam Ravnborg
Hi Vinay. > + > +static int tc_probe(struct i2c_client *client, const struct i2c_device_id > *id) > +{ > + struct device *dev = &client->dev; > + struct drm_panel *panel; > + struct tc_data *tc; > + int ret; > + > + tc = devm_kzalloc(dev, sizeof(*tc), GFP_KERNEL); > + if (

[PATCH net-next v5 1/3] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-20 Thread Jonathan McDowell
Update the driver to use the new PHYLINK callbacks, removing the legacy adjust_link callback. Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 306 +++- 1 file changed, 210 insertions(+), 96 deletions(-) diff --git a/drivers/net/dsa/qca8k.c b/dr

[PATCH] sched: fix build with GCC_PLUGIN_RANDSTRUCT

2020-06-20 Thread Mike Rapoport
From: Mike Rapoport Since the commit a148866489fb ("sched: Replace rq::wake_list") task_struct and CSD_TYPE_TTWU objects can be on the same queue and this requires that have "layout similar enough". This assumption is broken when CONFIG_GCC_PLUGIN_RANDSTRUCT is enabled: CHK include/genera

Re: INFO: trying to register non-static key in ath9k_htc_rxep

2020-06-20 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:f8f02d5c USB: OTG: rename product list of devices git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing console output: https://syzkaller.appspot.com/x/log.txt?x=15fd18a510 kernel co

Re:Re: [PATCH v2] drm/amdkfd: Fix memory leaks according to error branches

2020-06-20 Thread Bernard
From: Julia Lawall Date: 2020-06-20 17:37:19 To: Markus Elfring Cc: Bernard Zhao ,opensource.ker...@vivo.com,amd-...@lists.freedesktop.org,dri-de...@lists.freedesktop.org,kernel-janit...@vger.kernel.org,linux-kernel@vger.kernel.org,Alex Deucher ,"Christian König" ,"Felix Kühling" ,Daniel

Re: [PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister()

2020-06-20 Thread Sam Ravnborg
Hi Wei. On Thu, Jun 18, 2020 at 01:46:50PM +, Wei Yongjun wrote: > It's not necessary to unregister backlight device which > registered with devm_backlight_device_register(). > > Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API") > Reported-by: Hulk Robot > Signed-off-by: Wei

Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels

2020-06-20 Thread Sam Ravnborg
Hi Dmitry On Thu, Jun 18, 2020 at 01:27:03AM +0300, Dmitry Osipenko wrote: > The DRM panel bridge core requires connector type to be set up properly, > otherwise it rejects the panel. The missing connector type problem popped > up while I was trying to wrap CLAA070WP03XG panel into a DRM bridge in

Re:Re: [PATCH v2] drm/amdkfd: Fix memory leaks according to error branches

2020-06-20 Thread Julia Lawall
On Sat, 20 Jun 2020, Bernard wrote: > > > From: Julia Lawall > Date: 2020-06-20 17:37:19 > To: Markus Elfring > Cc: Bernard Zhao > ,opensource.ker...@vivo.com,amd-...@lists.freedesktop.org,dri-de...@lists.freedesktop.org,kernel-janit...@vger.kernel.org,linux-kernel@vger.kernel.org,Alex > D

Re: [PATCH][next] fbdev/fb.h: Use struct_size() helper in kzalloc()

2020-06-20 Thread Sam Ravnborg
Hi Gustavo. On Wed, Jun 17, 2020 at 12:56:47PM -0500, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > >

Re: [PATCH v1 3/8] powerpc: Set user/kernel boundary at TASK_SIZE instead of PAGE_OFFSET

2020-06-20 Thread kernel test robot
-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/powerpc-32s-Allocate-modules-outside-of-vmalloc-space-for-STRICT_KERNEL_RWX/20200620-001346 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc64-randconfig

arch/x86/include/asm/preempt.h:79:9: sparse: sparse: context imbalance in 'xfs_iflush_abort' - wrong count at exit

2020-06-20 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4333a9b0b67bb4e8bcd91bdd80da80b0ec151162 commit: 4165994ac9672d91134675caa6de3645a9ace6c8 xfs: factor common AIL item deletion code date: 3 months ago config: i386-randconfig-s002-20200620 (attached as

May the Peace of the Lord be with you

2020-06-20 Thread Mrs Maria Talley
May the Peace of the Lord be with you! Please this is an urgent solicitation for assistance, I'm Mrs Maria Talley from United States of America, but I lived in London for many years. I am 54 years old. I was diagnosed of cancer for about 2 years ago. This letter comes from a devastated, sorrowf

Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels

2020-06-20 Thread Laurent Pinchart
Hi Sam and Dmitry, On Sat, Jun 20, 2020 at 01:21:32PM +0200, Sam Ravnborg wrote: > On Thu, Jun 18, 2020 at 01:27:03AM +0300, Dmitry Osipenko wrote: > > The DRM panel bridge core requires connector type to be set up properly, > > otherwise it rejects the panel. The missing connector type problem po

Re: [PATCH v1 3/8] powerpc: Set user/kernel boundary at TASK_SIZE instead of PAGE_OFFSET

2020-06-20 Thread kernel test robot
-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/powerpc-32s-Allocate-modules-outside-of-vmalloc-space-for-STRICT_KERNEL_RWX/20200620-001346 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-randconfig

Re: [PATCH v2] nbd: Fix memory leak in nbd_add_socket

2020-06-20 Thread Markus Elfring
> If we add first socket to nbd, config->socks is malloced but > num_connections does not update(nsock's allocation fail), the memory > is leaked. Cause in later nbd_config_put(), will only free config->socks > when num_connections is not 0. > > Let nsock's allocation first to avoid this. I sugges

Re: riscv64-linux-objcopy: 'arch/riscv/kernel/vdso/vdso.so.dbg': No such file

2020-06-20 Thread Vincent Chen
On Sat, Jun 20, 2020 at 6:11 PM kernel test robot wrote: > > Hi Vincent, > > FYI, the error/warning still remains. > I have found out the root cause of this error and I will send a patch to fix it in a couple of days. Thanks for pointing out my mistake. > tree: https://git.kernel.org/pub/scm/li

[PATCH v2] platform/x86: Add new intel_atomisp2_led driver

2020-06-20 Thread Hans de Goede
Many Bay Trail and Cherry Trail devices come with a camera attached to Intel's Image Signal Processor. Linux currently does not have a driver for these, so they do not work as a camera. Some of these camera's have a status LED which is controlled through a GPIO in some cases, e.g. on the Asus T100

Re: [PATCH v3] drm/amd: Fix memory leak according to error branch

2020-06-20 Thread Markus Elfring
> The function kobject_init_and_add alloc memory like: > kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs > ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller > ->kmalloc_slab, in err branch this memory not free. If use > kmemleak, this path maybe catched. > These change

[no subject]

2020-06-20 Thread Mehmet Osman Pisir
Hello Friend, How are you, Please my previous email you did not reply it

Re: [PATCH v2] drm/amdkfd: Fix memory leaks according to error branches

2020-06-20 Thread Markus Elfring
>> I suggest to improve this change description. >> >> * Can an other wording variant be nicer? > > Markus's suggestion is as usual extremely imprecise. I pointed a general possibility out. I did not propose an exact wording alternative as it happened for other patches. > However, I also find th

Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-06-20 Thread Vadym Kochan
Hi Ido, On Wed, Jun 03, 2020 at 12:23:58PM +0300, Ido Schimmel wrote: > On Mon, Jun 01, 2020 at 01:50:13PM +0300, Vadym Kochan wrote: > > Hi Ido, > > > > On Sat, May 30, 2020 at 06:48:01PM +0300, Ido Schimmel wrote: > > > On Thu, May 28, 2020 at 06:12:40PM +0300, Vadym Kochan wrote: > > > > > >

[Resend PATCH net] bridge: uapi: mrp: Fix MRP_PORT_ROLE

2020-06-20 Thread Horatiu Vultur
Currently the MRP_PORT_ROLE_NONE has the value 0x2 but this is in conflict with the IEC 62439-2 standard. The standard defines the following port roles: primary (0x0), secondary(0x1), interconnect(0x2). Therefore remove the port role none. Fixes: 4714d13791f831 ("bridge: uapi: mrp: Add mrp attribu

Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels

2020-06-20 Thread Dmitry Osipenko
20.06.2020 14:49, Laurent Pinchart пишет: > Hi Sam and Dmitry, > > On Sat, Jun 20, 2020 at 01:21:32PM +0200, Sam Ravnborg wrote: >> On Thu, Jun 18, 2020 at 01:27:03AM +0300, Dmitry Osipenko wrote: >>> The DRM panel bridge core requires connector type to be set up properly, >>> otherwise it rejects

Re: [PATCH v3] drm/amd: Fix memory leak according to error branch

2020-06-20 Thread Julia Lawall
On Sat, 20 Jun 2020, Markus Elfring wrote: > > The function kobject_init_and_add alloc memory like: > > kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs > > ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller > > ->kmalloc_slab, in err branch this memory not free. If u

Re: [net-next 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x)

2020-06-20 Thread Vadym Kochan
Hi Jiri, Ido, On Mon, Jun 01, 2020 at 08:24:17AM +0200, Jiri Pirko wrote: > Sat, May 30, 2020 at 05:54:29PM CEST, ido...@idosch.org wrote: > >On Sat, May 30, 2020 at 05:52:31PM +0300, Vadym Kochan wrote: > > [...] > > > >> > WARNING: do not add new typedefs > >> > #1064: FILE: drivers/net/ether

Re: [PATCH 4.19 000/265] 4.19.129-rc2 review

2020-06-20 Thread Guenter Roeck
On 6/20/20 1:22 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.129 release. > There are 265 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses sho

Re: [PATCH 5.4 000/259] 5.4.48-rc2 review

2020-06-20 Thread Guenter Roeck
On 6/20/20 1:23 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.4.48 release. > There are 259 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses shoul

Re: [PATCH v8 1/4] bitops: Introduce the for_each_set_clump macro

2020-06-20 Thread Syed Nayyar Waris
On Tue, Jun 16, 2020 at 1:44 PM Andy Shevchenko wrote: > > On Mon, Jun 15, 2020 at 06:21:18PM +0530, Syed Nayyar Waris wrote: > > This macro iterates for each group of bits (clump) with set bits, > > within a bitmap memory region. For each iteration, "start" is set to > > the bit offset of the fou

Re: Commit 25f12ae45fc1 ("maccess: rename probe_kernel_address to get_kernel_nofault") causing several OOPSes

2020-06-20 Thread Kenneth R. Crudup
> > Thing is, there's other examples of the previous version in the kernel > > tree- any > > chance there's a usage conflict (Thunderbolt has a ROM in it, maybe > > something in > > "probe_roms.c"? (Just guessing, no idea): On Fri, 19 Jun 2020, Christoph Hellwig wrote: > Maybe. But nothing l

[RFC PATCH v1 2/2] arm64: dts: rockchip: add rk3318 A95X Z2 board

2020-06-20 Thread Johan Jonker
The rk3318 A95X Z2 boards are sold as TV box. No further documentation is given, but from the dts files extracted it seems that the rk3318 processor is simulair to the rk3328. This dts file contains only the basic nodes that have support in the mainline kernel. Features: CPU: RK3318 Quad-Core Cor

[RFC PATCH v1 1/2] dt-bindings: arm: rockchip: add A95X Z2 description

2020-06-20 Thread Johan Jonker
Add A95X Z2 description for a board with rk3318 processor. Signed-off-by: Johan Jonker --- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/roc

  1   2   3   4   >