[PATCH] Replace HTTP links with HTTPS ones: H8/300 ARCHITECTURE

2020-07-08 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: memory leak in inotify_update_watch

2020-07-08 Thread Dmitry Vyukov
On Wed, Jul 8, 2020 at 1:08 PM Catalin Marinas wrote: > > On Wed, Jul 08, 2020 at 09:17:37AM +0200, Dmitry Vyukov wrote: > > On Tue, Jul 7, 2020 at 8:17 PM Catalin Marinas > > wrote: > > > Kmemleak never performs well under heavy load. Normally you'd need to > > > let the system settle for a bit

Re: [PATCH] ext4: Delete unnecessary checks before brelse()

2020-07-08 Thread Ritesh Harjani
On 6/13/20 11:37 PM, Markus Elfring wrote: From: Markus Elfring Date: Sat, 13 Jun 2020 19:12:24 +0200 The brelse() function tests whether its argument is NULL and then returns immediately. Thus remove the tests which are not needed around the shown calls. This issue was detected by using th

Re: [PATCH RESEND v9 18/18] media: platform: Add jpeg enc feature

2020-07-08 Thread Tomasz Figa
On Wed, Jul 8, 2020 at 9:14 AM Xia Jiang wrote: > > On Tue, 2020-07-07 at 15:35 +0200, Tomasz Figa wrote: > > On Tue, Jul 7, 2020 at 8:47 AM Xia Jiang wrote: > > > > > > On Tue, 2020-06-30 at 16:53 +, Tomasz Figa wrote: > > > > Hi Xia, > > > > > > > > On Tue, Jun 30, 2020 at 10:56:21AM +0800,

Re: [PATCH] phy: allwinner: phy-sun6i-mipi-dphy: Constify structs

2020-07-08 Thread Vinod Koul
On 29-06-20, 21:57, Rikard Falkeborn wrote: > sun6i_dphy_ops and sun6i_dphy_regmap_config are not modified so make them > const structs to allow the compiler to put them in read-only memory. > > Before: >textdata bss dec hex filename >44071944 646415190f >

Re: [PATCH 1/3] mm: memcg/slab: remove unused argument by charge_slab_page()

2020-07-08 Thread Vlastimil Babka
On 7/7/20 7:36 PM, Roman Gushchin wrote: > charge_slab_page() is not using the gfp argument anymore, > remove it. > > Signed-off-by: Roman Gushchin Acked-by: Vlastimil Babka > --- > mm/slab.c | 2 +- > mm/slab.h | 3 +-- > mm/slub.c | 2 +- > 3 files changed, 3 insertions(+), 4 deletions(-) >

Re: [PATCH 3/3] mm: kmem: switch to static_branch_likely() in memcg_kmem_enabled()

2020-07-08 Thread Vlastimil Babka
On 7/7/20 7:36 PM, Roman Gushchin wrote: > Currently memcg_kmem_enabled() is optimized for the kernel memory > accounting being off. It was so for a long time, and arguably the > reason behind was that the kernel memory accounting was initially an > opt-in feature. However, now it's on by default o

Re: [PATCH 2/3] mm: slab: rename (un)charge_slab_page() to (un)account_slab_page()

2020-07-08 Thread Vlastimil Babka
On 7/7/20 7:36 PM, Roman Gushchin wrote: > charge_slab_page() and uncharge_slab_page() are not related anymore > to memcg charging and uncharging. In order to make their names > less confusing, let's rename them to account_slab_page() and > unaccount_slab_page() respectively. > > Signed-off-by: Ro

Re: [PATCH] perf parse-events: report bpf errors

2020-07-08 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 07, 2020 at 02:14:49PM -0700, Ian Rogers escreveu: > Setting the parse_events_error directly doesn't increment num_errors > causing the error message not to be displayed. Use the > parse_events__handle_error function that sets num_errors and handle > multiple errors. What was the comma

Re: [RESEND PATCH v7 2/2] devicetree: bindings: phy: Document ipq806x dwc3 qcom phy

2020-07-08 Thread Vinod Koul
On 15-06-20, 22:53, Ansuel Smith wrote: > Document dwc3 qcom phy hs and ss phy bindings needed to correctly > inizialize and use usb on ipq806x SoC. Rob ? > > Signed-off-by: Ansuel Smith > --- > v7: > * Drop useless AllOf > v6: > * Add maximum value > v5: > * Fix dt_binding_check error > v4: >

Re: [RFC PATCH 00/22] Enhance VHOST to enable SoC-to-SoC communication

2020-07-08 Thread Jason Wang
On 2020/7/7 下午10:45, Kishon Vijay Abraham I wrote: Hi Jason, On 7/7/2020 3:17 PM, Jason Wang wrote: On 2020/7/6 下午5:32, Kishon Vijay Abraham I wrote: Hi Jason, On 7/3/2020 12:46 PM, Jason Wang wrote: On 2020/7/2 下午9:35, Kishon Vijay Abraham I wrote: Hi Jason, On 7/2/2020 3:40 PM, Jason W

Re: [PATCH v2 1/3] KVM: nSVM: split kvm_init_shadow_npt_mmu() from kvm_init_shadow_mmu()

2020-07-08 Thread Paolo Bonzini
On 08/07/20 11:36, Vitaly Kuznetsov wrote: > @@ -4973,7 +4969,28 @@ void kvm_init_shadow_mmu(struct kvm_vcpu *vcpu, u32 > cr0, u32 cr4, u32 efer) > context->mmu_role.as_u64 = new_role.as_u64; > reset_shadow_zero_bits_mask(vcpu, context); > } > -EXPORT_SYMBOL_GPL(kvm_init_shadow_mmu);

Re: [PATCH] Replace HTTP links with HTTPS ones: CEPH COMMON CODE (LIBCEPH)

2020-07-08 Thread Ilya Dryomov
On Wed, Jul 8, 2020 at 8:53 AM Alexander A. Klimov wrote: > > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contai

Re: [PATCH 2/2] KVM: PPC: Book3S HV: rework secure mem slot dropping

2020-07-08 Thread Bharata B Rao
On Fri, Jul 03, 2020 at 05:59:14PM +0200, Laurent Dufour wrote: > When a secure memslot is dropped, all the pages backed in the secure device > (aka really backed by secure memory by the Ultravisor) should be paged out > to a normal page. Previously, this was achieved by triggering the page > fault

RE: [PATCH V2 1/2] hwmon: pwm-fan: Add profile support and add remove module support

2020-07-08 Thread Sandipan Patra
Hi Guenter, Agreed with the suggestion with regards to fan profile support. Looked at thermal driver and further planning to implement required changes in thermal core instead of pwm-fan driver. Dropping the current series. Thanks & Regards, Sandipan > -Original Message- > From: Guent

Re: [PATCH] spi: use kthread_create_worker() helper

2020-07-08 Thread Petr Mladek
On Wed 2020-07-08 09:09:00, Marek Szyprowski wrote: > Since commit 4977caef05aa ("kthread: work could not be queued when worker > being destroyed") This commit should disappear from linux-next soon. We did not expect that it would cause these warnings. We first want to fix the callers before we pu

[PATCH] perf/smmuv3: To simplify code for ioremap page in pmcg

2020-07-08 Thread Jay Chen
Use the devm_platform_get_and_ioremap_resource to simplify the code a bit. Signed-off-by: Jay Chen --- drivers/perf/arm_smmuv3_pmu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c index 48e28ef93a70..2d09f3e47d1

Re: [PATCH 12/14] clk: renesas: cpg-mssr: Add r8a774e1 support

2020-07-08 Thread Geert Uytterhoeven
Hi Prabhakar, On Tue, Jul 7, 2020 at 6:18 PM Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Add support for the RZ/G2H (R8A774E1) SoC to the Renesas Clock > Pulse Generator / Module Standby and Software Reset driver. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad P

Re: [PATCH 13/14] dt-bindings: pinctrl: renesas,pfc-pinctrl: Document r8a774e1 PFC support

2020-07-08 Thread Geert Uytterhoeven
On Tue, Jul 7, 2020 at 6:18 PM Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Document PFC support for the RZ/G2H (R8A774E1) SoC. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven i.e. will queue in sh-pfc-for-v5.9. Gr{oetj

[PATCH 2/2] iommu/dma: Avoid SAC address trick for PCIe devices

2020-07-08 Thread Robin Murphy
As for the intel-iommu implementation, relegate the opportunistic attempt to allocate a SAC address to the domain of conventional PCI devices only, to avoid it increasingly causing far more performance issues than possible benefits on modern PCI Express systems. Signed-off-by: Robin Murphy --- d

Re: [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware

2020-07-08 Thread Michal Hocko
On Wed 08-07-20 16:27:16, Aneesh Kumar K.V wrote: > Vlastimil Babka writes: > > > On 7/8/20 9:41 AM, Michal Hocko wrote: > >> On Wed 08-07-20 16:16:02, Joonsoo Kim wrote: > >>> On Tue, Jul 07, 2020 at 01:22:31PM +0200, Vlastimil Babka wrote: > >>> > >>> Simply, I call memalloc_nocma_{save,restor

[PATCH 1/2] iommu/intel: Avoid SAC address trick for PCIe devices

2020-07-08 Thread Robin Murphy
For devices stuck behind a conventional PCI bus, saving extra cycles at 33MHz is probably fairly significant. However since native PCI Express is now the norm for high-performance devices, the optimisation to always prefer 32-bit addresses for the sake of avoiding DAC is starting to look rather ana

[PATCH] Replace HTTP links with HTTPS ones: EDAC-SBRIDGE

2020-07-08 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

linux-next: Tree for Jul 8

2020-07-08 Thread Stephen Rothwell
Hi all, Changes since 20200707: New tree: set_fs My fixes tree contains: dbf24e30ce2e ("device_cgroup: Fix RCU list debugging warning") b236d81d9e4f ("powerpc/boot/dts: Fix dtc "pciex" warnings") The kbuild tree still had its build failure for which I reverted a commit. The f2fs tree gain

Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-08 Thread Hans de Goede
Hi, On 7/8/20 1:01 PM, Hans de Goede wrote: Hi, On 7/7/20 10:19 AM, Kees Cook wrote: Hi, In looking for closely at the additions that got made to the kernel_read_file() enums, I noticed that FIRMWARE_PREALLOC_BUFFER and FIRMWARE_EFI_EMBEDDED were added, but they are not appropriate *kinds* of

Re: [PATCH net-next v5 2/4] net: dsa: felix: (re)use already existing constants

2020-07-08 Thread Michael Walle
Am 2020-07-08 12:47, schrieb Vladimir Oltean: On Tue, Jul 07, 2020 at 11:21:29PM +0200, Michael Walle wrote: Now that there are USXGMII constants available, drop the old definitions and reuse the generic ones. Signed-off-by: Michael Walle --- drivers/net/dsa/ocelot/felix_vsc9959.c | 45

[PATCH] ARM: dts: stm32: Correct spi4 pins in stm32mp15-pinctrl.dtsi

2020-07-08 Thread Patrick Delaunay
Move spi4_pins_a nodes from pinctrl_z to pinctrl as the associated pins are not in BANK Z. Fixes: 498a7014989dfdd9a47864b55704dc829ed0dc90 Signed-off-by: Patrick Delaunay --- arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 28 1 file changed, 14 insertions(+), 14 deletions(-

Re: [REGRESSION] mlx5: Driver remove during hot unplug is broken

2020-07-08 Thread Niklas Schnelle
Hi Parav, Hi Shay, On 7/8/20 12:43 PM, Parav Pandit wrote: > Hi Niklas, > ... snip ... >>> > > Sorry for my late response. > Yes, this looks good and I also found same in my analysis. > With latest code mlx5_pci_close() already does drain_health_wq(), so the > additional call in remove_one() is

SD-X - a correction of Unix, with all elements to now.

2020-07-08 Thread Ywe Cærlyn
A complete correction of the unix name actually becomes SD-X, supply and demand OS. So this is now what it is called, with all things discussed included. Supply and Demand being a monotheistic principle that decides what happens on the OS, like indeed school teaches. (Rather than "Uni" which

Re: [PATCH v2 2/3] KVM: nSVM: properly call kvm_mmu_new_pgd() upon switching to guest

2020-07-08 Thread Paolo Bonzini
On 08/07/20 11:36, Vitaly Kuznetsov wrote: > Undesired triple fault gets injected to L1 guest on SVM when L2 is > launched with certain CR3 values. #TF is raised by mmu_check_root() > check in fast_pgd_switch() and the root cause is that when > kvm_set_cr3() is called from nested_prepare_vmcb_save(

Re: [PATCH] Replace HTTP links with HTTPS ones: KMOD KERNEL MODULE LOADER - USERMODE HELPER

2020-07-08 Thread Luis Chamberlain
On Wed, Jul 08, 2020 at 09:13:37AM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn

Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-08 Thread Luis Chamberlain
On Wed, Jul 08, 2020 at 01:37:41PM +0200, Hans de Goede wrote: > Hi, > > On 7/8/20 1:01 PM, Hans de Goede wrote: > > Hi, > > > > On 7/7/20 10:19 AM, Kees Cook wrote: > > > Hi, > > > > > > In looking for closely at the additions that got made to the > > > kernel_read_file() enums, I noticed that

[PATCH] Replace HTTP links with HTTPS ones: FIREWIRE SUBSYSTEM

2020-07-08 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH] thermal: sun8i: Be loud when probe fails

2020-07-08 Thread Frank Lee
HI Ondrej, On Wed, Jul 8, 2020 at 6:55 PM Ondrej Jirman wrote: > > I noticed several mobile Linux distributions failing to enable the > thermal regulation correctly, because the kernel is silent > when thermal driver fails to probe. Add enough error reporting > to debug issues and warn users in ca

Re: [PATCH V7 00/15] perf/x86: Add perf text poke events

2020-07-08 Thread Adrian Hunter
On 27/05/20 6:54 pm, Peter Zijlstra wrote: > On Wed, May 27, 2020 at 12:47:16PM -0300, Arnaldo Carvalho de Melo wrote: >> Em Wed, May 20, 2020 at 05:56:34PM +0200, Peter Zijlstra escreveu: >>> On Tue, May 19, 2020 at 10:40:01PM -0300, Arnaldo Carvalho de Melo wrote: PeterZ, from what we discus

[PATCH] kvm: x86: replace kvm_spec_ctrl_test_value with runtime test on the host

2020-07-08 Thread Maxim Levitsky
To avoid complex and in some cases incorrect logic in kvm_spec_ctrl_test_value, just try the guest's given value on the host processor instead, and if it doesn't #GP, allow the guest to set it. One such case is when host CPU supports STIBP mitigation but doesn't support IBRS (as is the case with s

Re: [PATCH 14/14] pinctrl: sh-pfc: pfc-r8a77951: Add R8A774E1 PFC support

2020-07-08 Thread Geert Uytterhoeven
On Tue, Jul 7, 2020 at 6:18 PM Lad Prabhakar wrote: > Renesas RZ/G2H (r8a774e1) is pin compatible with R-Car H3 (R8A77951), > however it doesn't have several automotive specific peripherals. Add > automotive-specific pin groups/functions along with common pin > groups/functions for supporting both

Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-08 Thread Hans de Goede
Hi, On 7/8/20 1:55 PM, Luis Chamberlain wrote: On Wed, Jul 08, 2020 at 01:37:41PM +0200, Hans de Goede wrote: Hi, On 7/8/20 1:01 PM, Hans de Goede wrote: Hi, On 7/7/20 10:19 AM, Kees Cook wrote: Hi, In looking for closely at the additions that got made to the kernel_read_file() enums, I no

Re: [PATCH] Bluetooth: Use whitelist for scan policy when suspending

2020-07-08 Thread Marcel Holtmann
Hi Miao-chen, > Even with one advertisement monitor in place, the scan policy should use > the whitelist while the system is going to suspend to prevent waking by > random advertisement. > > The following test was performed. > - With a paired device, register one advertisement monitor, suspend >

Re: [PATCH v3 1/8] KVM: X86: Reset vcpu->arch.cpuid_nent to 0 if SET_CPUID* fails

2020-07-08 Thread Paolo Bonzini
On 08/07/20 08:50, Xiaoyao Li wrote: > +Note, when this IOCTL fails, KVM gives no guarantees that previous valid > CPUID > +configuration (if there is) is not corrupted. Userspace can get a copy of > valid > +CPUID configuration through KVM_GET_CPUID2 in case. > + > :: I assume you mean "of the

[PATCH 03/30] scsi: libfc: fc_disc: trivial: Fix spelling mistake of 'discovery'

2020-07-08 Thread Lee Jones
This is my fault (can't even blame copy/paste). Cc: Hannes Reinecke Reported-by: Johannes Thumshirn Signed-off-by: Lee Jones --- drivers/scsi/libfc/fc_disc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c index 42

[PATCH 01/30] scsi: libfc: fc_exch: Supply some missing kerneldoc struct/function attributes/params

2020-07-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_exch.c:66: warning: Function parameter or member 'left' not described in 'fc_exch_pool' drivers/scsi/libfc/fc_exch.c:66: warning: Function parameter or member 'right' not described in 'fc_exch_pool' drivers/scsi/libfc/fc_e

[PATCH 04/30] scsi: fcoe: fcoe: Fix various kernel-doc infringements

2020-07-08 Thread Lee Jones
A couple of headers make no attempt to document their associated function parameters. Others looks as if they are suffering with a little bitrot. Fixes the following W=1 kernel build warning(s): drivers/scsi/fcoe/fcoe.c:654: warning: Function parameter or member 'lport' not described in 'fcoe_

[PATCH 00/30] Fix a bunch more SCSI related W=1 warnings

2020-07-08 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Slowly working through the SCSI related ones. There are many. Lee Jones (30): scsi: libfc: fc_exch: Supply some missing kerneldoc struct/functio

[PATCH 11/30] scsi: libfc: fc_rport: Fix a couple of misdocumented function parameters

2020-07-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_rport.c:129: warning: Function parameter or member 'port_id' not described in 'fc_rport_create' drivers/scsi/libfc/fc_rport.c:129: warning: Excess function parameter 'ids' description in 'fc_rport_create' drivers/scsi/libf

[PATCH 12/30] scsi: libfc: fc_fcp: Provide missing and repair existing function documentation

2020-07-08 Thread Lee Jones
Mostly due to descriptions not keeping up with API changes. Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_fcp.c:299: warning: Function parameter or member 'status_code' not described in 'fc_fcp_retry_cmd' drivers/scsi/libfc/fc_fcp.c:595: warning: Function parameter or

[PATCH 09/30] scsi: qedf: qedf_main: Remove set but not checked variable 'tmp'

2020-07-08 Thread Lee Jones
Looks like the return value of readw() has never been checked. Fixes the following W=1 kernel build warning(s): drivers/scsi/qedf/qedf_main.c: In function ‘__qedf_probe’: drivers/scsi/qedf/qedf_main.c:3203:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] Cc: qlogic-stor

[PATCH 13/30] scsi: libfc: fc_rport: Fix bitrotted function parameter and copy/paste error

2020-07-08 Thread Lee Jones
Description should state 'remote' port, not 'local'. Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_rport.c:1452: warning: Function parameter or member 'rdata_arg' not described in 'fc_rport_logo_resp' drivers/scsi/libfc/fc_rport.c:1452: warning: Excess function paramet

[PATCH 17/30] scsi: qedf: qedf_io: Remove a whole host of unused variables

2020-07-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/scsi/qedf/qedf_io.c: In function ‘qedf_cmd_timeout’: drivers/scsi/qedf/qedf_io.c:25:5: warning: variable ‘op’ set but not used [-Wunused-but-set-variable] 25 | u8 op = 0; | ^~ drivers/scsi/qedf/qedf_io.c: In function ‘qedf_map_sg’: dr

[PATCH 27/30] scsi: pm8001: pm8001_init: Demote obvious misuse of kerneldoc and update others

2020-07-08 Thread Lee Jones
More bitrot issues with function documentation not keeping up with API changes. Fixes the following W=1 kernel build warning(s): drivers/scsi/pm8001/pm8001_init.c:64: warning: cannot understand function prototype: 'const struct pm8001_chip_info pm8001_chips[] = ' drivers/scsi/pm8001/pm8001_ini

[PATCH 26/30] scsi: aic94xx: aic94xx_init: Demote seemingly unintentional kerneldoc header

2020-07-08 Thread Lee Jones
This is the only use of kerneldoc in the sourcefile and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic94xx/aic94xx_init.c:538: warning: Function parameter or member 'asd_ha' not described in 'asd_free_edbs' Cc: YueHaibing Cc: Luben Tuikov Sign

Re: memory leak in inotify_update_watch

2020-07-08 Thread Catalin Marinas
On Tue, Jul 07, 2020 at 05:24:11PM +0200, Jan Kara wrote: > On Mon 06-07-20 08:42:24, syzbot wrote: > > syzbot found the following crash on: > > > > HEAD commit:7cc2a8ea Merge tag 'block-5.8-2020-07-01' of git://git.ker.. > > git tree: upstream > > console output: https://syzkaller.appsp

[PATCH 28/30] scsi: aic94xx: aic94xx_hwi: Repair kerneldoc formatting error and remove extra param

2020-07-08 Thread Lee Jones
Function parameters need to be documented with format '@.*: '. 'to' is not longer asd_start_timers()'s function parameter. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic94xx/aic94xx_hwi.c:589: warning: Function parameter or member 'asd_ha' not described in 'asd_init_ctxmem'

[PATCH 23/30] scsi: qedf: qedf_debugfs: Demote obvious misuse of kerneldoc to standard comment blocks

2020-07-08 Thread Lee Jones
No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/scsi/qedf/qedf_debugfs.c:25: warning: Function parameter or member 'qedf' not described in 'qedf_dbg_host_init' drivers/scsi/qedf/qedf_debugfs.c:25: warning: Functio

[PATCH 30/30] scsi: qla4xxx: ql4_init: Provide a missing function param description and fix formatting

2020-07-08 Thread Lee Jones
Kerneldoc function parameter references need to be in the format '@.*: ', else the kerneldoc checker gets confused. Fixes the following W=1 kernel build warning(s): drivers/scsi/qla4xxx/ql4_init.c: In function ‘ql4xxx_set_mac_number’: drivers/scsi/qla4xxx/ql4_init.c:17:10: warning: variable ‘fu

[PATCH 22/30] scsi: aic7xxx: aic7xxx_osm: Fix 'amount_xferred' set but not used issue

2020-07-08 Thread Lee Jones
'amount_xferred' is used, but only in certain circumstances. Place the same stipulations on the defining/allocating of 'amount_xferred' as is placed when using it. We've been careful not to change any of the ordering semantics here. Fixes the following W=1 kernel build warning(s): drivers/scsi

[PATCH 29/30] scsi: aacraid: aachba: Fix a bunch of function doc formatting errors

2020-07-08 Thread Lee Jones
And a few missing/excessive parameter descriptions. Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/aachba.c:358: warning: Function parameter or member 'dev' not described in 'aac_get_config_status' drivers/scsi/aacraid/aachba.c:358: warning: Function parameter or member

[PATCH 20/30] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'ahc'

2020-07-08 Thread Lee Jones
Looks as though 'ahc' hasn't been used since 2005. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_slave_configure’: drivers/scsi/aic7xxx/aic7xxx_osm.c:674:20: warning: variable ‘ahc’ set but not used [-Wunused-but-set-variable] 674

[PATCH 25/30] scsi: aacraid: linit: Fix a couple of small kerneldoc issues

2020-07-08 Thread Lee Jones
Most likely caused by bitrot (docs not keeping in sync with API). Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’: drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] drive

[PATCH 24/30] scsi: aacraid: linit: Provide suggested curly braces around empty body of if()

2020-07-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’: drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] 368 | param->heads, param->sectors, num)); | ^ Cc: Adaptec OEM Raid So

[PATCH 19/30] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'tinfo'

2020-07-08 Thread Lee Jones
Looks like none of the artifact from ahc_fetch_transinfo() are used anymore. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_target_alloc’: drivers/scsi/aic7xxx/aic7xxx_osm.c:567:30: warning: variable ‘tinfo’ set but not used [-Wunus

[PATCH 06/30] scsi: fcoe: fcoe_transport: Correct some kernel-doc issues

2020-07-08 Thread Lee Jones
Mainly due to misdocumentation or bitrotted descriptions. Fixes the following W=1 kernel build warning(s): drivers/scsi/fcoe/fcoe_transport.c:396: warning: Function parameter or member 'skb' not described in 'fcoe_check_wait_queue' drivers/scsi/fcoe/fcoe_transport.c:447: warning: Function para

[PATCH 05/30] scsi: fcoe: fcoe_ctlr: Fix a myriad of documentation issues

2020-07-08 Thread Lee Jones
Mostly missing or incorrect (bitrotted) function parameters. Fixes the following W=1 kernel build warning(s): drivers/scsi/fcoe/fcoe_ctlr.c:139: warning: Function parameter or member 'mode' not described in 'fcoe_ctlr_init' drivers/scsi/fcoe/fcoe_ctlr.c:604: warning: Function parameter or memb

[PATCH 07/30] scsi: bnx2fc: bnx2fc_fcoe: Repair a range of kerneldoc issues

2020-07-08 Thread Lee Jones
>From bitrotted and missing function parameters to misuse of kerneldoc format. Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1082: warning: Function parameter or member 'lport' not described in 'bnx2fc_update_src_mac' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1082:

[PATCH 21/30] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'targ'

2020-07-08 Thread Lee Jones
Looks like checking the 'targ' was removed in 2005. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_send_async’: drivers/scsi/aic7xxx/aic7xxx_osm.c:1604:28: warning: variable ‘targ’ set but not used [-Wunused-but-set-variable] 1604 | struc

[PATCH 08/30] scsi: qedf: qedf_main: Demote obvious misuse of kerneldoc to standard comment blocks

2020-07-08 Thread Lee Jones
No attempt has been made to document either of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/scsi/qedf/qedf_main.c:1027: warning: Function parameter or member 'lport' not described in 'qedf_xmit' drivers/scsi/qedf/qedf_main.c:1027: warning: Function param

[PATCH 14/30] scsi: bnx2fc: bnx2fc_hwi: Fix a couple of bitrotted function documentation headers

2020-07-08 Thread Lee Jones
Likely a result of documentation not keeping up with API updates (a.k.a. bitrot). Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2fc/bnx2fc_hwi.c:493: warning: Function parameter or member 'hba' not described in 'bnx2fc_send_session_destroy_req' drivers/scsi/bnx2fc/bnx2fc_hw

[PATCH 18/30] scsi: bnx2fc: bnx2fc_tgt: Demote obvious misuse of kerneldoc to standard comment blocks

2020-07-08 Thread Lee Jones
No attempt has been made to document either of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'lport' not described in 'bnx2fc_rport_event_handler' drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: wa

Re: [PATCH 03/30] scsi: libfc: fc_disc: trivial: Fix spelling mistake of 'discovery'

2020-07-08 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn I think Martin can fold this one into the original one

[PATCH 16/30] scsi: arcmsr: arcmsr_hba: Make room for the trailing NULL, even if it is over-written

2020-07-08 Thread Lee Jones
Ensure we do not copy the final one (which is not overwitten). Fixes the following W=1 kernel build warning(s): In file included from include/linux/bitmap.h:9, from include/linux/nodemask.h:95, from include/linux/mmzone.h:17, from include/linux/gfp.h:6, from include/linux/umh.h:4, from incl

[PATCH 15/30] scsi: arcmsr: arcmsr_hba: Remove some set but unused variables

2020-07-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/scsi/arcmsr/arcmsr_hba.c: In function ‘arcmsr_remap_pciregion’: drivers/scsi/arcmsr/arcmsr_hba.c:286:30: warning: variable ‘flags’ set but not used [-Wunused-but-set-variable] 286 | unsigned long addr, range, flags; | ^ drivers/scs

[PATCH 10/30] scsi: libfc: fc_lport: Repair function parameter documentation

2020-07-08 Thread Lee Jones
Either misdocumentation and/or bitrot. Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_lport.c:412: warning: Function parameter or member 'in_fp' not described in 'fc_lport_recv_echo_req' drivers/scsi/libfc/fc_lport.c:412: warning: Excess function parameter 'fp' descrip

[PATCH 02/30] include: scsi: scsi_transport_fc: Match HBA Attribute Length with HBAAPI V2.0 definitions

2020-07-08 Thread Lee Jones
According to 'include/scsi/scsi_transport_fc.h': "Attributes are based on HBAAPI V2.0 definitions" ... so it seems sane to match the 'HBA Attribute Length' to them. If we don't, the compiler complains that the copied data will be truncated. Fixes the following W=1 kernel build warning(s): In

Re: [PATCH v10 1/5] iommu/arm-smmu: move TLB timeout and spin count macros

2020-07-08 Thread Jon Hunter
On 08/07/2020 06:00, Krishna Reddy wrote: > Move TLB timeout and spin count macros to header file to > allow using the same from vendor specific implementations. > > Signed-off-by: Krishna Reddy > --- > drivers/iommu/arm-smmu.c | 3 --- > drivers/iommu/arm-smmu.h | 2 ++ > 2 files changed, 2 i

Re: [PATCH v10 2/5] iommu/arm-smmu: ioremap smmu mmio region before implementation init

2020-07-08 Thread Jon Hunter
On 08/07/2020 06:00, Krishna Reddy wrote: > ioremap smmu mmio region before calling into implementation init. > This is necessary to allow mapped address available during vendor > specific implementation init. > > Signed-off-by: Krishna Reddy > --- > drivers/iommu/arm-smmu.c | 8 > 1

Re: [PATCH v3 4/8] KVM: X86: Split kvm_update_cpuid()

2020-07-08 Thread Paolo Bonzini
On 08/07/20 08:50, Xiaoyao Li wrote: > Split the part of updating vcpu model out of kvm_update_cpuid(), and put > it into a new kvm_update_vcpu_model(). So it's more clear that > kvm_update_cpuid() is to update guest CPUID settings, while > kvm_update_vcpu_model() is to update vcpu model (settings)

RE: [PATCH 0/3] Dynamic CPU frequency switching for the HiFive

2020-07-08 Thread Yash Shah
Hi Andreas, > -Original Message- > From: Andreas Schwab > Sent: 01 July 2020 16:11 > To: Yash Shah > Cc: Paul Walmsley ( Sifive) ; > pal...@dabbelt.com; robh...@kernel.org; linux-ri...@lists.infradead.org; > linux-kernel@vger.kernel.org; devicet...@vger.kernel.org; Sachin Ghadi > ; a...@

Re: [PATCH v3 5/8] KVM: X86: Rename cpuid_update() to update_vcpu_model()

2020-07-08 Thread Paolo Bonzini
On 08/07/20 08:50, Xiaoyao Li wrote: > The name of callback cpuid_update() is misleading that it's not about > updating CPUID settings of vcpu but updating the configurations of vcpu > based on the CPUIDs. So rename it to update_vcpu_model(). > > Signed-off-by: Xiaoyao Li With the change suggest

Re: [PATCH v3 0/8] Refactor handling flow of KVM_SET_CPUID*

2020-07-08 Thread Paolo Bonzini
On 08/07/20 08:50, Xiaoyao Li wrote: > This serial is the extended version of > https://lkml.kernel.org/r/20200528151927.14346-1-xiaoyao...@intel.com > > First two patches are bug fixing, and the others aim to refactor the flow > of SET_CPUID* as: > > 1. cpuid check: check if userspace provides l

Re: [PATCH 03/30] scsi: libfc: fc_disc: trivial: Fix spelling mistake of 'discovery'

2020-07-08 Thread Lee Jones
On Wed, 08 Jul 2020, Johannes Thumshirn wrote: > Looks good, > > Reviewed-by: Johannes Thumshirn > > I think Martin can fold this one into the original one Obviously I'd be okay with that, but it will depend on whether his tree is able to be rebased. Many public trees are unrebasable (if that

Re: [PATCH 03/30] scsi: libfc: fc_disc: trivial: Fix spelling mistake of 'discovery'

2020-07-08 Thread Johannes Thumshirn
On 08/07/2020 14:12, Lee Jones wrote: > Obviously I'd be okay with that, but it will depend on whether his > tree is able to be rebased. Many public trees are unrebasable (if > that's a word). Yeah but in this early stage SCSI usually is re-baseable.

Re: [PATCH 3/5] net: fec: initialize clock with 0 rather than current kernel time

2020-07-08 Thread Sergey Organov
Richard Cochran writes: > On Tue, Jul 07, 2020 at 08:56:41PM +0300, Sergey Organov wrote: >> It won't. Supposedly it'd force clock (that doesn't tick by default and >> stays at 0) to start ticking. > > No existing clockid_t has this behavior. Consider CLOCK_REALTIME or > CLOCK_MONOTONIC. > > T

Re: [PATCH 11/30] scsi: libfc: fc_rport: Fix a couple of misdocumented function parameters

2020-07-08 Thread Johannes Thumshirn
On 08/07/2020 14:04, Lee Jones wrote: > @@ -1445,7 +1445,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv > *rdata, > * fc_rport_logo_resp() - Handler for logout (LOGO) responses > * @sp: The sequence the LOGO was on > * @fp: The LOGO response frame > - * @

[PATCH] Replace HTTP links with HTTPS ones: DRM DRIVERS FOR BRIDGE CHIPS

2020-07-08 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH v1 0/9] s390: implement and optimize vmemmap_free()

2020-07-08 Thread David Hildenbrand
On 08.07.20 08:50, David Hildenbrand wrote: > On 07.07.20 14:13, David Hildenbrand wrote: >> On 07.07.20 14:08, Heiko Carstens wrote: >>> On Fri, Jul 03, 2020 at 03:39:08PM +0200, David Hildenbrand wrote: This series is based on the latest s390/features branch [1]. It implements vmemmap_f

Re: [PATCH 2/2] KVM: PPC: Book3S HV: rework secure mem slot dropping

2020-07-08 Thread Laurent Dufour
Le 08/07/2020 à 13:25, Bharata B Rao a écrit : On Fri, Jul 03, 2020 at 05:59:14PM +0200, Laurent Dufour wrote: When a secure memslot is dropped, all the pages backed in the secure device (aka really backed by secure memory by the Ultravisor) should be paged out to a normal page. Previously, this

Re: [PATCH 27/30] scsi: pm8001: pm8001_init: Demote obvious misuse of kerneldoc and update others

2020-07-08 Thread Jinpu Wang
On Wed, Jul 8, 2020 at 2:03 PM Lee Jones wrote: > > More bitrot issues with function documentation not keeping up with API > changes. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_init.c:64: warning: cannot understand function > prototype: 'const struct pm8

[PATCH] driver core: Drop mention of obsolete bus rwsem from kernel-doc

2020-07-08 Thread Lukas Wunner
15 years ago, commit 6eded061b126 ("Fix up bus code and remove use of rwsem") removed the bus rwsem, but left over a reference to it in a kernel-doc comment. Drop it. Signed-off-by: Lukas Wunner --- drivers/base/dd.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/dri

Re: [PATCH 13/30] scsi: libfc: fc_rport: Fix bitrotted function parameter and copy/paste error

2020-07-08 Thread Johannes Thumshirn
On 08/07/2020 14:04, Lee Jones wrote: > Description should state 'remote' port, not 'local'. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/libfc/fc_rport.c:1452: warning: Function parameter or member > 'rdata_arg' not described in 'fc_rport_logo_resp' > drivers/scsi/lib

Re: [PATCH net] xsk: remove cheap_dma optimization

2020-07-08 Thread Christoph Hellwig
On Wed, Jul 08, 2020 at 07:57:23AM +, Song Bao Hua (Barry Song) wrote: > > int dma_map_batch_start(struct device *dev, size_t rounded_len, > > enum dma_data_direction dir, unsigned long attrs, dma_addr_t *addr); > > int dma_map_batch_add(struct device *dev, dma_addr_t *addr, struct page > >

Re: [PATCH] arm64/module-plts: Consider the special case where plt_max_entries is 0

2020-07-08 Thread Ard Biesheuvel
On Wed, 8 Jul 2020 at 13:03, 彭浩(Richard) wrote: > > > On Tue, Jul 07, 2020 at 07:46:08AM -0400, Peng Hao wrote: > >> If plt_max_entries is 0, a warning is triggered. > >> WARNING: CPU: 200 PID: 3000 at arch/arm64/kernel/module-plts.c:97 > >> module_emit_plt_entry+0xa4/0x150 > > > > Which kernel a

[PATCH 2/4] firmware: arm_scmi: Remove unneeded __packed attribute

2020-07-08 Thread Cristian Marussi
Remove __packed attribute from struct scmi_event_header. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/notify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/notify.c b/drivers/firmware/arm_scmi/notify.c index c4d006cfde88..7524153

[PATCH 3/4] firmware: arm_scmi: Fix scmi_event_header fields typing

2020-07-08 Thread Cristian Marussi
Drop size_t in favour of fixed size u32 for consistency and shuffle around fields definitions to minimize implicit padding. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/notify.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scmi

[PATCH 4/4] firmware: arm_scmi: Remove fixed size typing from event reports

2020-07-08 Thread Cristian Marussi
Event reports are used to convey information describing events to the registered user-callbacks: they are necessarily derived from the underlying raw SCMI events' messages but they are not meant to expose or directly mirror any of those messages data layout, which belong to the protocol layer. Usi

[PATCH 1/4] firmware: arm_scmi: Remove zero-length array in SCMI Notifications

2020-07-08 Thread Cristian Marussi
Substitute zero-length array defined in scmi_base_error_report with a flexible length array definition. Signed-off-by: Cristian Marussi --- include/linux/scmi_protocol.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protoco

Re: [PATCH 13/30] scsi: libfc: fc_rport: Fix bitrotted function parameter and copy/paste error

2020-07-08 Thread Lee Jones
On Wed, 08 Jul 2020, Johannes Thumshirn wrote: > On 08/07/2020 14:04, Lee Jones wrote: > > Description should state 'remote' port, not 'local'. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/scsi/libfc/fc_rport.c:1452: warning: Function parameter or member > > 'rdata_

Re: [PATCH 11/30] scsi: libfc: fc_rport: Fix a couple of misdocumented function parameters

2020-07-08 Thread Lee Jones
On Wed, 08 Jul 2020, Johannes Thumshirn wrote: > On 08/07/2020 14:04, Lee Jones wrote: > > @@ -1445,7 +1445,7 @@ static void fc_rport_recv_rtv_req(struct > > fc_rport_priv *rdata, > > * fc_rport_logo_resp() - Handler for logout (LOGO) responses > > * @sp: The sequence the LOGO was o

Re: [PATCH v10 3/5] iommu/arm-smmu: add NVIDIA implementation for ARM MMU-500 usage

2020-07-08 Thread Jon Hunter
On 08/07/2020 06:00, Krishna Reddy wrote: > NVIDIA's Tegra194 SoC has three ARM MMU-500 instances. > It uses two of the ARM MMU-500s together to interleave IOVA > accesses across them and must be programmed identically. > This implementation supports programming the two ARM MMU-500s > that must b

Re: [PATCH 3/5] net: fec: initialize clock with 0 rather than current kernel time

2020-07-08 Thread Sergey Organov
Richard Cochran writes: > On Mon, Jul 06, 2020 at 06:27:21PM +0300, Vladimir Oltean wrote: >> There's no correct answer, I'm afraid. Whatever the default value of the >> clock may be, it's bound to be confusing for some reason, _if_ the >> reason why you're investigating it in the first place is

Re: [PATCH v10 4/5] dt-bindings: arm-smmu: add binding for Tegra194 SMMU

2020-07-08 Thread Jon Hunter
On 08/07/2020 06:00, Krishna Reddy wrote: > Add binding for NVIDIA's Tegra194 SoC SMMU. > > Signed-off-by: Krishna Reddy > --- > .../devicetree/bindings/iommu/arm,smmu.yaml| 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iommu/

<    1   2   3   4   5   6   7   8   9   10   >