[PATCH 00/32] fscache: Rewrite 2: Make the I/O interface use kiocb/iov_iter

2020-07-13 Thread David Howells
Here's a set of patches that massively overhauls the object lifecycle management and the I/O API of the local caching for network filesystems code for a reduction of about 3000 LoC and a 1000 line Documentation reduction. The ability to use async DIO to pass data to/from the cache gives a huge

[PATCH 13/14] fscache: Temporarily disable fscache_invalidate()

2020-07-13 Thread David Howells
Temporarily disable the fscache side of fscache_invalidate() so that the operation managing code can be removed. Signed-off-by: David Howells --- fs/cachefiles/interface.c |9 ++--- fs/fscache/cookie.c |4 +- fs/fscache/object.c | 78

[PATCH 03/32] vfs: Export rw_verify_area() for use by cachefiles

2020-07-13 Thread David Howells
Export rw_verify_area() for so that cachefiles can use it before issuing call_read_iter() and call_write_iter() to effect async DIO operations against the cache. Signed-off-by: David Howells --- fs/internal.h |5 - fs/read_write.c|1 + include/linux/fs.h |1 + 3 files

[PATCH 05/32] mm: Provide lru_to_last_page() to get last of a page list

2020-07-13 Thread David Howells
Provide a macro, lru_to_last_page(), to find the last page in a page list (the opposite of lru_to_page()). Signed-off-by: David Howells --- include/linux/mm.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index dc7b87310c10..9692b9b58b06 100644

[PATCH 02/32] vm: Add wait/unlock functions for PG_fscache

2020-07-13 Thread David Howells
Add functions to unlock and wait for unlock of PG_fscache analogously with those for PG_lock. Signed-off-by: David Howells --- include/linux/pagemap.h | 14 ++ mm/filemap.c| 18 ++ 2 files changed, 32 insertions(+) diff --git

[PATCH 01/32] iov_iter: Add ITER_MAPPING

2020-07-13 Thread David Howells
Add an iterator, ITER_MAPPING, that walks through a set of pages attached to an address_space, starting at a given page and offset and walking for the specified amount of bytes. The caller must guarantee that the pages are all present and they must be locked using PG_locked, PG_writeback or

[PATCH 04/32] vfs: Provide S_CACHE_FILE inode flag

2020-07-13 Thread David Howells
Provide an S_CACHE_FILE inode flag that cachefiles can set to ward off other kernel services and drivers (including itself) from using its cache files. Signed-off-by: David Howells --- include/linux/fs.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/fs.h

[PATCH 07/32] fscache: Provide a simple thread pool for running ops asynchronously

2020-07-13 Thread David Howells
Provide a simple thread pool that can be used to run cookie management operations in the background and a dispatcher infrastructure to punt operations to the pool if threads are available or to just run the operation in the calling thread if not. A future patch will replace all the object state

[PATCH 06/32] cachefiles: Remove tree of active files and use S_CACHE_FILE inode flag

2020-07-13 Thread David Howells
Remove the tree of active dentries from the cachefiles_cache struct and instead set a flag, S_CACHE_FILE, on the backing inode to indicate that this file is in use by the kernel so as to ward off other kernel users. This simplifies the code a lot and also prevents two overlain caches from

[PATCH] memory: Replace HTTP links with HTTPS ones

2020-07-13 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH 09/32] fscache: Rewrite the I/O API based on iov_iter

2020-07-13 Thread David Howells
Rewrite the fscache I/O API by introducing a number of new routines based on a number of principles: (1) The cache provides *only* write-to-cache and read-from-cache calls for transferring data to/from the cache. (2) The bufferage for I/O to/from the cache is supplied with an iov_iter.

Re: [PATCH] gcc-plugins: Replace HTTP links with HTTPS ones

2020-07-13 Thread Kees Cook
On Mon, Jul 13, 2020 at 03:50:18PM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If

Re: [PATCH 1/3] Bluetooth: Add new quirk for broken local ext features max_page

2020-07-13 Thread Marcel Holtmann
Hi Vasily, >> maybe just the read sync train params command is broken? Can you change the >> init code and not send it and see if the rest of the init phase proceeds. I >> would rather have the secure connections actually tested before dismissing >> it altogether. > > I don't think that I

[PATCH 10/32] fscache: Remove fscache_wait_on_invalidate()

2020-07-13 Thread David Howells
Remove fscache_wait_on_invalidate() as the invalidation wait is now built into the I/O path. Signed-off-by: David Howells --- fs/fscache/cookie.c | 14 -- include/linux/fscache.h | 17 - 2 files changed, 31 deletions(-) diff --git a/fs/fscache/cookie.c

Re: [PATCH 21/25] pinctrl: pinctrl-single: Fix struct/function documentation blocks

2020-07-13 Thread Tony Lindgren
* Lee Jones [200713 14:50]: > Add some missing attributes/parameter descriptions, remove other > superfluous ones, add struct header titles and fix misspellings. > > Fixes the following W=1 kernel build warning(s): > > drivers/pinctrl/pinctrl-single.c:50: warning: Function parameter or member

[PATCH 08/32] fscache: Replace the object management state machine

2020-07-13 Thread David Howells
Replace the object management state machine with something a lot simpler. The entire process of setting up or tearing down a cookie is done in one go, and the dispatcher either punts it to a worker thread, or if all the worker threads are all busy, does it in the current thread.

[PATCH 11/32] fscache: Keep track of size of a file last set independently on the server

2020-07-13 Thread David Howells
Keep track of the size of a file that we're caching as last set independently on the server by another client. As long as this does not change, we can make the assumption that anything over that boundary, if not represented in the local cache, will not be represented on the server either and can

[PATCH 13/32] fscache: Recast assertion in terms of cookie not being an index

2020-07-13 Thread David Howells
Recast assertion in terms of cookie not being an index rather than being a datafile. Signed-off-by: David Howells --- fs/fscache/cookie.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fscache/cookie.c b/fs/fscache/cookie.c index 5c53027d3f53..2d9d147411cd 100644 ---

[PATCH 12/32] fscache, cachefiles: Fix disabled histogram warnings

2020-07-13 Thread David Howells
Fix variable unused warnings due to disabled histogram stuff. Signed-off-by: David Howells --- fs/cachefiles/internal.h |7 +-- fs/fscache/internal.h|6 -- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h

[PATCH 17/32] cachefiles: Implement new fscache I/O backend API

2020-07-13 Thread David Howells
Implement the new fscache I/O backend API in cachefiles. The cachefiles_object struct carries a non-accounted file to the cachefiles object (so that it doesn't cause ENFILE). Signed-off-by: David Howells --- fs/cachefiles/Makefile|1 + fs/cachefiles/interface.c |3 ++

[PATCH 16/32] cachefiles: Split cachefiles_drop_object() up a bit

2020-07-13 Thread David Howells
Split cachefiles_drop_object() up a bit to make it easier to modify later. Signed-off-by: David Howells --- fs/cachefiles/interface.c | 58 ++--- 1 file changed, 39 insertions(+), 19 deletions(-) diff --git a/fs/cachefiles/interface.c

[PATCH 14/32] cachefiles: Remove some redundant checks on unsigned values

2020-07-13 Thread David Howells
Remove some redundant checks for unsigned values being >= 0. Signed-off-by: David Howells --- fs/cachefiles/bind.c |6 ++ fs/cachefiles/daemon.c |6 +++--- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/fs/cachefiles/bind.c b/fs/cachefiles/bind.c index

Re: [PATCH net-next v6 1/4] net: phy: add USXGMII link partner ability constants

2020-07-13 Thread Vladimir Oltean
On Thu, Jul 09, 2020 at 11:35:23PM +0200, Michael Walle wrote: > The constants are taken from the USXGMII Singleport Copper Interface > specification. The naming are based on the SGMII ones, but with an MDIO_ > prefix. > > Signed-off-by: Michael Walle > --- Somebody would need to review this

Re: [PATCH net-next v6 2/4] net: dsa: felix: (re)use already existing constants

2020-07-13 Thread Vladimir Oltean
On Thu, Jul 09, 2020 at 11:35:24PM +0200, Michael Walle wrote: > Now that there are USXGMII constants available, drop the old definitions > and reuse the generic ones. > > Signed-off-by: Michael Walle > --- I did regression-testing of this on an LS1028A-QDS with SerDes protocol 0x13bb.

[PATCH 18/32] cachefiles: Merge object->backer into object->dentry

2020-07-13 Thread David Howells
Merge the object->backer pointer into the object->dentry pointer and assume that data objects are always going to be just regular files. object->dentry can then more easily be overridden later by invalidation without having two different things to update the xattrs on. object->old maintains a

[PATCH 15/32] cachefiles: trace: Log coherency checks

2020-07-13 Thread David Howells
Add a cachefiles tracepoint that logs the result of coherency management when the coherency data on a file in the cache is checked or committed. Signed-off-by: David Howells --- fs/cachefiles/xattr.c | 45 ++ include/trace/events/cachefiles.h | 56

[PATCH 19/32] cachefiles: Implement a content-present indicator and bitmap

2020-07-13 Thread David Howells
Implement a content indicator that indicates the presence or absence of content and a bitmap that indicates which blocks of granular content are present in a granular file. This is added to the xattr that stores the netfs coherency data, along with the file size and the file zero point (the point

[PATCH 21/32] cachefiles: Round the cachefile size up to DIO block size

2020-07-13 Thread David Howells
Round the size of a cachefile up to DIO block size so that we can always read back the last partial page of a file using direct I/O. Signed-off-by: David Howells --- fs/cachefiles/interface.c | 13 + 1 file changed, 13 insertions(+) diff --git a/fs/cachefiles/interface.c

[PATCH 20/32] cachefiles: Implement extent shaper

2020-07-13 Thread David Howells
Implement the function that shapes extents to map onto the granules in a cache file. When setting to fetch data from the server to be cached, the extent will be expanded to align with granule size and cut down so that it doesn't cross the boundary between a non-present extent and a present

[PATCH 23/32] cachefiles: Add I/O tracepoints

2020-07-13 Thread David Howells
--- fs/cachefiles/interface.c | 16 +++-- fs/cachefiles/io.c|2 + include/trace/events/cachefiles.h | 123 + 3 files changed, 136 insertions(+), 5 deletions(-) diff --git a/fs/cachefiles/interface.c b/fs/cachefiles/interface.c

[PATCH 22/32] cachefiles: Implement read and write parts of new I/O API

2020-07-13 Thread David Howells
Implement writing into the cache and reading back from the cache inside cachefiles using asynchronous direct I/O from the specified iterator. The size and position of the request should be aligned to the reported dio_block_size. Errors and completion are reported by callback. Signed-off-by:

[PATCH 28/32] fscache, cachefiles: Rewrite invalidation

2020-07-13 Thread David Howells
Rewrite the cache object invalidation code in fscache and cachefiles. The following changes are made to fscache: (1) Invalidation is now ignored or allowed to proceed depending on the 'stage' a non-index cookie is in with respect to the backing object. (2) If invalidation is proceeds, it

[PATCH 24/32] fscache: Add read helper

2020-07-13 Thread David Howells
Add a trio of helper functions: fscache_read_helper_page_list(); fscache_read_helper_locked_page(); fscache_read_helper_for_write(); to do the work of shaping read requests, attempting to read from the cache, issuing or reissuing requests to the filesystem to pass to the

[PATCH 27/32] fscache: New stats

2020-07-13 Thread David Howells
Create some new stat counters appropriate to the new routines and display them in /proc/fs/fscache/stats. Signed-off-by: David Howells --- fs/fscache/dispatcher.c |6 fs/fscache/internal.h| 25 + fs/fscache/io.c |2 + fs/fscache/read_helper.c | 38

Re: [PATCH v2] Bluetooth: btusb: add Realtek 8822CE to usb_device_id table

2020-07-13 Thread Marcel Holtmann
Hi Joseph, > This patch adds the Realtek 8822CE controller to the usb_device_id > table to support the wideband speech capability. > > Reviewed-by: ala...@chromium.org > Signed-off-by: Joseph Hwang > --- > > Changes in v2: > - Fixed the commit subject and message body. > >

[PATCH 25/32] fscache: Display cache-specific data in /proc/fs/fscache/objects

2020-07-13 Thread David Howells
Allow the cache to add information in /proc/fs/fscache/objects instead of displaying cookie key and aux data - which can be seen in the cookies file. Signed-off-by: David Howells --- fs/cachefiles/content-map.c | 41 + fs/cachefiles/interface.c |

Re: [PATCH] firmware: qcom_scm: Fix legacy convention SCM accessors

2020-07-13 Thread Elliot Berman
For the Qualcomm TrustZone firmwares which I am familiar with: Reviewed-by: Elliot Berman On 7/4/2020 10:23 AM, Jonathan McDowell wrote: > The move to a combined driver for the QCOM SCM hardware changed the > io_writel and io_readl helpers to use non-atomic calls, despite the > commit message

[PATCH 26/32] fscache: Remove more obsolete stats

2020-07-13 Thread David Howells
Remove some more stats that have become obsolete. Signed-off-by: David Howells --- fs/fscache/internal.h | 18 ++ fs/fscache/obj.c |6 +++--- fs/fscache/stats.c| 50 + 3 files changed, 14 insertions(+), 60

[PATCH 29/32] fscache: Implement "will_modify" parameter on fscache_use_cookie()

2020-07-13 Thread David Howells
Implement the "will_modify" parameter passed to fscache_use_cookie(). Setting this to true will henceforth cause the affected object to be marked as dirty on disk, subject to conflict resolution in the event that power failure or a crash occurs or the filesystem operates in disconnected mode.

Re: [PATCH v2 17/22] drivers/base: Make device_find_child_by_name() compatible with sysfs inputs

2020-07-13 Thread Dan Williams
On Mon, Jul 13, 2020 at 9:13 AM Greg Kroah-Hartman wrote: > > On Mon, Jul 13, 2020 at 09:09:18AM -0700, Dan Williams wrote: > > On Mon, Jul 13, 2020 at 8:52 AM Greg Kroah-Hartman > > wrote: > > > > > > On Mon, Jul 13, 2020 at 08:39:43AM -0700, Dan Williams wrote: > > > > On Sun, Jul 12, 2020 at

[PATCH 30/32] fscache: Provide resize operation

2020-07-13 Thread David Howells
Provide a cache operation to resize an object. This is intended to be run synchronously rather than being deferred as it really needs to run inside the inode lock on the netfs inode from ->setattr() to correctly order with respect to other truncates and writes. Signed-off-by: David Howells ---

[PATCH 01/13] afs: Fix interruption of operations

2020-07-13 Thread David Howells
The afs filesystem driver allows unstarted operations to be cancelled by signal, but most of these can easily be restarted (mkdir for example). The primary culprits for reproducing this are those applications that use SIGALRM to display a progress counter. File lock-extension operation is marked

[PATCH 31/32] fscache: Remove the update operation

2020-07-13 Thread David Howells
Remove the cache-side of the object update operation as it doesn't serialise with other setattr, O_TRUNC and write operations. Signed-off-by: David Howells --- fs/cachefiles/interface.c | 59 - fs/fscache/internal.h |1 -

Re: [PATCH v2 19/22] mm/memremap_pages: Convert to 'struct range'

2020-07-13 Thread Ralph Campbell
On 7/12/20 9:27 AM, Dan Williams wrote: The 'struct resource' in 'struct dev_pagemap' is only used for holding resource span information. The other fields, 'name', 'flags', 'desc', 'parent', 'sibling', and 'child' are all unused wasted space. This is in preparation for introducing a

[PATCH 32/32] cachefiles: Shape write requests

2020-07-13 Thread David Howells
In cachefiles_shape_extent(), shape a write request to always write to the cache. The assumption is made that the caller has read the entire cache granule beforehand if necessary. Possibly this should be amended so that writes will only take place to granules that are marked present and granules

[PATCH 00/13] fscache: Rewrite 3: Make AFS use it

2020-07-13 Thread David Howells
Here's a set of patches that makes AFS use the fscache rewrite. These patches can be found as part of the branch here: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache-iter David --- David Howells (1): afs: Add O_DIRECT read support

[PATCH 03/13] afs: Don't truncate iter during data fetch

2020-07-13 Thread David Howells
Don't truncate the iterator to correspond to the actual data size when fetching the data from the server - rather, pass the length we want to read to rxrpc. This will allow the clear-after-read code in future to simply clear the remaining iterator capacity rather than having to reinitialise the

[PATCH 05/13] afs: Set up the iov_iter before calling afs_extract_data()

2020-07-13 Thread David Howells
afs_extract_data sets up a temporary iov_iter and passes it to AF_RXRPC each time it is called to describe the remaining buffer to be filled. Instead: (1) Put an iterator in the afs_call struct. (2) Set the iterator for each marshalling stage to load data into the appropriate places. A

[PATCH 02/13] afs: Move key to afs_read struct

2020-07-13 Thread David Howells
Stash the key used to authenticate read operations in the afs_read struct. This will be necessary to reissue the operation against the server if a read from the cache fails in upcoming cache changes. Signed-off-by: David Howells --- fs/afs/dir.c |3 ++- fs/afs/file.c | 16

Re: [RFC PATCH 4/7] x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode

2020-07-13 Thread Nicholas Piggin
Excerpts from Andy Lutomirski's message of July 14, 2020 1:48 am: > On Mon, Jul 13, 2020 at 7:13 AM Mathieu Desnoyers > wrote: >> >> - On Jul 13, 2020, at 9:47 AM, Nicholas Piggin npig...@gmail.com wrote: >> >> > Excerpts from Nicholas Piggin's message of July 13, 2020 2:45 pm: >> >> Excerpts

[PATCH 04/13] afs: Log remote unmarshalling errors

2020-07-13 Thread David Howells
Log unmarshalling errors reported by the peer (ie. it can't parse what we sent it). Limit the maximum number of messages to 3. Signed-off-by: David Howells --- fs/afs/rxrpc.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/fs/afs/rxrpc.c

Re: [PATCH net-next v6 3/4] net: enetc: Initialize SerDes for SGMII and USXGMII protocols

2020-07-13 Thread Vladimir Oltean
On Thu, Jul 09, 2020 at 11:35:25PM +0200, Michael Walle wrote: > ENETC has ethernet MACs capable of SGMII, 2500BaseX and USXGMII. But in > order to use these protocols some SerDes configurations need to be > performed. The SerDes is configurable via an internal PCS PHY which is > connected to an

Re: [PATCH 1/2] cpufreq: tegra186: Fix initial frequency

2020-07-13 Thread Jon Hunter
On 13/07/2020 04:25, Viresh Kumar wrote: > On 12-07-20, 11:06, Jon Hunter wrote: >> Commit 6cc3d0e9a097 ("cpufreq: tegra186: add >> CPUFREQ_NEED_INITIAL_FREQ_CHECK flag") fixed CPUFREQ support for >> Tegra186 but as a consequence the following warnings are now seen on >> boot ... >> >> cpufreq:

[PATCH 08/13] afs: Note the amount transferred in fetch-data delivery

2020-07-13 Thread David Howells
Note the amount of data transferred in the fscache request op structure in the delivery/decode routines for the various FetchData operations. Also, we need to exclude the excess from this value and then we need to use this in directory read rather than actual_len. Signed-off-by: David Howells

[PATCH 07/13] afs: Interpose struct fscache_io_request into struct afs_read

2020-07-13 Thread David Howells
Embed an fscache_io_request struct into struct afs_read and remove some of the redundant members from the latter. Change all references to those removed members to use the fscache ones instead. Signed-off-by: David Howells --- fs/afs/dir.c | 38 --

Re: [PATCH v1] Bluetooth: hci_qca: Bug fixes for SSR

2020-07-13 Thread Marcel Holtmann
Hi Venkata, > 1.During SSR for command time out if BT SoC goes to inresponsive > state, power cycling of BT SoC was not happening.Given the fix by > sending hw error event to reset the BT SoC. > > 2.If SSR is triggered then ignore the transmit data requests to > BT SoC until SSR is completed. >

[PATCH 06/13] afs: Use ITER_MAPPING for writing

2020-07-13 Thread David Howells
Use a single ITER_MAPPING iterator to describe the portion of a file to be transmitted to the server rather than generating a series of small ITER_BVEC iterators on the fly. This will make it easier to implement AIO in afs. In theory we could maybe use one giant ITER_BVEC, but that means

[PATCH 09/13] afs: Wait on PG_fscache before modifying/releasing a page

2020-07-13 Thread David Howells
PG_fscache is going to be used to indicate that a page is being written to the cache, and that the page should not be modified or released until it's finished. Make afs_invalidatepage() and afs_releasepage() wait for it. Signed-off-by: David Howells --- fs/afs/file.c |7 +++

[PATCH 10/13] afs: Use new fscache I/O API

2020-07-13 Thread David Howells
Make AFS use the new fscache I/O API to read and write from the cache. afs_readpage() now calls fscache_read_helper() once to try and create a block around the page to be read. afs_readpages() now calls fscache_read_helper() multiple times until its list is exhausted or an error occurs.

[PATCH 13/13] afs: Add O_DIRECT read support

2020-07-13 Thread David Howells
Add synchronous O_DIRECT read support to AFS (no AIO yet). It can theoretically handle reads up to the maximum size describable by loff_t - and given an iterator with sufficiently capacity to handle that and given support on the server. Signed-off-by: David Howells --- fs/afs/file.c |

Re: [PATCH net-next v6 4/4] net: enetc: Use DT protocol information to set up the ports

2020-07-13 Thread Vladimir Oltean
On Thu, Jul 09, 2020 at 11:35:26PM +0200, Michael Walle wrote: > From: Alex Marginean > > Use DT information rather than in-band information from bootloader to > set up MAC for XGMII. For RGMII use the DT indication in addition to > RGMII defaults in hardware. > However, this implies that PHY

[PATCH 11/13] afs: Copy local writes to the cache when writing to the server

2020-07-13 Thread David Howells
When writing to the server from afs_writepage() or afs_writepages(), copy the data to the cache object too. Signed-off-by: David Howells --- fs/afs/write.c | 132 ++-- 1 file changed, 128 insertions(+), 4 deletions(-) diff --git

[PATCH 12/13] afs: Invoke fscache_resize_cookie() when handling ATTR_SIZE for setattr

2020-07-13 Thread David Howells
Invoke fscache_resize_cookie() to adjust the size of the backing cache object when setattr is called with ATTR_SIZE. This discards any data that then lies beyond the revised EOF and frees up space. Signed-off-by: David Howells --- fs/afs/inode.c | 24 +++- 1 file

[PATCH] misc: Replace HTTP links with HTTPS ones

2020-07-13 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH v6] xfs: Fix false positive lockdep warning with sb_internal & fs_reclaim

2020-07-13 Thread Darrick J. Wong
On Tue, Jul 07, 2020 at 03:16:29PM -0400, Waiman Long wrote: > Depending on the workloads, the following circular locking dependency > warning between sb_internal (a percpu rwsem) and fs_reclaim (a pseudo > lock) may show up: > > == > WARNING:

Re: [TEGRA194_CPUFREQ PATCH v5 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property

2020-07-13 Thread Rob Herring
On Mon, Jul 13, 2020 at 07:36:46PM +0530, Sumit Gupta wrote: > To do frequency scaling on all CPUs within T194 CPU Complex, we need > to query BPMP for data on valid operating points. Document a compatible > string under 'cpus' node to represent the CPU Complex for binding drivers > like cpufreq

linux plumbers + clang + s390 virtualized testing

2020-07-13 Thread Nick Desaulniers
Hi Vasily and Heiko, We were very excited to see your patches going by for enabling Clang support for s390. Since then, we've added s390 builds to our continuous integration setup. We've been running into a few issues with doing virtualized boot tests of our kernels on s390. I was curious if

Re: [Linux-kernel-mentees] [PATCH 1/2] net/bluetooth: Prevent out-of-bounds read in hci_inquiry_result_evt()

2020-07-13 Thread Marcel Holtmann
Hi Peilin, > Check `num_rsp` before using it as for-loop counter. > > Cc: sta...@vger.kernel.org > Signed-off-by: Peilin Ye > --- > net/bluetooth/hci_event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v6 1/2] tmpfs: Per-superblock i_ino support

2020-07-13 Thread Matthew Wilcox
On Mon, Jul 13, 2020 at 05:15:39PM +0100, Chris Down wrote: > +#define SHMEM_INO_BATCH 1024U ... > + if (unlikely((ino & ~SHMEM_INO_BATCH) == 0)) { I don't think that works. I think you meant to write ~(SHMEM_INO_BATCH - 1). Or just ino % SHMEM_INO_BATCH which works even for

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-13 Thread Lorenzo Pieralisi
On Mon, Jul 13, 2020 at 04:50:03PM +0200, Pali Rohár wrote: > On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote: > > I will go over the thread again but I suspect I can merge the patch even > > though I still believe there is work to be done to understand the issue > > we are facing. > >

Re: [Linux-kernel-mentees] [PATCH 2/2] net/bluetooth: Prevent out-of-bounds read in hci_inquiry_result_with_rssi_evt()

2020-07-13 Thread Marcel Holtmann
Hi Peilin, > Check `num_rsp` before using it as for-loop counter. Add `unlock` label. > > Cc: sta...@vger.kernel.org > Signed-off-by: Peilin Ye > --- > net/bluetooth/hci_event.c | 7 +++ > 1 file changed, 7 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [RFC PATCH 09/35] nvme-pci: Change PCIBIOS_SUCCESSFUL to 0

2020-07-13 Thread Rajashekar, Revanth
Hi, On 7/13/2020 6:22 AM, Saheed O. Bolarinwa wrote: > In reference to the PCI spec (Chapter 2), PCIBIOS* is an x86 concept. > Their scope should be limited within arch/x86. > > Change all PCIBIOS_SUCCESSFUL to 0 > > Signed-off-by: "Saheed O. Bolarinwa" > --- > drivers/nvme/host/pci.c | 2 +- >

[PATCH] mm: thp: Replace HTTP links with HTTPS ones

2020-07-13 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH] ARM: dts: Configure osc clock for d_can on am437x

2020-07-13 Thread Tony Lindgren
* dillon.min...@gmail.com [200621 15:36]: > From: dillon min > > Since am437x have the same clock structure with am335x [1][2], > reuse the code from Tony Lindgren's patch [3] to fix dcan probe > failed on am437x platform. > > [1]: https://www.ti.com/lit/pdf/spruh73 Chapter-23, Figure 23-1.

Re: [PATCH v6 1/2] tmpfs: Per-superblock i_ino support

2020-07-13 Thread Chris Down
Matthew Wilcox writes: I don't think that works. I think you meant to write ~(SHMEM_INO_BATCH - 1). Or just ino % SHMEM_INO_BATCH which works even for non-power-of-two. Er, right. I now wonder why I didn't just write `ino % SHMEM_INO_BATCH` :-) I'll send again with that fix.

Re: [PATCH v4 1/2] Add DT bindings YAML schema for PWM fan controller of LGM SoC

2020-07-13 Thread Rob Herring
On Tue, Jun 30, 2020 at 03:55:31PM +0800, Rahul Tanwar wrote: > Intel's LGM(Lightning Mountain) SoC contains a PWM fan controller > which is only used to control the fan attached to the system. This > PWM controller does not have any other consumer other than fan. > Add DT bindings documentation

Re: [PATCH] ARM: OMAP2+: Fix possible memory leak in omap_hwmod_allocate_module

2020-07-13 Thread Tony Lindgren
* Paul Walmsley [200619 15:20]: > On Fri, 19 Jun 2020, Chen Tao wrote: > > > Fix memory leak in omap_hwmod_allocate_module not freeing in > > handling error path. > > > > Fixes: 8c87970543b17("ARM: OMAP2+: Add functions to allocate module data > > from device tree") > > Signed-off-by: Chen Tao

Re: [RFC PATCH 7/7] lazy tlb: shoot lazies, a non-refcounting lazy tlb option

2020-07-13 Thread Nicholas Piggin
Excerpts from Andy Lutomirski's message of July 14, 2020 1:59 am: > On Thu, Jul 9, 2020 at 6:57 PM Nicholas Piggin wrote: >> >> On big systems, the mm refcount can become highly contented when doing >> a lot of context switching with threaded applications (particularly >> switching between the

[PATCH v6] ima: move APPRAISE_BOOTPARAM dependency on ARCH_POLICY to runtime

2020-07-13 Thread Bruno Meneguele
The IMA_APPRAISE_BOOTPARAM config allows enabling different "ima_appraise=" modes - log, fix, enforce - at run time, but not when IMA architecture specific policies are enabled.  This prevents properly labeling the filesystem on systems where secure boot is supported, but not enabled on the

Re: [PATCH v2 0/3] Power10 basic energy management

2020-07-13 Thread Nicholas Piggin
Excerpts from Pratik Sampat's message of July 13, 2020 8:02 pm: > Thank you for your comments, > > On 13/07/20 10:53 am, Nicholas Piggin wrote: >> Excerpts from Pratik Rajesh Sampat's message of July 10, 2020 3:22 pm: >>> Changelog v1 --> v2: >>> 1. Save-restore DAWR and DAWRX unconditionally as

[PATCH] mtd: Replace HTTP links with HTTPS ones

2020-07-13 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH v2 19/22] mm/memremap_pages: Convert to 'struct range'

2020-07-13 Thread Dan Williams
On Mon, Jul 13, 2020 at 9:36 AM Ralph Campbell wrote: > > > On 7/12/20 9:27 AM, Dan Williams wrote: > > The 'struct resource' in 'struct dev_pagemap' is only used for holding > > resource span information. The other fields, 'name', 'flags', 'desc', > > 'parent', 'sibling', and 'child' are all

[PATCH 3/14 v3] ath9k: Check the return value of pcie_capability_read_*()

2020-07-13 Thread Saheed O. Bolarinwa
From: Bolarinwa Olayemi Saheed On failure pcie_capability_read_dword() sets it's last parameter, val to 0. However, with Patch 14/14, it is possible that val is set to ~0 on failure. This would introduce a bug because (x & x) == (~0 & x). This bug can be avoided without changing the function's

[PATCH 1/14 v3] IB/hfi1: Check the return value of pcie_capability_read_*()

2020-07-13 Thread Saheed O. Bolarinwa
From: Bolarinwa Olayemi Saheed On failure pcie_capability_read_dword() sets it's last parameter, val to 0. In this case dn and up will be 0, so aspm_hw_l1_supported() will return false. However, with Patch 14/14, it is possible that val is set to ~0 on failure. This would introduce a bug because

[PATCH 8/14 v3] PCI/ACPI: Check the return value of pcie_capability_read_*()

2020-07-13 Thread Saheed O. Bolarinwa
From: Bolarinwa Olayemi Saheed On failure pcie_capability_read_dword() sets it's last parameter, val to 0. However, with Patch 14/14, it is possible that val is set to ~0 on failure. This would introduce a bug because (x & x) == (~0 & x). This bug can be avoided if the return value of

[PATCH 12/14 v3] PCI/AER: Check the return value of pcie_capability_read_*()

2020-07-13 Thread Saheed O. Bolarinwa
From: Bolarinwa Olayemi Saheed On failure pcie_capability_read_dword() sets it's last parameter, val to 0. However, with Patch 14/14, it is possible that val is set to ~0 on failure. This would introduce a bug because (x & x) == (~0 & x). This bug can be avoided if the return value of

Re: [PATCH v6 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-07-13 Thread Peter Zijlstra
On Mon, Jul 13, 2020 at 03:27:55PM +0100, Qais Yousef wrote: > On 07/13/20 15:35, Peter Zijlstra wrote: > > > I protect this with rcu_read_lock() which as far as I know > > > synchronize_rcu() > > > will ensure if we do the update during this section; we'll wait for it to > > > finish. New

[PATCH 4/14 v3] iwlegacy: Check the return value of pcie_capability_read_*()

2020-07-13 Thread Saheed O. Bolarinwa
From: Bolarinwa Olayemi Saheed On failure pcie_capability_read_dword() sets it's last parameter, val to 0. However, with Patch 14/14, it is possible that val is set to ~0 on failure. This would introduce a bug because (x & x) == (~0 & x). This bug can be avoided without changing the function's

Re: [PATCH 11/18] perf metric: Add referenced metrics to hash data

2020-07-13 Thread Jiri Olsa
On Mon, Jul 13, 2020 at 05:27:53PM +0100, John Garry wrote: > On 12/07/2020 14:26, Jiri Olsa wrote: > > +int expr__add_ref(struct expr_parse_ctx *ctx, struct metric_ref *ref) > > +{ > > + struct expr_id_data *data_ptr = NULL, *old_data = NULL; > > + char *old_key = NULL; > > + char *name; >

Re: [PATCH v2 0/2] arm64: tlb: add support for TLBI RANGE instructions

2020-07-13 Thread Catalin Marinas
On Mon, Jul 13, 2020 at 08:41:31PM +0800, Zhenyu Ye wrote: > On 2020/7/13 20:21, Catalin Marinas wrote: > > On Fri, Jul 10, 2020 at 08:11:19PM +0100, Catalin Marinas wrote: > >> On Fri, 10 Jul 2020 17:44:18 +0800, Zhenyu Ye wrote: > >>> NOTICE: this series are based on the arm64 for-next/tlbi

Re: [PATCH v2 0/3] Power10 basic energy management

2020-07-13 Thread Nicholas Piggin
Excerpts from Gautham R Shenoy's message of July 13, 2020 8:48 pm: > On Mon, Jul 13, 2020 at 03:23:21PM +1000, Nicholas Piggin wrote: >> Excerpts from Pratik Rajesh Sampat's message of July 10, 2020 3:22 pm: >> > Changelog v1 --> v2: >> > 1. Save-restore DAWR and DAWRX unconditionally as they are

Re: [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type

2020-07-13 Thread Thara Gopinath
On 7/13/20 11:05 AM, Daniel Lezcano wrote: On 10/07/2020 15:51, Thara Gopinath wrote: Extend thermal trip point type property to include "cold" trip type indicating point in the temperature domain below which a warming action must be intiated. Signed-off-by: Thara Gopinath ---

Re: [PATCH net-next v6 1/4] net: phy: add USXGMII link partner ability constants

2020-07-13 Thread Andrew Lunn
On Mon, Jul 13, 2020 at 07:34:16PM +0300, Vladimir Oltean wrote: > On Thu, Jul 09, 2020 at 11:35:23PM +0200, Michael Walle wrote: > > The constants are taken from the USXGMII Singleport Copper Interface > > specification. The naming are based on the SGMII ones, but with an MDIO_ > > prefix. > > >

Re: [PATCH v4 1/5] dt-bindings: bus: Add firewall bindings

2020-07-13 Thread Rob Herring
On Wed, Jul 01, 2020 at 03:25:19PM +0200, Benjamin Gaignard wrote: > Add schemas for firewall consumer and provider. > > Signed-off-by: Benjamin Gaignard > Reviewed-by: Linus Walleij > --- > .../bindings/bus/stm32/firewall-consumer.yaml | 36 > ++ >

Re: [PATCH] iommu/arm-smmu: Add a init_context_bank implementation hook

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 04:11:23PM +0100, Will Deacon wrote: > On Thu, Jun 11, 2020 at 04:36:56PM -0600, Jordan Crouse wrote: > > Add a new implementation hook to allow the implementation specific code > > to tweek the context bank configuration just before it gets written. > > The first user will

Re: [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type

2020-07-13 Thread Daniel Lezcano
On 13/07/2020 19:01, Thara Gopinath wrote: > > > On 7/13/20 11:05 AM, Daniel Lezcano wrote: >> On 10/07/2020 15:51, Thara Gopinath wrote: >>> Extend thermal trip point type property to include "cold" trip type >>> indicating point in the temperature domain below which a warming action >>> must

[PATCH] mtd: rawnand: omap_elm: Replace HTTP links with HTTPS ones

2020-07-13 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH v4 3/5] dt-bindings: bus: Add STM32 ETZPC firewall controller

2020-07-13 Thread Rob Herring
On Wed, Jul 01, 2020 at 03:25:21PM +0200, Benjamin Gaignard wrote: > Document STM32 ETZPC firewall controller bindings > > Signed-off-by: Benjamin Gaignard > --- > .../bindings/bus/stm32/st,stm32-etzpc.yaml | 46 > ++ > 1 file changed, 46 insertions(+) > create

Re: [PATCH net-next v6 1/4] net: phy: add USXGMII link partner ability constants

2020-07-13 Thread Michael Walle
Am 2020-07-13 19:01, schrieb Andrew Lunn: On Mon, Jul 13, 2020 at 07:34:16PM +0300, Vladimir Oltean wrote: On Thu, Jul 09, 2020 at 11:35:23PM +0200, Michael Walle wrote: > The constants are taken from the USXGMII Singleport Copper Interface > specification. The naming are based on the SGMII

[PATCH v4 1/2] drm/probe_helper: Add drm_connector_helper_funcs.mode_valid_ctx

2020-07-13 Thread Lyude Paul
This is just an atomic version of mode_valid, which is intended to be used for situations where a driver might need to check the atomic state of objects other than the connector itself. One such example is with MST, where the maximum possible bandwidth on a connector can change dynamically

<    3   4   5   6   7   8   9   10   11   12   >