Re: [PATCH] usb: dwc2: Fix error path in gadget registration

2020-07-15 Thread Minas Harutyunyan
Hi Marek, On 7/15/2020 12:42 PM, Marek Szyprowski wrote: > Hi Minas, > > On 14.07.2020 14:32, Minas Harutyunyan wrote: >> On 7/14/2020 12:48 PM, Marek Szyprowski wrote: >>> When gadget registration fails, one should not call usb_del_gadget_udc(). >>> Ensure this by setting gadget->udc to NULL. Al

[PATCH] cpufreq: intel_pstate: Clean up aperf_mperf_shift description

2020-07-15 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The kerneldoc description of the aperf_mperf_shift field in struct global_params is unclear and there is a typo in it, so simplify it and clean it up. Reported-by: Lee Jones Signed-off-by: Rafael J. Wysocki --- drivers/cpufreq/intel_pstate.c |4 +--- 1 file changed

Re: [RFC PATCH 2/4] rseq: Allow extending struct rseq

2020-07-15 Thread Christian Brauner
On Wed, Jul 15, 2020 at 03:42:11PM +0200, Florian Weimer wrote: > * Mathieu Desnoyers: > > > So indeed it could be done today without upgrading the toolchains by > > writing custom assembler for each architecture to get the thread's > > struct rseq. AFAIU the ABI to access the thread pointer is fi

[PATCH] watchdog: initialize device before misc_register

2020-07-15 Thread krzysztof.sob...@nokia.com
From: Krzysztof Sobota Date: Wed, 15 Jul 2020 13:13:42 +0200 Subject: [PATCH] watchdog: initialize device before misc_register When watchdog device is being registered, it calls misc_register that makes watchdog available for systemd to open. This is a data race scenario, because when device is

[PATCH RFC don't apply] vdpa_sim: endian-ness for config space

2020-07-15 Thread Michael S. Tsirkin
VDPA sim stores config space as native endian, but that is wrong: modern guests expect LE. I coded up the following to fix it up, but it is wrong too: vdpasim_create is called before guest features are known. So what should we do? New ioctl to specify the interface used? More ideas? Signed-off-by

Re: [PATCH][next] dmaengine: ti: k3-udma: Use struct_size() in kzalloc()

2020-07-15 Thread Gustavo A. R. Silva
On 7/15/20 01:21, Vinod Koul wrote: > On 10-07-20, 13:25, Gustavo A. R. Silva wrote: >> Hi all, >> >> Friendly ping: who can take this, please? > > Applied now > Thanks, Vinod. -- Gustavo

Re: [PATCH] staging: rtl8188eu: core: fix coding style issues

2020-07-15 Thread Greg KH
On Wed, Jul 15, 2020 at 02:55:59AM +0530, Arpitha wrote: > Fixing WARNING: Prefer using '"%s...", __func__' to using 'function_name' > in a string in rtw_ioctl_set.c > > Signed-off-by: Arpitha <98.a...@gmail.com> We need a "full" name for kernel patches, what you use to sign documents. Same for

Re: [PATCH v2] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins.

2020-07-15 Thread Tetsuo Handa
On 2020/07/15 20:17, Tetsuo Handa wrote: > On 2020/07/15 18:48, Dan Carpenter wrote: >>> @@ -216,7 +216,7 @@ static void bit_clear_margins(struct vc_data *vc, >>> struct fb_info *info, >>> region.color = color; >>> region.rop = ROP_COPY; >>> >>> - if (rw && !bottom_only) { >>> + if (

Re: [PATCH RFC don't apply] vdpa_sim: endian-ness for config space

2020-07-15 Thread Jason Wang
On 2020/7/15 下午9:58, Michael S. Tsirkin wrote: VDPA sim stores config space as native endian, but that is wrong: modern guests expect LE. I coded up the following to fix it up, but it is wrong too: vdpasim_create is called before guest features are known. So what should we do? New ioctl to spe

Re: [PATCH 0/4] ASoC: fsl_asrc: allow selecting arbitrary clocks

2020-07-15 Thread Mark Brown
On Tue, Jul 14, 2020 at 01:50:50PM -0700, Nicolin Chen wrote: > On Tue, Jul 14, 2020 at 09:27:53PM +0100, Mark Brown wrote: > > The nominal rate might be the same but if they're in different clock > > domains then the actual rates might be different (hence the desire for > > an ASRC I guess). I c

[PATCH V3] arm64: dts: Introduce r8a774a1-beacon-rzg2m-kit

2020-07-15 Thread Adam Ford
Beacon EmebeddedWorks, formerly Logic PD is introducing a new SOM and development kit based on the RZ/G2M SoC from Renesas. The SOM supports eMMC, WiFi and Bluetooth, along with a Cat-M1 cellular radio. The Baseboard has Ethernet, USB, HDMI, stereo audio in and out, along with a variety of push b

[PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-15 Thread John Donnelly
From: Mike Snitzer Discontinue issuing writethrough write IO in series to the origin and then cache. Use bio_clone_fast() to create a new origin clone bio that will be mapped to the origin device and then bio_chain() it to the bio that gets remapped to the cache device. The origin clone bio doe

Re: [RFC PATCH v1 1/2] Bluetooth: queue ACL packets if no handle is found

2020-07-15 Thread Alain Michaud
Resending in plain text. On Wed, Jul 15, 2020 at 9:56 AM Alain Michaud wrote: > > Hi Marcel, > > Sorry, just got around to this. > > On Tue, Jun 30, 2020 at 2:55 AM Marcel Holtmann wrote: >> >> Hi Archie, >> >> >>> There is a possibility that an ACL packet is received before we >> >>> receive t

Re: [RESEND][PATCH] hwmon: scmi: fix potential buffer overflow in scmi_hwmon_probe()

2020-07-15 Thread Guenter Roeck
On Wed, Jul 15, 2020 at 01:13:38PM +0100, Cristian Marussi wrote: > SMATCH detected a potential buffer overflow in the manipulation of > hwmon_attributes array inside the scmi_hwmon_probe function: > > drivers/hwmon/scmi-hwmon.c:226 > scmi_hwmon_probe() error: buffer overflow 'hwmon_attributes' 6

Re: [PATCH 0/6] staging: dpaa2-ethsw: cleanup of link state and MAC addresses

2020-07-15 Thread Greg KH
On Tue, Jul 14, 2020 at 04:34:25PM +0300, Ioana Ciornei wrote: > This patch set is cleaning up the link state handling of the switch > ports in patches 1-4. The last two patches are setting up the MAC > addresses of the switch ports automatically so that the user is not > forced to manually add the

Re: [PATCH 7/9] soundwire: intel/cadence: merge Soundwire interrupt handlers/threads

2020-07-15 Thread Pierre-Louis Bossart
On 7/14/20 11:54 PM, Vinod Koul wrote: On 02-07-20, 10:01, Pierre-Louis Bossart wrote: Sounds good. Now that you are already in irq thread, does it make sense to spawn a worker thread for this and handle it there? Why not do in the irq thread itself. Using a thread kind of defeats the whol

Re: [GIT PULL tip/core/rcu] RCU commits for v5.9

2020-07-15 Thread Paul E. McKenney
On Tue, Jul 14, 2020 at 10:17:34PM +0200, Uladzislau Rezki wrote: > On Tue, Jul 14, 2020 at 11:27:32AM -0700, Paul E. McKenney wrote: > > On Tue, Jul 14, 2020 at 08:14:26PM +0200, Sebastian Andrzej Siewior wrote: > > > On 2020-07-14 10:27:01 [-0700], Paul E. McKenney wrote: > > > > Joel Fernandes (

[PATCH v2 0/3] ASoC: fsl-asoc-card: Support hp and mic detection

2020-07-15 Thread Shengjiu Wang
Support hp and mic detection. Add a parameter for asoc_simple_init_jack. Shengjiu Wang (3): ASoC: simple-card-utils: Support configure pin_name for asoc_simple_init_jack ASoC: bindings: fsl-asoc-card: Support hp-det-gpio and mic-det-gpio ASoC: fsl-asoc-card: Support Headphone and Microph

[PATCH v2 1/3] ASoC: simple-card-utils: Support configure pin_name for asoc_simple_init_jack

2020-07-15 Thread Shengjiu Wang
Currently the pin_name is fixed in asoc_simple_init_jack, but some driver may use a different pin_name. So add a new parameter in asoc_simple_init_jack for configuring pin_name. If this parameter is NULL, then the default pin_name is used. Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen ---

[PATCH v2 2/3] ASoC: bindings: fsl-asoc-card: Support hp-det-gpio and mic-det-gpio

2020-07-15 Thread Shengjiu Wang
Add headphone and microphone detection GPIO support. These properties are optional. Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen --- Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/fs

[PATCH v2 3/3] ASoC: fsl-asoc-card: Support Headphone and Microphone Jack detection

2020-07-15 Thread Shengjiu Wang
Use asoc_simple_init_jack function from simple card to implement the Headphone and Microphone detection. Register notifier to disable Speaker when Headphone is plugged in and enable Speaker when Headphone is unplugged. Register notifier to disable Digital Microphone when Analog Microphone is plugge

Re: [PATCH V3] arm64/hugetlb: Reserve CMA areas for gigantic pages on 16K and 64K configs

2020-07-15 Thread Catalin Marinas
On Wed, 1 Jul 2020 10:12:01 +0530, Anshuman Khandual wrote: > Currently 'hugetlb_cma=' command line argument does not create CMA area on > ARM64_16K_PAGES and ARM64_64K_PAGES based platforms. Instead, it just ends > up with the following warning message. Reason being, hugetlb_cma_reserve() > never

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-15 Thread Sebastian Andrzej Siewior
On 2020-07-15 15:38:08 [+0200], Uladzislau Rezki wrote: > > As of -rc3 it should complain about printk() which is why it is still > > disabled by default. > > > Have you tried to trigger a "complain" you are talking about? No, but I is wrong because a raw_spinlock_t is acquired followed by a spin

RE: [PATCH 0/6] staging: dpaa2-ethsw: cleanup of link state and MAC addresses

2020-07-15 Thread Ioana Ciornei
> Subject: Re: [PATCH 0/6] staging: dpaa2-ethsw: cleanup of link state and MAC > addresses > > On Tue, Jul 14, 2020 at 04:34:25PM +0300, Ioana Ciornei wrote: > > This patch set is cleaning up the link state handling of the switch > > ports in patches 1-4. The last two patches are setting up the MA

Re: [PATCH] cpufreq: intel_pstate: Clean up aperf_mperf_shift description

2020-07-15 Thread Lee Jones
On Wed, 15 Jul 2020, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The kerneldoc description of the aperf_mperf_shift field in > struct global_params is unclear and there is a typo in it, so > simplify it and clean it up. > > Reported-by: Lee Jones > Signed-off-by: Rafael J. Wysocki

Re: [RFC PATCH 2/4] rseq: Allow extending struct rseq

2020-07-15 Thread Mathieu Desnoyers
- On Jul 15, 2020, at 9:55 AM, Christian Brauner christian.brau...@ubuntu.com wrote: > On Wed, Jul 15, 2020 at 03:42:11PM +0200, Florian Weimer wrote: >> * Mathieu Desnoyers: >> >> > So indeed it could be done today without upgrading the toolchains by >> > writing custom assembler for each a

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-15 Thread Uladzislau Rezki
On Wed, Jul 15, 2020 at 04:16:22PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-07-15 15:38:08 [+0200], Uladzislau Rezki wrote: > > > As of -rc3 it should complain about printk() which is why it is still > > > disabled by default. > > > > > Have you tried to trigger a "complain" you are talki

Re: [PATCH 2/3] ARM: dts: imx7: add support for kamstrup flex concentrator

2020-07-15 Thread Bruno Thomsen
Den tir. 14. jul. 2020 kl. 13.54 skrev Fabio Estevam : > > Hi Bruno, > > On Tue, Jul 14, 2020 at 7:03 AM Bruno Thomsen wrote: > > > I have not yet been successful in converting the deprecated properties > > to generic phy properties, so hoping I could get a hit. > > > > Kernel error messages: > >

Re: [PATCH 8/9] soundwire: intel: add wake interrupt support

2020-07-15 Thread Pierre-Louis Bossart
On 7/14/20 11:50 PM, Vinod Koul wrote: On 01-07-20, 10:25, Pierre-Louis Bossart wrote: +* wake up master and slave so that slave can notify master +* the wakeen event and let codec driver check codec status +*/ + list_for_each_entry(slave, &bus->slaves, node) {

[PATCH 4/5] PCI: aardvark: Implement driver 'remove' function and allow to build it as module

2020-07-15 Thread Marek Behún
From: Pali Rohár Providing driver's 'remove' function allows kernel to bind and unbind devices from aardvark driver. It also allows to build aardvark driver as a module. Compiling aardvark as a module simplifies development and debugging of this driver as it can be reloaded at runtime without th

[PATCH 1/5] PCI: aardvark: Fix compilation on s390

2020-07-15 Thread Marek Behún
From: Pali Rohár Include linux/gpio/consumer.h instead of linux/gpio.h, as is said in the latter file. This was reported by kernel test bot when compiling for s390. drivers/pci/controller/pci-aardvark.c:350:2: error: implicit declaration of function 'gpiod_set_value_cansleep' [-Werror,-Wimpl

[PATCH 5/5] PCI: aardvark: Move PCIe reset card code to advk_pcie_train_link()

2020-07-15 Thread Marek Behún
From: Pali Rohár Move code which belongs to link training (delays and resets) into advk_pcie_train_link() function, so everything related to link training, including timings is at one place. After experiments it can be observed that link training in aardvark hardware is very sensitive to timings

[PATCH 3/5] PCI: pci-bridge-emul: Export API functions

2020-07-15 Thread Marek Behún
From: Pali Rohár It allows kernel modules which are not compiled into kernel image to use pci-bridge-emul API functions. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci-bridge-emul.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pci/pci-bridge-emul.c b

[PATCH 2/5] PCI: aardvark: Check for errors from pci_bridge_emul_init() call

2020-07-15 Thread Marek Behún
From: Pali Rohár Function pci_bridge_emul_init() may fail so correctly check for errors. Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space") Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/controller/pci-aardvark.c | 11 +++ 1 fil

[PATCH 0/5] PCIe aardvark controller improvements

2020-07-15 Thread Marek Behún
Hi, we have some more improvements for PCIe aardvark controller (Armada 3720 SOC - EspressoBIN and Turris MOX). The main improvement is that with these patches the driver can be compiled as a module, and can be reloaded at runtime. This series applies on top of Linus' master branch. Marek & Pal

Re: [PATCH 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'

2020-07-15 Thread Mark Brown
On Wed, Jul 15, 2020 at 10:44:47AM +0100, Lee Jones wrote: > /* > - * This dapm route map exits for DPCM link only. > + * This dapm route map exists for DPCM link only. > * The other routes shall go through Device Tree. This doesn't apply against current code, please check and resend. signat

[PATCH] Modified Makefile to print -eudyptula in the version string

2020-07-15 Thread Mritunjay Sharma
Signed-off-by: Mritunjay Sharma --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 0b5f8538bde5..d7897ce5ab23 100644 --- a/Makefile +++ b/Makefile @@ -2,7 +2,7 @@ VERSION = 5 PATCHLEVEL = 8 SUBLEVEL = 0 -EXTRAVERSION = -rc5 +EXTRAVERSION

Re: [PATCH] x86/bugs/multihit: Fix mitigation reporting when KVM is not in use

2020-07-15 Thread Dave Hansen
On 7/14/20 5:51 PM, Sean Christopherson wrote: > To do the above table, KVM will also need to update > itlb_multihit_kvm_mitigation > when it is unloaded, which seems rather silly. That's partly why I suggested > keying off CR4.VMXE as it doesn't require poking directly into KVM. E.g. the > enti

[PATCH v2] staging: rtl8188eu: core: fix coding style issues

2020-07-15 Thread Arpitha Raghunandan
Fixing WARNING: Prefer using '"%s...", __func__' to using 'function_name' in a string in rtw_ioctl_set.c Signed-off-by: Arpitha Raghunandan <98.a...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers

Re: [PATCH] vsock/virtio: annotate 'the_virtio_vsock' RCU pointer

2020-07-15 Thread Stefano Garzarella
On Mon, Jul 13, 2020 at 06:54:43AM -0400, Michael S. Tsirkin wrote: > On Fri, Jul 10, 2020 at 02:12:43PM +0200, Stefano Garzarella wrote: > > Commit 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free > > on the_virtio_vsock") starts to use RCU to protect 'the_virtio_vsock' > > pointer, bu

[PATCH v8 03/12] dt-bindings: PCI: Add bindings for more Brcmstb chips

2020-07-15 Thread Jim Quinlan
From: Jim Quinlan - Add compatible strings for three more Broadcom STB chips: 7278, 7216, 7211 (STB version of RPi4). - Add new property 'brcm,scb-sizes'. - Add new property 'resets'. - Add new property 'reset-names' for 7216 only. - Allow 'ranges' and 'dma-ranges' to have more than one item an

[PATCH v8 04/12] PCI: brcmstb: Add bcm7278 register info

2020-07-15 Thread Jim Quinlan
From: Jim Quinlan Add in compatibility strings and code for three Broadcom STB chips. Some of the register locations, shifts, and masks are different for certain chips, requiring the use of different constants based on of_id. We would like to add the following at this time to the match list but

[PATCH v8 11/12] PCI: brcmstb: Set bus max burst size by chip type

2020-07-15 Thread Jim Quinlan
From: Jim Quinlan The proper value of the parameter SCB_MAX_BURST_SIZE varies per chip. The 2711 family requires 128B whereas other devices can employ 512. The assignment is complicated by the fact that the values for this two-bit field have different meanings; Value Type_GenericType_7

[PATCH v8 10/12] PCI: brcmstb: Accommodate MSI for older chips

2020-07-15 Thread Jim Quinlan
From: Jim Quinlan Older BrcmSTB chips do not have a separate register for MSI interrupts; the MSIs are in a register that also contains unrelated interrupts. In addition, the interrupts lie in bits [31..24] for these legacy chips. This commit provides common code for both legacy and non-legacy

Re: strace of io_uring events?

2020-07-15 Thread Andy Lutomirski
> On Jul 15, 2020, at 4:12 AM, Miklos Szeredi wrote: > > Hi, > > This thread is to discuss the possibility of stracing requests > submitted through io_uring. I'm not directly involved in io_uring > development, so I'm posting this out of interest in using strace on > processes utilizing i

[PATCH v8 05/12] PCI: brcmstb: Add suspend and resume pm_ops

2020-07-15 Thread Jim Quinlan
From: Jim Quinlan Broadcom Set-top (BrcmSTB) boards typically support S2, S3, and S5 suspend and resume. Now the PCIe driver may do so as well. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli --- drivers/pci/controller/pcie-brcmstb.c | 47 +++ 1 file changed, 47

[PATCH v8 01/12] PCI: brcmstb: PCIE_BRCMSTB depends on ARCH_BRCMSTB

2020-07-15 Thread Jim Quinlan
From: Jim Quinlan Have PCIE_BRCMSTB depend on ARCH_BRCMSTB. Also set the default value to ARCH_BRCMSTB. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli Reviewed-by: Rob Herring --- drivers/pci/controller/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dri

[PATCH v8 06/12] PCI: brcmstb: Add bcm7278 PERST# support

2020-07-15 Thread Jim Quinlan
From: Jim Quinlan The PERST# bit was moved to a different register in 7278-type STB chips. In addition, the polarity of the bit was also changed; for other chips writing a 1 specified assert; for 7278-type chips, writing a 0 specifies assert. Of course, PERST# is a PCIe asserted-low signal. Sig

[PATCH v8 00/12] PCI: brcmstb: enable PCIe for STB chips

2020-07-15 Thread Jim Quinlan
Patchset Summary: Enhance a PCIe host controller driver. Because of its unusual design we are foced to change dev->dma_pfn_offset into a more general role allowing multiple offsets. See the 'v1' notes below for more info. v8: Commit: "device core: Introduce DMA range map, supplanting ...

[PATCH v8 07/12] PCI: brcmstb: Add control of rescal reset

2020-07-15 Thread Jim Quinlan
From: Jim Quinlan Some STB chips have a special purpose reset controller named RESCAL (reset calibration). The PCIe HW can now control RESCAL to start and stop its operation. On probe(), the RESCAL is deasserted and the driver goes through the sequence of setting registers and reading status in

[PATCH v8 02/12] ata: ahci_brcm: Fix use of BCM7216 reset controller

2020-07-15 Thread Jim Quinlan
From: Jim Quinlan A reset controller "rescal" is shared between the AHCI driver and the PCIe driver for the BrcmSTB 7216 chip. Use devm_reset_control_get_optional_shared() to handle this sharing. Signed-off-by: Jim Quinlan Fixes: 272ecd60a636 ("ata: ahci_brcm: BCM7216 reset is self de-asserti

[PATCH v8 09/12] PCI: brcmstb: Set additional internal memory DMA viewport sizes

2020-07-15 Thread Jim Quinlan
The Raspberry Pi (RPI) is currently the only chip using this driver (pcie-brcmstb.c). There, only one memory controller is used, without an extension region, and the SCB0 viewport size is set to the size of the first and only dma-range region. Other BrcmSTB SOCs have more complicated memory confi

[PATCH v8 12/12] PCI: brcmstb: Add bcm7211, bcm7216, bcm7445, bcm7278 to match list

2020-07-15 Thread Jim Quinlan
Now that the support is in place with previous commits, we add several chips that use the BrcmSTB driver. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli --- drivers/pci/controller/pcie-brcmstb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/pcie-brcmstb.c

Re: ioremap and dma cleanups and fixes for superh (2nd resend)

2020-07-15 Thread John Paul Adrian Glaubitz
Hi Geert! On 7/15/20 10:27 AM, John Paul Adrian Glaubitz wrote: >> Lemme gues: does commit 002ae7057069538a ("mm, dump_page(): do not crash >> with invalid mapping pointer") in v5.8-rc1 help? > > Hmm, it seems I already have that patch (I'm using Linus' main tree): > > commit 002ae7057069538aa3a

Re: [RFC PATCH 2/4] rseq: Allow extending struct rseq

2020-07-15 Thread Mathieu Desnoyers
- On Jul 15, 2020, at 2:31 AM, Florian Weimer f...@deneb.enyo.de wrote: > * Chris Kennelly: > >> When glibc provides registration, is the anticipated use case that a >> library would unregister and reregister each thread to "upgrade" it to >> the most modern version of interface it knows abou

RE: [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86

2020-07-15 Thread David Laight
From: Oliver O'Halloran > Sent: 15 July 2020 05:19 > > On Wed, Jul 15, 2020 at 8:03 AM Arnd Bergmann wrote: ... > > - config space accesses are very rare compared to memory > > space access and on the hardware side the error handling > > would be similar, but readl/writel don't return errors,

Re: [PATCH] hwmon: corsair-cpro: Change to hid driver

2020-07-15 Thread Guenter Roeck
On Tue, Jul 14, 2020 at 12:52:30PM +0200, Marius Zachmann wrote: > I found a project which uses hidraw to communicate with the device. > Because I do not want to break any existing userspace code, I > changed this to a hid driver, so hidraw can still be used. > Do I need to include the hid maintain

Re: [TEGRA194_CPUFREQ PATCH v6 3/3] cpufreq: Add Tegra194 cpufreq driver

2020-07-15 Thread Jon Hunter
On 15/07/2020 14:31, Sumit Gupta wrote: > Add support for CPU frequency scaling on Tegra194. The frequency > of each core can be adjusted by writing a clock divisor value to > a MSR on the core. The range of valid divisors is queried from > the BPMP. > > Signed-off-by: Mikko Perttunen > Signed-

Re: [PATCH] hwmon: corsair-cpro: Change to hid driver

2020-07-15 Thread Guenter Roeck
On Wed, Jul 15, 2020 at 08:59:52AM +0200, Marius Zachmann wrote: > On 15.07.20 at 04:36:22 CEST, Guenter Roeck wrote > > On Tue, Jul 14, 2020 at 12:52:30PM +0200, Marius Zachmann wrote: > > > I found a project which uses hidraw to communicate with the device. > > > Because I do not want to break an

Re: [PATCH net-next] cipso: Remove unused inline functions

2020-07-15 Thread David Miller
From: YueHaibing Date: Wed, 15 Jul 2020 10:18:46 +0800 > They are not used any more since commit b1edeb102397 ("netlabel: Replace > protocol/NetLabel linking with refrerence counts") > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] mptcp: Remove unused inline function mptcp_rcv_synsent()

2020-07-15 Thread David Miller
From: YueHaibing Date: Wed, 15 Jul 2020 10:36:13 +0800 > commit 263e1201a2c3 ("mptcp: consolidate synack processing.") > left behind this, remove it. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] netpoll: Remove unused inline function netpoll_netdev_init()

2020-07-15 Thread David Miller
From: YueHaibing Date: Wed, 15 Jul 2020 10:41:23 +0800 > commit d565b0a1a9b6 ("net: Add Generic Receive Offload infrastructure") > left behind this, remove it. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] net: flow: Remove unused inline function

2020-07-15 Thread David Miller
From: YueHaibing Date: Wed, 15 Jul 2020 10:31:19 +0800 > It is not used since commit 09c7570480f7 ("xfrm: remove flow cache") > > Signed-off-by: YueHaibing Applied.

Re: [PATCH 4.19 15/58] drm: panel-orientation-quirks: Use generic orientation-data for Acer S1003

2020-07-15 Thread Pavel Machek
Hi! > The Acer S1003 has proper DMI strings for sys-vendor and product-name, > so we do not need to match by BIOS-date. > > This means that the Acer S1003 can use the generic lcd800x1280_rightside_up > drm_dmi_panel_orientation_data struct which is also used by other quirks. This is just a clean

Re: [PATCH v3 0/4] Dedicated CLINT timer driver

2020-07-15 Thread Emil Renner Berthing
On Wed, 15 Jul 2020 at 09:15, Anup Patel wrote: > The current RISC-V timer driver is convoluted and implements two > distinct timers: > 1. S-mode timer: This is for Linux RISC-V S-mode with MMU. The > clocksource is implemented using TIME CSR and clockevent device > is implemented using S

[Regression] "SUNRPC: Add "@len" parameter to gss_unwrap()" breaks NFS Kerberos on upstream stable 5.4.y

2020-07-15 Thread Kai-Heng Feng
Hi, Multiple users reported NFS causes NULL pointer dereference [1] on Ubuntu, due to commit "SUNRPC: Add "@len" parameter to gss_unwrap()" and commit "SUNRPC: Fix GSS privacy computation of auth->au_ralign". The same issue happens on upstream stable 5.4.y branch. The mainline kernel doesn't ha

Re: [RFC PATCH 2/4] rseq: Allow extending struct rseq

2020-07-15 Thread Mathieu Desnoyers
- On Jul 14, 2020, at 10:34 PM, Chris Kennelly ckenne...@google.com wrote: > On Tue, Jul 14, 2020 at 2:33 PM Peter Oskolkov wrote: >> >> On Tue, Jul 14, 2020 at 10:43 AM Mathieu Desnoyers >> wrote: >> > >> > - On Jul 14, 2020, at 1:24 PM, Peter Oskolkov p...@posk.io wrote: >> > >> > > At

[PATCH v5 0/6] capabilities: Introduce CAP_CHECKPOINT_RESTORE

2020-07-15 Thread Adrian Reber
This is v5 of the 'Introduce CAP_CHECKPOINT_RESTORE' patchset. The changes to v4 are: * split into more patches to have the introduction of CAP_CHECKPOINT_RESTORE and the actual usage in different patches * reduce the /proc/self/exe patch to only be about CAP_CHECKPOINT_RESTORE Adrian

[PATCH] trace: fix commets of include guards

2020-07-15 Thread Philipp Rosenberger
Some header files where derived from other headers, but the comments of the include guards where not changed. This patch fixes those comments at the end of the header files. Signed-off-by: Philipp Rosenberger --- include/trace/events/initcall.h | 2 +- include/trace/events/irq_matrix.h | 2 +-

[PATCH v5 2/6] pid: use checkpoint_restore_ns_capable() for set_tid

2020-07-15 Thread Adrian Reber
Use the newly introduced capability CAP_CHECKPOINT_RESTORE to allow using clone3() with set_tid set. Signed-off-by: Adrian Reber Signed-off-by: Nicolas Viennot --- kernel/pid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/pid.c b/kernel/pid.c index de9d29c41d77..a9

[PATCH v5 1/6] capabilities: Introduce CAP_CHECKPOINT_RESTORE

2020-07-15 Thread Adrian Reber
This patch introduces CAP_CHECKPOINT_RESTORE, a new capability facilitating checkpoint/restore for non-root users. Over the last years, The CRIU (Checkpoint/Restore In Userspace) team has been asked numerous times if it is possible to checkpoint/restore a process as non-root. The answer usually wa

[PATCH v5 3/6] pid_namespace: use checkpoint_restore_ns_capable() for ns_last_pid

2020-07-15 Thread Adrian Reber
Use the newly introduced capability CAP_CHECKPOINT_RESTORE to allow writing to ns_last_pid. Signed-off-by: Adrian Reber Signed-off-by: Nicolas Viennot --- kernel/pid_namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c i

[PATCH v5 5/6] prctl: Allow checkpoint/restore capable processes to change exe link

2020-07-15 Thread Adrian Reber
From: Nicolas Viennot Allow CAP_CHECKPOINT_RESTORE capable users to change /proc/self/exe. This commit also changes the permission error code from -EINVAL to -EPERM for consistency with the rest of the prctl() syscall when checking capabilities. Signed-off-by: Nicolas Viennot Signed-off-by: Ad

[PATCH v5 6/6] selftests: add clone3() CAP_CHECKPOINT_RESTORE test

2020-07-15 Thread Adrian Reber
This adds a test that changes its UID, uses capabilities to get CAP_CHECKPOINT_RESTORE and uses clone3() with set_tid to create a process with a given PID as non-root. Signed-off-by: Adrian Reber Acked-by: Serge Hallyn --- tools/testing/selftests/clone3/Makefile | 4 +- .../clone3/clone

[PATCH v5 4/6] proc: allow access in init userns for map_files with CAP_CHECKPOINT_RESTORE

2020-07-15 Thread Adrian Reber
Opening files in /proc/pid/map_files when the current user is CAP_CHECKPOINT_RESTORE capable in the root namespace is useful for checkpointing and restoring to recover files that are unreachable via the file system such as deleted files, or memfd files. Signed-off-by: Adrian Reber Signed-off-by:

Re: [RFC PATCH 2/4] rseq: Allow extending struct rseq

2020-07-15 Thread Mathieu Desnoyers
- On Jul 15, 2020, at 9:42 AM, Florian Weimer fwei...@redhat.com wrote: > * Mathieu Desnoyers: > [...] >> How would this allow early-rseq-adopter libraries to interact with >> glibc ? > > Under all extension proposals I've seen so far, early adopters are > essentially incompatible with glibc

RE: [PATCH 7/7] exec: Implement kernel_execve

2020-07-15 Thread David Laight
From: Christoph Hellwig > Sent: 15 July 2020 07:43 > Subject: Re: [PATCH 7/7] exec: Implement kernel_execve > > On Tue, Jul 14, 2020 at 02:49:23PM -0700, Kees Cook wrote: > > On Tue, Jul 14, 2020 at 08:31:40AM -0500, Eric W. Biederman wrote: > > > +static int count_strings_kernel(const char *const

Re: [PATCH 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'

2020-07-15 Thread Lee Jones
On Wed, 15 Jul 2020, Mark Brown wrote: > On Wed, Jul 15, 2020 at 10:44:47AM +0100, Lee Jones wrote: > > > /* > > - * This dapm route map exits for DPCM link only. > > + * This dapm route map exists for DPCM link only. > > * The other routes shall go through Device Tree. > > This doesn't apply

Re: [RESEND][PATCH] hwmon: scmi: fix potential buffer overflow in scmi_hwmon_probe()

2020-07-15 Thread Guenter Roeck
On 7/15/20 6:00 AM, Sudeep Holla wrote: > On Wed, Jul 15, 2020 at 01:13:38PM +0100, Cristian Marussi wrote: >> SMATCH detected a potential buffer overflow in the manipulation of >> hwmon_attributes array inside the scmi_hwmon_probe function: >> >> drivers/hwmon/scmi-hwmon.c:226 >> scmi_hwmon_probe

Re: [PATCH 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'

2020-07-15 Thread Lee Jones
On Wed, 15 Jul 2020, Lee Jones wrote: > On Wed, 15 Jul 2020, Mark Brown wrote: > > > On Wed, Jul 15, 2020 at 10:44:47AM +0100, Lee Jones wrote: > > > > > /* > > > - * This dapm route map exits for DPCM link only. > > > + * This dapm route map exists for DPCM link only. > > > * The other route

Re: [RFC PATCH 2/4] rseq: Allow extending struct rseq

2020-07-15 Thread Florian Weimer
* Mathieu Desnoyers: > - On Jul 15, 2020, at 9:42 AM, Florian Weimer fwei...@redhat.com wrote: >> * Mathieu Desnoyers: >> > [...] >>> How would this allow early-rseq-adopter libraries to interact with >>> glibc ? >> >> Under all extension proposals I've seen so far, early adopters are >> ess

Re: [PATCH v2 1/2] spi: omap-uwire: Use clk_prepare_enable and clk_disable_unprepare

2020-07-15 Thread Mark Brown
On Wed, 15 Jul 2020 13:26:46 +0800, Qing Zhang wrote: > Convert clk_enable() to clk_prepare_enable() and clk_disable() to > clk_disable_unprepare() respectively in the spi-omap-uwire.c. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: oma

Re: [PATCH v5 0/4] Qualcomm labibb regulator driver

2020-07-15 Thread Mark Brown
On Mon, 22 Jun 2020 18:11:06 +0530, Sumit Semwal wrote: > This series adds a driver for LAB/IBB regulators found on some Qualcomm SoCs. > These regulators provide positive and/or negative boost power supplies > for LCD/LED display panels connected to the SoC. > > This series adds the support for p

Re: [PATCH 7/7] exec: Implement kernel_execve

2020-07-15 Thread Kees Cook
On Wed, Jul 15, 2020 at 07:42:48AM +0100, Christoph Hellwig wrote: > On Tue, Jul 14, 2020 at 02:49:23PM -0700, Kees Cook wrote: > > On Tue, Jul 14, 2020 at 08:31:40AM -0500, Eric W. Biederman wrote: > > > +static int count_strings_kernel(const char *const *argv) > > > +{ > > > + int i; > > > + > >

[PATCH v2 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'

2020-07-15 Thread Lee Jones
Cc: Timur Tabi Cc: Nicolin Chen Cc: Xiubo Li Cc: Fabio Estevam Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Lee Jones --- sound/soc/fsl/fsl-asoc-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index f

[PATCH RESEND 1/1] power_supply: wilco_ec: Add permanent long life charging mode

2020-07-15 Thread Crag Wang
This is a long life mode set in the factory for extended warranty battery, the power charging rate is customized so that battery at work last longer. Presently switching to a different battery charging mode is through EC PID 0x0710 to configure the battery firmware, this operation will be blocked

Re: [Regression] "SUNRPC: Add "@len" parameter to gss_unwrap()" breaks NFS Kerberos on upstream stable 5.4.y

2020-07-15 Thread Chuck Lever
> On Jul 15, 2020, at 10:48 AM, Kai-Heng Feng > wrote: > > Hi, > > Multiple users reported NFS causes NULL pointer dereference [1] on Ubuntu, > due to commit "SUNRPC: Add "@len" parameter to gss_unwrap()" and commit > "SUNRPC: Fix GSS privacy computation of auth->au_ralign". > > The same

[PATCH 01/14] spi: spi-loopback-test: Fix formatting issues in function header blocks

2020-07-15 Thread Lee Jones
Kerneldoc function parameter descriptions must be in '@.*: ' format. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'spi' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function

[PATCH 07/14] spi: spi-s3c64xx: Add missing entries for structs 's3c64xx_spi_dma_data' and 's3c64xx_spi_dma_data'

2020-07-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'quirks' not described in 's3c64xx_spi_port_config' drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'clk_ioclk' not described in 's3c64xx_spi_port_config'

[PATCH 04/14] spi: spi-ep93xx: Fix API slippage

2020-07-15 Thread Lee Jones
ep93xx_spi_read_write() changed is parameters, but the function documentation was left unchanged. Let's realign. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-ep93xx.c:227: warning: Function parameter or member 'master' not described in 'ep93xx_spi_read_write' drivers/spi/s

[PATCH 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc'

2020-07-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spifc.c:80: warning: Function parameter or member 'dev' not described in 'meson_spifc' Cc: Kevin Hilman Cc: Beniamino Galvani Cc: linux-amlo...@lists.infradead.org Signed-off-by: Lee Jones --- drivers/spi/spi-meson-spifc

[PATCH 12/14] spi: spi-at91-usart: Make use of the defined 'struct of_device_id'

2020-07-15 Thread Lee Jones
It's there so why not use it. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-at91-usart.c:684:34: warning: ‘at91_usart_spi_dt_ids’ defined but not used [-Wunused-const-variable=] 684 | static const struct of_device_id at91_usart_spi_dt_ids[] = { | ^ Cc:

[PATCH 08/14] spi: spi-pl022: Provide missing struct attribute/function param docs

2020-07-15 Thread Lee Jones
Also demote non-worthy kerneldoc headers to standard comment blocks. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-pl022.c:304: warning: cannot understand function prototype: 'enum ssp_writing ' drivers/spi/spi-pl022.c:330: warning: Function parameter or member 'loopback' n

[PATCH 00/14] Rid W=1 warnings in SPI

2020-07-15 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. After these patches are applied, the build system no longer complains about any W=0 nor W=1 level warnings in drivers/spi. Hurrah! Lee Jones (14):

[PATCH 14/14] spi: spi-amd: Do not define 'struct acpi_device_id' when

2020-07-15 Thread Lee Jones
Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-amd.c:297:36: warning: ‘spi_acpi_match’ defined but not used [-Wunused-const-variable=] 297 | static const struc

[PATCH 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo()

2020-07-15 Thread Lee Jones
Looks like it hasn't ever been checked. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spicc.c: In function ‘meson_spicc_reset_fifo’: drivers/spi/spi-meson-spicc.c:365:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] 365 | u32 data; | ^~~~ Cc:

[PATCH 09/14] spi: spi-zynq-qspi: Add description for 2 missing attributes/parameters

2020-07-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynq-qspi.c:143: warning: Function parameter or member 'dev' not described in 'zynq_qspi' drivers/spi/spi-zynq-qspi.c:334: warning: Function parameter or member 'spi' not described in 'zynq_qspi_config_op' drivers/spi/spi-zynq-q

Re: [PATCH v5 1/6] capabilities: Introduce CAP_CHECKPOINT_RESTORE

2020-07-15 Thread Christian Brauner
On Wed, Jul 15, 2020 at 04:49:49PM +0200, Adrian Reber wrote: > This patch introduces CAP_CHECKPOINT_RESTORE, a new capability facilitating > checkpoint/restore for non-root users. > > Over the last years, The CRIU (Checkpoint/Restore In Userspace) team has been > asked numerous times if it is pos

[PATCH 13/14] spi: spi-pxa2xx: Do not define 'struct acpi_device_id' when

2020-07-15 Thread Lee Jones
Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'pxa2xx_spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-pxa2xx.c:1435:36: warning: ‘pxa2xx_spi_acpi_match’ defined but not used [-Wunused-const-variable=] 1435 |

[PATCH 11/14] spi: spi-topcliff-pch: Add missing descriptions to 'struct pch_spi_data'

2020-07-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'io_base_addr' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_tx_buff' not described in 'pch_spi_data' dri

<    1   2   3   4   5   6   7   8   9   10   >