Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

Yonghong Song wrote: >On 8/14/20 2:16 AM, Miaohe Lin wrote: >> Convert the uses of fallthrough comments to fallthrough macro. >> >> Signed-off-by: Miaohe Lin > >This is not a bug fix but rather an enhancement so not sure whether this >should push to bpf tree or wait until bpf-next. > >It may be

Re: [PATCH v2 2/2] scsi: ufs: no need to send one Abort Task TM in case the task in DB was cleared

On Tue, 2020-08-11 at 16:18 +0200, Bean Huo wrote: > From: Bean Huo > > If the bit corresponds to a task in the Doorbell register has been > cleared, no need to poll the status of the task on the device side > and to send an Abort Task TM. Instead, let it directly goto cleanup. > > Meanwhile, to

Re: [GIT PULL] 9p update for 5.9-rc1

The pull request you sent on Sat, 15 Aug 2020 07:52:19 +0200: > https://github.com/martinetd/linux tags/9p-for-5.9-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/410520d07f5c66a6c1f3eb7ef2063d9bdd3d440b Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.

Re: Re: [GIT PULL] edac for v5.9 (part 2)

The pull request you sent on Sat, 15 Aug 2020 10:21:03 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git > tags/edac_updates_for_5.9_pt2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6ffdcde4ee9a20beda096dec664da89002610d7d Thank you! -- Deet-doot

Re: [GIT PULL] locking fixes

The pull request you sent on Sat, 15 Aug 2020 13:13:23 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > locking-urgent-2020-08-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/eb1319af4119c4936e02c879295e9fd4d50bbe3a Thank you! -- Deet-doot-dot

Re: [GIT PULL] SMB3 fixes

The pull request you sent on Sat, 15 Aug 2020 00:32:46 -0500: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.9-rc-smb3-fixes-part2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f6513bd39c15af8f8a63b1fbfcb1bf4717241655 Thank you! -- Deet-doot-dot, I am a bot. htt

Re: [GIT PULL] arch/sh updates for 5.9

The pull request you sent on Sat, 15 Aug 2020 15:33:04 -0400: > git://git.libc.org/linux-sh tags/sh-for-5.9 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5bbec3cfe376ed0014d9456a9be11d5ed75d587b Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/

Re: [GIT PULL] scheduler fixes

The pull request you sent on Sat, 15 Aug 2020 13:27:31 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-2020-08-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1195d58f003bf84d37fc5c30017600e09ba567b2 Thank you! -- Deet-doot-dot,

Re: [GIT PULL] x86 fixes

The pull request you sent on Sat, 15 Aug 2020 13:45:52 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > x86-urgent-2020-08-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/50f6c7dbd973092d8e5f3c89f29eb4bea19fdebd Thank you! -- Deet-doot-dot, I

Re: [GIT PULL] perf fixes

The pull request you sent on Sat, 15 Aug 2020 13:21:33 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > perf-urgent-2020-08-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7f5f5909bb0b26dcd309424da14bdf0c7e93 Thank you! -- Deet-doot-dot, I

Re: [GIT PULL] A RISC-V Fix for 5.9

The pull request you sent on Sat, 15 Aug 2020 15:39:41 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git > tags/riscv-for-linus-5.9-mw1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d84835b118ed8c14c21fa056ca54014b2eff068b Thank you! --

Re: [PATCH] net: correct zerocopy refcnt with newly allocated UDP or RAW uarg

Willem de Bruijn wrote: >On Fri, Aug 14, 2020 at 10:17 AM linmiaohe wrote: >> > >I don't think that can happen. > >The question is when this branch is false > >next = (u32)atomic_read(&sk->sk_zckey); >if ((u32)(uarg->id + uarg->len) == next) { > >I cannot come up w

Re: [PATCH] mm/gup_benchmark: use pin_user_pages for FOLL_LONGTERM flag

On 8/15/20 5:20 AM, Barry Song wrote: According to Documentation/core-api/pin_user_pages.rst, FOLL_PIN is a prerequisite to FOLL_LONGTERM. Another way of saying that is, FOLL_LONGTERM is a specific case, more restrictive case of FOLL_PIN. Almost all kernel modules are using pin_user_pages() with

Re: [PATCH] net: add missing skb_uarg refcount increment in pskb_carve_inside_header()

Willem de Bruijn wrote: >On Fri, Aug 14, 2020 at 9:20 AM linmiaohe wrote: >> >> Willem de Bruijn wrote: >> >On Thu, Aug 13, 2020 at 2:16 PM Miaohe Lin wrote: >> >> >> >> If the skb is zcopied, we should increase the skb_uarg refcount >> >> before we involve skb_release_data(). See pskb_expand_

Re: [PATCH 1/5] net: Fix potential deadloop in skb_copy_ubufs()

Eric Dumazet wrote: >On Fri, Aug 14, 2020 at 12:14 AM linmiaohe wrote: >> >> Willem de Bruijn wrote: >> >> Since we always call skb_orphan_frags in skb_clone, is it unnecessary to >> call skb_orphan_frags in pskb_expand_head when skb is cloned ? > >Please give us a real case. > >I fear that you

Re: [PATCH net] drivers/net/wan/lapbether: Added needed_tailroom

I took some time to look at the history of needed_tailroom. I found it was added in this commit: f5184d267c1a (net: Allow netdevices to specify needed head/tailroom) The author tried to make use of needed_tailroom at various places in the kernel by replacing the macro LL_RESERVED_SPACE with his ne

Re: [RFC 1/3] Initialize devlink health dump framework for the dlge driver

On 2020-08-15 00:05 +0800, Coiby Xu wrote: > Initialize devlink health dump framework for the dlge driver so the > coredump could be done via devlink. > > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/Makefile | 2 +- > drivers/staging/qlge/qlge.h| 9 +++ > drivers/stag

Re: [RFC 3/3] staging: qlge: clean up code that dump info to dmesg

On 2020-08-15 00:06 +0800, Coiby Xu wrote: > The related code are not necessary because, > - Device status and general registers can be obtained by ethtool. > - Coredump can be done via devlink health reporter. > - Structure related to the hardware (struct ql_adapter) can be obtained > by crash o

[PATCH] staging: greybus: Add identifier name to function definition argument

WARNING: function definition argument 'struct gbphy_device *' should also have an identifier name + int (*probe)(struct gbphy_device *, WARNING: function definition argument 'struct gbphy_device *' should also have an identifier name + void (*remove)(struct gbphy_device *); Signed-off

[PATCH 2/2] mm/pageblock: remove false sharing in pageblock_flags

Current pageblock_flags is only 4 bits, so it has to share a char size in cmpxchg when get set, the false sharing cause perf drop. If we incrase the bits up to 8, false sharing would gone in cmpxchg. and the only cost is half char per pageblock, which is half char per 128MB on x86, 4 chars in 1 GB

[PATCH 1/2] mm/pageblock: mitigation cmpxchg false sharing in pageblock flags

pageblock_flags is used as long, since every pageblock_flags is just 4 bits, 'long' size will include 8(32bit machine) or 16 pageblocks' flags, that flag setting has to sync in cmpxchg with 7 or 15 other pageblock flags. It would cause long waiting for sync. If we could change the pageblock_flags

Re: [PATCH] PCI: designware-ep: Fix the Header Type check

Hi Zhiqiang, I love your patch! Perhaps something to improve: [auto build test WARNING on pci/next] [also build test WARNING on linux/master linus/master v5.8 next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [PATCH 1/2] mm/pageblock: mitigation cmpxchg false sharing in pageblock flags

On Sun, Aug 16, 2020 at 11:47:56AM +0800, Alex Shi wrote: > +++ b/mm/page_alloc.c > @@ -467,6 +467,8 @@ static inline int pfn_to_bitidx(struct page *page, > unsigned long pfn) > return (pfn >> pageblock_order) * NR_PAGEBLOCK_BITS; > } > > +#define BITS_PER_CHAR8 include/linux/bit

[PATCH] mm/gup_benchmark: use pin_user_pages for FOLL_LONGTERM flag

According to Documentation/core-api/pin_user_pages.rst, FOLL_PIN is a prerequisite to FOLL_LONGTERM. Another way of saying that is, FOLL_LONGTERM is a specific case, more restrictive case of FOLL_PIN. Almost all kernel modules are using pin_user_pages() with FOLL_LONGTERM, mm/gup_benchmark.c seems

Re: [PATCH 2/2] arm64: Reserve memory for quick kexec

Hi Sang, Thank you for the patch! Yet something to improve: [auto build test ERROR on arm64/for-next/core] [also build test ERROR on linux/master linus/master v5.8 next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '

Re: [PATCH 2/2] mm/pageblock: remove false sharing in pageblock_flags

On Sun, Aug 16, 2020 at 11:47:57AM +0800, Alex Shi wrote: > Current pageblock_flags is only 4 bits, so it has to share a char size > in cmpxchg when get set, the false sharing cause perf drop. > > If we incrase the bits up to 8, false sharing would gone in cmpxchg. and > the only cost is half char

Re: [PATCH v2] lib/string.c: implement stpcpy

On Sun, Aug 16, 2020 at 2:19 AM 'Fangrui Song' via Clang Built Linux wrote: > > On 2020-08-15, 'Nick Desaulniers' via Clang Built Linux wrote: > >On Sat, Aug 15, 2020 at 2:31 PM Joe Perches wrote: > >> > >> On Sat, 2020-08-15 at 14:28 -0700, Nick Desaulniers wrote: > >> > On Sat, Aug 15, 2020 at

Re: [PATCH v2] bpf: Convert to use the preferred fallthrough macro

On 8/15/20 1:47 AM, Miaohe Lin wrote: Since commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use") introduce fallthrough pseudo keyword, then we should convert the uses of fallthrough comments to it. Signed-off-by: Miaohe Lin Acked-by: Yonghong

[PATCH] drm/bridge/tc358775: Fix for PTR_ERR

passing zero to 'PTR_ERR' Reported-by: kernel test robot Signed-off-by: Vinay Simha BN --- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 7da15cd..d951cdc 100644 -

Re: [PATCH 2/2] net: socket: implement SO_DESCRIPTION

Hi Pascal, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/perf/core] [also build test WARNING on linux/master v5.8] [cannot apply to security/next-testing linus/master next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. An

[PATCH] media: pvrusb2: fix parsing error

pvr2_std_str_to_id() returns 0 on failure and 1 on success, however the caller is checking failure case using <0 Signed-off-by: Tong Zhang --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/

Re: [PATCH 1/3] net: introduce helper sendpage_ok() in include/linux/net.h

Hi Coly, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on net/master net-next/master ipvs/master linus/master v5.8 next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

<    1   2   3   4