[PATCH v2 3/3] pinctrl: Ingenic: Add I2S pins support for Ingenic SoCs.

2020-08-31 Thread Zhou Yanjie
1.Add I2S pins support for the JZ4780 SoC. 2.Add I2S pins support for the X1000 SoC. 3.Add I2S pins support for the X1500 SoC. 4.Add I2S pins support for the X1830 SoC. Signed-off-by: 周琰杰 (Zhou Yanjie) --- Notes: v2: New patch. drivers/pinctrl/pinctrl-ingenic.c | 70

Re: [PATCH v6 52/76] x86/sev-es: Handle MMIO events

2020-08-31 Thread Borislav Petkov
On Mon, Aug 24, 2020 at 10:54:47AM +0200, Joerg Roedel wrote: > + if (bytes == 4) > + *reg_data = 0; /* Zero-extend for 32-bit operation */ Please put all side-comments over the respective line. There are a couple in this patch. Thx. -- Regards/Gruss,

Re: [PATCH v2] vfs: add RWF_NOAPPEND flag for pwritev2

2020-08-31 Thread Jann Horn
On Mon, Aug 31, 2020 at 5:32 PM Rich Felker wrote: > The pwrite function, originally defined by POSIX (thus the "p"), is > defined to ignore O_APPEND and write at the offset passed as its > argument. However, historically Linux honored O_APPEND if set and > ignored the offset. This cannot be

Re: [External] [BUGFIX PATCH] kprobes: Fix to check probe enabled before disarm_kprobe_ftrace()

2020-08-31 Thread Muchun Song
On Mon, Aug 31, 2020 at 11:12 PM Masami Hiramatsu wrote: > > Commit 0cb2f1372baa ("kprobes: Fix NULL pointer dereference at > kprobe_ftrace_handler") fixed one bug but not completely fixed yet. > If we run a kprobe_module.tc of ftracetest, kernel showed a warning > as below. > > > # ./ftracetest

Re: [PATCH v2] module: Harden STRICT_MODULE_RWX

2020-08-31 Thread Masahiro Yamada
On Mon, Aug 31, 2020 at 10:25 PM Ard Biesheuvel wrote: > > On Mon, 31 Aug 2020 at 13:43, Masahiro Yamada wrote: > > > > On Mon, Aug 31, 2020 at 6:47 PM Jessica Yu wrote: > > > > > > +++ Will Deacon [21/08/20 13:30 +0100]: > > > [snipped] > > > >> > > > So module_enforce_rwx_sections() is

Re: [PATCH v2] iomap: Fix WARN_ON_ONCE() from unprivileged users

2020-08-31 Thread Eric Sandeen
On 8/30/20 8:45 PM, Qian Cai wrote: > It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by > unprivileged users which would taint the kernel, or worse - panic if > panic_on_warn or panic_on_taint is set. Hence, just convert it to > pr_warn_ratelimited() to let users know their

Re: [PATCH v2] opp: Power on (virtual) power domains managed by the OPP core

2020-08-31 Thread Stephan Gerhold
Hi Viresh, On Mon, Aug 31, 2020 at 05:44:57PM +0530, Viresh Kumar wrote: > On 26-08-20, 11:33, Stephan Gerhold wrote: > > dev_pm_opp_attach_genpd() allows attaching an arbitrary number of > > power domains to an OPP table. In that case, the genpd core will > > create a virtual device for each of

Re: [rcuperf] 4e88ec4a9e: UBSAN:division-overflow_in_arch/x86/include/asm/div64.h

2020-08-31 Thread Paul E. McKenney
On Mon, Aug 31, 2020 at 08:01:22PM +0800, kernel test robot wrote: > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: 4e88ec4a9eb17527e640b063f79e5b875733eb53 ("rcuperf: Change rcuperf to > rcuscale") >

Re: [PATCH] infiniband: remove unnecessary fallthrough usage

2020-08-31 Thread Cengiz Can
On 2020-08-31 18:34, Jason Gunthorpe wrote: On Mon, Aug 31, 2020 at 06:30:34PM +0300, Cengiz Can wrote: Since /* fallthrough */ comments are deprecated[1], they are being replaced by new 'fallthrough' pseudo-keyword. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?\

Re: [PATCH v5 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-31 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年8月31日 週一 上午9:48寫道: > > On Mon, 2020-08-31 at 07:03 +0800, Chun-Kuang Hu wrote: > > Hi, Chunfeng & Kishon: > > > > How do you feel about this patch? > It's fine to me, > > Reviewed-by: Chunfeng Yun > Could you give an 'Acked-by' tag on this patch? So I could

Re: [PATCH v2] iomap: Fix WARN_ON_ONCE() from unprivileged users

2020-08-31 Thread Qian Cai
On Mon, Aug 31, 2020 at 10:48:59AM -0500, Eric Sandeen wrote: > On 8/30/20 8:45 PM, Qian Cai wrote: > > It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by > > unprivileged users which would taint the kernel, or worse - panic if > > panic_on_warn or panic_on_taint is set. Hence,

Re: [PATCH v5 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-31 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年8月31日 週一 上午9:50寫道: > > On Sun, 2020-08-23 at 09:48 +0800, Chun-Kuang Hu wrote: > > Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to > > drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' > > information. > > > >

Re: [PATCH v2] iomap: Fix WARN_ON_ONCE() from unprivileged users

2020-08-31 Thread Darrick J. Wong
On Mon, Aug 31, 2020 at 10:48:59AM -0500, Eric Sandeen wrote: > On 8/30/20 8:45 PM, Qian Cai wrote: > > It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by > > unprivileged users which would taint the kernel, or worse - panic if > > panic_on_warn or panic_on_taint is set. Hence,

Re: [PATCH v2 0/3] add fault injection to user memory access

2020-08-31 Thread Alexander Potapenko
> This series looks good to me. Great! Which tree do fault injection patches normally go to? > Reviewed-by: Akinobu Mita Reviewed-by: Alexander Potapenko

[PATCH] mm/mmap: Fix Add inline munmap_vma_range() for code readability

2020-08-31 Thread Liam R. Howlett
Add missing whitespace after the function, and fix comment arguments to match arguments. Signed-off-by: Liam R. Howlett --- mm/mmap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index b59b4e5889b5c..c64f4fc410312 100644 --- a/mm/mmap.c +++

[PATCH] staging: gdm724x: fixed two macros by adding brackets

2020-08-31 Thread antoniprzybylik
Added brackets to two macros. Signed-off-by: Antoni Przybylik --- drivers/staging/gdm724x/gdm_tty.c | 3 +-- drivers/staging/gdm724x/netlink_k.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c index

Re: [PATCH] drivers: optee: fix i2c build issue

2020-08-31 Thread Jorge Ramirez-Ortiz, Foundries
On 31/08/20, Randy Dunlap wrote: > On 8/31/20 8:23 AM, Jorge Ramirez-Ortiz wrote: > > When the optee driver is compiled into the kernel while the i2c core > > is configured as a module, the i2c symbols are not available. > > > > This commit addresses the situation by disabling the i2c support for

Re: [PATCH] Bluetooth: btusb: Fix memleak in btusb_mtk_submit_wmt_recv_urb

2020-08-31 Thread Marcel Holtmann
Hi Dinghao, > When kmalloc() on buf fails, urb should be freed just like > when kmalloc() on dr fails. > > Signed-off-by: Dinghao Liu > --- > drivers/bluetooth/btusb.c | 1 + > 1 file changed, 1 insertion(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH 16/28] wireless: marvell: mwifiex: init: Move 'tos_to_tid_inv' to where it's used

2020-08-31 Thread Kalle Valo
Lee Jones wrote: > 'tos_to_tid_inv' is only used in 2 of 17 files it's current being > included into. > > Fixes the following W=1 kernel build warning(s): > > In file included from drivers/net/wireless/marvell/mwifiex/main.c:23: > In file included from

Re: [PATCH] drivers: optee: fix i2c build issue

2020-08-31 Thread Randy Dunlap
On 8/31/20 8:23 AM, Jorge Ramirez-Ortiz wrote: > When the optee driver is compiled into the kernel while the i2c core > is configured as a module, the i2c symbols are not available. > > This commit addresses the situation by disabling the i2c support for > this use case while allowing it in all

Re: [PATCH] Bluetooth: Clear suspend tasks on unregister

2020-08-31 Thread Marcel Holtmann
Hi Abhishek, > While unregistering, make sure to clear the suspend tasks before > cancelling the work. If the unregister is called during resume from > suspend, this will unnecessarily add 2s to the resume time otherwise. > > Fixes: 4e8c36c3b0d73d (Bluetooth: Fix suspend notifier race) >

Re: [PATCH] Bluetooth: fix "list_add double add" in hci_conn_complete_evt

2020-08-31 Thread Marcel Holtmann
Hi Coiby, > When two HCI_EV_CONN_COMPLETE event packets with status=0 of the same > HCI connection are received, device_add would be called twice which > leads to kobject_add being called twice. Thus duplicate > (struct hci_conn *conn)->dev.kobj.entry would be inserted into > (struct hci_conn

Re: [PATCH AUTOSEL 5.8 25/42] ceph: fix inode number handling on arches with 32-bit ino_t

2020-08-31 Thread Ilya Dryomov
On Mon, Aug 31, 2020 at 5:30 PM Sasha Levin wrote: > > From: Jeff Layton > > [ Upstream commit ebce3eb2f7ef9f6ef01a60874ebd232450107c9a ] > > Tuan and Ulrich mentioned that they were hitting a problem on s390x, > which has a 32-bit ino_t value, even though it's a 64-bit arch (for > historical

Re: [PATCH v2] gpio: sprd: Clear interrupt when setting the type as edge

2020-08-31 Thread Bartosz Golaszewski
On Mon, Aug 31, 2020 at 11:10 AM Chunyan Zhang wrote: > > From: Taiping Lai > > The raw interrupt status of GPIO maybe set before the interrupt is enabled, > which would trigger the interrupt event once enabled it from user side. > This is the case for edge interrupts only. Adding a clear

[PATCHv2] drivers: optee: fix i2c build issue

2020-08-31 Thread Jorge Ramirez-Ortiz
When the optee driver is compiled into the kernel while the i2c core is configured as a module, the i2c symbols are not available. This commit addresses the situation by disabling the i2c support for this use case while allowing it in all other scenarios: i2c=y, optee=y i2c=m, optee=m i2c=y,

[RFC PATCH 0/1] USB EHCI: repeated resets on full and low speed devices

2020-08-31 Thread Khalid Aziz
I recently replaced the motherboard on my desktop with an MSI B450-A Pro Max motherboard. Since then my keybaords, mouse and tablet have become very unreliable. I see messages like this over and over in dmesg: ug 23 00:01:49 rhapsody kernel: [198769.314732] usb 1-2.4: reset full-speed USB device

[RFC PATCH 1/1] usb: ehci: Remove erroneous return of EPROTO upon detection of stall

2020-08-31 Thread Khalid Aziz
With the USB 3.0/3.1 controller on MSI B450-A Pro Max motherboard, full speed and low speed devices see constant resets making keyboards and mouse unreliable and unusable. These resets are caused by detection of stall in qtd_copy_status() and returning EPROTO which in turn results in TT buffers in

[PATCH 1/2] dt-bindings: mfd: google,cros-ec: Use unevaluatedProperties

2020-08-31 Thread Krzysztof Kozlowski
Additional properties or nodes actually might appear (e.g. wakeup) so use unevaluatedProperties to fix dtbs_check warnings like: arch/arm/boot/dts/exynos5250-snow.dt.yaml: embedded-controller@1e: 'keyboard-controller', 'wakeup-source' do not match any of the regexes: 'pinctrl-[0-9]+'

[PATCH 2/2] dt-bindings: mmc: mmc-pwreq-simple: Accept more than one reset GPIO

2020-08-31 Thread Krzysztof Kozlowski
There might be multiple reset GPIOs but dtschema has trouble parsing it if there are no maxItems: arch/arm/boot/dts/exynos5250-snow.dt.yaml: mmc3_pwrseq: reset-gpios: [[20, 2, 1], [20, 1, 1]] is too long From schema: Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml

Re: [PATCH v3] arm64: dts: qcom: sc7180-trogdor: add initial trogdor and lazor dt

2020-08-31 Thread Stephen Boyd
Quoting Rob Clark (2020-08-28 13:40:50) > From: Rob Clark > > This is essentialy a squash of a bunch of history of trogdor and lazor > dt updates from the chromium kernel tree. > > I don't claim any credit other than wanting to more easily boot upstream > kernel on these devices. > > I've

Re: [PATCH v2] iomap: Fix WARN_ON_ONCE() from unprivileged users

2020-08-31 Thread Eric Sandeen
On 8/31/20 10:56 AM, Darrick J. Wong wrote: > On Mon, Aug 31, 2020 at 10:48:59AM -0500, Eric Sandeen wrote: >> On 8/30/20 8:45 PM, Qian Cai wrote: >>> It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by >>> unprivileged users which would taint the kernel, or worse - panic if >>>

[PATCH] clk: rockchip: Fix overflow rate during fractional approximation

2020-08-31 Thread Jagan Teki
The current rockchip fractional approximation overflow the desired rate if parent rate is lower than the (rate * 20) for few clocks like dclk_vopb_frac. The overflow condition has observed in px30 for dclk_vopb_frac clock with an input rate of 71.1MHz and parent rate of 24MHz is, [2.543280]

RE: [PATCH] MAINTAINERS: IA64: mark Status as Odd Fixes only

2020-08-31 Thread Luck, Tony
> IA64 isn't really being maintained, so mark it as > Odd Fixes only. Acked-by: Tony Luck

Re: [PATCH v6 64/76] x86/sev-es: Handle #DB Events

2020-08-31 Thread Borislav Petkov
On Mon, Aug 24, 2020 at 10:54:59AM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > Handle #VC exceptions caused by #DB exceptions in the guest. Those > must be handled outside of instrumentation_begin()/end() so that the > handler will not be raised recursivly.

[PATCH v2 2/4] qla2xxx: Simplify return value logic in qla2x00_get_sp_from_handle()

2020-08-31 Thread Daniel Wagner
Refactor qla2x00_get_sp_from_handle() to avoid the unecessary goto if early returns are used. With this we can also avoid preinitilzing the sp pointer. Signed-off-by: Daniel Wagner --- drivers/scsi/qla2xxx/qla_isr.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v2 3/4] qla2xxx: Drop unused function argument from qla2x00_get_sp_from_handle()

2020-08-31 Thread Daniel Wagner
Commit 7c3df1320e5e ("[SCSI] qla2xxx: Code changes to support new dynamic logging infrastructure.") removed the use of the func argument. Signed-off-by: Daniel Wagner --- drivers/scsi/qla2xxx/qla_gbl.h | 3 +-- drivers/scsi/qla2xxx/qla_isr.c | 36

[PATCH v2 1/4] qla2xxx: Warn if done() or free() are called on an already freed srb

2020-08-31 Thread Daniel Wagner
Emit a warning when ->done or ->free are called on an already freed srb. There is a hidden use-after-free bug in the driver which corrupts the srb memory pool which originates from the cleanup callbacks. By explicitly resetting the callbacks to NULL, we workaround the memory corruption. An

[PATCH v2 0/4] qla2xxx: A couple crash fixes

2020-08-31 Thread Daniel Wagner
changes since v1: - added dummy warn function to patch#1 - added log entry to patch#4 as suggested by Martin Initial cover letter: The first crash we observed is due memory corruption in the srb memory pool. Unforuntatly, I couldn't find the source of the problem but the workaround by

[PATCH v2 4/4] qla2xxx: Handle incorrect entry_type entries

2020-08-31 Thread Daniel Wagner
It was observed on an ISP8324 16Gb HBA with fw=8.08.203 (d0d5) that pkt->entry_type was MBX_IOCB_TYPE/0x39 with an sp->type SRB_SCSI_CMD which is invalid and should not be possible. A careful code review of the crash dump didn't reveal any short comings. Reading the entry_type from the crash dump

Re: [PATCH v2 2/3] lib, uaccess: add failure injection to usercopy functions

2020-08-31 Thread peterz
On Fri, Aug 28, 2020 at 02:13:43PM +, albert.li...@gmail.com wrote: > @@ -82,6 +83,8 @@ __copy_from_user_inatomic(void *to, const void __user > *from, unsigned long n) > static __always_inline __must_check unsigned long > __copy_from_user(void *to, const void __user *from, unsigned long n)

Re: cpu-freq: running the perf increases the data rate?

2020-08-31 Thread Subhashini Rao Beerisetty
On Fri, Aug 28, 2020 at 6:04 PM Artem Bityutskiy wrote: > > On Thu, 2020-08-27 at 22:25 +0530, Subhashini Rao Beerisetty wrote: > > I have an application which finds the data rate over the PCIe > > interface. I’m getting the lesser data rate in one of my Linux X86 > > systems. > > Some more

Re: [PATCH] microblaze: fix kbuild redundant file warning

2020-08-31 Thread Masahiro Yamada
On Mon, Aug 31, 2020 at 11:01 PM Michal Simek wrote: > > Hi, > > On 28. 08. 20 20:35, Randy Dunlap wrote: > > From: Randy Dunlap > > > > Fix build warning since this file is already listed in > > include/asm-generic/Kbuild. > > > > ../scripts/Makefile.asm-generic:25: redundant generic-y found in

Re: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements

2020-08-31 Thread Jason Gunthorpe
On Tue, Aug 25, 2020 at 06:12:42PM +0100, Alex Dewar wrote: > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which > were later converted to fallthrough statements by commit df561f6688fe > ("treewide:

Re: [PATCH v3 3/3] media: i2c: imx274: Add IMX274 power on and off sequence

2020-08-31 Thread Sowjanya Komatineni
On 8/27/20 3:55 PM, Sowjanya Komatineni wrote: On 8/13/20 3:01 PM, Sakari Ailus wrote: Hi Sowjanya, On Fri, Jul 31, 2020 at 09:34:15AM -0700, Sowjanya Komatineni wrote: On 7/31/20 9:26 AM, Sakari Ailus wrote: Hi Sowjanya, Thanks for the patch. On Mon, Jul 20, 2020 at 10:01:34AM -0700,

Re: [PATCH 1/6] kprobes: tracing/kprobes: Fix to kill kprobes on initmem after boot

2020-08-31 Thread kernel test robot
suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Masami-Hiramatsu/tracing-boot-Add-new-options-for-tracing-specific-period/20200831-204738 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git

Re: [PATCH v2 0/3] add fault injection to user memory access

2020-08-31 Thread Akinobu Mita
Andrew, Could you take a look at this series, and consider taking in -mm tree? 2020年9月1日(火) 0:49 Alexander Potapenko : > > > This series looks good to me. > > Great! > > Which tree do fault injection patches normally go to? > > > Reviewed-by: Akinobu Mita > > Reviewed-by: Alexander Potapenko

Re: [PATCH] microblaze: fix kbuild redundant file warning

2020-08-31 Thread Randy Dunlap
On 8/31/20 9:22 AM, Masahiro Yamada wrote: > On Mon, Aug 31, 2020 at 11:01 PM Michal Simek wrote: >> >> Hi, >> >> On 28. 08. 20 20:35, Randy Dunlap wrote: >>> From: Randy Dunlap >>> >>> Fix build warning since this file is already listed in >>> include/asm-generic/Kbuild. >>> >>>

Re: [PATCH] fat: Avoid oops when bdi->io_pages==0

2020-08-31 Thread OGAWA Hirofumi
Jens Axboe writes: > On Sat, Aug 29, 2020 at 7:08 PM OGAWA Hirofumi > wrote: >> >> On one system, there was bdi->io_pages==0. This seems to be the bug of >> a driver somewhere, and should fix it though. Anyway, it is better to >> avoid the divide-by-zero Oops. >> >> So this check it. >> >>

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-31 Thread Lakshmi Ramasubramanian
On 8/31/20 7:47 AM, Stephen Smalley wrote: Could you please let me know when the current set of changes in SELinux next branch would be completed and be ready to take new changes? I mean, roughly - would it be a month from now or you expect that to take longer? I can't speak for Paul but

[PATCH v2] microblaze: fix kbuild redundant file warning

2020-08-31 Thread Randy Dunlap
From: Randy Dunlap Fix build warning since this file is already listed in include/asm-generic/Kbuild. ../scripts/Makefile.asm-generic:25: redundant generic-y found in arch/microblaze/include/asm/Kbuild: hw_irq.h Fixes: 630f289b7114 ("asm-generic: make more kernel-space headers mandatory")

Re: [PATCH] fat: Avoid oops when bdi->io_pages==0

2020-08-31 Thread Jens Axboe
On 8/31/20 10:37 AM, OGAWA Hirofumi wrote: > Jens Axboe writes: > >> On Sat, Aug 29, 2020 at 7:08 PM OGAWA Hirofumi >> wrote: >>> >>> On one system, there was bdi->io_pages==0. This seems to be the bug of >>> a driver somewhere, and should fix it though. Anyway, it is better to >>> avoid the

WARNING in nla_get_range_unsigned

2020-08-31 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:0f091e43 netlabel: remove unused param from audit_log_form.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=14865df290 kernel config: https://syzkaller.appspot.com/x/.config?x=61025c6fd3261bb1

INFO: task can't die in usb_start_wait_urb

2020-08-31 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b36c9697 Add linux-next specific files for 20200828 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=156a598e90 kernel config: https://syzkaller.appspot.com/x/.config?x=5e3cf99580b5542c dashboard

[PATCH 2/2] power: bq25980: Add support for the BQ259xx family

2020-08-31 Thread Dan Murphy
Add support for the BQ25980, BQ25975 and BQ25960 family of flash chargers. Signed-off-by: Dan Murphy --- drivers/power/supply/Kconfig |9 + drivers/power/supply/Makefile |1 + drivers/power/supply/bq25980_charger.c | 1316

[PATCH 1/2] dt-binding: bq25980: Add the bq25980 flash charger

2020-08-31 Thread Dan Murphy
Add yaml for the bq25980 flash charger. Signed-off-by: Dan Murphy --- .../bindings/power/supply/bq25980.yaml| 114 ++ 1 file changed, 114 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/bq25980.yaml diff --git

Re: [PATCH] Bluetooth: Clear suspend tasks on unregister

2020-08-31 Thread Abhishek Pandit-Subedi
v2 sent with fix. On Mon, Aug 31, 2020 at 8:49 AM Marcel Holtmann wrote: > > Hi Abhishek, > > > While unregistering, make sure to clear the suspend tasks before > > cancelling the work. If the unregister is called during resume from > > suspend, this will unnecessarily add 2s to the resume time

[PATCH v2] Bluetooth: Clear suspend tasks on unregister

2020-08-31 Thread Abhishek Pandit-Subedi
While unregistering, make sure to clear the suspend tasks before cancelling the work. If the unregister is called during resume from suspend, this will unnecessarily add 2s to the resume time otherwise. Fixes: 4e8c36c3b0d73d (Bluetooth: Fix suspend notifier race) Signed-off-by: Abhishek

[PATCH] mailbox: sti: fix struct description warnings

2020-08-31 Thread Alain Volmat
Fix formating of struct description to avoid warning highlighted by W=1 compilation. Fixes: 9ef4546cbd7e ("mailbox: Add support for ST's Mailbox IP") Signed-off-by: Alain Volmat --- drivers/mailbox/mailbox-sti.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v3 3/3] bio: convert get_user_pages_fast() --> pin_user_pages_fast()

2020-08-31 Thread Ira Weiny
On Mon, Aug 31, 2020 at 12:14:39AM -0700, John Hubbard wrote: > @@ -1113,8 +1113,8 @@ int bio_iov_iter_get_pages(struct bio *bio, struct > iov_iter *iter) > } else { > if (is_bvec) > ret = __bio_iov_bvec_add_pages(bio, iter); > -

Re: [PATCH] fat: Avoid oops when bdi->io_pages==0

2020-08-31 Thread Matthew Wilcox
On Mon, Aug 31, 2020 at 10:39:26AM -0600, Jens Axboe wrote: > We really should ensure that ->io_pages is always set, imho, instead of > having to work-around it in other spots. Interestingly, there are only three places in the entire kernel which _use_ bdi->io_pages. FAT, Verity and the

WARNING in chnl_net_uninit

2020-08-31 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4d41ead6 Merge tag 'block-5.9-2020-08-28' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=100cf1de90 kernel config: https://syzkaller.appspot.com/x/.config?x=5ebdb650dfa501c1

KASAN: use-after-free Read in bdev_del_partition

2020-08-31 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:dcc5c6f0 Merge tag 'x86-urgent-2020-08-30' of git://git.ke.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11e8ca8590 kernel config: https://syzkaller.appspot.com/x/.config?x=891ca5711a9f1650

[PATCH] char: virtio: Select VIRTIO from VIRTIO_CONSOLE.

2020-08-31 Thread Michal Suchanek
Make it possible to have virtio console built-in when other virtio drivers are modular. Signed-off-by: Michal Suchanek --- drivers/char/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig index 3a144c000a38..9bd9917ca9af

Re: [PATCH] fat: Avoid oops when bdi->io_pages==0

2020-08-31 Thread Jens Axboe
On 8/31/20 10:56 AM, Matthew Wilcox wrote: > On Mon, Aug 31, 2020 at 10:39:26AM -0600, Jens Axboe wrote: >> We really should ensure that ->io_pages is always set, imho, instead of >> having to work-around it in other spots. > > Interestingly, there are only three places in the entire kernel which

Re: [PATCH v3 3/6] IMA: update process_buffer_measurement to measure buffer hash

2020-08-31 Thread Mimi Zohar
On Thu, 2020-08-27 at 18:57 -0700, Tushar Sugandhi wrote: > process_buffer_measurement() currently only measures the input buffer. > When the buffer being measured is too large, it may result in bloated > IMA logs. The subject of this sentence refers to an individual record, while "bloated"

Re: [PATCH v2] vfs: add RWF_NOAPPEND flag for pwritev2

2020-08-31 Thread Jens Axboe
On 8/31/20 9:46 AM, Jann Horn wrote: > On Mon, Aug 31, 2020 at 5:32 PM Rich Felker wrote: >> The pwrite function, originally defined by POSIX (thus the "p"), is >> defined to ignore O_APPEND and write at the offset passed as its >> argument. However, historically Linux honored O_APPEND if set and

Re: [PATCH v6 1/6] i2c: Allow an ACPI driver to manage the device's power state during probe

2020-08-31 Thread Sakari Ailus
On Mon, Aug 31, 2020 at 12:00:23PM +0200, Wolfram Sang wrote: > > > + unsigned int flags; > > u32? > Yes. -- Sakari Ailus

Re: [PATCH v2 1/4] arm: dts: owl-s500: Fix incorrect PPI interrupt specifiers

2020-08-31 Thread Cristian Ciocaltea
On Mon, Aug 31, 2020 at 02:49:25PM +0530, Manivannan Sadhasivam wrote: > On 0828, Cristian Ciocaltea wrote: > > The PPI interrupts for cortex-a9 were incorrectly specified, fix them. > > > > Fixes: fdfe7f4f9d85 ("ARM: dts: Add Actions Semi S500 and LeMaker Guitar") > > Signed-off-by: Cristian

Re: [PATCH v2 4/4] arm: dts: owl-s500: Add RoseapplePi

2020-08-31 Thread Cristian Ciocaltea
On Mon, Aug 31, 2020 at 02:56:48PM +0530, Manivannan Sadhasivam wrote: > On 0828, Cristian Ciocaltea wrote: > > Add a Device Tree for the RoseapplePi SBC. > > > > Signed-off-by: Cristian Ciocaltea > > Reviewed-by: Peter Korsgaard > > Reviewed-by: Manivannan Sadhasivam Thanks, Cristi >

WARNING in timer_wait_running

2020-08-31 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:1127b219 Merge tag 'fallthrough-fixes-5.9-rc3' of git://gi.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1501768e90 kernel config: https://syzkaller.appspot.com/x/.config?x=978db74cb30aa994

Re: [PATCH v6 69/76] x86/realmode: Setup AP jump table

2020-08-31 Thread Borislav Petkov
On Mon, Aug 24, 2020 at 10:55:04AM +0200, Joerg Roedel wrote: > diff --git a/arch/x86/include/uapi/asm/svm.h b/arch/x86/include/uapi/asm/svm.h > index 8f36ae021a7f..a19ce9681ec2 100644 > --- a/arch/x86/include/uapi/asm/svm.h > +++ b/arch/x86/include/uapi/asm/svm.h > @@ -84,6 +84,9 @@ > /* SEV-ES

[PATCH 0/5] ARM: dts: at91: fix dtbs_check warnings

2020-08-31 Thread Alexandre Belloni
Hi, This series fixes some of the dtbs_check warnings. The remaining ones are mainly missing documentation or the documentation has not been converted to yaml. Alexandre Belloni (5): ARM: dts: at91: fix cpu node ARM: dts: at91: fix sram nodes ARM: dts: at91: move mmc pinctrl-names property

[PATCH 1/5] ARM: dts: at91: fix cpu node

2020-08-31 Thread Alexandre Belloni
The reg property is mandatory for cpu nodes, also fix the #address-cells of the cpus node that has to be at least 1. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91rm9200.dtsi | 5 +++-- arch/arm/boot/dts/at91sam9260.dtsi | 5 +++-- arch/arm/boot/dts/at91sam9261.dtsi | 5 +++--

[PATCH 3/5] ARM: dts: at91: move mmc pinctrl-names property to board dts

2020-08-31 Thread Alexandre Belloni
Having the pinctrl-names property in the dtsi leads to dtbs_check warnings when the board dts doesn't define pinctrl-0. Instead, move the property to the board dts actually using the mmc node. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/animeo_ip.dts | 1 +

Re: [PATCHv5 net-next] ipvs: remove dependency on ip6_tables

2020-08-31 Thread Julian Anastasov
Hello, On Sat, 29 Aug 2020, Yaroslav Bolyukin wrote: > This dependency was added because ipv6_find_hdr was in iptables specific > code but is no longer required > > Fixes: f8f626754ebe ("ipv6: Move ipv6_find_hdr() out of Netfilter code.") > Fixes: 63dca2c0b0e7 ("ipvs: Fix faulty IPv6

[PATCH 5/5] ARM: dts: at91: sama5d2: add missing flexcom spi node properties

2020-08-31 Thread Alexandre Belloni
SPI nodes require #address-cells and #size-cells add those properties in the flexcom spi nodes. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/sama5d2.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi

[PATCH 3/5] ARM: at91: dts: move mmc pinctrl-names property to board dts

2020-08-31 Thread Alexandre Belloni
Having the pinctrl-names property in the dtsi leads to dtbs_check warnings when the board dts doesn't define pinctrl-0. Instead, move the property to the board dts actually using the mmc node. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/animeo_ip.dts | 1 +

[PATCH 1/5] ARM: dts: at91: fix cpu node

2020-08-31 Thread Alexandre Belloni
The reg property is mandatory for cpu nodes, also fix the #address-cells of the cpus node that has to be at least 1. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91rm9200.dtsi | 5 +++-- arch/arm/boot/dts/at91sam9260.dtsi | 5 +++-- arch/arm/boot/dts/at91sam9261.dtsi | 5 +++--

[PATCH 4/5] ARM: dts: at91: add unit-address to memory node

2020-08-31 Thread Alexandre Belloni
The memory node requires a unit-address, add it. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/animeo_ip.dts | 2 +- arch/arm/boot/dts/at91-ariag25.dts| 2 +- arch/arm/boot/dts/at91-ariettag25.dts | 2 +- arch/arm/boot/dts/at91-cosino.dtsi|

[PATCH 2/5] ARM: dts: at91: fix sram nodes

2020-08-31 Thread Alexandre Belloni
The ranges, #address-cells and #size-cells properties are mandatory, add them to the sram nodes. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/at91rm9200.dtsi | 3 +++ arch/arm/boot/dts/at91sam9260.dtsi | 3 +++ arch/arm/boot/dts/at91sam9261.dtsi | 3 +++

Re: [PATCH] fs: Handle I_DONTCACHE in iput_final() instead of generic_drop_inode()

2020-08-31 Thread Ira Weiny
On Mon, Aug 31, 2020 at 06:13:13PM +0800, Hao Li wrote: > If generic_drop_inode() returns true, it means iput_final() can evict > this inode regardless of whether it is dirty or not. If we check > I_DONTCACHE in generic_drop_inode(), any inode with this bit set will be > evicted unconditionally.

Re: [PATCH] fat: Avoid oops when bdi->io_pages==0

2020-08-31 Thread OGAWA Hirofumi
Jens Axboe writes: > On 8/31/20 10:37 AM, OGAWA Hirofumi wrote: >> Jens Axboe writes: >> >>> I don't think we should work-around this here. What device is this on? >>> Something like the below may help. >> >> The reported bug is from nvme stack, and the below patch (I submitted >> same patch

possible deadlock in cleanup_net

2020-08-31 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b36c9697 Add linux-next specific files for 20200828 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=15185cc190 kernel config: https://syzkaller.appspot.com/x/.config?x=5e3cf99580b5542c dashboard

[PATCH v3 0/3] add fault injection to user memory access

2020-08-31 Thread albert . linde
From: Albert van der Linde The goal of this series is to improve testing of fault-tolerance in usages of user memory access functions, by adding support for fault injection. The first patch adds failure injection capability for usercopy functions. The second changes usercopy functions to use

[PATCH v3 3/3] x86: add failure injection to get/put/clear_user

2020-08-31 Thread albert . linde
From: Albert van der Linde To test fault-tolerance of user memory acceses in x86, add support for fault injection. Make both put_user() and get_user() fail with -EFAULT, and clear_user() fail by not clearing any bytes. Reviewed-by: Akinobu Mita Reviewed-by: Alexander Potapenko Signed-off-by:

[PATCH v3 2/3] lib, uaccess: add failure injection to usercopy functions

2020-08-31 Thread albert . linde
From: Albert van der Linde To test fault-tolerance of user memory access functions, introduce fault injection to usercopy functions. If a failure is expected return either -EFAULT or the total amount of bytes that were not copied. Reviewed-by: Akinobu Mita Reviewed-by: Alexander Potapenko

[PATCH v3 1/3] lib, include/linux: add usercopy failure capability

2020-08-31 Thread albert . linde
From: Albert van der Linde Add a failure injection capability to improve testing of fault-tolerance in usages of user memory access functions. Add CONFIG_FAULT_INJECTION_USERCOPY to enable faults in usercopy functions. The should_fail_usercopy function is to be called by these functions

[PATCH] scsi: ibmvfc: interface updates for future FPIN and MQ support

2020-08-31 Thread Tyrel Datwyler
VIOS partitions with SLI-4 enabled Emulex adapters will be capable of driving IO in parallel through mulitple work queues or channels, and with new hyperviosr firmware that supports multiple interrupt sources an ibmvfc NPIV single initiator can be modified to exploit end to end channelization in a

Re: [PATCH] fat: Avoid oops when bdi->io_pages==0

2020-08-31 Thread Jens Axboe
On 8/31/20 11:16 AM, OGAWA Hirofumi wrote: > Jens Axboe writes: > >> On 8/31/20 10:37 AM, OGAWA Hirofumi wrote: >>> Jens Axboe writes: >>> I don't think we should work-around this here. What device is this on? Something like the below may help. >>> >>> The reported bug is from nvme

Re: [PATCH] nouveau: fix the start/end range for migration

2020-08-31 Thread Ralph Campbell
On 8/31/20 4:51 AM, Jason Gunthorpe wrote: On Thu, Aug 27, 2020 at 02:37:44PM -0700, Ralph Campbell wrote: The user level OpenCL code shouldn't have to align start and end addresses to a page boundary. That is better handled in the nouveau driver. The npages field is also redundant since it

Re: [PATCH v3 3/3] misc: eeprom: at24: register nvmem only after eeprom is ready to use

2020-08-31 Thread Bartosz Golaszewski
On Mon, Aug 31, 2020 at 3:56 AM Vadym Kochan wrote: > > During nvmem_register() the nvmem core sends notifications when: > > - cell added > - nvmem added > > and during these notifications some callback func may access the nvmem > device, which will fail in case of at24 eeprom because

Re: [PATCH v3 3/3] misc: eeprom: at24: register nvmem only after eeprom is ready to use

2020-08-31 Thread Vadym Kochan
Hi Bartosz, On Mon, Aug 31, 2020 at 07:21:39PM +0200, Bartosz Golaszewski wrote: > On Mon, Aug 31, 2020 at 3:56 AM Vadym Kochan wrote: > > > > During nvmem_register() the nvmem core sends notifications when: > > > > - cell added > > - nvmem added > > > > and during these notifications

Re: [PATCH v6 70/76] x86/smpboot: Setup TSS for starting AP

2020-08-31 Thread Borislav Petkov
On Mon, Aug 24, 2020 at 10:55:05AM +0200, Joerg Roedel wrote: > @@ -1814,27 +1814,26 @@ static inline void ucode_cpu_init(int cpu) > load_ucode_ap(); > } > > -static inline void tss_setup_ist(struct tss_struct *tss) > +static inline void tss_setup_ist(struct tss_struct *tss, > +

[PATCH v3] iomap: Fix WARN_ON_ONCE() from unprivileged users

2020-08-31 Thread Qian Cai
It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by unprivileged users which would taint the kernel, or worse - panic if panic_on_warn or panic_on_taint is set. Hence, just convert it to pr_warn_ratelimited() to let users know their workloads are racing. Thank Dave Chinner for the

Re: [PATCH v3] iomap: Fix WARN_ON_ONCE() from unprivileged users

2020-08-31 Thread Christoph Hellwig
On Mon, Aug 31, 2020 at 01:25:34PM -0400, Qian Cai wrote: > It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by > unprivileged users which would taint the kernel, or worse - panic if > panic_on_warn or panic_on_taint is set. Hence, just convert it to > pr_warn_ratelimited() to let

Re: [PATCH v2 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-31 Thread Andreas Kemnade
Hi, On Thu, 27 Aug 2020 20:33:23 +0200 Jonathan Neuschäfer wrote: > On Wed, Aug 26, 2020 at 10:42:51PM +0200, Andreas Kemnade wrote: > > This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based > > on boards marked with "37NB-E60QF0+4A2". It is equipped with an i.MX6SL > >

Re: [PATCH v6 72/76] x86/head/64: Rename start_cpu0

2020-08-31 Thread Borislav Petkov
On Mon, Aug 24, 2020 at 10:55:07AM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > For SEV-ES this entry point will be used for restarting APs after they > have been offlined. Remove the '0' from the name to reflect that. Sure but only for SEV-ES guests and your change is unconditional. I

Re: [PATCH v6 48/76] x86/entry/64: Add entry code for #VC handler

2020-08-31 Thread Borislav Petkov
On Mon, Aug 24, 2020 at 10:54:43AM +0200, Joerg Roedel wrote: > @@ -674,6 +675,56 @@ asmlinkage __visible noinstr struct pt_regs > *sync_regs(struct pt_regs *eregs) > return regs; > } > > +#ifdef CONFIG_AMD_MEM_ENCRYPT > +asmlinkage __visible noinstr struct pt_regs

Re: [PATCH] x86/uaccess: Use pointer masking to limit uaccess speculation

2020-08-31 Thread Josh Poimboeuf
On Sat, Aug 29, 2020 at 07:31:20PM +, David Laight wrote: > > Rereading the patch it looks like a lot of bloat (as well as a > > lot of changes). > > Does the array_mask even work on 32bit archs where the kernel > > base address is 0xc000? Why wouldn't it on work on 32-bit? My patch does

Re: [PATCH] media: tc358743: initialize variable

2020-08-31 Thread Nick Desaulniers
On Sun, Aug 30, 2020 at 9:30 AM wrote: > > From: Tom Rix > > clang static analysis flags this error > > tc358743.c:1468:9: warning: Branch condition evaluates > to a garbage value > return handled ? IRQ_HANDLED : IRQ_NONE; >^~~ > handled should be initialized to

  1   2   3   4   5   6   7   8   9   10   >