Re: [PATCH v2 01/16] mm: Add AOP_UPDATED_PAGE return value

2020-10-15 Thread Christoph Hellwig
Don't we also need to handle the new return value in a few other places like cachefiles_read_reissue swap_readpage? Maybe those don't get called on the currently converted instances, but just leaving them without handling AOP_UPDATED_PAGE seems like a time bomb.

Re: [PATCH v2 02/16] mm: Inline wait_on_page_read into its one caller

2020-10-15 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v2 15/16] iomap: Inline iomap_iop_set_range_uptodate into its one caller

2020-10-15 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [mm/writeback] 8d92890bd6: will-it-scale.per_process_ops -15.3% regression

2020-10-15 Thread Jan Kara
On Thu 15-10-20 08:46:01, NeilBrown wrote: > On Wed, Oct 14 2020, Jan Kara wrote: > > > On Wed 14-10-20 16:47:06, kernel test robot wrote: > >> Greeting, > >> > >> FYI, we noticed a -15.3% regression of will-it-scale.per_process_ops due > >> to commit: > >> > >> commit: 8d92890bd6b8502d6aee4b374

[PATCH v2 2/3] dt-bindings: arm: fsl: add Van der Laan LANMCU board

2020-10-15 Thread Oleksij Rempel
Add Van der Laan LANMCU iMX6dl based board Signed-off-by: Oleksij Rempel --- Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 74aaf68b7d06..589

[PATCH v2 3/3] ARM: dts: add Van der Laan LANMCU board

2020-10-15 Thread Oleksij Rempel
Van der Laan LANMCU is a module for the food storage rooms to control proper gas composition. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6dl-lanmcu.dts | 469 +

[PATCH v2 1/3] dt-bindings: vendor-prefixes: Add an entry for Van der Laan b.v.

2020-10-15 Thread Oleksij Rempel
Add "vdl" entry for Van der Laan b.v.: https://www.teamvdl.nl/ Signed-off-by: Oleksij Rempel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/binding

[PATCH v2 0/3] mainline LANMCU board

2020-10-15 Thread Oleksij Rempel
changes v2: - add phy-handle - rename node to touchscreen@38 - reorder reg and status properties Oleksij Rempel (3): dt-bindings: vendor-prefixes: Add an entry for Van der Laan b.v. dt-bindings: arm: fsl: add Van der Laan LANMCU board ARM: dts: add Van der Laan LANMCU board .../devicetre

[PATCH] docs: driver-api: remove a duplicated index entry

2020-10-15 Thread Mauro Carvalho Chehab
The ipmb file was added twice at index.rst. That sounds to be because the same patch was applied twice, via different git trees: commit f6ae22d64433fd8e08654adad7966299da931bb9 Author: Mauro Carvalho Chehab Commit: Jonathan Corbet docs: ipmb: place it at driv

Re: [mm/writeback] 8d92890bd6: will-it-scale.per_process_ops -15.3% regression

2020-10-15 Thread Jan Kara
On Thu 15-10-20 11:08:43, Jan Kara wrote: > On Thu 15-10-20 08:46:01, NeilBrown wrote: > > On Wed, Oct 14 2020, Jan Kara wrote: > > > > > On Wed 14-10-20 16:47:06, kernel test robot wrote: > > >> Greeting, > > >> > > >> FYI, we noticed a -15.3% regression of will-it-scale.per_process_ops due > >

Re: [PATCH v7 2/2] soc: mediatek: add mt6779 devapc driver

2020-10-15 Thread Matthias Brugger
On 15/10/2020 04:13, Neal Liu wrote: On Thu, 2020-10-08 at 10:35 +0800, Neal Liu wrote: On Wed, 2020-10-07 at 12:44 +0200, Matthias Brugger wrote: On 27/08/2020 05:06, Neal Liu wrote: [...] +static int devapc_sync_vio_dbg(struct mtk_devapc_context *ctx) +{ + void __iomem *pd_vio_sh

Re: [PATCH 1/2] sched: Deny self-issued __set_cpus_allowed_ptr() when migrate_disable()

2020-10-15 Thread Valentin Schneider
On 13/10/20 15:21, Peter Zijlstra wrote: > On Tue, Oct 13, 2020 at 04:15:08PM +0200, Sebastian Andrzej Siewior wrote: >> On 2020-10-13 15:01:15 [+0100], Valentin Schneider wrote: >> > migrate_disable(); >> > set_cpus_allowed_ptr(current, {something excluding task_cpu(current)}); >> > affine

Re: [PATCH v3 3/8] of/address: Introduce of_dma_get_max_cpu_address()

2020-10-15 Thread Nicolas Saenz Julienne
On Thu, 2020-10-15 at 08:56 +0200, Ard Biesheuvel wrote: > On Thu, 15 Oct 2020 at 00:03, Rob Herring wrote: > > On Wed, Oct 14, 2020 at 2:12 PM Nicolas Saenz Julienne > > wrote: > > > Introduce of_dma_get_max_cpu_address(), which provides the highest CPU > > > physical address addressable by all

[v2] drm/msm: Fix race condition in msm driver with async layer updates

2020-10-15 Thread Krishna Manikandan
When there are back to back commits with async cursor update, there is a case where second commit can program the DPU hw blocks while first didn't complete flushing config to HW. Synchronize the compositions such that second commit waits until first commit flushes the composition. This change als

Re: [PATCH v2 3/3] arm64: dts: qcom: trogdor: Add brightness-levels

2020-10-15 Thread Daniel Thompson
On Wed, Oct 14, 2020 at 06:51:19AM -0700, Doug Anderson wrote: > Hi, > > On Wed, Oct 14, 2020 at 4:33 AM Daniel Thompson > wrote: > > > > On Tue, Oct 13, 2020 at 09:28:38AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Tue, Oct 13, 2020 at 1:01 AM Alexandru Stan > > > wrote: > > > > > >

Re: [v1] drm/msm: Fix race condition in msm driver with async layer updates

2020-10-15 Thread mkrishn
On 2020-10-14 20:55, Rob Clark wrote: On Wed, Oct 14, 2020 at 5:58 AM Krishna Manikandan wrote: When there are back to back commits with async cursor update, there is a case where second commit can program the DPU hw blocks while first didn't complete flushing config to HW. Synchronize the co

Re: [PATCH v3 3/8] of/address: Introduce of_dma_get_max_cpu_address()

2020-10-15 Thread Ard Biesheuvel
On Thu, 15 Oct 2020 at 11:16, Nicolas Saenz Julienne wrote: > > On Thu, 2020-10-15 at 08:56 +0200, Ard Biesheuvel wrote: > > On Thu, 15 Oct 2020 at 00:03, Rob Herring wrote: > > > On Wed, Oct 14, 2020 at 2:12 PM Nicolas Saenz Julienne > > > wrote: > > > > Introduce of_dma_get_max_cpu_address(),

Re: [RFC]: userspace memory reaping

2020-10-15 Thread Michal Hocko
On Wed 14-10-20 09:57:20, Suren Baghdasaryan wrote: > On Wed, Oct 14, 2020 at 5:09 AM Michal Hocko wrote: [...] > > > > The need is similar to why oom-reaper was introduced - when a process > > > > is being killed to free memory we want to make sure memory is freed > > > > even if the victim is in

Re: [PATCH 2/2] Revert "dccp: don't free ccid2_hc_tx_sock struct in dccp_disconnect()"

2020-10-15 Thread Kleber Souza
On 15.10.20 05:42, Jakub Kicinski wrote: > On Tue, 13 Oct 2020 19:18:49 +0200 Kleber Sacilotto de Souza wrote: >> From: Thadeu Lima de Souza Cascardo >> >> This reverts commit 2677d20677314101293e6da0094ede7b5526d2b1. >> >> This fixes an issue that after disconnect, dccps_hc_tx_ccid will still be

[PATCH] crypto: sm2 - remove unnecessary reset operations

2020-10-15 Thread Tianjia Zhang
This is an algorithm optimization. The reset operation when setting the public key is repeated and redundant, so remove it. At the same time, `sm2_ecc_os2ec()` is optimized to make the function more simpler and more in line with the Linux code style. Signed-off-by: Tianjia Zhang --- crypto/sm2.c

[PATCH] clk: imx8mq: Fix usdhc parents order

2020-10-15 Thread Abel Vesa
According to the latest RM (see Table 5-1. Clock Root Table), both usdhc root clocks have the parent order as follows: 000 - 25M_REF_CLK 001 - SYSTEM_PLL1_DIV2 010 - SYSTEM_PLL1_CLK 011 - SYSTEM_PLL2_DIV2 100 - SYSTEM_PLL3_CLK 101 - SYSTEM_PLL1_DIV3 110 - AUDIO_PLL2_CLK 111 - SYSTEM_PLL1_DIV8 So

Re: [PATCH v2 2/3] selftests/run_kselftest.sh: Make each test individually selectable

2020-10-15 Thread Naresh Kamboju
On Tue, 29 Sep 2020 at 01:56, Kees Cook wrote: > > Currently with run_kselftest.sh there is no way to choose which test > we could run. All the tests listed in kselftest-list.txt are all run > every time. This patch enhanced the run_kselftest.sh to make the test > collections (or tests) individual

Re: [PATCH 1/2] device-dax/kmem: Fix resource release

2020-10-15 Thread David Hildenbrand
On 15.10.20 02:42, Dan Williams wrote: > The conversion to request_mem_region() is broken because it assumes that > the range is marked busy prior to release. However, due to the way that > the kmem driver manipulates the IORESOURCE_BUSY flag (clears it to > let {add,remove}_memory() handle busy) i

Re: [PATCH v1 15/29] virito-mem: document Sub Block Mode (SBM)

2020-10-15 Thread David Hildenbrand
On 12.10.20 14:53, David Hildenbrand wrote: > Let's add some documentation for the current mode - Sub Block Mode (SBM) - > to prepare for a new mode - Big Block Mode (BBM). > > Follow-up patches will properly factor out the existing Sub Block Mode > (SBM) and implement Device Block Mode (DBM). s/

Re: [PATCH v2] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1

2020-10-15 Thread Maxime Ripard
On Tue, Oct 13, 2020 at 11:27:33PM +0200, Jernej Škrabec wrote: > Dne petek, 09. oktober 2020 ob 09:36:51 CEST je Maxime Ripard napisal(a): > > On Thu, Oct 08, 2020 at 10:00:06PM +0200, Clément Péron wrote: > > > Hi Maxime, > > > > > > Adding linux-sunxi and Jernej Skrabec to this discussion. > >

[tip: timers/urgent] selftests/timens: Add a test for futex()

2020-10-15 Thread tip-bot2 for Andrei Vagin
The following commit has been merged into the timers/urgent branch of tip: Commit-ID: 4cdf42596216e08051c0ccc4c896dcb8b2d22f10 Gitweb: https://git.kernel.org/tip/4cdf42596216e08051c0ccc4c896dcb8b2d22f10 Author:Andrei Vagin AuthorDate:Thu, 15 Oct 2020 00:29:09 -07:00 Commit

[tip: timers/urgent] futex: Adjust futex absolute timeouts with per-timens offset

2020-10-15 Thread tip-bot2 for Andrei Vagin
The following commit has been merged into the timers/urgent branch of tip: Commit-ID: 06764291690f8650a9f96dea42cc0dd4138d47d5 Gitweb: https://git.kernel.org/tip/06764291690f8650a9f96dea42cc0dd4138d47d5 Author:Andrei Vagin AuthorDate:Thu, 15 Oct 2020 00:29:08 -07:00 Commit

Re: [PATCH 01/11] firmware: arm_scmi: review protocol registration interface

2020-10-15 Thread Vincent Guittot
On Wed, 14 Oct 2020 at 17:06, Cristian Marussi wrote: > > Extend common protocol registration routines and provide some new generic > protocols' init/deinit helpers that tracks protocols' users and automatically > perform the proper initialization/de-initialization on demand. > > Convert all proto

[PATCH v2] mmc: sdhci: Use Auto CMD Auto Select only when v4_mode is true

2020-10-15 Thread Jisheng Zhang
sdhci-of-dwcmshc meets an eMMC read performance regression with below command after commit 427b6514d095 ("mmc: sdhci: Add Auto CMD Auto Select support"): dd if=/dev/mmcblk0 of=/dev/null bs=8192 count=10 Before the commit, the above command gives 120MB/s After the commit, the above command giv

Re: [PATCH 2/2] xen: Kconfig: nest Xen guest options

2020-10-15 Thread Jürgen Groß
On 14.10.20 19:53, Jason Andryuk wrote: Moving XEN_512GB allows it to nest under XEN_PV. That also allows XEN_PVH to nest under XEN as a sibling to XEN_PV and XEN_PVHVM giving: [*] Xen guest support [*] Xen PV guest support [*] Limit Xen pv-domain memory to 512GB [*] Xen PV Do

Re: [PATCH v2 16/16] iomap: Make readpage synchronous

2020-10-15 Thread Christoph Hellwig
> +static void iomap_read_page_end_io(struct bio_vec *bvec, > + struct completion *done, bool error) I really don't like the parameters here. Part of the problem is that ctx is only assigned to bi_private conditionally, which can easily be fixed. The other part is the strange bool er

Re: [PATCH v3 0/3] Actually fix freelist pointer vs redzoning

2020-10-15 Thread Vlastimil Babka
On 10/15/20 10:23 AM, Christopher Lameter wrote: On Wed, 14 Oct 2020, Kees Cook wrote: Note on patch 2: Christopher NAKed it, but I actually think this is a reasonable thing to add -- the "too small" check is only made when built with CONFIG_DEBUG_VM, so it *is* actually possible for someone to

Re: [tip: locking/core] lockdep: Fix lockdep recursion

2020-10-15 Thread Peter Zijlstra
On Wed, Oct 14, 2020 at 08:41:28PM -0700, Paul E. McKenney wrote: > So the (untested) patch below (on top of the other two) moves the delay > to rcu_gp_init(), in particular, to the first loop that traverses only > the leaf rcu_node structures handling CPU hotplug. > > Hopefully getting closer! S

Re: [tip: locking/core] lockdep: Fix lockdep recursion

2020-10-15 Thread Peter Zijlstra
On Thu, Oct 15, 2020 at 11:49:26AM +0200, Peter Zijlstra wrote: > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -1143,13 +1143,15 @@ bool rcu_lockdep_current_cpu_online(void > struct rcu_data *rdp; > struct rcu_node *rnp; > bool ret = false; > + unsigned long seq; >

Re: [PATCH v3 4/8] of: unittest: Add test for of_dma_get_max_cpu_address()

2020-10-15 Thread Nicolas Saenz Julienne
On Wed, 2020-10-14 at 17:04 -0500, Rob Herring wrote: > On Wed, Oct 14, 2020 at 2:12 PM Nicolas Saenz Julienne > wrote: > > Introduce a test for of_dma_get_max_cup_address(), it uses the same DT > > data as the rest of dma-ranges unit tests. > > > > Signed-off-by: Nicolas Saenz Julienne > > ---

Re: [tip: locking/core] lockdep: Fix lockdep recursion

2020-10-15 Thread Peter Zijlstra
On Thu, Oct 15, 2020 at 11:49:26AM +0200, Peter Zijlstra wrote: > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -1764,8 +1764,7 @@ static bool rcu_gp_init(void) > smp_mb(); // Pair with barriers used when updating ->ofl_seq to > odd values. > firstseq = READ_ON

DPTF_POWER and DPTF_PCH_FIVR

2020-10-15 Thread Borislav Petkov
Dudes, what are those new symbols in Kconfig and why do they wanna get enabled on my box when doing oldconfig? Depends on X86? Really, that widespread? The help text doesn't say why do I need this... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH 3/3] timekeeping: remove arch_gettimeoffset

2020-10-15 Thread Russell King - ARM Linux admin
On Thu, Oct 15, 2020 at 09:53:29AM +0200, Linus Walleij wrote: > On Thu, Oct 8, 2020 at 5:46 PM Arnd Bergmann wrote: > > > With Arm EBSA110 gone, nothing uses it any more, so the corresponding > > code and the Kconfig option can be removed. > > > > Signed-off-by: Arnd Bergmann > > Very nice cle

Re: fw_devlink on will break all snps,dw-apb-gpio users

2020-10-15 Thread Jisheng Zhang
On Thu, 15 Oct 2020 01:48:13 -0700 Saravana Kannan wrote: > On Thu, Oct 15, 2020 at 1:15 AM Jisheng Zhang > wrote: > > > > On Wed, 14 Oct 2020 22:04:24 -0700 Saravana Kannan wrote: > > > > > > > > > > > On Wed, Oct 14, 2020 at 9:02 PM Jisheng Zhang > > > wrote: > > > > > > > > On Wed, 14 Oc

Re: [PATCH v7 3/3] iommu/tegra-smmu: Add PCI support

2020-10-15 Thread Robin Murphy
On 2020-10-15 05:13, Nicolin Chen wrote: On Wed, Oct 14, 2020 at 06:42:36PM +0100, Robin Murphy wrote: On 2020-10-09 17:19, Nicolin Chen wrote: This patch simply adds support for PCI devices. Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko Signed-off-by: Nicolin Chen --- Changelog

Re: [PATCH 5/6] ARM: dts: mmp2-olpc-xo-1-75: explicitly add #address-cells=<0> for slave mode

2020-10-15 Thread Leizhen (ThunderTown)
Hi Lubomir: Can you review this patch? The results of all other patches are clear. On 2020/10/14 0:08, Zhen Lei wrote: > Delete the old property "#address-cells" and then explicitly add it with > zero value. The value of "#size-cells" is already zero, so keep it no > change. > > Signed-off-by:

Re: [PATCH v4.4/bluetooth 1/2] Bluetooth: Consolidate encryption handling in hci_encrypt_cfm

2020-10-15 Thread Greg KH
On Thu, Oct 15, 2020 at 09:43:32AM +0200, Hans-Christian Noren Egtvedt wrote: > From: Luiz Augusto von Dentz > > This makes hci_encrypt_cfm calls hci_connect_cfm in case the connection > state is BT_CONFIG so callers don't have to check the state. > > Signed-off-by: Luiz Augusto von Dentz > Sig

Re: WARNING: at drivers/opp/core.c:678 dev_pm_opp_set_rate+0x4cc/0x5d4 - on arm x15

2020-10-15 Thread Naresh Kamboju
On Mon, 31 Aug 2020 at 11:32, Viresh Kumar wrote: > > On 31-08-20, 11:30, Naresh Kamboju wrote: > > On Mon, 31 Aug 2020 at 10:11, Viresh Kumar wrote: > > > > > > On 28-08-20, 15:42, Naresh Kamboju wrote: > > > > Viresh, > > > > I have applied the v2 patch series on top of linux next-20200824. > >

Re: [PATCH v4.4/bluetooth 2/2] Bluetooth: Disconnect if E0 is used for Level 4

2020-10-15 Thread Greg KH
On Thu, Oct 15, 2020 at 09:43:33AM +0200, Hans-Christian Noren Egtvedt wrote: > From: Luiz Augusto von Dentz > > E0 is not allowed with Level 4: > > BLUETOOTH CORE SPECIFICATION Version 5.2 | Vol 3, Part C page 1319: > > '128-bit equivalent strength for link and encryption keys >required

Re: DPTF_POWER and DPTF_PCH_FIVR

2020-10-15 Thread Borislav Petkov
On Thu, Oct 15, 2020 at 11:53:11AM +0200, Borislav Petkov wrote: > Dudes, > > what are those new symbols in Kconfig and why do they wanna get enabled > on my box when doing oldconfig? Depends on X86? Really, that widespread? > > The help text doesn't say why do I need this... And that thing in s

Re: [PATCH 01/11] firmware: arm_scmi: review protocol registration interface

2020-10-15 Thread Cristian Marussi
Hi Vincent, thanks for the review. On Thu, Oct 15, 2020 at 11:41:09AM +0200, Vincent Guittot wrote: > On Wed, 14 Oct 2020 at 17:06, Cristian Marussi > wrote: > > > > Extend common protocol registration routines and provide some new generic > > protocols' init/deinit helpers that tracks protocol

Re: [PATCH] printk: ringbuffer: Wrong data pointer when appending small string

2020-10-15 Thread John Ogness
On 2020-10-15, Sergey Senozhatsky wrote: >> diff --git a/kernel/printk/printk_ringbuffer.c >> b/kernel/printk/printk_ringbuffer.c >> index 2493348a1631..24a960a89aa8 100644 >> --- a/kernel/printk/printk_ringbuffer.c >> +++ b/kernel/printk/printk_ringbuffer.c >> @@ -1125,7 +1125,10 @@ static char

Re: [PATCH v1 02/29] virtio-mem: simplify calculation in virtio_mem_mb_state_prepare_next_mb()

2020-10-15 Thread Wei Yang
On Thu, Oct 15, 2020 at 10:00:15AM +0200, David Hildenbrand wrote: >On 15.10.20 06:02, Wei Yang wrote: >> On Mon, Oct 12, 2020 at 02:52:56PM +0200, David Hildenbrand wrote: >>> We actually need one byte less (next_mb_id is exclusive, first_mb_id is >>> inclusive). Simplify. >>> >>> Cc: "Michael S.

Re: [PATCH] rtc: mt6397: Remove unused member dev

2020-10-15 Thread Alexandre Belloni
On Thu, 8 Oct 2020 17:34:14 +0800, Fei Shao wrote: > Removing the struct member "dev" in mt6397 RTC driver because it's not > initialized and the only usage is for one debugging message. > > Also fixed a typo in the error message. Applied, thanks! [1/1] rtc: mt6397: Remove unused member dev

Re: [PATCH v1 02/29] virtio-mem: simplify calculation in virtio_mem_mb_state_prepare_next_mb()

2020-10-15 Thread David Hildenbrand
On 15.10.20 12:00, Wei Yang wrote: > On Thu, Oct 15, 2020 at 10:00:15AM +0200, David Hildenbrand wrote: >> On 15.10.20 06:02, Wei Yang wrote: >>> On Mon, Oct 12, 2020 at 02:52:56PM +0200, David Hildenbrand wrote: We actually need one byte less (next_mb_id is exclusive, first_mb_id is incl

Re: [PATCH v3 3/8] of/address: Introduce of_dma_get_max_cpu_address()

2020-10-15 Thread Nicolas Saenz Julienne
On Thu, 2020-10-15 at 07:42 +0200, Christoph Hellwig wrote: > > +phys_addr_t __init of_dma_get_max_cpu_address(struct device_node *np) > > +{ > > + phys_addr_t max_cpu_addr = PHYS_ADDR_MAX; > > + struct of_range_parser parser; > > + phys_addr_t subtree_max_addr; > > + struct device_node *ch

Re: [PATCH v3 5/8] dma-direct: Turn zone_dma_bits default value into a define

2020-10-15 Thread Nicolas Saenz Julienne
On Thu, 2020-10-15 at 07:38 +0200, Christoph Hellwig wrote: > On Wed, Oct 14, 2020 at 09:12:07PM +0200, Nicolas Saenz Julienne wrote: > > Set zone_dma_bits default value through a define so as for architectures > > to be able to override it with their default value. > > Architectures can do that a

Re: [PATCH 1/2] x86/insn: Fix some potential undefined behavior.

2020-10-15 Thread Peter Zijlstra
On Wed, Oct 14, 2020 at 11:21:47PM -0700, Ian Rogers wrote: > From: Numfor Mbiziwo-Tiapo > > If insn_init is given a NULL kaddr and 0 buflen then validate_next will > perform arithmetic on NULL, add a guard to avoid this. How is this a problem? NULL is (void *)0, you can do arithmetic on that ju

Re: [PATCH v3 6/8] arm64: mm: Set ZONE_DMA size based on devicetree's dma-ranges

2020-10-15 Thread Nicolas Saenz Julienne
On Thu, 2020-10-15 at 07:39 +0200, Christoph Hellwig wrote: > On Wed, Oct 14, 2020 at 09:12:08PM +0200, Nicolas Saenz Julienne wrote: > > + zone_dma_bits = min(zone_dma_bits, > > + (unsigned > > int)ilog2(of_dma_get_max_cpu_address(NULL))); > > Plase avoid pointlessly long

Re: [PATCH v5] usb-serial:cp210x: add support to software flow control

2020-10-15 Thread kernel test robot
Hi Sheng, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb-serial/usb-next] [also build test WARNING on v5.9 next-20201015] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

zram NULL pointer dereference (zs_malloc)

2020-10-15 Thread David C. Manuelda
I found a serious bug about kernel NULL pointer dereference when using zram (in my case zram+btrfs) that makes system unstable and usually ends in a forced unclean reboot like powering off power source. This issue is present since >5.8.0 version (this one seems not affected) and still present

Re: [patch 1/2] nohz: only wakeup a single target cpu when kicking a task

2020-10-15 Thread Peter Zijlstra
On Thu, Oct 15, 2020 at 01:40:53AM +0200, Frederic Weisbecker wrote: > > re tick_nohz_task_switch() being placed wrong, it should probably be > > placed before finish_lock_switch(). Something like so. > > > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index cf044580683c..5c92c

5.10-rc0: build error in ipi.c

2020-10-15 Thread Pavel Machek
Hi! I'm getting build problems in 5.10-rc0 in config for n900. ARM board. CONFIG_SMP=y CONFIG_SMP_ON_UP=y CC net/devres.o kernel/irq/ipi.c: In function ‘irq_reserve_ipi’: kernel/irq/ipi.c:84:9: error: implicit declaration of function ‘__irq_domain_alloc_irqs’; did you mean ‘irq_dom

[tip:auto-latest] BUILD SUCCESS 80f92ca9b86c71450f003d39956fca4327cc5586

2020-10-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git auto-latest branch HEAD: 80f92ca9b86c71450f003d39956fca4327cc5586 Merge branch 'core/rcu' elapsed time: 1618m configs tested: 151 configs skipped: 2 The following configs have been built successfully. More configs m

Re: [PATCH v2] mmc: sdhci: Use Auto CMD Auto Select only when v4_mode is true

2020-10-15 Thread Adrian Hunter
On 15/10/20 12:41 pm, Jisheng Zhang wrote: > sdhci-of-dwcmshc meets an eMMC read performance regression with below > command after commit 427b6514d095 ("mmc: sdhci: Add Auto CMD Auto > Select support"): > > dd if=/dev/mmcblk0 of=/dev/null bs=8192 count=10 > > Before the commit, the above comm

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-15 Thread Felipe Balbi
Serge Semin writes: > On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote: >> >> Hi Serge, >> >> Serge Semin writes: >> > In accordance with the DWC USB3 bindings the corresponding node name is >> > suppose to comply with Generic USB HCD DT schema, which requires the USB >> > >> DWC3

Re: [PATCH v2 0/3] Clarify abstract scale usage for power values in Energy Model, EAS and IPA

2020-10-15 Thread Daniel Lezcano
On 15/10/2020 11:00, Lukasz Luba wrote: [ ... ] >> There is the SCMI and the DT. Because there are two sources where it is >> impossible to know if they are using the same units, we are stuck to >> ensure a consistency for the kernel. >> >> The platform should use: >>   - the SCMI only (scaled or

Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps

2020-10-15 Thread Peter Zijlstra
On Thu, Oct 15, 2020 at 01:23:41AM +0200, Jann Horn wrote: > It would probably be good to keep LTO and non-LTO builds in sync about > which files are subjected to objtool checks. So either you should be > removing the OBJECT_FILES_NON_STANDARD annotations for anything that > is linked into the mai

Re: [PATCH RFC 5/8] kasan: mark kasan_init_tags as __init

2020-10-15 Thread Marco Elver
On Wed, 14 Oct 2020 at 22:44, Andrey Konovalov wrote: > > Similarly to kasan_init() mark kasan_init_tags() as __init. > > Signed-off-by: Andrey Konovalov > Link: > https://linux-review.googlesource.com/id/I8792e22f1ca5a703c5e979969147968a99312558 > --- > include/linux/kasan.h | 4 ++-- > mm/kas

Re: [PATCH v2] i2c: i2c-mux-gpio: Enable this driver in ACPI land

2020-10-15 Thread Peter Rosin
Hi! On 2020-10-15 03:02, Evan Green wrote: > Enable i2c-mux-gpio devices to be defined via ACPI. The idle-state > property translates directly to a fwnode_property_*() call. The child > reg property translates naturally into _ADR in ACPI. > > The i2c-parent binding is a relic from the days when a

[PATCH v4] dt-bindings: power: rockchip: Convert to json-schema

2020-10-15 Thread Enric Balletbo i Serra
Convert the soc/rockchip/power_domain.txt binding document to json-schema and move to the power bindings directory. Signed-off-by: Enric Balletbo i Serra --- Rob, I didn't add a number of clocks neither a number of pm_qos because will be a finger in the air number. If you still want I add it, I c

Re: [PATCH 6/7] ARM: dts: Add dts for Raspberry Pi 4 + Cirrus Logic Lochnagar2

2020-10-15 Thread Nicolas Saenz Julienne
Hi Richard, your series is very welcome, upstream support for audio codecs on the RPi4 has always been lackluster. Could you provide more information on the actual products? Are there custom made hats for the RPi4 or this wired into a generic development board. On Wed, 2020-10-14 at 15:54 +0100,

[PATCH] ASoC: wm5102: Use get_unaligned_be16() for dac_comp_coeff

2020-10-15 Thread Richard Fitzgerald
Replace the two-step copy-and-convert in wm5102_out_comp_coeff_put() with get_unaligned_be16(). Apart from looking nicer, it avoids this sparse warning: wm5102.c:687:35: sparse: sparse: cast to restricted __be16 Signed-off-by: Richard Fitzgerald --- sound/soc/codecs/wm5102.c | 4 +--- 1 file ch

Re: [PATCH drm/hisilicon v2 2/2] drm/hisilicon: Use the same style of variable type in hibmc_drm_drv

2020-10-15 Thread Thomas Zimmermann
Hi On Thu, 15 Oct 2020 17:00:17 +0800 Tian Tao wrote: > Consistently Use the same style of variable type in hibmc_drm_drv.c and > hibmc_drm_drv.h. > > Signed-off-by: Tian Tao > Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 ++--- > drivers/g

Re: [PATCH v2 02/24] tools: docs: memory-model: fix references for some files

2020-10-15 Thread Peter Zijlstra
On Thu, Oct 15, 2020 at 07:15:18AM +0200, Mauro Carvalho Chehab wrote: > I guess there might be some misunderstanding here. My fault. The plan > is to have zero doc warnings for 5.10[1]. I'd be glad to help and convert all the documentation under my maintainership to .txt files for you.

Re: [PATCH v3 7/8] arm64: mm: Set ZONE_DMA size based on early IORT scan

2020-10-15 Thread Lorenzo Pieralisi
On Wed, Oct 14, 2020 at 09:12:09PM +0200, Nicolas Saenz Julienne wrote: [...] > +unsigned int __init acpi_iort_get_zone_dma_size(void) > +{ > + struct acpi_table_iort *iort; > + struct acpi_iort_node *node, *end; > + acpi_status status; > + u8 limit = 32; > + int i; > + > +

Re: [PATCH v2] mmc: sdhci: Use Auto CMD Auto Select only when v4_mode is true

2020-10-15 Thread Ulf Hansson
On Thu, 15 Oct 2020 at 11:41, Jisheng Zhang wrote: > > sdhci-of-dwcmshc meets an eMMC read performance regression with below > command after commit 427b6514d095 ("mmc: sdhci: Add Auto CMD Auto > Select support"): > > dd if=/dev/mmcblk0 of=/dev/null bs=8192 count=10 > > Before the commit, the a

Re: [PATCH] HID: i2c-hid: add polling mode based on connected GPIO chip's pin status

2020-10-15 Thread Barnabás Pőcze
Hi, I believe this patch causes I2C HID devices not to work with IRQs after resuming from suspend. > [...] > #ifdef CONFIG_PM_SLEEP > @@ -1183,7 +1292,8 @@ static int i2c_hid_suspend(struct device *dev) > /* Save some power */ > i2c_hid_set_power(client, I2C_HID_PWR_SLEEP); > > -

Re: [PATCH 5/8] x86/clear_page: add clear_page_uncached()

2020-10-15 Thread Borislav Petkov
On Wed, Oct 14, 2020 at 08:37:44PM -0700, Ankur Arora wrote: > I don't disagree but I think the selection of cached/uncached route should > be made where we have enough context available to be able to choose to do > this. > > This could be for example, done in mm_populate() or gup where if say the

Re: [PATCH v1 00/15] Introduce threaded trace streaming for basic perf record operation

2020-10-15 Thread Alexey Budankov
On 14.10.2020 20:27, Ingo Molnar wrote: > > * Alexey Budankov wrote: > >> >> Patch set provides threaded trace streaming for base perf record >> operation. Provided streaming mode (--threads) mitigates profiling >> data losses and resolves scalability issues of serial and asynchronous >> (--ai

Re: [PATCH 5/8] x86/clear_page: add clear_page_uncached()

2020-10-15 Thread Borislav Petkov
On Wed, Oct 14, 2020 at 08:21:57PM -0700, Ankur Arora wrote: > Also, if we did extend clear_page() to take the page-size as parameter > we still might not have enough information (ex. a 4K or a 2MB page that > clear_page() sees could be part of a GUP of a much larger extent) to > decide whether to

Re: linux-next: build warnings after merge of the kunit-next tree

2020-10-15 Thread Vitor Massaru Iha
Hi Stephen, On Thu, Oct 15, 2020 at 2:31 AM Stephen Rothwell wrote: > > Hi all, > > After merging the kunit-next tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > lib/bitfield_kunit.c: In function 'test_bitfields_compile': > lib/bitfield_kunit.c:136:21: warning: un

Re: [PATCH] atomics.tbl: Remove executable permission bits

2020-10-15 Thread Will Deacon
On Mon, Oct 12, 2020 at 12:34:06PM -0700, Joe Perches wrote: > commit 4d8e5cd233db ("locking/atomics: Fix scripts/atomic/ script > permissions") > set all files in this directory executable. > > But this file is an input to those scripts and does not need to be executable. > > Signed-off-by: Joe

[RFC PATCH 0/1] security: add fault injection to LSM hooks

2020-10-15 Thread Aleksandr Nogikh
From: Aleksandr Nogikh Fault injection capabilities[Documentation/fault-injection/fault-injection.rst] facilitate testing of the stability of the Linux kernel by providing means to force a number of kernel interfaces to return error codes. This RFC proposes adding such fault injection capability

[RFC PATCH 1/1] security: add fault injection capability

2020-10-15 Thread Aleksandr Nogikh
From: Aleksandr Nogikh Add a fault injection capability to call_int_hook macro. This will facilitate testing of fault tolerance of the code that invokes security hooks as well as the fault tolerance of the LSM implementations themselves. Add a KConfig option (CONFIG_FAIL_LSM_HOOKS) that controls

Re: [PATCH v2] lib: kunit: add list_sort test conversion to KUnit

2020-10-15 Thread Andy Shevchenko
On Wed, Oct 14, 2020 at 10:46:16PM -0300, Vitor Massaru Iha wrote: > This adds the conversion of the runtime tests of test_list_sort, > from `lib/test_list_sort.c` to KUnit tests. Please, provide better commit message. For example, add the output of _succeeded_ *and* _failed_ test cases (yes, you

[PATCH V3] [Cocci] coccinelle: iterators: Add for_each_child.cocci script

2020-10-15 Thread Sumera Priyadarsini
While iterating over child nodes with the for_each functions, if control is transferred from the middle of the loop, as in the case of a break or return or goto, there is no decrement in the reference counter thus ultimately resulting in a memory leak. Add this script to detect potential memory le

[PATCH] powerpc: force inlining of csum_partial() to avoid multiple csum_partial() with GCC10

2020-10-15 Thread Christophe Leroy
ppc-linux-objdump -d vmlinux | grep -e "" -e "<__csum_partial>" With gcc9 I get: c0017ef8 <__csum_partial>: c00182fc: 4b ff fb fd bl c0017ef8 <__csum_partial> c0018478: 4b ff fa 80 b c0017ef8 <__csum_partial> c03e8458:

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-15 Thread Thadeu Lima de Souza Cascardo
On Wed, Oct 14, 2020 at 08:43:22PM -0700, Jakub Kicinski wrote: > On Tue, 13 Oct 2020 19:18:48 +0200 Kleber Sacilotto de Souza wrote: > > From: Thadeu Lima de Souza Cascardo > > > > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason > > del_timer_sync can't be used is becau

Re: [PATCH v3] thunderbolt: Add the missed ida_simple_remove() in ring_request_msix()

2020-10-15 Thread Andy Shevchenko
On Thu, Oct 15, 2020 at 04:40:53PM +0800, Jing Xiangfeng wrote: > ring_request_msix() misses to call ida_simple_remove() in an error path. > Add a label 'err_ida_remove' and jump to it. FWIW, Reviewed-by: Andy Shevchenko > Fixes: 046bee1f9ab8 ("thunderbolt: Add MSI-X support") > Signed-off-by: J

Re: [PATCH v4 2/5] arm64: mremap speedup - Enable HAVE_MOVE_PMD

2020-10-15 Thread Will Deacon
On Wed, Oct 14, 2020 at 12:53:07AM +, Kalesh Singh wrote: > HAVE_MOVE_PMD enables remapping pages at the PMD level if both the > source and destination addresses are PMD-aligned. > > HAVE_MOVE_PMD is already enabled on x86. The original patch [1] that > introduced this config did not enable it

Re: [PATCH v1 3/3] ARM: dts: add Van der Laan LANMCU board

2020-10-15 Thread Marco Felsch
On 20-10-15 11:02, Oleksij Rempel wrote: > Hi Marco, > > thank you for review! > > On Wed, Oct 14, 2020 at 12:05:01PM +0200, Marco Felsch wrote: > > Hi Oleksij, > > > > pls can you send a patch adding this board to: > > Documentation/devicetree/bindings/arm/fsl.yaml > > > > infront of this patc

[PATCH] crypto: ecrdsa - use subsys_initcall instead of module_init

2020-10-15 Thread Tianjia Zhang
All templates and generic algorithms have been registered in subsys_initcall instead of module_init. The ecrdsa algorithm happened to be missed. Here is a fix for it. Cc: Vitaly Chikunov Signed-off-by: Tianjia Zhang --- crypto/ecrdsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: Linux 5.9: smartpqi: controller is offline: status code 0x6100c

2020-10-15 Thread Thomas Kreitler
Hello Paul, The meaning behind 0x6100c can be found rather easily. From drivers/scsi/smartpqi/smartpqi.h comes the main part #define PQI_DATA_IN_OUT_PCIE_COMPLETION_TIMEOUT 0x61 the rest looks like additional status bytes reported whilst the error is processed. My conclusion is that some

Re: [PATCH 1/1] Sched/fair: Improve the accuracy of sched_stat_wait statistics

2020-10-15 Thread Peter Zijlstra
On Thu, Oct 15, 2020 at 02:48:46PM +0800, qianjun.ker...@gmail.com wrote: > From: jun qian > > When the sched_schedstat changes from 0 to 1, some sched se maybe > already in the runqueue, the se->statistics.wait_start will be 0. > So it will let the (rq_of(cfs_rq)) - se->statistics.wait_start) >

[PATCH v3] media: v4l2-ctrl: add control for long term reference.

2020-10-15 Thread Dikshita Agarwal
LTR (Long Term Reference) frames are the frames that are encoded sometime in the past and stored in the DPB buffer list to be used as reference to encode future frames. This change adds controls to enable this feature. Signed-off-by: Dikshita Agarwal --- .../userspace-api/media/v4l/ext-ctrls-cod

Re: [PATCH] net: sockmap: Don't call bpf_prog_put() on NULL pointer

2020-10-15 Thread Jakub Sitnicki
On Thu, Oct 15, 2020 at 06:43 AM CEST, John Fastabend wrote: [...] > Jakub, any opinions on if we should just throw an error if users try to > add a sock to a map with a parser but no verdict? At the moment we fall > through and add the socket, but it wont do any receive parsing/verdict. > At the

[PATCH v2] media: v4l2-ctrl: Add base layer priority id control.

2020-10-15 Thread Dikshita Agarwal
This control indicates the priority id to be applied to base layer. Signed-off-by: Dikshita Agarwal --- Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 9 + drivers/media/v4l2-core/v4l2-ctrls.c | 1 + include/uapi/linux/v4l2-controls.h

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-15 Thread Benjamin Poirier
On 2020-10-15 11:37 +0800, Coiby Xu wrote: > On Tue, Oct 13, 2020 at 09:37:04AM +0900, Benjamin Poirier wrote: > > On 2020-10-12 19:24 +0800, Coiby Xu wrote: > > [...] > > > > I think, but didn't check in depth, that in those drivers, the devlink > > > > device is tied to the pci device and can exi

[PATCH v3 11/19] sched/core: Make migrate disable and CPU hotplug cooperative

2020-10-15 Thread Peter Zijlstra
From: Thomas Gleixner On CPU unplug tasks which are in a migrate disabled region cannot be pushed to a different CPU until they returned to migrateable state. Account the number of tasks on a runqueue which are in a migrate disabled section and make the hotplug wait mechanism respect that. Sign

[PATCH v3 10/19] sched: Fix migrate_disable() vs set_cpus_allowed_ptr()

2020-10-15 Thread Peter Zijlstra
Concurrent migrate_disable() and set_cpus_allowed_ptr() has interesting features. We rely on set_cpus_allowed_ptr() to not return until the task runs inside the provided mask. This expectation is exported to userspace. This means that any set_cpus_allowed_ptr() caller must wait until migrate_enabl

[PATCH v3 07/19] sched: Fix hotplug vs CPU bandwidth control

2020-10-15 Thread Peter Zijlstra
Since we now migrate tasks away before DYING, we should also move bandwidth unthrottle, otherwise we can gain tasks from unthrottle after we expect all tasks to be gone already. Also; it looks like the RT balancers don't respect cpu_active() and instead rely on rq->online in part, complete this. T

[PATCH v3 02/19] sched: Fix balance_callback()

2020-10-15 Thread Peter Zijlstra
The intent of balance_callback() has always been to delay executing balancing operations until the end of the current rq->lock section. This is because balance operations must often drop rq->lock, and that isn't safe in general. However, as noted by Scott, there were a few holes in that scheme; ba

[PATCH v3 18/19] sched: Deny self-issued __set_cpus_allowed_ptr() when migrate_disable()

2020-10-15 Thread Peter Zijlstra
From: Valentin Schneider migrate_disable(); set_cpus_allowed_ptr(current, {something excluding task_cpu(current)}); affine_move_task(); <-- never returns Signed-off-by: Valentin Schneider Signed-off-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/20201013140116.26651-1-valent

[PATCH v3 17/19] sched: Add migrate_disable() tracepoints

2020-10-15 Thread Peter Zijlstra
XXX write a tracer: - 'migirate_disable() -> migrate_enable()' time in task_sched_runtime() - 'migrate_pull -> sched-in' time in task_sched_runtime() The first will give worst case for the second, which is the actual interference experienced by the task to due migration constraints of migrate_d

<    1   2   3   4   5   6   7   8   9   10   >