Re: [LKP] Re: [sched] bdfcae1140: will-it-scale.per_thread_ops -37.0% regression

2020-10-22 Thread Mathieu Desnoyers
- On Oct 21, 2020, at 9:54 PM, Xing Zhengjun zhengjun.x...@linux.intel.com wrote: [...] > In fact, 0-day just copy the will-it-scale benchmark from the GitHub, if > you think the will-it-scale benchmark has some issues, you can > contribute your idea and help to improve it, later we will updat

[PATCH RFC v2 00/21] kasan: hardware tag-based mode for production use on arm64

2020-10-22 Thread Andrey Konovalov
This patchset is not complete (hence sending as RFC), but I would like to start the discussion now and hear people's opinions regarding the questions mentioned below. === Overview This patchset adopts the existing hardware tag-based KASAN mode [1] for use in production as a memory corruption miti

[PATCH RFC v2 12/21] kasan: inline and rename kasan_unpoison_memory

2020-10-22 Thread Andrey Konovalov
Currently kasan_unpoison_memory() is used as both an external annotation and as internal memory poisoning helper. Rename external annotation to kasan_unpoison_data() and inline the internal helper for for hardware tag-based mode to avoid undeeded function calls. There's the external annotation kas

[PATCH RFC v2 05/21] kasan: allow VMAP_STACK for HW_TAGS mode

2020-10-22 Thread Andrey Konovalov
Even though hardware tag-based mode currently doesn't support checking vmalloc allocations, it doesn't use shadow memory and works with VMAP_STACK as is. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/I3552cbc12321dec82cd7372676e9372a2eb452ac --- arch/Kconfig | 2

[PATCH RFC v2 11/21] kasan: inline kasan_poison_memory and check_invalid_free

2020-10-22 Thread Andrey Konovalov
Using kasan_poison_memory() or check_invalid_free() currently results in function calls. Move their definitions to mm/kasan/kasan.h and turn them into static inline functions for hardware tag-based mode to avoid uneeded function calls. Signed-off-by: Andrey Konovalov Link: https://linux-review.g

[PATCH RFC v2 14/21] kasan: add and integrate kasan boot parameters

2020-10-22 Thread Andrey Konovalov
TODO: no meaningful description here yet, please see the cover letter for this RFC series. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/If7d37003875b2ed3e0935702c8015c223d6416a4 --- mm/kasan/common.c | 92 +--- mm/kasan/generic.c |

[PATCH RFC v2 13/21] arm64: kasan: Add cpu_supports_tags helper

2020-10-22 Thread Andrey Konovalov
Add an arm64 helper called cpu_supports_mte() that exposes information about whether the CPU supports memory tagging and that can be called during early boot (unlike system_supports_mte()). Use that helper to implement a generic cpu_supports_tags() helper, that will be used by hardware tag-based K

[PATCH RFC v2 09/21] kasan: inline kasan_reset_tag for tag-based modes

2020-10-22 Thread Andrey Konovalov
Using kasan_reset_tag() currently results in a function call. As it's called quite often from the allocator code this leads to a noticeable slowdown. Move it to include/linux/kasan.h and turn it into a static inline function. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesourc

[PATCH RFC v2 15/21] kasan: check kasan_enabled in annotations

2020-10-22 Thread Andrey Konovalov
Declare the kasan_enabled static key in include/linux/kasan.h and in include/linux/mm.h and check it in all kasan annotations. This allows to avoid any slowdown caused by function calls when kasan_enabled is disabled. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id

[PATCH RFC v2 16/21] kasan: optimize poisoning in kmalloc and krealloc

2020-10-22 Thread Andrey Konovalov
Since kasan_kmalloc() always follows kasan_slab_alloc(), there's no need to reunpoison the object data, only to poison the redzone. This requires changing kasan annotation for early SLUB cache to kasan_slab_alloc(). Otherwise kasan_kmalloc() doesn't untag the object. This doesn't do any functional

[PATCH RFC v2 17/21] kasan: simplify kasan_poison_kfree

2020-10-22 Thread Andrey Konovalov
kasan_poison_kfree() is currently only called for mempool allocations that are backed by either kmem_cache_alloc() or kmalloc(). Therefore, the page passed to kasan_poison_kfree() is always PageSlab() and there's no need to do the check. Signed-off-by: Andrey Konovalov Link: https://linux-review

[PATCH RFC v2 07/21] kasan, arm64: move initialization message

2020-10-22 Thread Andrey Konovalov
Tag-based KASAN modes are fully initialized with kasan_init_tags(), while the generic mode only requireds kasan_init(). Move the initialization message for tag-based modes into kasan_init_tags(). Also fix pr_fmt() usage for KASAN code: generic mode doesn't need it, tag-based modes should use "kasa

[PATCH RFC v2 18/21] kasan: rename kasan_poison_kfree

2020-10-22 Thread Andrey Konovalov
Rename kasan_poison_kfree() into kasan_slab_free_mempool() as it better reflects what this annotation does. No functional changes. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/I5026f87364e556b506ef1baee725144bb04b8810 --- include/linux/kasan.h | 16 ---

[PATCH RFC v2 19/21] kasan: don't round_up too much

2020-10-22 Thread Andrey Konovalov
For tag-based mode kasan_poison_memory() already rounds up the size. Do the same for software modes and remove round_up() from common code. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/Ib397128fac6eba874008662b4964d65352db4aa4 --- mm/kasan/common.c | 8 ++--

[PATCH RFC v2 08/21] kasan: remove __kasan_unpoison_stack

2020-10-22 Thread Andrey Konovalov
There's no need for __kasan_unpoison_stack() helper, as it's only currently used in a single place. Removing it also removes undeed arithmetic. No functional changes. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/Ie5ba549d445292fe629b4a96735e4034957bcc50 --- mm

[PATCH RFC v2 06/21] kasan: mark kasan_init_tags as __init

2020-10-22 Thread Andrey Konovalov
Similarly to kasan_init() mark kasan_init_tags() as __init. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/I8792e22f1ca5a703c5e979969147968a99312558 --- include/linux/kasan.h | 2 +- mm/kasan/hw_tags.c| 2 +- mm/kasan/sw_tags.c| 2 +- 3 files changed, 3 i

[PATCH RFC v2 20/21] kasan: simplify assign_tag and set_tag calls

2020-10-22 Thread Andrey Konovalov
set_tag() already ignores the tag for the generic mode, so just call it as is. Add a check for the generic mode to assign_tag(), and simplify its call in kasan_kmalloc(). Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/I18905ca78fb4a3d60e1a34a4ca00247272480438

Re: [PATCH 1/2] x86: Conditional init of pcengines leds/keys gpios

2020-10-22 Thread Enrico Weigelt, metux IT consult
On 22.10.20 11:38, Ed W wrote: Hi, > As a compromise can you change your userland to cope with dynamic names? I > see two simple ways: > > 1) udev rule to set name as you wish can you give an example of udev rule depending on bios version ? > To recap though, the situation for many years was

[PATCH RFC v2 10/21] kasan: inline random_tag for HW_TAGS

2020-10-22 Thread Andrey Konovalov
Using random_tag() currently results in a function call. Move its definition to mm/kasan/kasan.h and turn it into a static inline function for hardware tag-based mode to avoid uneeded function call. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/Iac5b2faf9a912900e

[PATCH RFC v2 21/21] kasan: clarify comment in __kasan_kfree_large

2020-10-22 Thread Andrey Konovalov
Currently it says that the memory gets poisoned by page_alloc code. Clarify this by mentioning the specific callback that poisons the memory. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/I1334dffb69b87d7986fab88a1a039cc3ea764725 --- mm/kasan/common.c | 2 +- 1

Re: [RFC] Have insn decoder functions return success/failure

2020-10-22 Thread Masami Hiramatsu
On Thu, 22 Oct 2020 11:30:44 +0200 Borislav Petkov wrote: > On Thu, Oct 22, 2020 at 04:31:00PM +0900, Masami Hiramatsu wrote: > > No, insn_get_length() implies it decodes whole of the instruction. > > (yeah, we need an alias of that, something like insn_get_complete()) > > That's exactly what I'

Re: Context expectations in ALSA

2020-10-22 Thread Takashi Iwai
On Thu, 22 Oct 2020 14:57:41 +0200, Maxime Ripard wrote: > > On Thu, Oct 22, 2020 at 12:03:19PM +0200, Jaroslav Kysela wrote: > > Dne 22. 10. 20 v 11:50 Maxime Ripard napsal(a): > > > > > So, I'm not really sure what I'm supposed to do here. The drivers > > > involved don't appear to be doing any

[PATCH] staging/wlan-ng: Fix line alignment

2020-10-22 Thread izabela . bakollari
From: Izabela Bakollari Fix code alignment. Issue reported by checkpatch.pl Signed-off-by: Izabela Bakollari --- drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mg

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Christoph Hellwig
On Thu, Oct 22, 2020 at 11:36:40AM +0200, David Hildenbrand wrote: > My thinking: if the compiler that calls import_iovec() has garbage in > the upper 32 bit > > a) gcc will zero it out and not rely on it being zero. > b) clang will not zero it out, assuming it is zero. > > But > > a) will zero

Re: Context expectations in ALSA

2020-10-22 Thread Maxime Ripard
Hi Takashi, On Thu, Oct 22, 2020 at 03:20:49PM +0200, Takashi Iwai wrote: > On Thu, 22 Oct 2020 14:57:41 +0200, > Maxime Ripard wrote: > > > > On Thu, Oct 22, 2020 at 12:03:19PM +0200, Jaroslav Kysela wrote: > > > Dne 22. 10. 20 v 11:50 Maxime Ripard napsal(a): > > > > > > > So, I'm not really s

Re: kernel BUG at mm/page-writeback.c:2241 [ BUG_ON(PageWriteback(page); ]

2020-10-22 Thread William Kucharski
> On Oct 21, 2020, at 6:49 PM, Matthew Wilcox wrote: > > On Wed, Oct 21, 2020 at 08:30:18PM -0400, Qian Cai wrote: >> Today's linux-next starts to trigger this wondering if anyone has any clue. > > I've seen that occasionally too. I changed that BUG_ON to VM_BUG_ON_PAGE > to try to get a clu

Re: [PATCH] mm,thp,shmem: limit shmem THP alloc gfp_mask

2020-10-22 Thread Rik van Riel
On Thu, 2020-10-22 at 10:15 +0200, Michal Hocko wrote: > On Wed 21-10-20 23:48:46, Rik van Riel wrote: > > The allocation flags of anonymous transparent huge pages can be > > controlled > > through the files in /sys/kernel/mm/transparent_hugepage/defrag, > > which can > > help the system from getti

Re: [PATCH] KVM: X86: Expose KVM_HINTS_REALTIME in KVM_GET_SUPPORTED_CPUID

2020-10-22 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 22/10/20 03:34, Wanpeng Li wrote: >> From: Wanpeng Li >> >> Per KVM_GET_SUPPORTED_CPUID ioctl documentation: >> >> This ioctl returns x86 cpuid features which are supported by both the >> hardware and kvm in its default configuration. >> >> A well-behaved userspace

[PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions

2020-10-22 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update SC7180 lpass_variant structure with proper I2S bitwidth field bit positions, as bitwidth denotes 0 to 1 bits, but previously used only 0 bit. Fixes: commit cba62c8b49bead ("Merge series "ASoC: qcom: Add support for SC7180 lpass variant" from Rohit kumar :") Si

Re: [PATCH 2/4] clk: renesas: r8a774a1: Add RPC clocks

2020-10-22 Thread Geert Uytterhoeven
On Fri, Oct 16, 2020 at 2:17 PM Lad Prabhakar wrote: > From: Biju Das > > Describe the RPCSRC internal clock and the RPC[D2] clocks derived from it, > as well as the RPC-IF module clock, in the RZ/G2M (R8A774A1) CPG/MSSR > driver. > > Inspired by commit 94e3935b5756 ("clk: renesas: r8a77980: Add

Re: [PATCHv2 2/4] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf()

2020-10-22 Thread Suzuki Poulose
On 10/22/20 12:32 PM, Peter Zijlstra wrote: On Thu, Oct 22, 2020 at 04:27:52PM +0530, Sai Prakash Ranjan wrote: Looking at the ETR and other places in the kernel, ETF and the ETB are the only places trying to dereference the task(owner) in tmc_enable_etf_sink_perf() which is also called from th

Re: [PATCH] KVM: X86: Expose KVM_HINTS_REALTIME in KVM_GET_SUPPORTED_CPUID

2020-10-22 Thread Xiaoyao Li
On 10/22/2020 9:02 PM, Paolo Bonzini wrote: On 22/10/20 03:34, Wanpeng Li wrote: From: Wanpeng Li Per KVM_GET_SUPPORTED_CPUID ioctl documentation: This ioctl returns x86 cpuid features which are supported by both the hardware and kvm in its default configuration. A well-behaved userspace sho

Re: Context expectations in ALSA

2020-10-22 Thread Takashi Iwai
On Thu, 22 Oct 2020 15:24:12 +0200, Maxime Ripard wrote: > > Hi Takashi, > > On Thu, Oct 22, 2020 at 03:20:49PM +0200, Takashi Iwai wrote: > > On Thu, 22 Oct 2020 14:57:41 +0200, > > Maxime Ripard wrote: > > > > > > On Thu, Oct 22, 2020 at 12:03:19PM +0200, Jaroslav Kysela wrote: > > > > Dne 22.

Re: [PATCH 3/4] clk: renesas: r8a774b1: Add RPC clocks

2020-10-22 Thread Geert Uytterhoeven
On Fri, Oct 16, 2020 at 2:17 PM Lad Prabhakar wrote: > From: Biju Das > > Describe the RPCSRC internal clock and the RPC[D2] clocks derived from it, > as well as the RPC-IF module clock, in the RZ/G2N (R8A774B1) CPG/MSSR > driver. > > Inspired by commit 94e3935b5756 ("clk: renesas: r8a77980: Add

Re: [PATCH] printk: handle blank console arguments passed in.

2020-10-22 Thread Sergey Senozhatsky
On (20/10/22 13:38), Petr Mladek wrote: > > Hmm. How about this. console= is undocumented and unspecified - it > > may work sometimes or it may kill the system (and theoretically even > > corrupt some files, depending on what fd 1 and fd 2 point to). So > > maybe we can document console= and handle

Re: [PATCHv2 2/4] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf()

2020-10-22 Thread Peter Zijlstra
On Thu, Oct 22, 2020 at 06:19:37PM +0530, Sai Prakash Ranjan wrote: > On 2020-10-22 17:02, Peter Zijlstra wrote: > > On Thu, Oct 22, 2020 at 04:27:52PM +0530, Sai Prakash Ranjan wrote: > > > > > Looking at the ETR and other places in the kernel, ETF and the > > > ETB are the only places trying to

Re: [PATCH][v2] PM / sysfs: Expose suspend resume driver flags in sysfs

2020-10-22 Thread Andy Shevchenko
On Thu, Oct 22, 2020 at 12:24 PM Chen Yu wrote: > > Currently there are 4 driver flags to control system suspend/resume > behavior: DPM_FLAG_NO_DIRECT_COMPLETE, DPM_FLAG_SMART_PREPARE, > DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME. Make these flags > visible in sysfs as read-only to get a

[PATCH 4/6] media: uvcvideo: Add Privacy control based on EXT_GPIO

2020-10-22 Thread Ricardo Ribalda
Add a new control and mapping for Privacy controls connected to UVC_GUID_EXT_GPIO_CONTROLLERs. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 20 drivers/media/usb/uvc/uvcvideo.h | 2 +- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/d

[PATCH 2/6] media: uvcvideo: Add UVC_CTRL_FLAG_ENTITY_GET_CUR

2020-10-22 Thread Ricardo Ribalda
This flag allows controls to get their current value from an entity defined function instead of via a query to the USB device. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 17 + include/uapi/linux/uvcvideo.h| 1 + 2 files changed, 14 insertions(+), 4

[Outreachy kernel][PATCH 0/5] drm/amdgpu: Replace snprintf() with sysfs_emit

2020-10-22 Thread Sumera Priyadarsini
Using snprintf() for show() methods holds the risk of buffer overrun as snprintf() does not know the PAGE_SIZE maximum of the temporary buffer used to output sysfs content. This patchset is a series of Coccinelle cleanups across the staging directory to convert snprintf with scnprintf in the relev

[PATCH 1/6] media: uvcvideo: Add UVC_CTRL_FLAG_ENTITY_GET_INFO

2020-10-22 Thread Ricardo Ribalda
This flag allows controls to get their properties from an entity defined function instead of via a query to the USB device. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 9 +++-- drivers/media/usb/uvc/uvcvideo.h | 3 +++ include/uapi/linux/uvcvideo.h| 2 ++ 3 file

[PATCH 0/6] Show privacy_gpio as a v4l2_ctrl

2020-10-22 Thread Ricardo Ribalda
Some devices can implement a physical switch to disable the input of the camera on demand. Think of it like an elegant privacy sticker. The system can read the status of the privacy switch via a GPIO. The ACPI table maps this GPIO to the USB device via _CRS and _DSD descriptors, so the kernel

[PATCH 6/6] media: uvcvideo: Handle IRQs from the privacy_pin

2020-10-22 Thread Ricardo Ribalda
If the privacy pin produces an IRQ, read the gpio and notify userspace via an event. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 3 +++ drivers/media/usb/uvc/uvc_driver.c | 30 ++ 2 files changed, 33 insertions(+) diff --git a/drivers/med

[PATCH 5/6] media: uvcvideo: Implement UVC_GPIO_UNIT

2020-10-22 Thread Ricardo Ribalda
Some devices can implement a physical switch to disable the input of the camera on demand. Think of it like an elegant privacy sticker. The system can read the status of the privacy switch via a GPIO. It is important to know the status of the switch, e.g. to notify the user when the camera will p

[PATCH 3/6] media: uvcvideo: Add UVC_GUID_EXT_GPIO_CONTROLLER

2020-10-22 Thread Ricardo Ribalda
Create a new GUID for GPIO controller entities that do not belong to the USB video device. This GUID is selected on an address range completely different that the UVC standard to avoid collisions. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 4 drivers/media/usb/uv

Re: [RFC PATCH v3 9/9] ipu3-cio2: Add functionality allowing software_node connections to sensors on platforms designed for Windows

2020-10-22 Thread Andy Shevchenko
On Thu, Oct 22, 2020 at 3:59 PM Daniel Scally wrote: > On 20/10/2020 10:41, Andy Shevchenko wrote: ... > >> +static const char * const port_names[] = { > >> +"port0", "port1", "port2", "port3" > > + comma. > I think 4 ports is the maximum for CIO2 device, so this shouldn't ever > get extende

Re: [PATCH 3/3] PM: runtime: Resume the device earlier in __device_release_driver()

2020-10-22 Thread chenxiang (M)
Hi Rafael, 在 2020/10/22 3:14, Rafael J. Wysocki 写道: From: Rafael J. Wysocki Since the device is resumed from runtime-suspend in __device_release_driver() anyway, it is better to do that before looking for busy managed device links from it to consumers, because if there are any, device_links_un

[PATCH 1/5] gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()

2020-10-22 Thread Sumera Priyadarsini
Using snprintf() for show() methods holds the risk of buffer overrun as snprintf() does not know the PAGE_SIZE maximum of the temporary buffer used to output sysfs content. Modify amdgpu_atombios.c to use sysfs_emit() instead which knows the size of the temporary buffer. Issue found with Coccinel

Re: WARNING in dma_map_page_attrs

2020-10-22 Thread Christoph Hellwig
I don't think the merge commit makes sense here. But what we see here is that dma_map_page is called on the rxe device, without that device having a DMA mask. For now this needs a workaround in rxe, but for 5.11 I'll send a patch to remove dma-virt and just handle this case inside of the rdma cor

[PATCH 2/5] gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()

2020-10-22 Thread Sumera Priyadarsini
Using snprintf() for show() methods holds the risk of buffer overrun as snprintf() does not know the PAGE_SIZE maximum of the temporary buffer used to output sysfs content. Modify amdgpu_device.c to use sysfs_emit() instead which knows the size of the temporary buffer. Issue found with Coccinelle

[PATCH] sched/fair: prefer prev cpu in asymmetric wakeup path

2020-10-22 Thread Vincent Guittot
During fast wakeup path, scheduler always check whether local or prev cpus are good candidates for the task before looking for other cpus in the domain. With commit b7a331615d25 ("sched/fair: Add asymmetric CPU capacity wakeup scan") the heterogenous system gains a dedicated path but doesn't try

Re: [RFC 1/2] printk: Add kernel parameter: mute_console

2020-10-22 Thread Steven Rostedt
On Thu, 22 Oct 2020 13:42:27 +0200 Petr Mladek wrote: > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index fe64a49344bf..63fb96630767 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -1207,6 +1207,19 @@ void __init setup_log_buf(int early) > memblo

Re: [Outreachy kernel] [PATCH] staging/wlan-ng: Fix line that exceeds 100 columns

2020-10-22 Thread Julia Lawall
On Thu, 22 Oct 2020, izabela.bakoll...@gmail.com wrote: > From: Izabela Bakollari > > Rearrange comment that exceeds 100 columns length. Issue reported > by checkpatch.pl > > Signed-off-by: Izabela Bakollari > --- > drivers/staging/wlan-ng/cfg80211.c | 3 ++- > 1 file changed, 2 insertions(+

[GIT PULL 1/2] Kbuild updates for v5.10-rc1

2020-10-22 Thread Masahiro Yamada
Hi Linus, Please pull Kbuild updates for v5.10 You will see a merge conflict in arch/arm/Makefile. The fix-up is easy, and also available in linux-next. Thanks. The following changes since commit d012a7190fc1fd72ed48911e77ca97ba4521bccd: Linux 5.9-rc2 (2020-08-23 14:08:43 -0700) are availa

[PATCH 4/5] gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()

2020-10-22 Thread Sumera Priyadarsini
Using snprintf() for show() methods holds the risk of buffer overrun as snprintf() does not know the PAGE_SIZE maximum of the temporary buffer used to output sysfs content. Modify amdgpu_psp.c to use sysfs_emit() instead which knows the size of the temporary buffer. Issue found with Coccinelle.

[GIT PULL 2/2] Kconfig updates for v5.10-rc1

2020-10-22 Thread Masahiro Yamada
Hi Linus, Please pull Kconfig updates for v5.10 Thanks. The following changes since commit ba4f184e126b751d1bffad5897f263108befc780: Linux 5.9-rc6 (2020-09-20 16:33:55 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git t

[GIT PULL 2/2] Kconfig updates for v5.10-rc1

2020-10-22 Thread Masahiro Yamada
Hi Linus, Please pull Kconfig updates for v5.10 Thanks. The following changes since commit ba4f184e126b751d1bffad5897f263108befc780: Linux 5.9-rc6 (2020-09-20 16:33:55 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git t

[PATCH 5/5] gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()

2020-10-22 Thread Sumera Priyadarsini
Using snprintf() for show() methods holds the risk of buffer overrun as snprintf() does not know the PAGE_SIZE maximum of the temporary buffer used to output sysfs content. Modify amdgpu_ras.c to use sysfs_emit() instead which knows the size of the temporary buffer. Issue found with Coccinelle.

Re: [Outreachy kernel] [PATCH] staging/wlan-ng: Fix line alignment

2020-10-22 Thread Julia Lawall
On Thu, 22 Oct 2020, izabela.bakoll...@gmail.com wrote: > From: Izabela Bakollari > > Fix code alignment. Issue reported by checkpatch.pl Try to find something other than "Fix" to describe what you have done. What kind of change have you made and why is it a good idea? > > Signed-off-by: Izab

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 02:57:59PM +0200, Greg KH wrote: > On Thu, Oct 22, 2020 at 02:42:24PM +0200, David Hildenbrand wrote: > > On 22.10.20 14:18, Greg KH wrote: > > > On Thu, Oct 22, 2020 at 12:48:05PM +0200, Greg KH wrote: > > >> On Thu, Oct 22, 2020 at 11:36:40AM +0200, David Hildenbrand wrote

Re: [PATCH v2] i2c: designware: call i2c_dw_read_clear_intrbits_slave() once

2020-10-22 Thread Jarkko Nikula
Hi On 10/22/20 8:46 AM, Michael Wu wrote: @@ -217,10 +214,8 @@ static int i2c_dw_irq_handler_slave(struct dw_i2c_dev *dev) if (!i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_RECEIVED, &val)) dev_vdbg(dev->dev, "Byte %X ac

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-22 Thread Sergei Shtepa
The 10/22/2020 13:28, Damien Le Moal wrote: > On 2020/10/22 18:43, Sergei Shtepa wrote: > > > > Maybe, but the problem is that I can't imagine how to implement > > dm-intercept yet. > > How to use dm to implement interception without changing the stack > > of block devices. We'll have to make a h

Re: sound/soc/intel/catpt/dsp.c:359:9: sparse: sparse: restricted pci_power_t degrades to integer

2020-10-22 Thread Andy Shevchenko
Select catpt > and deprecate haswell > date: 3 weeks ago > config: i386-randconfig-s002-20201022 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.3-dirty > # > https://

Re: Context expectations in ALSA

2020-10-22 Thread Mark Brown
On Thu, Oct 22, 2020 at 11:50:41AM +0200, Maxime Ripard wrote: > This is caused by the HDMI driver polling some status bit that reports > that the infoframes have been properly sent, and calling usleep_range > between each iteration[1], and that is done in our trigger callback that > seems to be r

Re: [Outreachy kernel] [PATCH 4/5] gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 07:17:56PM +0530, Sumera Priyadarsini wrote: > Using snprintf() for show() methods holds the risk of buffer overrun > as snprintf() does not know the PAGE_SIZE maximum of the temporary > buffer used to output sysfs content. > > Modify amdgpu_psp.c to use sysfs_emit() instea

[PATCH v2] sched/fair: check for idle core

2020-10-22 Thread Julia Lawall
In the case of a thread wakeup, wake_affine determines whether a core will be chosen for the thread on the socket where the thread ran previously or on the socket of the waker. This is done primarily by comparing the load of the core where th thread ran previously (prev) and the load of the waker

Problem with checkpatch.pl (commit f5f613259f3f ("checkpatch: allow not using -f with files that are in git"))

2020-10-22 Thread Christophe Leroy
Hi, Runnning ./scripts/checkpatch.pl -g HEAD, I get the following error: Global symbol "$gitroot" requires explicit package name at ./scripts/checkpatch.pl line 980. Execution of ./scripts/checkpatch.pl aborted due to compilation errors. Reverting commit f5f613259f3f ("checkpatch: allow not us

Reducing number of Espressobin DTS files

2020-10-22 Thread Pali Rohár
Hello! For Espressobin A3720 board there are currently 4 DTS files: https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts?h=for-next https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dt

Re: [PATCH v4 3/7] of/address: Introduce of_dma_get_max_cpu_address()

2020-10-22 Thread Nicolas Saenz Julienne
On Thu, 2020-10-22 at 14:23 +0200, Ard Biesheuvel wrote: > > +/** > > + * of_dma_get_max_cpu_address - Gets highest CPU address suitable for DMA > > + * @np: The node to start searching from or NULL to start from the root > > + * > > + * Gets the highest CPU physical address that is addressable by

[PATCH] powerpc/bitops: Fix possible undefined behaviour with fls() and fls64()

2020-10-22 Thread Christophe Leroy
fls() and fls64() are using __builtin_ctz() and _builtin_ctzll(). On powerpc, those builtins trivially use ctlzw and ctlzd power instructions. Allthough those instructions provide the expected result with input argument 0, __builtin_ctz() and __builtin_ctzll() are documented as undefined for value

Re: [PATCH] KVM: X86: Expose KVM_HINTS_REALTIME in KVM_GET_SUPPORTED_CPUID

2020-10-22 Thread Paolo Bonzini
On 22/10/20 15:31, Xiaoyao Li wrote: >> >> It's common for userspace to copy all supported CPUID bits to >> KVM_SET_CPUID2, I don't think this is the right behavior for >> KVM_HINTS_REALTIME. > > It reminds of X86_FEATURE_WAITPKG, which is added to supported CPUID > recently as a fix but QEMU expo

Re: Question on io-wq

2020-10-22 Thread Jens Axboe
On 10/22/20 3:02 AM, Zhang,Qiang wrote: > > Hi Jens Axboe > > There are some problem in 'io_wqe_worker' thread, when the > 'io_wqe_worker' be create and Setting the affinity of CPUs in NUMA > nodes, due to CPU hotplug, When the last CPU going down, the > 'io_wqe_worker' thread will run anywhe

Re: [PATCH 4/4] clk: renesas: r8a774c0: Add RPC clocks

2020-10-22 Thread Geert Uytterhoeven
Hi Prabhakar, On Fri, Oct 16, 2020 at 2:17 PM Lad Prabhakar wrote: > Describe the RPCSRC internal clock and the RPC[D2] clocks derived from it, > as well as the RPC-IF module clock, in the RZ/G2E (R8A774C0) CPG/MSSR > driver. > > Inspired by commit 94e3935b5756 ("clk: renesas: r8a77980: Add RPC c

Re: sound/soc/intel/catpt/dsp.c:359:9: sparse: sparse: restricted pci_power_t degrades to integer

2020-10-22 Thread Bjorn Helgaas
edbb4250b1e9248c308fb63b805 > > commit: 6cbfa11d2694b8a1e46d6834fb9705d5589e3ef1 ASoC: Intel: Select catpt > > and deprecate haswell > > date: 3 weeks ago > > config: i386-randconfig-s002-20201022 (attached as .config) > > compiler: gcc-9 (Debian 9.3.0-15)

Re: [Outreachy kernel][PATCH 0/5] drm/amdgpu: Replace snprintf() with sysfs_emit

2020-10-22 Thread Daniel Vetter
On Thu, Oct 22, 2020 at 07:07:50PM +0530, Sumera Priyadarsini wrote: > Using snprintf() for show() methods holds the risk of buffer overrun > as snprintf() does not know the PAGE_SIZE maximum of the temporary > buffer used to output sysfs content. > > This patchset is a series of Coccinelle cleanu

Re: [RFC 1/2] printk: Add kernel parameter: mute_console

2020-10-22 Thread Guenter Roeck
On 10/22/20 6:10 AM, John Ogness wrote: > On 2020-10-22, Petr Mladek wrote: >> diff --git a/Documentation/admin-guide/kernel-parameters.txt >> b/Documentation/admin-guide/kernel-parameters.txt >> index 02d4adbf98d2..52b9e7f5468d 100644 >> --- a/Documentation/admin-guide/kernel-parameters.txt >> +

Re: [PATCH 3/3] PM: runtime: Resume the device earlier in __device_release_driver()

2020-10-22 Thread Rafael J. Wysocki
On Thu, Oct 22, 2020 at 3:40 PM chenxiang (M) wrote: > > Hi Rafael, > > 在 2020/10/22 3:14, Rafael J. Wysocki 写道: > > From: Rafael J. Wysocki > > > > Since the device is resumed from runtime-suspend in > > __device_release_driver() anyway, it is better to do that before > > looking for busy manage

Re: [PATCH] checkpatch: fix false positive for REPEATED_WORD warning

2020-10-22 Thread Aditya
On 22/10/20 12:42 am, Lukas Bulwahn wrote: > On Wed, Oct 21, 2020 at 8:25 PM Aditya wrote: >> >> On 21/10/20 11:35 pm, Joe Perches wrote: >>> On Wed, 2020-10-21 at 23:25 +0530, Aditya wrote: Thanks for your feedback. I ran a manual check using this approach over v5.6..v5.8. The nega

Re: [PATCH v1 1/5] seq_file: Introduce DEFINE_STORE_ATTRIBUTE() helper macro

2020-10-22 Thread Andy Shevchenko
On Thu, Oct 22, 2020 at 04:39:53PM +0800, Luo Jiaxing wrote: > We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute > for read-only file, but we found many of drivers want a helper marco for > read-write file too. I would expect that DEFINE_STORE maps to WO attribute... For R

Re: [RFC 1/2] printk: Add kernel parameter: mute_console

2020-10-22 Thread Guenter Roeck
On 10/22/20 6:45 AM, Steven Rostedt wrote: > On Thu, 22 Oct 2020 13:42:27 +0200 > Petr Mladek wrote: > >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c >> index fe64a49344bf..63fb96630767 100644 >> --- a/kernel/printk/printk.c >> +++ b/kernel/printk/printk.c >> @@ -1207,6 +1207,19

Re: RFC 2/2] printk: Restore and document obsolete ways to disable console output

2020-10-22 Thread Guenter Roeck
On 10/22/20 4:42 AM, Petr Mladek wrote: > The commit 48021f98130880dd7 ("printk: handle blank console arguments > passed in.") prevented crash caused by empty console= parameter value. > > Unfortunately, this value is widely used on Chromebooks to disable > the console output. The above commit cau

Re: [PATCHv2 2/4] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf()

2020-10-22 Thread Sai Prakash Ranjan
On 2020-10-22 19:04, Peter Zijlstra wrote: On Thu, Oct 22, 2020 at 06:19:37PM +0530, Sai Prakash Ranjan wrote: On 2020-10-22 17:02, Peter Zijlstra wrote: > On Thu, Oct 22, 2020 at 04:27:52PM +0530, Sai Prakash Ranjan wrote: > > > Looking at the ETR and other places in the kernel, ETF and the > >

Re: [PATCH v3] HID: i2c-hid: add polling mode based on connected GPIO chip's pin status

2020-10-22 Thread Barnabás Pőcze
Hi, I think this looks a lot better than the first version, the issues around suspend/resume are sorted out as far as I can see. However, I still have a couple comments, mainly minor ones. > [...] > +/* polling mode */ > +#define I2C_HID_POLLING_DISABLED 0 > +#define I2C_HID_POLLING_GPIO_PIN 1

[PATCH][next] docs/vm: trivial fixes to several spelling mistakes

2020-10-22 Thread Colin King
From: Colin Ian King Fix several spelling mistakes in vm documentation. Signed-off-by: Colin Ian King --- Documentation/vm/mmu_notifier.rst | 2 +- Documentation/vm/page_migration.rst | 2 +- Documentation/vm/page_owner.rst | 2 +- Documentation/vm/slub.rst | 2 +- 4 files chan

[PATCH] Bluetooth: btrtl: Ask 8821C to drop old firmware after shutdown

2020-10-22 Thread Kai-Heng Feng
Some platforms keep USB power even when they are powered off and in S5, this makes Realtek 8821C keep its firmware even after a cold boot, and make 8821C never load new firmware. So use vendor specific HCI command to ask 8821C drop its firmware after system shutdown. Newer firmware doesn't have t

Re: [PATCH] KVM: X86: Expose KVM_HINTS_REALTIME in KVM_GET_SUPPORTED_CPUID

2020-10-22 Thread Xiaoyao Li
On 10/22/2020 10:06 PM, Paolo Bonzini wrote: On 22/10/20 15:31, Xiaoyao Li wrote: It's common for userspace to copy all supported CPUID bits to KVM_SET_CPUID2, I don't think this is the right behavior for KVM_HINTS_REALTIME. It reminds of X86_FEATURE_WAITPKG, which is added to supported CPUID

Re: Reducing number of Espressobin DTS files

2020-10-22 Thread Andrew Lunn
> For example, Turris MOX board which is also A3720 based has optional > SDIO module which can be plugged / unplugged, standard variant is sold > without it and in DTS file is this node always enabled: I think the Turris has quite a sophisticated bootloader which manipulates the DT to fit the hard

RE: sound/soc/intel/catpt/dsp.c:359:9: sparse: sparse: restricted pci_power_t degrades to integer

2020-10-22 Thread Rojewski, Cezary
linux.git >>> master >>> head: f804b3159482eedbb4250b1e9248c308fb63b805 >>> commit: 6cbfa11d2694b8a1e46d6834fb9705d5589e3ef1 ASoC: Intel: Select catpt >>> and deprecate haswell >>> date: 3 weeks ago >>> config: i386-randconfig-s002-2020

Re: [RFC PATCH net-next 7/9] net: dsa: microchip: ksz9477: add hardware time stamping support

2020-10-22 Thread Richard Cochran
On Thu, Oct 22, 2020 at 02:32:43PM +0300, Vladimir Oltean wrote: > On Thu, Oct 22, 2020 at 01:11:40PM +0200, Christian Eggers wrote: > > > it seems that "moving" the timestamp back to the tail tag on TX is not > > required anymore. Keeping the RX timestamp simply in the correction > > field (negat

[PATCH] sched/deadline: remove the param struct rq in pick_next_dl_entity()

2020-10-22 Thread Hui Su
we can get the next dl_entity just from struct dl_rq, and do not need the param struct rq. So remove it. Like the change: https://lkml.org/lkml/2020/9/29/2030 Signed-off-by: Hui Su --- kernel/sched/deadline.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/sched/d

Re: [PATCH] checkpatch: fix false positive for REPEATED_WORD warning

2020-10-22 Thread Joe Perches
On Thu, 2020-10-22 at 19:51 +0530, Aditya wrote: > > > Alright Sir. Joe is fine, sir isn't necessary. > Hi Sir > I have implemented my solution. Should I send the patch in reply to > this mail or as a different mail? Also should I label it as v2? I have > also addressed the warnings out of list co

Re: Problem with checkpatch.pl (commit f5f613259f3f ("checkpatch: allow not using -f with files that are in git"))

2020-10-22 Thread Joe Perches
On Thu, 2020-10-22 at 15:59 +0200, Christophe Leroy wrote: > Hi, > > Runnning ./scripts/checkpatch.pl -g HEAD, I get the following error: > > Global symbol "$gitroot" requires explicit package name at > ./scripts/checkpatch.pl line 980. > Execution of ./scripts/checkpatch.pl aborted due to compi

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 04:28:20PM +0200, Arnd Bergmann wrote: > On Thu, Oct 22, 2020 at 3:50 PM Greg KH wrote: > > On Thu, Oct 22, 2020 at 02:57:59PM +0200, Greg KH wrote: > > > On Thu, Oct 22, 2020 at 02:42:24PM +0200, David Hildenbrand wrote: > > > > > struct iovec *iovec_from_user(const stru

Re: Reducing number of Espressobin DTS files

2020-10-22 Thread Pali Rohár
On Thursday 22 October 2020 16:29:00 Andrew Lunn wrote: > > For example, Turris MOX board which is also A3720 based has optional > > SDIO module which can be plugged / unplugged, standard variant is sold > > without it and in DTS file is this node always enabled: > > I think the Turris has quite a

Re: [PATCH] KVM: X86: Expose KVM_HINTS_REALTIME in KVM_GET_SUPPORTED_CPUID

2020-10-22 Thread Paolo Bonzini
On 22/10/20 16:28, Xiaoyao Li wrote: > On 10/22/2020 10:06 PM, Paolo Bonzini wrote: >> On 22/10/20 15:31, Xiaoyao Li wrote: It's common for userspace to copy all supported CPUID bits to KVM_SET_CPUID2, I don't think this is the right behavior for KVM_HINTS_REALTIME. >>> >>> It r

[PATCH v2] checkpatch: fix false positives in REPEATED_WORD warning

2020-10-22 Thread Aditya Srivastava
Presence of hexadecimal address or symbol results in false warning message by checkpatch.pl. For example, running checkpatch on commit b8ad540dd4e4 ("mptcp: fix memory leak in mptcp_subflow_create_socket()") results in warning: WARNING:REPEATED_WORD: Possible repeated word: 'ff' 00 00 00 00 0

[PATCH] fuse: fix potential accessing NULL pointer problem in fuse_send_init()

2020-10-22 Thread Zhiqiang Liu
In fuse_send_init func, ia is allocated by calling kzalloc func, and we donot check whether ia is NULL before using it. Thus, if allocating ia fails, accessing NULL pointer problem will occur. Here, we will call process_init_reply func if ia is NULL. Fixes: 615047eff108 ("fuse: convert init to

Re: [PATCH] mm,thp,shmem: limit shmem THP alloc gfp_mask

2020-10-22 Thread Vlastimil Babka
On 10/22/20 5:48 AM, Rik van Riel wrote: The allocation flags of anonymous transparent huge pages can be controlled through the files in /sys/kernel/mm/transparent_hugepage/defrag, which can help the system from getting bogged down in the page reclaim and compaction code when many THPs are gettin

Re: linux-next: Tree for Oct 22 (mlx5)

2020-10-22 Thread Randy Dunlap
On 10/21/20 8:41 PM, Stephen Rothwell wrote: > Hi all, > > Since the merge window is open, please do not add any v5.11 material to > your linux-next included branches until after v5.10-rc1 has been released. > > Changes since 20201021: > on x86_64: when CONFIG_IPV6 is not set/enabled: In file

Re: [PATCH] mm,thp,shmem: limit shmem THP alloc gfp_mask

2020-10-22 Thread Vlastimil Babka
On 10/22/20 4:51 PM, Vlastimil Babka wrote: On 10/22/20 5:48 AM, Rik van Riel wrote: The allocation flags of anonymous transparent huge pages can be controlled through the files in /sys/kernel/mm/transparent_hugepage/defrag, which can help the system from getting bogged down in the page reclaim

<    1   2   3   4   5   6   7   8   9   10   >