Re: [PATCH] x86/perf: Fix guest_get_msrs static call if there is no PMU

2021-03-09 Thread Peter Zijlstra
On Tue, Mar 09, 2021 at 08:46:49AM +0100, Peter Zijlstra wrote: > On Mon, Mar 08, 2021 at 12:40:44PM -0800, Sean Christopherson wrote: > > On Mon, Mar 08, 2021, Peter Zijlstra wrote: > > > > Given the one user in atomic_switch_perf_msrs() that should work because > > > it doesn't seem to care

[patch 13/14] firewire: ohci: Use tasklet_disable_in_atomic() where required

2021-03-09 Thread Thomas Gleixner
From: Sebastian Andrzej Siewior tasklet_disable() is invoked in several places. Some of them are in atomic context which prevents a conversion of tasklet_disable() to a sleepable function. The atomic callchains are: ar_context_tasklet() ohci_cancel_packet() tasklet_disable() ...

[patch 11/14] atm: eni: Use tasklet_disable_in_atomic() in the send() callback

2021-03-09 Thread Thomas Gleixner
From: Sebastian Andrzej Siewior The atmdev_ops::send callback which calls tasklet_disable() is invoked with bottom halfs disabled from net_device_ops::ndo_start_xmit(). All other invocations of tasklet_disable() in this driver happen in preemptible context. Change the send() call to use

[PATCH] kernel: kexec_file: fix error return code of kexec_calculate_store_digests()

2021-03-09 Thread Jia-Ju Bai
When vzalloc() returns NULL to sha_regions, no error return code of kexec_calculate_store_digests() is assigned. To fix this bug, ret is assigned with -ENOMEM in this case. Fixes: a43cac0d9dc2 ("kexec: split kexec_file syscall code to kexec_file.c") Reported-by: TOTE Robot Signed-off-by: Jia-Ju

[PATCH] objtool: Fix a memory leak bug

2021-03-09 Thread Jiapeng Chong
Fix the following cppcheck warnings: tools/objtool/check.c(1102): error: Memory leak: orig_alt_group. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- tools/objtool/check.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index

[patch 14/14] tasklets: Switch tasklet_disable() to the sleep wait variant

2021-03-09 Thread Thomas Gleixner
-- NOT FOR IMMEDIATE MERGING -- Now that all users of tasklet_disable() are invoked from sleepable context, convert it to use tasklet_unlock_wait() which might sleep. Signed-off-by: Thomas Gleixner --- include/linux/interrupt.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ---

[patch 05/14] tasklets: Replace spin wait in tasklet_unlock_wait()

2021-03-09 Thread Thomas Gleixner
From: Peter Zijlstra tasklet_unlock_wait() spin waits for TASKLET_STATE_RUN to be cleared. This is wasting CPU cycles in a tight loop which is especially painful in a guest when the CPU running the tasklet is scheduled out. tasklet_unlock_wait() is invoked from tasklet_kill() which is used in

[patch 06/14] tasklets: Replace spin wait in tasklet_kill()

2021-03-09 Thread Thomas Gleixner
From: Peter Zijlstra tasklet_kill() spin waits for TASKLET_STATE_SCHED to be cleared invoking yield() from inside the loop. yield() is an ill defined mechanism and the result might still be wasting CPU cycles in a tight loop which is especially painful in a guest when the CPU running the tasklet

[patch 04/14] tasklets: Use spin wait in tasklet_disable() temporarily

2021-03-09 Thread Thomas Gleixner
To ease the transition use spin waiting in tasklet_disable() until all usage sites from atomic context have been cleaned up. Signed-off-by: Thomas Gleixner --- include/linux/interrupt.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/include/linux/interrupt.h +++

[patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT

2021-03-09 Thread Thomas Gleixner
tasklet_unlock_spin_wait() spin waits for the TASKLET_STATE_SCHED bit in the tasklet state to be cleared. This works on !RT nicely because the corresponding execution can only happen on a different CPU. On RT softirq processing is preemptible, therefore a task preempting the softirq processing

Re: [PATCH] memstick: core: fix error return code of mspro_block_resume()

2021-03-09 Thread Ulf Hansson
On Fri, 5 Mar 2021 at 03:14, Jia-Ju Bai wrote: > > When mspro_block_init_card() fails, no error return code of > mspro_block_resume() is assigned. > To fix this bug, rc is assigned with the return value of > mspro_block_init_card(), and then rc is checked. > > Reported-by: TOTE Robot >

[PATCH] kernel: profile: fix error return code of create_proc_profile()

2021-03-09 Thread Jia-Ju Bai
When proc_create() returns NULL to entry, no error return code of create_proc_profile() is assigned. To fix this bug, err is assigned with -ENOMEM in this case. Fixes: e722d8daafb9 ("profile: Convert to hotplug state machine") Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai ---

Re: [PATCH] mmc: via-sdmmc: remove unneeded variable 'ret'

2021-03-09 Thread Ulf Hansson
On Tue, 9 Mar 2021 at 07:48, Yang Li wrote: > > Fix the following coccicheck warning: > ./drivers/mmc/host/via-sdmmc.c:1274:5-8: Unneeded variable: "ret". > Return "0" on line 1295 > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Applied for next, thanks! Kind regards Uffe > --- >

Re: [PATCH 2/2] KVM: arm64: Skip the cache flush when coalescing tables into a block

2021-03-09 Thread wangyanan (Y)
On 2021/3/9 16:43, Marc Zyngier wrote: On Tue, 09 Mar 2021 08:34:43 +, "wangyanan (Y)" wrote: On 2021/3/9 0:34, Will Deacon wrote: On Mon, Jan 25, 2021 at 10:10:44PM +0800, Yanan Wang wrote: After dirty-logging is stopped for a VM configured with huge mappings, KVM will recover the

Re: [PATCH 3/3] clk: socfpga: allow compile testing of Stratix 10 / Agilex clocks

2021-03-09 Thread Krzysztof Kozlowski
On 09/03/2021 09:49, Krzysztof Kozlowski wrote: > On 08/03/2021 19:23, Krzysztof Kozlowski wrote: >> The Stratix 10 / Agilex / N5X clocks do not use anything other >> than OF or COMMON_CLK so they should be compile testable on most of >> the platforms. >> >> Signed-off-by: Krzysztof Kozlowski

Re: [f2fs-dev] [PATCH v2] f2fs: add sysfs nodes to get accumulated compression info

2021-03-09 Thread Chao Yu
On 2021/3/5 10:24, Daeho Jeong wrote: From: Daeho Jeong Added acc_compr_inodes to show accumulated compressed inode count and acc_compr_blocks to show accumulated secured block count with I noticed that these stat numbers are recorded in extra reserved area in hot node curseg journal, the

Re: linux-next: Signed-off-by missing for commit in the gpio-brgl-fixes tree

2021-03-09 Thread Andy Shevchenko
On Mon, Mar 08, 2021 at 11:01:44PM +0200, Andy Shevchenko wrote: > On Mon, Mar 8, 2021 at 10:34 PM Stephen Rothwell > wrote: > > On Tue, 9 Mar 2021 07:26:20 +1100 Stephen Rothwell > > wrote: > > > > > > Commits > > > > > > eb441337c714 ("gpio: pca953x: Set IRQ type when handle Intel Galileo

[BUG] Possible bug of missing error return code in __ext4_journalled_writepage()

2021-03-09 Thread Jia-Ju Bai
In __ext4_journalled_writepage():     ..     inode_bh = ext4_journalled_write_inline_data(inode, len, page);     if (inode_bh == NULL)     goto out;     .. out:     unlock_page(page); out_no_pagelock:     brelse(inode_bh);     return ret; When inode_bh is NULL, ret is not assigned

Re: [PATCH] btrfs: turn btrfs_destroy_delayed_refs() into void function

2021-03-09 Thread Anand Jain
On 9/3/21 5:32 pm, Yang Li wrote: This function always return '0' and no callers use the return value. So make it a void function. This eliminates the following coccicheck warning: ./fs/btrfs/disk-io.c:4522:5-8: Unneeded variable: "ret". Return "0" on line 4530 Reported-by: Abaci Robot

RE: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config"

2021-03-09 Thread Li, Meng
> -Original Message- > From: Lee Jones > Sent: Tuesday, March 9, 2021 5:43 PM > To: Li, Meng > Cc: Marc Zyngier ; linux-kernel@vger.kernel.org; > a...@arndb.de; Hao, Kexin > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for > regmap_config" > > [Please note:

Re: [PATCH 5/5] powercap/drivers/dtpm: Scale the power with the load

2021-03-09 Thread Lukasz Luba
Hi Daniel, I've started reviewing the series, please find some comments below. On 3/1/21 9:21 PM, Daniel Lezcano wrote: Currently the power consumption is based on the current OPP power assuming the entire performance domain is fully loaded. That gives very gross power estimation and we can

Re: [PATCH v2 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-09 Thread kernel test robot
Hi Minchan, I love your patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.12-rc2 next-20210309] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH v3 0/4] Use obj_cgroup APIs to charge kmem pages

2021-03-09 Thread Muchun Song
Since Roman series "The new cgroup slab memory controller" applied. All slab objects are charged with the new APIs of obj_cgroup. The new APIs introduce a struct obj_cgroup to charge slab objects. It prevents long-living objects from pinning the original memory cgroup in the memory. But there are

[PATCH 3/3] ASoC: codecs: wcd934x: add a sanity check in set channel map

2021-03-09 Thread Srinivas Kandagatla
set channel map can be passed with a channel maps, however if the number of channels that are passed are more than the actual supported channels then we would be accessing array out of bounds. So add a sanity check to validate these numbers! Fixes: a61f3b4f476e ("ASoC: wcd934x: add support to

[PATCH 2/3] ASoC: qcom: sdm845: Fix array out of range on rx slim channels

2021-03-09 Thread Srinivas Kandagatla
WCD934x has only 13 RX SLIM ports however we are setting it as 16 in set_channel_map, this will lead to array out of bounds error! Orignally caught by enabling USBAN array out of bounds check: Fixes: 5caf64c633a3 ("ASoC: qcom: sdm845: add support to DB845c and Lenovo Yoga") Reported-by: John

[PATCH 0/3] ASoC: sdm845: array out of bound issues

2021-03-09 Thread Srinivas Kandagatla
During testing John Stultz and Amit reported few array our bound issues after enabling bound sanitizer This patch series attempts to fix those! Srinivas Kandagatla (3): ASoC: qcom: sdm845: Fix array out of bounds access ASoC: qcom: sdm845: Fix array out of range on rx slim channels ASoC:

[PATCH 1/3] ASoC: qcom: sdm845: Fix array out of bounds access

2021-03-09 Thread Srinivas Kandagatla
Static analysis Coverity had detected a potential array out-of-bounds write issue due to the fact that MAX AFE port Id was set to 16 instead of using AFE_PORT_MAX macro. Fix this by properly using AFE_PORT_MAX macro. Fixes: 1b93a8843147 ("ASoC: qcom: sdm845: handle soundwire stream")

[PATCH] gpio: wcd934x: Fix shift-out-of-bounds error

2021-03-09 Thread Srinivas Kandagatla
bit-mask for pins 0 to 4 is BIT(0) to BIT(4) however we ended up with BIT(n - 1) which is not right, and this was caught by below usban check UBSAN: shift-out-of-bounds in /workspace/dev/linux/drivers/gpio/gpio-wcd934x.c:34:14 qcom-q6v5-mss 408.remoteproc: failed to acquire pdc reset

RE: [PATCH v1 0/2] Watchdog Core Global Parameters

2021-03-09 Thread Flavio Suligoi
Hi Guenter, > > Instead of adding this kind of module parameters independently to each > > driver, the best solution is declaring each feature only once, in the > > watchdog core. > > > > I agree to and like the idea, but I don't see the point of letting drivers > opt in > or opt out. This adds

Re: [PATCH 5.11 00/44] 5.11.5-rc1 review

2021-03-09 Thread Greg KH
On Mon, Mar 08, 2021 at 02:29:53PM -0800, Guenter Roeck wrote: > On Mon, Mar 08, 2021 at 01:34:38PM +0100, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.11.5 release. > > There are 44 patches in this series, all will

[PATCH] dt-bindings: spi: Convert NXP flexspi to json schema

2021-03-09 Thread Kuldeep Singh
Convert the NXP FlexSPI binding to DT schema format using json-schema. Signed-off-by: Kuldeep Singh --- .../bindings/spi/nxp,spi-nxp-fspi.yaml| 85 +++ .../devicetree/bindings/spi/spi-nxp-fspi.txt | 43 -- MAINTAINERS | 2 +- 3

Re: Linux 5.10.22

2021-03-09 Thread gregkh
From: Greg Kroah-Hartman diff --git a/Makefile b/Makefile index 98ae9007e8a5..12a2a7271fcb 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 VERSION = 5 PATCHLEVEL = 10 -SUBLEVEL = 21 +SUBLEVEL = 22 EXTRAVERSION = NAME = Dare mighty things diff --git

Linux 5.10.22

2021-03-09 Thread gregkh
From: Greg Kroah-Hartman I'm announcing the release of the 5.10.22 kernel. All users of the 5.10 kernel series must upgrade. The updated 5.10.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.10.y and can be browsed at the normal

Re: Linux 5.11.5

2021-03-09 Thread gregkh
From: Greg Kroah-Hartman diff --git a/Makefile b/Makefile index cb9a8e823951..1673c12fb4b3 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 VERSION = 5 PATCHLEVEL = 11 -SUBLEVEL = 4 +SUBLEVEL = 5 EXTRAVERSION = NAME =  Valentine's Day Edition  diff

Linux 5.11.5

2021-03-09 Thread gregkh
From: Greg Kroah-Hartman I'm announcing the release of the 5.11.5 kernel. All users of the 5.11 kernel series must upgrade. The updated 5.11.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.11.y and can be browsed at the normal

Re: [PATCH 1/1] RISC-V: correct enum sbi_ext_rfence_fid

2021-03-09 Thread Heinrich Schuchardt
On 08.03.21 11:55, Anup Patel wrote: > On Mon, Mar 8, 2021 at 1:19 PM Atish Patra wrote: >> >> On Sat, Mar 6, 2021 at 4:12 AM Anup Patel wrote: >>> >>> On Sat, Mar 6, 2021 at 11:19 AM Heinrich Schuchardt >>> wrote: The constants in enum sbi_ext_rfence_fid should match the SBI

Re: [PATCH v2 3/3] netfilter: x_tables: Use correct memory barriers.

2021-03-09 Thread Florian Westphal
Mark Tomlinson wrote: > When a new table value was assigned, it was followed by a write memory > barrier. This ensured that all writes before this point would complete > before any writes after this point. However, to determine whether the > rules are unused, the sequence counter is read. To

Re: [RESEND PATCH v5 2/4] arm64: dts: rk3399: Add dfi and dmc nodes.

2021-03-09 Thread Johan Jonker
Hi Daniel, Some comments. Have a look if it's useful or that you disagree with. New nodes should be verifiable if possible. Especially with so many properties. Could you convert rockchip-dfi.txt and rk3399_dmc.txt to yaml instead of changing old txt documents? Add rockchip-dfi.yaml and

[PATCH] kdb: Refactor kdb_defcmd implementation

2021-03-09 Thread Sumit Garg
Switch to use kdbtab_t instead of separate struct defcmd_set since now we have kdb_register_table() to register pre-allocated kdb commands. Also, switch to use a linked list for sub-commands instead of dynamic array which makes traversing the sub-commands list simpler. Suggested-by: Daniel

Re: [PATCH v2 2/2] mm/memcg: set memcg when split page

2021-03-09 Thread Matthew Wilcox
On Tue, Mar 09, 2021 at 10:02:00AM +0100, Michal Hocko wrote: > On Mon 08-03-21 21:02:25, Matthew Wilcox wrote: > > On Thu, Mar 04, 2021 at 07:40:53AM +, Zhou Guanghui wrote: > > > For example, when alloc_pages_exact is used to allocate 1MB continuous > > > physical memory, 2MB is

Re: [PATCH v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line

2021-03-09 Thread Rodolfo Giometti
On 09/03/21 12:28, Andy Shevchenko wrote: > On Tue, Mar 09, 2021 at 11:51:58AM +0100, Rodolfo Giometti wrote: >> On 09/03/21 11:47, Andy Shevchenko wrote: >>> +Cc: Greg >>> >>> On Fri, Feb 26, 2021 at 07:03:32PM +0200, Andy Shevchenko wrote: On Tue, Feb 16, 2021 at 01:31:48PM +0200, Andy

Re: [RFT PATCH v3 12/27] of/address: Add infrastructure to declare MMIO as non-posted

2021-03-09 Thread Arnd Bergmann
On Tue, Mar 9, 2021 at 12:14 PM Linus Walleij wrote: > > On Mon, Mar 8, 2021 at 10:13 PM Rob Herring wrote: > > On Mon, Mar 08, 2021 at 09:29:54PM +0100, Arnd Bergmann wrote: > > > > This is obviously more work for the drivers, but at least it keeps > > > the common code free of the hack while

[RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-09 Thread Aditya Srivastava
Starting commented lines in a file mostly contains comments describing license, copyright or general information about the file. E.g., in sound/pci/ctxfi/ctresource.c, initial comment lines describe its copyright and other related file informations. But as kernel-doc reads these lines, it

Re: [PATCH 06/10] staging: greybus: spilib: use 'spi_delay_to_ns' for getting xfer delay

2021-03-09 Thread Greg KH
On Mon, Mar 08, 2021 at 04:54:58PM +0200, Alexandru Ardelean wrote: > The intent is the removal of the 'delay_usecs' field from the > spi_transfer struct, as there is a 'delay' field that does the same > thing. > > The spi_delay_to_ns() can be used to get the transfer delay. It works by > using

[PATCH 1/2] arm64: dts: ti: k3-am64-main: Add OSPI node

2021-03-09 Thread Vignesh Raghavendra
AM64 SoC has a single Octal SPI (OSPI) instance under Flash SubSystem (FSS). Add DT entry for the same. Signed-off-by: Vignesh Raghavendra --- arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 25 1 file changed, 25 insertions(+) diff --git

[PATCH 2/2] arm64: dts: ti: k3-am64-evm/sk: Add OSPI flash DT node

2021-03-09 Thread Vignesh Raghavendra
Both AM64 EVM and SK have a 512Mb S28HS512T Octal SPI NOR flash. Add DT node for the same. Signed-off-by: Vignesh Raghavendra --- Bootlog: SK: https://pastebin.ubuntu.com/p/gvxg7cFrXH/ EVM: https://pastebin.ubuntu.com/p/jb39GqkB78/ arch/arm64/boot/dts/ti/k3-am642-evm.dts | 36

[PATCH -next] ASoC: rt715-sdca: Remove unused including

2021-03-09 Thread 'Wei Yongjun
From: Wei Yongjun Remove including that don't need it. Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- sound/soc/codecs/rt715-sdca.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/rt715-sdca.c b/sound/soc/codecs/rt715-sdca.c index 92ad6fa408ec..20528afbdc57

Re: [mm/filemap] cbd59c48ae: fxmark.hdd_ext4_no_jnl_DRBM_9_bufferedio.works/sec -7.6% regression

2021-03-09 Thread Matthew Wilcox
On Tue, Mar 09, 2021 at 03:57:06PM +0800, kernel test robot wrote: > FYI, we noticed a -7.6% regression of > fxmark.hdd_ext4_no_jnl_DRBM_9_bufferedio.works/sec due to commit: > > commit: cbd59c48ae2bcadc4a7599c29cf32fd3f9b78251 ("mm/filemap: use head pages > in generic_file_buffered_read") >

[PATCH -next] ASoC: rt715-sdca: Fix return value check in rt715_sdca_sdw_probe()

2021-03-09 Thread 'Wei Yongjun
From: Wei Yongjun In case of error, the function devm_regmap_init_sdw_mbq() and devm_regmap_init_sdw() returns ERR_PTR() not NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 393c52d2d109 ("ASoC: rt715-sdca: Add RT715 sdca vendor-specific driver")

Re: [patch V3 6/6] rcu: Prevent false positive softirq warning on RT

2021-03-09 Thread Frederic Weisbecker
On Tue, Mar 09, 2021 at 09:55:58AM +0100, Thomas Gleixner wrote: > Soft interrupt disabled sections can legitimately be preempted or schedule > out when blocking on a lock on RT enabled kernels so the RCU preempt check > warning has to be disabled for RT kernels. > > Signed-off-by: Thomas

Re: [PATCH v2 0/4] enable flexspi support on imx8mp

2021-03-09 Thread Heiko Schocher
Hello Marco, On 09.03.21 09:19, Marco Felsch wrote: > Hi Heiko, > > On 21-03-09 06:31, Heiko Schocher wrote: >> >> This series enables support for the SPI NOR on the >> imx8mp based phyboard-pollux-rdk board. >> >> Patches new in v2: >> "spi: fspi: enable fspi driver for on imx8mp" >> which adds

Re: [PATCH] powerpc: Fix missing declaration of [en/dis]able_kernel_vsx()

2021-03-09 Thread Christophe Leroy
Le 09/03/2021 à 09:45, Geert Uytterhoeven a écrit : Hi Christophe, On Tue, Mar 9, 2021 at 9:39 AM Christophe Leroy wrote: Add stub instances of enable_kernel_vsx() and disable_kernel_vsx() when CONFIG_VSX is not set, to avoid following build failure. CC [M]

[patch 00/14] tasklets: Replace the spin wait loops and make it RT safe

2021-03-09 Thread Thomas Gleixner
This is a follow up to the review comments of the series which makes softirq processing PREEMPT_RT safe: https://lore.kernel.org/r/20201207114743.gk3...@hirez.programming.kicks-ass.net Peter suggested to replace the spin waiting in tasklet_disable() and tasklet_kill() with wait_event(). This

[patch 01/14] tasklets: Replace barrier() with cpu_relax() in tasklet_unlock_wait()

2021-03-09 Thread Thomas Gleixner
A barrier() in a tight loop which waits for something to happen on a remote CPU is a pointless exercise. Replace it with cpu_relax() which allows HT siblings to make progress. Signed-off-by: Thomas Gleixner Tested-by: Sebastian Andrzej Siewior --- include/linux/interrupt.h |3 ++- 1 file

Re: [PATCH] powerpc: Fix missing declaration of [en/dis]able_kernel_vsx()

2021-03-09 Thread Geert Uytterhoeven
Hi Christophe, On Tue, Mar 9, 2021 at 9:39 AM Christophe Leroy wrote: > Add stub instances of enable_kernel_vsx() and disable_kernel_vsx() > when CONFIG_VSX is not set, to avoid following build failure. > > CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o > In file included

[patch 02/14] tasklets: Use static inlines for stub implementations

2021-03-09 Thread Thomas Gleixner
Inlines exist for a reason. Signed-off-by: Thomas Gleixner Tested-by: Sebastian Andrzej Siewior --- include/linux/interrupt.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h @@ -676,9 +676,9 @@ static inline void

Re: [BUG] memstick: core: missing error return code in msb_resume()

2021-03-09 Thread Ulf Hansson
On Fri, 5 Mar 2021 at 03:45, Jia-Ju Bai wrote: > > My static analysis tool reports that no error return code is assigned in > error handling code of msb_resume(). > However, many other drivers assign error return code in xxx_resume(), > such as sky2_resume() and e1000_resume(). > I wonder whether

[patch 03/14] tasklets: Provide tasklet_disable_in_atomic()

2021-03-09 Thread Thomas Gleixner
Replacing the spin wait loops in tasklet_unlock_wait() with wait_var_event() is not possible as a handful of tasklet_disable() invocations are happening in atomic context. All other invocations are in teardown paths which can sleep. Provide tasklet_disable_in_atomic() and

Re: [PATCH 1/2] locking/rwsem: Add down_write_interruptible

2021-03-09 Thread Peter Zijlstra
On Mon, Mar 08, 2021 at 03:54:55PM -0500, Zack Rusin wrote: > Add an interruptible version of down_write. It's the other > side of the already implemented down_read_interruptible. > It allows drivers which used custom locking code to > support interruptible rw semaphores to switch over > to rwsem.

[irqchip: irq/irqchip-next] dt-bindings/irq: Add compatible string for the JZ4760B

2021-03-09 Thread irqchip-bot for Paul Cercueil
The following commit has been merged into the irq/irqchip-next branch of irqchip: Commit-ID: 673433e7c288927f7244658788f203c660d7a6f6 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/673433e7c288927f7244658788f203c660d7a6f6 Author:Paul Cercueil

Re: [PATCH 1/1] drm/amdkfd: fix build error with AMD_IOMMU_V2=m

2021-03-09 Thread Arnd Bergmann
On Tue, Mar 9, 2021 at 4:23 AM Felix Kuehling wrote: > > Using 'imply AMD_IOMMU_V2' does not guarantee that the driver can link > against the exported functions. If the GPU driver is built-in but the > IOMMU driver is a loadable module, the kfd_iommu.c file is indeed > built but does not work: >

Re: [PATCH] usb: cdns3: Coherent memory allocation optimization

2021-03-09 Thread Aswath Govindraju
Hi Peter, On 09/03/21 11:09 am, Sanket Parmar wrote: > Hi Peter, > >> On 21-03-05 17:01:11, Sanket Parmar wrote: >>> Allocation of DMA coherent memory in atomic context using >>> dma_alloc_coherent() might fail on some platform. To fix it, >>> Replaced dma_alloc_coherent() with dma_pool API to

[PATCH] block: keyslot-manager: fix error return code of blk_ksm_evict_key()

2021-03-09 Thread Jia-Ju Bai
When blk_ksm_find_keyslot() returns NULL to slot, no error return code of blk_ksm_evict_key() is assigned. To fix this bug, err is assigned with -ENOENT in this case. Fixes: 1b2628397058 ("block: Keyslot Manager for Inline Encryption") Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai ---

Re: [patch 10/14] ath9k: Use tasklet_disable_in_atomic()

2021-03-09 Thread Kalle Valo
Thomas Gleixner writes: > From: Sebastian Andrzej Siewior > > All callers of ath9k_beacon_ensure_primary_slot() are preemptible / > acquire a mutex except for this callchain: > > spin_lock_bh(>sc_pcu_lock); > ath_complete_reset() > -> ath9k_calculate_summary_state() > ->

Re: [PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-09 Thread Halil Pasic
On Thu, 4 Mar 2021 12:43:44 -0500 Tony Krowiak wrote: > On the other hand, if we don't have ->kvm because something broke, > then we may be out of luck anyway. There will certainly be no > way to unregister the GISC; however, it may still be possible > to unpin the pages if we still have

Re: [PATCH 2/2] usb: cdns3: Optimize DMA request buffer allocation

2021-03-09 Thread Christoph Hellwig
On Tue, Mar 09, 2021 at 10:18:43AM +, Sanket Parmar wrote: > > On Tue, Mar 09, 2021 at 06:19:40AM +0100, Sanket Parmar wrote: > > > dma_alloc_coherent() might fail on the platform with a small DMA region. > > > > > > To avoid such failure in cdns3_prepare_aligned_request_buf(), > > >

Re: [PATCH v6 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-03-09 Thread Cristian Marussi
Hi Jonathan, On Tue, Mar 09, 2021 at 10:27:01AM +, Jonathan Cameron wrote: > On Tue, 9 Mar 2021 07:38:13 + > Cristian Marussi wrote: > > > Hi > > > > On Tue, Mar 09, 2021 at 06:37:27AM +, Sudeep Holla wrote: > > > On Mon, Mar 08, 2021 at 07:48:41PM +, Jonathan Cameron wrote:

Re: [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h

2021-03-09 Thread Thomas Bogendoerfer
On Sat, Mar 06, 2021 at 04:57:30PM +0800, zhangqing wrote: > > > On 03/06/2021 04:03 PM, Thomas Bogendoerfer wrote: > > as you are already touching mach-loongson64 files... > > > > Is there a chance you clean up that up even further ? My goal is to > > have only files in mach- files, which have

Re: [PATCH v3] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-09 Thread Thomas Bogendoerfer
On Mon, Mar 08, 2021 at 10:24:47AM +0100, Thomas Bogendoerfer wrote: > BMIPS is one of the few platforms that do change the exception base. > After commit 2dcb39645441 ("memblock: do not start bottom-up allocations > with kernel_end") we started seeing BMIPS boards fail to boot with the > built-in

Re: [PATCH 4/6] usbip: fix stub_dev usbip_sockfd_store() races leading to gpf

2021-03-09 Thread Tetsuo Handa
On 2021/03/09 1:27, Shuah Khan wrote: > Yes. We might need synchronization between events, threads, and shutdown > in usbip_host side and in connection polling and threads in vhci. > > I am also looking at the shutdown sequences closely as well since the > local state is referenced without

Re: [PATCH v4 3/5] RISC-V: Initial DTS for Microchip ICICLE board

2021-03-09 Thread Ben Dooks
On 03/03/2021 20:02, Atish Patra wrote: Add initial DTS for Microchip ICICLE board having only essential devices (clocks, sdhci, ethernet, serial, etc). The device tree is based on the U-Boot patch.

Re: [v8,5/7] PCI: mediatek-gen3: Add MSI support

2021-03-09 Thread Marc Zyngier
On Wed, 24 Feb 2021 06:11:30 +, Jianjun Wang wrote: > > Add MSI support for MediaTek Gen3 PCIe controller. > > This PCIe controller supports up to 256 MSI vectors, the MSI hardware > block diagram is as follows: > > +-+ > | GIC | >

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-09 Thread Oleksij Rempel
Hi Jonathan, On Sat, Mar 06, 2021 at 02:59:59PM +, Jonathan Cameron wrote: > On Sat, 6 Mar 2021 14:28:52 +0100 > Oleksij Rempel wrote: > > > On Fri, Mar 05, 2021 at 07:02:39PM +, Jonathan Cameron wrote: > > > On Fri, 5 Mar 2021 14:38:13 +0100 > > > Oleksij Rempel wrote: > > > > > >

Re: [PATCH] block: keyslot-manager: fix error return code of blk_ksm_evict_key()

2021-03-09 Thread Satya Tangirala
On Tue, Mar 09, 2021 at 01:18:12AM -0800, Jia-Ju Bai wrote: > When blk_ksm_find_keyslot() returns NULL to slot, no error return code > of blk_ksm_evict_key() is assigned. > To fix this bug, err is assigned with -ENOENT in this case. > > Fixes: 1b2628397058 ("block: Keyslot Manager for Inline

Re: [PATCH v2] certs: Fix wrong kconfig option used for x509_revocation_list

2021-03-09 Thread David Howells
Eric Snowberg wrote: > >> @@ -11,7 +11,7 @@ hostprogs-always-$(CONFIG_ASN1) > >> += asn1_compiler > >> hostprogs-always-$(CONFIG_MODULE_SIG_FORMAT) += sign-file > >> hostprogs-always-$(CONFIG_SYSTEM_TRUSTED_KEYRING) += extract-cert > >>

Re: [PATCH] ARM: dts: imx6ull: fix ubi filesystem mount failed

2021-03-09 Thread Fabio Estevam
Hi Dillon, On Tue, Mar 9, 2021 at 3:15 AM wrote: > > From: dillon min > > since Micron MT29F2G08ABAEAWP's ecc error management: > > |Description| Requirement > |Minimum required ECC | 4-bit ECC per 528 bytes > |Minimum ECC with internal ECC enabled

[PATCH robh next] dt-bindings: usb: add USB controller port

2021-03-09 Thread Rafał Miłecki
From: Rafał Miłecki USB bindings already allow specifying USB device hard wired to a specific controller port but they don't allow describing port on its own. This fixes: arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dt.yaml: usb@23000: port@1: 'compatible' is a required property From

[PATCH] staging: rtl8712: fixed whitespace coding style issue

2021-03-09 Thread Selvakumar Elangovan
Removed additional whitspaces and added space around the binary operator in the rtl8712_xmit.h file Signed-off-by: Selvakumar Elangovan --- drivers/staging/rtl8712/rtl8712_xmit.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_xmit.h

Re: [PATCH v5 1/8] mm: Remove special swap entry functions

2021-03-09 Thread Matthew Wilcox
On Tue, Mar 09, 2021 at 11:14:58PM +1100, Alistair Popple wrote: > -static inline struct page *migration_entry_to_page(swp_entry_t entry) > -{ > - struct page *p = pfn_to_page(swp_offset(entry)); > - /* > - * Any use of migration entries may only occur while the > - *

Re: [PATCH v3] iommu: Check dev->iommu in iommu_dev_xxx functions

2021-03-09 Thread Robin Murphy
On 2021-03-03 17:36, Shameer Kolothum wrote: The device iommu probe/attach might have failed leaving dev->iommu to NULL and device drivers may still invoke these functions resulting in a crash in iommu vendor driver code. Hence make sure we check that. Reviewed-by: Robin Murphy Fixes: 

[PATCH 04/11] PM / devfreq: bail out early if no freq changes in devfreq_set_target

2021-03-09 Thread Dong Aisheng
It's unnecessary to set the same freq again and run notifier calls. Signed-off-by: Dong Aisheng --- drivers/devfreq/devfreq.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index bf3047896e41..6e80bf70e7b3 100644 ---

[PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq

2021-03-09 Thread Dong Aisheng
Use the more accurate returned new_freq as resume_freq. It's the same as how devfreq->previous_freq was updated. Signed-off-by: Dong Aisheng --- drivers/devfreq/devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c

[PATCH 06/11] PM / devfreq: drop the unnecessary low variable initialization

2021-03-09 Thread Dong Aisheng
drop the unnecessary low variable initialization and make the return more straightforward. Signed-off-by: Dong Aisheng --- drivers/devfreq/devfreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index

Re: [PATCH 2/2] KVM: x86/mmu: Exclude the MMU_PRESENT bit from MMIO SPTE's generation

2021-03-09 Thread Paolo Bonzini
On 09/03/21 11:09, Maxim Levitsky wrote: What happens if mmio generation overflows (e.g if userspace keeps on updating the memslots)? In theory if we have a SPTE with a stale generation, it can became valid, no? I think that we should in the case of the overflow zap all mmio sptes. What do you

[PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update_stats

2021-03-09 Thread Dong Aisheng
Check .get_dev_status() in devfreq_update_stats in case it's abused when a device does not provide it. Signed-off-by: Dong Aisheng --- drivers/devfreq/governor.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h index

[PATCH 07/11] PM / devfreq: check get_dev_status before start monitor

2021-03-09 Thread Dong Aisheng
The devfreq monitor depends on the device to provide load information by .get_dev_status() to calculate the next target freq. And this will cause changing governor to simple ondemand fail if device can't support. Signed-off-by: Dong Aisheng --- drivers/devfreq/devfreq.c | 10

[PATCH 02/11] PM / devfreq: remove the invalid description for get_target_freq

2021-03-09 Thread Dong Aisheng
First of all, no_central_polling was removed since commit 7e6fdd4bad03 ("PM / devfreq: Core updates to support devices which can idle") Secondly, get_target_freq() is not only called only with update_devfreq() notified by OPP now, but also min/max freq qos notifier. So remove this invalid

[PATCH 11/11] PM / devfreq: imx8m-ddrc: drop polling_ms

2021-03-09 Thread Dong Aisheng
polling_ms is only used by simple ondemand governor which this driver can't support. Drop it to avoid confusing. Signed-off-by: Dong Aisheng --- drivers/devfreq/imx8m-ddrc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c index

[PATCH 01/11] doc: ABI: devfreq: remove invalid central_polling description

2021-03-09 Thread Dong Aisheng
no_central_polling has been removed since commit 7e6fdd4bad03 ("PM / devfreq: Core updates to support devices which can idle") Signed-off-by: Dong Aisheng --- Documentation/ABI/testing/sysfs-class-devfreq | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH 02/11] PM / devfreq: remove the invalid description for get_target_freq

2021-03-09 Thread Dong Aisheng
First of all, no_central_polling was removed since commit 7e6fdd4bad03 ("PM / devfreq: Core updates to support devices which can idle") Secondly, get_target_freq() is not only called only with update_devfreq() notified by OPP now, but also min/max freq qos notifier. So remove this invalid

[PATCH 00/11] PM / devfreq: a few small fixes and improvements

2021-03-09 Thread Dong Aisheng
A few small fixes and improvements Dong Aisheng (11): doc: ABI: devfreq: remove invalid central_polling description PM / devfreq: remove the invalid description for get_target_freq PM / devfreq: fix the wrong set_freq path for userspace governor PM / devfreq: bail out early if no freq

[PATCH 03/11] PM / devfreq: fix the wrong set_freq path for userspace governor

2021-03-09 Thread Dong Aisheng
Fix the wrong set_freq path for userspace governor. Signed-off-by: Dong Aisheng --- drivers/devfreq/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 00704efe6398..20373a893b44 100644 --- a/drivers/devfreq/Kconfig

[PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq

2021-03-09 Thread Dong Aisheng
Use the more accurate returned new_freq as resume_freq. It's the same as how devfreq->previous_freq was updated. Signed-off-by: Dong Aisheng --- drivers/devfreq/devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c

[PATCH 04/11] PM / devfreq: bail out early if no freq changes in devfreq_set_target

2021-03-09 Thread Dong Aisheng
It's unnecessary to set the same freq again and run notifier calls. Signed-off-by: Dong Aisheng --- drivers/devfreq/devfreq.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index bf3047896e41..6e80bf70e7b3 100644 ---

[PATCH 09/11] PM / devfreq: governor: optimize simpleondemand get_target_freq

2021-03-09 Thread Dong Aisheng
devfreq_simple_ondemand_data only needs to be initialized once when calling devm_devfreq_add_device. It's unnecessary to put the data check logic in the hot path (.get_target_freq()) where it will be called all the time during polling. Instead, we only check and initialize it one time during

[PATCH 03/11] PM / devfreq: fix the wrong set_freq path for userspace governor

2021-03-09 Thread Dong Aisheng
Fix the wrong set_freq path for userspace governor. Signed-off-by: Dong Aisheng --- drivers/devfreq/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 00704efe6398..20373a893b44 100644 --- a/drivers/devfreq/Kconfig

[PATCH 06/11] PM / devfreq: drop the unnecessary low variable initialization

2021-03-09 Thread Dong Aisheng
drop the unnecessary low variable initialization and make the return more straightforward. Signed-off-by: Dong Aisheng --- drivers/devfreq/devfreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index

[PATCH 07/11] PM / devfreq: check get_dev_status before start monitor

2021-03-09 Thread Dong Aisheng
The devfreq monitor depends on the device to provide load information by .get_dev_status() to calculate the next target freq. And this will cause changing governor to simple ondemand fail if device can't support. Signed-off-by: Dong Aisheng --- drivers/devfreq/devfreq.c | 10

[PATCH 10/11] PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status

2021-03-09 Thread Dong Aisheng
Current driver actually does not support simple ondemand governor as it's unable to provide device load information. So removing the unnecessary callback to avoid confusing. Right now the driver is using userspace governor by default. Signed-off-by: Dong Aisheng --- drivers/devfreq/imx8m-ddrc.c

[PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update_stats

2021-03-09 Thread Dong Aisheng
Check .get_dev_status() in devfreq_update_stats in case it's abused when a device does not provide it. Signed-off-by: Dong Aisheng --- drivers/devfreq/governor.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h index

<    1   2   3   4   5   6   7   8   9   10   >