[PATCH v6 04/30] fs: Document file_ra_state

2021-04-08 Thread David Howells
From: Matthew Wilcox (Oracle) Turn the comments into kernel-doc and improve the wording slightly. Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: David Howells Link: https://lore.kernel.org/r/20210407201857.3582797-3-wi...@infradead.org/ --- include/linux/fs.h | 24 ++

[PATCH v6 06/30] netfs: Make a netfs helper module

2021-04-08 Thread David Howells
Make a netfs helper module to manage read request segmentation, caching support and transparent huge page support on behalf of a network filesystem. Signed-off-by: David Howells Reviewed-by: Jeff Layton cc: Matthew Wilcox cc: linux...@kvack.org cc: linux-cach...@redhat.com cc: linux-...@lists.i

[PATCH v6 07/30] netfs: Documentation for helper library

2021-04-08 Thread David Howells
Add interface documentation for the netfs helper library. Signed-off-by: David Howells cc: linux...@kvack.org cc: linux-cach...@redhat.com cc: linux-...@lists.infradead.org cc: linux-...@vger.kernel.org cc: linux-c...@vger.kernel.org cc: ceph-de...@vger.kernel.org cc: v9fs-develo...@lists.sourcef

Re: [PATCH] spi: imx: add a check for speed_hz before calculating the clock

2021-04-08 Thread Mark Brown
On Thu, Apr 08, 2021 at 06:33:47PM +0800, Clark Wang wrote: > When some drivers use spi to send data, spi_transfer->speed_hz is > not assigned. If spidev->max_speed_hz is not assigned as well, it > will cause an error in configuring the clock. Please don't send new patches in reply to other thread

[PATCH v6 08/30] netfs, mm: Move PG_fscache helper funcs to linux/netfs.h

2021-04-08 Thread David Howells
Move the PG_fscache related helper funcs (such as SetPageFsCache()) to linux/netfs.h rather than linux/fscache.h as the intention is to move to a model where they're used by the network filesystem and the helper library, but not by fscache/cachefiles itself. Signed-off-by: David Howells cc: Matth

[PATCH v6 09/30] netfs, mm: Add set/end/wait_on_page_fscache() aliases

2021-04-08 Thread David Howells
Add set/end/wait_on_page_fscache() as aliases of set/end/wait_page_private_2(). These allow a page to marked with PG_fscache, the flag to be removed and waiters woken and waiting for the flag to be cleared. A ref on the page is also taken and dropped. [Linus suggested putting the fscache-themed

Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-04-08 Thread Andy Shevchenko
On Thu, Apr 08, 2021 at 03:44:57PM +0200, Jessica Yu wrote: > +++ Stephen Boyd [30/03/21 20:05 -0700]: ... > > +static void init_build_id(struct module *mod, const struct load_info *info) > > +{ > > + const Elf_Shdr *sechdr; > > + unsigned int i; > > + > > + for (i = 0; i < info->hdr->e_shn

[PATCH v6 10/30] netfs: Provide readahead and readpage netfs helpers

2021-04-08 Thread David Howells
Add a pair of helper functions: (*) netfs_readahead() (*) netfs_readpage() to do the work of handling a readahead or a readpage, where the page(s) that form part of the request may be split between the local cache, the server or just require clearing, and may be single pages and transparent hug

[PATCH v6 11/30] netfs: Add tracepoints

2021-04-08 Thread David Howells
Add three tracepoints to track the activity of the read helpers: (1) netfs/netfs_read This logs entry to the read helpers and also expansion of the range in a readahead request. (2) netfs/netfs_rreq This logs the progress of netfs_read_request objects which track read requ

[PATCH v6 12/30] netfs: Gather stats

2021-04-08 Thread David Howells
Gather statistics from the netfs interface that can be exported through a seqfile. This is intended to be called by a later patch when viewing /proc/fs/fscache/stats. Signed-off-by: David Howells Reviewed-by: Jeff Layton cc: Matthew Wilcox cc: linux...@kvack.org cc: linux-cach...@redhat.com cc

[PATCH v6 13/30] netfs: Add write_begin helper

2021-04-08 Thread David Howells
Add a helper to do the pre-reading work for the netfs write_begin address space op. Changes v6: - Fixed a missing rreq put in netfs_write_begin()[3]. - Use DEFINE_READAHEAD()[4]. v5: - Made the wait for PG_fscache in netfs_write_begin() killable[2]. v4: - Added flag to netfs_subreq_terminated()

Re: [PATCH] afs: fix no return statement in function returning non-void

2021-04-08 Thread David Howells
Zheng Zengkai wrote: > static int afs_dir_set_page_dirty(struct page *page) > { > BUG(); /* This should never happen. */ > + return 0; > } That shouldn't be necessary. BUG() should be marked as 'no return' to the compiler. What arch and compiler are you using? David

[PATCH v6 14/30] netfs: Define an interface to talk to a cache

2021-04-08 Thread David Howells
Add an interface to the netfs helper library for reading data from the cache instead of downloading it from the server and support for writing data just downloaded or cleared to the cache. The API passes an iov_iter to the cache read/write routines to indicate the data/buffer to be used. This is

Re: [PATCH v1 1/2] iommu/tegra-smmu: Defer attachment of display clients

2021-04-08 Thread Dmitry Osipenko
08.04.2021 15:40, Thierry Reding пишет: > On Mon, Mar 29, 2021 at 02:32:55AM +0300, Dmitry Osipenko wrote: >> All consumer-grade Android and Chromebook devices show a splash screen >> on boot and then display is left enabled when kernel is booted. This >> behaviour is unacceptable in a case of impl

[PATCH v6 16/30] fscache, cachefiles: Add alternate API to use kiocb for read/write to cache

2021-04-08 Thread David Howells
Add an alternate API by which the cache can be accessed through a kiocb, doing async DIO, rather than using the current API that tells the cache where all the pages are. The new API is intended to be used in conjunction with the netfs helper library. A filesystem must pick one or the other and no

[PATCH 2/2 v2] staging: media: hantro: Align line break to the open parenthesis in file hantro_mpeg2.c

2021-04-08 Thread Aline Santana Cordeiro
Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/hantro/hantro_mpeg2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/hantro/hantr

[PATCH 1/2 v2] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

2021-04-08 Thread Aline Santana Cordeiro
Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/hantro/hantro_hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/hantro/hantro_h

[PATCH v6 15/30] netfs: Add a tracepoint to log failures that would be otherwise unseen

2021-04-08 Thread David Howells
Add a tracepoint to log internal failures (such as cache errors) that we don't otherwise want to pass back to the netfs. Signed-off-by: David Howells cc: Matthew Wilcox cc: linux...@kvack.org cc: linux-cach...@redhat.com cc: linux-...@lists.infradead.org cc: linux-...@vger.kernel.org cc: linux-c

[PATCH v6 17/30] afs: Disable use of the fscache I/O routines

2021-04-08 Thread David Howells
Disable use of the fscache I/O routined by the AFS filesystem. It's about to transition to passing iov_iters down and fscache is about to have its I/O path to use iov_iter, so all that needs to change. Signed-off-by: David Howells cc: linux-...@lists.infradead.org cc: linux-cach...@redhat.com cc

[PATCH v6 18/30] afs: Pass page into dirty region helpers to provide THP size

2021-04-08 Thread David Howells
Pass a pointer to the page being accessed into the dirty region helpers so that the size of the page can be determined in case it's a transparent huge page. This also required the page to be passed into the afs_page_dirty trace point - so there's no need to specifically pass in the index or privat

[PATCH v6 19/30] afs: Print the operation debug_id when logging an unexpected data version

2021-04-08 Thread David Howells
Print the afs_operation debug_id when logging an unexpected change in the data version. This allows the logged message to be matched against tracelines. Signed-off-by: David Howells cc: linux-...@lists.infradead.org cc: linux-cach...@redhat.com cc: linux-fsde...@vger.kernel.org Link: https://lo

[PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-08 Thread Xiongwei Song
From: Xiongwei Song Create a new header named traps.h, define macros to list ppc interrupt types in traps.h, replace the reference of the trap hex values with these macros. Referred the hex number in arch/powerpc/kernel/exceptions-64e.S, arch/powerpc/kernel/exceptions-64s.S and arch/powerpc/incl

[PATCH v6 20/30] afs: Move key to afs_read struct

2021-04-08 Thread David Howells
Stash the key used to authenticate read operations in the afs_read struct. This will be necessary to reissue the operation against the server if a read from the cache fails in upcoming cache changes. Signed-off-by: David Howells cc: linux-...@lists.infradead.org cc: linux-cach...@redhat.com cc: l

[PATCH -next] nilfs2: Fix typos in comments

2021-04-08 Thread Lu Jialin
numer -> number in fs/nilfs2/cpfile.c and fs/nilfs2/segment.c retured -> returned and Decription -> Description in fs/nilfs2/ioctl.c isntance -> instance in fs/nilfs2/the_nilfs.c No functionality changed. Signed-off-by: Lu Jialin --- fs/nilfs2/cpfile.c| 2 +- fs/nilfs2/ioctl.c | 6 +++---

[PATCH v6 21/30] afs: Don't truncate iter during data fetch

2021-04-08 Thread David Howells
Don't truncate the iterator to correspond to the actual data size when fetching the data from the server - rather, pass the length we want to read to rxrpc. This will allow the clear-after-read code in future to simply clear the remaining iterator capacity rather than having to reinitialise the it

[PATCH v6 22/30] afs: Log remote unmarshalling errors

2021-04-08 Thread David Howells
Log unmarshalling errors reported by the peer (ie. it can't parse what we sent it). Limit the maximum number of messages to 3. Signed-off-by: David Howells cc: linux-...@lists.infradead.org cc: linux-cach...@redhat.com cc: linux-fsde...@vger.kernel.org Link: https://lore.kernel.org/r/1594658262

[PATCH v6 23/30] afs: Set up the iov_iter before calling afs_extract_data()

2021-04-08 Thread David Howells
afs_extract_data() sets up a temporary iov_iter and passes it to AF_RXRPC each time it is called to describe the remaining buffer to be filled. Instead: (1) Put an iterator in the afs_call struct. (2) Set the iterator for each marshalling stage to load data into the appropriate places. A

[PATCH v6 24/30] afs: Use ITER_XARRAY for writing

2021-04-08 Thread David Howells
Use a single ITER_XARRAY iterator to describe the portion of a file to be transmitted to the server rather than generating a series of small ITER_BVEC iterators on the fly. This will make it easier to implement AIO in afs. In theory we could maybe use one giant ITER_BVEC, but that means potential

[PATCH v6 25/30] afs: Wait on PG_fscache before modifying/releasing a page

2021-04-08 Thread David Howells
PG_fscache is going to be used to indicate that a page is being written to the cache, and that the page should not be modified or released until it's finished. Make afs_invalidatepage() and afs_releasepage() wait for it. Signed-off-by: David Howells cc: linux-...@lists.infradead.org cc: linux-ca

[PATCH v6 26/30] afs: Extract writeback extension into its own function

2021-04-08 Thread David Howells
Extract writeback extension into its own function to break up the writeback function a bit. Signed-off-by: David Howells cc: linux-...@lists.infradead.org cc: linux-cach...@redhat.com cc: linux-fsde...@vger.kernel.org Link: https://lore.kernel.org/r/160588538471.3465195.782513375683399583.st...@

[PATCH v6 27/30] afs: Prepare for use of THPs

2021-04-08 Thread David Howells
As a prelude to supporting transparent huge pages, use thp_size() and similar rather than PAGE_SIZE/SHIFT. Further, try and frame everything in terms of file positions and lengths rather than page indices and numbers of pages. Signed-off-by: David Howells cc: linux-...@lists.infradead.org cc: li

Re: [PATCH 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

2021-04-08 Thread Frank Rowand
On 4/7/21 4:34 PM, Rob Herring wrote: > On Wed, Apr 7, 2021 at 3:51 PM wrote: >> >> From: Frank Rowand >> >> The Devicetree standard specifies an 8 byte alignment of the FDT. >> Code in libfdt expects this alignment for an FDT image in memory. >> kmemdup() returns 4 byte alignment on openrisc. R

[PATCH v6 28/30] afs: Use the fs operation ops to handle FetchData completion

2021-04-08 Thread David Howells
Use the 'success' and 'aborted' afs_operations_ops methods and add a 'failed' method to handle the completion of an AFS.FetchData, AFS.FetchData64 or YFS.FetchData64 RPC operation rather than directly calling the done func pointed to by the afs_read struct from the call delivery handler. This mean

[PATCH v6 29/30] afs: Use new netfs lib read helper API

2021-04-08 Thread David Howells
Make AFS use the new netfs read helpers to implement the VM read operations: - afs_readpage() now hands off responsibility to netfs_readpage(). - afs_readpages() is gone and replaced with afs_readahead(). - afs_readahead() just hands off responsibility to netfs_readahead(). These make use of

[PATCH v6 30/30] afs: Use the netfs_write_begin() helper

2021-04-08 Thread David Howells
Make AFS use the new netfs_write_begin() helper to do the pre-reading required before the write. If successful, the helper returns with the required page filled in and locked. It may read more than just one page, expanding the read to meet cache granularity requirements as necessary. Note: A mor

[RFC PATCH 0/5] hwlat improvements and osnoise tracer

2021-04-08 Thread Daniel Bristot de Oliveira
This series proposes a set of improvements and new features for the tracing subsystem to facilitate the debugging of low latency deployments. Currently, hwlat runs on a single CPU at a time, migrating across a set of CPUs in a round-robin fashion. The first three patches are changes made to allow

[RFC PATCH 1/5] tracing/hwlat: Add a cpus file specific for hwlat_detector

2021-04-08 Thread Daniel Bristot de Oliveira
Provides a "cpus" interface to the hardware latency detector. By default, it lists all CPUs, allowing hwlatd threads to run on any online CPU of the system. It serves to restrict the execution of hwlatd to the set of CPUs writing via this interface. Note that hwlatd also respects the "tracing_cpum

[RFC PATCH 2/5] tracing/hwlat: Implement the mode config option

2021-04-08 Thread Daniel Bristot de Oliveira
Provides the "mode" config to the hardware latency detector. hwlatd has two different operation modes. The default mode is the "round-robin" one, in which a single hwlatd thread runs, migrating among the allowed CPUs in a "round-robin" fashion. This is the current behavior. The "none" sets the all

[RFC PATCH 3/5] tracing/hwlat: Implement the per-cpu mode

2021-04-08 Thread Daniel Bristot de Oliveira
Implements the per-cpu mode in which a sampling thread is created for each cpu in the "cpus" (and tracing_mask). The per-cpu mode has the potention to speed up the hwlat detection by running on multiple CPUs at the same time. Cc: Jonathan Corbet Cc: Steven Rostedt Cc: Ingo Molnar Cc: Peter Zij

[RFC PATCH 4/5] tracing: Add __print_ns_to_secs() and __print_ns_without_secs() helpers

2021-04-08 Thread Daniel Bristot de Oliveira
From: Steven Rostedt To have nanosecond output displayed in a more human readable format, its nicer to convert it to a seconds format (XXX.Y). The problem is that to do so, the numbers must be divided by NSEC_PER_SEC, and moded too. But as these numbers are 64 bit, this can not be done si

[RFC PATCH 5/5] tracing: Add the osnoise tracer

2021-04-08 Thread Daniel Bristot de Oliveira
In the context of high-performance computing (HPC), the Operating System Noise (osnoise) refers to the interference experienced by an application due to activities inside the operating system. In the context of Linux, NMIs, IRQs, SoftIRQs, and any other system thread can cause noise to the system.

Re: [PATCH 1/2] [v2] bus: mhi: pci_generic: Introduce Foxconn T99W175 support

2021-04-08 Thread Manivannan Sadhasivam
On Thu, Apr 08, 2021 at 02:55:24AM -0700, Jarvis Jiang wrote: > Add support for T99W175 modems, this modem series is based on SDX55 > qcom chip. The modem is mainly based on MBIM protocol for both the > data and control path. > > This patch adds support for below modems: > > - T99W175(based on s

Re: [PATCH v2 1/6] software node: Free resources explicitly when swnode_register() fails

2021-04-08 Thread Rafael J. Wysocki
On Wed, Mar 31, 2021 at 1:06 PM Heikki Krogerus wrote: > > On Mon, Mar 29, 2021 at 06:12:02PM +0300, Andy Shevchenko wrote: > > Currently we have a slightly twisted logic in swnode_register(). > > It frees resources that it doesn't allocate on error path and > > in once case it relies on the ->rel

[PATCH v2 01/18] X.509: Parse RSASSA-PSS style certificates

2021-04-08 Thread Varad Gautam
An X.509 wrapper for a RSASSA-PSS signature contains additional signature parameters over the PKCSv.15 encoding scheme. Extend the x509 parser to allow parsing RSASSA-PSS encoded certificates, with the defaults taken from RFC8017. References: https://tools.ietf.org/html/rfc8017#appendix-C Signed-o

[PATCH v2 00/18] Implement RSASSA-PSS signature verification

2021-04-08 Thread Varad Gautam
Linux currently supports RSA PKCSv1.5 encoding scheme for signing / verification. This adds support for RSASSA PSS signature verification as described in RFC8017 [1]. Patch 1 extends the x509 certificate parser to unpack PSS signature parameters. Patches 2-8 pull out the common functions / struc

[PATCH v2 03/18] crypto: rsa-pkcs1pad: Extract pkcs1pad_create into a generic helper

2021-04-08 Thread Varad Gautam
which can be reused by other signature padding schemes as rsapad_akcipher_create. This will be moved out of rsa-pkcs1pad.c to be used across rsa-*pad implementations. Signed-off-by: Varad Gautam --- crypto/rsa-pkcs1pad.c | 48 ++- 1 file changed, 34 insert

Re: [PATCH v4 02/12] perf record: introduce thread specific data array

2021-04-08 Thread Andi Kleen
> + } else { > + thread_data[t].tid = syscall(SYS_gettid); That always fills in the tid of the setup thread instead of the target threads?

[PATCH v2 02/18] crypto: rsa-pkcs1pad: Rename pkcs1pad-specific functions to rsapad

2021-04-08 Thread Varad Gautam
The existing RSA implementation supports PKCSv1.5 style signature paddings via rsa-pkcs1pad. A lot of the functionality implemented for rsa-pkcs1pad can be reused across other RSA padding schemes. Rename such functions as rsapad_* before moving them out of rsa-pkcs1pad.c. Signed-off-by: Varad Gaut

RE: [PATCH -next] RDMA/qedr: Fix error return code in qedr_iw_connect()

2021-04-08 Thread Michal Kalderon
> From: Wang Wensheng > Sent: Thursday, April 8, 2021 2:32 PM > > Fix to return a negative error code from the error handling case instead of 0, > as done elsewhere in this function. > > Fixes: 82af6d19d8d9 ("RDMA/qedr: Fix synchronization methods and > memory leaks in qedr") > Reported-by: Hulk

[PATCH v2 04/18] crypto: rsa-pkcs1pad: Pull out child req processing code into helpers

2021-04-08 Thread Varad Gautam
rsa-pkcs1pad operations that require using RSA primitives rely on creating an akcipher child RSA transform and processing the results in the operation-specific callback. Add helpers rsapad_akcipher_setup_child and rsapad_akcipher_req_complete for req setup and callback handling, and switch pkcs1pad

[PATCH v2 06/18] crypto: rsa: Start moving RSA common code to rsa-common

2021-04-08 Thread Varad Gautam
Move out helpers from rsa-pkcs1pad.c which will be shared across rsa-*pad implementations. Signed-off-by: Varad Gautam --- crypto/Makefile | 1 + crypto/rsa-common.c | 76 ++ crypto/rsa-pkcs1pad.c| 97 +---

[PATCH v2 05/18] crypto: rsa-pkcs1pad: Rename pkcs1pad_* structs to rsapad_*

2021-04-08 Thread Varad Gautam
Use generic naming to share with other padding scheme implementations. These will be moved out of rsa-pkcs1pad.c. Signed-off-by: Varad Gautam --- crypto/rsa-pkcs1pad.c | 62 +-- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/crypto/rsa-pkc

[PATCH v2 08/18] crypto: rsa: Move rsapad_akcipher_setup_child and callback to rsa-common

2021-04-08 Thread Varad Gautam
Pull out more common code from rsa-pkcs1pad into rsa-common. Signed-off-by: Varad Gautam --- crypto/rsa-common.c | 31 +++ crypto/rsa-pkcs1pad.c| 32 include/crypto/internal/rsa-common.h | 9 3 files

[PATCH v2 07/18] crypto: rsa: Move more common code to rsa-common

2021-04-08 Thread Varad Gautam
Move helpers for setting public/private keys, RSA akcipher instance setup, keysize querying etc. to rsa-common.c. Signed-off-by: Varad Gautam --- crypto/rsa-common.c | 183 +++ crypto/rsa-pkcs1pad.c| 183 --- includ

[PATCH v2 10/18] crypto: rsa: Move struct rsa_mpi_key definition to rsa.h

2021-04-08 Thread Varad Gautam
The RSASSA-PSS signature scheme requires knowing the RSA modulus size in bits. The rsa akcipher_alg max_size call is insufficient for this, as the returned keysize is rounded up to the next byte. Since the RSA modulus is stored as an MPI accessible via struct rsa_mpi_key, move the struct definitio

[PATCH v2 09/18] crypto: Extend akcipher API to pass signature parameters

2021-04-08 Thread Varad Gautam
For certain signature encoding schemes (eg. RSASSA-PSS), the verify/sign operation behavior depends on information contained in the signature blob. Allow passing this down to the crypto_template by introducing a crypto_akcipher_set_sig_params() call. Signed-off-by: Varad Gautam --- crypto/rsa-co

[PATCH v2 11/18] crypto: Scaffolding for RSA-PSS signature style

2021-04-08 Thread Varad Gautam
Add a crypto_template for rsa-psspad, hidden behind CONFIG_CRYPTO_RSASSA_PSS. Set the sign/verify/encrypt/decrypt operations to return -EOPNOTSUPP, to be implemented in the future Signed-off-by: Varad Gautam --- crypto/Kconfig| 6 ++ crypto/Makefile | 1 + cry

[PATCH v2 16/18] crypto: rsa-psspad: Implement signature verify callback

2021-04-08 Thread Varad Gautam
The RSA output must be processed as per the EMSA-PSS-VERIFY operation from RFC8017, which forms the core of the PSS signature verification. Implement the verification callback, which operates on the RSA output buffer. Reference: https://tools.ietf.org/html/rfc8017#section-9.1.2 Signed-off-by: Var

[PATCH v2 13/18] crypto: rsa-psspad: Get signature parameters from a given signature

2021-04-08 Thread Varad Gautam
Implement akcipher_alg->set_sig_params for rsassa-psspad to receive the salt length and MGF hash function for the signature being verified. Signed-off-by: Varad Gautam --- v2: Set mgf_hash_algo in psspad_set_sig_params. v1 assumed this to be the same as the digest hash. crypto/rsa-psspad.c

[PATCH v2 12/18] crypto: rsa-psspad: Introduce shash alloc/dealloc helpers

2021-04-08 Thread Varad Gautam
RSASSA-PSS verify operation needs to compute digests for its Mask Generation Function (MGF1), and for digest comparison. Add helpers to populate a crypto_shash and desc for use in both cases. Signed-off-by: Varad Gautam --- crypto/rsa-psspad.c | 24 1 file changed, 24 i

[PATCH v2 15/18] crypto: rsa-psspad: Provide PSS signature verify operation

2021-04-08 Thread Varad Gautam
Trigger RSA transform on the signature being verified from psspad_verify, to produce intermediary data which will be handled in the psspad_verify_complete callback. Reference: https://tools.ietf.org/html/rfc8017#section-8.1.2 Signed-off-by: Varad Gautam --- crypto/rsa-psspad.c | 53 +

[PATCH v2 14/18] crypto: Implement MGF1 Mask Generation Function for RSASSA-PSS

2021-04-08 Thread Varad Gautam
This generates a "mask" byte array of size mask_len bytes as a concatenation of digests, where each digest is calculated on a concatenation of an input seed and a running counter to fill up mask_len bytes - as described by RFC8017 sec B.2.1. "MGF1". The mask is useful for RSA signing/verification

[PATCH v2 17/18] crypto: Accept pss as valid encoding during signature verification

2021-04-08 Thread Varad Gautam
Accept pss encoding for public_key_verify_signature. If CONFIG_CRYPTO_RSASSA_PSS is disabled, crypto_alloc_akcipher will fail to find a pss backend anyway. Signed-off-by: Varad Gautam Acked-by: Jarkko Sakkinen --- crypto/asymmetric_keys/public_key.c | 18 +- 1 file changed, 13 i

[PATCH v2 18/18] keyctl_pkey: Add pkey parameters slen and mgfhash for PSS

2021-04-08 Thread Varad Gautam
keyctl pkey_* operations accept enc and hash parameters at present. RSASSA-PSS signatures also require passing in the signature salt length and the mgf hash function. Add parameters: - 'slen' to feed in salt length of a PSS signature. - 'mgfhash' to feed in the hash function used for MGF. Signed-

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2021-04-08 Thread Hans de Goede
Hi all, On 4/8/21 2:13 PM, Stephen Rothwell wrote: > Hi all, > > Commit > > 11cccec79c60 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()") > > is missing a Signed-off-by from its committer. Ugh, thanks for letting me know, this was supposed to come from a merge from an immutable branch fr

Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

2021-04-08 Thread Catalin Marinas
On Wed, Apr 07, 2021 at 04:52:54PM +0100, Steven Price wrote: > On 07/04/2021 16:14, Catalin Marinas wrote: > > On Wed, Apr 07, 2021 at 11:20:18AM +0100, Steven Price wrote: > > > On 31/03/2021 19:43, Catalin Marinas wrote: > > > > When a slot is added by the VMM, if it asked for MTE in guest (I gu

arch/sh/kernel/process_32.c:42:9: sparse: sparse: incorrect type in argument 1 (different base types)

2021-04-08 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 454859c552da78b0f587205d308401922b56863e commit: e5fc436f06eef54ef512ea55a9db8eb9f2e76959 sparse: use static inline for __chk_{user,io}_ptr() date: 7 months ago config: sh-randconfig-s031-20210408

Re: [PATCH v15 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings

2021-04-08 Thread Rob Herring
On Mon, Apr 05, 2021 at 04:36:07PM +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema > for DPU device tree bindings. > > Signed-off-by: Krishna Manikandan > > Changes in v2: > - Changed dpu to

Re: [PATCH v1 1/2] iommu/tegra-smmu: Defer attachment of display clients

2021-04-08 Thread Dmitry Osipenko
08.04.2021 16:26, Thierry Reding пишет: > On Thu, Apr 08, 2021 at 02:42:42AM -0700, Nicolin Chen wrote: >> On Mon, Mar 29, 2021 at 02:32:55AM +0300, Dmitry Osipenko wrote: >>> All consumer-grade Android and Chromebook devices show a splash screen >>> on boot and then display is left enabled when ke

Re: [PATCH v2] ACPI: AC: fix some coding style issues

2021-04-08 Thread Rafael J. Wysocki
On Sat, Mar 27, 2021 at 4:50 AM Xiaofei Tan wrote: > > Fix some coding style issues reported by checkpatch.pl, including > following types: > > ERROR: "foo * bar" should be "foo *bar" > ERROR: code indent should use tabs where possible > WARNING: Block comments use a trailing */ on a separate line

Re: [PATCH 4/4] KVM: hyper-v: Advertise support for fast XMM hypercalls

2021-04-08 Thread Siddharth Chandrasekaran
On Thu, Apr 08, 2021 at 02:05:53PM +0200, Vitaly Kuznetsov wrote: > Siddharth Chandrasekaran writes: > > > Now that all extant hypercalls that can use XMM registers (based on > > spec) for input/outputs are patched to support them, we can start > > advertising this feature to guests. > > > > Cc: A

Re: [PATCH v4 05/12] perf record: start threads in the beginning of trace streaming

2021-04-08 Thread Andi Kleen
> + err = write(thread->pipes.ack[1], &msg, sizeof(msg)); > + if (err == -1) > + pr_err("threads[%d]: failed to notify on start. Error %m", > thread->tid); It might be safer to not use %m. I'm not sure if all the non glibc libcs that people use support it.

Re: [PATCH 01/18] X.509: Parse RSASSA-PSS style certificates

2021-04-08 Thread Varad Gautam
On 4/8/21 4:29 AM, hongbo li wrote: > Hi Varad, > > Varad Gautam mailto:varad.gau...@suse.com>> > 于2021年4月8日周四 上午5:20写道: >> >> Hi Hongbo, >> >> On 4/7/21 10:27 AM, hongbo li wrote: >> > Hello Varad, >> > >> > I also made an implementation of rsa pss: "[PATCH v3 0/4] crypto: add >> > rsa pss suppo

Re: [Outreachy kernel] [PATCH v3] staging: rtl8723bs: Remove camelcase in several files

2021-04-08 Thread Julia Lawall
On Thu, 8 Apr 2021, Fabio M. De Francesco wrote: > Remove camelcase in bFwCurrentInPSMode, a variable used by code > of several subdirectories/files of the driver. Issue detected by > checkpatch.pl. It could be reasonable to mention the removal of b in the log message. julia > > Signed-off-b

Re: [PATCH] ubifs: default to zstd compression

2021-04-08 Thread Rui Salvaterra
Hi, Richard, On Thu, 8 Apr 2021 at 12:00, Richard Weinberger wrote: > > I was about to NACK this patch but by looking at the diff I realized > that you change > the default compressor only for the default filesystem as created by > UBIFS itself. Yes, that was the idea. :) > Queued for the merge

Re: [PATCH 00/13] tty.h cleanups

2021-04-08 Thread Johan Hovold
On Thu, Apr 08, 2021 at 02:51:21PM +0200, Greg Kroah-Hartman wrote: > Turns out there is a lot of tty-internal stuff in include/linux/tty.h > that do not belong there. Create a internal-to-the-tty-layer .h file > for these types of things and move function prototypes to it instead of > being in th

Re: [PATCH v4 09/12] perf record: document parallel data streaming mode

2021-04-08 Thread Andi Kleen
> +--threads=:: > +Write collected trace data into several data files using parallel threads. > + value can be user defined list of masks. Masks separated by colon > +define cpus to be monitored by a thread and affinity mask of that thread > +is separated by slash. For example user specification li

Re: [PATCH v4 12/12] perf session: use reader functions to load perf data file

2021-04-08 Thread Andi Kleen
Except where I commented, for the series Acked-by: Andi Kleen -Andi

Re: [PATCH 2/3] dt-bindings: mfd: Convert pm8xxx bindings to yaml

2021-04-08 Thread Rob Herring
On Wed, Apr 7, 2021 at 9:37 PM Bjorn Andersson wrote: > > On Wed 07 Apr 10:37 CDT 2021, ska...@codeaurora.org wrote: > > > Hi Bjorn, > > > > On 2021-03-11 22:33, Bjorn Andersson wrote: > > > On Thu 11 Mar 01:29 CST 2021, satya priya wrote: > [..] > > > > +patternProperties: > > > > + "rtc@[0-9a-f

Re: [PATCH v3 00/12] acpi: fix some coding style issues

2021-04-08 Thread Rafael J. Wysocki
On Sat, Mar 27, 2021 at 1:11 PM Xiaofei Tan wrote: > > Fix some coding style issues reported by checkpatch.pl. > Only cleanup and no function changes. > > Differences from v2 to v3: > - Remove the modifications that may cause function change. > > Differences from v1 to v2: > - Add subsystem and mo

Re: [PATCH v2] staging: rtl8712: remove unused variable from rtl871x_mlme.c

2021-04-08 Thread Edmundo Carmona Antoranz
On Thu, Apr 8, 2021 at 6:10 AM Sergei Krainov wrote: > No side effects can be seen locally or in r8712_find_network() I am sorry to jump in. Sergei, what Greg is asking is basically why you want to delete the r8712_find_network call in the first place. Deleting an unused variable is fine, but the

[PATCH] mm: page_counter: mitigate consequences of a page_counter underflow

2021-04-08 Thread Johannes Weiner
When the unsigned page_counter underflows, even just by a few pages, a cgroup will not be able to run anything afterwards and trigger the OOM killer in a loop. Underflows shouldn't happen, but when they do in practice, we may just be off by a small amount that doesn't interfere with the normal ope

[PATCH] remoteproc: qcom: wcss: Remove unnecessary PTR_ERR()

2021-04-08 Thread angkery
From: Junlin Yang Remove unnecessary PTR_ERR(), it has been assigned to ret before, so return ret directly. Signed-off-by: Junlin Yang --- drivers/remoteproc/qcom_q6v5_wcss.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_wcs

Re: linux-next: build warning after merge of the kvm-arm tree

2021-04-08 Thread Marc Zyngier
On Thu, 08 Apr 2021 12:44:00 +0100, Stephen Rothwell wrote: > > [1 ] > Hi all, > > After merging the kvm-arm tree, today's linux-next build (htmldocs) > produced this warning: > > /home/sfr/next/next/Documentation/virt/kvm/arm/ptp_kvm.rst:19: WARNING: > Malformed table. > Text in column margi

[PATCH] arm64: mte: Move MTE TCF0 check in entry-common

2021-04-08 Thread Vincenzo Frascino
The check_mte_async_tcf macro sets the TIF flag non-atomically. This can race with another CPU doing a set_tsk_thread_flag() and the flag can be lost in the process. Move the tcf0 check to enter_from_user_mode() and clear tcf0 in exit_to_user_mode() to address the problem. Note: Moving the check

RE: [RFC 0/4] Fix machine check recovery for copy_from_user

2021-04-08 Thread Luck, Tony
> I have one scenario, may you take into account: > > If one copyin case occurs, write() returned by your patch, the user process > may > check the return values, for errors, it may exit the process, then the error > page > will be freed, and then the page maybe alloced to other process or to ker

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Thomas Weißschuh
Hi, On Mi, 2021-04-07T18:27+, Barnabás Pőcze wrote: > 2021. április 5., hétfő 22:48 keltezéssel, Thomas Weißschuh írta: > > Tested with a X570 I Aorus Pro Wifi. > > The mainboard contains an ITE IT8688E chip for management. > > This chips is also handled by drivers/hwmon/i87.c but as it is als

Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

2021-04-08 Thread Dmitry Osipenko
08.04.2021 16:06, Thierry Reding пишет: > On Thu, Apr 08, 2021 at 02:25:19AM +0300, Dmitry Osipenko wrote: >> 08.04.2021 02:00, Sowjanya Komatineni пишет: >>> >>> On 4/7/21 3:57 PM, Sowjanya Komatineni wrote: On 4/7/21 2:36 PM, Dmitry Osipenko wrote: > 07.04.2021 04:25, Sowjanya Komat

Re: [syzbot] INFO: task hung in io_ring_exit_work

2021-04-08 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: INFO: task hung in io_ring_exit_work INFO: task kworker/u4:0:9 blocked for more than 143 seconds. Not tainted 5.12.0-rc2-syzkaller #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables thi

[PATCH v2 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

2021-04-08 Thread frowand . list
From: Frank Rowand The Devicetree standard specifies an 8 byte alignment of the FDT. Code in libfdt expects this alignment for an FDT image in memory. kmemdup() returns 4 byte alignment on openrisc. Replace kmemdup() with kmalloc(), align pointer, memcpy() to get proper alignment. The 4 byte al

Re: [PATCH 4/4] KVM: hyper-v: Advertise support for fast XMM hypercalls

2021-04-08 Thread Vitaly Kuznetsov
Siddharth Chandrasekaran writes: > On Thu, Apr 08, 2021 at 02:05:53PM +0200, Vitaly Kuznetsov wrote: >> Siddharth Chandrasekaran writes: >> >> > Now that all extant hypercalls that can use XMM registers (based on >> > spec) for input/outputs are patched to support them, we can start >> > adverti

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85

2021-04-08 Thread Jagan Teki
On Wed, Mar 24, 2021 at 7:26 PM Claudius Heine wrote: > > Hi Jagan, > > On 2021-02-14 18:44, Jagan Teki wrote: > > SN65DSI83/84/85 devices are MIPI DSI to LVDS based bridge > > controller IC's from Texas Instruments. > > > > SN65DSI83 - Single Channel DSI to Single-link LVDS bridge > > SN65DSI84 -

Re: [PATCH v13 03/18] arm64: hyp-stub: Move el1_sync into the vectors

2021-04-08 Thread Pavel Tatashin
On Thu, Apr 8, 2021 at 6:24 AM Marc Zyngier wrote: > > On 2021-04-08 05:05, Pavel Tatashin wrote: > > From: James Morse > > > > The hyp-stub's el1_sync code doesn't do very much, this can easily fit > > in the vectors. > > > > With this, all of the hyp-stubs behaviour is contained in its vectors.

[GIT PULL] timer drivers for v5.13

2021-04-08 Thread Daniel Lezcano
Hi Thomas, please consider these changes for v5.13 Thanks -- Daniel The following changes since commit d4c7c28806616809e3baa0b7cd8c665516b2726d: timekeeping: Allow runtime PM from change_clocksource() (2021-03-29 16:41:59 +0200) are available in the Git repository at: https://git.lin

Re: [PATCH 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

2021-04-08 Thread Frank Rowand
On 4/7/21 5:01 PM, Guenter Roeck wrote: > On 4/7/21 1:59 PM, Frank Rowand wrote: >> Hi Guenter, >> >> On 4/7/21 3:51 PM, frowand.l...@gmail.com wrote: >>> From: Frank Rowand >>> >>> The Devicetree standard specifies an 8 byte alignment of the FDT. >>> Code in libfdt expects this alignment for an F

[PATCH v17 1/2] scsi: ufs: Enable power management for wlun

2021-04-08 Thread Asutosh Das
During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU (START_STOP_UNIT) to wlun during its runtime-suspend. During the process blk_queue_enter checks if the queue is not in suspended state. If so, it waits f

[PATCH v17 2/2] ufs: sysfs: Resume the proper scsi device

2021-04-08 Thread Asutosh Das
Resumes the actual scsi device the unit descriptor of which is being accessed instead of the hba alone. Reviewed-by: Can Guo Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufs-sysfs.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/s

Re: [PATCH v2 1/6] software node: Free resources explicitly when swnode_register() fails

2021-04-08 Thread Andy Shevchenko
On Thu, Apr 08, 2021 at 04:15:37PM +0200, Rafael J. Wysocki wrote: > On Wed, Mar 31, 2021 at 1:06 PM Heikki Krogerus > wrote: > > > > On Mon, Mar 29, 2021 at 06:12:02PM +0300, Andy Shevchenko wrote: > > > Currently we have a slightly twisted logic in swnode_register(). > > > It frees resources tha

Re: [PATCH] sched/fair: Rate limit calls to update_blocked_averages() for NOHZ

2021-04-08 Thread Vincent Guittot
On Wed, 7 Apr 2021 at 19:19, Tim Chen wrote: > > > > On 4/7/21 7:02 AM, Vincent Guittot wrote: > > Hi Tim, > > > > On Wed, 24 Mar 2021 at 17:05, Tim Chen wrote: > >> > >> > >> > >> On 3/24/21 6:44 AM, Vincent Guittot wrote: > >>> Hi Tim, > >> > >>> > >>> IIUC your problem, we call update_blocked_

Re: [PATCH v6 02/30] mm: Add set/end/wait functions for PG_private_2

2021-04-08 Thread Matthew Wilcox
On Thu, Apr 08, 2021 at 03:04:20PM +0100, David Howells wrote: > +static inline void set_page_private_2(struct page *page) > +{ > + get_page(page); > + SetPagePrivate2(page); PAGEFLAG(OwnerPriv1, owner_priv_1, PF_ANY) So we can set Private2 on any tail page ... > +void end_page_private_2

<    2   3   4   5   6   7   8   9   10   11   >