RE: [RFC PATCH 2/7] RDMA/rxe: Convert the triple tasklets to workqueues

2022-09-12 Thread matsuda-dais...@fujitsu.com
On Mon, Sep 12, 2022 12:09 AM Bart Van Assche wrote: > On 9/11/22 00:10, Yanjun Zhu wrote: > > I also implemented a workqueue for rxe. IMO, can we add a variable to > > decide to use tasklet or workqueue? > > > > If user prefer using tasklet, he can set the variable to use > > tasklet. And the defa

Re: [RFC PATCH 2/7] RDMA/rxe: Convert the triple tasklets to workqueues

2022-09-12 Thread Yanjun Zhu
在 2022/9/11 23:08, Bart Van Assche 写道: On 9/11/22 00:10, Yanjun Zhu wrote: I also implemented a workqueue for rxe. IMO, can we add a variable to decide to use tasklet or workqueue? If user prefer using tasklet, he can set the variable to use tasklet. And the default is tasklet. Set the variab

RE: [RFC PATCH 2/7] RDMA/rxe: Convert the triple tasklets to workqueues

2022-09-12 Thread matsuda-dais...@fujitsu.com
On Sat, Sep 10, 2022 4:39 AM Bob Pearson wrote: > On 9/6/22 21:43, Daisuke Matsuda wrote: > > In order to implement On-Demand Paging on the rxe driver, triple tasklets > > (requester, responder, and completer) must be allowed to sleep so that they > > can trigger page fault when pages being accesse

Re: [RFC PATCH 2/7] RDMA/rxe: Convert the triple tasklets to workqueues

2022-09-12 Thread Yanjun Zhu
在 2022/9/12 15:58, matsuda-dais...@fujitsu.com 写道: On Mon, Sep 12, 2022 12:09 AM Bart Van Assche wrote: On 9/11/22 00:10, Yanjun Zhu wrote: I also implemented a workqueue for rxe. IMO, can we add a variable to decide to use tasklet or workqueue? If user prefer using tasklet, he can set the v

RE: [RFC PATCH 0/7] RDMA/rxe: On-Demand Paging on SoftRoCE

2022-09-12 Thread matsuda-dais...@fujitsu.com
On Fri, Sep 9, 2022 12:08 PM Li, Zhijian wrote: > > Daisuke > > Great job. > > I love this feature, before starting reviewing you patches, i tested it with > QEMU(with fsdax memory-backend) migration > over RDMA where it worked for MLX5 before. Thank you for the try! Anybody interested in the

Re: [RFC PATCH 2/7] RDMA/rxe: Convert the triple tasklets to workqueues

2022-09-12 Thread Bob Pearson
On 9/12/22 02:58, matsuda-dais...@fujitsu.com wrote: > On Mon, Sep 12, 2022 12:09 AM Bart Van Assche wrote: >> On 9/11/22 00:10, Yanjun Zhu wrote: >>> I also implemented a workqueue for rxe. IMO, can we add a variable to >>> decide to use tasklet or workqueue? >>> >>> If user prefer using tasklet,