Re: [PATCH] selftests/net: Add missing va_end in test_snprintf

2024-10-19 Thread Simon Horman
On Thu, Oct 17, 2024 at 03:52:51PM +0800, Liu Jing wrote: > There is no va_end after va_copy, just add it. > > Signed-off-by: Liu Jing > Signed-off-by: Liu Jing Thanks, This is correct. However, it was fixed recently in the same way by the following commit authored by one of your colleagues, Z

Re: [PATCH bpf-next 2/6] selftests/bpf: add missing ns cleanups in btf_skc_cls_ingress

2024-10-19 Thread Alexis Lothoré
Hi Martin, thanks for the review ! On 10/19/24 01:57, Martin KaFai Lau wrote: > On 10/16/24 11:35 AM, Alexis Lothoré (eBPF Foundation) wrote: >> btf_skc_cls_ingress.c currently runs two subtests, and create a >> dedicated network namespace for each, but never cleans up the created >> namespace onc

Re: [PATCH] module: .strtab must be null terminated

2024-10-19 Thread Alexey Dobriyan
> + strhdr = &info->sechdrs[info->index.str]; > + if (strhdr->sh_size > 0 && info->strtab[strhdr->sh_size - 1] != '\0') { > + pr_err("module %s: string table isn't null terminated\n", > +info->name ?: "(missing .modinfo section or name > field)"); > +

Re: [PATCH] module: check symbol name offsets

2024-10-19 Thread Tobias Stoeckmann
On Sat, Oct 19, 2024 at 04:15:33PM +0200, Tobias Stoeckmann wrote: > + if (sym[i].st_name >= strhdr->sh_size) { Please note that this commit only makes sense being applied AFTER the other patch sent, i.e. "module: .strtab must be null terminated" because that patch modifies strhdr befo

Re: [PATCH net-next v7] ptp: Add support for the AMZNC10C 'vmclock' device

2024-10-19 Thread David Woodhouse
On Mon, 2024-10-14 at 13:12 -0700, Jakub Kicinski wrote: > On Mon, 14 Oct 2024 08:25:35 +0100 David Woodhouse wrote: > > On Wed, 2024-10-09 at 17:32 -0700, Jakub Kicinski wrote: > > > On Sun, 06 Oct 2024 08:17:58 +0100 David Woodhouse wrote:  > > > > +config PTP_1588_CLOCK_VMCLOCK > > > > +   

Re: [PATCH net-next v9 11/23] ovpn: store tunnel and transport statistics

2024-10-19 Thread kernel test robot
Hi Antonio, kernel test robot noticed the following build warnings: [auto build test WARNING on 6d858708d465669ba7de17e9c5691eb4019166e8] url: https://github.com/intel-lab-lkp/linux/commits/Antonio-Quartulli/netlink-add-NLA_POLICY_MAX_LEN-macro/20241016-092722 base: 6d858708d465669ba7de17e

[PATCH] selftests: tc-testing: Fixed typo error

2024-10-19 Thread Karan Sanghavi
Corrected the multiple and different typo errors in json files - "diffferent" is corrected to "different". - "muliple" and "miltiple" is corrected to "multiple". Signed-off-by: Karan Sanghavi --- tools/testing/selftests/tc-testing/tc-tests/filters/basic.json | 6 +++--- tools/testing/selftests

Re: [PATCH] selftests: tc-testing: Fixed typo error

2024-10-19 Thread Simon Horman
On Sat, Oct 19, 2024 at 11:52:21AM +, Karan Sanghavi wrote: > Corrected the multiple and different typo errors in json files > > - "diffferent" is corrected to "different". > - "muliple" and "miltiple" is corrected to "multiple". > > Signed-off-by: Karan Sanghavi Thanks, This addresses all

[PATCH] next: use new shared modules tree

2024-10-19 Thread Luis Chamberlain
Use the new shared modules tree as we have more than one modules maintainer now. git://git.kernel.org/pub/scm/linux/kernel/git/modules/linux.git Signed-off-by: Luis Chamberlain --- Next/Trees | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Next/Trees b/Next/Trees index 38812

Re: [PATCH v2] module: sign with sha512 instead of sha1 by default

2024-10-19 Thread Luis Chamberlain
On Wed, Oct 16, 2024 at 04:18:41PM +0200, Thorsten Leemhuis wrote: > Switch away from using sha1 for module signing by default and use the > more modern sha512 instead, which is what among others Arch, Fedora, > RHEL, and Ubuntu are currently using for their kernels. > > Sha1 has not been consider

Re: [PATCH] Fix typo in vringh_test.c

2024-10-19 Thread Shivam Chaudhary
On 08/10/24 8:22 PM, Shivam Chaudhary wrote: Corrected minor typo in tools/virtio/vringh_test.c: - Fixed "retreives" to "retrieves" Signed-off-by: Shivam Chaudhary --- tools/virtio/vringh_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virtio/vringh_test.c

Re: [PATCH v2] rpmsg: qcom_smd: Improve error handling for qcom_smd_parse_edge

2024-10-19 Thread Luca Weiss
On Donnerstag, 6. Juni 2024 21:01:36 MESZ Luca Weiss wrote: > When the mailbox driver has not probed yet, the error message "failed to > parse smd edge" is just going to confuse users, so improve the error > prints a bit. > > Cover the last remaining exits from qcom_smd_parse_edge with proper > er

Re: [PATCH bpf-next 4/6] selftests/bpf: add ipv4 and dual ipv4/ipv6 support in btf_skc_cls_ingress

2024-10-19 Thread Alexis Lothoré
On 10/19/24 02:30, Martin KaFai Lau wrote: > On 10/16/24 11:35 AM, Alexis Lothoré (eBPF Foundation) wrote: [...] >>   +    switch (ip_mode) { >> +    case TEST_MODE_IPV4: >> +    sock_family = AF_INET; >> +    srv_addr = SERVER_ADDR_IPV4; >> +    addr = (struct sockaddr_storage *)&srv

[PATCH] module: .strtab must be null terminated

2024-10-19 Thread Tobias Stoeckmann
The string table must be NUL-terminated, just like the section name table. Signed-off-by: Tobias Stoeckmann --- In order to create a proof of concept, which I can't get into a simple script right now, it's easiest to move '.strtab' to the end of the module file, write as many 'A' characters at th

[PATCH] module: check symbol name offsets

2024-10-19 Thread Tobias Stoeckmann
It must be verified that the symbol name offsets point into the string table, not outside of it. Signed-off-by: Tobias Stoeckmann --- Proof of Concept: 1. Create "poc.sh" ``` cat > poc.sh << EOF #!/bin/sh # Sets an illegal symbol name offset in supplied uncompressed module # usage: ./poc file.k

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-10-19 Thread Luis Chamberlain
On Thu, Oct 17, 2024 at 02:08:19PM +0200, Helge Deller wrote: > Hi Luis, > > On 10/17/24 01:21, Luis Chamberlain wrote: > > That sounds great. Yeah, the above would be great to test. A while ago > > I wrote a new modules selftests in order to test possible improvements > > on find_symbol() but I a

Re: [PATCH 00/12] Module Validation Refactor

2024-10-19 Thread Luis Chamberlain
On Tue, Oct 15, 2024 at 11:16:34PM +, Matthew Maurer wrote: > Split out from Extended MODVERSIONS Support [1] > > This series refactors module validation during loading to ensure that > everything is checked on its way in. This is intended to make the code > robust enough that we can more conf

Re: [PATCH v3 01/16] iommufd/viommu: Introduce IOMMUFD_OBJ_VDEVICE and its related struct

2024-10-19 Thread Nicolin Chen
On Thu, Oct 17, 2024 at 03:45:56PM -0300, Jason Gunthorpe wrote: > > +struct iommufd_vdevice * > > +__iommufd_vdevice_alloc(struct iommufd_ctx *ictx, size_t size) > > +{ > > + struct iommufd_object *obj; > > + > > + if (WARN_ON(size < sizeof(struct iommufd_vdevice))) > > + return ERR_

Re: [PATCH v3 03/16] iommufd/viommu: Add IOMMU_VDEVICE_ALLOC ioctl

2024-10-19 Thread Nicolin Chen
On Thu, Oct 17, 2024 at 03:52:30PM -0300, Jason Gunthorpe wrote: > > + if (viommu->ops && viommu->ops->vdevice_alloc) > > + vdev = viommu->ops->vdevice_alloc(viommu, idev->dev, virt_id); > > + else > > + vdev = __iommufd_vdevice_alloc(ucmd->ictx, sizeof(*vdev)); > > + if (