Marcus Wichelmann wrote:
> The existing XDP metadata test works by creating a veth pair and
> attaching XDP & TC programs that drop the packet when the condition of
> the test isn't fulfilled. The test then pings through the veth pair and
> succeeds when the ping comes through.
>
> While this test
On Thu, Feb 27, 2025 at 1:26 AM Alistair Popple wrote:
>
> I've asked a few times, but are there any plans/ideas on how to improve the
> situation? I'm kind of suprised we're building things on top of a fairly
> broken
> feature without an idea of how we might make that feature work. I'd love to
On 24/02/2025 21:47, Luis Gerhorst wrote:
> + } else if (error_recoverable_with_nospec(err) &&
> state->speculative)
> {
> + WARN_ON_ONCE(env->bypass_spec_v1);
> + WARN_ON_ONCE(env->cur_state != state);
> +
> + /* Prevent thi
Kevin Krakauer wrote:
> Modify gro.sh to return a useful exit code when the -t flag is used. It
> formerly returned 0 no matter what.
>
> Tested: Ran `gro.sh -t large` and verified that test failures return 1.
> Signed-off-by: Kevin Krakauer
Reviewed-by: Willem de Bruijn
> ---
> tools/testing
On Thu, Feb 27, 2025 at 6:27 AM Jiayuan Chen wrote:
>
> 1. Optimized some static bound port selftests to avoid port occupation
> when running test_progs -j.
> 2. Optimized the retry logic for test_maps.
Looks great. Applied.
Thank you for fixing them.
Kevin Krakauer wrote:
> GRO tests are timing dependent and can easily flake. This is partially
> mitigated in gro.sh by giving each subtest 3 chances to pass. However,
> this still flakes on some machines. Reduce the flakiness by:
>
> - Bumping retries to 6.
> - Setting napi_defer_hard_irqs to 1 t
Kevin Krakauer wrote:
> gro.c:main no longer erroneously claims a test passes when running as a
> sender.
>
> Tested: Ran `gro.sh -t large` to verify the sender no longer prints a
> status.
>
> Signed-off-by: Kevin Krakauer
Reviewed-by: Willem de Bruijn
Hi Vishal,
kernel test robot noticed the following build errors:
[auto build test ERROR on tip/x86/core]
[also build test ERROR on tip/master linus/master v6.14-rc4 next-20250227]
[cannot apply to tip/x86/tdx tip/auto-latest]
[If your patch is applied to the wrong git tree, kindly drop us a note
Hello:
This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov :
On Thu, 27 Feb 2025 22:26:43 +0800 you wrote:
> 1. Optimized some static bound port selftests to avoid port occupation
> when running test_progs -j.
> 2. Optimized the retry logic for test_maps.
>
> Some Failed C
Kevin Krakauer wrote:
> The GRO selftests can flake and have some confusing behavior. These
> changes make the output and return value of GRO behave as expected, then
> deflake the tests.
>
> v2:
> - Split into multiple commits.
> - Reduced napi_defer_hard_irqs to 1.
> - Reduced gro_flush_timeout
On Wed, Feb 26, 2025 at 12:25:05PM -0800, Atish Patra wrote:
> The PMU test commandline option takes an argument to disable a
> certain test. The initial assumption behind this was a common use case
> is just to run all the test most of the time. However, running a single
> test seems more useful i
On Wed, Feb 26, 2025 at 12:25:06PM -0800, Atish Patra wrote:
> It is helpful to vary the number of the LCOFI interrupts generated
> by the overflow test. Allow additional argument for overflow test
> to accommodate that. It can be easily cross-validated with
> /proc/interrupts output in the host.
>
This introduces a test for IPSec offload over bonding, utilizing netdevsim
for the testing process, as veth interfaces do not support IPSec offload.
The test will ensure that the IPSec offload functionality remains operational
even after a failover event occurs in the bonding configuration.
Signed
The fixed commit placed mutex_lock() inside spin_lock_bh(), which triggers
a warning:
BUG: sleeping function called from invalid context at...
Fix this by moving the IPsec deletion operation to bond_ipsec_free_sa,
which is not held by spin_lock_bh().
Additionally, delete the IPsec list in bond
The active-backup bonding mode supports XFRM ESP offload. However, when
a bond is added using command like `ip link add bond0 type bond mode 1
miimon 100`, the `ethtool -k` command shows that the XFRM ESP offload is
disabled. This occurs because, in bond_newlink(), we change bond link
first and reg
The first patch fixes the incorrect locks using in bond driver.
The second patch fixes the xfrm offload feature during setup active-backup
mode. The third patch add a ipsec offload testing.
v3: move the ipsec deletion to bond_ipsec_free_sa (Cosmin Ratiu)
v2: do not turn carrier on if bond change l
On Wed, Feb 26, 2025 at 12:25:04PM -0800, Atish Patra wrote:
> There is no need to start the counter in the overflow handler as we
> intend to trigger precise number of LCOFI interrupts through these
> tests. The overflow irq handler has already stopped the counter. As
> a result, the stop call fro
On Wed, Feb 26, 2025 at 12:25:03PM -0800, Atish Patra wrote:
> The perf event should be marked disabled during the creation as
> it is not ready to be scheduled until there is SBI PMU start call
> or config matching is called with auto start. Otherwise, event add/start
> gets called during perf_eve
On 2/27/25 10:37, Hangbin Liu wrote:
> The fixed commit placed mutex_lock() inside spin_lock_bh(), which triggers
> a warning:
>
> BUG: sleeping function called from invalid context at...
>
> Fix this by moving the IPsec deletion operation to bond_ipsec_free_sa,
> which is not held by spin_lock
On Fri, Feb 21, 2025 at 03:51:49PM +0530, Bharadwaj Raju wrote:
> Fix grammar such as "number amount of times is
> recommended" etc -> "the recommended number of
> times".
>
> Signed-off-by: Bharadwaj Raju
> ---
> tools/testing/selftests/sysctl/sysctl.sh | 6 +++---
> 1 file changed, 3 insertion
There is a spelling mistake in a sig_print message. Fix it.
Signed-off-by: Colin Ian King
---
tools/testing/selftests/x86/xstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/x86/xstate.c
b/tools/testing/selftests/x86/xstate.c
index 875777911d82..
Enable the checksum option for these two endpoints in order to allow
mobile data to actually work. Without this, no packets seem to make it
through the IPA.
Fixes: b310de784bac ("net: ipa: add IPA v4.7 support")
Signed-off-by: Luca Weiss
---
drivers/net/ipa/data/ipa_data-v4.7.c | 2 ++
1 file ch
Hi Keith
There are some error messages from qemu output when I tested this
series of patches with the virtio-net regression test. It can
reproduced by boot up a guest with vhost device after applied your
patches.
Error messages:
Qemu output:
qemu-kvm: -netdev {"id": "idoejzv8", "type": "tap", "vho
On 2/24/25 10:22 AM, Peter Seiderer wrote:
> Fix mpls maximum labels list parsing up to MAX_MPLS_LABELS/16 entries
> (instead of up to MAX_MPLS_LABELS - 1).
Very minor nit...
The above comments sounds misleading to me. I read it as the new limit
is MAX_MPLS_LABELS divided by 16, that is 1.
Thank
In the downstream IPA driver there's only one group defined for source
and destination, and the destination group doesn't have a _DPL suffix.
Fixes: b310de784bac ("net: ipa: add IPA v4.7 support")
Signed-off-by: Luca Weiss
---
drivers/net/ipa/data/ipa_data-v4.7.c | 12 +---
1 file change
pa: Enable checksum for IPA_ENDPOINT_AP_MODEM_{RX,TX} for v4.7
drivers/net/ipa/data/ipa_data-v4.7.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
---
base-commit: d082ecbc71e9e0bf49883ee4afd435a77a5101b6
change-id: 20250227-ipa-v4-7-fixes-20f2af9702e4
Best regards,
--
Luca Weiss
As per downstream reference, max_writes should be 12 and max_reads
should be 13.
Fixes: b310de784bac ("net: ipa: add IPA v4.7 support")
Signed-off-by: Luca Weiss
---
drivers/net/ipa/data/ipa_data-v4.7.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ipa/data/
Hi,
> diff --git a/arch/arm64/kernel/entry-common.c
> b/arch/arm64/kernel/entry-common.c
> index b260ddc4d3e9..b537af333b42 100644
> --- a/arch/arm64/kernel/entry-common.c
> +++ b/arch/arm64/kernel/entry-common.c
> @@ -8,6 +8,7 @@
> #include
> #include
> #include
> +#include
> #include
>
On 2025-02-21 4:44 pm, Jason Gunthorpe wrote:
On Fri, Feb 21, 2025 at 03:39:45PM +, Robin Murphy wrote:
Yuck. Realistically we are going to have no more than two different
implementations of this; a fiddly callback interface seems overkill. All we
should need in the domain is a simple indica
On Mon, 24 Feb 2025 at 11:25, Brendan Jackman wrote:
>
> On Fri, 21 Feb 2025 at 19:26, Brendan Jackman wrote:
> >
> > It seems that 9pfs does not allow truncating unlinked files, Mark Brown
> > has noted that NFS may also behave this way.
>
> I have not investigated at all but I _think_ over the
On 2/25/25 18:24, Shyam Saini wrote:
> On Tue, Feb 25, 2025 at 09:33:10AM +0100, Petr Pavlu wrote:
>> On 2/21/25 11:42, Rasmus Villemoes wrote:
>>> On Thu, Feb 13 2025, Petr Pavlu wrote:
>>>
On 2/11/25 22:48, Shyam Saini wrote:
> In the unlikely event of the allocation failing, it is bett
Switch for using of get_state_synchronize_rcu_full() and
poll_state_synchronize_rcu_full() pair to debug a normal
synchronize_rcu() call.
Just using "not" full APIs to identify if a grace period is
passed or not might lead to a false-positive kernel splat.
It can happen, because get_state_synchro
Currently "nfakewriters" parameter can be set to any value but
there is no possibility to adjust it automatically based on how
many CPUs a system has where a test is run on.
To address this, if the "nfakewriters" is set to negative it will
be adjusted to num_online_cpus() during torture initializa
Add extra parameters for rcutorture module. One is the "nfakewriters"
which is set -1. There will be created number of test-kthreads which
correspond to number of CPUs in a test system. Those threads randomly
invoke synchronize_rcu() call.
Apart of that "rcu_normal" is set to 1, because it is spec
Hi all,
This patch series continues the work to migrate the *.sh tests into
prog_tests framework.
The test_tunnel.sh script has already been partly migrated to
test_progs in prog_tests/test_tunnel.c so I add my work to it.
PATCH 1 & 2 create some helpers to avoid code duplication and ease the
mi
A fair amount of code duplication is present among tests to attach BPF
programs.
Create generic_attach* helpers that attach BPF programs to a given
interface.
Use ASSERT_OK_FD() instead of ASSERT_GE() to check fd's validity.
Use these helpers in all the available tests.
Signed-off-by: Bastien Cur
On Thu, Feb 27, 2025 at 11:21:51AM +0200, Nikolay Aleksandrov wrote:
> >> @@ -617,6 +611,12 @@ static void bond_ipsec_del_sa_all(struct bonding
> >> *bond)
> >>
> >>mutex_lock(&bond->ipsec_lock);
> >>list_for_each_entry(ipsec, &bond->ipsec_list, list) {
> >> + if (ipsec->xs->km.
gre tunnels are tested in the test_tunnel.sh but not in the test_progs
framework.
Add a new test in test_progs to test gre tunnels. It uses the same
network topology and the same BPF programs than the script.
Remove test_gre() and test_gre_no_tunnel_key() from the script.
Signed-off-by: Bastien C
All tests use more or less the same ping commands as final validation.
Also test_ping()'s return value is checked with ASSERT_OK() while this
check is already done by the SYS() macro inside test_ping().
Create helpers around test_ping() and use them in the tests to avoid code
duplication.
Remove t
ip6gre tunnels are tested in the test_tunnel.sh but not in the test_progs
framework.
Add a new test in test_progs to test ip6gre tunnels. It uses the same
network topology and the same BPF programs than the script. Disable the
IPv6 DAD feature because it can take lot of time and cause some tests t
ip6erspan tunnels are tested in the test_tunnel.sh but not in the
test_progs framework.
Add a new test in test_progs to test ip6erspan tunnels. It uses the same
network topology and the same BPF programs than the script.
Remove test_ip6erspan() from the script.
Signed-off-by: Bastien Curutchet (e
erspan tunnels are tested in the test_tunnel.sh but not in the test_progs
framework.
Add a new test in test_progs to test erspan tunnels. It uses the same
network topology and the same BPF programs than the script.
Remove test_erspan() from the script.
Signed-off-by: Bastien Curutchet (eBPF Found
ip6tnl tunnels are tested in the test_tunnel.sh but not in the test_progs
framework.
Add a new test in test_progs to test ip6tnl tunnels. It uses the same
network topology and the same BPF programs than the script.
Remove test_ipip6() and test_ip6ip6() from the script.
Signed-off-by: Bastien Curu
geneve tunnels are tested in the test_tunnel.sh but not in the test_progs
framework.
Add a new test in test_progs to test geneve tunnels. It uses the same
network topology and the same BPF programs than the script.
Remove test_geneve() from the script.
Signed-off-by: Bastien Curutchet (eBPF Found
All tests from test_tunnel.sh have been migrated into test test_progs.
The last test remaining in the script is the test_ipip() that is already
covered in the test_prog framework by the NONE case of test_ipip_tunnel().
Remove the test_tunnel.sh script and its Makefile entry
Signed-off-by: Bastien
ip6geneve tunnels are tested in the test_tunnel.sh but not in the
test_progs framework.
Add a new test in test_progs to test ip6geneve tunnels. It uses the same
network topology and the same BPF programs than the script.
Remove test_ip6geneve() from the script.
Signed-off-by: Bastien Curutchet (e
On 2/27/25 15:21, Hangbin Liu wrote:
> On Thu, Feb 27, 2025 at 11:21:51AM +0200, Nikolay Aleksandrov wrote:
@@ -617,6 +611,12 @@ static void bond_ipsec_del_sa_all(struct bonding
*bond)
mutex_lock(&bond->ipsec_lock);
list_for_each_entry(ipsec, &bond->ipsec_list, lis
On Thu, 27 Feb 2025 11:19:33 +0100, Paolo Abeni wrote:
> On 2/24/25 10:22 AM, Peter Seiderer wrote:
> > diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> > index ae5e81e62733..bb13a4591709 100644
> > --- a/net/core/pktgen.c
> > +++ b/net/core/pktgen.c
> > @@ -915,8 +915,13 @@ static ssize_t ge
Hello Paolo,
On Thu, 27 Feb 2025 11:24:48 +0100, Paolo Abeni wrote:
> On 2/24/25 10:22 AM, Peter Seiderer wrote:
> > Fix mpls maximum labels list parsing up to MAX_MPLS_LABELS/16 entries
> > (instead of up to MAX_MPLS_LABELS - 1).
>
> Very minor nit...
>
> The above comments sounds misleading to
Honour the user given buffer size for the hex32_arg(), num_arg(),
strn_len(), get_imix_entries() and get_labels() calls (otherwise they will
access memory outside of the user given buffer).
Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
---
Changes v7 -> v8
- rebased on actual net-nex
Remove all superfluous index ('i += len') assignements (value not used
afterwards).
Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
---
Changes v7 -> v8
- rebased on actual net-next/main
- no changes
Changes v6 -> v7
- rebased on actual net-next/main
- no changes
Changes v5 ->
Remove extra tmp variable in pktgen_if_write (re-use len instead).
Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
---
Changes v7 -> v8
- rebased on actual net-next/main
- no changes
Changes v6 -> v7
- rebased on actual net-next/main
- no changes
Changes v5 -> v6
- no changes
While taking a look at '[PATCH net] pktgen: Avoid out-of-range in
get_imix_entries' ([1]) and '[PATCH net v2] pktgen: Avoid out-of-bounds
access in get_imix_entries' ([2], [3]) and doing some tests and code review
I detected that the /proc/net/pktgen/... parsing logic does not honour the
user given
Add some test for /proc/net/pktgen/... interface.
- enable 'CONFIG_NET_PKTGEN=m' in tools/testing/selftests/net/config
Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
---
Changes v7 -> v8
- rebased on actual net-next/main
- fix c99 comments (suggested by Paolo Abeni)
- add rev-by
Fix mpls list reset parsing to work as describe in
Documentation/networking/pktgen.rst:
pgset "mpls 0"turn off mpls (or any invalid argument works too!)
- before the patch
$ echo "mpls 0001,0002" > /proc/net/pktgen/lo\@0
$ grep mpls /proc/net/pktgen/lo\@0
Fix mix of int/long (and multiple conversion from/to) by using consequently
size_t for i and max and ssize_t for len and adjust function signatures
of hex32_arg(), count_trail_chars(), num_arg() and strn_len() accordingly.
Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
---
Changes v7 ->
101 - 156 of 156 matches
Mail list logo
