[PATCH v2] selftests/filesystems: Fix build of anon_inode_test

2025-05-30 Thread Mark Brown
The newly added anon_inode_test test fails to build due to attempting to include a nonexisting overlayfs/wrapper.h: anon_inode_test.c:10:10: fatal error: overlayfs/wrappers.h: No such file or directory 10 | #include "overlayfs/wrappers.h" | ^~ This is due to

Re: [PATCH v3 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-30 Thread Bryan O'Donoghue
On 30/05/2025 10:00, Vincent Knecht via B4 Relay wrote: > From: Vincent Knecht > > Some devices need writing values to VFE VBIF registers. > Add helper functions to do this. > > Signed-off-by: Vincent Knecht > --- > drivers/media/platform/qcom/camss/Makefile | 1 + > drivers/media/p

Re: [PATCH v3 2/4] media: qcom: camss: Add support for MSM8939

2025-05-30 Thread Bryan O'Donoghue
On 30/05/2025 10:00, Vincent Knecht via B4 Relay wrote: > + camss->res->version == CAMSS_8x39 || This is not correct - it should be 893x since 8939 and 8936 are ~ the same SoC - probably 36 is just a binned version of 39. Anyway the x is the least significant digit. Please fix --- bod

Re: [PATCH v3 3/3] rpmsg: ctrl: Introduce RPMSG_CREATE_EPT_FD_IOCTL uAPI

2025-05-30 Thread Dawei Li
HI Beleswar, Thanks for reviewing. On Fri, May 30, 2025 at 03:15:28PM +0530, Beleswar Prasad Padhi wrote: > Hi Dawei, > > On 19/05/25 20:38, Dawei Li wrote: > > Implement RPMSG_CREATE_EPT_FD_IOCTL, new uAPI for rpmsg ctrl, which > > shares most of operations of RPMSG_CREATE_EPT_IOCTL except that

[RFC PATCH v1 4/6] mm: Introduce arch_in_lazy_mmu_mode()

2025-05-30 Thread Ryan Roberts
Introduce new arch_in_lazy_mmu_mode() API, which returns true if the calling context is currently in lazy mmu mode or false otherwise. Each arch that supports lazy mmu mode must provide an implementation of this API. The API will shortly be used to prevent accidental lazy mmu mode nesting when per

[RFC PATCH v1 3/6] mm: Avoid calling page allocator from apply_to_page_range()

2025-05-30 Thread Ryan Roberts
Lazy mmu mode applies to the current task and permits pte modifications to be deferred and updated at a later time in a batch to improve performance. apply_to_page_range() calls its callback in lazy mmu mode and some of those callbacks call into the page allocator to either allocate or free pages.

[RFC PATCH v1 1/6] fs/proc/task_mmu: Fix pte update and tlb maintenance ordering in pagemap_scan_pmd_entry()

2025-05-30 Thread Ryan Roberts
pagemap_scan_pmd_entry() was previously modifying ptes while in lazy mmu mode, then performing tlb maintenance for the modified ptes, then leaving lazy mmu mode. But any pte modifications during lazy mmu mode may be deferred until arch_leave_lazy_mmu_mode(), inverting the required ordering between

[RFC PATCH v1 2/6] mm: Fix pte update and tlb maintenance ordering in migrate_vma_collect_pmd()

2025-05-30 Thread Ryan Roberts
migrate_vma_collect_pmd() was previously modifying ptes while in lazy mmu mode, then performing tlb maintenance for the modified ptes, then leaving lazy mmu mode. But any pte modifications during lazy mmu mode may be deferred until arch_leave_lazy_mmu_mode(), inverting the required ordering between

[RFC PATCH v1 0/6] Lazy mmu mode fixes and improvements

2025-05-30 Thread Ryan Roberts
Hi All, I recently added support for lazy mmu mode on arm64. The series is now in Linus's tree so should be in v6.16-rc1. But during testing in linux-next we found some ugly corners (unexpected nesting). I was able to fix those issues by making the arm64 implementation more permissive (like the ot

[RFC PATCH v1 6/6] Revert "arm64/mm: Permit lazy_mmu_mode to be nested"

2025-05-30 Thread Ryan Roberts
Commit 491344301b25 ("arm64/mm: Permit lazy_mmu_mode to be nested") made the arm64 implementation of lazy_mmu_mode tolerant to nesting. But subsequent commits have fixed the core code to ensure that lazy_mmu_mode never gets nested (as originally intended). Therefore we can revert this commit and re

[RFC PATCH v1 5/6] mm: Avoid calling page allocator while in lazy mmu mode

2025-05-30 Thread Ryan Roberts
Lazy mmu mode applies to the current task and permits pte modifications to be deferred and updated at a later time in a batch to improve performance. tlb_next_batch() is called in lazy mmu mode as follows: zap_pte_range arch_enter_lazy_mmu_mode do_zap_pte_range zap_present_ptes zap_p

Re: [PATCH v3 3/3] rpmsg: ctrl: Introduce RPMSG_CREATE_EPT_FD_IOCTL uAPI

2025-05-30 Thread Beleswar Prasad Padhi
Hi Dawei, On 19/05/25 20:38, Dawei Li wrote: > Implement RPMSG_CREATE_EPT_FD_IOCTL, new uAPI for rpmsg ctrl, which > shares most of operations of RPMSG_CREATE_EPT_IOCTL except that it > returns fd representing eptdev to userspace directly. > > Possible calling procedures for userspace are: > - fd

Re: [PATCH v3 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

2025-05-30 Thread Ujwal Kundur
> Sorry I don't have an opinion on which of these is the best (I can try > to find some time to form an opionion on this later!), but: > > Fixing the flakiness sounds great, but I would suggest decoupling that > from the refactoring. If it's practical, focus on removing the globals > first, while l

Re: [RFC PATCH v1 0/6] Lazy mmu mode fixes and improvements

2025-05-30 Thread Lorenzo Stoakes
+cc Jann who is a specialist in all things page table-y and especially scary edge cases :) On Fri, May 30, 2025 at 03:04:38PM +0100, Ryan Roberts wrote: > Hi All, > > I recently added support for lazy mmu mode on arm64. The series is now in > Linus's tree so should be in v6.16-rc1. But during test

[PATCH v3 2/4] media: qcom: camss: Add support for MSM8939

2025-05-30 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht The camera subsystem for the MSM8939 is the same as MSM8916 except with 3 CSID instead of 2, and some higher clock rates. As a quirk, this SoC needs writing values to 2 VFE VBIF registers (see downstream msm8939-camera.dtsi vbif-{regs,settings} properties). This fixes black

[PATCH v3 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-05-30 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 253 + 1 file changed, 253 insertions(+) diff --git a/Documentation/devicet

Re: [PATCH v2 2/3] virtio-mem: fix multiple typos in struct comments and function docs

2025-05-30 Thread David Hildenbrand
On 29.05.25 10:42, Alok Tiwari wrote: Corrected several spelling mistakes in code comments, including: - "bock" -> "block" - "valued" -> "value" - "actipn" -> "action" - "accidentially" -> "accidentally" - Improved grammar in a few places for clarity. These changes are purely cosmetic and do not

[PATCH v3 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-30 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Some devices need writing values to VFE VBIF registers. Add helper functions to do this. Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/Makefile | 1 + drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 12 +++ drivers/media/platform

[PATCH v3 0/4] CAMSS support for MSM8939

2025-05-30 Thread Vincent Knecht via B4 Relay
This series adds CAMSS support for MSM8939. It's mostly identical to MSM8916, except for some clocks and an additional CSI. To fix black stripes across sensor output, and garbage in CSID TPG output, 2 VFE VBIF register settings are needed. So the 1st patch adds helper functions to do just that. P

Re: [PATCH] virtio-vdpa: Remove virtqueue list

2025-05-30 Thread Eugenio Perez Martin
On Thu, May 29, 2025 at 9:30 AM Viresh Kumar wrote: > > The virtio vdpa implementation creates a list of virtqueues, while the > same is already available in the struct virtio_device. > > This list is never traversed though, and only the pointer to the struct > virtio_vdpa_vq_info is used in the c

Re: [PATCH] selftests/filesystems: Fix build of anon_inode_test

2025-05-30 Thread Mark Brown
On Sun, May 18, 2025 at 03:01:34PM +0100, Mark Brown wrote: > The anon_inode_test test fails to build due to attempting to include > a nonexisting overlayfs/wrapper.h: > > anon_inode_test.c:10:10: fatal error: overlayfs/wrappers.h: No such file or > directory >10 | #include "overlayfs/wrapper

Re: [RFC PATCH v1 3/6] mm: Avoid calling page allocator from apply_to_page_range()

2025-05-30 Thread Liam R. Howlett
* Ryan Roberts [250530 10:05]: > Lazy mmu mode applies to the current task and permits pte modifications > to be deferred and updated at a later time in a batch to improve > performance. apply_to_page_range() calls its callback in lazy mmu mode > and some of those callbacks call into the page allo

Re: [RFC PATCH v1 1/6] fs/proc/task_mmu: Fix pte update and tlb maintenance ordering in pagemap_scan_pmd_entry()

2025-05-30 Thread Ryan Roberts
On 30/05/2025 17:26, Jann Horn wrote: > On Fri, May 30, 2025 at 4:04 PM Ryan Roberts wrote: >> pagemap_scan_pmd_entry() was previously modifying ptes while in lazy mmu >> mode, then performing tlb maintenance for the modified ptes, then >> leaving lazy mmu mode. But any pte modifications during la

Re: [RFC PATCH v1 1/6] fs/proc/task_mmu: Fix pte update and tlb maintenance ordering in pagemap_scan_pmd_entry()

2025-05-30 Thread Jann Horn
On Fri, May 30, 2025 at 6:45 PM Ryan Roberts wrote: > On 30/05/2025 17:26, Jann Horn wrote: > > On Fri, May 30, 2025 at 4:04 PM Ryan Roberts wrote: > >> pagemap_scan_pmd_entry() was previously modifying ptes while in lazy mmu > >> mode, then performing tlb maintenance for the modified ptes, then

[PATCH bpf-next v2 2/2] selftests/bpf: Add test for bpftool access to read-only protected maps

2025-05-30 Thread Slava Imameev
Add selftest cases that validate bpftool's expected behavior when accessing maps protected from modification via security_bpf_map. The test includes a BPF program attached to security_bpf_map with two maps: - A protected map that only allows read-only access - An unprotected map that allows full a

[PATCH bpf-next v2 1/2] bpftool: Use appropriate permissions for map access

2025-05-30 Thread Slava Imameev
Modify several functions in tools/bpf/bpftool/common.c to allow specification of requested access for file descriptors, such as read-only access. Update bpftool to request only read access for maps when write access is not required. This fixes errors when reading from maps that are protected from

Re: [PATCH v2 1/1] mm/memory_hotplug: PG_offline_skippable for offlining memory blocks with PageOffline pages

2025-05-30 Thread Vlastimil Babka
On 5/20/25 18:42, David Hildenbrand wrote: > A long-term goal is supporting frozen PageOffline pages, and later > PageOffline pages that don't have a refcount at all. Some more work for Looking forward to that :) > that is needed -- in particular around non-folio page migration and > memory ballo

[PATCH v3 4/4] arm64: dts: qcom: msm8939: Add camss and cci

2025-05-30 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Add the camera subsystem and CCI used to interface with cameras on the Snapdragon 615. Signed-off-by: Vincent Knecht --- arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi | 4 + arch/arm64/boot/dts/qcom/msm8939.dtsi| 146 +++ 2 files changed, 1

Re: [RFC PATCH v1 1/6] fs/proc/task_mmu: Fix pte update and tlb maintenance ordering in pagemap_scan_pmd_entry()

2025-05-30 Thread Jann Horn
On Fri, May 30, 2025 at 4:04 PM Ryan Roberts wrote: > pagemap_scan_pmd_entry() was previously modifying ptes while in lazy mmu > mode, then performing tlb maintenance for the modified ptes, then > leaving lazy mmu mode. But any pte modifications during lazy mmu mode > may be deferred until arch_le

Re: [RFC PATCH v1 0/6] Lazy mmu mode fixes and improvements

2025-05-30 Thread Ryan Roberts
On 30/05/2025 15:47, Lorenzo Stoakes wrote: > +cc Jann who is a specialist in all things page table-y and especially scary > edge cases :) > > On Fri, May 30, 2025 at 03:04:38PM +0100, Ryan Roberts wrote: >> Hi All, >> >> I recently added support for lazy mmu mode on arm64. The series is now in >>

Re: [RFC PATCH v1 3/6] mm: Avoid calling page allocator from apply_to_page_range()

2025-05-30 Thread Ryan Roberts
On 30/05/2025 17:23, Liam R. Howlett wrote: > * Ryan Roberts [250530 10:05]: >> Lazy mmu mode applies to the current task and permits pte modifications >> to be deferred and updated at a later time in a batch to improve >> performance. apply_to_page_range() calls its callback in lazy mmu mode >> a

Re: [PATCH v2 3/3] remoteproc: imx_rproc: add power mode check for remote core attachment

2025-05-30 Thread Ulf Hansson
On Thu, 29 May 2025 at 22:15, Hiago De Franco wrote: > > On Thu, May 29, 2025 at 03:54:47AM +, Peng Fan wrote: > > [...] > > > > We are making progress ;-) > > > > > > With the patches you shared Ulf (I added them on top of the current > > > master branch), it works as expected, dev_pm_genpd_i

Re: [RFC PATCH v2 0/9] KVM: Enable Nested Virt selftests

2025-05-30 Thread Miguel Luis
Hi Ganapatrao, > On 12 May 2025, at 10:52, Ganapatrao Kulkarni > wrote: > > This patch series makes the selftest work with NV enabled. The guest code > is run in vEL2 instead of EL1. We add a command line option to enable > testing of NV. The NV tests are disabled by default. > The following

Re: [PATCH] fs/dax: Fix "don't skip locked entries when scanning entries"

2025-05-30 Thread Christian Brauner
On Fri, 23 May 2025 14:37:49 +1000, Alistair Popple wrote: > Commit 6be3e21d25ca ("fs/dax: don't skip locked entries when scanning > entries") introduced a new function, wait_entry_unlocked_exclusive(), > which waits for the current entry to become unlocked without advancing > the XArray iterator s

Re: [PATCH v3 2/4] media: qcom: camss: Add support for MSM8939

2025-05-30 Thread Bryan O'Donoghue
On 30/05/2025 12:49, Bryan O'Donoghue wrote: On 30/05/2025 10:00, Vincent Knecht via B4 Relay wrote: + camss->res->version == CAMSS_8x39 || This is not correct - it should be 893x since 8939 and 8936 are ~ the same SoC - probably 36 is just a binned version of 39. Anyway the x is the

Re: [RFC PATCH net-next v2 2/2] selftests: net: add XDP socket tests for virtio-net

2025-05-30 Thread Maciej Fijalkowski
On Thu, May 29, 2025 at 09:29:14PM +0700, Bui Quang Minh wrote: > On 5/29/25 18:18, Maciej Fijalkowski wrote: > > On Tue, May 27, 2025 at 11:19:04PM +0700, Bui Quang Minh wrote: > > > This adds a test to test the virtio-net rx when there is a XDP socket > > > bound to it. There are tests for both c

Re: [RFC PATCH v1 3/6] mm: Avoid calling page allocator from apply_to_page_range()

2025-05-30 Thread Liam R. Howlett
* Ryan Roberts [250530 12:50]: ... > > > > > > These wrappers are terrible for readability and annoying for argument > > lists too. > > Agreed. > > > > > Could we do something like the pgtbl_mod_mask or zap_details and pass > > through a struct or one unsigned int for create and lazy_mmu? >

[PATCH bpf-next 1/2] bpftool: Use appropriate permissions for map access

2025-05-30 Thread Slava Imameev
Modify several functions in tools/bpf/bpftool/common.c to allow specification of requested access for file descriptors, such as read-only access. Update bpftool to request only read access for maps when write access is not required. This fixes errors when reading from maps that are protected from

Re: [PATCH] kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests

2025-05-30 Thread Richard Fitzgerald
On 29/5/25 16:38, Jakub Kicinski wrote: On Fri, 11 Apr 2025 10:59:04 +0100 Richard Fitzgerald wrote: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests.config. This helps to detect use of uninitialized local variables. This option found an uninitialized data bug in the cs_dsp test. Signed-off-b

[PATCH bpf-next 2/2] selftests/bpf: Add test for bpftool access to read-only protected maps

2025-05-30 Thread Slava Imameev
Add selftest cases that validate bpftool's expected behavior when accessing maps protected from modification via security_bpf_map. The test includes a BPF program attached to security_bpf_map with two maps: - A protected map that only allows read-only access - An unprotected map that allows full a

Re: [RFC PATCH v2 0/9] KVM: Enable Nested Virt selftests

2025-05-30 Thread Oliver Upton
Hi Ganapat, On Mon, May 12, 2025 at 03:52:42AM -0700, Ganapatrao Kulkarni wrote: > This patch series makes the selftest work with NV enabled. The guest code > is run in vEL2 instead of EL1. We add a command line option to enable > testing of NV. The NV tests are disabled by default. > > Modified

Re: [PATCH v1 1/1] selftests/x86: Add a test to detect infinite sigtrap handler loop

2025-05-30 Thread Sohil Mehta
On 5/30/2025 4:07 PM, Xin Li (Intel) wrote: > When FRED is enabled, if the Trap Flag (TF) is set without an external > debugger attached, it can lead to an infinite loop in the SIGTRAP > handler. To avoid this, the software event flag in the augmented SS > must be cleared, ensuring that no single-

[PATCH net v2] selftests: net: build net/lib dependency in all target

2025-05-30 Thread Bui Quang Minh
We have the logic to include net/lib automatically for net related selftests. However, currently, this logic is only in install target which means only `make install` will have net/lib included. This commit moves the logic to all target so that all `make`, `make run_tests` and `make install` will h

Re: [PATCH net v2] selftests: net: build net/lib dependency in all target

2025-05-30 Thread Bui Quang Minh
On 5/31/25 12:10, Bui Quang Minh wrote: We have the logic to include net/lib automatically for net related selftests. However, currently, this logic is only in install target which means only `make install` will have net/lib included. This commit moves the logic to all target so that all `make`,

Re: [PATCH v3 2/4] media: qcom: camss: Add support for MSM8939

2025-05-30 Thread Konrad Dybcio
On 5/30/25 1:49 PM, Bryan O'Donoghue wrote: > On 30/05/2025 10:00, Vincent Knecht via B4 Relay wrote: >> +camss->res->version == CAMSS_8x39 || > > This is not correct - it should be 893x since 8939 and 8936 are ~ the > same SoC - probably 36 is just a binned version of 39. > > Anyway the

[PATCH v1 1/1] selftests/x86: Add a test to detect infinite sigtrap handler loop

2025-05-30 Thread Xin Li (Intel)
When FRED is enabled, if the Trap Flag (TF) is set without an external debugger attached, it can lead to an infinite loop in the SIGTRAP handler. To avoid this, the software event flag in the augmented SS must be cleared, ensuring that no single-step trap remains pending when ERETU completes. Thi