Re: [BUG] 2.6.21-rc1,2,3 regressions on my system that I found so far

(hm, google says i'm not the only one seeing this, so...) On Sun, 2007-03-18 at 00:32 +0100, Thomas Gleixner wrote: > Maxim, > > On Sun, 2007-03-18 at 01:00 +0200, Maxim wrote: > > >Mar 14 00:22:23 MAIN kernel: [2.072931] checking TSC synchronization > > >[CPU#0 -> CPU#1]: > > >Mar 14

Re: [PATCH] x86: Introduce REX prefix helper for kprobes

Masami Hiramatsu wrote: > Hi Harvey, > > Harvey Harrison wrote: >> Fold some small ifdefs into a helper function. >> >> Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> >> --- >> Masami, Ingo, I had this left in some unsent kprobes unification >> work. Depends on your tastes, but does reduce

[PATCH 10/52] KVM: Portability: Move kvm_vcpu_ioctl_get_dirty_log to arch-specific file

From: Zhang Xiantao <[EMAIL PROTECTED]> Meanwhile keep the interface in common, and leave as more logic in common as possible. Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |5 + drivers/kvm/kvm_main.c | 19

why do we call clear_active_flags in shrink_inactive_list ?

In 2.6.23's shrink_inactive_list function, why do we have to call clear_active_flags after isolate_lru_pages call ? IMHO, If it call isolate_lru_pages with "zone->inactive_list", It can be sure that it is not PG_active. So I think It is unnecessary calling clear_active_flags. Nonetheless, Why do

[PATCH 38/52] KVM: Portability: Split kvm_set_memory_region() to have an arch callout

From: Zhang Xiantao <[EMAIL PROTECTED]> Moving !user_alloc case to kvm_arch to avoid unnecessary code logic in non-x86 platform. Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |4 +++ drivers/kvm/kvm_main.c | 38

[PATCH 39/52] KVM: Split vcpu creation to avoid vcpu_load() before preemption setup

Split kvm_arch_vcpu_create() into kvm_arch_vcpu_create() and kvm_arch_vcpu_setup(), enabling preemption notification between the two. This mean that we can now do vcpu_load() within kvm_arch_vcpu_setup(). Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |1 +

[PATCH 26/52] KVM: Portability: Move x86 pic strutctures

From: Jerone Young <[EMAIL PROTECTED]> This patch moves structures: kvm_pic_state kvm_ioapic_state to inclue/asm-x86/kvm.h. Signed-off-by: Jerone Young <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- include/asm-x86/kvm.h | 49

[PATCH 31/52] KVM: Portability: Move cpuid structures to

From: Jerone Young <[EMAIL PROTECTED]> This patch moves structures: kvm_cpuid_entry kvm_cpuid from include/linux/kvm.h to include/asm-x86/kvm.h Signed-off-by: Jerone Young <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- include/asm-x86/kvm.h | 17

[PATCH 28/52] KVM: Portability: Move structure lapic_state to

From: Jerone Young <[EMAIL PROTECTED]> This patch moves structure lapic_state from include/linux/kvm.h to include/asm-x86/kvm.h Signed-off-by: Jerone Young <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- include/asm-x86/kvm.h |6 ++ include/linux/kvm.h |5

[PATCH 45/52] KVM: MMU: Introduce and use gpte_to_gfn()

Instead of repretitively open-coding this. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/paging_tmpl.h | 28 1 files changed, 20 insertions(+), 8 deletions(-) diff --git a/drivers/kvm/paging_tmpl.h b/drivers/kvm/paging_tmpl.h index 6e01301..6f79ae8

[PATCH 48/52] KVM: MMU: Remove set_pde()

It is now identical to set_pte(). Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/paging_tmpl.h | 25 - 1 files changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/kvm/paging_tmpl.h b/drivers/kvm/paging_tmpl.h index cc373ed..062f4f5 100644 ---

[PATCH 41/52] KVM: Add statistic for remote tlb flushes

Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |1 + drivers/kvm/kvm_main.c |3 +++ drivers/kvm/x86.c |1 + 3 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h index b65f5de..048849d 100644 ---

[PATCH 50/52] KVM: MMU: Adjust page_header_update_slot() to accept a gfn instead of a gpa

Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/mmu.c |7 --- drivers/kvm/paging_tmpl.h |3 +-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c index c3362ba..1dcffc4 100644 --- a/drivers/kvm/mmu.c +++

[PATCH 40/52] KVM: MMU: Implement guest page fault bypass for nonpae

I spent an hour worrying why I see so many guest page faults on FC6 i386. Turns out bypass wasn't implemented for nonpae. Implement it so it doesn't happen again. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/paging_tmpl.h |9 ++--- 1 files changed, 6 insertions(+), 3

[PATCH 52/52] KVM: MMU: Simplify nonpaging_map()

Instead of passing an hpa, pass a regular struct page. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/mmu.c | 24 ++-- 1 files changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c index 1dcffc4..1965185 100644 ---

[PATCH 49/52] KVM: MMU: Merge set_pte() and set_pte_common()

Since set_pte() is now the only caller of set_pte_common(), merge the two functions. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/paging_tmpl.h | 26 ++ 1 files changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/kvm/paging_tmpl.h

[PATCH 47/52] KVM: MMU: Remove extra gaddr parameter from set_pte_common()

Similar information is available in the gfn parameter, so use that. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/mmu.c |1 + drivers/kvm/paging_tmpl.h | 29 + 2 files changed, 10 insertions(+), 20 deletions(-) diff --git

[PATCH 51/52] KVM: MMU: Introduce gfn_to_gpa()

Converting a frame number to an address is tricky since the data type changes size. Introduce a function to do it. This fixes an actual bug when accessing guest ptes. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |4 drivers/kvm/paging_tmpl.h |4 ++--

[PATCH 44/52] KVM: MMU: Code cleanup

From: Izik Eidus <[EMAIL PROTECTED]> Signed-off-by: Izik Eidus <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/paging_tmpl.h | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/kvm/paging_tmpl.h

[PATCH 46/52] KVM: MMU: Move pse36 handling to the guest walker

Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/mmu.c |7 +++ drivers/kvm/paging_tmpl.h |5 ++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c index 346aa65..a9fed59 100644 --- a/drivers/kvm/mmu.c +++

[PATCH 42/52] KVM: MMU: Avoid unnecessary remote tlb flushes when guest updates a pte

If all we're doing is increasing permissions on a pte (typical for demand paging), then there's not need to flush remote tlbs. Worst case they'll get a spurious page fault. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/mmu.c | 27 ++- 1 files changed,

[PATCH 43/52] KVM: Don't bother the mmu if cr3 load doesn't change cr3

If the guest requests just a tlb flush, don't take the vm lock and drop the mmu context pointlessly. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/mmu.c |2 +- drivers/kvm/x86.c | 25 + drivers/kvm/x86.h |1 + 3 files changed, 27 insertions(+), 1

[PATCH 30/52] KVM: Portability: Move kvm_sregs and msr structures to

From: Jerone Young <[EMAIL PROTECTED]> Move structures: kvm_sregs kvm_msr_entry kvm_msrs kvm_msr_list from include/linux/kvm.h to include/asm-x86/kvm.h Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- include/asm-x86/kvm.h | 36

[PATCH 37/52] KVM: Recalculate mmu pages needed for every memory region change

From: Zhang Xiantao <[EMAIL PROTECTED]> Instead of incrementally changing the mmu cache size for every memory slot operation, recalculate it from scratch. This is simpler and safer. Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> ---

[PATCH 34/52] KVM: MMU: Selectively set PageDirty when releasing guest memory

From: Izik Eidus <[EMAIL PROTECTED]> Improve dirty bit setting for pages that kvm release, until now every page that we released we marked dirty, from now only pages that have potential to get dirty we mark dirty. Signed-off-by: Izik Eidus <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL

[PATCH 36/52] KVM: x86 emulator: prefetch up to 15 bytes of the instruction executed

Instead of fetching one byte at a time, prefetch 15 bytes (or until the next page boundary) to avoid guest page table walks. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 38 -- drivers/kvm/x86_emulate.h |7 +++ 2

[PATCH 33/52] KVM: MMU: Fix potential memory leak with smp real-mode

From: Izik Eidus <[EMAIL PROTECTED]> When we map a page, we check whether some other vcpu mapped it for us and if so, bail out. But we should decrease the refcount on the page as we do so. Signed-off-by: Izik Eidus <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> ---

[PATCH 32/52] KVM: Export include/asm-x86/kvm.h

Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- include/asm-x86/Kbuild |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/asm-x86/Kbuild b/include/asm-x86/Kbuild index 12db5a1..da5eb69 100644 --- a/include/asm-x86/Kbuild +++ b/include/asm-x86/Kbuild @@ -3,6 +3,7 @@

[PATCH 35/52] KVM: x86 emulator: retire ->write_std()

Theoretically used to acccess memory known to be ordinary RAM, it was never implemented. It is questionable whether it is possible to implement it correctly. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86.c | 10 -- drivers/kvm/x86_emulate.h | 11

[PATCH 27/52] KVM: Portability: Move kvm_regs to

From: Jerone Young <[EMAIL PROTECTED]> This patch moves structure kvm_regs to include/asm-x86/kvm.h. Each architecture will need to create there own version of this structure. Signed-off-by: Jerone Young <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- include/asm-x86/kvm.h

[PATCH 29/52] KVM: Portability: Move kvm_segment & kvm_dtable structure to

From: Jerone Young <[EMAIL PROTECTED]> This patch moves structures: kvm_segment kvm_dtable from include/linux/kvm.h to include/asm-x86/kvm.h Signed-off-by: Jerone Young <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- include/asm-x86/kvm.h | 17

[PATCH 25/52] KVM: Portability: Move kvm_memory_alias to asm/kvm.h

From: Jerone Young <[EMAIL PROTECTED]> This patch moves sturct kvm_memory_alias from include/linux/kvm.h to include/asm-x86/kvm.h. Also have include/linux/kvm.h include include/asm/kvm.h. Signed-off-by: Jerone Young <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> ---

[PATCH 24/52] KVM: Move misplaced comment

From: Hollis Blanchard <[EMAIL PROTECTED]> Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h index

[PATCH 21/52] KVM: MMU: Remove unused variable

Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/paging_tmpl.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/paging_tmpl.h b/drivers/kvm/paging_tmpl.h index be66401..77a2b22 100644 --- a/drivers/kvm/paging_tmpl.h +++ b/drivers/kvm/paging_tmpl.h

[PATCH 20/52] KVM: Add missing #include

Needed for empty_zero_page. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c index 469e6b4..d6c5191 100644 --- a/drivers/kvm/kvm_main.c +++

[PATCH 22/52] KVM: Remove unused "rmap_overflow" variable

From: Hollis Blanchard <[EMAIL PROTECTED]> Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h index 1901456..ba78a45

[PATCH 23/52] KVM: Correct consistent typo: "destory" -> "destroy"

From: Hollis Blanchard <[EMAIL PROTECTED]> Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |2 +- drivers/kvm/kvm_main.c |2 +- drivers/kvm/x86.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 16/52] KVM: Portability: Move some function declarations to x86.h

From: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h | 84 - drivers/kvm/x86.h | 84

[PATCH 18/52] KVM: MMU: Change guest pte access to kvm_{read,write}_guest()

From: Izik Eidus <[EMAIL PROTECTED]> Things are simpler and more regular this way. Signed-off-by: Izik Eidus <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/paging_tmpl.h | 24 +--- 1 files changed, 5 insertions(+), 19 deletions(-) diff

[PATCH 13/52] KVM: Portability: Move struct kvm_x86_ops definition to x86.h

From: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h | 69 - drivers/kvm/x86.h | 67 +++

[PATCH 15/52] KVM: Move some static inline functions out from kvm.h into x86.h

From: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h | 109 drivers/kvm/x86.h | 110 +

[PATCH 17/52] KVM: VMX: Force seg.base == (seg.sel << 4) in real mode

From: Jan Kiszka <[EMAIL PROTECTED]> Ensure that segment.base == segment.selector << 4 when entering the real mode on Intel so that the CPU will not bark at us. This fixes some old protected mode demo from http://www.x86.org/articles/pmbasics/tspec_a1_doc.htm. Signed-off-by: Jan Kiszka <[EMAIL

[PATCH 14/52] KVM: Portability: Move vcpu regs enumeration definition to x86.h

From: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h | 35 --- drivers/kvm/x86.h | 35 +++ 2 files changed, 35

[PATCH 19/52] KVM: Simplify kvm_clear_guest_page()

From: Izik Eidus <[EMAIL PROTECTED]> Use kvm_write_guest_page() with empty_zero_page, instead of doing kmap and memset. Signed-off-by: Izik Eidus <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c | 17 + 1 files changed, 1

[PATCH 11/52] KVM: Portability: MMU initialization and teardown split

From: Zhang Xiantao <[EMAIL PROTECTED]> Move out kvm_mmu init and exit functionality from kvm_main.c Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c |8 drivers/kvm/x86.c | 24 +++-

[PATCH 12/52] KVM: Portability: Move some macro definitions from kvm.h to x86.h

From: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h | 33 - drivers/kvm/x86.h | 33 + 2 files changed, 33 insertions(+), 33

[PATCH 07/52] KVM: Extend stats support for VM stats

This is in addition to the current virtual cpu statistics. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h | 14 -- drivers/kvm/kvm_main.c | 26 +++--- drivers/kvm/x86.c | 39 --- 3 files

[PATCH 09/52] KVM: Make unloading of FPU state when putting vcpu arch-independent

From: Amit Shah <[EMAIL PROTECTED]> Instead of having each architecture do it individually, we do this in the arch-independent code (just x86 as of now). [avi: add svm to the mix, which was added to mainline during the 2.6.24-rc process] Signed-off-by: Amit Shah <[EMAIL PROTECTED]>

[PATCH 05/52] KVM: Add fpu_reload counter

Measure the number of times we switch the fpu state. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |1 + drivers/kvm/x86.c |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h index 04efe88..a85c590 100644 ---

[PATCH 08/52] KVM: MMU: Add some mmu statistics

Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |6 ++ drivers/kvm/mmu.c |9 - drivers/kvm/x86.c |6 ++ 3 files changed, 20 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h index d3171f9..bdcc44e 100644 ---

[PATCH 04/52] KVM: Replace 'light_exits' stat with 'host_state_reload'

This is a little more accurate (since it counts actual reloads, not potential reloads), and reverses the sense of the statistic to measure a bad event like most of the other stats (e.g. we want to minimize all counters). Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |2

[PATCH 06/52] KVM: Add instruction emulation statistics

--- drivers/kvm/kvm.h |2 ++ drivers/kvm/x86.c |4 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h index a85c590..5a8a9af 100644 --- a/drivers/kvm/kvm.h +++ b/drivers/kvm/kvm.h @@ -249,6 +249,8 @@ struct kvm_stat { u32

[PATCH 03/52] KVM: Portability: Add two hooks to handle kvm_create and destroy vm

From: Zhang Xiantao <[EMAIL PROTECTED]> Add two arch hooks to handle kvm_create_vm and kvm destroy_vm. Now, just put io_bus init and destory in common. Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |4

[PATCH 02/52] KVM: Remove __init attributes for kvm_init_debug and kvm_init_msr_list

From: Zhang Xiantao <[EMAIL PROTECTED]> Since their callers are not declared with __init. Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c |2 +- drivers/kvm/x86.c |2 +- 2 files changed, 2 insertions(+), 2

[PATCH 00/52] KVM patch queue review for 2.6.25 merge window (part III)

The third installment of the 2.6.25 kvm patch queue, for your reviewing pleasure. This time, a diffstat of the files affected by these 53 patches is appended. drivers/kvm/kvm.h | 384 ++--- drivers/kvm/kvm_main.c| 192 +++---

[PATCH 01/52] KVM: Remove ptr comparisons to 0

From: Joe Perches <[EMAIL PROTECTED]> Fix sparse warnings "Using plain integer as NULL pointer" Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |2 +- drivers/kvm/kvm_main.c |3 ++- drivers/kvm/svm.c |2 +-

[PATCH] include/asm-alpha/core_cia.h, kernel 2.6.23.12

[please Cc: me on followups] Trying to compile 2.6.23.12 on alpha (a miata) resulted in this failure: cc1: warnings being treated as errors include/asm/io_trivial.h: In function 'cia_readb': include/asm/io_trivial.h:75: warning: passing argument 1 of 'cia_ioread8' discards qualifiers from

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

On Saturday 29 December 2007, Alan Stern wrote: > lockdep warns whenever a task acquires a mutex while holding another > mutex of the same kind (that is, the same member in another structure > of the same type).  But there are lots of places where the kernel needs > to acquire dev->sem for one

Re: [PATCH] x86: kprobes remove fix_riprel #ifdef

Hello Harvey, A similar idea was already nack-ed by Ananth. http://sources.redhat.com/ml/systemtap/2007-q4/msg00468.html And I agree his thought. Especially, "riprel" does not exist on x86_32, so fix_riprel() is meaningless on it. Thus, I think it would better be ifdef'd in call-site. Harvey

Re: [PATCH] x86: Introduce REX prefix helper for kprobes

Hi Harvey, Harvey Harrison wrote: > Fold some small ifdefs into a helper function. > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> > --- > Masami, Ingo, I had this left in some unsent kprobes unification > work. Depends on your tastes, but does reduce ifdefs and is a bit > better about

Re: TOMOYO Linux Security Goal

On Sun, 30 Dec 2007 14:29:50 +0900, Tetsuo Handa said: > Use of "learning mode" is independent from "correct policy". My point *exactly*. > The "learning mode" merely takes your duty of appending permissions to policy. > We can develop and share procedures for how to exercise infrequently used

Re: [RFC/PATCH] e100 driver didn't support any MII-less PHYs...

Andreas Mohr wrote: > Hi all, > > I was mildly annoyed when rebooting my _headless_ internet gateway after a > hotplug -> udev migration and witnessing it not coming up again, > which turned out to be due to an eepro100 / e100 loading conflict > since eepro100 supported both of my Intel-based

Re: 2.6.24-rc6-mm1

On Sun, 30 Dec 2007 04:34:36 +0100 Torsten Kaiser wrote: > On Dec 30, 2007 2:30 AM, Herbert Xu <[EMAIL PROTECTED]> wrote: > > On Sat, Dec 29, 2007 at 05:51:13PM +0100, Torsten Kaiser wrote: > > > > > > > > The cause, why I am resending this: I just got a crash with > > > > > 2.6.24-rc6-mm1, again

Re: TOMOYO Linux Security Goal

Hello. [EMAIL PROTECTED] wrote: > Please make a *big* notation someplace that "learning mode" is quite likely to > *not* produce a totally correct policy. In particular, it won't build rules > for > infrequently used code paths (such as error handling) unless you find a way to > exercise those

SATA buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

I needed to get a new hard disk for one of my systems and thought that it was about time to start going with SATA. I picked up a Promise 4-Port Sata300-TX4 to go with a 750G Seagate SATA -- I'd had good luck with a Promise ATA100 (P)ATA and lower capacity Seagates and thought it would be a good

Re: [PATCH] security: remove security_sb_post_mountroot hook

On Sat, 29 Dec 2007, H. Peter Anvin wrote: > The security_sb_post_mountroot() hook is long-since obsolete, and is > fundamentally broken: it is never invoked if someone uses initramfs. > This is particularly damaging, because the existence of this hook has > been used as motivation for not using

Re: [RFC] USB driver for talking to the Microchip PIC18 boot loader

On Dec 30, 2007 11:53 AM, mgross <[EMAIL PROTECTED]> wrote: > Yeah, it has been done from user space using a libusb based > application. (that didn't work with a usb-hub in the loop) and had > code that was just too nasty for words, so I made a kernel driver that > looks nicer to me and enables a

Re: [RFC] USB driver for talking to the Microchip PIC18 boot loader

On Dec 30, 2007 12:29 PM, mgross <[EMAIL PROTECTED]> wrote: > The device ID's are different 0x000C in ldusb.c vrs 0x000b in the > driver I just posted. I know that. 000b is for the demo application. 000c is for the bootloader application. I am not a progammer myself but I think the USB

Re: [RFC] USB driver for talking to the Microchip PIC18 boot loader

On Sun, Dec 30, 2007 at 10:40:45AM +0800, Xiaofan Chen wrote: > On Dec 30, 2007 6:15 AM, Alan Stern <[EMAIL PROTECTED]> wrote: > > On Sat, 29 Dec 2007, mgross wrote: > > > > > I'm playing around with a PIC based project at home (not an Intel > > > activity) and found I needed a usb driver to talk

Re: RFC: permit link(2) to work across --bind mounts ?

On Sat, 29 Dec 2007, [EMAIL PROTECTED] wrote: > On Sat, 29 Dec 2007 12:40:47 PST, dean gaudet said: > > > the main worry i have is some user maliciously hardlinks everything > > under /var/log somewhere else and slowly fills up the file system with > > old rotated logs. > > "Doctor, it hurts

Re: [RFC] USB driver for talking to the Microchip PIC18 boot loader

On Sat, Dec 29, 2007 at 05:15:30PM -0500, Alan Stern wrote: > On Sat, 29 Dec 2007, mgross wrote: > > > I'm playing around with a PIC based project at home (not an Intel > > activity) and found I needed a usb driver to talk to the boot loader > > so I can program my USB Bitwhacker with new custom

[PATCH] x86_64: clear IO_APIC before enabing apic error vector. v2

please check if you can replace the one in the x86-mm http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commitdiff;h=ffcbdc220a1520d006a837f33589c7c19ffbeb76 the updated one avoid one link warning. YH [PATCH] x86_64: clear IO_APIC before enabing apic error vector. v2 some apic

Re: RFC: permit link(2) to work across --bind mounts ?

On Sat, 29 Dec 2007 12:40:47 PST, dean gaudet said: > > See, this is where you show that you don't understand the system. I'll > > explain it, just once. /var/home contains home directories. /var/log and > > /var/home are on the same filesystem. So /var/log/* can be linked to > >

[PATCH] x86: provide a DMI based port 0x80 I/O delay override

Hi Linus. [ resend, forgot the CC to linux-kernel. sorry ] This fixes "hwclock" triggered boottime hangs for a few HP/Compaq laptops and might as such be applicable to 2.6.24 still. The kernel's use of an outb to port 0x80 as an I/O delay disagrees with these machines (after ACPI is live, that

Re: 2.6.24-rc6-mm1

On Dec 30, 2007 2:30 AM, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Sat, Dec 29, 2007 at 05:51:13PM +0100, Torsten Kaiser wrote: > > > > > > The cause, why I am resending this: I just got a crash with > > > > 2.6.24-rc6-mm1, again looking network related: > > > > > > > > [93436.933356] WARNING: at

Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)

On 30-12-07 02:49, Islam Amer wrote: Glad I could be of help. Sure please go ahead, I will keep testing this patch with upcoming git kernels, and report any problems. Thanks. I'll see if Linus wants it for 2.6.24 still. Could be minimal enough. So what I understand now is that AMD C1E

Re: [BUG][PATCH] bluetooth: put_device before device_del fix

From: Dave Young <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 13:27:50 +0800 > Because of workqueue delay, the put_device could be called before device_del, > so move it to del_conn. > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> Applied, thanks Dave. Please post bluetooth patches, just

Re: 2.6.24-rc6-mm1 - crash in tick_sched_timer/update_process_times

On Thu, 27 Dec 2007 12:54:34 EST, [EMAIL PROTECTED] said: > [15345.901919] Unable to handle kernel paging request at 00af008c00cd RIP: > [15345.901934] [] scheduler_tick+0xdb/0x1c4 > [15345.901952] PGD 0 > [15345.901959] Oops: [1] PREEMPT SMP > [15345.901972] last sysfs file:

Re: [PATCH] Fix broken ip= parsing

From: Thomas Bogendoerfer <[EMAIL PROTECTED]> Date: Sat, 29 Dec 2007 18:08:49 +0100 (CET) > Commit a6c05c3d064dbb83be88cba3189beb5db9d2dfc3 breaks ip= parsing > completly, because ic_enable is never set. The patch below puts > back the way ic_enable was set before. > > Signed-off-by: Thomas

Re: [RFC] USB driver for talking to the Microchip PIC18 boot loader

On Dec 30, 2007 6:15 AM, Alan Stern <[EMAIL PROTECTED]> wrote: > On Sat, 29 Dec 2007, mgross wrote: > > > I'm playing around with a PIC based project at home (not an Intel > > activity) and found I needed a usb driver to talk to the boot loader > > so I can program my USB Bitwhacker with new

Re: eMMC and MMC plus card supports

Sandeep K wrote: Hi all, Can anybody please let me know, does the current linux tree supports MMC plus and eMMC cards. It certainly supports MMCplus. My understanding is that eMMC is just a form-factor and is not visibly different to the host controller, so it should just work. I know that

Re: [PATCH] x86: unify x86 Makefile(s)

> Without inlining the maxmimum stack usage inside foobar() is > max(stack usage foo(), stack usage bar()). [1] It's a little more complicated. gcc 4.x (not sure which x, might 0) is clever enough to not use max() stack, but only use the stack for the different scopes as needed similar as when

Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)

Glad I could be of help. Sure please go ahead, I will keep testing this patch with upcoming git kernels, and report any problems. So what I understand now is that AMD C1E state saves battery like dynticks, so we don't need dynticks ? On Sun, 2007-12-30 at 02:38 +0100, Rene Herman wrote: > On

Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)

On 29-12-07 23:28, Islam Amer wrote: Thanks for the detailed response. I thought I had gotten to the bottom of my problems when I found that udev workaround, I guess I was naive. I did the two tests you described and they predictably caused the hard hangs. I needed to run the port80 program

Re: 2.6.24-rc6-mm1

On Sat, Dec 29, 2007 at 05:51:13PM +0100, Torsten Kaiser wrote: > > > > The cause, why I am resending this: I just got a crash with > > > 2.6.24-rc6-mm1, again looking network related: > > > > > > [93436.933356] WARNING: at include/net/dst.h:165 dst_release() > > > [93436.936685] Pid: 8079, comm:

Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)

Sorry, pressed send too soon. here is the line in dmesg: Compaq Presario v6000: using alternate I/O delay port Thanks, please tell me if you need anymore info. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] security: remove security_sb_post_mountroot hook

--- "H. Peter Anvin" <[EMAIL PROTECTED]> wrote: > The security_sb_post_mountroot() hook is long-since obsolete, and is > fundamentally broken: it is never invoked if someone uses initramfs. > This is particularly damaging, because the existence of this hook has > been used as motivation for not

Re: Fwd: laptop / computer hardlocks during execution of 32bit applications(binaries) on 64bit system (Gentoo)

On Sunday 30 December 2007 00:04:17 Matthew wrote: > so I was wrong XD > > sorry, > > the error was found in the meantime: > > see: http://forums.gentoo.org/viewtopic-p-4667858.html#4667858 > > Don't need to do more testing. The culprit is the unification of the > x86 i387 code. > > The culprit is

Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)

Thanks for the detailed response. I thought I had gotten to the bottom of my problems when I found that udev workaround, I guess I was naive. I did the two tests you described and they predictably caused the hard hangs. I needed to run the port80 program only once to get the hard hang. The

[PATCH] security: remove security_sb_post_mountroot hook

The security_sb_post_mountroot() hook is long-since obsolete, and is fundamentally broken: it is never invoked if someone uses initramfs. This is particularly damaging, because the existence of this hook has been used as motivation for not using initramfs. Stephen Smalley confirmed on 2007-07-19

Re: TOMOYO Linux Security Goal

On Fri 2007-12-28 12:23:51, [EMAIL PROTECTED] wrote: > On Fri, 28 Dec 2007 23:32:09 +0900, Tetsuo Handa said: > > > You can run your system with only policy collected by learning mode. > > Thus, you basically don't need manual intervention. > > But since there are randomly named files (i.e.

Fwd: laptop / computer hardlocks during execution of 32bit applications(binaries) on 64bit system (Gentoo)

so I was wrong XD sorry, the error was found in the meantime: see: http://forums.gentoo.org/viewtopic-p-4667858.html#4667858 Don't need to do more testing. The culprit is the unification of the x86 i387 code. The culprit is 57c3da2f5bb3fafedc31284117ae43bc593b65ab or

Re: almost daily Kernel oops with 2.6.23.9 - and now 2.6.23.11 as well

Hi, you guys were right, I was wrong. It is the hardware. I increased ram voltage by 0.15V on the 22nd and hadn't any oopses since then. And I did torture the system. I am deeply sorry that I wasted your time (but still puzzled that the oopses started after kernel update - maybe I should

Re: [PATCH] Fix broken ip= parsing

On 29/12/2007, Thomas Bogendoerfer <[EMAIL PROTECTED]> wrote: > Commit a6c05c3d064dbb83be88cba3189beb5db9d2dfc3 breaks ip= parsing > completly, because ic_enable is never set. The patch below puts > back the way ic_enable was set before. > > Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> >

Re: [RFC] sleepy linux

Hi! > > ... I also don't need to call any suspend() routines, because all the > > drivers are already suspended, right? > > Well, you have a number of devices which cannot do runtime pm. > They can do suspend/resume with the whole system. For them these > operations mean saving/restoring state.

Re: [RFC] sleepy linux

Hi! > > > > Is there an easy way to tell if all the devices are runtime suspended? > > > > > > Do you really want to know whether they are suspended or whether they > > > could be suspended? > > > > If they are suspended. > > > > My plan is: let the drivers autosuspend on their own. If I see

Re: [RFC] sleepy linux

Hi! > >NOHZ + C4 + turn off screen + turn off disk + turn off SATA is still > >~8W on thinkpad x60. > > > >S3 is ~1W. > > > >That's quite significant difference. > > > >(But yes, connected-to-ethernet is not most important use scenario.) > >

Re: [PATCH] Hibernation: Document __save_processor_state() on x86-64

Hi! > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > Document the fact that __save_processor_state() has to save all CPU > registers referred to by the kernel in case a different kernel is > used to load and restore a hibernation image containing it. > Sigend-off-by: Rafael J. Wysocki

Re: Top 9 kernel oopses/warnings for the week of December 29th, 2007

On Sat, 29 Dec 2007, Linus Torvalds wrote: > On Sat, 29 Dec 2007, Arjan van de Ven wrote: > > hmmm.. the copy in my Sent folder looks fine, as does the one in the lkml > > archive: > > http://lkml.org/lkml/2007/12/29/41 > > > > This is distinctly weird. > > Ahh, it seems to be a alpine bug.

Re: [RFC] USB driver for talking to the Microchip PIC18 boot loader

On Sat, 29 Dec 2007, mgross wrote: > I'm playing around with a PIC based project at home (not an Intel > activity) and found I needed a usb driver to talk to the boot loader > so I can program my USB Bitwhacker with new custom firmware. The > following adds the pic18bl driver to the kernel. Its

  1   2   3   4   >