Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Matthew Wilcox
On Sun, Jan 13, 2008 at 12:24:15AM -0700, Matthew Wilcox wrote: > Here's a patch (on top of Ivan's) to improve things further. Oops. I forgot to check the ordering of mmconfig vs direct probing, so that patch would end up just using mmconfig for everything. Not what we want. Also, there's

2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-12 Thread Valdis . Kletnieks
I'm seeing problems with Sendmail on 24-rc6-mm1, where the main Sendmail is listening on ::1/25, and Fetchmail connects to 127.0.0.1:25 to inject mail it has just fetched from an outside server via IMAP - it will often just hang and not make any further progress. Looking at netstat shows something

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-12 Thread Sam Ravnborg
> > +#ifdef CONFIG_HOTPLUG > +#define DEV_KEEP(sec) > +#define DEV_DISCARD(sec) *(.dev##sec) > +#else > +#define DEV_KEEP(sec)*(.dev##sec) > +#define DEV_DISCARD(sec) > +#endif > + > +#ifdef CONFIG_HOTPLUG_CPU > +#define CPU_KEEP(sec) > +#define CPU_DISCARD(sec) *(.cpu##sec) > +#else >

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Matthew Wilcox
On Sun, Jan 13, 2008 at 06:08:05PM +1100, Benjamin Herrenschmidt wrote: > On Sat, 2008-01-12 at 17:40 +0300, Ivan Kokshaysky wrote: > > Actually I'm strongly against Arjan's patch. First, it's based on > > assumption that the MMCONFIG thing is sort of fundamentally broken > > on some systems, but

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Loic Prylli
On 1/13/2008 1:01 AM, Matthew Wilcox wrote: On Sat, Dec 29, 2007 at 12:12:19AM +0300, Ivan Kokshaysky wrote: On Fri, Dec 28, 2007 at 12:40:53PM -0500, Loic Prylli wrote: One thing that could be changed in pci_cfg_space_size() is to avoid making a special case for PCI-X 266MHz/533Mhz

Re: backlight module for nvidia cards -- control backlight even with offb

2008-01-12 Thread Benjamin Herrenschmidt
No time to look at this right now, please ping me if you have no news in a week or so. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Benjamin Herrenschmidt
On Sat, 2008-01-12 at 17:40 +0300, Ivan Kokshaysky wrote: > > Actually I'm strongly against Arjan's patch. First, it's based on > assumption that the MMCONFIG thing is sort of fundamentally broken > on some systems, but none of the facts we have so far does confirm > that. > And second, I really

Re: regression: 100% io-wait with 2.6.24-rcX

2008-01-12 Thread Fengguang Wu
On Sun, Jan 13, 2008 at 12:32:30AM +0100, Joerg Platte wrote: > Am Freitag, 11. Januar 2008 schrieb Fengguang Wu: > > On Thu, Jan 10, 2008 at 11:03:05AM +0100, Joerg Platte wrote: > > > Am Donnerstag, 10. Januar 2008 schrieb Fengguang Wu: > > > > > problem, because the iowait problem disappeared

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Jeff Garzik
Matthew Wilcox wrote: On Sat, Jan 12, 2008 at 08:42:48PM -0800, Arjan van de Ven wrote: Wanne bet there'll be devices that screw this up? THere's devices that even screwed up the 64-256 region after all. I don't know if they 'screwed it up'. There are devices that misbehave when registers

Re: -mm: pnp-do-not-stop-start-devices-in-suspend-resume-path.patch breaks resuming isapnp cards

2008-01-12 Thread Rene Herman
On 13-01-08 06:50, Bjorn Helgaas wrote: On Saturday 12 January 2008 1:08:01 pm Rene Herman wrote: pnp-do-not-stop-start-devices-in-suspend-resume-path.patch in current -mm breaks resuming isapnp cards from hibernation. They need the pnp_start_dev to enable the device again after hibernation.

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Matthew Wilcox
On Sat, Dec 29, 2007 at 12:12:19AM +0300, Ivan Kokshaysky wrote: > On Fri, Dec 28, 2007 at 12:40:53PM -0500, Loic Prylli wrote: > > One thing that could be changed in pci_cfg_space_size() is to avoid > > making a special case for PCI-X 266MHz/533Mhz (assume cfg_size == 256 > > for such devices

Re: -mm: pnp-do-not-stop-start-devices-in-suspend-resume-path.patch breaks resuming isapnp cards

2008-01-12 Thread Bjorn Helgaas
On Saturday 12 January 2008 1:08:01 pm Rene Herman wrote: > pnp-do-not-stop-start-devices-in-suspend-resume-path.patch in current -mm > breaks resuming isapnp cards from hibernation. They need the pnp_start_dev > to enable the device again after hibernation. > > They don't really need the

Re: [patch 18/19] account mlocked pages

2008-01-12 Thread Rik van Riel
On Fri, 11 Jan 2008 18:21:09 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > * Rik van Riel <[EMAIL PROTECTED]> [2008-01-08 15:59:57]: > > The following patch is required to compile the code with > CONFIG_NORECLAIM enabled and CONFIG_NORECLAIM_MLOCK disabled. I have untangled the #ifdefs to

Re: [PATCH] Clustering indirect blocks in Ext3

2008-01-12 Thread Abhishek Rai
Thanks for the great feedback Daniel! Following this email, I'll be sending out two separate emails with the actual patches, one against the latest stable kernel and one against the latest mm patch, using the format suggested by you. Sorry about the tabs and spaces thing, I've fixed my email

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-12 Thread Rik van Riel
On Sun, 13 Jan 2008 07:39:59 +0300 Anton Salikhmetov <[EMAIL PROTECTED]> wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > Changes for updating the ctime and mtime fields for memory-mapped files: > > 1) new flag triggering update of the inode data; > 2) new function to update ctime

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Matthew Wilcox
On Sat, Jan 12, 2008 at 08:42:48PM -0800, Arjan van de Ven wrote: > Wanne bet there'll be devices that screw this up? THere's devices that even > screwed > up the 64-256 region after all. I don't know if they 'screwed it up'. There are devices that misbehave when registers are read from pci

Re: [PATCH 1/2] massive code cleanup of sys_msync()

2008-01-12 Thread Rik van Riel
On Sun, 13 Jan 2008 07:39:58 +0300 Anton Salikhmetov <[EMAIL PROTECTED]> wrote: > Substantial code cleanup of the sys_msync() function: > > 1) using the PAGE_ALIGN() macro instead of "manual" alignment; > 2) improved readability of the loop traversing the process memory regions. > >

Re: [RFC][PATCH] per-task I/O throttling

2008-01-12 Thread Balbir Singh
* Andrea Righi <[EMAIL PROTECTED]> [2008-01-12 19:01:14]: > Peter Zijlstra wrote: > > On Sat, 2008-01-12 at 16:27 +0530, Balbir Singh wrote: > >> * Peter Zijlstra <[EMAIL PROTECTED]> [2008-01-12 10:46:37]: > >> > >>> On Fri, 2008-01-11 at 23:57 -0500, [EMAIL PROTECTED] wrote: > On Fri, 11

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Arjan van de Ven
On Sat, 12 Jan 2008 20:36:59 -0500 Tony Camuso <[EMAIL PROTECTED]> wrote: > Thanks, Arjan. > > The problem we have been experiencing has to do with Northbridges, > not with devices. correct for now. HOWEVER, and this is the point Linus has made several times: Just about NOBODY has devices that

[PATCH 2/2] updating ctime and mtime at syncing

2008-01-12 Thread Anton Salikhmetov
http://bugzilla.kernel.org/show_bug.cgi?id=2645 Changes for updating the ctime and mtime fields for memory-mapped files: 1) new flag triggering update of the inode data; 2) new function to update ctime and mtime for block device files; 3) new helper function to update ctime and mtime when

[PATCH 0/2] yet another attempt to fix the ctime and mtime issue

2008-01-12 Thread Anton Salikhmetov
The POSIX standard requires that the ctime and mtime fields for memory-mapped files should be updated after a write reference to the memory region where the file data is mapped. At least FreeBSD 6.2 and HP-UX 11i implement this properly. Linux does not, which leads to data loss problems in

[PATCH 1/2] massive code cleanup of sys_msync()

2008-01-12 Thread Anton Salikhmetov
Substantial code cleanup of the sys_msync() function: 1) using the PAGE_ALIGN() macro instead of "manual" alignment; 2) improved readability of the loop traversing the process memory regions. Signed-off-by: Anton Salikhmetov <[EMAIL PROTECTED]> --- mm/msync.c | 78

Re: Huawei EC321 CDMA PCCARD support broken

2008-01-12 Thread Zhang Weiwu
Daolong Wang wrote: > Sigh! I was just going to buy one…… > If you found any CDMA PCCARD working for Linux, please also let me know, I am looking for a replacement myself. If you wait a few weeks later, I get a Ubuntu 6.04 live CD from my Beijing office and then I'll let you know if this

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread James Bottomley
On Sat, 2008-01-12 at 19:38 -0600, Robert Hancock wrote: > James Bottomley wrote: > > On Sat, 2008-01-12 at 17:04 -0600, Robert Hancock wrote: > >> I don't think the problem is that there's some buffer which is getting > >> allocated above 4GB and never bounced, since the problem goes away if >

Re: [kvm-devel] boot stops after console handover?

2008-01-12 Thread Carlo Marcelo Arenas Belon
On Sun, Jan 13, 2008 at 01:19:13AM +, Antoine Martin wrote: > Carlo Marcelo Arenas Belon wrote: > > On Sat, Jan 12, 2008 at 11:01:28PM +0200, Avi Kivity wrote: > >> Antoine Martin wrote: > >> > >>> FYI, just tried building 2.6.24-rc7-git4 and got this warning: > >>> (...) > >> Probably

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Robert Hancock
Linus Torvalds wrote: On Fri, 11 Jan 2008, Matthew Wilcox wrote: Did I miss a bug report? The only problems I'm currently aware of are the ones where using MMCONFIG during BAR probing causes a hard lockup on some Intel machines, and the ones where we get bad config data on some AMD machines

[PATCH] Documentation: Add 00-INDEX file for AoE

2008-01-12 Thread Jesper Juhl
Documentation/aoe/ is missing a 00-INDEX file. Add one. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- 00-INDEX | 18 ++ 1 file changed, 18 insertions(+) --- /dev/null 2005-11-21 04:22:37.0 +0100 +++ linux-2.6/Documentation/aoe/00-INDEX2008-01-13

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread Robert Hancock
James Bottomley wrote: On Sat, 2008-01-12 at 17:04 -0600, Robert Hancock wrote: I don't think the problem is that there's some buffer which is getting allocated above 4GB and never bounced, since the problem goes away if ADMA is disabled entirely and the DMA mask remains 32-bit always. My

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Tony Camuso
Thanks, Arjan. The problem we have been experiencing has to do with Northbridges, not with devices. As far as the device is concerned, after the Northbridge translates the config access into PCI bus cycles, the device has no idea what mechanism drove the Northbridge to the translation. That is

Re: [kvm-devel] boot stops after console handover?

2008-01-12 Thread Antoine Martin
Carlo Marcelo Arenas Belon wrote: > On Sat, Jan 12, 2008 at 11:01:28PM +0200, Avi Kivity wrote: >> Antoine Martin wrote: >> >>> FYI, just tried building 2.6.24-rc7-git4 and got this warning: >>> (...) >> Probably harmless, but worth reporting to lkml. > > couldn't replicate it here, but I'd seen

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Arjan van de Ven
On Sat, 12 Jan 2008 19:12:23 -0500 Tony Camuso <[EMAIL PROTECTED]> wrote: > Arjan, > > I have not seen your MMCONFIG patch. > > Would you mind sending me a copy? > sure On PCs, PCI extended configuration space (4Kb) is riddled with problems associated with the memory mapped access

[PATCH 2/2] irda: avoid potential memory leak in irda_setsockopt()

2008-01-12 Thread Jesper Juhl
There are paths through the irda_setsockopt() function where we return and may or may not have allocated a new ias_obj but in any case have not used it for anything yet and we end up leaking memory. As far as I can tell, in the case where we didn't allocate a new ias_ob but simply were

[PATCH 1/2] irda: return -ENOMEM upon failure to allocate new ias_obj

2008-01-12 Thread Jesper Juhl
irias_new_object() can fail its memory allocation and will return NULL in that case. I believe the proper thing to do is to catch this, free the ias_opt that was allocated earlier but won't be used and then return -ENOMEM. There are assertions further on that check for a NULL ias_obj, but I

Re: [PATCH] pda_power: add device_init_wakeup

2008-01-12 Thread Dmitry
Hi, 2008/1/13, Anton Vorontsov <[EMAIL PROTECTED]>: > On Sun, Jan 13, 2008 at 01:50:16AM +0300, Dmitry Baryshkov wrote: > > Hi, > > > > Please apply this patch. Otherwise pda_power can't generate wakeup > > events. I forgot this in the initial pda_power suspend/resume patch. > > > > Add

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Tony Camuso
Arjan, I have not seen your MMCONFIG patch. Would you mind sending me a copy? Thanks. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: 2.6.24-rc7-git4: Reported regressions from 2.6.23

2008-01-12 Thread Rafael J. Wysocki
On Sunday, 13 of January 2008, Frans Pop wrote: > Rafael J. Wysocki wrote: > > If you know of any other unresolved regressions from 2.6.23, please let me > > know either and I'll add them to the list. > > Does this qualify as a regression? I guess so. > I have not seen a fix posted for it yet.

Re: [PATCH] pda_power: add device_init_wakeup

2008-01-12 Thread Anton Vorontsov
On Sun, Jan 13, 2008 at 01:50:16AM +0300, Dmitry Baryshkov wrote: > Hi, > > Please apply this patch. Otherwise pda_power can't generate wakeup > events. I forgot this in the initial pda_power suspend/resume patch. > > Add device_init_wakeup to init wakeup. Thanks, folded into "pda_power: add

Re: [RFD] Incremental fsck

2008-01-12 Thread Daniel Phillips
On Wednesday 09 January 2008 01:16, Andreas Dilger wrote: > While an _incremental_ fsck isn't so easy for existing filesystem > types, what is pretty easy to automate is making a read-only snapshot > of a filesystem via LVM/DM and then running e2fsck against that. The > kernel and filesystem have

Re: Top 10 kernel oopses for the week ending January 12th, 2008

2008-01-12 Thread Arjan van de Ven
Adrian Bunk wrote: On Sat, Jan 12, 2008 at 03:13:29PM -0800, Arjan van de Ven wrote: Adrian Bunk wrote: All the other reports only contain the plain trace. Is there any way to get more information whether the former is a pattern or not, and to get this information somehow displayed on the

Re: Top 10 kernel oopses for the week ending January 12th, 2008

2008-01-12 Thread Adrian Bunk
On Sat, Jan 12, 2008 at 03:13:29PM -0800, Arjan van de Ven wrote: > Adrian Bunk wrote: >> >> All the other reports only contain the plain trace. Is there any way to >> get more information whether the former is a pattern or not, and to >> get this information somehow displayed on the webpage? > >

[git patches] net driver fixes

2008-01-12 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: MAINTAINERS | 10 ++- drivers/net/3c509.c |4 + drivers/net/Kconfig

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread James Bottomley
On Sat, 2008-01-12 at 17:04 -0600, Robert Hancock wrote: > I don't think the problem is that there's some buffer which is getting > allocated above 4GB and never bounced, since the problem goes away if > ADMA is disabled entirely and the DMA mask remains 32-bit always. My > guess is something

Re: Top 10 kernel oopses for the week ending January 12th, 2008

2008-01-12 Thread Arjan van de Ven
Adrian Bunk wrote: All the other reports only contain the plain trace. Is there any way to get more information whether the former is a pattern or not, and to get this information somehow displayed on the webpage? IF the kernel prints that its tainted or whatever it'll be shown, as well as

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread Robert Hancock
James Bottomley wrote: With mem<=4098M or sata_nv.adma=0 it still mounts and works ok. As I wrote, it would appear that somehow the blk_queue_bounce_limit setting that the driver has made is not being respected and the block layer is still trying to feed it addresses over 4GB. Any ideas

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Arjan van de Ven
On Sun, 13 Jan 2008 00:49:11 +0300 Ivan Kokshaysky <[EMAIL PROTECTED]> wrote: > On Sat, Jan 12, 2008 at 09:45:57AM -0800, Arjan van de Ven wrote: > > btw this is my main objection to your patch; it intertwines the > > conf1 and mmconfig code even more. > > There is nothing wrong with it; please

Re: [PATCH] pda_power: add device_init_wakeup

2008-01-12 Thread Dmitry Baryshkov
Hi, Please apply this patch. Otherwise pda_power can't generate wakeup events. I forgot this in the initial pda_power suspend/resume patch. Add device_init_wakeup to init wakeup. Signed-off-by: Dmitry Baryshkov <[EMAIL PROTECTED]> diff --git a/drivers/power/pda_power.c

Re: 2.6.24-rc7-git4: Reported regressions from 2.6.23

2008-01-12 Thread Rafael J. Wysocki
On Saturday, 12 of January 2008, Harvey Harrison wrote: > On Sat, 2008-01-12 at 22:05 +0100, Rafael J. Wysocki wrote: > > [RFC: Would that be useful if I sent regression-fixing patches, CCed to the > > appropriate maintainers/lists, along with the reports?] > > Perhaps keep the regression report

backlight module for nvidia cards -- control backlight even with offb

2008-01-12 Thread Andy Wingo
Hi all, I have a 12" powerbook, one of the last G4's, and have long been irritated that I couldn't use offb because it has no backlight control. This is more irritating now that the nouveau project's X drivers are starting to work for me on PPC, but are incompatible with the nvidiafb frame

Re: regression: 100% io-wait with 2.6.24-rcX

2008-01-12 Thread Joerg Platte
Am Freitag, 11. Januar 2008 schrieb Fengguang Wu: > On Thu, Jan 10, 2008 at 11:03:05AM +0100, Joerg Platte wrote: > > Am Donnerstag, 10. Januar 2008 schrieb Fengguang Wu: > > > > problem, because the iowait problem disappeared today after the > > > > regular Debian update. I'll try to install the

Re: Top 10 kernel oopses for the week ending January 12th, 2008

2008-01-12 Thread Adrian Bunk
On Sat, Jan 12, 2008 at 10:48:05AM -0800, Arjan van de Ven wrote: > The http://www.kerneloops.org website collects kernel oops and > warning reports from various mailing lists and bugzillas as well as > with a client users can install to auto-submit oopses. > Below is a top 10 list of the oopses

Re: 2.6.24-rc7-git4: Reported regressions from 2.6.23

2008-01-12 Thread Harvey Harrison
On Sat, 2008-01-12 at 22:05 +0100, Rafael J. Wysocki wrote: > [RFC: Would that be useful if I sent regression-fixing patches, CCed to the > appropriate maintainers/lists, along with the reports?] Perhaps keep the regression report as-is, but for each regression with a patch follow up with an

[PATCH 2/2] x86: Function ifdefs in fault_32|64.c

2008-01-12 Thread Harvey Harrison
Add caller of is_errata93() to X86_32, ifdef'd to do nothing. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/mm/fault_32.c | 59 +-- arch/x86/mm/fault_64.c | 30 ++-- 2 files changed, 83 insertions(+), 6

[PATCH 1/2] x86: Last of trivial fault_32|64.c unification

2008-01-12 Thread Harvey Harrison
Comments, indentation, printk format. Uses task_pid_nr() on X86_64 now, but this is always defined to task->pid. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/mm/fault_32.c | 20 arch/x86/mm/fault_64.c | 29 +++-- 2 files

Re: 2.6.24-rc7-git4: Reported regressions from 2.6.23

2008-01-12 Thread Adrian Bunk
On Sat, Jan 12, 2008 at 10:05:34PM +0100, Rafael J. Wysocki wrote: > [RFC: Would that be useful if I sent regression-fixing patches, CCed to the > appropriate maintainers/lists, along with the reports?] >... I don't think sending the patches around brings much advantage. But I always also Cc'ed

Re: [PATCH] serial: remove "too much work for irq" printk

2008-01-12 Thread H. Peter Anvin
Alan Cox wrote: This is going to put trouble in other places unless, at least, it can be turned off. The UART serial interface is heavily emulated as a console interface without an actual serial port behind it, both in hardware and software. Rates will typically vastly exceed real serial

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-12 Thread Ivan Kokshaysky
On Sat, Jan 12, 2008 at 09:45:57AM -0800, Arjan van de Ven wrote: > btw this is my main objection to your patch; it intertwines the conf1 > and mmconfig code even more. There is nothing wrong with it; please realize that mmconf and conf1 are just different cpu-side interfaces. Both produce

Re: [PATCH] serial: remove "too much work for irq" printk

2008-01-12 Thread Alan Cox
> This is going to put trouble in other places unless, at least, it can be > turned off. The UART serial interface is heavily emulated as a console > interface without an actual serial port behind it, both in hardware and > software. Rates will typically vastly exceed real serial port rates,

Re: [PATCH] serial: remove "too much work for irq" printk

2008-01-12 Thread H. Peter Anvin
Alan Cox wrote: On Sat, 12 Jan 2008 15:15:43 -0500 Benjamin LaHaise <[EMAIL PROTECTED]> wrote: When using kvm with a serial console, the serial driver will print out "too much work for irq4" on any heavy activity (ie vi on a file repainting the terminal). This message is entirely spurious,

Re: [PATCH] serial: remove "too much work for irq" printk

2008-01-12 Thread Alan Cox
On Sat, 12 Jan 2008 15:15:43 -0500 Benjamin LaHaise <[EMAIL PROTECTED]> wrote: > When using kvm with a serial console, the serial driver will print out > "too much work for irq4" on any heavy activity (ie vi on a file repainting > the terminal). This message is entirely spurious, as output

Re: [PATCH 06/21] ide-floppy: remove struct idefloppy_flexible_disk_page

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Saturday 12 January 2008, Borislav Petkov wrote: [...] > > > set_disk_ro(floppy->disk, floppy->wp); > > > - page = (idefloppy_flexible_disk_page_t *) (header + 1); > > > - > > > - page->transfer_rate = be16_to_cpu(page->transfer_rate); > > > - page->sector_size =

Re: 2.6.24-rc7-git4: Reported regressions from 2.6.23

2008-01-12 Thread Rafael J. Wysocki
On Saturday, 12 of January 2008, Rafael J. Wysocki wrote: > [RFC: Would that be useful if I sent regression-fixing patches, That is, the patches pointed to by the "Patch" fields in the list entries. > CCed to the appropriate maintainers/lists, along with the reports?] Rafael -- To unsubscribe

Re: [PATCH 18/21] ide-floppy: fix error handling in idefloppy_probe()

2008-01-12 Thread Borislav Petkov
On Sat, Jan 12, 2008 at 09:18:01PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Friday 11 January 2008, Borislav Petkov wrote: > > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> > > --- > > drivers/ide/ide-floppy.c |3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff

[PATCH] kthread: allow kthread_stop calls to run in parallel

2008-01-12 Thread Jeff Layton
Currently, all kthread_stop calls are serialized. If something calls kthread_stop on a kthread, no other kthread will be able to be brought down until the first kthread_stop returns. A "rogue" kthread could therefore prevent other kthreads from ever coming down. This patch makes it so that

Re: Could not set non-blocking flag with 2.6.24-rc5

2008-01-12 Thread Christoph Hellwig
On Thu, Dec 13, 2007 at 09:16:01PM +0100, Tino Keitel wrote: > Hi folks, > > I often build Debian packages inside a chroot. Today I discovered a > failure during an "aptitude update", which is a command to download new > package lists for the package management. In strace, the lines around > the

2.6.24-rc7-git4: Reported regressions from 2.6.23

2008-01-12 Thread Rafael J. Wysocki
[RFC: Would that be useful if I sent regression-fixing patches, CCed to the appropriate maintainers/lists, along with the reports?] This message contains a list of some regressions from 2.6.23 reported since 2.6.24-rc1 was released, for which there are no fixes in the mainline I know of.  If any

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-12 Thread Sam Ravnborg
On Fri, Jan 11, 2008 at 08:44:28PM +0100, Sam Ravnborg wrote: > Hi Jan. > > On Fri, Jan 11, 2008 at 08:55:29AM +, Jan Beulich wrote: > > Since __cpuinitdata/__devinitdata don't allow const to be specified with > > them (otherwise .init.data sections with and without the writeable attribute >

Re: [PATCH 00/21] ide-floppy redux v2

2008-01-12 Thread Borislav Petkov
On Sat, Jan 12, 2008 at 09:14:39PM +0100, Bartlomiej Zolnierkiewicz wrote: [...] > PS1 Please rebase the patches still needing polishing on top of updated > IDE quilt tree, recast them and respin the patch series (no need to post > already merged patches). sure, will do. > PS2 what happend to

Re: [PATCH 06/21] ide-floppy: remove struct idefloppy_flexible_disk_page

2008-01-12 Thread Borislav Petkov
[...] > This is not an equivalent transformation: > > header->wp is 0 or 1 > pc.buffer[3] & 0x80 is 0 or 0x80 > > It seems to work fine for ->wp (because it is needlessly defined as 'int') > but may seriously confuse set_disk_ro() and thus bdev_read_only() users. > > Should be fixed to

[PATCH] Shrink ext3_inode_info by 8 bytes for !POSIX_ACL.

2008-01-12 Thread Indan Zupancic
i_file_acl and i_dir_acl aren't always needed. With certain configs this makes 10 ext3_inode_cache objects fit in one slab instead of the current 9, as the size shrinks from 416 to 408 bytes for 32 bit, !POSIX_ACL and !EXT3_FS_XATTR configs. Signed-off-by: Indan Zupancic <[EMAIL PROTECTED]> ---

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread James Bottomley
On Sat, 2008-01-12 at 13:25 -0600, Robert Hancock wrote: > Alexander wrote: > > Robert Hancock wrote: > >> There's this patch which was intended to fix it: > >> > >> http://lkml.org/lkml/2007/11/22/148 > > > > I applied this patch to 2.6.24-rc7. Now at boot time my DVD-RW is > > normaly detected

Re: Lenovo ThinkPads need acpi_osi="Linux"

2008-01-12 Thread Henrique de Moraes Holschuh
On Sat, 12 Jan 2008, Len Brown wrote: > > Lenovo has been attempting to make things a bit easier for Linux on their > > ThinkPads, by disabling the more obnoxious behaviours of the firmware (used > > by their Windows drivers) when in Linux. It looks like they used the OSI > > string for that.

Re: [PATCH] serial: remove "too much work for irq" printk

2008-01-12 Thread Christoph Hellwig
On Sat, Jan 12, 2008 at 03:15:43PM -0500, Benjamin LaHaise wrote: > When using kvm with a serial console, the serial driver will print out > "too much work for irq4" on any heavy activity (ie vi on a file repainting > the terminal). This message is entirely spurious, as output continues to >

Re: [PATCH 19/21] ide-floppy: fix most of the remaining checkpatch.pl issues

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > i.e., > ERROR: switch and case should be at the same indent > ERROR: need spaces around that '=' (ctx:VxV) > ERROR: trailing statements should be on next line > WARNING: no space between function name and open parenthesis '(' > WARNING: printk()

Re: [PATCH 18/21] ide-floppy: fix error handling in idefloppy_probe()

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> > --- > drivers/ide/ide-floppy.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c > index 89b26ea..0729df5

Re: [PATCH 20/21] ide-floppy: merge idefloppy_{input,output}_buffers

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by > introducing a 4th arg. called direction. According to its value > we atapi_input_bytes() or atapi_output_bytes(). Also, simplify the interrupt This change is fine but

Re: [PATCH 14/21] ide-floppy: mv idefloppy_{should_,}report_error

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > In addition to shortening the function name, move the printk-call into the > function thereby saving some code lines. Also, make the function out_of_line > since it is not on a performance critical path. > > Signed-off-by: Borislav Petkov

Re: [PATCH 21/21] ide-floppy: remove atomic test_*bit macros

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > This change is temporary and after unification of the IDE subsystem proper > bit setting and testing macros will be introduced. > > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> > --- > drivers/ide/ide-floppy.c | 82 >

Re: [PATCH 11/21] ide-floppy: fix comments formatting

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > That is, > - remove unnecessary comments > - shorten comments > - shorten lines longer 80 columns > - cleanup whitespace > - add a missing loglevel KERN_ to a printk-call > - fix misc checkpatch warnings Majority of this patch consists of

Re: [PATCH 12/21] ide-floppy: factor out ioctl handlers from idefloppy_ioctl()

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > By passing idefloppy_floppy_t *floppy to the factored out functions, we get > rid of (almost) all local vars so stack usage should be at minimum here. Also, > we merge idefloppy_begin_format() into idefloppy_format_start() since it is > its >

Re: [PATCH 06/21] ide-floppy: remove struct idefloppy_flexible_disk_page

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Saturday 12 January 2008, Bartlomiej Zolnierkiewicz wrote: [...] > > - header = (idefloppy_mode_parameter_header_t *) pc.buffer; > > - floppy->wp = header->wp; > > + floppy->wp = pc.buffer[3] & 0x80; > > This is not an equivalent transformation: > > header->wp is 0 or 1 > pc.buffer[3]

Re: [PATCH 00/21] ide-floppy redux v2

2008-01-12 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 12 January 2008, Bartlomiej Zolnierkiewicz wrote: > On Friday 11 January 2008, Borislav Petkov wrote: > > > > Hi Bart, > > > >here's the second version of the ide-floppy refactoring trail. All the > > patches are based on the version of your quilt tree from the 05.01. Also,

Re: new runtime scsi warnings in 2.6.24-rc6+git

2008-01-12 Thread James Bottomley
On Sat, 2008-01-12 at 20:58 +0100, Rafael J. Wysocki wrote: > On Friday, 4 of January 2008, Meelis Roos wrote: > > Todays git gives the following warning during bootup on a Intel 845+PATA > > PC (using libata to drive PATA): > > > > Driver 'sd' needs updating - please use bus_type methods > >

[PATCH] serial: remove "too much work for irq" printk

2008-01-12 Thread Benjamin LaHaise
When using kvm with a serial console, the serial driver will print out "too much work for irq4" on any heavy activity (ie vi on a file repainting the terminal). This message is entirely spurious, as output continues to work fine. Remove the message as it corrupts screen output and is far too

[PATCH] input: psmouse: fix potential input register race in psmouse_connect()

2008-01-12 Thread Andres Salomon
If we successfully call input_register_device() in psmouse_connect but sysfs_create_group() fails, we'll enter the error path without ever having called input_unregister_device() (potentially leaking memory, or creating a race condition if something else attempts to access the new input device).

[PATCH] input: psmouse: fix input_dev leak in lifebook driver

2008-01-12 Thread Andres Salomon
The lifebook driver may register a second input device, but it never unregisters it. This fixes that. Signed-off-by: Andres Salomon <[EMAIL PROTECTED]> --- drivers/input/mouse/lifebook.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git

[PATCH] input: check return value of input_register_device() in hil_ptr.c's init

2008-01-12 Thread Andres Salomon
Signed-off-by: Andres Salomon <[EMAIL PROTECTED]> --- drivers/input/mouse/hil_ptr.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/input/mouse/hil_ptr.c b/drivers/input/mouse/hil_ptr.c index 27f88fb..de8b836 100644 --- a/drivers/input/mouse/hil_ptr.c +++

-mm: pnp-do-not-stop-start-devices-in-suspend-resume-path.patch breaks resuming isapnp cards

2008-01-12 Thread Rene Herman
Hi Andrew. pnp-do-not-stop-start-devices-in-suspend-resume-path.patch in current -mm breaks resuming isapnp cards from hibernation. They need the pnp_start_dev to enable the device again after hibernation. They don't really need the pnp_stop_dev() which the above mentioned patch also

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-12 Thread Jarek Poplawski
On Sat, Jan 12, 2008 at 05:47:54PM +0800, Dave Young wrote: > Add the following class iteration functions for driver use: > class_for_each_device > class_find_device > class_for_each_child > class_find_child > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> > > --- > drivers/base/class.c |

Re: [PATCH 8/8] ide: add ->cable_detect method to ide_hwif_t

2008-01-12 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Add ->cable_detect method to ide_hwif_t. * Call the new method in ide_init_port() if: - the host supports UDMA modes > UDMA2 ('hwif->ultra_mask & 78') - DMA initialization was successful (if hwif->dma_base is not set ide_init_port() sets

[PATCH] [RESEND] Assign IRQs to HPET Timers

2008-01-12 Thread Balaji Rao
The userspace API for the HPET (see Documentation/hpet.txt) did not work. The HPET_IE_ON ioctl was failing as there was no IRQ assigned to the timer device. This patch fixes it by allocating IRQs to timer blocks in the HPET. arch/x86/kernel/hpet.c | 13 + drivers/char/hpet.c|

Re: new runtime scsi warnings in 2.6.24-rc6+git

2008-01-12 Thread Rafael J. Wysocki
On Friday, 4 of January 2008, Meelis Roos wrote: > Todays git gives the following warning during bootup on a Intel 845+PATA > PC (using libata to drive PATA): > > Driver 'sd' needs updating - please use bus_type methods > Driver 'sr' needs updating - please use bus_type methods They are due to

Re: [PATCH 0/5] USB Kconfig: Reorganize USB Kconfig Menu

2008-01-12 Thread Greg KH
On Sat, Jan 12, 2008 at 01:20:46PM +0300, Al Boldi wrote: > Greg KH wrote: > > On Sat, Jan 05, 2008 at 06:40:38PM +0300, Al Boldi wrote: > > > Reorganize USB Kconfig Menu, and move USB_GADGET out into the Device > > > Driver Menu. ?This helps the USB Kconfig Menu to be more logical/usable. > > > >

nosmp/maxcpus=0 or 1 -> TSC unstable

2008-01-12 Thread dean gaudet
if i boot an x86 64-bit 2.6.24-rc7 kernel with nosmp, maxcpus=0 or 1 it still disables TSC :) Marking TSC unstable due to TSCs unsynchronized this is an opteron 2xx box which does have two cpus and no clock-divide in halt or cpufreq enabled so TSC should be fine with only one cpu. pretty sure

[PATCH] PM: Acquire device locks on suspend (rev. 4)

2008-01-12 Thread Rafael J. Wysocki
Hi Greg, Please drop gregkh-driver-pm-acquire-device-locks-prior-to-suspending.patch that deadlocks suspend and hibernation on some systems, and apply the appended $subject patch (which provides the equivalent functionality and introduces safeguards against deadlocking in the relevant cases)

Re: [PATCH] Only print SCSI data direction warning once for a command

2008-01-12 Thread James Bottomley
On Wed, 2008-01-02 at 07:03 +0100, Andi Kleen wrote: > When I use cdparanoia my logs get spammed a lot by > > printk: 464 messages suppressed. > sg_write: data in/out 30576/30576 bytes for SCSI command 0xbe--guessing data > in; >program cdparanoia not setting count and/or reply_len properly

Re: rtl8187 rate control doesn't work

2008-01-12 Thread Stefano Brivio
On Sat, 12 Jan 2008 19:23:53 +0100 Hauke Mehrtens <[EMAIL PROTECTED]> wrote: > I have tried wireless-2.6 and I have the same problem. If the rate goes > over 11M no TCP/IP traffic goes through the wireless connecting. If rate > is set to auto and the rate control algorithm changes it to something

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread Robert Hancock
Alexander wrote: Robert Hancock wrote: There's this patch which was intended to fix it: http://lkml.org/lkml/2007/11/22/148 I applied this patch to 2.6.24-rc7. Now at boot time my DVD-RW is normaly detected as: sr0: scsi3-mmc drive: 48x/48x writer dvd-ram cd/rw xa/form2 cdda tray But I

Re: The ext3 way of journalling

2008-01-12 Thread Andrey Vul
On Jan 12, 2008 10:06 AM, Theodore Tso <[EMAIL PROTECTED]> wrote: [snip] > Unfortunately Ubuntu users [snip] fit this demographic hugely, and > Ubuntu refuses to fix this problem[1], so it's been personally very > vexing, because the users complain to *me*, and I can't fix the problem, > because

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-12 Thread Andrew Morton
On Sat, 12 Jan 2008 14:14:01 + Adrian McMenamin <[EMAIL PROTECTED]> wrote: > > > > + spin_command->cmd[0] = 0x70; > > > + spin_command->cmd[2] = 0x1f; > > > + spin_command->buflen = 0; > > > + gd.pending = 1; > > > + gdrom_packetcommand(gd.cd_info, spin_command); > > > + /* 60 second timeout

Re: [alsa-devel] PNP_DRIVER_RES_DISABLE breaks swsusp at least with snd_cs4236

2008-01-12 Thread Rafael J. Wysocki
On Saturday, 12 of January 2008, Rene Herman wrote: > On 12-01-08 16:21, Pierre Ossman wrote: > > > Ah, sorry. It was a different thread. Look for a mail with the subject > > "PNP: do not stop/start devices in suspend/resume path" in the LKML och > > linux-pm archives. > > Right, and I see

  1   2   3   4   >