2016-08-12 13:30 GMT+08:00 Huaitong Han :
> percpu cpus_in_cluster is a pointer with CONFIG_CPUMASK_OFFSTACK,
> cpu_in_cluster
> is not alloced memory before x2apic_prepare_cpu is invoked, so cpumask_set_cpu
> would get a NULL pointer bug:
> BUG: unable to handle kernel
On Thu, Aug 11, 2016 at 02:49:29PM -0700, Thomas Garnier wrote:
> Restore the processor state before calling any other function to ensure
> per-cpu variables can be used with KASLR memory randomization.
>
> Tracing functions use per-cpu variables (gs based) and one was called
> just before
2016-08-12 13:30 GMT+08:00 Huaitong Han :
> percpu cpus_in_cluster is a pointer with CONFIG_CPUMASK_OFFSTACK,
> cpu_in_cluster
> is not alloced memory before x2apic_prepare_cpu is invoked, so cpumask_set_cpu
> would get a NULL pointer bug:
> BUG: unable to handle kernel NULL pointer dereference
On Thu, Aug 11, 2016 at 02:49:29PM -0700, Thomas Garnier wrote:
> Restore the processor state before calling any other function to ensure
> per-cpu variables can be used with KASLR memory randomization.
>
> Tracing functions use per-cpu variables (gs based) and one was called
> just before
* Denys Vlasenko [2016-08-11 17:45:21]:
> Since instruction decoder now supports EVEX-encoded insns, two fixes are
> needed
> to correctly handle them in uprobes.
Could you please add the commit that helps support the insns in the
Changelog.
Rest all looks okay.
Looks
* Denys Vlasenko [2016-08-11 17:45:21]:
> Since instruction decoder now supports EVEX-encoded insns, two fixes are
> needed
> to correctly handle them in uprobes.
Could you please add the commit that helps support the insns in the
Changelog.
Rest all looks okay.
Looks good to me.
Acked-by:
percpu cpus_in_cluster is a pointer with CONFIG_CPUMASK_OFFSTACK, cpu_in_cluster
is not alloced memory before x2apic_prepare_cpu is invoked, so cpumask_set_cpu
would get a NULL pointer bug:
BUG: unable to handle kernel NULL pointer dereference at (null)
IP: [] x2apic_cluster_probe+0x35/0x70
percpu cpus_in_cluster is a pointer with CONFIG_CPUMASK_OFFSTACK, cpu_in_cluster
is not alloced memory before x2apic_prepare_cpu is invoked, so cpumask_set_cpu
would get a NULL pointer bug:
BUG: unable to handle kernel NULL pointer dereference at (null)
IP: [] x2apic_cluster_probe+0x35/0x70
On Fri, Aug 12, 2016 at 03:10:38AM +, Mathieu Desnoyers wrote:
> - On Aug 11, 2016, at 9:28 PM, Boqun Feng boqun.f...@gmail.com wrote:
>
> > On Thu, Aug 11, 2016 at 11:26:30PM +, Mathieu Desnoyers wrote:
> >> - On Jul 24, 2016, at 2:01 PM, Dave Watson davejwat...@fb.com wrote:
>
On Fri, Aug 12, 2016 at 03:10:38AM +, Mathieu Desnoyers wrote:
> - On Aug 11, 2016, at 9:28 PM, Boqun Feng boqun.f...@gmail.com wrote:
>
> > On Thu, Aug 11, 2016 at 11:26:30PM +, Mathieu Desnoyers wrote:
> >> - On Jul 24, 2016, at 2:01 PM, Dave Watson davejwat...@fb.com wrote:
>
On Thu, Aug 11, 2016 at 11:51:38PM +0200, Arnd Bergmann wrote:
> That patch looks good, sorry I missed it. I see that Vladimir already
> did the lpc32xx portion of it, can you send the part for s3c24xx
> to the exynos maintainers?
I see you've added them to CC, thanks Arnd. Here it is:
---
From:
On Thu, Aug 11, 2016 at 11:51:38PM +0200, Arnd Bergmann wrote:
> That patch looks good, sorry I missed it. I see that Vladimir already
> did the lpc32xx portion of it, can you send the part for s3c24xx
> to the exynos maintainers?
I see you've added them to CC, thanks Arnd. Here it is:
---
From:
On Thu, 2016-08-11 at 14:17 -0600, Alex Williamson wrote:
>
> vfio isn't playing nanny here for the fun of it, part of the reason we
> have vpd access functions is because folks have discovered that vpd
> registers between PCI functions on multi-function devices may be
> shared. So pounding on
On Thu, 2016-08-11 at 14:17 -0600, Alex Williamson wrote:
>
> vfio isn't playing nanny here for the fun of it, part of the reason we
> have vpd access functions is because folks have discovered that vpd
> registers between PCI functions on multi-function devices may be
> shared. So pounding on
On Thu, Aug 11, 2016 at 9:16 PM, Dave Chinner wrote:
>
> That's why running aim7 as your "does the filesystem scale"
> benchmark is somewhat irrelevant to scaling applications on high
> performance systems these days
Yes, don't get me wrong - I'm not at all trying to say
On Thu, Aug 11, 2016 at 9:16 PM, Dave Chinner wrote:
>
> That's why running aim7 as your "does the filesystem scale"
> benchmark is somewhat irrelevant to scaling applications on high
> performance systems these days
Yes, don't get me wrong - I'm not at all trying to say that AIM7 is a
good
Change the MFD config option as per latest naming
Acked-by: Mark Brown
Signed-off-by: Keerthy
---
drivers/regulator/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index
The LP873X chip is a power management IC for Portable Navigation Systems
and Tablet Computing devices. It contains the following components:
- Regulators.
- Configurable General Purpose Output Signals(GPO).
PMIC interacts with the main processor through i2c. PMIC has
couple of
Add driver for lp873x PMIC family GPOs. Two GPOs are supported
and can be configured in Open-drain output or Push-pull output.
Acked-by: Linus Walleij
Signed-off-by: Keerthy
---
Changes in v8:
* Replaced hardcoded bit fields with macros.
Change the MFD config option as per latest naming
Acked-by: Mark Brown
Signed-off-by: Keerthy
---
drivers/regulator/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 6c88e31..97dc4cc 100644
---
The LP873X chip is a power management IC for Portable Navigation Systems
and Tablet Computing devices. It contains the following components:
- Regulators.
- Configurable General Purpose Output Signals(GPO).
PMIC interacts with the main processor through i2c. PMIC has
couple of
Add driver for lp873x PMIC family GPOs. Two GPOs are supported
and can be configured in Open-drain output or Push-pull output.
Acked-by: Linus Walleij
Signed-off-by: Keerthy
---
Changes in v8:
* Replaced hardcoded bit fields with macros.
drivers/gpio/Kconfig | 10 +++
The LP873X chip is a power management IC for Portable Navigation Systems
and Tablet Computing devices. It contains the following components:
- Regulators.
- Configurable General Purpose Output Signals(GPO).
PMIC interacts with the main processor through i2c. PMIC has
couple of
The LP873X chip is a power management IC for Portable Navigation Systems
and Tablet Computing devices. It contains the following components:
- Regulators.
- Configurable General Purpose Output Signals(GPO).
PMIC interacts with the main processor through i2c. PMIC has
couple of
This series adds support for rotary-switch on AM335x-ICE that is
connected to TI PCA9536 I2C GPIO expander.
First patch adds new generic driver to read status of group of GPIO
lines and report the value as an input event. The second patch adds DT
entries for the same.
Vignesh R (2):
input:
This series adds support for rotary-switch on AM335x-ICE that is
connected to TI PCA9536 I2C GPIO expander.
First patch adds new generic driver to read status of group of GPIO
lines and report the value as an input event. The second patch adds DT
entries for the same.
Vignesh R (2):
input:
Add a driver to read group of GPIO lines and provide its status as a
numerical value as input event to the system. This will help in
intefacing devices, that can be connected over GPIOs, that provide input
to the system by driving GPIO lines connected to them like a rotary dial
or a switch.
For
AM335x ICE board has a rotary-switch connected to PCA9536 I2C GPIO
expander. The position of the rotary-switch is reflected by status of
GPIO lines. Add gpio-decoder node to read these GPIO line status via
gpio-decoder driver and report it as an input event to the system.
Signed-off-by: Vignesh R
AM335x ICE board has a rotary-switch connected to PCA9536 I2C GPIO
expander. The position of the rotary-switch is reflected by status of
GPIO lines. Add gpio-decoder node to read these GPIO line status via
gpio-decoder driver and report it as an input event to the system.
Signed-off-by: Vignesh R
Add a driver to read group of GPIO lines and provide its status as a
numerical value as input event to the system. This will help in
intefacing devices, that can be connected over GPIOs, that provide input
to the system by driving GPIO lines connected to them like a rotary dial
or a switch.
For
On Thu, Aug 11, 2016 at 08:20:53PM -0700, Linus Torvalds wrote:
> On Thu, Aug 11, 2016 at 7:52 PM, Christoph Hellwig wrote:
> >
> > I can look at that, but indeed optimizing this patch seems a bit
> > stupid.
>
> The "write less than a full block to the end of the file" is actually
On Thu, Aug 11, 2016 at 08:20:53PM -0700, Linus Torvalds wrote:
> On Thu, Aug 11, 2016 at 7:52 PM, Christoph Hellwig wrote:
> >
> > I can look at that, but indeed optimizing this patch seems a bit
> > stupid.
>
> The "write less than a full block to the end of the file" is actually
> a
Hi Catalin,
Thanks for the response!
On Thursday 11 August 2016 10:38 PM, Catalin Marinas wrote:
> On Thu, Aug 11, 2016 at 07:48:12PM +0300, Grygorii Strashko wrote:
>> On 08/11/2016 06:54 PM, Catalin Marinas wrote:
>>> On Thu, Aug 11, 2016 at 05:20:51PM +0530, Vignesh R wrote:
I see the
Hi Catalin,
Thanks for the response!
On Thursday 11 August 2016 10:38 PM, Catalin Marinas wrote:
> On Thu, Aug 11, 2016 at 07:48:12PM +0300, Grygorii Strashko wrote:
>> On 08/11/2016 06:54 PM, Catalin Marinas wrote:
>>> On Thu, Aug 11, 2016 at 05:20:51PM +0530, Vignesh R wrote:
I see the
On 08/09/2016 09:58 PM, Joerg Roedel wrote:
On Mon, Aug 08, 2016 at 09:42:36PM +0700, Suthikulpanit, Suravee wrote:
Hi Joerg/Radim/Paolo,
Are there any other concerns about this series?
Okay, looked again through the iommu-patches and sent you my feedback.
Overall I think we are on track to
On 08/09/2016 09:58 PM, Joerg Roedel wrote:
On Mon, Aug 08, 2016 at 09:42:36PM +0700, Suthikulpanit, Suravee wrote:
Hi Joerg/Radim/Paolo,
Are there any other concerns about this series?
Okay, looked again through the iommu-patches and sent you my feedback.
Overall I think we are on track to
Hi all,
Changes since 20160811:
Non-merge commits (relative to Linus' tree): 1492
1513 files changed, 39934 insertions(+), 15095 deletions(-)
I have created today's linux-next tree at
git://git.kernel.org/pub/scm
Hi all,
Changes since 20160811:
Non-merge commits (relative to Linus' tree): 1492
1513 files changed, 39934 insertions(+), 15095 deletions(-)
I have created today's linux-next tree at
git://git.kernel.org/pub/scm
On Thu, Aug 11, 2016 at 07:27:52PM -0700, Linus Torvalds wrote:
> On Thu, Aug 11, 2016 at 5:54 PM, Dave Chinner wrote:
> >
> > So, removing mark_page_accessed() made the spinlock contention
> > *worse*.
> >
> > 36.51% [kernel] [k] _raw_spin_unlock_irqrestore
> >6.27%
On Thu, Aug 11, 2016 at 07:27:52PM -0700, Linus Torvalds wrote:
> On Thu, Aug 11, 2016 at 5:54 PM, Dave Chinner wrote:
> >
> > So, removing mark_page_accessed() made the spinlock contention
> > *worse*.
> >
> > 36.51% [kernel] [k] _raw_spin_unlock_irqrestore
> >6.27% [kernel] [k]
On 11/08/16 08:28, Kees Cook wrote:
> From: Emese Revfy
>
> When "ram_latent_entropy" is passed on the kernel command line, entropy
> will be extracted from up to the first 4GB of RAM while the runtime memory
> allocator is being initialized. This entropy isn't
On 11/08/16 08:28, Kees Cook wrote:
> From: Emese Revfy
>
> When "ram_latent_entropy" is passed on the kernel command line, entropy
> will be extracted from up to the first 4GB of RAM while the runtime memory
> allocator is being initialized. This entropy isn't cryptographically
> secure, but
Hi.
2016-07-28 16:44 GMT+09:00 Arnd Bergmann :
>
> I think the problem is that you have three consoles:
>
> - the boot console that stays active until a real console comes up
> - the framebuffer console that is initialized early and goes on to
> disable the bootconsole
> - the
Hi.
2016-07-28 16:44 GMT+09:00 Arnd Bergmann :
>
> I think the problem is that you have three consoles:
>
> - the boot console that stays active until a real console comes up
> - the framebuffer console that is initialized early and goes on to
> disable the bootconsole
> - the serial console
Thanks!
On Fri, Aug 12, 2016 at 3:12 AM, Oleg Nesterov wrote:
> > The bug happens because when __seccomp_filter() detects
> > fatal_signal_pending(), it calls do_exit() without dequeuing the fatal
> > signal. When do_exit() sends the PTRACE_EVENT_EXIT
>
> I _never_ understood
On Thu, Aug 11, 2016 at 09:40:32AM -0700, Joshua Clayton wrote:
> Previously the onboard hub was made to work by treating its
> reset gpio as a regulator enable.
> Get rid of that kludge now that pwseq has added reset gpio support
> Move pin muxing the hub reset pin into the usbh1 group
>
>
Thanks!
On Fri, Aug 12, 2016 at 3:12 AM, Oleg Nesterov wrote:
> > The bug happens because when __seccomp_filter() detects
> > fatal_signal_pending(), it calls do_exit() without dequeuing the fatal
> > signal. When do_exit() sends the PTRACE_EVENT_EXIT
>
> I _never_ understood what
On Thu, Aug 11, 2016 at 09:40:32AM -0700, Joshua Clayton wrote:
> Previously the onboard hub was made to work by treating its
> reset gpio as a regulator enable.
> Get rid of that kludge now that pwseq has added reset gpio support
> Move pin muxing the hub reset pin into the usbh1 group
>
>
On Thu, Aug 11, 2016 at 7:52 PM, Christoph Hellwig wrote:
>
> I can look at that, but indeed optimizing this patch seems a bit
> stupid.
The "write less than a full block to the end of the file" is actually
a reasonably common case.
It may not make for a great filesystem benchmark,
On Thu, Aug 11, 2016 at 7:52 PM, Christoph Hellwig wrote:
>
> I can look at that, but indeed optimizing this patch seems a bit
> stupid.
The "write less than a full block to the end of the file" is actually
a reasonably common case.
It may not make for a great filesystem benchmark, but it also
On Thu, Aug 11, 2016 at 09:40:29AM -0700, Joshua Clayton wrote:
>
> Hi Peter,
>
> Consider this my attempt to squeeze my own dts into your patch series.
> These patches repalce patch 6 in V5. of the usb pwrseq series
> I adding a #address and #size to imx6qdl.dtsi in patch 1
> and remove those
On Thu, Aug 11, 2016 at 09:40:29AM -0700, Joshua Clayton wrote:
>
> Hi Peter,
>
> Consider this my attempt to squeeze my own dts into your patch series.
> These patches repalce patch 6 in V5. of the usb pwrseq series
> I adding a #address and #size to imx6qdl.dtsi in patch 1
> and remove those
- On Aug 11, 2016, at 9:28 PM, Boqun Feng boqun.f...@gmail.com wrote:
> On Thu, Aug 11, 2016 at 11:26:30PM +, Mathieu Desnoyers wrote:
>> - On Jul 24, 2016, at 2:01 PM, Dave Watson davejwat...@fb.com wrote:
>>
>> >>> +static inline __attribute__((always_inline))
>> >>> +bool
On 08/10/16 at 05:09pm, Hidehiro Kawai wrote:
> Daniel Walker reported problems which happens when
> crash_kexec_post_notifiers kernel option is enabled
> (https://lkml.org/lkml/2015/6/24/44).
>
> In that case, smp_send_stop() is called before entering kdump routines
> which assume other CPUs are
- On Aug 11, 2016, at 9:28 PM, Boqun Feng boqun.f...@gmail.com wrote:
> On Thu, Aug 11, 2016 at 11:26:30PM +, Mathieu Desnoyers wrote:
>> - On Jul 24, 2016, at 2:01 PM, Dave Watson davejwat...@fb.com wrote:
>>
>> >>> +static inline __attribute__((always_inline))
>> >>> +bool
On 08/10/16 at 05:09pm, Hidehiro Kawai wrote:
> Daniel Walker reported problems which happens when
> crash_kexec_post_notifiers kernel option is enabled
> (https://lkml.org/lkml/2015/6/24/44).
>
> In that case, smp_send_stop() is called before entering kdump routines
> which assume other CPUs are
Hi Hidehiro
Thanks for the update.
On 08/10/16 at 05:09pm, Hidehiro Kawai wrote:
> Daniel Walker reported problems which happens when
> crash_kexec_post_notifiers kernel option is enabled
> (https://lkml.org/lkml/2015/6/24/44).
>
> In that case, smp_send_stop() is called before entering kdump
Hi Hidehiro
Thanks for the update.
On 08/10/16 at 05:09pm, Hidehiro Kawai wrote:
> Daniel Walker reported problems which happens when
> crash_kexec_post_notifiers kernel option is enabled
> (https://lkml.org/lkml/2015/6/24/44).
>
> In that case, smp_send_stop() is called before entering kdump
- On Aug 11, 2016, at 11:10 PM, Mathieu Desnoyers
mathieu.desnoy...@efficios.com wrote:
> - On Aug 11, 2016, at 9:28 PM, Boqun Feng boqun.f...@gmail.com wrote:
>
>> On Thu, Aug 11, 2016 at 11:26:30PM +, Mathieu Desnoyers wrote:
>>> - On Jul 24, 2016, at 2:01 PM, Dave Watson
Add support for cdn DP controller which is embedded in the rk3399
SoCs. The DP is compliant with DisplayPort Specification,
Version 1.3, This IP is compatible with the rockchip type-c PHY IP.
There is a uCPU in DP controller, it need a firmware to work,
please put the firmware file to
- On Aug 11, 2016, at 11:10 PM, Mathieu Desnoyers
mathieu.desnoy...@efficios.com wrote:
> - On Aug 11, 2016, at 9:28 PM, Boqun Feng boqun.f...@gmail.com wrote:
>
>> On Thu, Aug 11, 2016 at 11:26:30PM +, Mathieu Desnoyers wrote:
>>> - On Jul 24, 2016, at 2:01 PM, Dave Watson
Add support for cdn DP controller which is embedded in the rk3399
SoCs. The DP is compliant with DisplayPort Specification,
Version 1.3, This IP is compatible with the rockchip type-c PHY IP.
There is a uCPU in DP controller, it need a firmware to work,
please put the firmware file to
Hi Ruchi,
[auto build test WARNING on tip/timers/core]
[also build test WARNING on v4.8-rc1 next-20160811]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ruchi-Kandoi/timekeeping-Prints
Hi Ruchi,
[auto build test WARNING on tip/timers/core]
[also build test WARNING on v4.8-rc1 next-20160811]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ruchi-Kandoi/timekeeping-Prints
> "Tyrel" == Tyrel Datwyler writes:
Tyrel> On 08/03/2016 02:36 PM, Tyrel Datwyler wrote:
>> This patchset introduces optional FC-TAPE/FC Class 3 Error Recovery
>> to the ibmvfc client driver.
>>
>> Tyrel Datwyler (2): ibmvfc: Set READ FCP_XFER_READY DISABLED bit
> "Tyrel" == Tyrel Datwyler writes:
Tyrel> On 08/03/2016 02:36 PM, Tyrel Datwyler wrote:
>> This patchset introduces optional FC-TAPE/FC Class 3 Error Recovery
>> to the ibmvfc client driver.
>>
>> Tyrel Datwyler (2): ibmvfc: Set READ FCP_XFER_READY DISABLED bit in
>> PRLI ibmvfc: add FC
On 07/29/2016 06:00 AM, Mel Gorman wrote:
> On Fri, Jul 29, 2016 at 10:13:40AM +1000, Dave Chinner wrote:
>> On Thu, Jul 28, 2016 at 11:25:13AM +0100, Mel Gorman wrote:
>>> On Thu, Jul 28, 2016 at 03:49:47PM +1000, Dave Chinner wrote:
Seems you're all missing the obvious.
Add a
On 07/29/2016 06:00 AM, Mel Gorman wrote:
> On Fri, Jul 29, 2016 at 10:13:40AM +1000, Dave Chinner wrote:
>> On Thu, Jul 28, 2016 at 11:25:13AM +0100, Mel Gorman wrote:
>>> On Thu, Jul 28, 2016 at 03:49:47PM +1000, Dave Chinner wrote:
Seems you're all missing the obvious.
Add a
clk_register_fixed_factor returns an ERR_PTR in case of an error and
should have an IS_ERR check instead of a null check.
The Coccinelle semantic patch used to find this issue is as follows:
@@
expression e;
statement S;
@@
*e = clk_register_fixed_factor(...);
if (!e) S
Signed-off-by: Amitoj
clk_register_fixed_factor returns an ERR_PTR in case of an error and
should have an IS_ERR check instead of a null check.
The Coccinelle semantic patch used to find this issue is as follows:
@@
expression e;
statement S;
@@
*e = clk_register_fixed_factor(...);
if (!e) S
Signed-off-by: Amitoj
On Thu, Aug 11, 2016 at 11:31:06AM -0700, Davidlohr Bueso wrote:
> On Thu, 11 Aug 2016, Peter Zijlstra wrote:
>
> > On Wed, Aug 10, 2016 at 04:29:22PM -0700, Davidlohr Bueso wrote:
> >
> > > (1) As Manfred suggested, have a patch 1 that fixes the race against
> > > mainline
> > > with the
On Thu, Aug 11, 2016 at 11:31:06AM -0700, Davidlohr Bueso wrote:
> On Thu, 11 Aug 2016, Peter Zijlstra wrote:
>
> > On Wed, Aug 10, 2016 at 04:29:22PM -0700, Davidlohr Bueso wrote:
> >
> > > (1) As Manfred suggested, have a patch 1 that fixes the race against
> > > mainline
> > > with the
On 2016/8/11 18:08, Jaehoon Chung wrote:
Hi Shawn,
On 08/09/2016 10:49 AM, Shawn Lin wrote:
Hi,
On 2016/8/8 18:24, Jaehoon Chung wrote:
Hi Shawn,
On 08/07/2016 10:33 AM, Shawn Lin wrote:
By default, dw_mmc outputs high level voltage to indicate powering
up the card and outputs low level
On 2016/8/11 18:08, Jaehoon Chung wrote:
Hi Shawn,
On 08/09/2016 10:49 AM, Shawn Lin wrote:
Hi,
On 2016/8/8 18:24, Jaehoon Chung wrote:
Hi Shawn,
On 08/07/2016 10:33 AM, Shawn Lin wrote:
By default, dw_mmc outputs high level voltage to indicate powering
up the card and outputs low level
From: Tomohiro Kusumi
autofs4_kill_sb() doesn't need to be declared as extern,
and no other functions in .h are explicitly declared as extern.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
On Fri, Aug 12, 2016 at 12:23:29PM +1000, Dave Chinner wrote:
> Christoph, maybe there's something we can do to only trigger
> speculative prealloc growth checks if the new file size crosses the end of
> the currently allocated block at the EOF. That would chop out a fair
> chunk of the
From: Tomohiro Kusumi
autofs4_kill_sb() doesn't need to be declared as extern,
and no other functions in .h are explicitly declared as extern.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/autofs_i.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Fri, Aug 12, 2016 at 12:23:29PM +1000, Dave Chinner wrote:
> Christoph, maybe there's something we can do to only trigger
> speculative prealloc growth checks if the new file size crosses the end of
> the currently allocated block at the EOF. That would chop out a fair
> chunk of the
From: Tomohiro Kusumi
Sync with changes made by 730c9eec which introduced an union for
various ioctl commands instead of having statically named arg1,2.
This commit simply replaces arg1,2 with the corresponding fields
without changing semantics.
Signed-off-by:
From: Tomohiro Kusumi
Returning -ENOTTY here fails to free dynamically allocated param.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/dev-ioctl.c |3 ++-
1 file changed, 2 insertions(+), 1
From: Tomohiro Kusumi
Sync with changes made by 730c9eec which introduced an union for
various ioctl commands instead of having statically named arg1,2.
This commit simply replaces arg1,2 with the corresponding fields
without changing semantics.
Signed-off-by: Tomohiro Kusumi
Signed-off-by:
From: Tomohiro Kusumi
Returning -ENOTTY here fails to free dynamically allocated param.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/dev-ioctl.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
From: Tomohiro Kusumi
The explanation on how ioctl handles devid seems incorrect.
Userspace who calls this ioctl has no input regarding devid,
and ioctl implementation retrieves devid via superblock.
Signed-off-by: Tomohiro Kusumi
From: Tomohiro Kusumi
No functional changes, based on the following justification.
1. Make the code more consistent using the ioctl vector _ioctls[],
rather than assigning NULL only for this ioctl command.
2. Remove goto done; for better maintainability in the long
From: Tomohiro Kusumi
This macro was never used by neither kernel nor userspace,
and also doesn't represent "devid length" in bytes.
(unless it was added to mean something else).
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
From: Tomohiro Kusumi
This isn't a return value, so change the message to indicate
the status is the result of may_umount().
(or locate pr_debug() after put_user() with the same message)
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian
Since linux/auto_dev-ioctl.h wasn't included in include/linux/Kbuild
it wasn't moved to uapi/linux as part of the uapi series.
Signed-off-by: Ian Kent
---
include/linux/auto_dev-ioctl.h | 209 -
include/uapi/linux/auto_dev-ioctl.h | 221
From: Tomohiro Kusumi
The explanation on how ioctl handles devid seems incorrect.
Userspace who calls this ioctl has no input regarding devid,
and ioctl implementation retrieves devid via superblock.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
From: Tomohiro Kusumi
No functional changes, based on the following justification.
1. Make the code more consistent using the ioctl vector _ioctls[],
rather than assigning NULL only for this ioctl command.
2. Remove goto done; for better maintainability in the long run.
3. The existing code
From: Tomohiro Kusumi
This macro was never used by neither kernel nor userspace,
and also doesn't represent "devid length" in bytes.
(unless it was added to mean something else).
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
include/linux/auto_dev-ioctl.h |2 --
1 file
From: Tomohiro Kusumi
This isn't a return value, so change the message to indicate
the status is the result of may_umount().
(or locate pr_debug() after put_user() with the same message)
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/root.c |2 +-
1 file changed,
Since linux/auto_dev-ioctl.h wasn't included in include/linux/Kbuild
it wasn't moved to uapi/linux as part of the uapi series.
Signed-off-by: Ian Kent
---
include/linux/auto_dev-ioctl.h | 209 -
include/uapi/linux/auto_dev-ioctl.h | 221
From: Tomohiro Kusumi
linux/limits.h should be included by uapi instead of linux/auto_fs.h
so as not to cause compile error in userspace.
# cat << EOF > ./test1.c
> #include
> #include
> int main(void) {
> return 0;
> }
> EOF
# gcc -Wall -g ./test1.c
In
From: Tomohiro Kusumi
All other warnings use "cmd(0x%08x)" and this is the only one with "cmd(%d)".
(below comes from my userspace debug program, but not automount daemon)
[ 1139.905676] autofs4:pid:1640:check_dev_ioctl_version: ioctl control
interface version
The count of miscellaneous device ioctls in fs/autofs4/autofs_i.h is wrong.
The number of ioctls is the difference between AUTOFS_DEV_IOCTL_VERSION_CMD
and AUTOFS_DEV_IOCTL_ISMOUNTPOINT_CMD (14) not the difference between
AUTOFS_IOC_COUNT and 11 (21).
Signed-off-by: Ian Kent
From: Tomohiro Kusumi
linux/limits.h should be included by uapi instead of linux/auto_fs.h
so as not to cause compile error in userspace.
# cat << EOF > ./test1.c
> #include
> #include
> int main(void) {
> return 0;
> }
> EOF
# gcc -Wall -g ./test1.c
In file included from
From: Tomohiro Kusumi
All other warnings use "cmd(0x%08x)" and this is the only one with "cmd(%d)".
(below comes from my userspace debug program, but not automount daemon)
[ 1139.905676] autofs4:pid:1640:check_dev_ioctl_version: ioctl control
interface version mismatch: kernel(1.0), user(0.0),
The count of miscellaneous device ioctls in fs/autofs4/autofs_i.h is wrong.
The number of ioctls is the difference between AUTOFS_DEV_IOCTL_VERSION_CMD
and AUTOFS_DEV_IOCTL_ISMOUNTPOINT_CMD (14) not the difference between
AUTOFS_IOC_COUNT and 11 (21).
Signed-off-by: Ian Kent
Cc: Tomohiro Kusumi
From: Tomohiro Kusumi
plus minor whitespace fixes.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
Documentation/filesystems/autofs4.txt |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
The inode allocation failure case in autofs4_dir_symlink() frees
the autofs dentry info of the dentry without setting ->d_fsdata to
NULL.
That could lead to a double free so just get rid of the free and
leave it to ->d_release().
Signed-off-by: Ian Kent
Cc: Tomohiro Kusumi
1 - 100 of 1592 matches
Mail list logo