Re: [PATCH 2/2] powerpc/time: Only set ARCH_HAS_SCALED_CPUTIME on PPC64

2018-03-22 Thread kbuild test robot
Hi Christophe, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 2/2] powerpc/time: Only set ARCH_HAS_SCALED_CPUTIME on PPC64

2018-03-22 Thread kbuild test robot
Hi Christophe, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH V2 4/4] video: simplefb: switch to use clk_bulk API to simplify clock operations

2018-03-22 Thread kbuild test robot
Hi Dong, Thank you for the patch! Yet something to improve: [auto build test ERROR on clk/clk-next] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH V2 4/4] video: simplefb: switch to use clk_bulk API to simplify clock operations

2018-03-22 Thread kbuild test robot
Hi Dong, Thank you for the patch! Yet something to improve: [auto build test ERROR on clk/clk-next] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH] platform/x86: fujitsu-laptop: Simplify soft key handling

2018-03-22 Thread Jonathan Woithe
On Thu, Mar 22, 2018 at 06:27:16PM -0700, Darren Hart (VMware) wrote: > The hardcoded BIT(X) used in the soft key handling can be confusing and > prone to errors. > > Instead, use the status FLAG_* defines for the sparse keymap index. > Rather than check for each known bit, use a bitmask to

Re: [PATCH] platform/x86: fujitsu-laptop: Simplify soft key handling

2018-03-22 Thread Jonathan Woithe
On Thu, Mar 22, 2018 at 06:27:16PM -0700, Darren Hart (VMware) wrote: > The hardcoded BIT(X) used in the soft key handling can be confusing and > prone to errors. > > Instead, use the status FLAG_* defines for the sparse keymap index. > Rather than check for each known bit, use a bitmask to

Re: [v2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-03-22 Thread kbuild test robot
Hi Roy, I love your patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on next-20180322] [cannot apply to linus/master v4.16-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

Re: [v2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-03-22 Thread kbuild test robot
Hi Roy, I love your patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on next-20180322] [cannot apply to linus/master v4.16-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

[PATCH] reset: uniphier: add ethernet reset control support for PXs3

2018-03-22 Thread Kunihiko Hayashi
Add reset lines for ethernet controller on PXs3 SoC. Signed-off-by: Kunihiko Hayashi --- drivers/reset/reset-uniphier.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c index e8bb023..fd3afbd

[PATCH] reset: uniphier: add ethernet reset control support for PXs3

2018-03-22 Thread Kunihiko Hayashi
Add reset lines for ethernet controller on PXs3 SoC. Signed-off-by: Kunihiko Hayashi --- drivers/reset/reset-uniphier.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c index e8bb023..fd3afbd 100644 ---

[PATCH] clk: uniphier: add ethernet clock control support for PXs3

2018-03-22 Thread Kunihiko Hayashi
Add clock control for ethernet controller on PXs3 SoC. Signed-off-by: Kunihiko Hayashi --- drivers/clk/uniphier/clk-uniphier-sys.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/uniphier/clk-uniphier-sys.c

[PATCH] clk: uniphier: add ethernet clock control support for PXs3

2018-03-22 Thread Kunihiko Hayashi
Add clock control for ethernet controller on PXs3 SoC. Signed-off-by: Kunihiko Hayashi --- drivers/clk/uniphier/clk-uniphier-sys.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/uniphier/clk-uniphier-sys.c b/drivers/clk/uniphier/clk-uniphier-sys.c index d244e72..faadd9b

[PATCH 2/7] staging: ks7010: Fix lines over 80 characters due to comments.

2018-03-22 Thread Quytelda Kahja
There are several instances where comments are spaced so far to the right they cause the line to go over the 80 character limit. Move these comments to above the statements they describe instead. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 19

[PATCH 2/7] staging: ks7010: Fix lines over 80 characters due to comments.

2018-03-22 Thread Quytelda Kahja
There are several instances where comments are spaced so far to the right they cause the line to go over the 80 character limit. Move these comments to above the statements they describe instead. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 19 --- 1

[PATCH 4/7] staging: ks7010: Remove duplicate #define's

2018-03-22 Thread Quytelda Kahja
The AUTH_TYPE_OPEN_SYSTEM and AUTH_TYPE_SHARED_KEY #define lines are duplicated in ks_hostif.h. Replace them both with one set of Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 5/7] staging: ks7010: Replace memcmp() operation with ether_addr_equal().

2018-03-22 Thread Quytelda Kahja
Instead of using memcmp() to directly compare BSSIDs, use ether_addr_equal() from 'linux/etherdevice.h'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 4/7] staging: ks7010: Remove duplicate #define's

2018-03-22 Thread Quytelda Kahja
The AUTH_TYPE_OPEN_SYSTEM and AUTH_TYPE_SHARED_KEY #define lines are duplicated in ks_hostif.h. Replace them both with one set of Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 5/7] staging: ks7010: Replace memcmp() operation with ether_addr_equal().

2018-03-22 Thread Quytelda Kahja
Instead of using memcmp() to directly compare BSSIDs, use ether_addr_equal() from 'linux/etherdevice.h'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c

[PATCH 1/7] staging: ks7010: Fix line over 80 characters.

2018-03-22 Thread Quytelda Kahja
There is no reason for comment describing the BSSID check for loop to be spaced so far to the right. Move it above the for loop. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 1/7] staging: ks7010: Fix line over 80 characters.

2018-03-22 Thread Quytelda Kahja
There is no reason for comment describing the BSSID check for loop to be spaced so far to the right. Move it above the for loop. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 3/7] staging: ks7010: Factor out common members in request structs.

2018-03-22 Thread Quytelda Kahja
Most of the request structures defined in ks_hostif.h have common members: * __le16 phy_type; * __le16 cts_mode; * __le16 scan_type; * __le16 capability; * struct rate_set16_t rate_set; Factor out these members into a common substructure of type 'hostif_request_t'. This allows a large portion of

[PATCH 3/7] staging: ks7010: Factor out common members in request structs.

2018-03-22 Thread Quytelda Kahja
Most of the request structures defined in ks_hostif.h have common members: * __le16 phy_type; * __le16 cts_mode; * __le16 scan_type; * __le16 capability; * struct rate_set16_t rate_set; Factor out these members into a common substructure of type 'hostif_request_t'. This allows a large portion of

[PATCH 7/7] staging: ks7010: Remove hostif_infrastructure_set2_request_t.

2018-03-22 Thread Quytelda Kahja
The handling of hostif_infrastructure_set_request_t and hostif_infrastructure_set2_request_t is identical, with the exception of the event type value. Merge the two structs so they can be handled by a single function ('hostif_infrastructure_set_request'). Signed-off-by: Quytelda Kahja

[PATCH 7/7] staging: ks7010: Remove hostif_infrastructure_set2_request_t.

2018-03-22 Thread Quytelda Kahja
The handling of hostif_infrastructure_set_request_t and hostif_infrastructure_set2_request_t is identical, with the exception of the event type value. Merge the two structs so they can be handled by a single function ('hostif_infrastructure_set_request'). Signed-off-by: Quytelda Kahja ---

[PATCH 6/7] staging: ks7010: Factor out repeated code for reading IEs.

2018-03-22 Thread Quytelda Kahja
Some of the code for reading IEs is replicated multiple times in the switch statement for get_ap_information(). Factor that code out into read_ie(). Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 31 +++ 1 file changed,

[PATCH 6/7] staging: ks7010: Factor out repeated code for reading IEs.

2018-03-22 Thread Quytelda Kahja
Some of the code for reading IEs is replicated multiple times in the switch statement for get_ap_information(). Factor that code out into read_ie(). Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 31 +++ 1 file changed, 15 insertions(+), 16

Re: [PATCH v4 04/24] fpga: add device feature list support

2018-03-22 Thread Wu Hao
On Thu, Mar 22, 2018 at 04:31:05PM -0500, Alan Tull wrote: > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > Hi Hao, Hi Alan Thanks a lot for the code review and the comments. : ) > > > Device Feature List (DFL) defines a feature list structure that creates > > a link

Re: [PATCH v4 04/24] fpga: add device feature list support

2018-03-22 Thread Wu Hao
On Thu, Mar 22, 2018 at 04:31:05PM -0500, Alan Tull wrote: > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > Hi Hao, Hi Alan Thanks a lot for the code review and the comments. : ) > > > Device Feature List (DFL) defines a feature list structure that creates > > a link list of feature

Re: [PATCH v2 1/6] phy: qcom-qmp: Enable pipe_clk before checking USB3 PHY_STATUS

2018-03-22 Thread Manu Gautam
Hi Stephen, On 3/23/2018 12:13 AM, Stephen Boyd wrote: > Quoting Manu Gautam (2018-03-22 01:50:41) >> QMP PHY for USB mode requires pipe_clk for calibration and PLL lock >> to take place. This lock is output from PHY to GCC clock_ctl and then > s/lock/clock/ Yes, will fix typo. >> fed back to

Re: [PATCH v2 1/6] phy: qcom-qmp: Enable pipe_clk before checking USB3 PHY_STATUS

2018-03-22 Thread Manu Gautam
Hi Stephen, On 3/23/2018 12:13 AM, Stephen Boyd wrote: > Quoting Manu Gautam (2018-03-22 01:50:41) >> QMP PHY for USB mode requires pipe_clk for calibration and PLL lock >> to take place. This lock is output from PHY to GCC clock_ctl and then > s/lock/clock/ Yes, will fix typo. >> fed back to

Re: linux-next: manual merge of the net-next tree with the rdma-fixes tree

2018-03-22 Thread Jason Gunthorpe
On Fri, Mar 23, 2018 at 12:19:00AM -0400, David Miller wrote: > From: Doug Ledford > Date: Thu, 15 Mar 2018 21:18:02 -0400 > > > Here's the commit (from the rdma git repo) with the proper merge fix > > (although it also has other minor merge stuff that needs to be ignored):

Re: linux-next: manual merge of the net-next tree with the rdma-fixes tree

2018-03-22 Thread Jason Gunthorpe
On Fri, Mar 23, 2018 at 12:19:00AM -0400, David Miller wrote: > From: Doug Ledford > Date: Thu, 15 Mar 2018 21:18:02 -0400 > > > Here's the commit (from the rdma git repo) with the proper merge fix > > (although it also has other minor merge stuff that needs to be ignored): > > > > 2d873449a202

Re: [PATCH] dlm: prompt the user SCTP is experimental

2018-03-22 Thread Gang He
Hello David, Do you agree to add this prompt to the user? Since sometimes customers attempted to setup SCTP protocol with two rings, but they could not get the expected result, then it maybe bring some concerns to the customer for DLM qualities. Thanks Gang >>> > As you know, DLM module

Re: [PATCH] dlm: prompt the user SCTP is experimental

2018-03-22 Thread Gang He
Hello David, Do you agree to add this prompt to the user? Since sometimes customers attempted to setup SCTP protocol with two rings, but they could not get the expected result, then it maybe bring some concerns to the customer for DLM qualities. Thanks Gang >>> > As you know, DLM module

Re: linux-next: manual merge of the net-next tree with the rdma-fixes tree

2018-03-22 Thread David Miller
From: Doug Ledford Date: Thu, 15 Mar 2018 21:18:02 -0400 > Here's the commit (from the rdma git repo) with the proper merge fix > (although it also has other minor merge stuff that needs to be ignored): > > 2d873449a202 (Merge branch 'k.o/wip/dl-for-rc' into

Re: linux-next: manual merge of the net-next tree with the rdma-fixes tree

2018-03-22 Thread David Miller
From: Doug Ledford Date: Thu, 15 Mar 2018 21:18:02 -0400 > Here's the commit (from the rdma git repo) with the proper merge fix > (although it also has other minor merge stuff that needs to be ignored): > > 2d873449a202 (Merge branch 'k.o/wip/dl-for-rc' into k.o/wip/dl-for-next) Really?

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread kbuild test robot
Hi Sinan, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread kbuild test robot
Hi Sinan, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCH v2 2/2] media: Add a driver for the ov7251 camera sensor

2018-03-22 Thread Todor Tomov
The ov7251 sensor is a 1/7.5-Inch B VGA (640x480) CMOS Digital Image Sensor from Omnivision. The driver supports the following modes: - 640x480 30fps - 640x480 60fps - 640x480 90fps Output format is MIPI RAW 10. The driver supports configuration via user controls for: - exposure and gain; -

[PATCH v2 2/2] media: Add a driver for the ov7251 camera sensor

2018-03-22 Thread Todor Tomov
The ov7251 sensor is a 1/7.5-Inch B VGA (640x480) CMOS Digital Image Sensor from Omnivision. The driver supports the following modes: - 640x480 30fps - 640x480 60fps - 640x480 90fps Output format is MIPI RAW 10. The driver supports configuration via user controls for: - exposure and gain; -

[PATCH v2 1/2] dt-bindings: media: Binding document for OV7251 camera sensor

2018-03-22 Thread Todor Tomov
Add the document for ov7251 device tree binding. CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov Reviewed-by: Rob Herring ---

[PATCH v2 1/2] dt-bindings: media: Binding document for OV7251 camera sensor

2018-03-22 Thread Todor Tomov
Add the document for ov7251 device tree binding. CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov Reviewed-by: Rob Herring --- .../devicetree/bindings/media/i2c/ov7251.txt | 51 ++ 1 file changed, 51 insertions(+) create

[PATCH v2 0/2] Add support for ov7251 camera sensor

2018-03-22 Thread Todor Tomov
The ov7251 sensor is a 1/7.5-Inch B VGA (640x480) CMOS Digital Image Sensor from Omnivision. -- Version 2: - changed ov7251 node's name in DT binding example; - SPDX licence identifier; - better names for register value

[PATCH v2 0/2] Add support for ov7251 camera sensor

2018-03-22 Thread Todor Tomov
The ov7251 sensor is a 1/7.5-Inch B VGA (640x480) CMOS Digital Image Sensor from Omnivision. -- Version 2: - changed ov7251 node's name in DT binding example; - SPDX licence identifier; - better names for register value

[PATCH v2 0/2] Add support for ov7251 camera sensor

2018-03-22 Thread Todor Tomov
The ov7251 sensor is a 1/7.5-Inch B VGA (640x480) CMOS Digital Image Sensor from Omnivision. -- Version 2: - changed ov7251 node's name in DT binding example; - SPDX licence identifier; - better names for register value

[PATCH v2 0/2] Add support for ov7251 camera sensor

2018-03-22 Thread Todor Tomov
The ov7251 sensor is a 1/7.5-Inch B VGA (640x480) CMOS Digital Image Sensor from Omnivision. -- Version 2: - changed ov7251 node's name in DT binding example; - SPDX licence identifier; - better names for register value

Re: [PATCH V3] ZBOOT: fix stack protector in compressed boot phase

2018-03-22 Thread Jiaxun Yang
在 2018-03-22四的 22:21 +,James Hogan写道: > On Fri, Mar 16, 2018 at 03:55:16PM +0800, Huacai Chen wrote: > > diff --git a/arch/mips/boot/compressed/decompress.c > > b/arch/mips/boot/compressed/decompress.c > > index fdf99e9..5ba431c 100644 > > --- a/arch/mips/boot/compressed/decompress.c > > +++

Re: [PATCH V3] ZBOOT: fix stack protector in compressed boot phase

2018-03-22 Thread Jiaxun Yang
在 2018-03-22四的 22:21 +,James Hogan写道: > On Fri, Mar 16, 2018 at 03:55:16PM +0800, Huacai Chen wrote: > > diff --git a/arch/mips/boot/compressed/decompress.c > > b/arch/mips/boot/compressed/decompress.c > > index fdf99e9..5ba431c 100644 > > --- a/arch/mips/boot/compressed/decompress.c > > +++

[PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()

2018-03-22 Thread Ryder Lee
The error return value should be fixed as it may return EPROBE_DEFER. Cc: Rick Chang Cc: Bin Liu Signed-off-by: Ryder Lee --- drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()

2018-03-22 Thread Ryder Lee
The error return value should be fixed as it may return EPROBE_DEFER. Cc: Rick Chang Cc: Bin Liu Signed-off-by: Ryder Lee --- drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c

Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements

2018-03-22 Thread Chris Packham
On 07/12/17 23:42, Wolfram Sang wrote: > On Sun, Oct 29, 2017 at 06:29:18PM +0100, Wolfram Sang wrote: >> On Wed, Jul 05, 2017 at 10:13:54PM +1200, Chris Packham wrote: >>> This series addresses some of the points identified by Andy. The series is >>> based on top of i2c/for-next. 2 of the patches

Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements

2018-03-22 Thread Chris Packham
On 07/12/17 23:42, Wolfram Sang wrote: > On Sun, Oct 29, 2017 at 06:29:18PM +0100, Wolfram Sang wrote: >> On Wed, Jul 05, 2017 at 10:13:54PM +1200, Chris Packham wrote: >>> This series addresses some of the points identified by Andy. The series is >>> based on top of i2c/for-next. 2 of the patches

Re: [PATCH 0/8] Move most GPIO documentation to driver-api/gpio/ and ReST

2018-03-22 Thread Linus Walleij
On Fri, Mar 9, 2018 at 12:40 AM, Jonathan Neuschäfer wrote: > Jonathan Neuschäfer (8): > MAINTAINERS: GPIO: Add Documentation/driver-api/gpio/ > Documentation: driver-api: Move gpio.rst to gpio/index.rst > Documentation: gpio: Move introduction to driver-api >

Re: [PATCH 0/8] Move most GPIO documentation to driver-api/gpio/ and ReST

2018-03-22 Thread Linus Walleij
On Fri, Mar 9, 2018 at 12:40 AM, Jonathan Neuschäfer wrote: > Jonathan Neuschäfer (8): > MAINTAINERS: GPIO: Add Documentation/driver-api/gpio/ > Documentation: driver-api: Move gpio.rst to gpio/index.rst > Documentation: gpio: Move introduction to driver-api > Documentation: gpio: Move

Re: [usb-next, v3 PATCH] usb: xhci: skip phys initialization of shared hcd

2018-03-22 Thread Chunfeng Yun
On Thu, 2018-03-22 at 13:53 +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 22, 2018 at 08:12:50PM +0800, Chunfeng Yun wrote: > > The phys has already been initialized when add primary hcd, > > including usb2 phys and usb3 phys also if exist, so needn't > > re-parse "phys" property again. > >

Re: [usb-next, v3 PATCH] usb: xhci: skip phys initialization of shared hcd

2018-03-22 Thread Chunfeng Yun
On Thu, 2018-03-22 at 13:53 +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 22, 2018 at 08:12:50PM +0800, Chunfeng Yun wrote: > > The phys has already been initialized when add primary hcd, > > including usb2 phys and usb3 phys also if exist, so needn't > > re-parse "phys" property again. > >

RE: [PATCH] qed: Use true and false for boolean values

2018-03-22 Thread Kalluru, Sudarsana
-Original Message- From: Gustavo A. R. Silva [mailto:gust...@embeddedor.com] Sent: 23 March 2018 01:39 To: Elior, Ariel ; Dept-Eng Everest Linux L2 Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva

RE: [PATCH] qed: Use true and false for boolean values

2018-03-22 Thread Kalluru, Sudarsana
-Original Message- From: Gustavo A. R. Silva [mailto:gust...@embeddedor.com] Sent: 23 March 2018 01:39 To: Elior, Ariel ; Dept-Eng Everest Linux L2 Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva Subject: [PATCH] qed: Use true and false for boolean values

RE: [PATCH v2] cpuidle: poll_state: Add time limit to poll_idle()

2018-03-22 Thread Doug Smythies
On 2018.03.22 12:12 Doug Smythies wrote: >On 2018.03.22 09:32 Rik van Riel wrote: >> On Wed, 2018-03-14 at 13:04 +0100, Peter Zijlstra wrote: >> >>> On x86 we don't have to use that time_check_counter thing, >>> sched_clock() >>> is really cheap, not sure if it makes sense on other platforms. >>

RE: [PATCH v2] cpuidle: poll_state: Add time limit to poll_idle()

2018-03-22 Thread Doug Smythies
On 2018.03.22 12:12 Doug Smythies wrote: >On 2018.03.22 09:32 Rik van Riel wrote: >> On Wed, 2018-03-14 at 13:04 +0100, Peter Zijlstra wrote: >> >>> On x86 we don't have to use that time_check_counter thing, >>> sched_clock() >>> is really cheap, not sure if it makes sense on other platforms. >>

[PATCH v4 02/22] iommu/vt-d: move device_domain_info to header

2018-03-22 Thread Jacob Pan
Allow both intel-iommu.c and dmar.c to access device_domain_info. Prepare for additional per device arch data used in TLB flush function Signed-off-by: Jacob Pan --- drivers/iommu/intel-iommu.c | 18 -- include/linux/intel-iommu.h | 19

[PATCH v4 02/22] iommu/vt-d: move device_domain_info to header

2018-03-22 Thread Jacob Pan
Allow both intel-iommu.c and dmar.c to access device_domain_info. Prepare for additional per device arch data used in TLB flush function Signed-off-by: Jacob Pan --- drivers/iommu/intel-iommu.c | 18 -- include/linux/intel-iommu.h | 19 +++ 2 files changed, 19

[PATCH v4 00/22] IOMMU and VT-d driver support for Shared Virtual Address (SVA)

2018-03-22 Thread Jacob Pan
Hi All, Shared virtual address (SVA), a.k.a, Shared virtual memory (SVM) on Intel platforms allow address space sharing between device DMA and applications. SVA can reduce programming complexity and enhance security. To enable SVA in the guest, i.e. shared guest application address space and

[PATCH v4 00/22] IOMMU and VT-d driver support for Shared Virtual Address (SVA)

2018-03-22 Thread Jacob Pan
Hi All, Shared virtual address (SVA), a.k.a, Shared virtual memory (SVM) on Intel platforms allow address space sharing between device DMA and applications. SVA can reduce programming complexity and enhance security. To enable SVA in the guest, i.e. shared guest application address space and

[PATCH v4 04/22] iommu/vt-d: add bind_pasid_table function

2018-03-22 Thread Jacob Pan
Add Intel VT-d ops to the generic iommu_bind_pasid_table API functions. The primary use case is for direct assignment of SVM capable device. Originated from emulated IOMMU in the guest, the request goes through many layers (e.g. VFIO). Upon calling host IOMMU driver, caller passes guest PASID

[PATCH v4 04/22] iommu/vt-d: add bind_pasid_table function

2018-03-22 Thread Jacob Pan
Add Intel VT-d ops to the generic iommu_bind_pasid_table API functions. The primary use case is for direct assignment of SVM capable device. Originated from emulated IOMMU in the guest, the request goes through many layers (e.g. VFIO). Upon calling host IOMMU driver, caller passes guest PASID

[PATCH v4 07/22] iommu/vt-d: fix dev iotlb pfsid use

2018-03-22 Thread Jacob Pan
PFSID should be used in the invalidation descriptor for flushing device IOTLBs on SRIOV VFs. Signed-off-by: Jacob Pan --- drivers/iommu/dmar.c| 6 +++--- drivers/iommu/intel-iommu.c | 16 +++- include/linux/intel-iommu.h | 5 ++--- 3 files

[PATCH v4 09/22] iommu/vt-d: add svm/sva invalidate function

2018-03-22 Thread Jacob Pan
When Shared Virtual Address (SVA) is enabled for a guest OS via vIOMMU, we need to provide invalidation support at IOMMU API and driver level. This patch adds Intel VT-d specific function to implement iommu passdown invalidate API for shared virtual address. The use case is for supporting caching

[PATCH v4 03/22] iommu/vt-d: add a flag for pasid table bound status

2018-03-22 Thread Jacob Pan
Adding a flag in device domain into to track whether a guest or user PASID table is bound to a device. Signed-off-by: Jacob Pan --- include/linux/intel-iommu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/intel-iommu.h

[PATCH v4 07/22] iommu/vt-d: fix dev iotlb pfsid use

2018-03-22 Thread Jacob Pan
PFSID should be used in the invalidation descriptor for flushing device IOTLBs on SRIOV VFs. Signed-off-by: Jacob Pan --- drivers/iommu/dmar.c| 6 +++--- drivers/iommu/intel-iommu.c | 16 +++- include/linux/intel-iommu.h | 5 ++--- 3 files changed, 20 insertions(+), 7

[PATCH v4 09/22] iommu/vt-d: add svm/sva invalidate function

2018-03-22 Thread Jacob Pan
When Shared Virtual Address (SVA) is enabled for a guest OS via vIOMMU, we need to provide invalidation support at IOMMU API and driver level. This patch adds Intel VT-d specific function to implement iommu passdown invalidate API for shared virtual address. The use case is for supporting caching

[PATCH v4 03/22] iommu/vt-d: add a flag for pasid table bound status

2018-03-22 Thread Jacob Pan
Adding a flag in device domain into to track whether a guest or user PASID table is bound to a device. Signed-off-by: Jacob Pan --- include/linux/intel-iommu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h index 13b44bb..e4a16dc

[PATCH v4 12/22] iommu: introduce device fault report API

2018-03-22 Thread Jacob Pan
Traditionally, device specific faults are detected and handled within their own device drivers. When IOMMU is enabled, faults such as DMA related transactions are detected by IOMMU. There is no generic reporting mechanism to report faults back to the in-kernel device driver or the guest OS in case

[PATCH v4 01/22] iommu: introduce bind_pasid_table API function

2018-03-22 Thread Jacob Pan
Virtual IOMMU was proposed to support Shared Virtual Memory (SVM) use in the guest: https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg05311.html As part of the proposed architecture, when an SVM capable PCI device is assigned to a guest, nested mode is turned on. Guest owns the first level

[PATCH v4 08/22] iommu/vt-d: support flushing more translation cache types

2018-03-22 Thread Jacob Pan
When Shared Virtual Memory is exposed to a guest via vIOMMU, extended IOTLB invalidation may be passed down from outside IOMMU subsystems. This patch adds invalidation functions that can be used for additional translation cache types. Signed-off-by: Jacob Pan ---

[PATCH v4 01/22] iommu: introduce bind_pasid_table API function

2018-03-22 Thread Jacob Pan
Virtual IOMMU was proposed to support Shared Virtual Memory (SVM) use in the guest: https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg05311.html As part of the proposed architecture, when an SVM capable PCI device is assigned to a guest, nested mode is turned on. Guest owns the first level

[PATCH v4 08/22] iommu/vt-d: support flushing more translation cache types

2018-03-22 Thread Jacob Pan
When Shared Virtual Memory is exposed to a guest via vIOMMU, extended IOTLB invalidation may be passed down from outside IOMMU subsystems. This patch adds invalidation functions that can be used for additional translation cache types. Signed-off-by: Jacob Pan --- drivers/iommu/dmar.c|

[PATCH v4 12/22] iommu: introduce device fault report API

2018-03-22 Thread Jacob Pan
Traditionally, device specific faults are detected and handled within their own device drivers. When IOMMU is enabled, faults such as DMA related transactions are detected by IOMMU. There is no generic reporting mechanism to report faults back to the in-kernel device driver or the guest OS in case

[PATCH v4 13/22] iommu: introduce page response function

2018-03-22 Thread Jacob Pan
IO page faults can be handled outside IOMMU subsystem. For an example, when nested translation is turned on and guest owns the first level page tables, device page request can be forwared to the guest for handling faults. As the page response returns by the guest, IOMMU driver on the host need to

[PATCH v4 13/22] iommu: introduce page response function

2018-03-22 Thread Jacob Pan
IO page faults can be handled outside IOMMU subsystem. For an example, when nested translation is turned on and guest owns the first level page tables, device page request can be forwared to the guest for handling faults. As the page response returns by the guest, IOMMU driver on the host need to

[PATCH v4 11/22] driver core: add per device iommu param

2018-03-22 Thread Jacob Pan
DMA faults can be detected by IOMMU at device level. Adding a pointer to struct device allows IOMMU subsystem to report relevant faults back to the device driver for further handling. For direct assigned device (or user space drivers), guest OS holds responsibility to handle and respond per device

[PATCH v4 11/22] driver core: add per device iommu param

2018-03-22 Thread Jacob Pan
DMA faults can be detected by IOMMU at device level. Adding a pointer to struct device allows IOMMU subsystem to report relevant faults back to the device driver for further handling. For direct assigned device (or user space drivers), guest OS holds responsibility to handle and respond per device

[PATCH v4 06/22] iommu/vt-d: add definitions for PFSID

2018-03-22 Thread Jacob Pan
When SRIOV VF device IOTLB is invalidated, we need to provide the PF source ID such that IOMMU hardware can gauge the depth of invalidation queue which is shared among VFs. This is needed when device invalidation throttle (DIT) capability is supported. This patch adds bit definitions for checking

[PATCH v4 14/22] iommu: handle page response timeout

2018-03-22 Thread Jacob Pan
When IO page faults are reported outside IOMMU subsystem, the page request handler may fail for various reasons. E.g. a guest received page requests but did not have a chance to run for a long time. The irresponsive behavior could hold off limited resources on the pending device. There can be

[PATCH v4 14/22] iommu: handle page response timeout

2018-03-22 Thread Jacob Pan
When IO page faults are reported outside IOMMU subsystem, the page request handler may fail for various reasons. E.g. a guest received page requests but did not have a chance to run for a long time. The irresponsive behavior could hold off limited resources on the pending device. There can be

[PATCH v4 06/22] iommu/vt-d: add definitions for PFSID

2018-03-22 Thread Jacob Pan
When SRIOV VF device IOTLB is invalidated, we need to provide the PF source ID such that IOMMU hardware can gauge the depth of invalidation queue which is shared among VFs. This is needed when device invalidation throttle (DIT) capability is supported. This patch adds bit definitions for checking

[PATCH v4 16/22] iommu/vt-d: report non-recoverable faults to device

2018-03-22 Thread Jacob Pan
Currently, dmar fault IRQ handler does nothing more than rate limited printk, no critical hardware handling need to be done in IRQ context. For some use case such as vIOMMU, it might be useful to report non-recoverable faults outside host IOMMU subsystem. DMAR fault can come from both DMA and

[PATCH v4 16/22] iommu/vt-d: report non-recoverable faults to device

2018-03-22 Thread Jacob Pan
Currently, dmar fault IRQ handler does nothing more than rate limited printk, no critical hardware handling need to be done in IRQ context. For some use case such as vIOMMU, it might be useful to report non-recoverable faults outside host IOMMU subsystem. DMAR fault can come from both DMA and

[PATCH v4 05/22] iommu: introduce iommu invalidate API function

2018-03-22 Thread Jacob Pan
From: "Liu, Yi L" When an SVM capable device is assigned to a guest, the first level page tables are owned by the guest and the guest PASID table pointer is linked to the device context entry of the physical IOMMU. Host IOMMU driver has no knowledge of caching

[PATCH v4 17/22] iommu/intel-svm: report device page request

2018-03-22 Thread Jacob Pan
If the source device of a page request has its PASID table pointer bound to a guest, the first level page tables are owned by the guest. In this case, we shall let guest OS to manage page fault. This patch uses the IOMMU fault reporting API to send fault events, possibly via VFIO, to the guest

[PATCH v4 05/22] iommu: introduce iommu invalidate API function

2018-03-22 Thread Jacob Pan
From: "Liu, Yi L" When an SVM capable device is assigned to a guest, the first level page tables are owned by the guest and the guest PASID table pointer is linked to the device context entry of the physical IOMMU. Host IOMMU driver has no knowledge of caching structure updates unless the guest

[PATCH v4 17/22] iommu/intel-svm: report device page request

2018-03-22 Thread Jacob Pan
If the source device of a page request has its PASID table pointer bound to a guest, the first level page tables are owned by the guest. In this case, we shall let guest OS to manage page fault. This patch uses the IOMMU fault reporting API to send fault events, possibly via VFIO, to the guest

[PATCH v4 18/22] iommu/intel-svm: replace dev ops with fault report API

2018-03-22 Thread Jacob Pan
With the introduction of generic IOMMU device fault reporting API, we can replace the private fault callback functions with standard function and event data. Signed-off-by: Jacob Pan --- drivers/iommu/intel-svm.c | 7 +-- include/linux/intel-svm.h | 20

Re: [PATCH] pinctrl: devicetree: Fix dt_to_map_one_config handling of hogs

2018-03-22 Thread Linus Walleij
On Wed, Mar 7, 2018 at 5:12 PM, Charles Keepax wrote: > On Fri, Mar 02, 2018 at 09:42:54AM +0100, Linus Walleij wrote: >> On Wed, Feb 28, 2018 at 4:53 PM, Richard Fitzgerald >> wrote: >> >> > When dt_to_map_one_config() is called with a

[PATCH v4 20/22] iommu/vt-d: add intel iommu page response function

2018-03-22 Thread Jacob Pan
This patch adds page response support for Intel VT-d. Generic response data is taken from the IOMMU API then parsed into VT-d specific response descriptor format. Signed-off-by: Jacob Pan --- drivers/iommu/intel-iommu.c | 47

[PATCH v4 18/22] iommu/intel-svm: replace dev ops with fault report API

2018-03-22 Thread Jacob Pan
With the introduction of generic IOMMU device fault reporting API, we can replace the private fault callback functions with standard function and event data. Signed-off-by: Jacob Pan --- drivers/iommu/intel-svm.c | 7 +-- include/linux/intel-svm.h | 20 +++- 2 files

Re: [PATCH] pinctrl: devicetree: Fix dt_to_map_one_config handling of hogs

2018-03-22 Thread Linus Walleij
On Wed, Mar 7, 2018 at 5:12 PM, Charles Keepax wrote: > On Fri, Mar 02, 2018 at 09:42:54AM +0100, Linus Walleij wrote: >> On Wed, Feb 28, 2018 at 4:53 PM, Richard Fitzgerald >> wrote: >> >> > When dt_to_map_one_config() is called with a pinctrl_dev passed >> > in, it should only be using this if

[PATCH v4 20/22] iommu/vt-d: add intel iommu page response function

2018-03-22 Thread Jacob Pan
This patch adds page response support for Intel VT-d. Generic response data is taken from the IOMMU API then parsed into VT-d specific response descriptor format. Signed-off-by: Jacob Pan --- drivers/iommu/intel-iommu.c | 47 +

[PATCH v4 21/22] trace/iommu: add sva trace events

2018-03-22 Thread Jacob Pan
Signed-off-by: Jacob Pan --- include/trace/events/iommu.h | 112 +++ 1 file changed, 112 insertions(+) diff --git a/include/trace/events/iommu.h b/include/trace/events/iommu.h index 72b4582..e64eb29 100644 ---

[PATCH v4 10/22] iommu: introduce device fault data

2018-03-22 Thread Jacob Pan
Device faults detected by IOMMU can be reported outside IOMMU subsystem for further processing. This patch intends to provide a generic device fault data such that device drivers can be communicated with IOMMU faults without model specific knowledge. The proposed format is the result of

  1   2   3   4   5   6   7   8   9   10   >