Re: [PATCH v2] x86: fix movdir64b() sparse warning

2021-01-06 Thread Borislav Petkov
On Wed, Jan 06, 2021 at 03:40:25PM -0700, Dave Jiang wrote: > Subject: Re: [PATCH v2] x86: fix movdir64b() sparse warning There are a lot of times I don't agree with checkpatch but this time I do: WARNING: A patch subject line should describe the change not the tool that found it #2: Subject:

Re: [PATCH 3/5] crypto: add RFC5869 HKDF

2021-01-06 Thread Stephan Mueller
Am Mittwoch, dem 06.01.2021 um 23:30 -0800 schrieb Eric Biggers: > On Mon, Jan 04, 2021 at 10:49:13PM +0100, Stephan Müller wrote: > > RFC5869 specifies an extract and expand two-step key derivation > > function. The HKDF implementation is provided as a service function that > > operates on a

Re: Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2021-01-06 Thread dinghao . liu
> On Wed, 6 Jan 2021 18:56:23 +0800 (GMT+08:00) dinghao@zju.edu.cn > wrote: > > > I used this one for a test: > > > > > > https://patchwork.kernel.org/project/netdevbpf/patch/1609312994-121032-1-git-send-email-abaci-bug...@linux.alibaba.com/ > > > > > > I'm not getting the Fixes tag when I

[PATCH v2] kasan: remove redundant config option

2021-01-06 Thread Walter Wu
CONFIG_KASAN_STACK and CONFIG_KASAN_STACK_ENABLE both enable KASAN stack instrumentation, but we should only need one config, so that we remove CONFIG_KASAN_STACK_ENABLE and make CONFIG_KASAN_STACK workable. see [1]. When enable KASAN stack instrumentation, then for gcc we could do no prompt and

[PATCH 4.19 1/7] clone: add CLONE_PIDFD

2021-01-06 Thread Wen Yang
From: Christian Brauner [ Upstream commit b3e5838252665ee4cfa76b82bdf1198dca81e5be ] This patchset makes it possible to retrieve pid file descriptors at process creation time by introducing the new flag CLONE_PIDFD to the clone() system call. Linus originally suggested to implement this as a

[PATCH 4.19 5/7] proc: Clear the pieces of proc_inode that proc_evict_inode cares about

2021-01-06 Thread Wen Yang
From: "Eric W. Biederman" [ Upstream commit 71448011ea2a1cd36d8f5cbdab0ed716c454d565 ] This just keeps everything tidier, and allows for using flags like SLAB_TYPESAFE_BY_RCU where slabs are not always cleared before reuse. I don't see reuse without reinitializing happening with the proc_inode

[PATCH 4.19 6/7] proc: Use d_invalidate in proc_prune_siblings_dcache

2021-01-06 Thread Wen Yang
From: "Eric W. Biederman" [ Upstream commit f90f3cafe8d56d593fc509a4185da1d5800efea4 ] The function d_prune_aliases has the problem that it will only prune aliases thare are completely unused. It will not remove aliases for the dcache or even think of removing mounts from the dcache. For that

Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register

2021-01-06 Thread Michael Walle
Hi Shawn, Am 2021-01-07 07:40, schrieb Shawn Guo: On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote: The offset of the reset request register is 0, the absolute address is 0x1e6. Boards without PSCI support will fail to perform a reset: [ 26.734700] reboot: Restarting system

[PATCH 4.19 2/7] pidfd: add polling support

2021-01-06 Thread Wen Yang
From: "Joel Fernandes (Google)" [ Upstream commit b53b0b9d9a613c418057f6cb921c2f40a6f78c24 ] This patch adds polling support to pidfd. Android low memory killer (LMK) needs to know when a process dies once it is sent the kill signal. It does so by checking for the existence of /proc/pid which

[PATCH 4.19 3/7] proc: Rename in proc_inode rename sysctl_inodes sibling_inodes

2021-01-06 Thread Wen Yang
From: "Eric W. Biederman" [ Upstream commit 0afa5ca82212247456f9de1468b595a111fee633 ] I about to need and use the same functionality for pid based inodes and there is no point in adding a second field when this field is already here and serving the same purporse. Just give the field a generic

[PATCH 4.19 7/7] proc: Use a list of inodes to flush from proc

2021-01-06 Thread Wen Yang
From: "Eric W. Biederman" [ Upstream commit 7bc3e6e55acf065500a24621f3b313e7e5998acf ] Rework the flushing of proc to use a list of directory inodes that need to be flushed. The list is kept on struct pid not on struct task_struct, as there is a fixed connection between proc inodes and pids

[PATCH 4.19 4/7] proc: Generalize proc_sys_prune_dcache into proc_prune_siblings_dcache

2021-01-06 Thread Wen Yang
From: "Eric W. Biederman" [ Upstream commit 26dbc60f385ff9cff475ea2a3bad02e80fd6fa43 ] This prepares the way for allowing the pid part of proc to use this dcache pruning code as well. Signed-off-by: Eric W. Biederman Cc: # 4.19.x Signed-off-by: Wen Yang --- fs/proc/inode.c | 38

[PATCH v2 4.9 04/10] proc: Better ownership of files for non-dumpable tasks in user namespaces

2021-01-06 Thread Wen Yang
From: "Eric W. Biederman" [ Upstream commit 68eb94f16227336a5773b83ecfa8290f1d6b78ce ] Instead of making the files owned by the GLOBAL_ROOT_USER. Make non-dumpable files whose mm has always lived in a user namespace owned by the user namespace root. This allows the container root to have

[PATCH 4.19 0/7] fix a race in release_task when flushing the dentry

2021-01-06 Thread Wen Yang
The dentries such as /proc//ns/ have the DCACHE_OP_DELETE flag, they should be deleted when the process exits. Suppose the following race appears: release_task dput -> proc_flush_task -> dentry->d_op->d_delete(dentry) -> __exit_signal

[PATCH v2 4.9 05/10] proc: use %u for pid printing and slightly less stack

2021-01-06 Thread Wen Yang
From: Alexey Dobriyan [ Upstream commit e3912ac37e07a13c70675cd75020694de4841c74 ] PROC_NUMBUF is 13 which is enough for "negative int + \n + \0". However PIDs and TGIDs are never negative and newline is not a concern, so use just 10 per integer. Link:

[PATCH v2 4.9 08/10] proc: Clear the pieces of proc_inode that proc_evict_inode cares about

2021-01-06 Thread Wen Yang
From: "Eric W. Biederman" [ Upstream commit 71448011ea2a1cd36d8f5cbdab0ed716c454d565 ] This just keeps everything tidier, and allows for using flags like SLAB_TYPESAFE_BY_RCU where slabs are not always cleared before reuse. I don't see reuse without reinitializing happening with the proc_inode

[PATCH v2 4.9 10/10] proc: Use a list of inodes to flush from proc

2021-01-06 Thread Wen Yang
From: "Eric W. Biederman" [ Upstream commit 7bc3e6e55acf065500a24621f3b313e7e5998acf ] Rework the flushing of proc to use a list of directory inodes that need to be flushed. The list is kept on struct pid not on struct task_struct, as there is a fixed connection between proc inodes and pids

[PATCH v2 4.9 01/10] clone: add CLONE_PIDFD

2021-01-06 Thread Wen Yang
From: Christian Brauner [ Upstream commit b3e5838252665ee4cfa76b82bdf1198dca81e5be ] This patchset makes it possible to retrieve pid file descriptors at process creation time by introducing the new flag CLONE_PIDFD to the clone() system call. Linus originally suggested to implement this as a

[PATCH v2 4.9 07/10] proc: Generalize proc_sys_prune_dcache into proc_prune_siblings_dcache

2021-01-06 Thread Wen Yang
From: "Eric W. Biederman" [ Upstream commit 26dbc60f385ff9cff475ea2a3bad02e80fd6fa43 ] This prepares the way for allowing the pid part of proc to use this dcache pruning code as well. Signed-off-by: Eric W. Biederman Cc: # 4.9.x (proc: fix up cherry-pick conflicts for 26dbc60f385f)

[PATCH v2 4.9 06/10] proc: Rename in proc_inode rename sysctl_inodes sibling_inodes

2021-01-06 Thread Wen Yang
From: "Eric W. Biederman" [ Upstream commit 0afa5ca82212247456f9de1468b595a111fee633 ] I about to need and use the same functionality for pid based inodes and there is no point in adding a second field when this field is already here and serving the same purporse. Just give the field a generic

[PATCH v2 4.9 09/10] proc: Use d_invalidate in proc_prune_siblings_dcache

2021-01-06 Thread Wen Yang
From: "Eric W. Biederman" [ Upstream commit f90f3cafe8d56d593fc509a4185da1d5800efea4 ] The function d_prune_aliases has the problem that it will only prune aliases thare are completely unused. It will not remove aliases for the dcache or even think of removing mounts from the dcache. For that

[PATCH v2 4.9 03/10] proc: Pass file mode to proc_pid_make_inode

2021-01-06 Thread Wen Yang
From: Andreas Gruenbacher [ Upstream commit db978da8fa1d0819b210c137d31a339149b88875 ] Pass the file mode of the proc inode to be created to proc_pid_make_inode. In proc_pid_make_inode, initialize inode->i_mode before calling security_task_to_inode. This allows selinux to set isec->sclass

[PATCH v2 4.9 02/10] pidfd: add polling support

2021-01-06 Thread Wen Yang
From: "Joel Fernandes (Google)" [ Upstream commit b53b0b9d9a613c418057f6cb921c2f40a6f78c24 ] This patch adds polling support to pidfd. Android low memory killer (LMK) needs to know when a process dies once it is sent the kill signal. It does so by checking for the existence of /proc/pid which

[PATCH v2 4.9 00/10] fix a race in release_task when flushing the dentry

2021-01-06 Thread Wen Yang
The dentries such as /proc//ns/ have the DCACHE_OP_DELETE flag, they should be deleted when the process exits. Suppose the following race appears: release_task dput -> proc_flush_task -> dentry->d_op->d_delete(dentry) -> __exit_signal

Re: [PATCH 5/5] fs: use HKDF implementation from kernel crypto API

2021-01-06 Thread Stephan Mueller
Am Mittwoch, dem 06.01.2021 um 23:19 -0800 schrieb Eric Biggers: > On Mon, Jan 04, 2021 at 10:50:49PM +0100, Stephan Müller wrote: > > As the kernel crypto API implements HKDF, replace the > > file-system-specific HKDF implementation with the generic HKDF > > implementation. > > > >

[PATCH v4 3/3] iommu/vt-d: Fix ineffective devTLB invalidation for subdevices

2021-01-06 Thread Liu Yi L
iommu_flush_dev_iotlb() is called to invalidate caches on device. It only loops the devices which are full-attached to the domain. For sub-devices, this is ineffective. This results in invalid caching entries left on the device. Fix it by adding loop for subdevices as well. Also, the domain->

[PATCH v4 2/3] iommu/vt-d: Track device aux-attach with subdevice_domain_info

2021-01-06 Thread Liu Yi L
In the existing code, loop all devices attached to a domain does not include sub-devices attached via iommu_aux_attach_device(). This was found by when I'm working on the below patch, There is no device in the domain->devices list, thus unable to get the cap and ecap of iommu unit. But this

[PATCH v4 1/3] iommu/vt-d: Move intel_iommu info from struct intel_svm to struct intel_svm_dev

2021-01-06 Thread Liu Yi L
Current struct intel_svm has a field to record the struct intel_iommu pointer for a PASID bind. And struct intel_svm will be shared by all the devices bind to the same process. The devices may be behind different DMAR units. As the iommu driver code uses the intel_iommu pointer stored in intel_svm

[PATCH v4 0/3] iommu/vt-d: Misc fixes on scalable mode

2021-01-06 Thread Liu Yi L
Hi Baolu, Joerg, Will, This patchset aims to fix a bug regards to native SVM usage, and also two bugs around subdevice (attached to device via auxiliary manner) tracking and ineffective device_tlb flush. v3 -> v4: - Address comments from Baolu Lu and add acked-by - Fix issue reported by "Dan

Re: [RFC PATCH kernel] block: initialize block_device::bd_bdi for bdev_cache

2021-01-06 Thread Christoph Hellwig
On Thu, Jan 07, 2021 at 10:58:39AM +1100, Alexey Kardashevskiy wrote: >> And AFAICT the root inode on >> bdev superblock can get only to bdev_evict_inode() and bdev_free_inode(). >> Looking at bdev_evict_inode() the only thing that's used there from struct >> block_device is really bd_bdi.

[PATCH v4 2/2] scsi: ufs: handle LINERESET with correct tm_cmd

2021-01-06 Thread Jaegeuk Kim
From: Jaegeuk Kim This fixes a warning caused by wrong reserve tag usage in __ufshcd_issue_tm_cmd. WARNING: CPU: 7 PID: 7 at block/blk-core.c:630 blk_get_request+0x68/0x70 WARNING: CPU: 4 PID: 157 at block/blk-mq-tag.c:82 blk_mq_get_tag+0x438/0x46c And, in ufshcd_err_handler(), we can avoid to

[PATCH v4 1/2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

2021-01-06 Thread Jaegeuk Kim
When gate_work/ungate_work gets an error during hibern8_enter or exit, ufshcd_err_handler() ufshcd_scsi_block_requests() ufshcd_reset_and_restore() ufshcd_clear_ua_wluns() -> stuck ufshcd_scsi_unblock_requests() In order to avoid it, ufshcd_clear_ua_wluns() can be called per

[PATCH v4 0/2] UFS bug fixes

2021-01-06 Thread Jaegeuk Kim
Change log from v3: - move ufshcd_clear_ua_wluns() after ufshcd_scsi_add_wlus() - remove BLK_MQ_REQ_RESERVED for tm tag - move IO wait to cover all the non-fatal errors

Re: [PATCH v3 1/2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

2021-01-06 Thread Jaegeuk Kim
On 01/07, Can Guo wrote: > On 2021-01-07 14:57, Jaegeuk Kim wrote: > > On 01/07, Can Guo wrote: > > > On 2021-01-07 05:41, Jaegeuk Kim wrote: > > > > When gate_work/ungate_work gets an error during hibern8_enter or exit, > > > > ufshcd_err_handler() > > > >ufshcd_scsi_block_requests() > > > >

[PATCH v2 4.9 00/10] fix a race in release_task when flushing the dentry

2021-01-06 Thread Wen Yang
The dentries such as /proc//ns/ have the DCACHE_OP_DELETE flag, they should be deleted when the process exits. Suppose the following race appears: release_task dput -> proc_flush_task -> dentry->d_op->d_delete(dentry) -> __exit_signal

Re: [PATCH V4] scsi: ufs-debugfs: Add error counters

2021-01-06 Thread Can Guo
On 2021-01-07 15:25, Adrian Hunter wrote: People testing have a need to know how many errors might be occurring over time. Add error counters and expose them via debugfs. A module initcall is used to create a debugfs root directory for ufshcd-related items. In the case that modules are

Re: [PATCH 3/5] crypto: add RFC5869 HKDF

2021-01-06 Thread Eric Biggers
On Mon, Jan 04, 2021 at 10:49:13PM +0100, Stephan Müller wrote: > RFC5869 specifies an extract and expand two-step key derivation > function. The HKDF implementation is provided as a service function that > operates on a caller-provided HMAC cipher handle. HMAC isn't a "cipher". > The extract

Re: kerneldoc warnings since commit 538fc2ee870a3 ("rcu: Introduce kfree_rcu() single-argument macro")

2021-01-06 Thread Lukas Bulwahn
On Tue, Jan 5, 2021 at 5:29 PM Uladzislau Rezki wrote: > > On Tue, Jan 05, 2021 at 06:56:59AM -0800, Paul E. McKenney wrote: > > On Tue, Jan 05, 2021 at 02:14:41PM +0100, Uladzislau Rezki wrote: > > > Dear, Lukas. > > > > > > > Dear Uladzislau, > > > > > > > > in commit 538fc2ee870a3 ("rcu:

Re: [RFC 0/2] kbuild: Add support to build overlays (%.dtbo)

2021-01-06 Thread Viresh Kumar
On 07-01-21, 14:28, Masahiro Yamada wrote: > On Wed, Jan 6, 2021 at 12:21 AM Rob Herring wrote: > > > > On Tue, Jan 5, 2021 at 4:24 AM Viresh Kumar wrote: > > > > > > Hello, > > > > > > Here is an attempt to make some changes in the kernel to allow building > > > of device tree overlays. > > > >

[PATCH V4] scsi: ufs-debugfs: Add error counters

2021-01-06 Thread Adrian Hunter
People testing have a need to know how many errors might be occurring over time. Add error counters and expose them via debugfs. A module initcall is used to create a debugfs root directory for ufshcd-related items. In the case that modules are built-in, then initialization is done in link order,

Re: [PATCH v3 2/2] scsi: ufs: handle LINERESET with correct tm_cmd

2021-01-06 Thread Jaegeuk Kim
On 01/07, Can Guo wrote: > On 2021-01-07 14:51, Jaegeuk Kim wrote: > > On 01/07, Can Guo wrote: > > > On 2021-01-07 05:41, Jaegeuk Kim wrote: > > > > From: Jaegeuk Kim > > > > > > > > This fixes a warning caused by wrong reserve tag usage in > > > > __ufshcd_issue_tm_cmd. > > > > > > > > WARNING:

Re: [PATCH v3 2/2] scsi: ufs: handle LINERESET with correct tm_cmd

2021-01-06 Thread Can Guo
On 2021-01-07 15:03, Can Guo wrote: On 2021-01-07 14:51, Jaegeuk Kim wrote: On 01/07, Can Guo wrote: On 2021-01-07 05:41, Jaegeuk Kim wrote: > From: Jaegeuk Kim > > This fixes a warning caused by wrong reserve tag usage in > __ufshcd_issue_tm_cmd. > > WARNING: CPU: 7 PID: 7 at

Re: [PATCH] net: dsa: fix led_classdev build errors

2021-01-06 Thread Kurt Kanzenbach
On Tue Jan 05 2021, Randy Dunlap wrote: > Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y. > This limits the latter to =m when LEDS_CLASS=m. > > microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function > `hellcreek_ptp_setup': > (.text+0xf80): undefined

Re: [PATCH 5/5] fs: use HKDF implementation from kernel crypto API

2021-01-06 Thread Eric Biggers
On Mon, Jan 04, 2021 at 10:50:49PM +0100, Stephan Müller wrote: > As the kernel crypto API implements HKDF, replace the > file-system-specific HKDF implementation with the generic HKDF > implementation. > > Signed-off-by: Stephan Mueller > --- > fs/crypto/Kconfig | 2 +- >

[PATCH v1] vdpa/mlx5: Fix memory key MTT population

2021-01-06 Thread Eli Cohen
map_direct_mr() assumed that the number of scatter/gather entries returned by dma_map_sg_attrs() was equal to the number of segments in the sgl list. This led to wrong population of the mkey object. Fix this by properly referring to the returned value. The hardware expects each MTT entry to

Re: [RFC PATCH v2 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-06 Thread Leon Romanovsky
On Thu, Jan 07, 2021 at 06:55:16AM +, Tian, Kevin wrote: > > From: Leon Romanovsky > > Sent: Thursday, January 7, 2021 2:09 PM > > > > On Thu, Jan 07, 2021 at 02:04:29AM +, Tian, Kevin wrote: > > > > From: Leon Romanovsky > > > > Sent: Thursday, January 7, 2021 12:02 AM > > > > > > > >

Re: [PATCH 0/5] Add KDF implementations to crypto API

2021-01-06 Thread Eric Biggers
On Wed, Jan 06, 2021 at 10:59:24PM -0800, Eric Biggers wrote: > On Thu, Jan 07, 2021 at 07:37:05AM +0100, Stephan Mueller wrote: > > Am Montag, dem 04.01.2021 um 14:20 -0800 schrieb Eric Biggers: > > > On Mon, Jan 04, 2021 at 10:45:57PM +0100, Stephan Müller wrote: > > > > The HKDF addition is

Re: [PATCH v3 1/2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

2021-01-06 Thread Can Guo
On 2021-01-07 14:57, Jaegeuk Kim wrote: On 01/07, Can Guo wrote: On 2021-01-07 05:41, Jaegeuk Kim wrote: > When gate_work/ungate_work gets an error during hibern8_enter or exit, > ufshcd_err_handler() >ufshcd_scsi_block_requests() >ufshcd_reset_and_restore() >

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Borislav Petkov
On Wed, Jan 06, 2021 at 11:13:53AM -0800, Paul E. McKenney wrote: > Not yet, it isn't! Well, except in -rcu. ;-) Of course it is - saying "This commit" in this commit's commit message is very much a tautology. :-) > You are suggesting dropping mce_missing_cpus and just doing this? > > if

Re: [PATCH v3 2/2] scsi: ufs: handle LINERESET with correct tm_cmd

2021-01-06 Thread Can Guo
On 2021-01-07 14:51, Jaegeuk Kim wrote: On 01/07, Can Guo wrote: On 2021-01-07 05:41, Jaegeuk Kim wrote: > From: Jaegeuk Kim > > This fixes a warning caused by wrong reserve tag usage in > __ufshcd_issue_tm_cmd. > > WARNING: CPU: 7 PID: 7 at block/blk-core.c:630 blk_get_request+0x68/0x70 >

RE: [RFC PATCH 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-06 Thread Tian, Kevin
> From: David Woodhouse > Sent: Thursday, December 10, 2020 4:23 PM > > On Thu, 2020-12-10 at 08:46 +0800, Lu Baolu wrote: > > +/* > > + * We want to figure out which context we are running in. But the > hardware > > + * does not introduce a reliable way (instruction, CPUID leaf, MSR, >

Re: INFO: task hung in do_truncate (2)

2021-01-06 Thread syzbot
syzbot suspects this issue was fixed by commit: commit dfefd226b0bf7c435a58d75a0ce2f9273b9825f6 Author: Alexey Dobriyan Date: Tue Dec 15 03:15:03 2020 + mm: cleanup kstrto*() usage bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=111aa0cf50 start commit: 7ae77150

Re: [PATCH 0/5] Add KDF implementations to crypto API

2021-01-06 Thread Eric Biggers
On Thu, Jan 07, 2021 at 07:37:05AM +0100, Stephan Mueller wrote: > Am Montag, dem 04.01.2021 um 14:20 -0800 schrieb Eric Biggers: > > On Mon, Jan 04, 2021 at 10:45:57PM +0100, Stephan Müller wrote: > > > The HKDF addition is used to replace the implementation in the filesystem > > > crypto

Re: [PATCH v3 1/2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

2021-01-06 Thread Jaegeuk Kim
On 01/07, Can Guo wrote: > On 2021-01-07 05:41, Jaegeuk Kim wrote: > > When gate_work/ungate_work gets an error during hibern8_enter or exit, > > ufshcd_err_handler() > >ufshcd_scsi_block_requests() > >ufshcd_reset_and_restore() > > ufshcd_clear_ua_wluns() -> stuck > >

RE: [RFC PATCH v2 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-06 Thread Tian, Kevin
> From: Leon Romanovsky > Sent: Thursday, January 7, 2021 2:09 PM > > On Thu, Jan 07, 2021 at 02:04:29AM +, Tian, Kevin wrote: > > > From: Leon Romanovsky > > > Sent: Thursday, January 7, 2021 12:02 AM > > > > > > On Wed, Jan 06, 2021 at 11:23:39AM -0400, Jason Gunthorpe wrote: > > > > On

Re: [PATCH v3 2/2] scsi: ufs: handle LINERESET with correct tm_cmd

2021-01-06 Thread Jaegeuk Kim
On 01/07, Can Guo wrote: > On 2021-01-07 05:41, Jaegeuk Kim wrote: > > From: Jaegeuk Kim > > > > This fixes a warning caused by wrong reserve tag usage in > > __ufshcd_issue_tm_cmd. > > > > WARNING: CPU: 7 PID: 7 at block/blk-core.c:630 blk_get_request+0x68/0x70 > > WARNING: CPU: 4 PID: 157 at

Re: [PATCH v3 2/2] scsi: ufs: handle LINERESET with correct tm_cmd

2021-01-06 Thread Jaegeuk Kim
On 01/07, Can Guo wrote: > Hi Jaegeuk, > > On 2021-01-07 05:41, Jaegeuk Kim wrote: > > From: Jaegeuk Kim > > > > This fixes a warning caused by wrong reserve tag usage in > > __ufshcd_issue_tm_cmd. > > > > WARNING: CPU: 7 PID: 7 at block/blk-core.c:630 blk_get_request+0x68/0x70 > > WARNING:

Re: [PATCH] drm/panel: feiyang-fy07024di26a30d: cleanup if panel attaching failed

2021-01-06 Thread Jagan Teki
On Thu, Jan 7, 2021 at 10:16 AM Icenowy Zheng wrote: > > > > 于 2021年1月6日 GMT+08:00 下午5:47:20, Jagan Teki 写到: > >On Sat, Nov 28, 2020 at 6:23 PM Icenowy Zheng wrote: > >> > >> Attaching the panel can fail, so cleanup work is necessary, otherwise > >> a pointer to freed struct drm_panel* will

Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register

2021-01-06 Thread Shawn Guo
On Thu, Jan 7, 2021 at 2:40 PM Shawn Guo wrote: > > On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote: > > The offset of the reset request register is 0, the absolute address is > > 0x1e6. Boards without PSCI support will fail to perform a reset: > > > > [ 26.734700] reboot:

Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register

2021-01-06 Thread Shawn Guo
On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote: > The offset of the reset request register is 0, the absolute address is > 0x1e6. Boards without PSCI support will fail to perform a reset: > > [ 26.734700] reboot: Restarting system > [ 27.743259] Unable to restart system > [

Re: [PATCH 0/5] Add KDF implementations to crypto API

2021-01-06 Thread Stephan Mueller
Am Montag, dem 04.01.2021 um 14:20 -0800 schrieb Eric Biggers: > On Mon, Jan 04, 2021 at 10:45:57PM +0100, Stephan Müller wrote: > > The HKDF addition is used to replace the implementation in the filesystem > > crypto extension. This code was tested by using an EXT4 encrypted file > > system that

Re: [PATCH v3 2/2] scsi: ufs: handle LINERESET with correct tm_cmd

2021-01-06 Thread Can Guo
On 2021-01-07 05:41, Jaegeuk Kim wrote: From: Jaegeuk Kim This fixes a warning caused by wrong reserve tag usage in __ufshcd_issue_tm_cmd. WARNING: CPU: 7 PID: 7 at block/blk-core.c:630 blk_get_request+0x68/0x70 WARNING: CPU: 4 PID: 157 at block/blk-mq-tag.c:82 blk_mq_get_tag+0x438/0x46c

Re: [PATCH] rtw88: 8821c: Add RFE 2 support

2021-01-06 Thread Kai-Heng Feng
On Wed, Aug 5, 2020 at 7:24 PM Kai-Heng Feng wrote: > > Hi Tony, > > > On Aug 5, 2020, at 19:18, Tony Chuang wrote: > > > >> 8821CE with RFE 2 isn't supported: > >> [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported > >> [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip

Re: [PATCH v1 1/3] x86/cpufeatures: Add low performance CRC32C instruction CPU feature

2021-01-06 Thread Borislav Petkov
On Thu, Jan 07, 2021 at 02:19:06PM +0800, Tony W Wang-oc wrote: > SSE4.2 on Zhaoxin CPUs are compatible with Intel. The presence of > CRC32C instruction is enumerated by CPUID.01H:ECX.SSE4_2[bit 20] = 1. > Some Zhaoxin CPUs declare support SSE4.2 instruction sets but their > CRC32C instruction are

[PATCH 2/2] watchdog: BD70528: conditionally allow BD70528 module

2021-01-06 Thread Matti Vaittinen
The BD70528 watchdog module provides start/stop interface for RTC driver because the BD70528 watchdog must be stopped when RTC time is set. (WDG uses RTC counter and setting RTC may accidentally trigger WDG if WDG is enabled). The BD71828 use same RTC driver as BD70528 but don't share same WDG

Re: [PATCH] iommu/io-pgtable-arm: Allow non-coherent masters to use system cache

2021-01-06 Thread Sai Prakash Ranjan
Hi Will, On 2021-01-06 17:26, Will Deacon wrote: On Thu, Dec 24, 2020 at 12:10:07PM +0530, Sai Prakash Ranjan wrote: commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went the memory type setting required for

[PATCH 1/2] watchdog: bd70528: don't crash if WDG is confiured with BD71828

2021-01-06 Thread Matti Vaittinen
If config for BD70528 watchdog is enabled when BD71828 or BD71815 are used the RTC module will issue call to BD70528 watchdog with NULL data. Ignore this call and don't crash. Signed-off-by: Matti Vaittinen --- drivers/watchdog/bd70528_wdt.c | 15 +++ 1 file changed, 15

Re: [PATCH] crypto: x86/crc32c-intel - Don't match some Zhaoxin CPUs

2021-01-06 Thread Tony W Wang-oc
On 03/01/2021 05:12, Herbert Xu wrote: > On Tue, Dec 15, 2020 at 06:28:11PM +0800, Tony W Wang-oc wrote: >> The driver crc32c-intel match CPUs supporting X86_FEATURE_XMM4_2. >> On platforms with Zhaoxin CPUs supporting this X86 feature, when >> crc32c-intel and crc32c-generic are both registered,

[PATCH V3 2/2] scripts: dtc: Build fdtoverlay and fdtdump tools

2021-01-06 Thread Viresh Kumar
We will start building overlays for platforms soon in the kernel and would need these tools going forward. Lets start building them. The fdtoverlay program applies (or merges) one ore more overlay dtb blobs to a base dtb blob. The kernel build system would later use fdtoverlay to generate the

Re: [PATCH] gpio: bd7xxxx: use helper variable for pdev->dev

2021-01-06 Thread Vaittinen, Matti
Thanks for making this better :) On Wed, 2021-01-06 at 11:11 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Using a helper local variable to store the address of >dev adds > to readability and allows us to avoid unnecessary line breaks. > > Signed-off-by: Bartosz Golaszewski

RE: [PATCH] exfat: improve performance of exfat_free_cluster when using dirsync mount option

2021-01-06 Thread Sungjong Seo
> There are stressful update of cluster allocation bitmap when using dirsync > mount option which is doing sync buffer on every cluster bit clearing. > This could result in performance degradation when deleting big size file. > Fix to update only when the bitmap buffer index is changed would make

Re: [PATCH] crypto: x86/crc32c-intel - Don't match some Zhaoxin CPUs

2021-01-06 Thread Tony W Wang-oc
On 22/12/2020 12:54, h...@zytor.com wrote: > On December 21, 2020 7:01:39 PM PST, tonywwang...@zhaoxin.com wrote: >> On December 22, 2020 3:27:33 AM GMT+08:00, h...@zytor.com wrote: >>> On December 20, 2020 6:46:25 PM PST, tonywwang...@zhaoxin.com wrote: On December 16, 2020 1:56:45 AM

[PATCH] kasan: remove redundant config option

2021-01-06 Thread Walter Wu
CONFIG_KASAN_STACK and CONFIG_KASAN_STACK_ENABLE both enable KASAN stack instrumentation, but we should only need one config option, so that we remove CONFIG_KASAN_STACK_ENABLE. see [1]. For gcc we could do no prompt and default value y, and for clang prompt and default value n. [1]:

[PATCH v1 0/3] crypto: x86/crc32c-intel - Exclude some Zhaoxin CPUs

2021-01-06 Thread Tony W Wang-oc
The driver crc32c-intel match CPUs supporting X86_FEATURE_XMM4_2. On platforms with Zhaoxin CPUs supporting this X86 feature, when crc32c-intel and crc32c-generic are both registered, system will use crc32c-intel because its .cra_priority is greater than crc32c-generic. When doing lmbench3 Create

[PATCH v1 3/3] crypto: x86/crc32c-intel Exclude low performance CRC32C instruction CPUs

2021-01-06 Thread Tony W Wang-oc
Low performance CRC32C instruction CPUs expect to use the driver crc32c-generic. So remove these CPUs support from crc32c-intel. Signed-off-by: Tony W Wang-oc --- arch/x86/crypto/crc32c-intel_glue.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/crypto/crc32c-intel_glue.c

[PATCH v1 2/3] x86/cpu: Set low performance CRC32C flag on some Zhaoxin CPUs

2021-01-06 Thread Tony W Wang-oc
Some Zhaoxin CPUs declare support SSE4.2 instruction sets but having a CRC32C instruction implementation that not working as intended. Set low performance CRC32C flag on these CPUs for later use. Signed-off-by: Tony W Wang-oc --- arch/x86/kernel/cpu/centaur.c | 7 +++

[PATCH v1 1/3] x86/cpufeatures: Add low performance CRC32C instruction CPU feature

2021-01-06 Thread Tony W Wang-oc
SSE4.2 on Zhaoxin CPUs are compatible with Intel. The presence of CRC32C instruction is enumerated by CPUID.01H:ECX.SSE4_2[bit 20] = 1. Some Zhaoxin CPUs declare support SSE4.2 instruction sets but their CRC32C instruction are working with low performance. Add a synthetic CPU flag to indicates

Re: [PATCH] proc_sysclt: fix oops caused by incorrect command parameters.

2021-01-06 Thread Xiaoming Ni
On 2021/1/7 7:46, Kees Cook wrote: subject typo: "sysclt" -> "sysctl" On Thu, Dec 24, 2020 at 03:42:56PM +0800, Xiaoming Ni wrote: The process_sysctl_arg() does not check whether val is empty before invoking strlen(val). If the command line parameter () is incorrectly configured and val is

[RESEND PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-06 Thread Xu Yilun
This driver supports the ethernet retimers (C827) for the Intel PAC (Programmable Acceleration Card) N3000, which is a FPGA based Smart NIC. C827 is an Intel(R) Ethernet serdes transceiver chip that supports up to 100G transfer. On Intel PAC N3000 there are 2 C827 chips managed by the Intel MAX

[RESEND PATCH 0/2] Add retimer interfaces support for Intel MAX 10 BMC

2021-01-06 Thread Xu Yilun
I resend this patchset to loop in networking developers for comments. This is the previous thread. I'll fix other comments when I have a v2. https://lore.kernel.org/lkml/x%2fv9hvxyluot9...@kroah.com/ The patchset is for the retimers connected to Intel MAX 10 BMC on Intel PAC (Programmable

[RESEND PATCH 1/2] mfd: intel-m10-bmc: specify the retimer sub devices

2021-01-06 Thread Xu Yilun
The patch specifies the 2 retimer sub devices and their resources in the parent driver's mfd_cell. It also adds the register definition of the retimer sub devices. There are 2 ethernet retimer chips (C827) connected to the Intel MAX 10 BMC. They are managed by the BMC firmware, and host could

Re: [PATCH v3 1/2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

2021-01-06 Thread Can Guo
On 2021-01-07 05:41, Jaegeuk Kim wrote: When gate_work/ungate_work gets an error during hibern8_enter or exit, ufshcd_err_handler() ufshcd_scsi_block_requests() ufshcd_reset_and_restore() ufshcd_clear_ua_wluns() -> stuck ufshcd_scsi_unblock_requests() In order to avoid it,

Re: [RFC PATCH v2 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-06 Thread Leon Romanovsky
On Thu, Jan 07, 2021 at 02:04:29AM +, Tian, Kevin wrote: > > From: Leon Romanovsky > > Sent: Thursday, January 7, 2021 12:02 AM > > > > On Wed, Jan 06, 2021 at 11:23:39AM -0400, Jason Gunthorpe wrote: > > > On Wed, Jan 06, 2021 at 12:40:17PM +0200, Leon Romanovsky wrote: > > > > > > > I asked

Re: [PATCH v3] scsi: ufs: Replace sprintf and snprintf with sysfs_emit

2021-01-06 Thread Can Guo
On 2021-01-07 05:15, Bean Huo wrote: From: Bean Huo sprintf and snprintf may cause output defect in sysfs content, it is better to use new added sysfs_emit function which knows the size of the temporary buffer. Reviewed-by: Can Guo Reviewed-by: Avri Altman Suggested-by: Greg

Re: [PATCH v3 2/2] scsi: ufs: handle LINERESET with correct tm_cmd

2021-01-06 Thread Can Guo
Hi Jaegeuk, On 2021-01-07 05:41, Jaegeuk Kim wrote: From: Jaegeuk Kim This fixes a warning caused by wrong reserve tag usage in __ufshcd_issue_tm_cmd. WARNING: CPU: 7 PID: 7 at block/blk-core.c:630 blk_get_request+0x68/0x70 WARNING: CPU: 4 PID: 157 at block/blk-mq-tag.c:82

Re: [PATCH] vdpa/mlx5: Fix memory key MTT population

2021-01-06 Thread Eli Cohen
On Thu, Jan 07, 2021 at 12:15:53PM +0800, Jason Wang wrote: > > On 2021/1/6 下午5:05, Eli Cohen wrote: > > map_direct_mr() assumed that the number of scatter/gather entries > > returned by dma_map_sg_attrs() was equal to the number of segments in > > the sgl list. This led to wrong population of

[PATCH] dt-bindings: mmc: sdhci-am654: Add compatible string for AM64 SoC

2021-01-06 Thread Aswath Govindraju
Add compatible string for AM64 SoC in device tree binding of AM654 SDHCI module as the same IP is used. Signed-off-by: Aswath Govindraju --- Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH V2 2/2] scripts: dtc: Build fdtoverlay and fdtdump tools

2021-01-06 Thread Masahiro Yamada
On Thu, Jan 7, 2021 at 2:16 PM Viresh Kumar wrote: > > We will start building overlays for platforms soon in the kernel and > would need these tools going forward. Lets start building them. The commit log should explain how fdtdump and fdtoverlay are used while building the kernel tree.

[PATCH] alarmtimer: Do not mess with an enqueued hrtimer

2021-01-06 Thread Li RongQing
when an hrtimer is enqueued already, its expires should be not changed, otherwise, this will corrupts the ordering of the timerqueue RB tree, if other hrtimer is enqueued before this hrtimer is restarted, whole RB tree is completely hosed Fixes: 6cffe00f7d4e ("alarmtimer: Add functions for

Re: [External] Re: [PATCH v2 3/6] mm: hugetlb: fix a race between freeing and dissolving the page

2021-01-06 Thread Muchun Song
On Thu, Jan 7, 2021 at 12:56 AM Michal Hocko wrote: > > On Wed 06-01-21 16:47:36, Muchun Song wrote: > > There is a race condition between __free_huge_page() > > and dissolve_free_huge_page(). > > > > CPU0: CPU1: > > > > // page_count(page) == 1 > > put_page(page) > >

Re: [RFC 0/2] kbuild: Add support to build overlays (%.dtbo)

2021-01-06 Thread Masahiro Yamada
On Wed, Jan 6, 2021 at 12:21 AM Rob Herring wrote: > > On Tue, Jan 5, 2021 at 4:24 AM Viresh Kumar wrote: > > > > Hello, > > > > Here is an attempt to make some changes in the kernel to allow building > > of device tree overlays. > > > > While at it, I would also like to discuss about how we

Re: [PATCH v2 1/2] arm64: dts: mt8183: config dsi node

2021-01-06 Thread Nicolas Boichat
On Thu, Jan 7, 2021 at 1:22 PM Hsin-Yi Wang wrote: > > Config dsi node for mt8183 kukui. Set panel and ports. > > Several kukui boards share the same panel property and only compatible > is different. So compatible will be set in board dts for comparison > convenience. I like this, but maybe

[PATCH v2 1/2] arm64: dts: mt8183: config dsi node

2021-01-06 Thread Hsin-Yi Wang
Config dsi node for mt8183 kukui. Set panel and ports. Several kukui boards share the same panel property and only compatible is different. So compatible will be set in board dts for comparison convenience. Signed-off-by: Hsin-Yi Wang --- Change: v2: move compatible to board dts ---

RE: [PATCH v3 3/3] iommu/vt-d: Fix ineffective devTLB invalidation for subdevices

2021-01-06 Thread Liu, Yi L
Hi Will, > From: Will Deacon > Sent: Wednesday, January 6, 2021 1:24 AM > > On Tue, Jan 05, 2021 at 05:50:22AM +, Liu, Yi L wrote: > > > > +static void __iommu_flush_dev_iotlb(struct device_domain_info > *info, > > > > + u64 addr, unsigned int mask) > > > >

[PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board.

2021-01-06 Thread Hsin-Yi Wang
Similar to krane-sku176 but using a different panel source. Signed-off-by: Hsin-Yi Wang --- Change: v2: move compatible to board dts --- .../devicetree/bindings/arm/mediatek.yaml | 1 + arch/arm64/boot/dts/mediatek/Makefile | 1 + .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23

Re: [PATCH v3 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-06 Thread Dmitry Torokhov
Hi Philip, On Mon, Jan 04, 2021 at 06:22:34PM -0800, Philip Chen wrote: > The top-row keys in a keyboard usually have dual functionalities. > E.g. A function key "F1" is also an action key "Browser back". > > Therefore, when an application receives an action key code from > a top-row key press,

[PATCH V2 2/2] scripts: dtc: Build fdtoverlay and fdtdump tools

2021-01-06 Thread Viresh Kumar
We will start building overlays for platforms soon in the kernel and would need these tools going forward. Lets start building them. Signed-off-by: Viresh Kumar --- scripts/dtc/Makefile | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/dtc/Makefile

[PATCH V2 1/2] scripts: dtc: Add fdtoverlay.c and fdtdump.c to DTC_SOURCE

2021-01-06 Thread Viresh Kumar
We will start building overlays for platforms soon in the kernel and would need these tools going forward. Lets start fetching them. Note that a copy of fdtdump.c was already copied back in the year 2012, but was never updated or built for some reason. Signed-off-by: Viresh Kumar --- V2:

Re: [PATCH v3 1/6] arm64: dts: imx8mq: Add NOC node

2021-01-06 Thread Shawn Guo
On Thu, Dec 10, 2020 at 11:09:01AM +0100, Martin Kepplinger wrote: > From: Leonard Crestez > > Add initial support for dynamic frequency scaling of the main NOC > on imx8mq. > > Make DDRC the parent of the NOC (using passive governor) so that the > main NOC is automatically scaled together with

RE: [PATCH 4/6] acpi/drivers/thermal: Remove TRIPS_NONE cooling device binding

2021-01-06 Thread Zhang, Rui
ACPI thermal driver binds the devices listed in _TZD method with THERMAL_TRIPS_NONE. Now given that 1. THERMAL_TRIPS_NONE is removed from thermal framework 2. _TZP is rarely supported. I searched ~500 acpidumps from different platforms reported by end users in kernel Bugzilla, there is only one

  1   2   3   4   5   6   7   8   9   10   >