On Thu, Sep 16, 2021 at 04:49:19PM +0800, Shiyang Ruan wrote:
>
>
> On 2021/9/16 14:16, Christoph Hellwig wrote:
> > On Wed, Sep 15, 2021 at 06:44:58PM +0800, Shiyang Ruan wrote:
> > > + rc = dax_direct_access(iomap->dax_dev, pgoff, 1, , NULL);
> > > + if (rc < 0)
> > > + goto out;
> > >
On Thu, Sep 16, 2021 at 12:12 AM Christoph Hellwig wrote:
>
> On Wed, Sep 15, 2021 at 01:27:47PM -0700, Dan Williams wrote:
> > > Yeah, Christoph suggested that we make the clearing operation explicit
> > > in a related thread a few weeks ago:
> > >
Hi Shiyang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.15-rc1 next-20210916]
[cannot apply to xfs-linux/for-next hch-configfs/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when
On 2021/9/16 14:23, Christoph Hellwig wrote:
On Wed, Sep 15, 2021 at 06:45:00PM +0800, Shiyang Ruan wrote:
+static int
+xfs_dax_write_iomap_end(
+ struct inode*inode,
+ loff_t pos,
+ loff_t length,
+ ssize_t
On 2021/9/16 14:16, Christoph Hellwig wrote:
On Wed, Sep 15, 2021 at 06:44:58PM +0800, Shiyang Ruan wrote:
+ rc = dax_direct_access(iomap->dax_dev, pgoff, 1, , NULL);
+ if (rc < 0)
+ goto out;
+ memset(kaddr + offset, 0, size);
+ if (srcmap->addr !=
On Wed, Sep 15, 2021 at 01:27:47PM -0700, Dan Williams wrote:
> > Yeah, Christoph suggested that we make the clearing operation explicit
> > in a related thread a few weeks ago:
> > https://lore.kernel.org/linux-fsdevel/yrtnlperhfmz2...@infradead.org/
>
> That seemed to be tied to a proposal to
On Wed, Sep 15, 2021 at 05:22:27PM -0700, Darrick J. Wong wrote:
> > xfs_ilock(XFS_I(inode), XFS_MMAPLOCK_SHARED);
> > ret = dax_iomap_fault(vmf, pe_size, , NULL,
> > (write_fault && !vmf->cow_page) ?
> > -
On Wed, Sep 15, 2021 at 06:45:00PM +0800, Shiyang Ruan wrote:
> +static int
> +xfs_dax_write_iomap_end(
> + struct inode*inode,
> + loff_t pos,
> + loff_t length,
> + ssize_t written,
> + unsigned
> -s64 dax_iomap_zero(loff_t pos, u64 length, struct iomap *iomap)
> +s64 dax_iomap_zero(struct iomap_iter *iter, loff_t pos, u64 length)
I think we can also mark the iter const.
Otherwise looks good:
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
On Wed, Sep 15, 2021 at 06:44:58PM +0800, Shiyang Ruan wrote:
> + rc = dax_direct_access(iomap->dax_dev, pgoff, 1, , NULL);
> + if (rc < 0)
> + goto out;
> + memset(kaddr + offset, 0, size);
> + if (srcmap->addr != IOMAP_HOLE && srcmap->addr != iomap->addr) {
Should we
11 matches
Mail list logo