Re: [PATCH] acpi/nfit: badrange report spill over to clean range

2022-07-14 Thread Dan Williams
Jane Chu wrote: > I meant to say there would be 8 calls to the nfit_handle_mce() callback, > one call for each poison with accurate address. > > Also, short ARS would find 2 poisons. > > I attached the console output, my annotation is prefixed with "<==". [29078.634817] {4}[Hardware Error]:

Re: [PATCH] acpi/nfit: badrange report spill over to clean range

2022-07-14 Thread Dan Williams
Jane Chu wrote: > On 7/13/2022 5:24 PM, Dan Williams wrote: > > Jane Chu wrote: > >> On 7/12/2022 5:48 PM, Dan Williams wrote: > >>> Jane Chu wrote: > Commit 7917f9cdb503 ("acpi/nfit: rely on mce->misc to determine poison > granularity") changed nfit_handle_mce() callback to report

Re: [PATCH] acpi/nfit: badrange report spill over to clean range

2022-07-14 Thread Jane Chu
On 7/13/2022 5:24 PM, Dan Williams wrote: > Jane Chu wrote: >> On 7/12/2022 5:48 PM, Dan Williams wrote: >>> Jane Chu wrote: Commit 7917f9cdb503 ("acpi/nfit: rely on mce->misc to determine poison granularity") changed nfit_handle_mce() callback to report badrange for each poison at

Re: [PATCH v1 1/1] nvdimm/namespace: return uuid_null only once in nd_dev_to_uuid()

2022-07-14 Thread Dan Williams
Andy Shevchenko wrote: > On Thu, Jul 14, 2022 at 11:24:05AM -0700, Dan Williams wrote: > > Andy Shevchenko wrote: > > > Refactor nd_dev_to_uuid() in order to make code shorter and cleaner > > > by joining conditions and hence returning uuid_null only once. > > > > Apologies for the delay, applied

RE: [PATCH v1 1/1] nvdimm/namespace: drop nested variable in create_namespace_pmem()

2022-07-14 Thread Dan Williams
Andy Shevchenko wrote: > Kernel build bot reported: > > namespace_devs.c:1991:10: warning: Local variable 'uuid' shadows outer > variable [shadowVariable] > > Refactor create_namespace_pmem() by dropping a nested version of > the same variable. Applied for 5.19-rc. Thanks!

Re: [PATCH v1 1/1] nvdimm/namespace: return uuid_null only once in nd_dev_to_uuid()

2022-07-14 Thread Andy Shevchenko
On Thu, Jul 14, 2022 at 11:24:05AM -0700, Dan Williams wrote: > Andy Shevchenko wrote: > > Refactor nd_dev_to_uuid() in order to make code shorter and cleaner > > by joining conditions and hence returning uuid_null only once. > > Apologies for the delay, applied for v5.20. No problem and thanks!

RE: [PATCH v1 1/1] nvdimm/namespace: drop unneeded temporary variable in size_store()

2022-07-14 Thread Dan Williams
Andy Shevchenko wrote: > Refactor size_store() in order to remove temporary variable on stack > by joining conditionals. Looks good, applied.

RE: [PATCH v1 1/1] nvdimm/namespace: return uuid_null only once in nd_dev_to_uuid()

2022-07-14 Thread Dan Williams
Andy Shevchenko wrote: > Refactor nd_dev_to_uuid() in order to make code shorter and cleaner > by joining conditions and hence returning uuid_null only once. Apologies for the delay, applied for v5.20.

RE: [RFC PATCH v6] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind

2022-07-14 Thread Dan Williams
sure all > files and processes are handled correctly. > > == > Changes since v5: > 1. Renamed MF_MEM_REMOVE to MF_MEM_PRE_REMOVE > 2. hold s_umount before sync_filesystem() > 3. move sync_filesystem() after SB_BORN check > 4. Rebased on next-20220714 > > Changes sin

Re: [RFC PATCH v6] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind

2022-07-14 Thread Darrick J. Wong
range includes metadata area. Make sure all > files and processes are handled correctly. > > == > Changes since v5: > 1. Renamed MF_MEM_REMOVE to MF_MEM_PRE_REMOVE > 2. hold s_umount before sync_filesystem() > 3. move sync_filesystem() after SB_BORN check > 4. Re

[RFC PATCH v6] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind

2022-07-14 Thread ruansy.f...@fujitsu.com
E_REMOVE 2. hold s_umount before sync_filesystem() 3. move sync_filesystem() after SB_BORN check 4. Rebased on next-20220714 Changes since v4: 1. sync_filesystem() at the beginning when MF_MEM_REMOVE 2. Rebased on next-20220706 [1]: https://lore.kernel.org/linux-mm/161604050314.1463742.1415166