Re: [PATCH 0/3] mm: use memmap_on_memory semantics for dax/kmem

2023-06-21 Thread Verma, Vishal L
On Fri, 2023-06-16 at 09:44 +0200, David Hildenbrand wrote: > On 16.06.23 00:00, Vishal Verma wrote: > > The dax/kmem driver can potentially hot-add large amounts of memory > > originating from CXL memory expanders, or NVDIMMs, or other 'device > > memories'. There is a chance there isn't enough

[PATCH v3] dax/kmem: Pass valid argument to memory_group_register_static

2023-06-21 Thread Tarun Sahu
memory_group_register_static takes maximum number of pages as the argument while dev_dax_kmem_probe passes total_len (in bytes) as the argument. IIUC, I don't see any crash/panic impact as such. As, memory_group_register_static just set the max_pages limit which is used in

Re: [PATCH][next] fsdax: remove redundant variable 'error'

2023-06-21 Thread Jan Kara
On Wed 21-06-23 14:02:56, Colin Ian King wrote: > The variable 'error' is being assigned a value that is never read, > the assignment and the variable and redundant and can be removed. > Cleans up clang scan build warning: > > fs/dax.c:1880:10: warning: Although the value stored to 'error' is >

[PATCH][next] fsdax: remove redundant variable 'error'

2023-06-21 Thread Colin Ian King
The variable 'error' is being assigned a value that is never read, the assignment and the variable and redundant and can be removed. Cleans up clang scan build warning: fs/dax.c:1880:10: warning: Although the value stored to 'error' is used in the enclosing expression, the value is never actually

[PATCH v2] dax/kmem: Pass valid argument to memory_group_register_static

2023-06-21 Thread Tarun Sahu
memory_group_register_static takes maximum number of pages as the argument while dev_dax_kmem_probe passes total_len (in bytes) as the argument. IIUC, I don't see any crash/panic impact as such. As, memory_group_register_static just set the max_pages limit which is used in

Re: [PATCH] dax/kmem: Pass valid argument to memory_group_register_static

2023-06-21 Thread Verma, Vishal L
On Wed, 2023-06-21 at 11:36 +0530, Tarun Sahu wrote: > Hi Alison, > > Alison Schofield writes: > > > On Tue, Jun 20, 2023 at 07:33:32PM +0530, Tarun Sahu wrote: > > > memory_group_register_static takes maximum number of pages as the argument > > > while dev_dax_kmem_probe passes total_len (in

Re: [PATCH] dax/kmem: Pass valid argument to memory_group_register_static

2023-06-21 Thread Tarun Sahu
Hi Alison, Alison Schofield writes: > On Tue, Jun 20, 2023 at 07:33:32PM +0530, Tarun Sahu wrote: >> memory_group_register_static takes maximum number of pages as the argument >> while dev_dax_kmem_probe passes total_len (in bytes) as the argument. > > This sounds like a fix. An explanation of