Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-12-06 Thread Michael S. Tsirkin
On Thu, Dec 07, 2023 at 07:22:12AM +0100, Tobias Huschle wrote: > 3. vhost looping endlessly, waiting for kworker to be scheduled > > I dug a little deeper on what the vhost is doing. I'm not an expert on > virtio whatsoever, so these are just educated guesses that maybe > someone can

Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-12-06 Thread Tobias Huschle
On Tue, Nov 28, 2023 at 04:55:11PM +0800, Abel Wu wrote: > On 11/27/23 9:56 PM, Tobias Huschle Wrote: > > On Wed, Nov 22, 2023 at 11:00:16AM +0100, Peter Zijlstra wrote: > > > On Tue, Nov 21, 2023 at 02:17:21PM +0100, Tobias Huschle wrote: [...] > > What are the weights of the two entities? >

Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-06 Thread Jason Wang
On Tue, Dec 5, 2023 at 7:35 PM Yunsheng Lin wrote: > > introduce vhost_net_test basing on virtio_test to test > vhost_net changing in the kernel. > > Signed-off-by: Yunsheng Lin > --- > tools/virtio/Makefile | 8 +- > tools/virtio/vhost_net_test.c | 441

Re: [PATCH net-next 4/6] vhost/net: remove vhost_net_page_frag_refill()

2023-12-06 Thread Jason Wang
On Tue, Dec 5, 2023 at 7:35 PM Yunsheng Lin wrote: > > The page frag in vhost_net_page_frag_refill() uses the > 'struct page_frag' from skb_page_frag_refill(), but it's > implementation is similar to page_frag_alloc_align() now. > > This patch removes vhost_net_page_frag_refill() by using >

Re: [PATCH net-next 5/6] net: introduce page_frag_cache_drain()

2023-12-06 Thread Jason Wang
On Tue, Dec 5, 2023 at 7:35 PM Yunsheng Lin wrote: > > When draining a page_frag_cache, most user are doing > the similar steps, so introduce an API to avoid code > duplication. > > Signed-off-by: Yunsheng Lin > --- For vhost part: Acked-by: Jason Wang Thanks

Re: [PATCH] ipvs: add a stateless type of service and a stateless Maglev hashing scheduler

2023-12-06 Thread Dan Carpenter
Hi Lev, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Lev-Pantiukhin/ipvs-add-a-stateless-type-of-service-and-a-stateless-Maglev-hashing-scheduler/20231204-232344

[PATCH v2 1/2] Documentatiion/ABI: Add ABI documentation for sys-bus-dax

2023-12-06 Thread Vishal Verma
Add the missing sysfs ABI documentation for the device DAX subsystem. Various ABI attributes under this have been present since v5.1, and more have been added over time. In preparation for adding a new attribute, add this file with the historical details. Cc: Dan Williams Signed-off-by: Vishal

[PATCH v2 2/2] dax: add a sysfs knob to control memmap_on_memory behavior

2023-12-06 Thread Vishal Verma
Add a sysfs knob for dax devices to control the memmap_on_memory setting if the dax device were to be hotplugged as system memory. The default memmap_on_memory setting for dax devices originating via pmem or hmem is set to 'false' - i.e. no memmap_on_memory semantics, to preserve legacy behavior.

[PATCH v2 0/2] Add DAX ABI for memmap_on_memory

2023-12-06 Thread Vishal Verma
correctly in v1 - Link to v1: https://lore.kernel.org/r/20231206-vv-dax_abi-v1-0-474eb88e2...@intel.com --- Vishal Verma (2): Documentatiion/ABI: Add ABI documentation for sys-bus-dax dax: add a sysfs knob to control memmap_on_memory behavior drivers/dax/bus.c | 40

[PATCH v8] bus: mhi: host: Add tracing support

2023-12-06 Thread Krishna chaitanya chundru
o v7: https://lore.kernel.org/r/20231206-ftrace_support-v7-1-aca49a042...@quicinc.com Changes in v7: - change log format as pointed by mani. - Link to v6: https://lore.kernel.org/r/20231204-ftrace_support-v6-1-9b206546d...@quicinc.com Changes in v6: - use 'rp' directly as suggested by jeffrey. -

Re: [PATCH v7] bus: mhi: host: Add tracing support

2023-12-06 Thread Krishna Chaitanya Chundru
On 12/6/2023 9:25 PM, Steven Rostedt wrote: On Wed, 6 Dec 2023 21:12:57 +0530 Krishna chaitanya chundru wrote: diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c index f78aefd2d7a3..6acb85f4c5f8 100644 --- a/drivers/bus/mhi/host/init.c +++ b/drivers/bus/mhi/host/init.c

[PATCH] nvdimm-btt: fix a potential memleak in btt_freelist_init

2023-12-06 Thread Dinghao Liu
When an error happens in btt_freelist_init(), its caller discover_arenas() will directly free arena, which makes arena->freelist allocated in btt_freelist_init() a leaked memory. Fix this by freeing arena->freelist in all error handling paths of btt_freelist_init(). Fixes: 5212e11fde4d ("nd_btt:

Re: [PATCH net-next 2/6] page_frag: unify gfp bit for order 3 page allocation

2023-12-06 Thread Jakub Kicinski
On Tue, 5 Dec 2023 19:34:40 +0800 Yunsheng Lin wrote: > __GFP_DIRECT_RECLAIM is xor'd to avoid > direct reclaim in skb_page_frag_refill(), but it is not > xor'd in __page_frag_cache_refill(). xor is not the same thing as masking a bit off. The patch itself LGTM.

Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-06 Thread Xuan Zhuo
On Tue, 5 Dec 2023 20:39:28 +0100, Eric Dumazet wrote: > On Tue, Dec 5, 2023 at 3:11 AM Xuan Zhuo wrote: > > > > On Mon, 4 Dec 2023 13:28:21 +0100, Eric Dumazet wrote: > > > On Mon, Dec 4, 2023 at 12:43 PM Philo Lu wrote: > > > > > > > > Add 3 tracepoints, namely

Re: [PATCH net-next v7 3/4] virtio/vsock: fix logic which reduces credit update messages

2023-12-06 Thread Arseniy Krasnov
On 07.12.2023 01:08, Michael S. Tsirkin wrote: > On Thu, Dec 07, 2023 at 12:52:51AM +0300, Arseniy Krasnov wrote: >> >> >> On 07.12.2023 00:53, Michael S. Tsirkin wrote: >>> On Thu, Dec 07, 2023 at 12:18:48AM +0300, Arseniy Krasnov wrote: Add one more condition for sending credit update

Re: [PATCH net-next v7 3/4] virtio/vsock: fix logic which reduces credit update messages

2023-12-06 Thread Michael S. Tsirkin
On Thu, Dec 07, 2023 at 12:52:51AM +0300, Arseniy Krasnov wrote: > > > On 07.12.2023 00:53, Michael S. Tsirkin wrote: > > On Thu, Dec 07, 2023 at 12:18:48AM +0300, Arseniy Krasnov wrote: > >> Add one more condition for sending credit update during dequeue from > >> stream socket: when number of

Re: [PATCH net-next v7 3/4] virtio/vsock: fix logic which reduces credit update messages

2023-12-06 Thread Arseniy Krasnov
On 07.12.2023 00:53, Michael S. Tsirkin wrote: > On Thu, Dec 07, 2023 at 12:18:48AM +0300, Arseniy Krasnov wrote: >> Add one more condition for sending credit update during dequeue from >> stream socket: when number of bytes in the rx queue is smaller than >> SO_RCVLOWAT value of the socket.

Re: [PATCH net-next v7 3/4] virtio/vsock: fix logic which reduces credit update messages

2023-12-06 Thread Michael S. Tsirkin
On Thu, Dec 07, 2023 at 12:18:48AM +0300, Arseniy Krasnov wrote: > Add one more condition for sending credit update during dequeue from > stream socket: when number of bytes in the rx queue is smaller than > SO_RCVLOWAT value of the socket. This is actual for non-default value > of SO_RCVLOWAT

[PATCH net-next v7 4/4] vsock/test: two tests to check credit update logic

2023-12-06 Thread Arseniy Krasnov
Both tests are almost same, only differs in two 'if' conditions, so implemented in a single function. Tests check, that credit update message is sent: 1) During setting SO_RCVLOWAT value of the socket. 2) When number of 'rx_bytes' become smaller than SO_RCVLOWAT value. Signed-off-by: Arseniy

[PATCH net-next v7 2/4] virtio/vsock: send credit update during setting SO_RCVLOWAT

2023-12-06 Thread Arseniy Krasnov
Send credit update message when SO_RCVLOWAT is updated and it is bigger than number of bytes in rx queue. It is needed, because 'poll()' will wait until number of bytes in rx queue will be not smaller than SO_RCVLOWAT, so kick sender to send more data. Otherwise mutual hungup for tx/rx is

[PATCH net-next v7 0/4] send credit update during setting SO_RCVLOWAT

2023-12-06 Thread Arseniy Krasnov
Hello, DESCRIPTION This patchset fixes old problem with hungup of both rx/tx sides and adds test for it. This happens due to non-default SO_RCVLOWAT value and deferred credit update in virtio/vsock. Link to previous old patchset:

[PATCH net-next v7 3/4] virtio/vsock: fix logic which reduces credit update messages

2023-12-06 Thread Arseniy Krasnov
Add one more condition for sending credit update during dequeue from stream socket: when number of bytes in the rx queue is smaller than SO_RCVLOWAT value of the socket. This is actual for non-default value of SO_RCVLOWAT (e.g. not 1) - idea is to "kick" peer to continue data transmission, because

[PATCH net-next v7 1/4] vsock: update SO_RCVLOWAT setting callback

2023-12-06 Thread Arseniy Krasnov
Do not return if transport callback for SO_RCVLOWAT is set (only in error case). In this case we don't need to set 'sk_rcvlowat' field in each transport - only in 'vsock_set_rcvlowat()'. Also, if 'sk_rcvlowat' is now set only in af_vsock.c, change callback name from 'set_rcvlowat' to

[PATCH RFC 4/4] dev_dax_iomap: Add CONFIG_DEV_DAX_IOMAP kernel build parameter

2023-12-06 Thread John Groves
From: John Groves Add CONFIG_DEV_DAXIOMAP kernel build parameter --- drivers/dax/Kconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig index a88744244149..b1ebcc77120b 100644 --- a/drivers/dax/Kconfig +++ b/drivers/dax/Kconfig @@ -78,4

[PATCH RFC 3/4] dev_dax_iomap: Add dax_operations to /dev/dax struct dax_device

2023-12-06 Thread John Groves
From: John Groves This is the primary content of this rfc. Notes about this commit: * These methods are based somewhat loosely on pmem_dax_ops from drivers/nvdimm/pmem.c * dev_dax_direct_access() is physaddr based * dev_dax_direct_access() works for mmap, but fails dax_copy_to_iter() on

[PATCH RFC 2/4] dev_dax_iomap: Temporary hacks due to linkage issues

2023-12-06 Thread John Groves
From: John Groves These are functions that should be called from outside, but I had linkage issues and did this hack instead. Will fix in the "real" patches... --- drivers/dax/bus.c | 50 +++ 1 file changed, 50 insertions(+) diff --git

[PATCH RFC 1/4] dev_dax_iomap: Add add_dax_ops() func for fs-dax to provide dax holder_ops

2023-12-06 Thread John Groves
From: John Groves This is clearly not the right way to set the holder_ops; where & how should this be done? --- drivers/dax/super.c | 16 include/linux/dax.h | 5 + 2 files changed, 21 insertions(+) diff --git a/drivers/dax/super.c b/drivers/dax/super.c index

[PATCH RFC 0/4] dev_dax_iomap: introduce iomap for /dev/dax

2023-12-06 Thread John Groves
From: John Groves This patch set is not intended to be merged; I'm hoping to get some clarification as to the correct approach (especialy from Dan). This work is related to famfs, which is a dax file system for shared fabric-attached memory (FAM). Famfs is "coming soon" as an RFC, but the

[PATCH v6 1/2] depmod: Handle installing modules under a different directory

2023-12-06 Thread Michal Suchanek
Some distributions aim at shipping all files in /usr. The path under which kernel modules are installed is hardcoded to /lib which conflicts with this goal. When kmod provides kmod.pc, use it to determine the correct module installation path. With kmod that does not provide the config

[PATCH v6 2/2] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-12-06 Thread Michal Suchanek
The default MODLIB value is composed of three variables MODLIB = $(INSTALL_MOD_PATH)$(KERNEL_MODULE_DIRECTORY)/$(KERNELRELEASE) However, the kernel.spec hadcodes the default value of $(KERNEL_MODULE_DIRECTORY), and changed value is not reflected when building the package. Pass

Re: [PATCH] init: move THIS_MODULE from to

2023-12-06 Thread Paul Gortmaker
[Re: [PATCH] init: move THIS_MODULE from to ] On 03/12/2023 (Sun 19:06) Masahiro Yamada wrote: > On Sun, Nov 26, 2023 at 4:19???PM Masahiro Yamada > wrote: > > > > Commit f50169324df4 ("module.h: split out the EXPORT_SYMBOL into > > export.h") appropriately separated EXPORT_SYMBOL into > >

Re: [PATCH net] vsock/virtio: fix "comparison of distinct pointer types lacks a cast" warning

2023-12-06 Thread Arseniy Krasnov
On 06.12.2023 19:41, Stefano Garzarella wrote: > After backporting commit 581512a6dc93 ("vsock/virtio: MSG_ZEROCOPY > flag support") in CentOS Stream 9, CI reported the following error: > > In file included from ./include/linux/kernel.h:17, > from

Re: [PATCH 0/2] kmod /usr support

2023-12-06 Thread Lucas De Marchi
On Fri, Nov 10, 2023 at 01:13:53PM +0100, Michal Suchanek wrote: Hello, This is resend of the last patch in the series that adds prefix support to kernel module location together with additional patch for validating the user supplied input to options that are interpreted as directories. Thanks

Re: [PATCH net] vsock/virtio: fix "comparison of distinct pointer types lacks a cast" warning

2023-12-06 Thread Michael S. Tsirkin
On Wed, Dec 06, 2023 at 05:41:43PM +0100, Stefano Garzarella wrote: > After backporting commit 581512a6dc93 ("vsock/virtio: MSG_ZEROCOPY > flag support") in CentOS Stream 9, CI reported the following error: > > In file included from ./include/linux/kernel.h:17, > from

Re: [PATCH v7 3/4] remoteproc: zynqmp: add pm domains support

2023-12-06 Thread Tanmay Shah
On 12/6/23 9:43 AM, Mathieu Poirier wrote: > On Fri, 1 Dec 2023 at 11:10, Tanmay Shah wrote: > > > > > > On 11/29/23 11:10 AM, Mathieu Poirier wrote: > > > On Mon, Nov 27, 2023 at 10:33:05AM -0600, Tanmay Shah wrote: > > > > > > > > On 11/23/23 12:11 PM, Mathieu Poirier wrote: > > > > > On Wed,

[PATCH net] vsock/virtio: fix "comparison of distinct pointer types lacks a cast" warning

2023-12-06 Thread Stefano Garzarella
After backporting commit 581512a6dc93 ("vsock/virtio: MSG_ZEROCOPY flag support") in CentOS Stream 9, CI reported the following error: In file included from ./include/linux/kernel.h:17, from ./include/linux/list.h:9, from ./include/linux/preempt.h:11,

Re: [PATCH v7] bus: mhi: host: Add tracing support

2023-12-06 Thread Steven Rostedt
On Wed, 6 Dec 2023 21:12:57 +0530 Krishna chaitanya chundru wrote: > diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c > index f78aefd2d7a3..6acb85f4c5f8 100644 > --- a/drivers/bus/mhi/host/init.c > +++ b/drivers/bus/mhi/host/init.c > @@ -20,6 +20,9 @@ > #include >

Re: [PATCH v7 3/4] remoteproc: zynqmp: add pm domains support

2023-12-06 Thread Mathieu Poirier
On Fri, 1 Dec 2023 at 11:10, Tanmay Shah wrote: > > > On 11/29/23 11:10 AM, Mathieu Poirier wrote: > > On Mon, Nov 27, 2023 at 10:33:05AM -0600, Tanmay Shah wrote: > > > > > > On 11/23/23 12:11 PM, Mathieu Poirier wrote: > > > > On Wed, Nov 22, 2023 at 03:00:36PM -0600, Tanmay Shah wrote: > > > >

[PATCH v7] bus: mhi: host: Add tracing support

2023-12-06 Thread Krishna chaitanya chundru
This change adds ftrace support for following functions which helps in debugging the issues when there is Channel state & MHI state change and also when we receive data and control events: 1. mhi_intvec_mhi_states 2. mhi_process_data_event_ring 3. mhi_process_ctrl_ev_ring 4. mhi_gen_tre 5.

Re: [PATCH] kmod: Add FIPS 202 SHA-3 support

2023-12-06 Thread Lucas De Marchi
On Sun, Oct 22, 2023 at 07:09:28PM +0100, Dimitri John Ledkov wrote: Add support for parsing FIPS 202 SHA-3 signature hashes. Separately, it is not clear why explicit hashes are re-encoded here, instead of trying to generically show any digest openssl supports. Signed-off-by: Dimitri John

[PATCH] ring-buffer: Force absolute timestamp on discard of event

2023-12-06 Thread Steven Rostedt
From: "Steven Rostedt (Google)" There's a race where if an event is discarded from the ring buffer and an interrupt were to happen at that time and insert an event, the time stamp is still used from the discarded event as an offset. This can screw up the timings. If the event is going to be

[PATCH] ring-buffer: Test last update in 32bit version of __rb_time_read()

2023-12-06 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Since 64 bit cmpxchg() is very expensive on 32bit architectures, the timestamp used by the ring buffer does some interesting tricks to be able to still have an atomic 64 bit number. It originally just used 60 bits and broke it up into two 32 bit words where the

Re: [PATCH] ipvs: add a stateless type of service and a stateless Maglev hashing scheduler

2023-12-06 Thread Julian Anastasov
Hello, On Mon, 4 Dec 2023, Lev Pantiukhin wrote: > +#define IP_VS_SVC_F_STATELESS0x0040 /* stateless scheduling > */ I have another idea for the traffic that does not need per-client state. We need some per-dest cp to forward the packet. If we replace the

Re: [PATCH] ipvs: add a stateless type of service and a stateless Maglev hashing scheduler

2023-12-06 Thread kernel test robot
Hi Lev, kernel test robot noticed the following build warnings: [auto build test WARNING on horms-ipvs-next/master] [also build test WARNING on horms-ipvs/master linus/master v6.7-rc4 next-20231206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH 12/27] tty: hvc: convert to u8 and size_t

2023-12-06 Thread Christophe Leroy
Le 06/12/2023 à 08:36, Jiri Slaby (SUSE) a écrit : > Switch character types to u8 and sizes to size_t. To conform to > characters/sizes in the rest of the tty layer. > > Signed-off-by: Jiri Slaby (SUSE) > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: Amit Shah >