[PATCH v5 8/8] selftests/ftrace: add fprobe test cases for VFS type "%pd" and "%pD"

2024-01-24 Thread Ye Bin
This patch adds fprobe test cases for new print format type "%pd/%pD".The test cases test the following items: 1. Test "%pd" type for dput(); 2. Test "%pD" type for vfs_read(); This test case require enable CONFIG_HAVE_FUNCTION_ARG_ACCESS_API configuration. Signed-off-by: Ye Bin ---

[PATCH v5 7/8] selftests/ftrace: add kprobe test cases for VFS type "%pd" and "%pD"

2024-01-24 Thread Ye Bin
This patch adds test cases for new print format type "%pd/%pD".The test cases test the following items: 1. Test README if add "%pd/%pD" type; 2. Test "%pd" type for dput(); 3. Test "%pD" type for vfs_read(); This test case require enable CONFIG_HAVE_FUNCTION_ARG_ACCESS_API configuration.

[PATCH v5 6/8] Documentation: tracing: add new type '%pd' and '%pD' for kprobe

2024-01-24 Thread Ye Bin
Similar to printk() '%pd' is for fetch dentry's name from struct dentry's pointer, and '%pD' is for fetch file's name from struct file's pointer. Signed-off-by: Ye Bin --- Documentation/trace/kprobetrace.rst | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH v5 5/8] tracing: add new type "%pd/%pD" in readme_msg[]

2024-01-24 Thread Ye Bin
Signed-off-by: Ye Bin --- kernel/trace/trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 2a7c6fd934e9..13197d3b86bd 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -5745,7 +5745,7 @@ static const char

[PATCH v5 4/8] tracing/probes: support '%pd/%pD' type for fprobe

2024-01-24 Thread Ye Bin
Support print type '%pd/%pD' for print dentry's or file's name. Signed-off-by: Ye Bin --- kernel/trace/trace_fprobe.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/kernel/trace/trace_fprobe.c b/kernel/trace/trace_fprobe.c index 7d2ddbcfa377..988d68e906ad 100644 ---

[PATCH v5 2/8] tracing/probes: support '%pd' type for print struct dentry's name

2024-01-24 Thread Ye Bin
Similar to '%pd' for printk, use '%pd' for print struct dentry's name. Signed-off-by: Ye Bin --- kernel/trace/trace_kprobe.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index c4c6e0e0068b..7cbb43740b4f 100644 ---

[PATCH v5 3/8] tracing/probes: support '%pD' type for print struct file's name

2024-01-24 Thread Ye Bin
Similar to '%pD' for printk, use '%pD' for print struct file's name. Signed-off-by: Ye Bin --- kernel/trace/trace_probe.c | 57 +++--- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c index

[PATCH v5 1/8] tracing/probes: add traceprobe_expand_dentry_args() helper

2024-01-24 Thread Ye Bin
Add traceprobe_expand_dentry_args() to expand dentry args. this API is prepare to support "%pd" print format for kprobe. Signed-off-by: Ye Bin --- kernel/trace/trace_probe.c | 50 ++ kernel/trace/trace_probe.h | 2 ++ 2 files changed, 52 insertions(+) diff

[PATCH v5 0/8] support '%pd' and '%pD' for print file name

2024-01-24 Thread Ye Bin
During fault locating, the file name needs to be printed based on the dentry/file address. The offset needs to be calculated each time, which is troublesome. Similar to printk, kprobe supports printing file names for dentry/file addresses. Diff v5 vs v4: 1. Use glob_match() instead of

Re: [PATCH v2 2/3] virtio_net: Add missing virtio header in skb for XDP_PASS

2024-01-24 Thread Liang Chen
On Wed, Jan 24, 2024 at 7:04 PM Heng Qi wrote: > > > > 在 2024/1/24 下午4:57, Liang Chen 写道: > > For the XDP_PASS scenario of the XDP path, the skb constructed with > > xdp_buff does not include the virtio header. Adding the virtio header > > information back when creating the skb. > > > >

Re: [PATCH v2 2/3] virtio_net: Add missing virtio header in skb for XDP_PASS

2024-01-24 Thread Liang Chen
On Wed, Jan 24, 2024 at 5:16 PM Xuan Zhuo wrote: > > On Wed, 24 Jan 2024 16:57:20 +0800, Liang Chen > wrote: > > For the XDP_PASS scenario of the XDP path, the skb constructed with > > xdp_buff does not include the virtio header. Adding the virtio header > > information back when creating the

Re: [PATCH v2 2/3] virtio_net: Add missing virtio header in skb for XDP_PASS

2024-01-24 Thread Xuan Zhuo
On Thu, 25 Jan 2024 11:48:18 +0800, Jason Wang wrote: > On Wed, Jan 24, 2024 at 5:16 PM Xuan Zhuo wrote: > > > > On Wed, 24 Jan 2024 16:57:20 +0800, Liang Chen > > wrote: > > > For the XDP_PASS scenario of the XDP path, the skb constructed with > > > xdp_buff does not include the virtio

Re: [PATCH net-next 2/2] tun: AF_XDP Rx zero-copy support

2024-01-24 Thread Jason Wang
On Wed, Jan 24, 2024 at 5:38 PM Yunjian Wang wrote: > > Now the zero-copy feature of AF_XDP socket is supported by some > drivers, which can reduce CPU utilization on the xdp program. > This patch set allows tun to support AF_XDP Rx zero-copy feature. > > This patch tries to address this by: > -

Re: [PATCH v2 2/3] virtio_net: Add missing virtio header in skb for XDP_PASS

2024-01-24 Thread Jason Wang
On Wed, Jan 24, 2024 at 5:16 PM Xuan Zhuo wrote: > > On Wed, 24 Jan 2024 16:57:20 +0800, Liang Chen > wrote: > > For the XDP_PASS scenario of the XDP path, the skb constructed with > > xdp_buff does not include the virtio header. Adding the virtio header > > information back when creating the

Re: [PATCH net-next 2/2] tun: AF_XDP Rx zero-copy support

2024-01-24 Thread Jason Wang
On Thu, Jan 25, 2024 at 3:05 AM Willem de Bruijn wrote: > > Yunjian Wang wrote: > > Now the zero-copy feature of AF_XDP socket is supported by some > > drivers, which can reduce CPU utilization on the xdp program. > > This patch set allows tun to support AF_XDP Rx zero-copy feature. > > > > This

Re: [PATCH net-next v2] vsock/test: add '--peer-port' input argument

2024-01-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 23 Jan 2024 10:27:50 +0300 you wrote: > Implement port for given CID as input argument instead of using > hardcoded value '1234'. This allows to run different test instances > on a single CID. Port argument

Re: [PATCH v9] bus: mhi: host: Add tracing support

2024-01-24 Thread Krishna Chaitanya Chundru
On 1/8/2024 6:52 PM, Krishna Chaitanya Chundru wrote: Hi Steven, Even though I added your reviewed-by tag, I incorporated changes mentioned in the previous patch. Can you please review it once. Thanks & Regards, Krishna Chaitanya. Hi Steven, Can you please review it once. Thanks &

Re: [PATCH 1/4] tracing/user_events: Prepare find/delete for same name events

2024-01-24 Thread Google
On Tue, 23 Jan 2024 22:08:41 + Beau Belgrave wrote: > The current code for finding and deleting events assumes that there will > never be cases when user_events are registered with the same name, but > different formats. In the future this scenario will exist to ensure > user programs can be

Re: [PATCH v4 7/7] selftests/ftrace: add test cases for VFS type "%pd" and "%pD"

2024-01-24 Thread Google
On Wed, 24 Jan 2024 11:21:45 +0800 "yebin (H)" wrote: > > > On 2024/1/24 9:32, Masami Hiramatsu (Google) wrote: > > On Tue, 23 Jan 2024 17:21:39 +0800 > > Ye Bin wrote: > > > >> This patch adds test cases for new print format type "%pd/%pD".The test > >> cases > >> test the following items:

Re: [PATCH 2/9] remoteproc: imx_rproc: Use devm_rproc_alloc() helper

2024-01-24 Thread Iuliana Prodan
On 1/23/2024 8:46 PM, Andrew Davis wrote: Use the device lifecycle managed allocation function. This helps prevent mistakes like freeing out of order in cleanup functions and forgetting to free on error paths. Signed-off-by: Andrew Davis Reviewed-by: Iuliana Prodan Thanks, Iulia ---

Re: [PATCH 1/9] remoteproc: imx_dsp_rproc: Use devm_rproc_alloc() helper

2024-01-24 Thread Iuliana Prodan
On 1/23/2024 8:46 PM, Andrew Davis wrote: Use the device lifecycle managed allocation function. This helps prevent mistakes like freeing out of order in cleanup functions and forgetting to free on error paths. Signed-off-by: Andrew Davis Reviewed-by: Iuliana Prodan Thanks, Iulia ---

Re: [syzbot] [virtualization?] KMSAN: uninit-value in virtqueue_add (4)

2024-01-24 Thread Stefan Hajnoczi
On Wed, Jan 24, 2024 at 11:47:32AM +0100, Alexander Potapenko wrote: > On Thu, Jan 4, 2024 at 9:45 PM Stefan Hajnoczi wrote: > > > > On Tue, Jan 02, 2024 at 08:03:46AM -0500, Michael S. Tsirkin wrote: > > > On Mon, Jan 01, 2024 at 05:38:24AM -0800, syzbot wrote: > > > > Hello, > > > > > > > >

[PATCH v7 5/5] dax: add a sysfs knob to control memmap_on_memory behavior

2024-01-24 Thread Vishal Verma
Add a sysfs knob for dax devices to control the memmap_on_memory setting if the dax device were to be hotplugged as system memory. The default memmap_on_memory setting for dax devices originating via pmem or hmem is set to 'false' - i.e. no memmap_on_memory semantics, to preserve legacy behavior.

[PATCH v7 2/5] dax/bus.c: replace several sprintf() with sysfs_emit()

2024-01-24 Thread Vishal Verma
There were several places where drivers/dax/bus.c uses 'sprintf' to print sysfs data. Since a sysfs_emit() helper is available specifically for this purpose, replace all the sprintf() usage for sysfs with sysfs_emit() in this file. Cc: Dan Williams Reported-by: Greg Kroah-Hartman Signed-off-by:

[PATCH v7 4/5] mm/memory_hotplug: export mhp_supports_memmap_on_memory()

2024-01-24 Thread Vishal Verma
In preparation for adding sysfs ABI to toggle memmap_on_memory semantics for drivers adding memory, export the mhp_supports_memmap_on_memory() helper. This allows drivers to check if memmap_on_memory support is available before trying to request it, and display an appropriate message if it isn't

[PATCH v7 3/5] Documentatiion/ABI: Add ABI documentation for sys-bus-dax

2024-01-24 Thread Vishal Verma
Add the missing sysfs ABI documentation for the device DAX subsystem. Various ABI attributes under this have been present since v5.1, and more have been added over time. In preparation for adding a new attribute, add this file with the historical details. Cc: Dan Williams Signed-off-by: Vishal

[PATCH v7 1/5] dax/bus.c: replace driver-core lock usage by a local rwsem

2024-01-24 Thread Vishal Verma
The dax driver incorrectly used driver-core device locks to protect internal dax region and dax device configuration structures. Replace the device lock usage with a local rwsem, one each for dax region configuration and dax device configuration. As a result of this conversion, no device_lock()

[PATCH v7 0/5] Add DAX ABI for memmap_on_memory

2024-01-24 Thread Vishal Verma
This series adds sysfs ABI to control memmap_on_memory behavior for DAX devices. Patch 1 replaces incorrect device_lock() usage with a local rwsem - this was identified during review. Patch 2 is also a preparatory patch that replaces sprintf() for sysfs operations with sysfs_emit() Patch 3 adds

[PATCH net-next v1] vsock/test: print type for SOCK_SEQPACKET

2024-01-24 Thread Arseniy Krasnov
SOCK_SEQPACKET is supported for virtio transport, so do not interpret such type of socket as unknown. Signed-off-by: Arseniy Krasnov --- tools/testing/vsock/vsock_diag_test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/vsock/vsock_diag_test.c

Re: [PATCH net-next 2/2] tun: AF_XDP Rx zero-copy support

2024-01-24 Thread Willem de Bruijn
Yunjian Wang wrote: > Now the zero-copy feature of AF_XDP socket is supported by some > drivers, which can reduce CPU utilization on the xdp program. > This patch set allows tun to support AF_XDP Rx zero-copy feature. > > This patch tries to address this by: > - Use peek_len to consume a

Re: Front camera on pinephone

2024-01-24 Thread Pavel Machek
Hi! > Isn't this simply the case of picking the gc2145 bits from Megis tree? > > https://megous.com/git/linux/tree/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi?h=orange-pi-5.10#n410 Well, that, adjusting dts bits to the new driver, testing and submitting the patch. And it looks

Re: general protection fault in ath9k_wmi_event_tasklet

2024-01-24 Thread Toke Høiland-Jørgensen
"Ubisectech Sirius" writes: > Hello. > We are Ubisectech Sirius Team, the vulnerability lab of China ValiantSec. > Recently, our team has discovered a issue in Linux kernel > 6.7.0-g9d1694dc91ce. Attached to the email were a POC file of the issue. > Stack dump: > general protection fault,

[PATCH] arm64: dts: qcom: sm6350: Add tsens thermal zones

2024-01-24 Thread Luca Weiss
temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + q6-hvx-thermal { + polling-delay-passive = <0>; + polling-delay = <0>; + + thermal-sensors = < 4>; + + trips { + q6-hvx-crit { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + video-thermal { + polling-delay-passive = <0>; + polling-delay = <0>; + + thermal-sensors = < 11>; + + trips { + video-crit { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + }; + timer { compatible = "arm,armv8-timer"; clock-frequency = <1920>; --- base-commit: 6fd66bc55f7ed910980b9cc4afe31e1bb066c7e0 change-id: 20240124-sm6350-tsens-c17692ffad3b Best regards, -- Luca Weiss

Re: [PATCH v12 3/6] tracing: Add snapshot refcount

2024-01-24 Thread Google
On Tue, 23 Jan 2024 11:07:54 + Vincent Donnefort wrote: [...] > @@ -6592,8 +6641,11 @@ int tracing_set_tracer(struct trace_array *tr, const > char *buf) > > if (t->init) { > ret = tracer_init(t, tr); > - if (ret) > + if (ret) { > +

Re: [PATCH] tracing: Include PPIN in mce_record tracepoint

2024-01-24 Thread Steven Rostedt
On Wed, 24 Jan 2024 10:57:08 +0100 Borislav Petkov wrote: > On Tue, Jan 23, 2024 at 08:38:53PM -0500, Steven Rostedt wrote: > > Yes, rasdaemon uses libtraceevent (or a copy of it internally) that > > reads the format file to find fields. You can safely add fields to the > > middle of the event

Re: [PATCH 3/3] arm64: dts: qcom: msm8953: add reset for display subsystem

2024-01-24 Thread Konrad Dybcio
On 1/23/24 22:03, Luca Weiss wrote: From: Vladimir Lypak With this reset we can avoid situations like IRQ storms from DSI host before it even started probing (because boot-loader left DSI IRQs on). Signed-off-by: Vladimir Lypak Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio

Re: [PATCH v4 3/7] tracing/probes: support '%pd' type for print struct dentry's name

2024-01-24 Thread Google
On Wed, 24 Jan 2024 10:46:10 +0800 "yebin (H)" wrote: > > > On 2024/1/23 22:40, Masami Hiramatsu (Google) wrote: > > On Tue, 23 Jan 2024 17:21:35 +0800 > > Ye Bin wrote: > > > >> Similar to '%pd' for printk, use '%pd' for print struct dentry's name. > >> > >> Signed-off-by: Ye Bin > >> --- >

Re: [PATCH 2/3] clk: qcom: gcc-msm8953: add MDSS_BCR reset

2024-01-24 Thread Konrad Dybcio
On 1/23/24 22:03, Luca Weiss wrote: From: Vladimir Lypak Add an entry in the gcc driver for the MDSS_BCR reset found on MSM8953. Signed-off-by: Vladimir Lypak [luca: expand commit message, move entry] Signed-off-by: Luca Weiss --- I found some more definitions in lk2nd 88:#define

Re: [PATCH v2 2/3] virtio_net: Add missing virtio header in skb for XDP_PASS

2024-01-24 Thread Heng Qi
在 2024/1/24 下午4:57, Liang Chen 写道: For the XDP_PASS scenario of the XDP path, the skb constructed with xdp_buff does not include the virtio header. Adding the virtio header information back when creating the skb. Signed-off-by: Liang Chen --- drivers/net/virtio_net.c | 6 ++ 1 file

Re: [syzbot] [virtualization?] KMSAN: uninit-value in virtqueue_add (4)

2024-01-24 Thread Alexander Potapenko
On Thu, Jan 4, 2024 at 9:45 PM Stefan Hajnoczi wrote: > > On Tue, Jan 02, 2024 at 08:03:46AM -0500, Michael S. Tsirkin wrote: > > On Mon, Jan 01, 2024 at 05:38:24AM -0800, syzbot wrote: > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit:fbafc3e621c3 Merge

Re: [PATCH] tracing: Include PPIN in mce_record tracepoint

2024-01-24 Thread Borislav Petkov
On Tue, Jan 23, 2024 at 08:38:53PM -0500, Steven Rostedt wrote: > Yes, rasdaemon uses libtraceevent (or a copy of it internally) that > reads the format file to find fields. You can safely add fields to the > middle of the event structure and the parsing will be just fine. Should we worry about

[PATCH net-next 2/2] tun: AF_XDP Rx zero-copy support

2024-01-24 Thread Yunjian Wang
Now the zero-copy feature of AF_XDP socket is supported by some drivers, which can reduce CPU utilization on the xdp program. This patch set allows tun to support AF_XDP Rx zero-copy feature. This patch tries to address this by: - Use peek_len to consume a xsk->desc and get xsk->desc length. -

[PATCH net-next 1/2] xsk: Remove non-zero 'dma_page' check in xp_assign_dev

2024-01-24 Thread Yunjian Wang
Now dma mappings are used by the physical NICs. However the vNIC maybe do not need them. So remove non-zero 'dma_page' check in xp_assign_dev. Signed-off-by: Yunjian Wang --- net/xdp/xsk_buff_pool.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/net/xdp/xsk_buff_pool.c

[PATCH net-next 0/2] tun: AF_XDP Rx zero-copy support

2024-01-24 Thread Yunjian Wang
Now, some drivers support the zero-copy feature of AF_XDP sockets, which can significantly reduce CPU utilization for XDP programs. This patch set enables tun to also support the AF_XDP Rx zero-copy feature, with the following changes: 1. The unnecessary 'dma_page' check has been removed when

Re: [PATCH v2 2/3] virtio_net: Add missing virtio header in skb for XDP_PASS

2024-01-24 Thread Xuan Zhuo
On Wed, 24 Jan 2024 16:57:20 +0800, Liang Chen wrote: > For the XDP_PASS scenario of the XDP path, the skb constructed with > xdp_buff does not include the virtio header. Adding the virtio header > information back when creating the skb. > > Signed-off-by: Liang Chen > --- >

Re: [PATCH v2 1/3] virtio_net: Preserve virtio header before XDP program execution

2024-01-24 Thread Xuan Zhuo
On Wed, 24 Jan 2024 16:57:19 +0800, Liang Chen wrote: > The xdp program may overwrite the inline virtio header. To ensure the > integrity of the virtio header, it is saved in a data structure that > wraps both the xdp_buff and the header before running the xdp program. > > Signed-off-by: Liang

[PATCH v2 3/3] virtio_net: Support RX hash XDP hint

2024-01-24 Thread Liang Chen
The RSS hash report is a feature that's part of the virtio specification. Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost (still a work in progress as per [1]) support this feature. While the capability to obtain the RSS hash has been enabled in the normal path, it's

[PATCH v2 2/3] virtio_net: Add missing virtio header in skb for XDP_PASS

2024-01-24 Thread Liang Chen
For the XDP_PASS scenario of the XDP path, the skb constructed with xdp_buff does not include the virtio header. Adding the virtio header information back when creating the skb. Signed-off-by: Liang Chen --- drivers/net/virtio_net.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH v2 1/3] virtio_net: Preserve virtio header before XDP program execution

2024-01-24 Thread Liang Chen
The xdp program may overwrite the inline virtio header. To ensure the integrity of the virtio header, it is saved in a data structure that wraps both the xdp_buff and the header before running the xdp program. Signed-off-by: Liang Chen --- drivers/net/virtio_net.c | 43

[PATCH v2 0/3] virtio_net: Support the RX hash XDP hint

2024-01-24 Thread Liang Chen
The RSS hash report is a feature that's part of the virtio specification. Currently, virtio backends like qemu and vdpa (mlx5) support it(potentially vhost). While the capability to obtain the RSS hash has been enabled in the normal path, it's currently missing in the XDP path. Changes from v1:

Re: [PATCH] percpu: improve percpu_alloc_percpu_fail event trace

2024-01-24 Thread Dennis Zhou
Hello, On Mon, Jan 22, 2024 at 08:55:39PM -0500, Steven Rostedt wrote: > On Tue, 23 Jan 2024 09:44:43 +0800 > George Guo wrote: > > > There are two reasons of percpu_alloc failed without warnings: > > > > 1. do_warn is false > > 2. do_warn is true and warn_limit is reached the limit. > > Yes

Re: [PATCH] virtio_net: Support RX hash XDP hint

2024-01-24 Thread Liang Chen
On Wed, Jan 24, 2024 at 2:06 PM Xuan Zhuo wrote: > > On Wed, 24 Jan 2024 10:04:51 +0800, Liang Chen > wrote: > > On Mon, Jan 22, 2024 at 7:10 PM Heng Qi wrote: > > > > > > Hi Liang Chen, > > > > > > 在 2024/1/22 下午6:22, Liang Chen 写道: > > > > The RSS hash report is a feature that's part of the

Re: [PATCH] virtio_net: Support RX hash XDP hint

2024-01-24 Thread Liang Chen
On Wed, Jan 24, 2024 at 10:12 AM Jason Wang wrote: > > On Mon, Jan 22, 2024 at 6:23 PM Liang Chen wrote: > > > > The RSS hash report is a feature that's part of the virtio specification. > > Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost > > (still a work in progress as