Re: [PATCH v7 19/36] function_graph: Implement fgraph_reserve_data() and fgraph_retrieve_data()

2024-02-15 Thread Google
On Wed, 14 Feb 2024 18:54:07 -0500 Steven Rostedt wrote: > On Thu, 15 Feb 2024 08:45:52 +0900 > Masami Hiramatsu (Google) wrote: > > > > Hmm, the above is a fast path. I wonder if we should add a patch to make > > > that into: > > > > > > if (unlikely(size_bytes & (sizeof(long) - 1))) > >

Re: [PATCH v9 09/15] x86/sgx: Charge mem_cgroup for per-cgroup reclamation

2024-02-15 Thread Haitao Huang
Hi Dave, On Thu, 15 Feb 2024 17:43:18 -0600, Dave Hansen wrote: On 2/5/24 13:06, Haitao Huang wrote: static struct mem_cgroup *sgx_encl_get_mem_cgroup(struct sgx_encl *encl) { @@ -1003,14 +1001,6 @@ static struct mem_cgroup *sgx_encl_get_mem_cgroup(struct sgx_encl *encl)

[PATCH v18 3/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper

2024-02-15 Thread ankita
From: Ankit Agrawal NVIDIA's upcoming Grace Hopper Superchip provides a PCI-like device for the on-chip GPU that is the logical OS representation of the internal proprietary chip-to-chip cache coherent interconnect. The device is peculiar compared to a real PCI device in that whilst there is a

[PATCH v18 2/3] vfio/pci: rename and export range_intersect_range

2024-02-15 Thread ankita
From: Ankit Agrawal range_intersect_range determines an overlap between two ranges. If an overlap, the helper function returns the overlapping offset and size. The VFIO PCI variant driver emulates the PCI config space BAR offset registers. These offset may be accessed for read/write with a

[PATCH v18 1/3] vfio/pci: rename and export do_io_rw()

2024-02-15 Thread ankita
From: Ankit Agrawal do_io_rw() is used to read/write to the device MMIO. The grace hopper VFIO PCI variant driver require this functionality to read/write to its memory. Rename this as vfio_pci_core functions and export as GPL. Reviewed-by: Kevin Tian Signed-off-by: Ankit Agrawal ---

[PATCH v18 0/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper

2024-02-15 Thread ankita
From: Ankit Agrawal NVIDIA's upcoming Grace Hopper Superchip provides a PCI-like device for the on-chip GPU that is the logical OS representation of the internal proprietary chip-to-chip cache coherent interconnect. The device is peculiar compared to a real PCI device in that whilst there is a

Re: [PATCH v9 09/15] x86/sgx: Charge mem_cgroup for per-cgroup reclamation

2024-02-15 Thread Dave Hansen
On 2/5/24 13:06, Haitao Huang wrote: > static struct mem_cgroup *sgx_encl_get_mem_cgroup(struct sgx_encl *encl) > { > @@ -1003,14 +1001,6 @@ static struct mem_cgroup > *sgx_encl_get_mem_cgroup(struct sgx_encl *encl) > struct sgx_encl_mm *encl_mm; > int idx; > > - /* > - *

Re: [PATCH RESEND] vdpa/mlx5: Allow CVQ size changes

2024-02-15 Thread Dragos Tatulea
On 02/15, Jonah Palmer wrote: > The MLX driver was not updating its control virtqueue size at set_vq_num > and instead always initialized to MLX5_CVQ_MAX_ENT (16) at > setup_cvq_vring. > > Qemu would try to set the size to 64 by default, however, because the > CVQ size always was initialized to

[PATCH v6 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART

2024-02-15 Thread Stefan Hansson
This was not enabled in the matisse-wifi tree. Without this, it is not possible to use the USB port for serial debugging via a "Carkit debug cable". Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio ---

[PATCH v6 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)

2024-02-15 Thread Stefan Hansson
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet based on the MSM8926 platform. The common dtsi is also modified to describe the widest constraints, which required modifications to the matisse-wifi dts. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski ---

[PATCH v6 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

2024-02-15 Thread Stefan Hansson
This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v6 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2024-02-15 Thread Stefan Hansson
According to the dts from the kernel source code released by Samsung, matissewifi and matisselte only have minor differences in hardware, so use a shared dtsi to reduce duplicated code. Additionally, this should make adding support for matisse3g easier should someone want to do that at a later

[PATCH v6 0/4] Add samsung-matisselte and common matisse dtsi

2024-02-15 Thread Stefan Hansson
This series adds a common samsung-matisse dtsi and reworks samsung-matisse-wifi to use it, and introduces samsung-matisselte. I choose matisselte over matisse-lte as this is how most other devices (klte, s3ve3g) do it and it is the codename that Samsung gave the device. See individual commits for

Re: [PATCH v2 2/2] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 8.0 Wi-Fi

2024-02-15 Thread Luca Weiss
On Donnerstag, 15. Februar 2024 18:19:49 CET Bryant Mairs wrote: > Add support for this tablet based on the MSM8226 SoC, codenamed > "milletwifi". > > Signed-off-by: Bryant Mairs > Acked-by: Linus Walleij afaik Acked-by should come before Signed-off-by (in other words your S-o-b should be the

Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Document samsung,milletwifi device

2024-02-15 Thread Conor Dooley
On Thu, Feb 15, 2024 at 06:19:48PM +0100, Bryant Mairs wrote: > Add binding documentation for Samsung Galaxy Tab 4 8.0 Wi-Fi > tablet which is based on Snapdragon 400 (apq8026) SoC. > > Signed-off-by: Bryant Mairs > Acked-by: Linus Walleij Acked-by: Conor Dooley Cheers, Conor. > --- >

[PATCH RESEND] vdpa/mlx5: Allow CVQ size changes

2024-02-15 Thread Jonah Palmer
The MLX driver was not updating its control virtqueue size at set_vq_num and instead always initialized to MLX5_CVQ_MAX_ENT (16) at setup_cvq_vring. Qemu would try to set the size to 64 by default, however, because the CVQ size always was initialized to 16, an error would be thrown when sending

Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

2024-02-15 Thread Ira Weiny
Jonathan Cameron wrote: > On Wed, 14 Feb 2024 17:33:18 -0500 > Steven Rostedt wrote: > > > On Wed, 14 Feb 2024 14:19:19 -0800 > > Ira Weiny wrote: > > > > > > > Jonathan Cameron wrote: > > > > > > > > > > > So I'm thinking this is a won't fix - wait for the printk rework to > > > > > >

[PATCH v2 2/2] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 8.0 Wi-Fi

2024-02-15 Thread Bryant Mairs
Add support for this tablet based on the MSM8226 SoC, codenamed "milletwifi". Signed-off-by: Bryant Mairs Acked-by: Linus Walleij --- arch/arm/boot/dts/qcom/Makefile | 1 + .../qcom/qcom-apq8026-samsung-milletwifi.dts | 568 ++ 2 files changed, 569

[PATCH v2 1/2] dt-bindings: arm: qcom: Document samsung,milletwifi device

2024-02-15 Thread Bryant Mairs
Add binding documentation for Samsung Galaxy Tab 4 8.0 Wi-Fi tablet which is based on Snapdragon 400 (apq8026) SoC. Signed-off-by: Bryant Mairs Acked-by: Linus Walleij --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 0/2] Add samsung-milletwifi

2024-02-15 Thread Bryant Mairs
This series adds support for samsung-milletwifi, the smaller cousin to samsung-matisselte. I've used the manufacturer's naming convention for consistency. Hardware currently supported: - GPS - Display - Wi-Fi - Bluetooth - Cover detection - Physical buttons - Touchscreen and touchkeys -

Re: [PATCH v10 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-02-15 Thread Tanmay Shah
On 2/15/24 3:06 AM, Krzysztof Kozlowski wrote: > On 13/02/2024 21:37, Tanmay Shah wrote: > > Hello, > > > > Thanks for reviews please find my comments below. > > > > On 2/13/24 1:20 PM, Rob Herring wrote: > >> On Tue, 13 Feb 2024 09:54:48 -0800, Tanmay Shah wrote: > >>> From: Radhey Shyam

Re: [PATCH v7 28/36] tracing: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs

2024-02-15 Thread Steven Rostedt
On Wed, 7 Feb 2024 00:12:40 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Add ftrace_partial_regs() which converts the ftrace_regs to pt_regs. > If the architecture defines its own ftrace_regs, this copies partial > registers to pt_regs and returns it. If not,

Re: [PATCH v7 25/36] arm64: ftrace: Enable HAVE_FUNCTION_GRAPH_FREGS

2024-02-15 Thread Steven Rostedt
On Wed, 7 Feb 2024 00:12:06 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Enable CONFIG_HAVE_FUNCTION_GRAPH_FREGS on arm64. Note that this > depends on HAVE_DYNAMIC_FTRACE_WITH_ARGS which is enabled if the > compiler supports "-fpatchable-function-entry=2". If

Re: [PATCH v7 24/36] x86/ftrace: Enable HAVE_FUNCTION_GRAPH_FREGS

2024-02-15 Thread Steven Rostedt
On Wed, 7 Feb 2024 00:11:56 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Support HAVE_FUNCTION_GRAPH_FREGS on x86-64, which saves ftrace_regs > on the stack in ftrace_graph return trampoline so that the callbacks > can access registers via ftrace_regs APIs. >

Re: [PATCH v7 23/36] function_graph: Add a new exit handler with parent_ip and ftrace_regs

2024-02-15 Thread Steven Rostedt
On Wed, 7 Feb 2024 00:11:44 +0900 "Masami Hiramatsu (Google)" wrote: > diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h > index c88bf47f46da..a061f8832b20 100644 > --- a/arch/x86/include/asm/ftrace.h > +++ b/arch/x86/include/asm/ftrace.h > @@ -72,6 +72,8 @@

Re: [PATCH v7 23/36] function_graph: Add a new exit handler with parent_ip and ftrace_regs

2024-02-15 Thread Steven Rostedt
On Wed, 7 Feb 2024 00:11:44 +0900 "Masami Hiramatsu (Google)" wrote: > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > index 61c541c36596..308b3bec01b1 100644 > --- a/kernel/trace/Kconfig > +++ b/kernel/trace/Kconfig > @@ -34,6 +34,9 @@ config HAVE_FUNCTION_GRAPH_TRACER > config

Re: [PATCH V2 3/3] vdpa_sim: flush workers on suspend

2024-02-15 Thread Eugenio Perez Martin
On Wed, Feb 14, 2024 at 8:52 PM Steven Sistare wrote: > > On 2/14/2024 2:39 PM, Eugenio Perez Martin wrote: > > On Wed, Feb 14, 2024 at 6:50 PM Steven Sistare > > wrote: > >> > >> On 2/13/2024 11:10 AM, Eugenio Perez Martin wrote: > >>> On Mon, Feb 12, 2024 at 6:16 PM Steve Sistare > >>>

Re: [PATCH v7 23/36] function_graph: Add a new exit handler with parent_ip and ftrace_regs

2024-02-15 Thread Steven Rostedt
On Wed, 7 Feb 2024 00:11:44 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Add a new return handler to fgraph_ops as 'retregfunc' which takes > parent_ip and ftrace_regs instead of ftrace_graph_ret. This handler > is available only if the arch support

Re: [PATCH v7 22/36] function_graph: Add a new entry handler with parent_ip and ftrace_regs

2024-02-15 Thread Steven Rostedt
On Wed, 7 Feb 2024 00:11:34 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Add a new entry handler to fgraph_ops as 'entryregfunc' which takes > parent_ip and ftrace_regs. Note that the 'entryfunc' and 'entryregfunc' > are mutual exclusive. You can set only

Re: [PATCH v7 21/36] function_graph: Add selftest for passing local variables

2024-02-15 Thread Steven Rostedt
On Wed, 7 Feb 2024 00:11:22 +0900 "Masami Hiramatsu (Google)" wrote: > From: Steven Rostedt (VMware) > > Add boot up selftest that passes variables from a function entry to a > function exit, and make sure that they do get passed around. > > Signed-off-by: Steven Rostedt (VMware) >

Re: [PATCH v7 20/36] function_graph: Improve push operation for several interrupts

2024-02-15 Thread Steven Rostedt
On Wed, 7 Feb 2024 00:11:12 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Improve push and data reserve operation on the shadow stack for > several sequencial interrupts. > > To push a ret_stack or data entry on the shadow stack, we need to > prepare an index

Re: [RFC PATCH v2 4/6] dt-bindings: input: add entry for Marvell 88PM88X PMICs onkey

2024-02-15 Thread Rob Herring
On Sun, Feb 11, 2024 at 10:35:54AM +0100, Karel Balej wrote: > From: Karel Balej > > Marvell 88PM88X PMICs provide onkey functionality -- add the bindings. > > Signed-off-by: Karel Balej > --- > > Notes: > RFC v2: > - Add wakeup-source property and reference onkey schema from MFD. >

Re: [RFC PATCH v2 1/6] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC

2024-02-15 Thread Rob Herring
On Sun, Feb 11, 2024 at 10:35:51AM +0100, Karel Balej wrote: > From: Karel Balej > > Marvell 88PM886 is a PMIC with several subdevices such as onkey, > regulators or battery and charger. It comes in at least two revisions, > A0 and A1 -- only A1 is described here at the moment. > >

Re: [RESEND PATCH v2] modules: wait do_free_init correctly

2024-02-15 Thread Eric Chanudet
On Tue, Jan 30, 2024 at 06:21:03AM -0800, Luis Chamberlain wrote: > On Tue, Jan 30, 2024 at 09:40:38AM +0800, Changbin Du wrote: > > On Mon, Jan 29, 2024 at 09:53:58AM -0800, Luis Chamberlain wrote: > > > On Mon, Jan 29, 2024 at 10:03:04AM +0800, Changbin Du wrote: > > > > The commit 1a7b7d922081

[PATCH] kbuild: remove EXPERT and !COMPILE_TEST guarding from TRIM_UNUSED_KSYMS

2024-02-15 Thread Masahiro Yamada
This reverts the following two commits: - a555bdd0c58c ("Kbuild: enable TRIM_UNUSED_KSYMS again, with some guarding") - 5cf0fd591f2e ("Kbuild: disable TRIM_UNUSED_KSYMS option") Commit 5e9e95cc9148 ("kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion") solved the build time issue.

Re: [PATCH] synthetic tracing: Fix trace_string() return value

2024-02-15 Thread Google
On Wed, 14 Feb 2024 23:05:56 +0100 Thorsten Blum wrote: > Fix trace_string() by assigning the string length to the return variable > which got lost in commit ddeea494a16f ("tracing/synthetic: Use union > instead of casts") and caused trace_string() to always return 0. > Good catch! Acked-by:

Re: [PATCH v4 0/6] LoongArch: Add pv ipi support on LoongArch VM

2024-02-15 Thread WANG Xuerui
On 2/15/24 18:11, WANG Xuerui wrote: Sorry for the late reply (and Happy Chinese New Year), and thanks for providing microbenchmark numbers! But it seems the more comprehensive CoreMark results were omitted (that's also absent in v3)? While the Of course the benchmark suite should be

Re: [PATCH v4 0/6] LoongArch: Add pv ipi support on LoongArch VM

2024-02-15 Thread WANG Xuerui
Hi, On 2/1/24 11:19, Bibo Mao wrote: [snip] Here is the microbenchmarck data with perf bench futex wake case on 3C5000 single-way machine, there are 16 cpus on 3C5000 single-way machine, VM has 16 vcpus also. The benchmark data is ms time unit to wakeup 16 threads, the performance is higher if

Re: [PATCH 1/3] loongarch: Call arch_mem_init() before platform_init() in the init sequence

2024-02-15 Thread Huacai Chen
Hi, Oreoluwa, On Thu, Feb 15, 2024 at 5:31 AM Oreoluwa Babatunde wrote: > > > On 2/14/2024 5:03 AM, Huacai Chen wrote: > > Hi, Oreoluwa, > > > > On Sat, Feb 10, 2024 at 8:29 AM Oreoluwa Babatunde > > wrote: > >> The platform_init() function which is called during device bootup > >> contains a

Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held

2024-02-15 Thread Jonathan Cameron
On Wed, 14 Feb 2024 17:33:18 -0500 Steven Rostedt wrote: > On Wed, 14 Feb 2024 14:19:19 -0800 > Ira Weiny wrote: > > > > > Jonathan Cameron wrote: > > > > > > > > > So I'm thinking this is a won't fix - wait for the printk rework to > > > > > land and > > > > > assume this will be

Re: [v3 PATCH] ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.

2024-02-15 Thread Aiswarya Cyriac
>>On Wed, Feb 14, 2024 at 03:01:10PM +0100, Aiswarya Cyriac wrote: >> This commit fixes the following warning when building virtio_snd driver. >> >> " >> *** CID 1583619: Uninitialized variables (UNINIT) >> sound/virtio/virtio_kctl.c:294 in virtsnd_kctl_tlv_op() >> 288 >> 289

Re: [PATCH v10 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-02-15 Thread Krzysztof Kozlowski
On 13/02/2024 21:37, Tanmay Shah wrote: > Hello, > > Thanks for reviews please find my comments below. > > On 2/13/24 1:20 PM, Rob Herring wrote: >> On Tue, 13 Feb 2024 09:54:48 -0800, Tanmay Shah wrote: >>> From: Radhey Shyam Pandey >>> >>> Introduce bindings for TCM memory address space on