Re: [PATCH 2/5 v2] Input: bu21013_ts - Move GPIO init and exit functions into the driver

2012-11-26 Thread Dmitry Torokhov
Hi Lee, On Mon, Nov 26, 2012 at 12:01:43PM +, Lee Jones wrote: > /** > + * bu21013_gpio_board_init() - configures the touch panel > + * @reset_pin: reset pin number > + * > + * This function is used to configure the voltage and > + * reset the touch panel controller. > + */ > +static int bu21

Re: [PATCH 1/5] Input: bu21013_ts - Request a regulator that actually exists

2012-11-26 Thread Dmitry Torokhov
correct name, as referenced in platform regulator code is 'avdd'. Here, > > when we request a regulator, we use the correct name instead. > > > > Cc: Dmitry Torokhov > > Cc: linux-in...@vger.kernel.org > > Acked-by: Arnd Bergmann > > Acked-by: Linus Walle

Re: [PATCH 2/3] Input: spear-keyboard: Add clk_{un}prepare() support

2012-11-26 Thread Dmitry Torokhov
On Mon, Nov 26, 2012 at 09:57:45PM +0530, Viresh Kumar wrote: > On 20 November 2012 14:17, Dmitry Torokhov wrote: > > No, not really, it just does not work well with devm_* patches that got > > applied: on removal you unprepare clock as the very first operation and > > then

Re: [Pv-drivers] [PATCH 00/12] VMCI for Linux upstreaming

2012-11-26 Thread Dmitry Torokhov
On Monday, November 26, 2012 02:37:54 PM Greg KH wrote: > On Wed, Nov 21, 2012 at 12:31:04PM -0800, George Zhang wrote: > > * * * > > This series of VMCI linux upstreaming patches include latest udpate from > > VMware. > > > > Summary of changes: > > - Sparse clean. > > - Checkpatch clean

Re: [Pv-drivers] [PATCH 00/12] VMCI for Linux upstreaming

2012-11-26 Thread Dmitry Torokhov
On Monday, November 26, 2012 03:23:57 PM Greg KH wrote: > On Mon, Nov 26, 2012 at 03:01:04PM -0800, Dmitry Torokhov wrote: > > On Monday, November 26, 2012 02:37:54 PM Greg KH wrote: > > > On Wed, Nov 21, 2012 at 12:31:04PM -0800, George Zhang wrote: > > > > * * * >

Re: [Pv-drivers] [PATCH 00/12] VMCI for Linux upstreaming

2012-11-26 Thread Dmitry Torokhov
On Monday, November 26, 2012 03:44:26 PM Greg KH wrote: > On Mon, Nov 26, 2012 at 03:36:52PM -0800, Dmitry Torokhov wrote: > > On Monday, November 26, 2012 03:23:57 PM Greg KH wrote: > > > On Mon, Nov 26, 2012 at 03:01:04PM -0800, Dmitry Torokhov wrote: > > > > On M

Re: [PATCH 12/12] VMCI: Some header and config files.

2012-11-26 Thread Dmitry Torokhov
Hi Greg, For some reason it still didn't go through to our corporate mail server but I see it on LKML. On Mon, Nov 26, 2012 at 04:03:04PM -0800, Greg KH wrote: > On Wed, Nov 07, 2012 at 10:43:03AM -0800, George Zhang wrote: > > > +static inline struct vmci_handle VMCI_MAKE_HANDLE(vmci_id cid, vm

Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files.

2012-11-26 Thread Dmitry Torokhov
On Monday, November 26, 2012 04:32:39 PM Greg KH wrote: > On Mon, Nov 26, 2012 at 04:23:57PM -0800, Dmitry Torokhov wrote: > > Hi Greg, > > > > For some reason it still didn't go through to our corporate mail server > > but I see it on LKML. > > Good. >

Re: [Pv-drivers] [PATCH 00/12] VMCI for Linux upstreaming

2012-11-26 Thread Dmitry Torokhov
On Mon, Nov 26, 2012 at 07:27:07PM -0500, Woody Suwalski wrote: > Greg KH wrote: > >On Mon, Nov 26, 2012 at 03:52:31PM -0800, Dmitry Torokhov wrote: > >> > >>Mind resending it, please? > >Now resent. > I see both versions of Greg's message - one from 1

[PATCH v2] ARM: eukrea_mbimx27-baseboard - use stock get_pendown_state() in ads7846

2012-11-27 Thread Dmitry Torokhov
The default implementation matches exactly our custom one so we can switch to using the default one. As a bonus the driver will take care of setting GPIO line for us. Signed-off-by: Dmitry Torokhov --- Adjusted to use IMX_GPIO_NR() macro. arch/arm/mach-imx/eukrea_mbimx27-baseboard.c | 19

[PATCH 2/4] Input: RMI4 - move sensor driver and F01 handler into the core

2012-11-27 Thread Dmitry Torokhov
There is no point in having the sensor driver and F01 handler separate from the RMI core since it is not useful without them and having them all together simplifies initialization among other things. Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/Kconfig | 23

[PATCH 3/4] Input: RMI4 - move function registration into the core

2012-11-27 Thread Dmitry Torokhov
This saves on boilerplate code that is needed in individual modules implementing function handlers. Also converted bool bitfields back to u8. Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_bus.c| 189 ++ drivers/input/rmi4/rmi_driver.c | 2

[PATCH 4/4] Input: RMI4 - introduce rmi_module_driver() macro

2012-11-27 Thread Dmitry Torokhov
This also allows us to cut down on the boilerplate code in the function handler modules. Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_f11.c | 13 + include/linux/rmi.h | 14 ++ 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers

Re: [RFC PATCH 05/06] input/rmi4: F01 - device control

2012-11-27 Thread Dmitry Torokhov
On Mon, Nov 26, 2012 at 02:31:27PM -0800, Christopher Heiny wrote: > On 11/26/2012 01:40 AM, Dmitry Torokhov wrote: > >Hi Christopher, > > > >On Fri, Nov 16, 2012 at 07:58:53PM -0800, Christopher Heiny wrote: > >>RMI Function 01 implements basic device control and

[PATCH 2/2] Input: RMI4 - F11 - remove relreport attribute

2012-11-27 Thread Dmitry Torokhov
This data item does not seem to be used anywhere. Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_f11.c | 37 - include/linux/rmi.h | 1 - 2 files changed, 38 deletions(-) diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4

[PATCH 1/2] Input: RMI4 - rework F11 sysfs and debugfs attributes

2012-11-27 Thread Dmitry Torokhov
Avoid rolling our own debugfs operations and use the standar ones instead. Also switch to using attribute groups to create sysfs attributes. The max_x and max_y can be retrieced via EVIOGABS and so attributes moved over to debugfs. Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_f11

Re: [PATCH 3/3] Input: bu21013_ts - Add support for Device Tree booting

2012-11-27 Thread Dmitry Torokhov
Hi Lee, On Tue, Nov 27, 2012 at 01:13:10PM +, Lee Jones wrote: > Now we can register the BU21013_ts touch screen when booting with > Device Tree enabled. Here we parse all the necessary components > previously expected to be passed from platform data. I applied these 3 patches, but for DT we

Re: [PATCH 1/4] Input RMI4 - rename rmi_function_container to rmi_function

2012-11-27 Thread Dmitry Torokhov
On Tue, Nov 27, 2012 at 03:43:05PM -0800, Christopher Heiny wrote: > On 11/27/2012 01:21 AM, Dmitry Torokhov wrote: > >To save my old fingers... > > > >Signed-off-by: Dmitry Torokhov > >--- > > > >It looks like this driver(s) need some love and I might

Re: [PATCH 2/4] Input: RMI4 - move sensor driver and F01 handler into the core

2012-11-29 Thread Dmitry Torokhov
Hi Chris, On Wed, Nov 28, 2012 at 08:54:32PM -0800, Christopher Heiny wrote: > On 11/27/2012 01:21 AM, Dmitry Torokhov wrote: > >There is no point in having the sensor driver and F01 handler separate > >from the RMI core since it is not useful without them and having them

[PATCH] Input: gpio_keys_polled - switch to using gpio_request_one()

2012-11-29 Thread Dmitry Torokhov
This saves us a few lines of code. Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/gpio_keys_polled.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c index d72d0e5

[PATCH] Input: gpio_keys - switch to using gpio_request_one()

2012-11-29 Thread Dmitry Torokhov
This saves us a few lines of code. Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/gpio_keys.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 79435de..d327f5a 100644 --- a

Re: [PATCH] input: drop unnecessary dependencies on TTY

2013-02-06 Thread Dmitry Torokhov
On Tue, Feb 05, 2013 at 05:58:34PM -0800, Joe Millenbach wrote: > Backing out changes made in earlier TTY removal patch. Switched > to only one dependency in SERPORT on TTY instead of many incorrect > dependencies. > > Signed-off-by: Joe Millenbach > Reported-by: Dmitry T

Re: [Pv-drivers] [PATCH 0/1] VM Sockets for Linux upstreaming

2013-02-08 Thread Dmitry Torokhov
Hi David, On Wed, Feb 06, 2013 at 04:23:55PM -0800, Andy King wrote: > In an effort to improve the out-of-the-box experience with Linux kernels for > VMware users, VMware is working on readying the VM Sockets (VSOCK, formerly > VMCI Sockets) (vsock) kernel module for inclusion in the Linux kernel.

Re: [PATCH] input: don't call input_dev_release_keys() in resume

2013-04-04 Thread Dmitry Torokhov
Hi Oskar, On Thu, Mar 07, 2013 at 03:01:22PM +0100, oskar.and...@sonymobile.com wrote: > From: Aleksej Makarov > > When waking up the platform by pressing a specific key, sending a > release on that key makes it impossible to react on the event in > user-space. > No, we can not simply not rele

Re: linux-next: manual merge of the tty tree with the input tree

2013-01-28 Thread Dmitry Torokhov
On Mon, Jan 28, 2013 at 02:09:31PM -0800, Joe Millenbach wrote: > On Mon, Jan 28, 2013 at 9:33 AM, Dmitry Torokhov > wrote: > > On Mon, Jan 28, 2013 at 06:46:15AM -0800, Greg KH wrote: > >> On Mon, Jan 28, 2013 at 08:44:24PM +1100, Stephen Rothwell wrote: > >> &g

Re: linux-next: manual merge of the tty tree with the input tree

2013-01-28 Thread Dmitry Torokhov
On Tue, Jan 29, 2013 at 10:59:17AM +1100, Josh Triplett wrote: > On Mon, Jan 28, 2013 at 02:44:43PM -0800, Dmitry Torokhov wrote: > > On Mon, Jan 28, 2013 at 02:09:31PM -0800, Joe Millenbach wrote: > > > On Mon, Jan 28, 2013 at 9:33 AM, Dmitry Torokhov > > > wrote: >

Re: linux-next: manual merge of the tty tree with the input tree

2013-01-28 Thread Dmitry Torokhov
On Tue, Jan 29, 2013 at 04:13:21PM +1100, Josh Triplett wrote: > On Mon, Jan 28, 2013 at 04:23:57PM -0800, Dmitry Torokhov wrote: > > On Tue, Jan 29, 2013 at 10:59:17AM +1100, Josh Triplett wrote: > > > On Mon, Jan 28, 2013 at 02:44:43PM -0800, Dmitry Torokhov wrote: > >

Re: linux-next: manual merge of the tty tree with the input tree

2013-01-28 Thread Dmitry Torokhov
Hi Joe, On Mon, Jan 28, 2013 at 10:26:47PM -0800, Joe Millenbach wrote: > On Mon, Jan 28, 2013 at 9:33 PM, Dmitry Torokhov > wrote: > > Please revert the input changes and add *ONE* new dependency to the > > serport driver. > > > > Thanks. > > > > --

Re: [PATCH 04/05] input: RMI4 F01 device control

2013-01-31 Thread Dmitry Torokhov
Hi Chris, On Fri, Jan 18, 2013 at 05:12:44PM -0800, Christopher Heiny wrote: > In addition to the changes described in 0/0 of this patchset, this patch > includes device serialization updated to conform to the latest RMI4 > specification. I was looking at the various aspects of the RMI4 patchset,

Re: [PATCH v3 0/2] Input: twl6040-vibra cleanups (devm_* conversion, system wq)

2013-01-25 Thread Dmitry Torokhov
Hi Peter, On Thu, Jan 24, 2013 at 12:44:29PM +0100, Peter Ujfalusi wrote: > Hi Dmitry, > > On 01/14/2013 04:34 PM, Peter Ujfalusi wrote: > > Hi Dmitry, > > > > Changes since v2: > > - twl4030-vibra patches are left out (they have been applied) > > - Do not use devm_input_allocate_device() in twl

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
Hi Borislav, On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote: > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > index 8e1a9ec53003..cb467656e684 100644 > --- a/drivers/hv/vmbus_drv.c > +++ b/drivers/hv/vmbus_drv.c > @@ -724,7 +724,7 @@ static int __init hv_acpi_init(

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
Hi Borislav, On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > Put all config options needed to run Linux as a guest behind a > CONFIG_HYPERVISOR_GUEST menu so that they don't get built-in by > default but selected by the user. Also, move x86_hyper into

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
On Fri, Jan 25, 2013 at 07:23:35PM +0100, Borislav Petkov wrote: > On Fri, Jan 25, 2013 at 10:07:31AM -0800, Dmitry Torokhov wrote: > > > - if (x86_hyper != &x86_hyper_ms_hyperv) > > > + if (!x86_hyper || strncmp(x86_hyper->name, "VMware", 6)) > > >

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
On Fri, Jan 25, 2013 at 07:32:13PM +0100, Borislav Petkov wrote: > On Fri, Jan 25, 2013 at 10:12:51AM -0800, Dmitry Torokhov wrote: > > Hi Borislav, > > > > On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote: > > > From: Borislav Petkov > > >

Re: [Pv-drivers] [PATCH 1/1] VSOCK: Introduce VM Sockets

2013-01-25 Thread Dmitry Torokhov
Hi Neil, On Friday, January 25, 2013 06:59:53 PM Neil Horman wrote: > On Fri, Jan 25, 2013 at 09:37:50AM -0800, ack...@vmware.com wrote: > > + > > +config VMWARE_VSOCK > > + tristate "Virtual Socket protocol" > > + depends on VMWARE_VMCI > > What is CONFIG_VMWARE_VMCI? I don't find that in a

Re: linux-next: manual merge of the tty tree with the input tree

2013-01-28 Thread Dmitry Torokhov
On Mon, Jan 28, 2013 at 06:46:15AM -0800, Greg KH wrote: > On Mon, Jan 28, 2013 at 08:44:24PM +1100, Stephen Rothwell wrote: > > Hi Greg, > > > > Today's linux-next merge of the tty tree got a conflict in > > drivers/input/keyboard/Kconfig between commit 6f2ac009f29b ("Input: > > goldfish - virtua

[PATCH 2/5] W1: w1-gpio - switch to using dev_pm_ops

2013-02-22 Thread Dmitry Torokhov
Signed-off-by: Dmitry Torokhov --- drivers/w1/masters/w1-gpio.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c index 799dafd..c45b9ae 100644 --- a/drivers/w1/masters/w1-gpio.c +++ b/drivers/w1

[PATCH 3/5] W1: w1-gpio - guard DT IDs with CONFIG_OF

2013-02-22 Thread Dmitry Torokhov
This fixes the following warning: CC drivers/w1/masters/w1-gpio.o drivers/w1/masters/w1-gpio.c:50:28: warning: ‘w1_gpio_dt_ids’ defined but not used [-Wunused-variable] Also provide stub for w1_gpio_probe_dt() if device tree support is disabled. Signed-off-by: Dmitry Torokhov

[PATCH 5/5] W1: w1-gpio - switch to using managed resources (devm)

2013-02-22 Thread Dmitry Torokhov
This simplifies error unwinding and device teardown. Signed-off-by: Dmitry Torokhov --- drivers/w1/masters/w1-gpio.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c index ee6b6e3

[PATCH 4/5] W1: w1-gpio - rework handling of platform data

2013-02-22 Thread Dmitry Torokhov
tree and prefer kernel-supplied data (it may be easier to fiddle in kernel structure before committing final result to device tree). Signed-off-by: Dmitry Torokhov --- drivers/w1/masters/w1-gpio.c | 93 +--- 1 file changed, 53 insertions(+), 40 deletions

[PATCH 1/5] W1: w1-gpio - fix incorrect __init/__exit markups

2013-02-23 Thread Dmitry Torokhov
We should not be using __init/__exit markups on probe() and remove() methods unless platform_device_probe() is used, because other methods allow unbinding device through sysfs and these methods should not be discarded. Signed-off-by: Dmitry Torokhov --- This was just compiled - no hardware

Re: [PATCH 4/5] W1: w1-gpio - rework handling of platform data

2013-02-23 Thread Dmitry Torokhov
On Sat, Feb 23, 2013 at 06:55:45PM +0200, Ville Syrjälä wrote: > On Fri, Feb 22, 2013 at 11:58:39PM -0800, Dmitry Torokhov wrote: > > The platform data in the dveice structure does not belong to the driver > > and so it should not be trying to alter it, but instead use a local

[RFC/PATCH] devres: allow adding custom actions to the stack

2013-02-23 Thread Dmitry Torokhov
group of devres resources. Signed-off-by: Dmitry Torokhov --- drivers/base/devres.c | 74 ++ include/linux/device.h | 4 +++ 2 files changed, 78 insertions(+) diff --git a/drivers/base/devres.c b/drivers/base/devres.c index 6683906..507379e 100644

Re: [PATCH v5 1/3] mfd: syscon: Removed support for unloading

2013-02-23 Thread Dmitry Torokhov
On Sat, Feb 23, 2013 at 04:51:19PM -0700, Stephen Warren wrote: > On 02/22/2013 10:28 PM, Alexander Shiyan wrote: > >> On 02/22/2013 10:15 PM, Alexander Shiyan wrote: > >>> The driver can be used in various subsystems and therefore should not > >>> be unloaded when it is defined in the kernel confi

[PATCH] Media: remove incorrect __exit markups

2013-02-24 Thread Dmitry Torokhov
: Dmitry Torokhov --- drivers/media/i2c/adp1653.c | 4 ++-- drivers/media/i2c/smiapp/smiapp-core.c | 4 ++-- drivers/media/platform/soc_camera/omap1_camera.c | 4 ++-- drivers/media/radio/radio-si4713.c | 4 ++-- drivers/media/rc/ir-rx51.c

[PATCH] Regulator: db8500-prcmu - remove incorrect __exit markup

2013-02-24 Thread Dmitry Torokhov
: Dmitry Torokhov --- drivers/regulator/db8500-prcmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/db8500-prcmu.c b/drivers/regulator/db8500-prcmu.c index 219d162..a53c11a 100644 --- a/drivers/regulator/db8500-prcmu.c +++ b/drivers/regulator/db8500

[PATCH] SPI: spi-ppc4xx - remove incorrect __exit markup

2013-02-24 Thread Dmitry Torokhov
: Dmitry Torokhov --- drivers/spi/spi-ppc4xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c index 7a85f22..027b474 100644 --- a/drivers/spi/spi-ppc4xx.c +++ b/drivers/spi/spi-ppc4xx.c @@ -560,7 +560,7 @@ free_master

[PATCH 2/5] W1: w1-gpio - switch to using dev_pm_ops

2013-02-24 Thread Dmitry Torokhov
Signed-off-by: Dmitry Torokhov --- drivers/w1/masters/w1-gpio.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c index 799dafd..c45b9ae 100644 --- a/drivers/w1/masters/w1-gpio.c +++ b/drivers/w1

[PATCH 5/5] W1: w1-gpio - switch to using managed resources (devm)

2013-02-24 Thread Dmitry Torokhov
This simplifies error unwinding and device teardown. Signed-off-by: Dmitry Torokhov --- drivers/w1/masters/w1-gpio.c | 32 +++- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c index 465ce52

[PATCH 4/5] W1: w1-gpio - rework handling of platform data

2013-02-24 Thread Dmitry Torokhov
tree and prefer kernel-supplied data (it may be easier to fiddle in kernel structure before committing final result to device tree). Signed-off-by: Dmitry Torokhov --- drivers/w1/masters/w1-gpio.c | 44 +--- 1 file changed, 25 insertions(+), 19 deletions

[PATCH 3/5] W1: w1-gpio - guard DT IDs with CONFIG_OF

2013-02-24 Thread Dmitry Torokhov
This fixes the following warning: CC drivers/w1/masters/w1-gpio.o drivers/w1/masters/w1-gpio.c:50:28: warning: ‘w1_gpio_dt_ids’ defined but not used [-Wunused-variable] Also provide stub for w1_gpio_probe_dt() if device tree support is disabled. Signed-off-by: Dmitry Torokhov

[PATCH v2 1/5] W1: w1-gpio - fix incorrect __init/__exit markups

2013-02-24 Thread Dmitry Torokhov
We should not be using __init/__exit markups on probe() and remove() methods unless platform_device_probe() is used, because other methods allow unbinding device through sysfs and these methods should not be discarded. Signed-off-by: Dmitry Torokhov --- Paatch #4 was adjusted according to

Re: [PATCH v5 1/3] mfd: syscon: Removed support for unloading

2013-02-24 Thread Dmitry Torokhov
On Mon, Feb 25, 2013 at 10:53:42AM +0400, Alexander Shiyan wrote: > > On Sat, Feb 23, 2013 at 04:51:19PM -0700, Stephen Warren wrote: > > > On 02/22/2013 10:28 PM, Alexander Shiyan wrote: > > > >> On 02/22/2013 10:15 PM, Alexander Shiyan wrote: > > > >>> The driver can be used in various subsystems

Re: [PATCH] Media: remove incorrect __exit markups

2013-02-25 Thread Dmitry Torokhov
On Mon, Feb 25, 2013 at 08:49:26AM +0100, Guennadi Liakhovetski wrote: > Hi Dmitry > > On Sun, 24 Feb 2013, Dmitry Torokhov wrote: > > > Even if bus is not hot-pluggable, the devices can be unbound from the > > driver via sysfs, so we should not be using __exit a

Re: [PATCH v6 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-25 Thread Dmitry Torokhov
e matrix-keypad FDT binding is used with a small addition to control > ghosting. > > Signed-off-by: Simon Glass > Signed-off-by: Luigi Semenzato > Signed-off-by: Vincent Palatin Acked-by: Dmitry Torokhov > --- > Changes in v6: > - Fix incorrect indentation in cros_e

Re: [RFC/PATCH] devres: allow adding custom actions to the stack

2013-02-25 Thread Dmitry Torokhov
On Mon, Feb 25, 2013 at 03:48:01PM -0800, Tejun Heo wrote: > On Sat, Feb 23, 2013 at 08:05:57PM -0800, Dmitry Torokhov wrote: > > Sometimes drivers need to execute one-off actions in their error handling > > or device teardown paths. An example would be toggling a GPIO line t

[PATCH v2] Media: remove incorrect __init/__exit markups

2013-02-25 Thread Dmitry Torokhov
() methods should not be marked __init unless platform_driver_probe() is used. Signed-off-by: Dmitry Torokhov --- v1->v2: removed __init markup on omap1_cam_probe() that was pointed out by Guennadi Liakhovetski. drivers/media/i2c/adp1653.c | 4 ++-- drivers/me

Re: [PATCH] ipack: add missing put_device() after device_register() failed

2013-02-26 Thread Dmitry Torokhov
On Tue, Feb 26, 2013 at 10:03:15AM +0100, Samuel Iglesias Gonsalvez wrote: > put_device() must be called after device_register() fails, > since device_register() always initializes the refcount > on the device structure to one. > > dev->id is free'd inside of ipack_device_release function. > So, i

Re: [PATCH V2] rtc: add devm_rtc_device_{register,unregister}()

2013-02-26 Thread Dmitry Torokhov
On Tue, Feb 26, 2013 at 10:21:06AM +0900, Jingoo Han wrote: > +/** > + * devm_rtc_device_unregister - resource managed devm_rtc_device_unregister() > + * @dev: the device to unregister > + * @rtc: the RTC class device to unregister > + * > + * Deallocated a rtc allocated with devm_rtc_device_regist

Re: [PATCH] gpio: em: Add Device Tree support

2013-02-26 Thread Dmitry Torokhov
Hi Magnus, On Tue, Feb 26, 2013 at 10:26:23PM +0900, Magnus Damm wrote: > From: Magnus Damm > > Update the Emma Mobile GPIO driver to add DT support. > ... > @@ -366,15 +387,33 @@ static int em_gio_remove(struct platform > return 0; > } > #ifdef CONFIG_OF here? No need to have extra

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Dmitry Torokhov
On Wed, Feb 27, 2013 at 10:58:44AM -0700, Mathieu Poirier wrote: > On 13-02-27 09:57 AM, Linus Torvalds wrote: > > On Tue, Feb 26, 2013 at 11:33 PM, Dave Airlie wrote: > >> > >> It looks to me like the weak bit isn't working so well > >> > >> if (platform_sysrq_reset_seq) { > >>

Re: uhid: broken interface: 32/64-bit compatibility

2013-02-18 Thread Dmitry Torokhov
Hi David, On Fri, Feb 15, 2013 at 12:46:55PM +0100, David Herrmann wrote: > Hi Kirill > > On Fri, Feb 15, 2013 at 12:29 PM, Kirill A. Shutemov > wrote: > > Hi David and all, > > > > There's claim in uhid.h that the interface is "compatible even between > > architectures". But it obviously is not

Re: uhid: broken interface: 32/64-bit compatibility

2013-02-18 Thread Dmitry Torokhov
On Mon, Feb 18, 2013 at 11:28:40AM +0100, Jiri Kosina wrote: > On Fri, 15 Feb 2013, Dmitry Torokhov wrote: > > > > Here's my attempt to fix the issue. > > > > > > Not sure if tricks with padding in a good idea. We can just use __u64 > > > in

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-19 Thread Dmitry Torokhov
On Mon, Feb 18, 2013 at 11:20:43PM -0800, Joe Perches wrote: > On Mon, 2013-02-18 at 20:13 -0800, Simon Glass wrote: > > On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov > > > On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: > > >> + for (r

Re: [PATCH] Input: psmouse - retry getid command in psmouse_probe()

2013-02-19 Thread Dmitry Torokhov
Hi Chung-yih, On Mon, Feb 18, 2013 at 05:45:07PM +0800, Chung-Yih Wang (王崇懿) wrote: > Yes, I could add CONFIG_MOUSE_PS2_SYNAPTICS for the change as we only > need it for synaptics touchpad/touchpoint on lenovo's machines. > I do not think it will solve anything as all distributions have CONFIG_M

Re: [PATCH] Input: synaptics - add retry mechanism for reconnect

2013-02-19 Thread Dmitry Torokhov
Hi Chung-yih, On Mon, Feb 18, 2013 at 04:40:21PM +0800, Chung-yih Wang wrote: > On the Samsung Series 5 Chromebook, the Synaptics ClickPad will sometimes not > send an "0xFA" PS/2 ACK in response to a command byte during the reconnect > sequence following a resume from suspend. From our experiment

[git pull] Input updates for 3.9-rc0

2013-02-19 Thread Dmitry Torokhov
and (1): Input: goldfish - virtual input event driver Daniel Kurtz (1): Input: synaptics - fix 1->3 contact transition reporting Dmitry Torokhov (6): Input: atkbd - fix a typo in a message Input: walkera0701 - set up input device's parent Input: walkera0701 -

Re: [PATCH 07/11] mfd: menelaus: use devm_request_irq() and devm_kzalloc()

2013-02-19 Thread Dmitry Torokhov
Hi Jongoo, On Wed, Feb 20, 2013 at 03:12:38PM +0900, Jingoo Han wrote: > Use devm_request_irq() and devm_kzalloc() to make cleanup paths > more simple. > ... > @@ -1269,9 +1266,7 @@ static int __exit menelaus_remove(struct i2c_client > *client) > { > struct menelaus_chip*menelaus =

Re: [PATCH 08/11] mfd: ezx-pcap: use devm_request_irq() and devm_kzalloc()

2013-02-19 Thread Dmitry Torokhov
On Wed, Feb 20, 2013 at 03:13:06PM +0900, Jingoo Han wrote: > Use devm_request_irq() and devm_kzalloc() to make cleanup paths > more simple. > > Signed-off-by: Jingoo Han > --- > drivers/mfd/ezx-pcap.c | 16 +--- > 1 files changed, 5 insertions(+), 11 deletions(-) > > diff --git a

Re: [PATCH 10/11] mfd: tps65010: use devm_request_irq() and devm_kzalloc()

2013-02-19 Thread Dmitry Torokhov
On Wed, Feb 20, 2013 at 03:14:05PM +0900, Jingoo Han wrote: > Use devm_request_irq() and devm_kzalloc() to make cleanup paths > more simple. > > Signed-off-by: Jingoo Han > --- > drivers/mfd/tps65010.c | 15 +-- > 1 files changed, 5 insertions(+), 10 deletions(-) > > diff --git a/

Re: [PATCH 05/11] mfd: twl6040: use devm_gpio_request_one() and devm_request_threaded_irq()

2013-02-19 Thread Dmitry Torokhov
Hi Jingoo, On Wed, Feb 20, 2013 at 03:11:38PM +0900, Jingoo Han wrote: > Use devm_gpio_request_one() and devm_request_threaded_irq() to make > cleanup paths and more simple. > > Signed-off-by: Jingoo Han > --- > drivers/mfd/twl6040.c | 26 +++--- > 1 files changed, 7 inse

Re: [PATCH 07/11] mfd: menelaus: use devm_request_irq() and devm_kzalloc()

2013-02-20 Thread Dmitry Torokhov
On Wed, Feb 20, 2013 at 05:05:10PM +0900, Jingoo Han wrote: > On Wednesday, February 20, 2013 4:31 PM, Dmitry Torokhov wrote: > > > > Hi Jongoo, > > > > On Wed, Feb 20, 2013 at 03:12:38PM +0900, Jingoo Han wrote: > > > Use devm_request_irq() and devm_kzallo

Re: [PATCH 07/11] mfd: menelaus: use devm_request_irq() and devm_kzalloc()

2013-02-20 Thread Dmitry Torokhov
On Wed, Feb 20, 2013 at 05:17:30PM +0900, Jingoo Han wrote: > On Wednesday, February 20, 2013 5:10 PM, Dmitry Torokhov wrote: > > > > On Wed, Feb 20, 2013 at 05:05:10PM +0900, Jingoo Han wrote: > > > On Wednesday, February 20, 2013 4:31 PM, Dmitry Torokhov wrote: &

[PATCH] hp-wmi: fix handling of platform device

2013-02-20 Thread Dmitry Torokhov
stead of platform_driver_register(), which disables binding/unbinding via sysfs. This also allows us to mark hp_wmi_bios_setup as __init and discard it once module is initialized. Signed-off-by: Dmitry Torokhov --- Compiled only, no hardware to run. drivers/platform/x86/hp-wmi.c

[PATCH] I2C: i2c-pxa - remove incorrect __exit annotations

2013-02-20 Thread Dmitry Torokhov
The remove() methods should not be marked __exit unless we are using platform_driver_probe() which disables unbinding device from driver via sysfs. Signed-off-by: Dmitry Torokhov --- Compiled only, no hardware. drivers/i2c/busses/i2c-pxa.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] MFD: remove incorrect __exit annotations

2013-02-20 Thread Dmitry Torokhov
Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. Signed-off-by: Dmitry Torokhov --- Not tested - no hardware. drivers/mfd/menelaus.c | 4 ++-- drivers/mfd/tps65010.c | 4 ++-- 2 files

Re: [PATCH v5 2/6] mfd: Add ChromeOS EC implementation

2013-02-20 Thread Dmitry Torokhov
On Wed, Feb 20, 2013 at 09:24:35AM -0800, Simon Glass wrote: > This is the base EC implementation, which provides a high level > interface to the EC for use by the rest of the kernel. The actual > communcations is dealt with by a separate protocol driver which > registers itself with this interface

Re: [PATCH v5 5/6] Input: matrix-keymap: Add function to read the new DT binding

2013-02-20 Thread Dmitry Torokhov
; parameters then we can add this, and then refactor each driver to hold > such a structure. > > Signed-off-by: Simon Glass > Tested-by: Sourav Poddar (v2) Acked-by: Dmitry Torokhov I suppose the EC driver will go through MFD tree, right? -- Dmitry -- To unsubscribe from this list

Re: [PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-20 Thread Dmitry Torokhov
} ... > +static int cros_ec_keyb_probe(struct platform_device *pdev) > +{ > + struct cros_ec_device *ec = dev_get_drvdata(pdev->dev.parent); > + struct device *dev = ec->dev; > + struct cros_ec_keyb *ckdev = NULL; > + struct input_dev *idev =

Re: [PATCH v5 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-20 Thread Dmitry Torokhov
On Wed, Feb 20, 2013 at 09:24:36AM -0800, Simon Glass wrote: > +#ifdef DEBUG > + dev_dbg(ec_dev->dev, "packet: "); > + for (i = 0; i < i2c_msg[1].len; i++) > + dev_cont(ec_dev->dev, " %02x", in_buf[i]); > + dev_cont(ec_dev->dev, ", sum = %02x\n", sum); There is "%ph" now so

Re: [PATCH] Input: fix Cypress PS/2 Trackpad in Dell XPS12

2013-02-21 Thread Dmitry Torokhov
On Thu, Feb 21, 2013 at 10:55:55AM -0800, Kamal Mostafa wrote: > Avoid firmware glitch in Cypress PS/2 Trackpad firmware version 11 > (as observed in Dell XPS12) which prevents driver from recognizing > the trackpad. > > BugLink: http://launchpad.net/bugs/1103594 > > Signed-off-by: Kamal Mostafa

Re: [PATCH] Input: fix Cypress PS/2 Trackpad in Dell XPS12

2013-02-21 Thread Dmitry Torokhov
On Thu, Feb 21, 2013 at 12:02:46PM -0800, Kamal Mostafa wrote: > On Thu, 2013-02-21 at 11:56 -0800, Dmitry Torokhov wrote: > > On Thu, Feb 21, 2013 at 10:55:55AM -0800, Kamal Mostafa wrote: > > > Avoid firmware glitch in Cypress PS/2 Trackpad firmware version 11 > > >

Dangerous devm_request_irq() conversions

2013-02-21 Thread Dmitry Torokhov
Hi, It looks like a whole slew of devm_request_irq() conversions just got applied to mainline and many of them are quite broken. Consider fd5231ce336e038037b4f0190a6838bdd6e17c6d or c1879fe80c61f3be6f2ddb82509c2e7f92a484fe: the drivers udsed first to free IRQ and then unregister the corresponding

Re: Dangerous devm_request_irq() conversions

2013-02-21 Thread Dmitry Torokhov
On Fri, Feb 22, 2013 at 04:12:36PM +0900, Jingoo Han wrote: > On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote: > > > > Hi, > > > > It looks like a whole slew of devm_request_irq() conversions just got > > applied to mainline and many of them ar

Re: Dangerous devm_request_irq() conversions

2013-02-22 Thread Dmitry Torokhov
On Fri, Feb 22, 2013 at 04:57:29PM +0900, Jingoo Han wrote: > On Friday, February 22, 2013 4:27 PM, Dmitry Torokhov wrote: > > On Fri, Feb 22, 2013 at 04:12:36PM +0900, Jingoo Han wrote: > > > On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote: > > > > > &

Re: linux-next: build failure after merge of the final tree

2013-03-12 Thread Dmitry Torokhov
On Tue, Mar 12, 2013 at 10:57:19PM +1100, Stephen Rothwell wrote: > On Tue, 12 Mar 2013 10:31:09 +0100 Daniel Hellstrom > wrote: > > > > APBPS2 driver is missing linux/slab.h required on at least PowerPC. See > > patch below. How do you want me to proceed? > > That is up to Dmitry - either a fi

Re: [PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-13 Thread Dmitry Torokhov
On Wed, Mar 13, 2013 at 04:50:49PM -0700, Benson Leung wrote: > + > +#define BYTE_PER_LINE 8 > +void cyapa_dump_data(struct cyapa *cyapa, size_t length, const u8 *data) > +{ > +#ifdef DEBUG > + struct device *dev = &cyapa->client->dev; > + int i; > + char buf[BYTE_PER_LINE * 3 + 1]; >

Re: [PATCH v2 4/8] drivers: input: use module_platform_driver_probe()

2013-03-14 Thread Dmitry Torokhov
Hi Fabio, On Thursday, March 14, 2013 06:09:34 PM Fabio Porcedda wrote: > This patch converts the drivers to use the > module_platform_driver_probe() macro which makes the code smaller and > a bit simpler. I already have patches from Sachin Kamat for this, I am waiting for -rc3 to sync up with ma

[git pull] Input updates for 3.6-rc4

2012-08-30 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Changelog: - Dmitry Torokhov (1): Input: i8042

Re: [PATCH] Input: Let the FT5x06 driver build without debugfs

2012-08-30 Thread Dmitry Torokhov
On Thu, Aug 30, 2012 at 03:26:21PM -0700, David Rientjes wrote: > On Tue, 21 Aug 2012, Dmitry Torokhov wrote: > > > > > > On 08/17/2012 02:15 AM, Eric W. Biederman wrote: > > > > >> When testing to make certain my user namespace code works in > > >

Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-30 Thread Dmitry Torokhov
Hi Matthieu, On Thu, Aug 30, 2012 at 04:30:54PM -0600, mathieu.poir...@linaro.org wrote: > From: "Mathieu J. Poirier" > > This patch adds keyreset functionality to the sysrq driver. It > allows certain button/key combinations to be used in order to > trigger device resets. > > The first time th

Re: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual

2012-08-30 Thread Dmitry Torokhov
500 > child device prior to requesting an IRQ, but as we're no longer using > Device Tree to collect our IRQ numbers, it's actually better to allow > the core to do this during device registration time. So the IRQ number > we pull from its resource has alrea

Re: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual

2012-08-30 Thread Dmitry Torokhov
On Thu, Aug 30, 2012 at 04:02:21PM -0700, Dmitry Torokhov wrote: > On Thu, Aug 30, 2012 at 02:12:04PM +0100, Lee Jones wrote: > > > Sorry for the delay. Yes, this shoudl be fine, but since it is > > > essentially a revert of the original patch it should be pushed in as >

Re: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 08:31:33AM +0100, Lee Jones wrote: > On Thu, Aug 30, 2012 at 04:03:23PM -0700, Dmitry Torokhov wrote: > > On Thu, Aug 30, 2012 at 04:02:21PM -0700, Dmitry Torokhov wrote: > > > On Thu, Aug 30, 2012 at 02:12:04PM +0100, Lee Jones wrote: > > > &

Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 11:02:27PM +0100, Alan Cox wrote: > > > Why do we need to involve a platform device and not use, for example, a > > > module > > > parameter, that could be set up from userspace? > > > > The platform device comes from the original design and was included to > > minimise th

Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 04:57:04PM -0600, Mathieu Poirier wrote: > On 12-08-31 04:41 PM, Dmitry Torokhov wrote: > > On Fri, Aug 31, 2012 at 11:02:27PM +0100, Alan Cox wrote: > >>>> Why do we need to involve a platform device and not use, for example, a > >>>&

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-09-04 Thread Dmitry Torokhov
Hi Vojtech, On Tue, Aug 14, 2012 at 12:11:54AM +0200, Vojtech Bocek wrote: > Initial input event has not yet arrived in joydev_connect() > where values are set, which means default values of input_absinfo > are used for init event, not the actual values from joystick. So what guarantees that joys

Re: [PATCH] input: gpio_keys_polled: fix dt pdata->nbuttons

2012-09-12 Thread Dmitry Torokhov
On Wed, Sep 12, 2012 at 06:27:23PM -0300, Alexandre Pereira da Silva wrote: > pdata->nbuttons should be updated by the dt code. > > Signed-off-by: Alexandre Pereira da Silva Applied, thank you Alexandre. > --- > drivers/input/keyboard/gpio_keys_polled.c |1 + > 1 file changed, 1 insertion

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-09-12 Thread Dmitry Torokhov
On Wed, Sep 05, 2012 at 10:09:57PM +0200, Vojtěch Boček wrote: > Hi, > > 2012/9/5 Dmitry Torokhov > > So what guarantees that joystick events will arrive in time, before > > joydev_generate_startup_event() is called? It looks like your solution > > is racy... > &

Re: [PATCH v3 01/20] Input: Break out MT data

2012-09-12 Thread Dmitry Torokhov
On Sat, Sep 01, 2012 at 09:46:56PM +0200, Henrik Rydberg wrote: > Move all MT-related things to a separate place. This saves some > bytes for non-mt input devices, and prepares for new MT features. > > Signed-off-by: Henrik Rydberg ... > @@ -1287,10 +1284,8 @@ struct input_dev { > > int r

  1   2   3   4   5   6   7   8   9   10   >