On Tue, Mar 27, 2007 at 07:23:16AM -0600, Eric W. Biederman wrote:
> I guess I should add that I'm not certain that the code is exactly correct
> there are weird differences between enable/disable and mask.
My understanding was "enable" would clear (or ignore) pending interrupts
and "unmask" would
On Mon, Mar 26, 2007 at 04:18:22PM -0700, Mitch Williams wrote:
> This patch fixes a kernel bug which is triggered when using the
> irqbalance daemon with MSI-X hardware.
>
> Because both MSI-X interrupt messages and MSI-X table writes are posted,
> it's possible for them to cross while in-flight.
On Sat, Mar 31, 2007 at 04:27:46PM +0530, Milind Arun Choudhary wrote:
> Clean up ROUND_?UP, Use ALIGN where ever appropriate.
>
> Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]>
Milind,
Looks good to me.
Signed-off-by: Grant Grundler <[EMAIL PROTECTED]>
Kyle,
On Sun, Apr 01, 2007 at 01:06:46PM +0530, Milind Arun Choudhary wrote:
> ROUND_UP macro cleanup, use ALIGN where ever appropriate
>
> Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]>
Also looks good to me. Just one white space nit we can fixup by hand.
Signed-off-by:
On Wed, Oct 21, 2015 at 2:00 AM, Ulf Hansson wrote:
To put a few more numbers on the "chunk size vs perf":
1EG (512KB) -> 44K commands -> ~20 minutes
32EG (16MB) -> 1375 commands -> ~1 minute
128EG (64MB) -> 344 commands -> ~30 seconds
8191EG (~4GB) -> 6 commands ->
On Tue, Oct 20, 2015 at 11:57 AM, Jeff Moyer wrote:
> Hi Grant,
>
> Grant Grundler writes:
>
>> Ping? Does no one care how long BLK_SECDISCARD takes?
>>
>> ChromeOS has landed this change as a compromise between "fast" (<10
>> seconds) and &quo
[resending text-only]
On Wed, Sep 2, 2015 at 3:07 PM, Grant Grundler wrote:
>
>
> On Wed, Sep 2, 2015 at 11:28 AM, Olof Johansson wrote:
> ...
>> > +/**
>> > + * struct mmc_ioc_combo_cmd - combo command information
>> > + * @num_of_cmds: number of comm
on as this seems to make
> sense. However, I left num_of_cmds as an 8-bit value unless someone has
> a need for more than 256 commands ;-)
Awesome - thanks! I saw that in the new version you posted. LGTM.
You or Ulf can add "Reviewed by: Grant Grundler http://vger.kernel.org/majordomo-inf
roblem if we care about data privacy since
consumers won't expect a "secure erase" operation to take 1/2h or more
and think the device is hung.
cheers,
grant
On Mon, Sep 28, 2015 at 2:45 PM, Grant Grundler wrote:
> [resending...I forgot to switch gmail back to text-only mode.
Hi Ryan!
Just some questions inline - in general I like the reset function.
On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee wrote:
>
> Signed-off-by: Ryan Lee
> ---
> Changes : Created max98373_reset function to minimize code duplication.
>Changed regmap_write to regmap_update_bits. Othe
I just realized I had one more question...
On Mon, Nov 26, 2018 at 6:24 PM Grant Grundler wrote:
>
> Hi Ryan!
>
> Just some questions inline - in general I like the reset function.
>
> On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee
> wrote:
> >
> > Signed-off-b
On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee wrote:
>
> >-Original Message-
> >From: Mark Brown
> >Sent: Wednesday, November 28, 2018 1:50 AM
> >To: Ryan Lee
> >Cc: Liam Girdwood ; Jaroslav Kysela
> >; Takashi Iwai ; Grant Grundler
> >; Kun
On Tue, Apr 20, 2021 at 11:02 AM Sakari Ailus
wrote:
>
> Hi Bingbu,
>
> Thanks for the patch.
>
> On Tue, Apr 20, 2021 at 10:48:33AM +0800, Bingbu Cao wrote:
> > Intel IPU(Image Processing Unit) has its own (IO)MMU hardware,
> > The IPU driver allocates its own page table that is not mapped
> > vi
[+jejb to cc]
On Tue, Sep 25, 2007 at 04:58:43PM -0700, [EMAIL PROTECTED] wrote:
> This is a followup to http://lkml.org/lkml/2007/8/24/280
>
> Despite Grant's desire for a more elegant solution, there's
> not much new here. I moved the API change from pci.h to
> dma-mapping.h and removed the p
On Thu, Sep 27, 2007 at 06:13:02PM -0700, [EMAIL PROTECTED] wrote:
>
> Document dma_flags_set_dmabarrier().
>
> Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]>
This looks really good!
thanks,
grant
Acked-by: Grant Grundler <[EMAIL PROTECTED]>
>
I'd like to get rid of
> de4x5_strncmp since it is not, in fact, a strncmp.
+1 I think your analysis is correct. The function appears to be
checking against a black list of MAC addresses that has two "broken"
devices MAC addresses.
Acked-by: Grant Grundler
thanks,
grant
us mistake.
Acked-by: Grant Grundler
>
> ---
> The semantic patch is difficult to summarize, but is available in the cover
> letter of this patch series.
>
> drivers/net/ethernet/dec/tulip/dmfe.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Sun, Dec 7, 2014 at 11:20 AM, Julia Lawall wrote:
> Replace a misspelled function name by %s and then __func__.
Patch is correct but this commit message is not. Please correct and
add my Ack-by.
cheers,
grant
> This was done using Coccinelle, including the use of Levenshtein distance,
> as p
On Thu, Apr 26, 2018 at 12:56 AM, Krzysztof Kozlowski wrote:
> On Thu, Apr 26, 2018 at 2:40 AM, Grant Grundler wrote:
>> On Wed, Apr 25, 2018 at 2:54 AM, Krzysztof Kozlowski
>> wrote:
>>>
>>> commit 90841047a01b452cc8c3f9b990698b264143334a upstream
>>>
t;
> Signed-off-by: Grant Grundler
> Reviewed-by: Douglas Anderson
> Signed-off-by: David S. Miller
> [krzk: Rebase on v4.4]
> Signed-off-by: Krzysztof Kozlowski
thanks krzk!
FTR, to support RTL8153B (HW ID 0x6010), the follow patch series to
bring r8152 v1.09.9 driver from 4.14 ke
+nic_swsd [adding per Realtek developer team request]
On Sat, Jan 16, 2021 at 5:26 AM Grant Grundler wrote:
>
> Several error paths in bind/probe code will only emit
> output using dev_dbg. But if we are going to fail the
> bind/probe, emit related output with "err" prior
+nic_swsd [adding per Realtek developer team request]
On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote:
>
> Errors in protocol should be logged when the driver aborts operations.
> If the driver can carry on and "humor" the device, then emitting
> the message as debu
+nic_swsd [adding per Realtek developer team request]
On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote:
>
> RTL8156 sends notifications about every 32ms.
> Only display/log notifications when something changes.
>
> This issue has been reported by others:
> https://
On Tue, Jan 19, 2021 at 9:46 PM Jakub Kicinski wrote:
>
> On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote:
> > RTL8156 sends notifications about every 32ms.
> > Only display/log notifications when something changes.
> >
> > This issue has been repor
On Wed, Jan 20, 2021 at 12:55 AM Grant Grundler wrote:
>
> On Tue, Jan 19, 2021 at 9:46 PM Jakub Kicinski wrote:
> >
> > On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote:
> > > RTL8156 sends notifications about every 32ms.
> > > Only display/log
mbit/s uplink
...
Chrome OS cannot support RTL8156 until this is fixed.
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ncm.c | 12 +++-
include/linux/usb/usbnet.h | 2 ++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cd
On Wed, Jan 20, 2021 at 1:05 AM Jakub Kicinski wrote:
>
> On Wed, 20 Jan 2021 00:59:17 + Grant Grundler wrote:
> > > > Thanks for the patch, this looks like an improvement over:
> > > >
> > > > 59b4a8fa27f5 ("CDC-NCM: remove "connected"
On Wed, Jan 20, 2021 at 5:04 PM Jakub Kicinski wrote:
>
> On Wed, 20 Jan 2021 03:38:32 + Hayes Wang wrote:
> > Grant Grundler
> > > Sent: Wednesday, January 20, 2021 9:12 AM
> > > Subject: [PATCH net] net: usb: cdc_ncm: don't spew notifications
> >
This series introduces support for USB network devices that report
speed as a part of their protocol, not emulating an MII to be accessed
over MDIO.
v2: rebased on recent upstream changes
v3: incorporated hints on naming and comments
v4: fix misplaced hunks; reword some commit messages;
add sa
ed on upstream
v3: changed names and made clear which units are used
v4: moved hunks to correct patch; rewrote commmit messages
Signed-off-by: Oliver Neukum
Tested-by: Roland Dreier
Reviewed-by: Grant Grundler
Tested-by: Grant Grundler
---
drivers/net/usb/usbnet.c
replaces the one
recently submitted in de658a195ee23ca6aaffe197d1d2ea040beea0a2 :
"net: usb: cdc_ncm: don't spew notifications"
v2: rebased on upstream
v3: changed variable names
v4: rewrote commit message
Signed-off-by: Oliver Neukum
Tested-by: Roland Dreier
Signed-off-by:
From: Grant Grundler
Until very recently, the usbnet framework only had support functions
for devices which reported the link speed by explicitly querying the
PHY over a MDIO interface. However, the cdc_ether devices send
notifications when the link state or link speeds change and do not
expose
rename
the existing functions with _mii suffix.
v2: rebased on changed upstream
v3: changed names to clearly say that this does NOT use phylib
v4: moved hunks to correct patch; reworded commmit messages
Signed-off-by : Oliver Neukum
Tested-by: Roland Dreier
Reviewed-by: Grant Grundler
Tested-by
[Key part of Andew's reply: "Yes, this discussion should not prevent
this patchset from being merged."]
On Tue, Apr 6, 2021 at 1:00 PM Andrew Lunn wrote:
>
> > > Speed: 2500Mb/s and Duplex: Half is very unlikely. You really only
> > > ever see 10 Half and occasionally 100 Half. Anything above tha
This series introduces support for USB network devices that report
speed as a part of their protocol, not emulating an MII to be accessed
over MDIO.
v2: rebased on recent upstream changes
v3: incorporated hints on naming and comments
v4: fix misplaced hunks; reword some commit messages;
add sa
ed on upstream
v3: changed names and made clear which units are used
v4: moved hunks to correct patch; rewrote commmit messages
Signed-off-by: Oliver Neukum
Tested-by: Roland Dreier
Reviewed-by: Grant Grundler
Tested-by: Grant Grundler
Reviewed-by: Andrew Lunn
---
drivers/net/usb/usbnet.c
replaces the one
recently submitted in de658a195ee23ca6aaffe197d1d2ea040beea0a2 :
"net: usb: cdc_ncm: don't spew notifications"
v2: rebased on upstream
v3: changed variable names
v4: rewrote commit message
Signed-off-by: Oliver Neukum
Tested-by: Roland Dreier
Signed-off-by:
framework to use the new functions to get link speed/state.
User space can now get the most recent link speed/state using ethtool.
v4: added to series since cdc_ether uses same notifications
as cdc_ncm driver.
Signed-off-by: Grant Grundler
Reviewed-by: Andrew Lunn
---
drivers/net/usb
rename
the existing functions with _mii suffix.
v2: rebased on changed upstream
v3: changed names to clearly say that this does NOT use phylib
v4: moved hunks to correct patch; reworded commmit messages
Signed-off-by : Oliver Neukum
Tested-by: Roland Dreier
Reviewed-by: Grant Grundler
Tested-by
On Tue, Mar 30, 2021 at 2:17 AM Grant Grundler wrote:
>
> This series introduces support for USB network devices that report
> speed as a part of their protocol, not emulating an MII to be accessed
> over MDIO.
>
> v2: rebased on recent upstream changes
> v3: incorporate
On Tue, Apr 6, 2021 at 12:09 AM Andrew Lunn wrote:
>
> On Mon, Apr 05, 2021 at 04:13:40PM -0700, Grant Grundler wrote:
> > This series introduces support for USB network devices that report
> > speed as a part of their protocol, not emulating an MII to be accessed
> &g
Errors in protocol should be logged when the driver aborts operations.
If the driver can carry on and "humor" the device, then emitting
the message as debug output level is fine.
Signed-off-by: Grant Grundler
---
drivers/net/usb/usbnet.c | 2 +-
1 file changed, 1 insertion(+),
Several error paths in bind/probe code will only emit
output using dev_dbg. But if we are going to fail the
bind/probe, emit related output with "err" priority.
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ncm.c | 10 +-
1 file changed, 5 insertions(+), 5
Several error paths in bind/probe code will only emit
output using dev_dbg. But if we are going to fail the
bind/probe, emit related output with "err" priority.
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ncm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletion
mbit/s uplink
...
Chrome OS cannot support RTL8156 until this is fixed.
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ncm.c | 12 +++-
include/linux/usb/usbnet.h | 2 ++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cd
Errors in protocol should be logged when the driver aborts operations.
If the driver can carry on and "humor" the device, then emitting
the message as debug output level is fine.
Signed-off-by: Grant Grundler
---
drivers/net/usb/usbnet.c | 2 +-
1 file changed, 1 insertion(+),
all and large page entries
> in exynos_iommu_unmap(). Missing cache flush of removed page table
> entries can cause missing page fault interrupt when a master IP
> accesses an unmapped area.
>
> Reviewed-by: Tomasz Figa
> Tested-by: Grant Grundler
> Signed-off-by: Cho KyongHo
On Thu, Mar 13, 2014 at 10:13 PM, Cho KyongHo wrote:
> This commit introduces sysmmu_pte_t for page table entries and
> sysmmu_iova_t vor I/O virtual address that is manipulated by
> exynos-iommu driver. The purpose of the typedef is to remove
> dependencies to the driver code from the change of C
On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa wrote:
...
> No. Proper Linux drivers must support deferred probing mechanism and there
> should be no assumptions about probing orders. Using other initcall level
> than module_initcall for particular drivers is strongly discouraged.
That's true for "
On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa wrote:
...
>> Device driver is not only for the scholarship but also for the real use.
>
> Huh? I'm not sure what kind of comment is this.
I'm guessing Cho meant: "This isn't an academic exercise - I have a
real use case that requires reference countin
On Wed, Mar 19, 2014 at 10:30 AM, Tomasz Figa wrote:
...
> As I said, AFAIK the trend is to get rid of ordering by initcalls and make
> sure that drivers can handle missing dependencies properly, even for
> "services" such as DMA, GPIO, clocks and so on, which after all are provided
> by normal dr
e case that REMOTE_WAKEUP feature doesn't
>> be set when system suspend. In this case, the PHY power will not be turned
>> on again when system resume, so the HW reset must be added in the resume
>> function.
>>
>> Signed-off-by: Freddy Xin
>> Tested-by: Gr
On Tue, Mar 4, 2014 at 4:01 AM, Hayes Wang wrote:
> Reset and reinitialize the device when the tx timeout occurs.
Hayes,
I believe this patch was dropped after the series was split.
Can you please repost this patch by itself?
(and fix the "function" typo in the patch header)
>
> Signed-off-by:
Hi Ondrej,
On Sat, Jun 21, 2014 at 1:29 PM, Ondrej Zary wrote:
> Poll link status every 2 seconds instead of 60 for ADMtek Comet chips.
Why use 2 seconds for the polling interval?
I'm sure you have a good reason for this and it should be in the
commit message or as a comment in the code.
I oth
On Wed, May 21, 2014 at 2:32 AM, Arnd Bergmann wrote:
> On Wednesday 21 May 2014 11:02:45 Thierry Reding wrote:
>> On Wed, May 21, 2014 at 10:54:42AM +0200, Arnd Bergmann wrote:
>>
>> > Right. As long as we always unmap the buffers from the IOMMU after they
>> > have stopped being in use, it's ver
the required quirks in general (lightly tested).
o "parrot" (Acer C7 Chromebook) which uses the SDHCI_QUIRK2_BROKEN_UHS
quirk: disables ADMA mode, and adds a delay after power.
Signed-off-by: Stephen Hurd
Signed-off-by: Grant Grundler
---
drivers/mmc/host/sdhci-
ttp://coccinelle.lip6.fr/)
>
> //
> @@
> statement S;
> @@
>
> - if (!netdev_priv(...)) S
> //
>
> Signed-off-by: Julia Lawall
Acked-by: Grant Grundler
cheers,
grant
>
> ---
> drivers/net/ethernet/dec/tulip/uli526x.c |6 --
> 1 file changed,
, the iommu domain maintains a list of iommu devices which are
> attached. This driver relies on the iommu core to ensure that all devices
> have detached before destroying a domain.
>
> Signed-off-by: Daniel Kurtz
> Signed-off-by: Simon Xue
Reviewed-by: Grant Grundler
On Wed, May 4, 2016 at 6:51 AM, Rob Herring wrote:
...
>> +Required properties:
>> +
>> + compatible: Must be "atmel,atmegaxx_captouch".
>
> No wildcards in the compatible strings. Use the specific devices.
>
> Also, use hyphen rather than underscore. However, if the device is only
> a tou
On Fri, May 6, 2016 at 2:19 AM, Nicolas Ferre wrote:
...
> Is it different from the Atmel QT1070 or QT2160 which have drivers
> already available in Linux: drivers/input/keyboard/qt1070.c
Yes. What Daniel said. I would describe it as "probe code and
interrupt handling protocol are different" f
On Mon, May 9, 2016 at 9:29 AM, Dmitry Torokhov
wrote:
> On Fri, May 06, 2016 at 11:14:12PM +0800, Daniel Hung-yu Wu wrote:
>> The register set is different, and this chip does not support calibration.
>> The I2C protocol is not the same as well; there is an additional byte
>> indicating data leng
Add I2C driver for AtmegaXX capacitive touch device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
.../bindings/input/atmel,atmegaxx_captouch.txt | 34 +++
drivers/input/misc/Kconfig | 11 +
drivers/input/misc/Makefile| 1
Ping? Did this change get accepted?
cheers,
grant
On Tue, Apr 5, 2016 at 12:07 PM, Grant Grundler wrote:
> On Mon, Apr 4, 2016 at 5:37 PM, Guenter Roeck wrote:
>> The Qualcom watchdog timer block reports if the system was reset by the
>> watchdog. Pass the information to user
On Tue, May 3, 2016 at 7:01 PM, Guenter Roeck wrote:
> On 05/03/2016 06:36 PM, Grant Grundler wrote:
>>
>> Ping? Did this change get accepted?
>>
>
> Hi Grant,
>
> Should be. It is in my watchdog-next branch. I plan to send
> a pull request to Wim early next w
On Wed, May 4, 2016 at 6:51 AM, Rob Herring wrote:
> On Tue, May 03, 2016 at 10:13:31AM -0700, Grant Grundler wrote:
>> Add I2C driver for AtmegaXX capacitive touch device.
>>
>> Signed-off-by: Hung-yu Wu
>> Signed-off-by: Grant Grundler
>> ---
>> .../bin
From: Daniel Hung-yu Wu
Add I2C driver for Atmel Capacitive Touch Button device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
drivers/input/misc/Kconfig | 11 ++
drivers/input/misc/Makefile | 1 +
drivers/input/misc/atmel_captouch.c | 287
From: Daniel Hung-yu Wu
Add binding for Atmel Capacitive Touch Button device.
Signed-off-by: Daniel Hung-yu Wu
Signed-off-by: Grant Grundler
---
.../devicetree/bindings/input/atmel,captouch.txt | 34 ++
1 file changed, 34 insertions(+)
create mode 100644 Documentation
From: Daniel Hung-yu Wu
Add I2C driver for Atmel Capacitive Touch Button device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
drivers/input/misc/Kconfig | 13 ++
drivers/input/misc/Makefile | 1 +
drivers/input/misc/atmel_captouch.c | 287
On Wed, May 18, 2016 at 2:59 PM, Dmitry Torokhov
wrote:
> On Tue, May 17, 2016 at 12:29:32PM -0700, Grant Grundler wrote:
>> From: Daniel Hung-yu Wu
>>
>> Add I2C driver for Atmel Capacitive Touch Button device.
>>
>> Signed-off-by: Hung-yu Wu
>> Sig
On Wed, May 18, 2016 at 2:59 PM, Dmitry Torokhov
wrote:
> On Wed, May 18, 2016 at 11:44:04AM -0500, Rob Herring wrote:
>> On Mon, May 16, 2016 at 01:54:53PM -0700, Grant Grundler wrote:
>> > From: Daniel Hung-yu Wu
>> >
>> > Add binding for Atmel Capacitive T
Ping? Any additional feedback?
We've been holding off putting this code into ChromeOS since I'm happy
to integrate (just about) any addtional feedback on the code or DT
entries.
thanks!
grant
On Tue, May 10, 2016 at 7:07 PM, Grant Grundler wrote:
> From: Daniel Hung-yu Wu
>
[plain text this time...]
On Sat, May 14, 2016 at 9:35 AM, Wim Van Sebroeck wrote:
>
> Hi Guenter,
>
> > The Qualcom watchdog timer block reports if the system was reset by the
> > watchdog. Pass the information to user space.
> >
> > Cc: Grant Grundler
On Sat, May 14, 2016 at 7:52 AM, Rob Herring wrote:
> On Tue, May 10, 2016 at 07:07:48PM -0700, Grant Grundler wrote:
>> From: Daniel Hung-yu Wu
>>
>> Add binding for Atmel Capacitive Touch Button device.
>>
>> Signed-off-by: Daniel Hung-yu Wu
From: Daniel Hung-yu Wu
Add binding for Atmel Capacitive Touch Button device.
Signed-off-by: Daniel Hung-yu Wu
Signed-off-by: Grant Grundler
---
.../devicetree/bindings/input/atmel,captouch.txt | 36 ++
1 file changed, 34 insertions(+)
create mode 100644 Documentation
From: Daniel Hung-yu Wu
Add I2C driver for Atmel Capacitive Touch Button device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
drivers/input/misc/Kconfig | 13 ++
drivers/input/misc/Makefile | 1 +
drivers/input/misc/atmel_captouch.c | 287
From: Grant Grundler
I haven't had any PCI tulip HW for the past ~5 years. I have
been reviewing tulip patches and can continue doing that.
Signed-off-by: Grant Grundler
---
I'm also proposing to add linux-parisc to the list since AFAIK, all
parisc systems but the C8000 workstatio
On Thu, Nov 19, 2015 at 6:29 PM, Florian Fainelli wrote:
> On 19/11/15 17:56, Grant Grundler wrote:
>> From: Grant Grundler
>>
>> I haven't had any PCI tulip HW for the past ~5 years. I have
>> been reviewing tulip patches and can continue doing that.
>
On Tue, Dec 1, 2015 at 12:44 PM, Helge Deller wrote:
> On 01.12.2015 17:41, Bjorn Helgaas wrote:
>> There are no callers of pcibios_init_bus(), so remove it.
>
> True, pcibios_init_bus() isn't called anywhere, so it should be removed.
>
> But I wonder if we might need to initialize latency and par
On Thu, Sep 10, 2015 at 1:24 AM, Jon Hunter wrote:
...
>> - you have some implicit padding after the structure and should replace that
>> with explictit pad bytes to extend the structure to a multiple of its
>> alignment (8 bytes).
>
> Would padding with __u32 at the end be sufficient here? I
On Thu, Sep 10, 2015 at 11:20 AM, Jon Hunter wrote:
>
> On 10/09/15 18:10, Grant Grundler wrote:
...
>>>>>> struct mmc_ioc_multi_cmd {
>>>>>> __u64 num_of_cmds;
>>>>>> struct mmc_ioc_cmd cmds[0];
>>>>>> };
&
icient).
>
> Signed-off-by: Seshagiri Holi
> Cc: Arnd Bergmann
> Cc: Grant Grundler
Reviewed-by: Grant Grundler
One comment below. two actually. ;)
> Cc: Olof Johansson
> [ jonath...@nvidia.com: Rebased on linux-next from v3.18. Changed
> userspace pointer type for mult
se that default but no
> longer warn about it.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Grant Grundler
thanks!
grant
> diff --git a/drivers/net/ethernet/dec/tulip/winbond-840.c
> b/drivers/net/ethernet/dec/tulip/winbond-840.c
> index 6aa887e0e1cb..9beb3d34d4ba 100644
>
On Mon, Apr 4, 2016 at 5:37 PM, Guenter Roeck wrote:
> The Qualcom watchdog timer block reports if the system was reset by the
> watchdog. Pass the information to user space.
>
> Cc: Grant Grundler
> Signed-off-by: Guenter Roeck
Reviewed-by: Grant Grundler
Tested-by: Grant Gr
>
> Signed-off-by: Seshagiri Holi
> Cc: Arnd Bergmann
> Cc: Grant Grundler
> Cc: Olof Johansson
> [ jonath...@nvidia.com: Rebased on linux-next from v3.18. Changed
> userspace pointer type for multi command to be a u64. Renamed
> from combo commands to multi com
Awesome! Thanks Ulf! :)
cheers
grant
On Mon, Oct 5, 2015 at 3:55 AM, Ulf Hansson wrote:
> On 24 September 2015 at 03:30, Grant Grundler wrote:
>> MMC_IOC_CMD and MMC_IOC_MULTI_CMD ioctl() code currently bails on
>> any eMMC errors. However, in case there is any resp[] dat
On Fri, Nov 6, 2015 at 4:22 AM, Vishnu Pratap Singh
wrote:
> This patch handles blk_register_region() return value.
> Earlier blk_register_region() function doesn't handle error
> cases, now it is added, so the callers of this function
> should also handle it.
>
> Verfied on X86 based ubuntu machi
ion of function 'usleep_range'
[-Werror,-Wimplicit-function-declaration]
usleep_range(1, 11000);
^
Including delay.h "fixes" this.
Signed-off-by: Grant Grundler
---
sound/soc/codecs/max98373.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/c
[resending as plain/text - sorry]
On Fri, Sep 7, 2018 at 10:52 AM Grant Grundler wrote:
>
>
>
> On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote:
>>
>> On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote:
>> > Commit ca917f9fe1a0fab added use o
On Fri, Sep 7, 2018 at 10:56 AM Mark Brown wrote:
>
> On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote:
> > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote:
>
> > > Note that this isn't causing a warning upstream, presumably due to an
> > > im
Local "#define DRIVER_LICENSE" obfuscates which license is used
in MODULE_LICENSE(). "fgrep -R MODULE_LICENSE" is more informative
when the string is hard coded in MODULE_LICENSE.
Signed-off-by: Grant Grundler
---
Most of the kernel already uses hard coded strings.
The few p
On Fri, Jul 15, 2016 at 2:25 PM, David Miller wrote:
> From: Grant Grundler
> Date: Thu, 14 Jul 2016 11:27:16 -0700
>
>> ethtool -i provides a driver version that is hard coded.
>> Export the same value via "modinfo".
>>
>> Signed-off-by: Grant Gr
On Thu, Jun 2, 2016 at 5:27 PM, Gwendal Grignou wrote:
> If available, eMMC stack uses HC_ERASE_GRP_SIZE as preferred erase size.
> However, that size is the minimal size we must use, not the optimal size.
> Calculate the optimal size based on whole device size and fall back to
> HC_ERASE_GRP_SIZE
ethtool -i provides a driver version that is hard coded.
Export the same value via "modinfo".
Signed-off-by: Grant Grundler
---
drivers/net/usb/r8152.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 0da72d3..1c01ed5 10
[as plain text this time...]
Robert,
On Mon, Jul 25, 2016 at 10:40 AM, wrote:
> From: Grant Grundler
For the record, I believe I am not the author of these patches.
I believe the original author is
Signed-off-by: Freddy Xin
as recorded in the following code reviews (and testing) t
On Mon, Jul 25, 2016 at 10:40 AM, wrote:
> From: Vincent Palatin
>
> Check the answers from the USB stack and avoid re-sending multiple times
> the request if the device has disappeared.
>
> Signed-off-by: Vincent Palatin
The original chromium.org code review:
https://chromium-review.googl
-review.googlesource.com/#/q/Fix+AX88772x+resume+failures
And has substantial meta data regarding author and reviewers:
(summarized from https://chromium-review.googlesource.com/#/c/314520/)
Signed-off-by: Allan Chou
Signed-off-by: WK Tsai
Tested-by: Grant Grundler
Reviewed-by: Wang-Kai Tsai
On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss wrote:
...
> Thanks for the feedback (for this patch and the other ones)!
> I'm preparing a v2 and will submit it withing a day or two.
Excellent! very welcome and thanks again for picking this up.
...
>> FTR, current drivers/net/usb/ax88179_178a.c u
Hayes Wang realtek.com> writes:
> Replace using VID/PID with using tp->version to initialize the ops.
Hayes,
This patch breaks new HW with existing drivers. more below.
>
> Signed-off-by: Hayes Wang realtek.com>
> ---
> drivers/net/usb/r8152.c | 79 ++--
[resending as plain text only - sorry]
Ping? Any feedback on this patch?
LGTM.
cheers,
grant
On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke wrote:
> 'perms' will never be NULL since it isn't a plain pointer but an array
> of u32 values.
>
> This fixes the following warning when building wi
On Thu, Mar 23, 2017 at 5:08 AM, Paul Moore wrote:
> On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler wrote:
>> Ping? Any feedback on this patch?
>
> It's on my list of patches to review, patience please.
No problem! Thank you!
just wanted confirmation it wasn't o
201 - 300 of 328 matches
Mail list logo
