Re: [PATCH] x86: work around clang IAS bug referencing __force_order

2020-08-07 Thread Sedat Dilek
On Fri, Aug 7, 2020 at 12:13 AM Thomas Gleixner wrote: > > Sedat Dilek writes: > > what is the status of this patch? > > Just looked at it. > > > I needed this one to be able to build VirtualBox via DKMS as an > > out-of-tree kernel-module. > > Not be

Re: Linux 5.8-rc6

2020-08-10 Thread Sedat Dilek
On Mon, Aug 10, 2020 at 5:30 PM Geert Uytterhoeven wrote: > > Hi Sedat, > > On Tue, Jul 21, 2020 at 10:19 AM Sedat Dilek wrote: > > You happen to know if I can configure in my ~/.gitconfig to pull > > linux-git stuff from two repositories - check first git.ke

Re: [PATCH] x86/defconfigs/32: Unset 64BIT

2020-08-10 Thread Sedat Dilek
On Mon, Aug 10, 2020 at 5:59 PM Daniel Díaz wrote: > > A recent refresh of the defconfigs got rid of the following > (unset) config: > > # CONFIG_64BIT is not set > > Innocuous as it seems, when the config file is saved again the > behavior is changed so that CONFIG_64BIT=y. > > Currently, > >

Re: [PATCH] x86/defconfigs/32: Unset 64BIT

2020-08-10 Thread Sedat Dilek
On Mon, Aug 10, 2020 at 5:59 PM Daniel Díaz wrote: > > A recent refresh of the defconfigs got rid of the following > (unset) config: > > # CONFIG_64BIT is not set > > Innocuous as it seems, when the config file is saved again the > behavior is changed so that CONFIG_64BIT=y. > > Currently, > >

Re: [PATCH v2] x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig

2020-08-19 Thread Sedat Dilek
pare0' failed > make[1]: *** [prepare0] Error 2 > /oe/build/tmp/work-shared/intel-core2-32/kernel-source/Makefile:185: recipe > for target '__sub-make' failed > make: *** [__sub-make] Error 2 > > Fixes: 1d0e12fd3a84 ("x86/defconfigs: Refresh defconfig fil

Re: depmod fixes for linux-stable releases

2021-01-10 Thread Sedat Dilek
On Sun, Jan 10, 2021 at 11:19 AM Sasha Levin wrote: > > On Sat, Jan 09, 2021 at 05:23:22PM -0800, Linus Torvalds wrote: > >Ack, I think 436e980e2ed5 ("kbuild: don't hardcode depmod path") is > >stable material even if it doesn't fix a bug. > > > >Not only does the fix for that commit not make sens

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Sedat Dilek
On Mon, Jan 11, 2021 at 9:18 AM 'Bill Wendling' via Clang Built Linux wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data is

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Sedat Dilek
On Mon, Jan 11, 2021 at 9:39 AM Sedat Dilek wrote: > > On Mon, Jan 11, 2021 at 9:18 AM 'Bill Wendling' via Clang Built Linux > wrote: > > > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Sedat Dilek
On Mon, Jan 11, 2021 at 10:17 AM Bill Wendling wrote: > > On Mon, Jan 11, 2021 at 12:39 AM Sedat Dilek wrote: > > > > On Mon, Jan 11, 2021 at 9:18 AM 'Bill Wendling' via Clang Built Linux > > wrote: > > > > > > From: Sami Tolvanen

Re: [PATCH v2] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Sedat Dilek
On Tue, Jan 12, 2021 at 6:14 AM 'Bill Wendling' via Clang Built Linux wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data is

Re: [PATCH] mm/mremap: fix BUILD_BUG_ON() error in get_extent

2021-01-12 Thread Sedat Dilek
> CONFIG_UBSAN_UNSIGNED_OVERFLOW. If we want to keep the BUILD_BUG() > around, I think this is fine. Alternatively, turning it into a runtime > check would be fine too. > > Reviewed-by: Nathan Chancellor > I have this patch in my custom 5.11 queue. Feel free to add my: Te

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-12 Thread Sedat Dilek
d require pahole to be installed with an > appropriate version to select and use CONFIG_DEBUG_INFO_BTF, which is > standard for options that require a specific tools version. > > Suggested-by: Sedat Dilek > Signed-off-by: Nathan Chancellor Thanks for the patch, Nathan, Might be good to g

Re: [PATCH v4 2/3] Kbuild: make DWARF version a choice

2021-01-13 Thread Sedat Dilek
On Wed, Jan 13, 2021 at 1:32 AM Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an > explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a > way that's forward compatible with existing configs, and makes adding > future versions more s

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-18 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek wrote: > > > > [ big snip ] > > [More snippage.] > > > [ CC Fangrui ] > > > > With the attached... > > > >[PATCH v3] module: Ig

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-18 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > > > On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek wrote: > > > > > > [ big snip ] > > > > [More snippage.] > &

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-18 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > > > > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > > > >

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Sedat Dilek
On Fri, Jan 8, 2021 at 6:30 AM Al Viro wrote: > > On Tue, Jan 05, 2021 at 11:29:11AM -0700, Jens Axboe wrote: > > Song reported a boot regression in a kvm image with 5.11-rc, and bisected > > it down to the below patch. Debugging this issue, turns out that the boot > > stalled when a task is waiti

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Sedat Dilek
otup > > mainline. Your patch fixes my problem. I haven't done any analysis > > of the code--just testing, thus: > > > > Tested-by: Douglas Anderson > > Thanks, adding your Tested-by. > I have this in my patch-series since it appeared in [1]. Feel free to add my: Tested-by: Sedat Dilek # LLVM/Clang version 11.0.1 - Sedat - [1] https://git.kernel.dk/cgit/linux-block/log/?h=task_work - Sedat -

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Fri, Dec 11, 2020 at 7:46 PM 'Sami Tolvanen' via Clang Built Linux wrote: > > This patch series adds support for building the kernel with Clang's > Link Time Optimization (LTO). In addition to performance, the primary > motivation for LTO is to allow Clang's Control-Flow Integrity (CFI) > to be

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Sat, Jan 9, 2021 at 4:36 PM Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 03:54:20PM +0100, Sedat Dilek wrote: > > I am interested in having Clang LTO (Clang-CFI) for x86-64 working and > > help with testing. > > > > I tried the Git tree mentioned in [3] &

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Sat, Jan 9, 2021 at 5:07 PM Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 04:46:21PM +0100, Sedat Dilek wrote: > > On Sat, Jan 9, 2021 at 4:36 PM Josh Poimboeuf wrote: > > > > > > On Sat, Jan 09, 2021 at 03:54:20PM +0100, Sedat Dilek wrote: > > >

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Sat, Jan 9, 2021 at 5:33 PM Josh Poimboeuf wrote: > > > > > Did you push it (oh ah push it push it really really really good...) > > > > to your remote Git please :-). > > > > > > I thought I already pushed it pretty good ;-) do you not see it? > > > > > > git://git.kernel.org/pub/scm/linux/ker

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Sat, Jan 9, 2021 at 6:06 PM Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 11:03:57AM -0600, Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 05:45:47PM +0100, Sedat Dilek wrote: > > > I tried merging with clang-cfi Git which is based on Linux v5.11-rc2+ > > >

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Sat, Jan 9, 2021 at 6:06 PM Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 11:03:57AM -0600, Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 05:45:47PM +0100, Sedat Dilek wrote: > > > I tried merging with clang-cfi Git which is based on Linux v5.11-rc2+ > > >

depmod fixes for linux-stable releases

2021-01-09 Thread Sedat Dilek
Hi, I was CCed on the "depmod: handle the case of /sbin/depmod without /sbin in PATH" changes to linux-stable releases. Do you mind also pushing...? commit 436e980e2ed526832de822cbf13c317a458b78e1 kbuild: don't hardcode depmod path That was the origin for the depmod follow-up. Thanks. Regards

Re: [PATCH] kbuild: check the minimum compiler version in Kconfig

2021-01-13 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 5:17 AM Masahiro Yamada wrote: > > Paul Gortmaker reported a regression in the GCC version check [1]. > If you use GCC 4.8, the build breaks before showing the error message > "error Sorry, your version of GCC is too old - please use 4.9 or newer." > Hi Masahiro, This pat

Re: [PATCH v4 2/3] Kbuild: make DWARF version a choice

2021-01-13 Thread Sedat Dilek
15 :-). I should ask Mr. Corbet for a LWN subscription. > On Wed, Jan 13, 2021 at 1:24 PM Sedat Dilek wrote: > > > > On Wed, Jan 13, 2021 at 1:32 AM Nick Desaulniers > > wrote: > > > > > > --- a/Makefile > > > +++ b/Makefile > &g

Re: [PATCH v4 2/3] Kbuild: make DWARF version a choice

2021-01-13 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 8:20 AM Sedat Dilek wrote: > > On Thu, Jan 14, 2021 at 12:27 AM Nick Desaulniers > wrote: > > > > Sedat, > > Thanks for testing, and congrats on https://lwn.net/Articles/839772/. > > I always appreciate you taking the time to help test m

Re: [PATCH] Documentation/llvm: Add a section about supported architectures

2021-01-13 Thread Sedat Dilek
reporting issues that come about from it. > Thanks, this was overdue and is definitely helpful for users and developers. For x86 64bit: Reviewed-by: Sedat Dilek Together with "[PATCH] kbuild: check the minimum compiler version in Kconfig" this looks very good to me. /o\ - Sedat

Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 8:55 AM Ilie Halip wrote: > > Hi Masahiro, > > > + #elif defined(__INTEL_COMPILER) > > + /* How to get the version of intel compiler? */ > > + ICC 0 0 0 > > According to Intel documentation[1], this should do the trick: > >

Re: [PATCH v4] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Sedat Dilek
.0.1 *** [ Selfmade LLVM toolchain v11.1.0-rc1 ] dileks@iniza:~/src/linux-kernel/git$ which clang /opt/llvm-toolchain/bin/clang dileks@iniza:~/src/linux-kernel/git$ scripts/cc-version.sh clang Clang 110100 [ LLVM-12 from ] dileks@iniza:~/src/linux-kernel/git$ scripts/cc-version.sh clang-12 Clang 1

Re: [PATCH v4] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 9:41 PM Sedat Dilek wrote: > > On Thu, Jan 14, 2021 at 7:54 PM Masahiro Yamada wrote: > > > > Paul Gortmaker reported a regression in the GCC version check [1]. > > If you use GCC 4.8, the build breaks before showing the error message > > &qu

Re: [PATCH v1.1 11/21] objtool: Move unsuffixed symbol conversion to a helper function

2021-01-14 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 9:55 PM Josh Poimboeuf wrote: > > This logic will also be needed for the CONFIG_CFI_CLANG support. > Good you fixed that in v2. I re-pulled from [1]. - Sedat - [1] https://git.kernel.org/pub/scm/linux/kernel/git/jpoimboe/linux.git/log/?h=objtool-vmlinux > Signed-off-by

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-14 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 8:40 PM Josh Poimboeuf wrote: > > Add support for proper vmlinux.o validation, which will be needed for > Sami's upcoming x86 LTO set. (And vmlinux validation is the future for > objtool anyway, for other reasons.) > > This isn't 100% done -- most notably, crypto still nee

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-14 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 5:51 AM Sedat Dilek wrote: > > On Thu, Jan 14, 2021 at 8:40 PM Josh Poimboeuf wrote: > > > > Add support for proper vmlinux.o validation, which will be needed for > > Sami's upcoming x86 LTO set. (And vmlinux validation is the future for

Re: [PATCH v3 0/2] Kbuild: DWARF v5 support

2020-12-28 Thread Sedat Dilek
On Sun, Dec 27, 2020 at 7:47 PM Sedat Dilek wrote: > > On Fri, Dec 4, 2020 at 2:13 AM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > sigh...I ran a broken script to send the series which doesn't cc folks > > properly. > > + lkm

Re: Linux 5.11-rc1

2020-12-28 Thread Sedat Dilek
On Mon, Dec 28, 2020 at 9:04 AM Sedat Dilek wrote: > > On Mon, Dec 28, 2020 at 8:30 AM Sedat Dilek wrote: > > > > [ Please CC me I am not subscribed to LKML and linux-kbuild ML ] > > > > Hi Linus, Hi Mashiro, > > > > thanks for the Linux v5.11-rc1 relea

Re: Linux 5.11-rc1

2020-12-28 Thread Sedat Dilek
[ Please CC me I am not subscribed to LKML and linux-kbuild ML ] Hi Linus, I also tested with LLVM toolchain v11.0.1-rc2 together with passing LLVM=1 and LLVM_IAS=1 to my make line. I had one ERROR: error: too few operands for instruction in arch/x86/kvm/svm/sev.c The issue was reported in Cla

Re: Linux 5.11-rc1

2020-12-28 Thread Sedat Dilek
On Mon, Dec 28, 2020 at 8:45 PM Linus Torvalds wrote: > > On Mon, Dec 28, 2020 at 7:26 AM Sedat Dilek wrote: > > > > I also tested with LLVM toolchain v11.0.1-rc2 together with passing > > LLVM=1 and LLVM_IAS=1 to my make line. > > > > I had one ERROR:

Re: Linux 5.11-rc1

2020-12-28 Thread Sedat Dilek
On Mon, Dec 28, 2020 at 8:40 PM Linus Torvalds wrote: > > On Mon, Dec 28, 2020 at 12:04 AM Sedat Dilek wrote: > > > > > $ dpkg -L kmod | grep bin | grep depmod > > > /sbin/depmod > > > > > > $ which depmod > > > [ empty ] > > >

Re: [PATCH v3 0/2] Kbuild: DWARF v5 support

2020-12-31 Thread Sedat Dilek
On Mon, Dec 28, 2020 at 4:15 PM Sedat Dilek wrote: > > On Sun, Dec 27, 2020 at 7:47 PM Sedat Dilek wrote: > > > > On Fri, Dec 4, 2020 at 2:13 AM 'Nick Desaulniers' via Clang Built > > Linux wrote: > > > > > > sigh...I ran a broken script to se

Re: Linux 5.11-rc1

2020-12-27 Thread Sedat Dilek
[ Please CC me I am not subscribed to LKML and linux-kbuild ML ] Hi Linus, Hi Mashiro, thanks for the Linux v5.11-rc1 release. With a new release I always do my first builds with my distro's default compiler and linker (GCC v10.2.1 and GNU/ld BFD v2.35.1). ( It's approx. 40% faster than LLVM too

Re: Linux 5.11-rc1

2020-12-28 Thread Sedat Dilek
On Mon, Dec 28, 2020 at 8:30 AM Sedat Dilek wrote: > > [ Please CC me I am not subscribed to LKML and linux-kbuild ML ] > > Hi Linus, Hi Mashiro, > > thanks for the Linux v5.11-rc1 release. > > With a new release I always do my first builds with my distro's >

Re: linux-next: build failure after merge of the tip tree

2021-03-23 Thread Sedat Dilek
On Mon, Mar 22, 2021 at 4:39 AM Stephen Rothwell wrote: > > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > arch/x86/net/bpf_jit_comp.c: In function 'arch_prepare_bpf_trampoline': > arch/x86/net/bpf_jit_comp.c:2015:16: error: 'ideal_no

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-23 Thread Sedat Dilek
On Mon, Mar 22, 2021 at 1:13 PM Jiri Kosina wrote: > > On Sat, 13 Mar 2021, Luca Coelho wrote: > > > > > > > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with > > > > > > > > > hard IRQs > > > > > > > > > disabled (e.g. from LED core). We can't enable BHs in such a > > > > > > >

Re: [PATCH v2] sched: Optimize __calc_delta.

2021-03-04 Thread Sedat Dilek
On Thu, Mar 4, 2021 at 6:34 PM 'Nick Desaulniers' via Clang Built Linux wrote: > > On Wed, Mar 3, 2021 at 2:48 PM Josh Don wrote: > > > > From: Clement Courbet > > > > A significant portion of __calc_delta time is spent in the loop > > shifting a u64 by 32 bits. Use `fls` instead of iterating. >

Re: [PATCH v2] sched: Optimize __calc_delta.

2021-03-04 Thread Sedat Dilek
On Thu, Mar 4, 2021 at 7:24 PM Sedat Dilek wrote: > > On Thu, Mar 4, 2021 at 6:34 PM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > On Wed, Mar 3, 2021 at 2:48 PM Josh Don wrote: > > > > > > From: Clement Courbet > > > > &

Re: [xhci] usb 4-1: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd

2021-03-05 Thread Sedat Dilek
On Fri, Mar 5, 2021 at 5:07 PM Alan Stern wrote: > > On Fri, Mar 05, 2021 at 01:09:16PM +0100, Sedat Dilek wrote: > > On Mon, Mar 1, 2021 at 4:53 PM Alan Stern wrote: > > [ ... ] > > > You can use usbmon on bus 4 to record the USB traffic. It may indicate

Re: [xhci] usb 4-1: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd

2021-03-05 Thread Sedat Dilek
On Fri, Mar 5, 2021 at 8:05 PM Sedat Dilek wrote: > > On Fri, Mar 5, 2021 at 5:07 PM Alan Stern wrote: > > > > On Fri, Mar 05, 2021 at 01:09:16PM +0100, Sedat Dilek wrote: > > > On Mon, Mar 1, 2021 at 4:53 PM Alan Stern > > > wrote: > > > [ ... ]

Re: [xhci] usb 4-1: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd

2021-03-05 Thread Sedat Dilek
On Fri, Mar 5, 2021 at 8:25 PM Alan Stern wrote: > > On Fri, Mar 05, 2021 at 08:05:49PM +0100, Sedat Dilek wrote: > > On Fri, Mar 5, 2021 at 5:07 PM Alan Stern wrote: > > > > Don't worry about trying to decode the output. To me it looks like the > > >

Re: [xhci] usb 4-1: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd

2021-03-05 Thread Sedat Dilek
On Fri, Mar 5, 2021 at 8:30 PM Alan Stern wrote: > > On Fri, Mar 05, 2021 at 08:22:22PM +0100, Sedat Dilek wrote: > > The quirks match: > > > > [Fri Mar 5 20:06:56 2021] usb-storage 4-1:1.0: USB Mass Storage device > > detected > > [Fri Mar 5 20:06:56 202

Re: [xhci] usb 4-1: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd

2021-03-05 Thread Sedat Dilek
On Fri, Mar 5, 2021 at 8:47 PM Alan Stern wrote: > > On Fri, Mar 05, 2021 at 08:41:40PM +0100, Sedat Dilek wrote: > > On Fri, Mar 5, 2021 at 8:30 PM Alan Stern wrote: > > > > Okay, that indicates the ATA commands are being sent not by the kernel > > > but by so

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-30 Thread Sedat Dilek
On Sat, Mar 27, 2021 at 9:02 PM Linus Torvalds wrote: > > On Sat, Mar 27, 2021 at 5:08 AM Sedat Dilek wrote: > > > > debian-5.10.19 as host-kernel: > > 11655.755564957 seconds time elapsed > > > > dileks-5.12-rc3 plus x86-nops as host-kernel: > > 11941

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-03 Thread Sedat Dilek
On Tue, Mar 2, 2021 at 10:07 PM Nathan Chancellor wrote: > > This is not necessary anymore now that we specify '--prefix=', which > tells clang exactly where to find the GNU cross tools. This has been > verified with self compiled LLVM 10.0.1 and LLVM 13.0.0 as well as a > distribution version of

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-03 Thread Sedat Dilek
On Wed, Mar 3, 2021 at 4:25 AM Sedat Dilek wrote: > > On Tue, Mar 2, 2021 at 10:07 PM Nathan Chancellor wrote: > > > > This is not necessary anymore now that we specify '--prefix=', which > > tells clang exactly where to find the GNU cross tools. This has be

Re: [PATCH v2] iwlwifi: don't call netif_napi_add() with rxq->lock held (was Re: Lockdep warning in iwl_pcie_rx_handle())

2021-03-03 Thread Sedat Dilek
On Wed, Mar 3, 2021 at 1:38 AM Kalle Valo wrote: > > "Coelho, Luciano" writes: > > > On Tue, 2021-03-02 at 11:34 +0100, Jiri Kosina wrote: > >> From: Jiri Kosina > >> > >> We can't call netif_napi_add() with rxq-lock held, as there is a potential > >> for deadlock as spotted by lockdep (see belo

Re: [PATCH v2 1/2] Makefile: Remove '--gcc-toolchain' flag

2021-03-15 Thread Sedat Dilek
llor > > --- > > > > v1 -> v2: > > > > * Improve commit message (add history behind flag and link to Fangrui's > > documentation improvement). > > > Both applied to linux-kbuild. Thanks. > Sorry for being pedantic: This misses my Tested-by#s

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-15 Thread Sedat Dilek
On Sat, Mar 13, 2021 at 2:47 PM Sedat Dilek wrote: [ ... ] > Let me look if I will do a selfmade ThinLTO+PGO optimized LLVM > toolchain v12.0.0-rc3 this weekend. > I did it. Here some fresh numbers: [ Selfmade LLVM toolchain v12.0.0-rc3 "stage1-only" ] [ Host-Kernel: 5.12.0-

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-15 Thread Sedat Dilek
On Mon, Mar 15, 2021 at 6:15 PM Borislav Petkov wrote: > > On Mon, Mar 15, 2021 at 06:04:41PM +0100, Sedat Dilek wrote: > > Here some fresh numbers: > > Lemme paste my previous reply which still holds true here: > > "There's a reason I have -s for silent in th

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-15 Thread Sedat Dilek
On Mon, Mar 15, 2021 at 7:10 PM Peter Zijlstra wrote: > > On Mon, Mar 15, 2021 at 06:04:41PM +0100, Sedat Dilek wrote: > > > make V=1 -j4 LLVM=1 LLVM_IAS=1 > > So for giggles I checked, neither GCC nor LLVM seem to emit prefix NOPs > when building with -march=sandybrid

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-15 Thread Sedat Dilek
On Mon, Mar 15, 2021 at 11:14 PM Peter Zijlstra wrote: > > On Mon, Mar 15, 2021 at 07:23:29PM +0100, Sedat Dilek wrote: > > > You mean something like that ^^? > > > > - Sedat - > > > > [1] > > https://git.zx2c4.com/laptop-kernel/commit/?id=116badbe

Re: [PATCH 0/3] Fix CONFIG_FUNCTION_TRACER with clang

2021-03-26 Thread Sedat Dilek
On Thu, Mar 25, 2021 at 11:38 PM Nathan Chancellor wrote: > > Hi all, > > This series fixes function tracing with clang. > > Patch 1 adjusts the mcount regex in scripts/recordmcount.pl to handle > the presence of PLT relocations, which happen with clang. Without this, > the mcount_loc section will

Re: [PATCH 1/3] x86: Propagate $(CLANG_FLAGS) to $(REALMODE_FLAGS)

2021-03-26 Thread Sedat Dilek
directives. > > * `-no-integrated-as' tells clang to assemble with GNU Assembler > instead of its built-in LLVM assembler. This flag is set by default > unless `LLVM_IAS=1' is set, because the LLVM assembler can't yet > parse certain GNU extensions. > >

Re: linux-next: build failure after merge of the tip tree

2021-03-26 Thread Sedat Dilek
On Mon, Mar 22, 2021 at 10:02 AM Borislav Petkov wrote: > > On Mon, Mar 22, 2021 at 02:37:14PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > > failed like this: > > > > arch/x86/net/bpf_jit_comp.c: In function 'arch_

Re: linux-next: build failure after merge of the tip tree

2021-03-27 Thread Sedat Dilek
On Fri, Mar 26, 2021 at 2:11 PM Borislav Petkov wrote: > > On Fri, Mar 26, 2021 at 09:57:43AM +0100, Sedat Dilek wrote: > > The commit b90829704780 "bpf: Use NOP_ATOMIC5 instead of > > emit_nops(&prog, 5) for BPF_TRAMP_F_CALL_ORIG" is now in Linus Git > > (

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-27 Thread Sedat Dilek
Out of curiosity I tried in my build-environment and my testing-rules to have comparable numbers... ..without passing "V=1" and "KBUILD_VERBOSE=1" as make-options: NOTE: Identical linux-config plus LLVM/Clang v12.0.0-rc3. debian-5.10.19 as host-kernel: 11655.755564957 seconds time elapsed dilek

Re: [PATCH 0/3] Fix CONFIG_FUNCTION_TRACER with clang

2021-03-27 Thread Sedat Dilek
On Fri, Mar 26, 2021 at 2:07 PM Nathan Chancellor wrote: > > On Fri, Mar 26, 2021 at 09:37:55AM +0100, Sedat Dilek wrote: > > On Thu, Mar 25, 2021 at 11:38 PM Nathan Chancellor > > wrote: > > > > > > Hi all, > > > > > > This series fixes fu

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-04-01 Thread Sedat Dilek
gt; > [...] > > Applied to kspp/cfi/cleanups, thanks! > > [1/1] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute > https://git.kernel.org/kees/c/f5c4679d6c49 > I have queued this up in my custom patchset (for-5.12/kspp-cfi-cleanups-20210225). What is the plan to get this upstream? Feel free to add my: Tested-by: Sedat Dilek - Sedat -

Re: Subject: Re: [PATCH v3] kbuild: add support for zstd compressed modules

2021-04-09 Thread Sedat Dilek
On Thu, Apr 8, 2021 at 11:05 PM Piotr Gorski wrote: > > No, the --rm option is essential. xz and gzip have the --rm option built in > as opposed to zstd, which is why I used it. I've been using zstd module > compression since last december (although I set a different compression level > on mine

Re: Subject: Re: [PATCH v3] kbuild: add support for zstd compressed modules

2021-04-09 Thread Sedat Dilek
On Fri, Apr 9, 2021 at 1:10 PM Piotr Gorski wrote: > > I originally posted the patch in a different form [1] even before Masahiro's > changes. > I've been testing this solution since December last year and posted it in > March this year, > after I made sure everything was working fine. This patc

Re: Subject: Re: [PATCH v3] kbuild: add support for zstd compressed modules

2021-04-09 Thread Sedat Dilek
On Fri, Apr 9, 2021 at 1:31 PM Sedat Dilek wrote: > > On Fri, Apr 9, 2021 at 1:10 PM Piotr Gorski wrote: > > > > I originally posted the patch in a different form [1] even before > > Masahiro's changes. > > I've been testing this solution since Decemb

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-04-02 Thread Sedat Dilek
On Fri, Apr 2, 2021 at 8:31 PM Nathan Chancellor wrote: > > On Fri, Apr 02, 2021 at 11:25:42AM -0700, Kees Cook wrote: > > On Fri, Apr 02, 2021 at 08:42:07AM +0200, Sedat Dilek wrote: > > > On Thu, Feb 25, 2021 at 10:25 PM Kees Cook wrote: > > > > > >

Usage of CXX in tools directory

2021-04-04 Thread Sedat Dilek
[ Please CC me I am not subscribed to all mailing-lists ] [ Please CC some more folks if you like ] Hi, when dealing/experimenting with BPF together with pahole/dwarves and dwarf-v5 and clang-lto I fell over that there is usage of CXX in tools directory. Especially, I wanted to build and run tes

Re: Usage of CXX in tools directory

2021-04-04 Thread Sedat Dilek
> So you need to pass CXX=clang++ manually when playing in tools directory: > > MAKE="make V=1 > MAKE_OPTS="HOSTCC=clang HOSTCXX=clang++ HOSTLD=ld.lld CC=clang > CXX=clang++ LD=ld.lld LLVM=1 LLVM_IAS=1" > MAKE_OPTS="MAKE_OPTS $PAHOLE=/opt/pahole/bin/pahole" > > $ LC_ALL=C $MAKE $MAKE_OPTS -C tools/

Re: clang-12: i386: Unsupported relocation type: R_386_PLT32 (4)

2021-02-22 Thread Sedat Dilek
On Mon, Feb 22, 2021 at 5:08 PM Naresh Kamboju wrote: > > While building i386 configs on stable-rc 5.10, stable-rc 5.11 branch > and mainline > with clang-12 these following warnings and errors were noticed. > Hi Naresh, Please see commit bb73d07148c405c293e576b40af37737faf23a6a ("x86/build: Tre

Re: clang-12: i386: Unsupported relocation type: R_386_PLT32 (4)

2021-02-22 Thread Sedat Dilek
On Mon, Feb 22, 2021 at 5:30 PM Naresh Kamboju wrote: > > On Mon, 22 Feb 2021 at 21:44, Sedat Dilek wrote: > > > > On Mon, Feb 22, 2021 at 5:08 PM Naresh Kamboju > > wrote: > > > > > > While building i386 configs on stable-rc 5.10, stable-rc 5.11 bra

Re: [PATCH v3] x86/pci: fix the function type for check_reserved_t

2020-12-04 Thread Sedat Dilek
e820_type values for the > > type argument, change the typedef and the unused type argument in > > is_acpi_reserved to enum e820_type to fix the type mismatch. > > > > Reported-by: Sedat Dilek > > Suggested-by: Borislav Petkov > > Signed-off-by: Sami Tolvanen &

Linux 5.12-rc1

2021-03-01 Thread Sedat Dilek
[ Please CC me I am not subscribed to LKML ] [ Original post see [0] ] Hi Linus, Thanks for Linux v5.12-rc1 and all involved people. [ Delayed merge-window ] I wondered why there was approx. for 6 days no commits and got an answer from an LWN posting "5.12 Merge window delayed". Unsure, if ther

Re: [xhci] usb 4-1: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd

2021-03-01 Thread Sedat Dilek
On Wed, Feb 24, 2021 at 6:25 PM Sedat Dilek wrote: > > On Wed, Feb 24, 2021 at 2:44 PM Sedat Dilek wrote: > > > > Hi Mathias, > > > > I am here on Linux-v5.11-10201-gc03c21ba6f4e. > > > > I see a lot xhci-resets in my dmesg-log: > > > > roo

Re: [PATCH] kbuild: collect minimum tool versions into scripts/min-tool-version.sh

2021-03-12 Thread Sedat Dilek
t; 2.23.0 > $ scripts/min-tool-version.sh foo > foo: unknown tool > > Signed-off-by: Masahiro Yamada > Reviewed-by: Nathan Chancellor The idea with creating gcc, llvm, binutils etc. files containing the minimum version-string sounds good to me. This version here test

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-12 Thread Sedat Dilek
On Fri, Mar 12, 2021 at 1:00 PM Peter Zijlstra wrote: > > Hi! > > A while ago Steve complained about x86 being weird for having different NOPs > [1] > > Having cursed the same thing before, I figured it was time to look at the NOP > situation. > > 32bit simply isn't a performance target anymore,

Re: [xhci] usb 4-1: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd

2021-03-12 Thread Sedat Dilek
On Fri, Mar 12, 2021 at 5:57 PM Sedat Dilek wrote: > > On Sun, Mar 7, 2021 at 6:07 PM Alan Stern wrote: > > > > On Sun, Mar 07, 2021 at 05:57:39PM +0100, Sedat Dilek wrote: > > > On Sun, Mar 7, 2021 at 4:46 PM Alan Stern > > > wrote: > > > >

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-12 Thread Sedat Dilek
On Fri, Mar 12, 2021 at 6:26 PM Steven Rostedt wrote: > > On Fri, 12 Mar 2021 15:47:26 +0100 > Borislav Petkov wrote: > > > On Fri, Mar 12, 2021 at 03:29:48PM +0100, Sedat Dilek wrote: > > > What does this change exactly mean to/for me? > > > > Probably not

Re: [xhci] usb 4-1: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd

2021-03-12 Thread Sedat Dilek
OK, now for the records: [ /etc/modprobe.d/usb-storage.conf ] # Add quirks for USB Mass Storage devices # # Link: https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html # # Option #1: Use Kernel command line parameter # [1] Usage: usb-storage.quirks= # [2] VendorID (VID) and

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-12 Thread Sedat Dilek
On Fri, Mar 12, 2021 at 6:47 PM Steven Rostedt wrote: > > On Fri, 12 Mar 2021 18:35:45 +0100 > Sedat Dilek wrote: > > > > Hey Steve, you degraded me to a number :-). > > It's the internet, everyone is a number. > > > > > I dunno which Git tree

Re: [xhci] usb 4-1: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd

2021-03-12 Thread Sedat Dilek
On Fri, Mar 12, 2021 at 7:05 PM Alan Stern wrote: > > On Fri, Mar 12, 2021 at 06:41:58PM +0100, Sedat Dilek wrote: > > OK, now for the records: > > > > [ /etc/modprobe.d/usb-storage.conf ] > > > > # Add quirks for USB Mass Storage devices > > # > &

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-12 Thread Sedat Dilek
On Fri, Mar 12, 2021 at 7:13 PM Sedat Dilek wrote: > > On Fri, Mar 12, 2021 at 6:47 PM Steven Rostedt wrote: > > > > On Fri, 12 Mar 2021 18:35:45 +0100 > > Sedat Dilek wrote: > > > > > > > Hey Steve, you degraded me to a number :-). &g

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-12 Thread Sedat Dilek
warning below. > >> > >> Hi, > >> > >> friendly ping on this one ... > > > > Luca, > > > > Johannes is telling me that he merged this patch internally, but I have no > > idea what is happening to it ... ? > > > > The reported

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-13 Thread Sedat Dilek
On Sat, Mar 13, 2021 at 9:51 AM Borislav Petkov wrote: > > On Sat, Mar 13, 2021 at 06:26:15AM +0100, Sedat Dilek wrote: > > x86/jump_label: Mark arguments as const to satisfy asm constraints > > Where do I find this patch? > Here we go: https://git.kernel.org/pub/scm

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-13 Thread Sedat Dilek
On Sat, Mar 13, 2021 at 1:15 PM Borislav Petkov wrote: > > On Sat, Mar 13, 2021 at 01:10:29PM +0100, Sedat Dilek wrote: > > Here we go: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/patch/?id=864b435514b286c0be2a38a02f487aa28d990ef8 > > That&#

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-13 Thread Sedat Dilek
On Sat, Mar 13, 2021 at 1:49 PM Borislav Petkov wrote: > > On Sat, Mar 13, 2021 at 01:38:22PM +0100, Sedat Dilek wrote: > > AFAICS you did a 5 times x86-64 defconfig with dropped pagecache and `make > > -j9`? > > The tailored .config for that particular test box. >

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-13 Thread Sedat Dilek
On Sat, Mar 13, 2021 at 2:29 PM Borislav Petkov wrote: > > On Sat, Mar 13, 2021 at 01:58:56PM +0100, Sedat Dilek wrote: > > You can add Debian/experimental APT sources.list ... > > I could but I don't expect clang12 to behave any differently here. > Agreed in things

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-20 Thread Sedat Dilek
Hi, When I looked through the code I wondered why we do not add a "CONFIG_PGO_CLANG_PROFDATA" which can be helpful when doing the PGO rebuild with a vmlinux.profdata. This introduces a "PGO_PROFDATA" to turn on/off to pass "-fprofile-use=vmlinux.profdata" (see CFLAGS_PGO_CLANG_PROFDATA in top-lev

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-20 Thread Sedat Dilek
On Wed, Jan 20, 2021 at 11:36 PM Jiri Olsa wrote: > > On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sedat Dilek wrote: > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. > > > > While looking into the source code I found duplicate assignments > &

Re: [PATCH v5 2/3] Kbuild: make DWARF version a choice

2021-01-20 Thread Sedat Dilek
On Wed, Jan 20, 2021 at 9:40 PM Nathan Chancellor wrote: > > On Fri, Jan 15, 2021 at 01:06:15PM -0800, Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an > > explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a > > way that's forward

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-20 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > > > > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > > > >

Re: [PATCH bpf-next v3] samples/bpf: Update build procedure for manually compiling LLVM and Clang

2021-01-21 Thread Sedat Dilek
On Thu, Jan 21, 2021 at 9:08 AM Andrii Nakryiko wrote: > > On Wed, Jan 20, 2021 at 9:36 PM Nathan Chancellor > wrote: > > > > On Thu, Jan 21, 2021 at 01:27:35PM +0800, Tiezhu Yang wrote: > > > The current LLVM and Clang build procedure in samples/bpf/README.rst is > > > out of date. See below tha

Re: [PATCH v6] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Sedat Dilek
t; value stopping it. Can you add an example for the workload test? Here I do a x86-64 defconfig build. See attached script. Usually, I download this patch from LORE. link="https://lore.kernel.org/r/20210111081821.3041587-1-mo...@google.com"; b4 -d am $link This downloads v6. What

Re: [PATCH bpf-next v3] samples/bpf: Update build procedure for manually compiling LLVM and Clang

2021-01-21 Thread Sedat Dilek
On Thu, Jan 21, 2021 at 9:55 AM Sedat Dilek wrote: > > On Thu, Jan 21, 2021 at 9:08 AM Andrii Nakryiko > wrote: > > > > On Wed, Jan 20, 2021 at 9:36 PM Nathan Chancellor > > wrote: > > > > > > On Thu, Jan 21, 2021 at 01:27:35PM +0800, Tiezhu Yang wr

Re: [PATCH] [RFC] arm64: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION

2021-03-10 Thread Sedat Dilek
On Wed, Mar 10, 2021 at 10:08 PM Arnd Bergmann wrote: > > On Wed, Mar 10, 2021 at 9:50 PM Masahiro Yamada wrote: > > On Mon, Mar 1, 2021 at 10:11 AM Nicholas Piggin wrote: > > > Excerpts from Arnd Bergmann's message of February 27, 2021 7:49 pm: > > > > > masahiro@oscar:~/ref/linux$ echo 'void

<    3   4   5   6   7   8   9   10   11   12   >