RE: [PATCH] Input: elan_i2c - +200 ms delay before setting to ABS mode

2016-06-20 Thread
Hi Dmitry, The modification from Chris is a special case. Because the Touchpad FW is a little different from normal one, It cause problem in Asus's OBE test. That's why Elan's driver use work-around to solve the problem. It's not tested by other touchpad. Let me discuss with internal FW team to

RE: [PATCH] Input: elan_i2c - +200 ms delay before setting to ABS mode

2016-06-21 Thread
Hi Dmitry, -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Tuesday, June 21, 2016 1:43 AM To: Chris Chiu; kt.l...@emc.com.tw Cc: Charlie Mooney; Michele Curti; Krzysztof Kozlowski; Benson Leung; linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org; l

RE: [PATCH 0/8] Input: support for latest Lenovo thinkpads (series 80)

2018-04-09 Thread
ause error happen in elantech_create_smbus. It will be recovered only if I rmmod/modprobe i2c_i801 first. Do you have any idea about it? Thanks KT -Original Message- From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] Sent: Friday, April 06, 2018 2:51 PM To: Dmitry Toro

RE: [PATCH 0/8] Input: support for latest Lenovo thinkpads (series 80)

2018-04-10 Thread
Hi Benjamin, -Original Message- From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] Sent: Tuesday, April 10, 2018 3:35 PM To: 廖崇榮 Cc: Dmitry Torokhov; Oliver Haessler; Benjamin Berg; open list:HID CORE LAYER; lkml Subject: Re: [PATCH 0/8] Input: support for latest Lenovo

RE: [PATCH] Input: elantech - Fix V4 report decoding for module with middle key

2018-05-30 Thread
Hi Dmitry, -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Wednesday, May 30, 2018 2:05 AM To: KT Liao Cc: linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org; ulrik.debie...@e2big.org; phoe...@emc.com.tw; aaron...@canonical.com; josh.c...@emc.com.t

RE: [PATCH] Input: elan_i2c - Add i2c_reset in sysfs for ELAN touchpad recovery

2019-03-28 Thread
Hi Dmitry, -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Wednesday, March 27, 2019 12:34 PM To: KT Liao Cc: linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org; ulrik.debie...@e2big.org; roger.whitta...@suse.com Subject: Re: [PATCH] Input: elan_i2

RE: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger

2016-05-23 Thread
input_report_key(dev, BTN_TOOL_FINGER, input_mt_get_value(dev, ABS_DISTANCE)); count = 1; } B.R KT -Original Message- From: 'Dmitry Torokhov' [mailto:dmitry.torok...@gmail.com] Sent: Friday, May 20, 2016 8:52 AM To: 廖崇榮 Cc: l

RE: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger

2016-05-17 Thread
nter_emulation] emit BTN_TOOL_FINGER report without change function parameter. Please let me know if my misunderstand about your idea. Thanks KT -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Tuesday, May 17, 2016 1:54 AM To: 廖崇榮 Cc: linux-in...@vger.kern

[PATCH] Emit BTN_TOO_FINGER in function input_mt_report_pointer_emulation if touchpad meets hover condition

2016-05-25 Thread
Hi Dmitry, Update /input/mouse/input-mt.c Emit BTN_TOO_FINGER in input_mt_report_pointer_emulation if touchpad meets hover condition. Thanks & BR KT -Original Message- From: 'Dmitry Torokhov' [mailto:dmitry.torok...@gmail.com] Sent: Friday, May 20, 2016 8:52 AM To:

[PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger

2016-05-16 Thread
Only ABS_DISTANCE is not enough for upper OS to distingiush hover event be triggered from object from faraway to and close touchpad surface or from object prepare to leave the touchpad surface. Add BTN_TOOL_FINGER flag to help it. object_from_farawayobject_inside_hover_area o

RE: [PATCH 1/1] Input: elantech: Use SMBus based on bus info

2019-01-18 Thread
-Original Message- From: Kai Heng Feng [mailto:kai.heng.f...@canonical.com] Sent: Friday, January 18, 2019 12:15 AM To: Benjamin Tissoires Cc: Dmitry Torokhov; 廖崇榮; open list:HID CORE LAYER; lkml Subject: Re: [PATCH 1/1] Input: elantech: Use SMBus based on bus info > On Jan 17, 2

RE: [PATCH 1/1] Input: elantech: Use SMBus based on bus info

2019-01-20 Thread
-Original Message- From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com] Sent: Monday, January 21, 2019 12:28 PM To: 廖崇榮 Cc: Benjamin Tissoires; Dmitry Torokhov; open list:HID CORE LAYER; lkml Subject: Re: [PATCH 1/1] Input: elantech: Use SMBus based on bus info > On Jan 18, 2

RE: [PATCH v2 09/10] Input: elan_i2c - correct the width/size base value

2019-05-23 Thread
Hi Benjamin, Thanks so much for all you do for Elan touchpad. For the width_*, I have a question for it. Our antenna sensors fully occupied the whole touchpad PCB. The Gap between 2 sensors are 7.5 mil (0.19mm). That's why we did not minus one trace. Thanks KT -Original Message- From:

RE: [PATCH v2 09/10] Input: elan_i2c - correct the width/size base value

2019-05-24 Thread
Hi -Original Message- From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] Sent: Friday, May 24, 2019 3:06 PM To: 廖崇榮 Cc: Dmitry Torokhov; Rob Herring; Aaron Ma; Hans de Goede; open list:HID CORE LAYER; lkml; devicet...@vger.kernel.org Subject: Re: [PATCH v2 09/10] Input

RE: [PATCH v2 08/10] Input: elan_i2c - export true width/height

2019-05-26 Thread
Hi -Original Message- From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] Sent: Friday, May 24, 2019 5:37 PM To: Dmitry Torokhov; KT Liao; Rob Herring; Aaron Ma; Hans de Goede Cc: open list:HID CORE LAYER; lkml; devicet...@vger.kernel.org Subject: Re: [PATCH v2 08/10] Input: e

RE: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-04-01 Thread
Hi Dmitry, -Original Message- From: Dmitry Torokhov [mailto:d...@chromium.org] Sent: Saturday, March 30, 2019 2:24 AM To: Hans de Goede; 廖崇榮 Cc: Vladislav Dalechyn; Benjamin Tissoires; Jiri Kosina; kai.heng.f...@canonical.com; swb...@chromium.org; bige...@linutronix.de; open list:HID

RE: [PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)

2018-04-17 Thread
Hi Benjamin, I agree this series. Thanks KT -Original Message- From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] Sent: Tuesday, April 17, 2018 4:34 PM To: 廖崇榮 Cc: Oliver Haessler; Benjamin Berg; Rob Herring; devicet...@vger.kernel.org; open list:HID CORE LAYER; lkml

RE: [PATCH] Input: elan_i2c - +200 ms delay before setting to ABS mode

2016-06-22 Thread
-Original Message- From: Daniel Drake [mailto:dr...@endlessm.com] Sent: Tuesday, June 21, 2016 10:42 PM To: 廖崇榮 Cc: Dmitry Torokhov; Chris Chiu; Charlie Mooney; Michele Curti; Krzysztof Kozlowski; Benson Leung; linux-in...@vger.kernel.org; Linux Kernel; Linux Upstreaming Team; 黃世鵬 經理

RE: [PATCH] Input: /input/input-mt.c Emit BTN_TOO_FINGER in function input_mt_report_pointer_emulation if touchpad meets hover condition Signed-off-by: KT Liao

2016-06-02 Thread
Hi Dmitry, I up-streamed the patch last Sunday, please let me know if you have other concern. Thanks your support KT -Original Message- From: KT Liao [mailto:ktalex.l...@gmail.com] Sent: Sunday, May 29, 2016 11:39 AM To: linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org; dmitr

RE: [PATCH] Input: elan_i2c - Add new ic and modify some functions for new IC infomation Signed-off-by: KT Liao

2016-11-18 Thread
Hi Dmitry -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Friday, November 18, 2016 1:15 AM To: KT Liao Cc: linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org; phoe...@emc.com.tw; kt.l...@emc.com.tw Subject: Re: [PATCH] Input: elan_i2c - Add new i

RE: [PATCH] Input: elantech - Add a special mode for a specific FW The touchapd which sample ver is 0x74 and hw_version is 0x03 have a fw bug which will cause crush sometimes, I add some work-around f

2016-12-04 Thread
Hi Ulrik, Dmitry, Thanks your comment for the patch. Please see my reply I the below. -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Sunday, December 04, 2016 2:48 AM To: ulrik.debie...@e2big.org Cc: KT Liao; linux-kernel@vger.kernel.org; linux-in...@vg

RE: [PATCH] Input: elan_i2c - add ASUS EeeBook X205TA special touchpad fw

2017-03-06 Thread
Hi Dmitry -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Tuesday, March 07, 2017 3:55 AM To: KT Liao Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org; Matjaz Hegedic Subject: Re: [PATCH] Input: elan_i2c - add ASUS EeeBook X205TA special touc

RE: [PATCH] Input: elan_i2c - add ASUS EeeBook X205TA special touchpad fw

2017-03-07 Thread
Hi Matjaz, -Original Message- From: Matjaž Hegedič [mailto:matjaz.hege...@gmail.com] Sent: Tuesday, March 07, 2017 6:52 PM To: 廖崇榮; 'Dmitry Torokhov' Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org; 黃世鵬 經理; miller_w...@emc.com.tw Subject: Re: [PATCH] Input: elan

RE: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize

2016-07-11 Thread
Hi Dmitry, -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Saturday, July 09, 2016 8:25 AM To: KT Liao Cc: linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org; phoe...@emc.com.tw; kt.l...@emc.com.tw Subject: Re: [PATCH] Input: /input/mouse/elan_i2c

RE: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize

2016-07-12 Thread
Hi Dmitry, -Original Message- From: 'Dmitry Torokhov' [mailto:dmitry.torok...@gmail.com] Sent: Tuesday, July 12, 2016 1:03 AM To: 廖崇榮 Cc: 'KT Liao'; linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org; phoe...@emc.com.tw Subject: Re: [PATCH] Input: /input/mouse

RE: [PATCH] Input: /input/input-mt.c Emit BTN_TOO_FINGER in function input_mt_report_pointer_emulation if touchpad meets hover condition Signed-off-by: KT Liao

2016-06-13 Thread
Hi Dmitry, We would like to follow up if there is any update or feedback for this patch. Thanks & B.R KT -Original Message- From: 廖崇榮 [mailto:kt.l...@emc.com.tw] Sent: Thursday, June 02, 2016 7:57 PM To: 'linux-kernel@vger.kernel.org'; 'linux-in

RE: [PATCH] Input: elan_i2c - +200 ms delay before setting to ABS mode

2016-06-27 Thread
Hi Daniel, Chris -Original Message- From: Daniel Drake [mailto:dr...@endlessm.com] Sent: Tuesday, June 21, 2016 10:42 PM To: 廖崇榮 Cc: Dmitry Torokhov; Chris Chiu; Charlie Mooney; Michele Curti; Krzysztof Kozlowski; Benson Leung; linux-in...@vger.kernel.org; Linux Kernel; Linux

RE: [PATCH v2 08/10] Input: elan_i2c - export true width/height

2019-05-29 Thread
-Original Message- From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] Sent: Wednesday, May 29, 2019 3:17 PM To: Sean O'Brien; Peter Hutterer Cc: Harry Cutts; Dmitry Torokhov; 廖崇榮; Rob Herring; Aaron Ma; Hans de Goede; open list:HID CORE LAYER; lkml; de

RE: [PATCH] Input: elan_i2c - Prevent breaking of FW updating from unexpected signal

2017-05-24 Thread
Hi Dmitry -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Wednesday, May 24, 2017 5:14 AM To: KT Liao Cc: linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org; phoe...@emc.com.tw Subject: Re: [PATCH] Input: elan_i2c - Prevent breaking of FW updating

RE: [PATCH] Input: elantech - support new touchpad IC and extend elan's touchapd command Origianl ic-body field is not sufficient for upcoming IC, Elan ps/2 driver extend the fomation to support futur

2017-08-07 Thread
Hi Ulrik, Thanks your review, I add comment in below. -Original Message- From: ulrik.debie...@e2big.org [mailto:ulrik.debie...@e2big.org] Sent: Friday, August 04, 2017 4:52 AM To: KT Liao Cc: linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org; dmitry.torok...@gmail.com; phoe...@emc