[PATCH 1/3] rtc: rx8010: Remove duplicate define

2017-11-03 Thread Akshay Bhat
Remove duplicate define for RX8010_YEAR Signed-off-by: Akshay Bhat --- drivers/rtc/rtc-rx8010.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c index 1ed3403..f948f75 100644 --- a/drivers/rtc/rtc-rx8010.c +++ b/drivers/rtc/rtc-rx8010.c

[PATCH 2/3] rtc: rx8010: Specify correct address for RX8010_RESV31

2017-11-03 Thread Akshay Bhat
Define for reserved register 31 had the incorrect address. Specify the correct address. Reported-by: Jens-Peter Oswald Signed-off-by: Akshay Bhat --- drivers/rtc/rtc-rx8010.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c

[PATCH 3/3] rtc: rx8010: Fix for incorrect return value

2017-11-03 Thread Akshay Bhat
The err variable is not being reset after a successful read. Explicitly reset err variable to account for all return paths. Reported-by: Jens-Peter Oswald Signed-off-by: Akshay Bhat --- drivers/rtc/rtc-rx8010.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/rtc-rx8010.c b

[PATCH v3 1/2] drm/imx: imx-ldb: Add DDC support

2016-04-27 Thread Akshay Bhat
From: Steve Longerbeam Add support for reading EDID over Display Data Channel. If no DDC adapter is available, falls back to hardcoded EDID or display-timings node as before. Signed-off-by: Steve Longerbeam Signed-off-by: Akshay Bhat Acked-by: Philipp Zabel --- Hi Philipp, I have addressed

[PATCH v3 2/2] dt-bindings: imx: ldb: Add ddc-i2c-bus property

2016-04-27 Thread Akshay Bhat
Document the ddc-i2c-bus property used by imx-ldb driver to read EDID information via I2C interface. Signed-off-by: Akshay Bhat --- v3: Newly added. Documentation/devicetree/bindings/display/imx/ldb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings

[PATCH] rtc: Add Epson RX8010SJ RTC driver

2015-11-11 Thread Akshay Bhat
This driver supports the following functions: - reading and setting time - alarms when connected to an IRQ - reading and clearing the voltage low flags Datasheet: http://www.epsondevice.com/docs/qd/en/DownloadServlet?id=ID000956 Signed-off-by: Akshay Bhat --- drivers/rtc/Kconfig | 10

[PATCH] drm/panel: simple: Add support for G121X1-L03

2015-11-18 Thread Akshay Bhat
Add support for Innolux CheMei 12" G121X1-L03 XGA LVDS display. Datasheet: http://www.azdisplays.com/PDF/G121X1-L03.pdf Signed-off-by: Akshay Bhat --- .../bindings/display/panel/innolux,g121x1-l03.txt | 7 + drivers/gpu/drm/panel/panel-simple.c | 31

Re: [PATCH] rtc: Add Epson RX8010SJ RTC driver

2015-12-01 Thread Akshay Bhat
Hi, Wanted to check if there was any feedback on this patch? Thanks, Akshay On 11/11/2015 05:31 PM, Akshay Bhat wrote: This driver supports the following functions: - reading and setting time - alarms when connected to an IRQ - reading and clearing the voltage low flags Datasheet: http

Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop

2015-12-02 Thread Akshay Bhat
On 11/06/2015 05:02 PM, Guenter Roeck wrote: On Fri, Nov 06, 2015 at 11:53:42AM -0800, Tim Harvey wrote: On Thu, Nov 5, 2015 at 2:23 PM, Guenter Roeck wrote: On Thu, Nov 05, 2015 at 04:19:21PM -0500, Akshay Bhat wrote: From: Tim Harvey The IMX6 watchdog supports assertion of a signal

[PATCH v2] rtc: Add Epson RX8010SJ RTC driver

2015-12-03 Thread Akshay Bhat
This driver supports the following functions: - reading and setting time - alarms when connected to an IRQ - reading and clearing the voltage low flags Datasheet: http://www.epsondevice.com/docs/qd/en/DownloadServlet?id=ID000956 Signed-off-by: Akshay Bhat --- Changes in v2: - Address comments

Re: [PATCH] rtc: Add Epson RX8010SJ RTC driver

2015-12-03 Thread Akshay Bhat
Thanks for the detailed feedback and mentioning --strict option for checkpatch :) I have fixed all the issues in the v2 version of the patch: https://lkml.org/lkml/2015/12/3/606 On 12/02/2015 06:40 PM, Alexandre Belloni wrote: On 11/11/2015 at 17:31:58 -0500, Akshay Bhat wrote : diff --git a

[PATCH] hwmon: (ads7828) Enable internal reference

2016-04-18 Thread Akshay Bhat
settle before performing a normal read. Without this fix, the first read from the ADC when using internal reference always returns incorrect data. Signed-off-by: Akshay Bhat --- drivers/hwmon/ads7828.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/hwmon/ads7828.c b

[PATCH v2] drm/imx: imx-ldb: Add DDC support

2016-04-26 Thread Akshay Bhat
From: Steve Longerbeam Add support for reading EDID over Display Data Channel. If no DDC adapter is available, falls back to hardcoded EDID or display-timings node as before. Signed-off-by: Steve Longerbeam Signed-off-by: Akshay Bhat Acked-by: Philipp Zabel --- Hi Philipp, I found this

[PATCH v4 0/2] imx6: Implement external watchdog reset

2015-11-05 Thread Akshay Bhat
[Rebase to next-20151105 and re-sending work done by Tim Harvey] The IMX6 watchdog supports assertion of a signal (WDOG_B) which can be pinmux'd to an external pin. This is typically used for boards that have PMIC's in control of the IMX6 power rails. In fact, failure to use such an external reset

[PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop

2015-11-05 Thread Akshay Bhat
From: Tim Harvey The IMX6 watchdog supports assertion of a signal (WDOG_B) which can be pinmux'd to an external pin. This is typically used for boards that have PMIC's in control of the IMX6 power rails. In fact, failure to use such an external reset on boards with external PMIC's can result in v

[PATCH v4 2/2] ARM: dts: ventana: Add ext-reset support

2015-11-05 Thread Akshay Bhat
From: Tim Harvey The Gateworks Ventana boards have a PMIC that can be used to regulate the CPU voltage rails for DVFS support. In order to ensure this PMIC is properly reset the watchdog needs to be configured to assert its external reset signal. Additionally the pad used for WDOG_B needs to be

[PATCH v2 1/2] can: holt_hi311x: document device tree bindings

2017-01-17 Thread Akshay Bhat
Document the HOLT HI-311x CAN device tree bindings. Signed-off-by: Akshay Bhat Acked-by: Rob Herring --- v1 -> v2: - No changes .../devicetree/bindings/net/can/holt_hi311x.txt| 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicet

[PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-01-17 Thread Akshay Bhat
Signed-off-by: Akshay Bhat --- v1 -> v2: Address comments from Marc Kleine-Budde: - use u8 instead of uint8_t - alphabetically sort Makefile and Kconfig - copy over copyright information from mcp251x - use single space after each marco - add missing HI3110_ namespace in defines - remove ma

Re: [PATCH 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-01-17 Thread Akshay Bhat
Marc, On 01/03/2017 10:31 AM, Marc Kleine-Budde wrote: > On 11/14/2016 06:55 PM, Akshay Bhat wrote: >> This patch adds support for the Holt HI-311x CAN controller. The HI311x >> CAN controller is capable of transmitting and receiving standard data >> frames, extended data fra

[PATCH 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2016-11-14 Thread Akshay Bhat
Signed-off-by: Akshay Bhat --- drivers/net/can/spi/Kconfig |6 + drivers/net/can/spi/Makefile |1 + drivers/net/can/spi/hi311x.c | 1071 ++ 3 files changed, 1078 insertions(+) create mode 100644 drivers/net/can/spi/hi311x.c diff --git a/drivers

[PATCH 1/2] can: holt_hi311x: document device tree bindings

2016-11-14 Thread Akshay Bhat
Document the HOLT HI-311x CAN device tree bindings. Signed-off-by: Akshay Bhat --- .../devicetree/bindings/net/can/holt_hi311x.txt| 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/holt_hi311x.txt diff --git a

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-17 Thread Akshay Bhat
Hi Wolfgang, On 03/17/2017 03:39 AM, Wolfgang Grandegger wrote: > Hello Akshay, > > Am 16.03.2017 um 23:29 schrieb Akshay Bhat: >> Hi Wolfgang, >> >> On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: >>> >>> Looks much better now! There are messa

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-17 Thread Akshay Bhat
Hi Wolfgang, On 03/17/2017 01:04 PM, Wolfgang Grandegger wrote: > > Hm, that's unusual. Cable disconnected and then send a message: > > $ grep /proc/interrupts; sleep 10; /proc/interrupts > > should make things clear. But maybe it's a clever chip and it does stop > sending error messages if the

[PATCH v4 1/2] can: holt_hi311x: document device tree bindings

2017-03-17 Thread Akshay Bhat
Document the HOLT HI-311x CAN device tree bindings. Signed-off-by: Akshay Bhat Acked-by: Rob Herring --- v3 -> v4: - No changes .../devicetree/bindings/net/can/holt_hi311x.txt| 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicet

[PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-17 Thread Akshay Bhat
Signed-off-by: Akshay Bhat --- v3 -> v4: Address comments from Wolfgang Grandegger: - Add support for CAN warning state reporting - Add support for reporting tx/rx error counts in bus error messages - Keep bus error interrupts enabled to detect CAN state changes - Fix bug in restart code af

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-20 Thread Akshay Bhat
Hi Wolfgang, On 03/19/2017 12:17 PM, Wolfgang Grandegger wrote: > Hello Akshay, > > I still see some improvements... > > Am 17.03.2017 um 22:10 schrieb Akshay Bhat: >> This patch adds support for the Holt HI-311x CAN controller. The HI311x >> CAN controller is

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-20 Thread Akshay Bhat
Hi Wolfgang, On 03/20/2017 12:46 PM, Wolfgang Grandegger wrote: ..snip.. >> >> The top 3 bits of HI3110_READ_ERR (BUSOFF, TXERRP, RXERRP) are valid >> even if HI3110_INT_BUSERR is not set. > > I'm confused! If you disable BUSERR interrupts, you do not get the > status bits any longer, you said. B

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-24 Thread Akshay Bhat
Hi Marc, On 03/17/2017 05:10 PM, Akshay Bhat wrote: > This patch adds support for the Holt HI-311x CAN controller. The HI311x > CAN controller is capable of transmitting and receiving standard data > frames, extended data frames and remote frames. The HI311x interfaces > with the h

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-14 Thread Akshay Bhat
Hi Wolfgang, On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: ...snip >> /disconnect cable >> can0 2088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME >> protocol-violation{{}{acknowledge-slot}} >> bus-error >> error-counter-tx-rx{{40}{0}} >> can0

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-16 Thread Akshay Bhat
Hi Wolfgang, On 03/15/2017 05:42 AM, Wolfgang Grandegger wrote: > Hello Akshay, > ..snip.. >> >> So here is my plan: >> - Have the bus error interrupt always enabled >> - If berr-reporting off, then have the isr checks/reports state changes > > Error state change messages should always be there.

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-16 Thread Akshay Bhat
Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: > > Looks much better now! There are message for state changes to error > warning and passive. Just the following message is not correct: > > (000.200824) can0 2004 [8] 00 40 00 00 00 00 5F 19 ERRORFRAME > controller

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-07 Thread Akshay Bhat
On 01/17/2017 02:22 PM, Akshay Bhat wrote: > This patch adds support for the Holt HI-311x CAN controller. The HI311x > CAN controller is capable of transmitting and receiving standard data > frames, extended data frames and remote frames. The HI311x interfaces > with the h

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-09 Thread Akshay Bhat
included in the Linux kernel. Below are detailed test results if you like: https://goo.gl/VWgzp7 Ones of particular interest: 10M-msgs-1M-bitrate-100burst-40ms-interval-leaf.png 10M-msgs-1M-bitrate-100burst-40ms-interval-pwc.txt Thanks, Akshay > > Am 07.03.2017 um 16:31 schrieb Akshay Bhat: &

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-09 Thread Akshay Bhat
Hi Wolfgang, On 03/09/2017 09:45 AM, Wolfgang Grandegger wrote: > Hello Akshay, > > Am 09.03.2017 um 13:34 schrieb Akshay Bhat: >> >> Hi Wolfgang, >> >> Good question. I have not worked with MPC251x but the HI-311x performs >> much better because HI-3110

[PATCH v3 1/2] can: holt_hi311x: document device tree bindings

2017-03-13 Thread Akshay Bhat
Document the HOLT HI-311x CAN device tree bindings. Signed-off-by: Akshay Bhat Acked-by: Rob Herring --- v2 -> v3: - No changes .../devicetree/bindings/net/can/holt_hi311x.txt| 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicet

[PATCH v3 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-13 Thread Akshay Bhat
Signed-off-by: Akshay Bhat --- v2 -> v3: Address comments from Wolfgang Grandegger: - Remove noisy debug messages in hi3110 read/write - Remove error messages which worsen failure conditions - Do not copy data bytes for RTR messages - Simplify the logic to setting the can mode - Add support

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-13 Thread Akshay Bhat
Hi Wolfgang, On 03/09/2017 12:36 PM, Wolfgang Grandegger wrote: > Hello, > > doing a quick review... I realized a few issues... > > Am 17.01.2017 um 20:22 schrieb Akshay Bhat: >> +static u8 hi3110_read(struct spi_device *spi, u8 command) >> +{ >> +struct hi

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-14 Thread Akshay Bhat
Hi Wolfgang, On 03/14/2017 08:11 AM, Wolfgang Grandegger wrote: > ... snip ... >>> A few other things to check: >>> >>> Run "cangen" and monitor the message with "candump -e any,0:0,#FFF". >>> Then 1) disconnect the cable or 2) short-circuit CAN low and high at the >>> connector. You should s

Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

2016-08-29 Thread Akshay Bhat
Hi, On Fri, Aug 12, 2016 at 2:08 PM, Akshay Bhat wrote: > From: Ken Lin > > Avoid getting sample rate on B850V3 CP2114 as it is unsupported and > causes noisy "current rate is different from the runtime rate" messages > when playback starts. > > Signed-off-by: K

Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

2016-08-29 Thread Akshay Bhat
On 08/29/2016 10:13 AM, Takashi Iwai wrote: On Mon, 29 Aug 2016 16:10:03 +0200, Akshay Bhat wrote: Hi, On Fri, Aug 12, 2016 at 2:08 PM, Akshay Bhat wrote: From: Ken Lin Avoid getting sample rate on B850V3 CP2114 as it is unsupported and causes noisy "current rate is different fro

Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

2016-08-30 Thread Akshay Bhat
On 08/29/2016 10:49 AM, Takashi Iwai wrote: Gah, then it was a different one. Obviously I overlooked your patch during my vacation. Will put it to the queue. But, this message should appear only once in the recent version. Does it still annoy as appearing repeatedly at all...? Hi Takash

Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop

2016-03-28 Thread Akshay Bhat
Hi Shawn, On 02/28/2016 08:56 AM, Fabio Estevam wrote: Rob, On Thu, Jan 28, 2016 at 6:28 PM, Akshay Bhat wrote: I have no objections against the idea and the code itself. But as Guenter pointed out: it would be handy to get feedback from the devicetree maintainers on the above discussion

Re: [PATCH] component: remove device from master match list on failed add

2016-02-11 Thread Akshay Bhat
Daniel Stone collabora.com> writes: > > Fixes: ffc30b74fd6d01588bd3fdebc3b1acc0857e6fc8 > Signed-off-by: Daniel Stone collabora.com> Tested-by: Akshay Bhat Tested on imx6 processor based board where re-probe was broken after a probe deferral.

[PATCH] drm/panel: simple: fix g121x1_l03 hsync/vsync polarity

2016-03-01 Thread Akshay Bhat
Set hsync/vsync to active low for g121x1_l03 panel to match the recommended setting in datasheet. Signed-off-by: Akshay Bhat --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c

[PATCH] DT: i2c: Add Epson RX8010 to list of trivial devices

2015-12-23 Thread Akshay Bhat
This adds devicetree documentation for the bindings of rtc-rx8010 driver. Signed-off-by: Akshay Bhat --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation

[PATCH] DT: i2c: Add Freescale MPL3115 to trivial devices list

2015-12-23 Thread Akshay Bhat
This adds devicetree documentation for the bindings of mpl3115 driver. Signed-off-by: Akshay Bhat --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation

[PATCH] DT: i2c: Update vendor prefix for 24c00

2015-12-23 Thread Akshay Bhat
"at" is not a valid vendor prefix, correcting the same to "atmel" Signed-off-by: Akshay Bhat --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i2c/tr

[PATCH] USB: cp210x: add IDs for GE B650V3 and B850V3 boards

2016-02-01 Thread Akshay Bhat
From: Ken Lin Add USB ID for cp2104/5 devices on GE B650v3 and B850v3 boards. Signed-off-by: Ken Lin Signed-off-by: Akshay Bhat --- drivers/usb/serial/cp210x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index 987813b

Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop

2016-01-28 Thread Akshay Bhat
Rob, On 12/28/2015 11:29 AM, Wim Van Sebroeck wrote: Hi Tim, On Wed, Dec 2, 2015 at 12:54 PM, Tim Harvey wrote: On Wed, Dec 2, 2015 at 11:11 AM, Akshay Bhat wrote: On 11/06/2015 05:02 PM, Guenter Roeck wrote: On Fri, Nov 06, 2015 at 11:53:42AM -0800, Tim Harvey wrote: On Thu, Nov 5

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-04-04 Thread Akshay Bhat
On 04/04/2017 11:34 AM, Marc Kleine-Budde wrote: > On 03/24/2017 06:20 PM, Akshay Bhat wrote: >> Hi Marc, >> >> On 03/17/2017 05:10 PM, Akshay Bhat wrote: >>> This patch adds support for the Holt HI-311x CAN controller. The HI311x >>> CAN controller i

[PATCH v2] rtc: rx8010: Fix for incorrect return value

2017-11-08 Thread Akshay Bhat
The err variable is not being reset after a successful read. Explicitly return 0 at the end of function call to account for all return paths. Reported-by: Jens-Peter Oswald Signed-off-by: Akshay Bhat --- v2: Address comments from Alexandre Belloni - Return 0 at end of function instead of

Re: [PATCH 3/3] rtc: rx8010: Fix for incorrect return value

2017-11-08 Thread Akshay Bhat
On Tue, Nov 7, 2017 at 9:30 PM, Alexandre Belloni wrote: > On 03/11/2017 at 13:32:41 -0400, Akshay Bhat wrote: >> if (err != 2) >> return err < 0 ? err : -EIO; >> + err = 0; > > Isn't it simpler to make the function return 0 instead of

[PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

2016-08-12 Thread Akshay Bhat
From: Ken Lin Avoid getting sample rate on B850V3 CP2114 as it is unsupported and causes noisy "current rate is different from the runtime rate" messages when playback starts. Signed-off-by: Ken Lin Signed-off-by: Akshay Bhat --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertio