not
produce error/warning messages if the firmware file is not found, but
will still attempt to query the usermodehelper for the optional
firmware. Effectively, FW_OPT_UEVENT | FW_OPT_FALLBACK | FW_OPT_NO_WARN.
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_class.c | 27
fer a
different strategy to tackle this issue.
Andres Rodriguez (1):
firmware: add a function to load optional firmware
drivers/base/firmware_class.c | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
--
2.14.1
not
produce error/warning messages if the firmware file is not found, but
will still attempt to query the usermodehelper for the optional
firmware. Effectively, FW_OPT_UEVENT | FW_OPT_FALLBACK | FW_OPT_NO_WARN.
v2: add header prototype, use updated opt_flags
Signed-off-by: Andres Rodriguez
Hi Luis,
Thanks for all your feedback, greatly appreciated.
On 2018-03-10 09:40 AM, Luis R. Rodriguez wrote:
On Sat, Mar 10, 2018 at 6:35 AM, Luis R. Rodriguez wrote:
You also I take it have users in
mind? I'd like to see at least one user of the API or this fixing a
reported issue. Ie, if us
On 2018-03-13 12:38 PM, Luis R. Rodriguez wrote:
On Tue, Mar 13, 2018 at 03:39:23PM +0200, Kalle Valo wrote:
"Luis R. Rodriguez" writes:
On Mon, Mar 12, 2018 at 12:10:47AM +0100, Arend van Spriel wrote:
On 3/11/2018 5:05 PM, Andres Rodriguez wrote:
Your patch series then should
Including:
- Fixup outdated kernel-doc paths
- Slightly too short title underline
- Some typos
Signed-off-by: Andres Rodriguez
---
Hey Greg,
Here is the patch rebased on gregkh/driver-core-linus as requested.
Note that there is a patch by Hans de Goede that contains
some of the path fixes
The ASCII art illustration should be marked as a preformatted text
block. Otherwise the build will fail when attempting to parse it.
Fixes: bdecb33af34f ( "usb: typec: API for controlling USB ..." )
Signed-off-by: Andres Rodriguez
---
Documentation/driver-api/usb/typec.rst | 2
everyone that chimed in.
I'll be following up with some proposals for the async API. Hopefully we can
end up with something that is not "the least bad" option.
This series can be found in the for-luis-v4 branch of:
https://github.com/lostgoat/linux.git
Andres Rodriguez (9):
This reduces the unnecessary spew when trying to load optional firmware:
"Direct firmware load for ... failed with error -2"
Signed-off-by: Andres Rodriguez
Acked-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
Some basic definitions for the FW_OPT_* values
v2: Documentation corrections from Luis.
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_loader/firmware.h | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/base/firmware_loader/firmware.h
b/drivers/base
This should let us associate enum kdoc to these values.
v2: use BIT() macro
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_loader/fallback.c | 12 ++--
drivers/base/firmware_loader/fallback.h | 6 --
drivers/base/firmware_loader/firmware.h | 18
.
Signed-off-by: Andres Rodriguez
---
drivers/net/wireless/ath/ath10k/testmode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/testmode.c
b/drivers/net/wireless/ath/ath10k/testmode.c
index 568810b41657..0beb91be1b1c 100644
--- a/drivers/net
Use the correct prefix for symbols exported by firmware_loader(). This
is done since firmware_sysfs_fallback() is now exposed through
kernel-doc.
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_loader/fallback.c | 8
drivers/base/firmware_loader/fallback.h | 4 ++--
drivers
The kernel-doc spec dictates a function name ends in ().
Signed-off-by: Andres Rodriguez
Acked-by: Randy Dunlap
---
drivers/base/firmware_loader/fallback.c | 8
drivers/base/firmware_loader/main.c | 22 +++---
2 files changed, 15 insertions(+), 15 deletions
_nowait for now, since we lack agreement on the API
[0]: https://git.kernel.org/linus/c0cc00f250e1
Signed-off-by: Andres Rodriguez
---
.../driver-api/firmware/request_firmware.rst | 5 +
drivers/base/firmware_loader/main.c| 24 ++
include/linux
Including:
- Fixup outdated kernel-doc paths
- Slightly too short title underline
- Some typos
Signed-off-by: Andres Rodriguez
---
Documentation/driver-api/firmware/request_firmware.rst | 16
drivers/base/firmware_loader/fallback.c| 4 ++--
drivers/base
ame to the fallback path spew in order
to associate it with the appropriate request.
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_loader/fallback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/firmware_loader/fallback.c
b/drivers/base/firmware_loader/
On 2018-05-03 07:42 PM, Luis R. Rodriguez wrote:
On Mon, Apr 23, 2018 at 04:12:02PM -0400, Andres Rodriguez wrote:
Previously, one could assume the firmware name from the preceding
message: "Direct firmware load for {name} failed with error %d".
However, with the new firmware_requ
On 2018-04-20 06:26 AM, Kalle Valo wrote:
Andres Rodriguez writes:
This reduces the unnecessary spew when trying to load optional firmware:
"Direct firmware load for ... failed with error -2"
Signed-off-by: Andres Rodriguez
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/
27;ve also included patches for the following consumer drivers:
- amdgpu
- ath10k
- brcmfmac
Thanks again for your feedback.
Regards,
Andres
Andres Rodriguez (8):
firmware: some documentation fixes
firmware: wrap FW_OPT_* into an enum
firmware: add kernel-doc for enum fw_opt
fir
This should let us associate enum kdoc to these values.
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_loader/fallback.c | 12 ++--
drivers/base/firmware_loader/fallback.h | 6 --
drivers/base/firmware_loader/firmware.h | 17 +
drivers/base
This reduces the unnecessary spew when trying to load optional firmware:
"Direct firmware load for ... failed with error -2"
Signed-off-by: Andres Rodriguez
---
drivers/net/wireless/ath/ath10k/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wi
This reduces the unnecessary spew when trying to load optional firmware:
"Direct firmware load for ... failed with error -2"
Signed-off-by: Andres Rodriguez
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
di
Some basic definitions for the FW_OPT_* values
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_loader/firmware.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/base/firmware_loader/firmware.h
b/drivers/base/firmware_loader/firmware.h
index 957396293b92
ame to the fallback path spew in order
to associate it with the appropriate request.
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_loader/fallback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/firmware_loader/fallback.c
b/drivers/base/firmware_loader/
]: https://git.kernel.org/linus/c0cc00f250e1
Signed-off-by: Andres Rodriguez
---
.../driver-api/firmware/request_firmware.rst | 13 --
drivers/base/firmware_loader/main.c| 52 --
include/linux/firmware.h | 6 +++
3 files changed
.
This patch switches the amdgpu to use firmware_request_nowarn(), which
will not produce the warnings mentioned above. Hopefully resulting in a
cleaner bootup log.
Signed-off-by: Andres Rodriguez
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4
Including:
- Fixup outdated kernel-doc paths
- Slightly too short title underline
- Some typos
Signed-off-by: Andres Rodriguez
---
Documentation/driver-api/firmware/request_firmware.rst | 16
drivers/base/firmware_loader/fallback.c| 4 ++--
drivers/base
On 2018-05-08 02:12 PM, Luis R. Rodriguez wrote:
Clarify the provenance of the firmware loader firmware_class module name
and why we cannot rename the module in the future.
Signed-off-by: Luis R. Rodriguez
---
.../driver-api/firmware/fallback-mechanisms.rst | 9 ++---
1 file c
confusion on whether the
firmware load succeed or not.
These are my 2c in the matter.
Regards,
Andres
Regards,
Christian.
Am 17.04.2018 um 00:24 schrieb Andres Rodriguez:
Currently, during the normal boot process the amdgpu driver will produce
spew like the following in dmesg:
Direct firmware l
This reduces the unnecessary spew when trying to load optional firmware:
"Direct firmware load for ... failed with error -2"
Signed-off-by: Andres Rodriguez
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
di
ame to the fallback path spew in order
to associate it with the appropriate request.
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_loader/fallback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/firmware_loader/fallback.c
b/drivers/base/firmware_loader/
This reduces the unnecessary spew when trying to load optional firmware:
"Direct firmware load for ... failed with error -2"
Signed-off-by: Andres Rodriguez
---
drivers/net/wireless/ath/ath10k/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wi
Including:
- Fixup outdated kernel-doc paths
- Slightly too short title underline
- Some typos
Signed-off-by: Andres Rodriguez
---
Documentation/driver-api/firmware/request_firmware.rst | 16
drivers/base/firmware_loader/fallback.c| 4 ++--
drivers/base
.
This patch switches the amdgpu to use firmware_request_nowarn(), which
will not produce the warnings mentioned above. Hopefully resulting in a
cleaner bootup log.
Signed-off-by: Andres Rodriguez
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4
kernel-doc style
[0]: https://git.kernel.org/linus/c0cc00f250e1
Signed-off-by: Andres Rodriguez
---
.../driver-api/firmware/request_firmware.rst | 13 --
drivers/base/firmware_loader/main.c| 52 --
include/linux/firmware.h
The kernel-doc spec dictates a function name ends in ().
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_loader/fallback.c | 8
drivers/base/firmware_loader/main.c | 22 +++---
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/base
This re-spin includes fixes for the kernel-doc style as pointed
out by Randy Dunlap. Otherwise it should be functionally identical
to the previous iteration.
New changes can be found in patches 4 & 5.
Andres Rodriguez (9):
firmware: some documentation fixes
firmware: wrap FW_OPT_* int
Some basic definitions for the FW_OPT_* values
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_loader/firmware.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/base/firmware_loader/firmware.h
b/drivers/base/firmware_loader/firmware.h
index 957396293b92
This should let us associate enum kdoc to these values.
Signed-off-by: Andres Rodriguez
---
drivers/base/firmware_loader/fallback.c | 12 ++--
drivers/base/firmware_loader/fallback.h | 6 --
drivers/base/firmware_loader/firmware.h | 17 +
drivers/base
On 2018-04-17 11:33 AM, Christian König wrote:
Am 17.04.2018 um 17:07 schrieb Andres Rodriguez:
On 2018-04-17 04:48 AM, Christian König wrote:
Well this is a rather big NAK for this patch.
Only a small fraction of the firmware files amdgpu uses are actually
optional (the ones with the
On 2018-04-17 11:52 AM, Christian König wrote:
Am 17.04.2018 um 17:41 schrieb Andres Rodriguez:
On 2018-04-17 11:33 AM, Christian König wrote:
Am 17.04.2018 um 17:07 schrieb Andres Rodriguez:
On 2018-04-17 04:48 AM, Christian König wrote:
Well this is a rather big NAK for this patch
On 2018-04-17 12:41 PM, Andres Rodriguez wrote:
On 2018-04-17 11:52 AM, Christian König wrote:
Am 17.04.2018 um 17:41 schrieb Andres Rodriguez:
On 2018-04-17 11:33 AM, Christian König wrote:
Am 17.04.2018 um 17:07 schrieb Andres Rodriguez:
On 2018-04-17 04:48 AM, Christian König
43 matches
Mail list logo
