Re: [PATCH, resend] kfifo: initialize fifo accordingly to C99 standard

2012-11-29 Thread Andy Shevchenko
On Thu, Nov 29, 2012 at 1:56 AM, Andrew Morton wrote: > On Wed, 21 Nov 2012 16:31:11 +0200 > Andy Shevchenko wrote: > >> When build a kernel with "make W=1" we will get a warning about missing >> initializer. It comes from kfifo usage style. The DEFINE_KFIFO macr

Re: [PATCH, resend] kfifo: initialize fifo accordingly to C99 standard

2012-11-29 Thread Andy Shevchenko
On Thu, Nov 29, 2012 at 11:21 AM, Andy Shevchenko wrote: > On Thu, Nov 29, 2012 at 1:56 AM, Andrew Morton > wrote: >> On Wed, 21 Nov 2012 16:31:11 +0200 >> Andy Shevchenko wrote: >> >>> When build a kernel with "make W=1" we will get a warning about m

Re: [PATCH, resend] kfifo: initialize fifo accordingly to C99 standard

2012-11-29 Thread Andy Shevchenko
On Thu, Nov 29, 2012 at 3:51 AM, Andrew Morton wrote: > On Wed, 21 Nov 2012 16:31:11 +0200 > Andy Shevchenko wrote: > >> When build a kernel with "make W=1" we will get a warning about missing >> initializer. It comes from kfifo usage style. The DEFINE_KFIFO macr

[PATCH] dw_dmac: don't wait for FIFO_EMPTY endlessly in dwc_chan_pause

2013-03-21 Thread Andy Shevchenko
leted. Signed-off-by: Andy Shevchenko --- drivers/dma/dw_dmac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index 43a5329..43e2e89 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma/dw_dmac.c @@ -1030,10 +10

[PATCH] dw_dmac: fix typo in Kconfig

2013-03-21 Thread Andy Shevchenko
The commit c30f46bc (drivers/Kconfig: add several missing GENERIC_HARDIRQS dependencies) introduced a warning on make defconfig stage. This patch fixes a typo. Signed-off-by: Andy Shevchenko --- drivers/dma/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma

[PATCH] dw_dmac: add support for Lynxpoint DMA controllers

2013-02-07 Thread Andy Shevchenko
From: Mika Westerberg Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated from ACPI namespace with ACPI ID INTL9C60. Signed-off-by: Andy Shevchenko --- drivers/dma/dw_dmac.c |6

Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

2013-02-07 Thread Andy Shevchenko
On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar wrote: > On 7 February 2013 21:06, Andy Shevchenko > wrote: >> From: Mika Westerberg >> >> Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general >> purpose serial buses like SPI, I2C, and HSUART.

Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

2013-02-07 Thread Andy Shevchenko
On Fri, Feb 8, 2013 at 6:28 AM, Viresh Kumar wrote: > On Thu, Feb 7, 2013 at 10:35 PM, Andy Shevchenko > wrote: >> On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar wrote: >>> On 7 February 2013 21:06, Andy Shevchenko >>> wrote: >>>> From: Mika Westerber

[PATCH] platform: fall-back to driver name check if there is no id found

2013-02-08 Thread Andy Shevchenko
to match by the driver name. This will make it similar to the DT or ACPI cases. Signed-off-by: Andy Shevchenko Reported-by: Mika Westerberg Cc: Eric Miao Cc: Greg Kroah-Hartman --- drivers/base/platform.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base

[PATCH, resend] platform: fall-back to driver name check if there is no id found

2013-02-11 Thread Andy Shevchenko
to match by the driver name. This will make it similar to the DT or ACPI cases. Signed-off-by: Andy Shevchenko Reported-by: Mika Westerberg Cc: Eric Miao Cc: Greg Kroah-Hartman --- drivers/base/platform.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base

[PATCH 4/6] dma: coh901318_lli: set residue only if dma is in progress

2013-02-12 Thread Andy Shevchenko
When status is DMA_SUCCESS the residue should be zero. Otherwise it's a bug. Signed-off-by: Andy Shevchenko Cc: Linus Walleij Cc: linux-arm-ker...@lists.infradead.org --- drivers/dma/coh901318.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/coh90131

[PATCH 1/6] of: dma: protect list write operation by spin_lock

2013-02-12 Thread Andy Shevchenko
It's possible to have an inconsistency in the list due to unprotected operation on it. The patch adds a proper locking on the list operation. Signed-off-by: Andy Shevchenko Acked-by: Rob Herring --- drivers/of/dma.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/of/dm

[PATCH 0/6] dma: various fixes in different DMAC drivers

2013-02-12 Thread Andy Shevchenko
This is a patcset of independent fixes of the DMAC drivers. They are simple and being understandable in their context. Andy Shevchenko (6): of: dma: protect list write operation by spin_lock dmaengine.h: remove redundant else keyword dma: coh901318_lli: avoid unbalanced locking dma

[PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking

2013-02-12 Thread Andy Shevchenko
I have not checked the code but there is a possibility that custom pool->lock is not needed at all due to dma_pool contains it's own lock. Signed-off-by: Andy Shevchenko Cc: Linus Walleij Cc: linux-arm-ker...@lists.infradead.org --- drivers/dma/coh901318_lli.c |2 +- 1 file ch

[PATCH 5/6] edma: do not waste memory for dma_mask

2013-02-12 Thread Andy Shevchenko
Accordingly to commentary in the platform_device_register_full the memory allocated for dma_mask will not going to be freed. That's why is better to assign dma_mask afterwards. Signed-off-by: Andy Shevchenko --- drivers/dma/edma.c |6 -- 1 file changed, 4 insertions(+), 2 dele

[PATCH 2/6] dmaengine.h: remove redundant else keyword

2013-02-12 Thread Andy Shevchenko
dmaengine_device_control returns -ENOSYS in case the dma driver doesn't have such functionality. Signed-off-by: Andy Shevchenko --- include/linux/dmaengine.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h

[PATCH 6/6] dma: tegra20-apb-dma: remove unnecessary assignment

2013-02-12 Thread Andy Shevchenko
There is no need to assign 0 to residue, because dma_cookie_status() does this for us. Signed-off-by: Andy Shevchenko --- drivers/dma/tegra20-apb-dma.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index 46e4630..fcee27e

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Andy Shevchenko
On Tue, Feb 12, 2013 at 5:56 PM, Vinod Koul wrote: > On Wed, Jan 30, 2013 at 09:32:56AM +0200, Andy Shevchenko wrote: >> On Tue, 2013-01-29 at 20:57 +0530, Viresh Kumar wrote: >> > On Tue, Jan 29, 2013 at 10:52 AM, Mika Westerberg >> > wrote: >> > > We ha

Re: [PATCH] dw_dmac: apply default dma_mask if needed

2013-02-12 Thread Andy Shevchenko
On Tue, Feb 12, 2013 at 6:16 PM, Vinod Koul wrote: > On Tue, Jan 29, 2013 at 05:06:24PM +0200, Andy Shevchenko wrote: >> In some cases we got the device without dma_mask configured. We have to apply >> the default value to avoid crashes during memory mapping. >> > what wa

Re: [PATCH 07/33] dma: Convert to devm_ioremap_resource()

2013-01-29 Thread Andy Shevchenko
rent address spaces) drivers/dma/dw_dmac.c:1691:32:expected void const *ptr drivers/dma/dw_dmac.c:1691:32:got void [noderef] *[assigned] regs -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

[PATCH] dw_dmac: apply default dma_mask if needed

2013-01-29 Thread Andy Shevchenko
In some cases we got the device without dma_mask configured. We have to apply the default value to avoid crashes during memory mapping. Signed-off-by: Andy Shevchenko --- drivers/dma/dw_dmac.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-01-29 Thread Andy Shevchenko
T is a platform device (see drivers/acpi/csrt.c for the details). That's why we have to pass this info somehow to the DMAC driver. And like Mika already mentioned we have no other generic way except IORESOURCE_DMA. If you have something better in mind, please share. We could adopt our code the

Re: [PATCH v5 03/14] ARM: edma: add AM33XX support to the private EDMA API

2013-01-29 Thread Andy Shevchenko
On Wed, Jan 30, 2013 at 8:41 AM, Matt Porter wrote: > On Mon, Jan 28, 2013 at 09:27:24PM +0200, Andy Shevchenko wrote: >> On Tue, Jan 15, 2013 at 10:32 PM, Matt Porter wrote: >> > Adds support for parsing the TI EDMA DT data into the required >> > EDMA private API pla

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-01-30 Thread Andy Shevchenko
On Wed, 2013-01-30 at 13:31 +0530, Viresh Kumar wrote: > On Wed, Jan 30, 2013 at 1:02 PM, Andy Shevchenko > wrote: > > We get a device from the ACPI CSRT table. During enumeration we don't > > know what kind of the device it is. From the enumeration point of view > >

Re: [PATCH v2 4/4] dw_dmac: return proper residue value

2013-01-24 Thread Andy Shevchenko
On Thu, 2013-01-24 at 10:37 +0530, Viresh Kumar wrote: > On Wed, Jan 23, 2013 at 9:07 PM, Andy Shevchenko > wrote: > > diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c > > > static void dwc_scan_descriptors(struct dw_dma *dw, struct

[PATCH v3 4/4] dw_dmac: return proper residue value

2013-01-24 Thread Andy Shevchenko
by this patch due to len field in the descriptor structure is left untouched by the original code. Signed-off-by: Andy Shevchenko --- drivers/dma/dw_dmac.c | 44 +--- drivers/dma/dw_dmac_regs.h |1 + 2 files changed, 42 insertions(+), 3 deletions

[PATCH v3 3/4] dw_dmac: fill individual length of descriptor

2013-01-24 Thread Andy Shevchenko
It will be useful to have the length of the transfer in the descriptor. The cyclic transfer functions remained untouched. Signed-off-by: Andy Shevchenko Acked-by: Viresh Kumar --- drivers/dma/dw_dmac.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/dw_dmac.c b/drivers

[PATCH v3 2/4] dw_dmac: introduce total_len field in struct dw_desc

2013-01-24 Thread Andy Shevchenko
By this new field we distinguish a total length of the chain and the individual length of each descriptor in the chain. Signed-off-by: Andy Shevchenko Acked-by: Viresh Kumar --- drivers/dma/dw_dmac.c | 12 ++-- drivers/dma/dw_dmac_regs.h |1 + 2 files changed, 7 insertions

[PATCH v3 1/4] dw_dmac: remove unnecessary tx_list field in dw_dma_chan

2013-01-24 Thread Andy Shevchenko
The soft LLP mode is working for active descriptor only. So, we do not need to have a copy of its pointer. Signed-off-by: Andy Shevchenko Acked-by: Viresh Kumar --- drivers/dma/dw_dmac.c | 20 +++- drivers/dma/dw_dmac_regs.h |1 - 2 files changed, 15 insertions(+), 6

[PATCH v3 0/4] dw_dmac: return actual residue value

2013-01-24 Thread Andy Shevchenko
Since v1: - everything is rewritten to address Viresh's and Vinod's comments. *** BLURB HERE *** Andy Shevchenko (4): dw_dmac: remove unnecessary tx_list field in dw_dma_chan dw_dmac: introduce total_len field in struct dw_desc dw_dmac: fill individual length of descriptor dw_dm

Re: [PATCH v3 4/4] dw_dmac: return proper residue value

2013-01-24 Thread Andy Shevchenko
On Thu, Jan 24, 2013 at 12:45 PM, Viresh Kumar wrote: > On Thu, Jan 24, 2013 at 4:04 PM, Andy Shevchenko > wrote: > > I don't see residue - len from interrupt handler. It isn't required? Where exactly? >> @@ -1062,6 +1090,7 @@ dwc_tx_status(struct dma_chan *c

[PATCH v3.5] dw_dmac: return proper residue value

2013-01-24 Thread Andy Shevchenko
by this patch due to len field in the descriptor structure is left untouched by the original code. Signed-off-by: Andy Shevchenko --- drivers/dma/dw_dmac.c | 47 ++-- drivers/dma/dw_dmac_regs.h |1 + 2 files changed, 46 insertions(+), 2 deletions

Re: [PATCH v3.5] dw_dmac: return proper residue value

2013-01-25 Thread Andy Shevchenko
On Fri, 2013-01-25 at 09:43 +0530, Viresh Kumar wrote: > On Thu, Jan 24, 2013 at 6:37 PM, Andy Shevchenko > wrote: > > Currently the driver returns full length of the active descriptor which is > > wrong. We have to go throught the active descriptor and substract the > >

Re: [PATCH v3.5] dw_dmac: return proper residue value

2013-01-25 Thread Andy Shevchenko
On Fri, Jan 25, 2013 at 10:56 AM, Andy Shevchenko wrote: > On Fri, 2013-01-25 at 09:43 +0530, Viresh Kumar wrote: >> On Thu, Jan 24, 2013 at 6:37 PM, Andy Shevchenko >> wrote: >> > diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c >> > +static

Re: [PATCH v3.5] dw_dmac: return proper residue value

2013-01-25 Thread Andy Shevchenko
On Fri, Jan 25, 2013 at 11:07 AM, Viresh Kumar wrote: > On 25 January 2013 14:34, Andy Shevchenko wrote: >> Okay, we have to have a protection here because get_sent reads two >> registers consequentially. This means we could end up with scenario >> with threads 1 and 2 >

Re: [PATCH v3.5] dw_dmac: return proper residue value

2013-01-25 Thread Andy Shevchenko
On Fri, Jan 25, 2013 at 11:39 AM, Viresh Kumar wrote: > On 25 January 2013 15:07, Andy Shevchenko wrote: >> Yeah, the keyword is "look". 1 per million cases it could be true. I >> think this discussion is going to the dead end. >> Anyone else would like to arg

Re: [PATCH v3.5] dw_dmac: return proper residue value

2013-01-25 Thread Andy Shevchenko
On Fri, Jan 25, 2013 at 11:30 AM, Viresh Kumar wrote: > On Fri, Jan 25, 2013 at 2:49 PM, Andy Shevchenko > wrote: >> On Fri, Jan 25, 2013 at 11:07 AM, Viresh Kumar >> wrote: >>> Who is going to right on ctlhi/lo? > > Ahh, my English :( (/s/right/write) >

[PATCH v4 3/4] dw_dmac: fill individual length of descriptor

2013-01-25 Thread Andy Shevchenko
It will be useful to have the length of the transfer in the descriptor. The cyclic transfer functions remained untouched. Signed-off-by: Andy Shevchenko Acked-by: Viresh Kumar --- drivers/dma/dw_dmac.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/dw_dmac.c b/drivers

[PATCH v4 1/4] dw_dmac: remove unnecessary tx_list field in dw_dma_chan

2013-01-25 Thread Andy Shevchenko
The soft LLP mode is working for active descriptor only. So, we do not need to have a copy of its pointer. Signed-off-by: Andy Shevchenko Acked-by: Viresh Kumar --- drivers/dma/dw_dmac.c | 20 +++- drivers/dma/dw_dmac_regs.h |1 - 2 files changed, 15 insertions(+), 6

[PATCH v4 0/4] dw_dmac: return actual residue value

2013-01-25 Thread Andy Shevchenko
get rid of dwc_update_residue(): for soft LLP mode we assign residue in dwc_do_start() and decrease it at each interrupt. In the middle of transfer we will return that result substracted by amount of sent bytes Since v1: - everything is rewritten to address Viresh's and Vinod's comments. Andy Shevc

[PATCH v4 2/4] dw_dmac: introduce total_len field in struct dw_desc

2013-01-25 Thread Andy Shevchenko
By this new field we distinguish a total length of the chain and the individual length of each descriptor in the chain. Signed-off-by: Andy Shevchenko Acked-by: Viresh Kumar --- drivers/dma/dw_dmac.c | 12 ++-- drivers/dma/dw_dmac_regs.h |1 + 2 files changed, 7 insertions

[PATCH v4 4/4] dw_dmac: return proper residue value

2013-01-25 Thread Andy Shevchenko
by this patch due to len field in the descriptor structure is left untouched by the original code. Signed-off-by: Andy Shevchenko --- drivers/dma/dw_dmac.c | 47 ++-- drivers/dma/dw_dmac_regs.h |1 + 2 files changed, 46 insertions(+), 2 deletions

[PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-01-28 Thread Andy Shevchenko
On some hardware configurations we have got the request line with the offset. The patch introduces convert_slave_id() helper for that cases. The request line base is got from the platform device resources provided by the IORESOURCE_DMA type. Signed-off-by: Mika Westerberg Signed-off-by: Andy

Re: [PATCH] dw_dmac: move soft LLP code from tasklet to dwc_scan_descriptors

2013-01-28 Thread Andy Shevchenko
On Mon, 2013-01-28 at 04:10 -0800, Vinod Koul wrote: > > On Fri, Jan 18, 2013 at 5:44 PM, Andy Shevchenko > > > The proper place for the main logic of the soft LLP mode is > > > dwc_scan_descriptors. It prevents to get the transfer unexpectedly > > > abo

Re: [PATCH v5 03/14] ARM: edma: add AM33XX support to the private EDMA API

2013-01-28 Thread Andy Shevchenko
rm_get_irq_byname(pdev, irq_name); > + if (node) > + err_irq[j] = irq_of_parse_and_map(node, 2); > + else { > + sprintf(irq_name, "edma%d_err", j); > + err_irq[j] = platform_get_irq_byname

Re: [PATCH v5 07/14] dmaengine: add dma_request_slave_channel_compat()

2013-01-28 Thread Andy Shevchenko
gt; -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-19 Thread Andy Shevchenko
On Mon, 2013-01-28 at 13:04 +0200, Andy Shevchenko wrote: > On some hardware configurations we have got the request line with the offset. > The patch introduces convert_slave_id() helper for that cases. The request > line > base is got from the platform device resources pro

[PATCHv2] dw_dmac: adjust slave_id accordingly to request line base

2013-02-20 Thread Andy Shevchenko
On some hardware configurations we have got the request line with the offset. The patch introduces convert_slave_id() helper for that cases. The request line base is came from the driver data provided by the platform_device_id table. Signed-off-by: Mika Westerberg Signed-off-by: Andy Shevchenko

[PATCH] events: always do slow path when trying to find a pmu

2013-02-20 Thread Andy Shevchenko
ase the idr_alloc is never called, but idr_find is. The hint field is never initialized and could not be dereferenced. The proposed fix uses the idr_slowpath call which reflects old behaviour. Signed-off-by: Andy Shevchenko Reported-by: Kirill A. Shutemov --- kernel/events/core.c | 2 +- 1 file

Re: [PATCH] events: always do slow path when trying to find a pmu

2013-02-20 Thread Andy Shevchenko
On Wed, Feb 20, 2013 at 7:16 PM, Tejun Heo wrote: > On Wed, Feb 20, 2013 at 07:09:36PM +0200, Andy Shevchenko wrote: >> The guilty commit is cc5b5f6 "events: convert to idr_alloc()" together with >> f49318a "idr: implement lookup hint". In our case the idr_allo

Re: [PATCHv2] dw_dmac: adjust slave_id accordingly to request line base

2013-02-22 Thread Andy Shevchenko
On Wed, Feb 20, 2013 at 1:52 PM, Andy Shevchenko wrote: > On some hardware configurations we have got the request line with the offset. > The patch introduces convert_slave_id() helper for that cases. The request > line > base is came from the driver data provided by the platform_dev

Re: [PATCH 1/2] dw_dmac: make driver endianness configurable

2012-09-03 Thread Andy Shevchenko
You right. I have a patch to support few options like that already. However, I can't share it yet by some legal reasons. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel

Re: [PATCH v4 2/3] dw_dmac: max_mem_width limits value for SRC/DST_TR_WID register

2012-09-03 Thread Andy Shevchenko
0 > +#defineDW_MEM_WIDTH_32 1 /* e.g. for avr32 */ > + u8 max_mem_width; Might be I missed something, but why is it slave configuration? I think the controller (actually channel) structure is more suitable to keep that field inside. -- With Best Reg

Re: [PATCH v4 3/3] avr32: at32ap700x: set DMA slave properties for MCI dw_dmac

2012-09-03 Thread Andy Shevchenko
up dst_master as well? > + /* Limit maximum transfer width to 32-bit */ > + slave->sdata.max_mem_width = DW_MEM_WIDTH_32; It's under question regarding to my comments on previous patch. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the lin

Re: [PATCH v4 2/3] dw_dmac: max_mem_width limits value for SRC/DST_TR_WID register

2012-09-03 Thread Andy Shevchenko
On Mon, Sep 3, 2012 at 11:30 AM, Viresh Kumar wrote: > On 3 September 2012 13:55, Andy Shevchenko wrote: >>> #define DW_MEM_WIDTH_64 0 /* default */ >>> #define DW_MEM_WIDTH_32 1 /* e.g. for avr32 */ >> There are 4 options: 32, 64, 128, and

[PATCH] dw_dmac: utilize slave_id to pass request line

2012-09-03 Thread Andy Shevchenko
usage of the custom slave config structure. Signed-off-by: Andy Shevchenko --- drivers/dma/dw_dmac.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index f0c9403..7a67673 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma/dw_dmac.c

Re: [PATCH v4 2/3] dw_dmac: max_mem_width limits value for SRC/DST_TR_WID register

2012-09-03 Thread Andy Shevchenko
down to 2. The first value that works correctly will be > used as the maximum. Oh, it might be good idea to get this value in case neither IP nor platform data provides it. I'm pretty sure the platform device driver has to know this beforehand. -- With Best Regards, Andy Shevchenko

Re: dmatest to use synopsys dma driver (dw_dmac.c)

2012-10-02 Thread Andy Shevchenko
me one > could > (who has used dw_dmac.c) could share their code to use dw_dmac.c. I published all my patches already here in the mailing list. Part of them is under review, but another part has been pushed to the linux-next. I highly encourage you to try most recent version from the li

Re: dmatest to use synopsys dma driver

2012-10-02 Thread Andy Shevchenko
t? Please, follow the discussions in the mailing list. Most of the related patches are tagged as "dw_dmac". -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

[PATCH 4/4] dmaengine: dw_dmac: amend description and indentation

2012-10-02 Thread Andy Shevchenko
From: Heikki Krogerus The driver will be used as a core part for various implementations of the DesignWare DMA device. The patch adjusts description on the top and corrects paragraph indentation in few places across the code. Signed-off-by: Heikki Krogerus Signed-off-by: Andy Shevchenko

[PATCH 2/4] dmaengine: dw_dmac: add module alias

2012-10-02 Thread Andy Shevchenko
From: Heikki Krogerus It's good to have a quasistatic name for the platform driver. Signed-off-by: Heikki Krogerus Signed-off-by: Andy Shevchenko Reviewed-by: Felipe Balbi Acked-by: Viresh Kumar --- drivers/dma/dw_dmac.c |1 + 1 file changed, 1 insertion(+) diff --git a/driver

[PATCH 3/4] dmaengine: dw_dmac: remove CLK dependency

2012-10-02 Thread Andy Shevchenko
From: Heikki Krogerus This driver could be used on different platforms. Thus, the HAVE_CLK dependency is dropped away. Signed-off-by: Heikki Krogerus Signed-off-by: Andy Shevchenko Reviewed-by: Felipe Balbi Acked-by: Viresh Kumar --- drivers/dma/Kconfig |1 - 1 file changed, 1 deletion

[PATCH 0/4] dw_dmac: few cleanups to the driver

2012-10-02 Thread Andy Shevchenko
There are few cleanups to the driver which already acked and reviewed. I decide to split last series to two parts. This is first part. Heikki Krogerus (4): dmaengine: dw_dmac: use helper macro module_platform_driver() dmaengine: dw_dmac: add module alias dmaengine: dw_dmac: remove CLK depend

[PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-02 Thread Andy Shevchenko
From: Heikki Krogerus Since v3.2 we have nice macro to define the platform driver's init and exit calls. This patch simplifies the dw_dmac driver by using that macro. Signed-off-by: Heikki Krogerus Signed-off-by: Andy Shevchenko Reviewed-by: Felipe Balbi Acked-by: Viresh Kumar --- dr

Re: [PATCH 1/3] Fix trailing whitespace in trace.h

2012-10-02 Thread Andy Shevchenko
/') + 1; Moreover there is already basename() in the lib/dynamic_debug.c you could rename, export and reuse. -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/3] Add parenthesis to macros with complex values in trace.h

2012-10-02 Thread Andy Shevchenko
ne TRACE_GOTO(chip, label) goto label > +#define TRACE_RET(chip, ret) return(ret) > +#define TRACE_GOTO(chip, label) goto(label) > #endif In this specific case I think checkpatch.pl wants more than needed. -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this li

[PATCH 3/7] staging: rts_pstor: reuse kbasename()

2012-10-02 Thread Andy Shevchenko
The custom filename function mostly repeats the kernel's kbasename. This patch simplifies it. The updated filename() will not check for the '\' in the filenames. It seems redundant in Linux. Signed-off-by: Andy Shevchenko Cc: YAMANE Toshiaki Cc: Greg Kroah-Hartman ---

[PATCH 6/7] usb: core: reuse kbasename()

2012-10-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org --- drivers/usb/core/file.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/usb/core/file.c b/drivers/usb/core/file.c index e5387a4..eff9af9 100644 --- a/drivers/usb/core

[PATCH 7/7] trace: reuse kbasename() functionality

2012-10-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Steven Rostedt (maintainer:TRACING) Cc: Frederic Weisbecker (maintainer:TRACING) --- kernel/trace/trace_uprobe.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index

[PATCH 2/7] lib: dynamic_debug: reuse kbasename()

2012-10-02 Thread Andy Shevchenko
Remove the custom implementation of the functionality similar to kbasename(). Signed-off-by: Andy Shevchenko Cc: Jason Baron --- lib/dynamic_debug.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index e7f7d99..1db1fc6

[PATCH 5/7] procfs: reuse kbasename() functionality

2012-10-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- fs/proc/proc_devtree.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c index df7dd08..3d9fd66 100644 --- a/fs/proc/proc_devtree.c +++ b/fs/proc/proc_devtree.c @@ -13,6 +13,7

[PATCH 4/7] mm: reuse kbasename() functionality

2012-10-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: linux...@kvack.org --- mm/memory.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 0e3a516..6b101a2 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -58,6 +58,7 @@ #include #include #include

[PATCH 1/7] string: introduce helper to get base file name from given path

2012-10-02 Thread Andy Shevchenko
There are several places in kernel that use functionality like shell's basename function. Let's do it common helper for them. Signed-off-by: Andy Shevchenko Cc: YAMANE Toshiaki --- include/linux/string.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/linu

Re: [PATCH 1/7] string: introduce helper to get base file name from given path

2012-10-02 Thread Andy Shevchenko
On Tue, Oct 2, 2012 at 8:34 PM, Greg KH wrote: > On Tue, Oct 02, 2012 at 06:00:54PM +0300, Andy Shevchenko wrote: >> There are several places in kernel that use functionality like shell's >> basename >> function. Let's do it common helper for them. >> >

Re: [PATCH 6/7] usb: core: reuse kbasename()

2012-10-03 Thread Andy Shevchenko
On Tue, Oct 2, 2012 at 6:00 PM, Andy Shevchenko wrote: > --- a/drivers/usb/core/file.c > +++ b/drivers/usb/core/file.c > @@ -200,14 +200,9 @@ int usb_register_dev(struct usb_interface *intf, > > /* create a usb class device for this usb interface */ > snprintf

[PATCHv2 1/6] string: introduce helper to get base file name from given path

2012-10-03 Thread Andy Shevchenko
There are several places in the kernel that use functionality like basename(3) with the exception: in case of '/foo/bar/' we expect to get an empty string. Let's do it common helper for them. Signed-off-by: Andy Shevchenko --- include/linux/string.h | 11 +++ 1 f

[PATCHv2 3/6] staging: rts_pstor: reuse kbasename()

2012-10-03 Thread Andy Shevchenko
The custom filename function mostly repeats the kernel's kbasename. This patch simplifies it. The updated filename() will not check for the '\' in the filenames. It seems redundant in Linux. Signed-off-by: Andy Shevchenko Cc: YAMANE Toshiaki Cc: Greg Kroah-Hartman ---

[PATCHv2 4/6] mm: reuse kbasename() functionality

2012-10-03 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: linux...@kvack.org --- mm/memory.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 0e3a516..6b101a2 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -58,6 +58,7 @@ #include #include #include

[PATCHv2 6/6] trace: reuse kbasename() functionality

2012-10-03 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Steven Rostedt (maintainer:TRACING) Cc: Frederic Weisbecker (maintainer:TRACING) --- kernel/trace/trace_uprobe.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index

[PATCHv2 5/6] procfs: reuse kbasename() functionality

2012-10-03 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- fs/proc/proc_devtree.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c index df7dd08..3d9fd66 100644 --- a/fs/proc/proc_devtree.c +++ b/fs/proc/proc_devtree.c @@ -13,6 +13,7

[PATCHv2 2/6] lib: dynamic_debug: reuse kbasename()

2012-10-03 Thread Andy Shevchenko
Remove the custom implementation of the functionality similar to kbasename(). Signed-off-by: Andy Shevchenko Cc: Jason Baron --- lib/dynamic_debug.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index e7f7d99..1db1fc6

[PATCHv2 0/6] lib/string: introduce kbasename helper

2012-10-03 Thread Andy Shevchenko
There are several places in kernel that duplicate code to get last part of the pathname. This patchset introduces a helper. Since v1: - fix changelog of the patch 1 - we are doing basname(3) alike helper - usb related patch temporary excluded from series (under discussion with Greg) Andy

[PATCHv2.5] trace: reuse kbasename() functionality

2012-10-03 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Steven Rostedt Cc: Frederic Weisbecker --- kernel/trace/trace_uprobe.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index 03003cd..c7ba4f6 100644 --- a/kernel/trace

Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver

2012-10-03 Thread Andy Shevchenko
st possible size, and keep as much of >> common part in dmac.c... >> >> Similar is done in drivers/mmc/host/sdhci*... > Yes that IMHO would be simpler approach :) Oh, thanks, I got the idea. Will implement soon. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this

Re: [PATCH 1/7] string: introduce helper to get base file name from given path

2012-10-04 Thread Andy Shevchenko
On Wed, 2012-10-03 at 14:39 -0400, Nick Bowler wrote: > On 2012-10-02 11:12 -0700, Greg KH wrote: > > On Tue, Oct 02, 2012 at 08:52:05PM +0300, Andy Shevchenko wrote: > > > On Tue, Oct 2, 2012 at 8:34 PM, Greg KH > > > wrote: [...] > > Well, if you want your

Re: [PATCHv2.5] trace: reuse kbasename() functionality

2012-10-05 Thread Andy Shevchenko
On Fri, Oct 5, 2012 at 7:49 PM, Steven Rostedt wrote: > On Wed, 2012-10-03 at 11:53 +0300, Andy Shevchenko wrote: >> Signed-off-by: Andy Shevchenko >> Cc: Steven Rostedt >> Cc: Frederic Weisbecker >> --- >> kernel/trace/trace_uprobe.c |8 >&

Re: [PATCHv2.5] trace: reuse kbasename() functionality

2012-10-05 Thread Andy Shevchenko
On Fri, Oct 5, 2012 at 8:12 PM, Steven Rostedt wrote: > On Fri, 2012-10-05 at 20:02 +0300, Andy Shevchenko wrote: > >> > I don't see kbasename() anywhere. Is this based off of other patches? >> It's introduced by first patch in the series. > Usually a series

Re: [PATCH] xhci: fix null-pointer dereference when destroying half-built segment rings

2012-11-01 Thread Andy Shevchenko
> -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list:

[PATCH, resend] of: re-use kernel's kbasename()

2012-11-05 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Acked-by: Grant Likely Cc: Rob Herring --- drivers/of/fdt.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index 91a375f..0ca0f9e 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -486,14

[PATCHv2 5/6] dw_dmac: autoconfigure data_width or get it via platform data

2012-09-21 Thread Andy Shevchenko
Not all of the controllers support the 64 bit data width. Make it configurable via platform data. The driver will try to get a value from the component parameters, otherwise it will use the platform data. Signed-off-by: Andy Shevchenko --- arch/arm/mach-spear13xx/spear13xx.c |2 ++ arch

[PATCHv2 4/6] dw_dmac: autoconfigure block_size or use platform data

2012-09-21 Thread Andy Shevchenko
The maximum block size is a configurable parameter for the chip. So, driver will try to get it from the encoded component parameters. Otherwise it will come from the platform data. Signed-off-by: Andy Shevchenko --- arch/arm/mach-spear13xx/spear13xx.c |1 + arch/avr32/mach-at32ap

[PATCHv2 0/6] dw_dmac: introduce autoconfiguration

2012-09-21 Thread Andy Shevchenko
transfers. It means that normal linked list transfer is substituted by set of single block transfers transparently to the user. Since v1: - addressed all Viresh's comments. Andy Shevchenko (6): dw_dmac: mark dwc_dump_chan_regs as inline dw_dmac: fill optional encoded parameters in register stru

[PATCHv2 3/6] dw_dmac: get number of channels from hardware if possible

2012-09-21 Thread Andy Shevchenko
In case the controller has the encoded parameters feature enabled the driver will use it to get the number of channels. In the future it will be used for the other important parameters as well. Signed-off-by: Andy Shevchenko --- drivers/dma/dw_dmac.c | 33 +++-- 1

[PATCHv2 2/6] dw_dmac: fill optional encoded parameters in register structure

2012-09-21 Thread Andy Shevchenko
There is a block of the registers that are optional. However, if enabled they contain useful information about the controller hardware configuration. We will use this piece of data to autoconfigure the driver. Signed-off-by: Andy Shevchenko --- drivers/dma/dw_dmac_regs.h | 30

Re: [PATCHv2 4/6] dw_dmac: autoconfigure block_size or use platform data

2012-09-21 Thread Andy Shevchenko
On Fri, 2012-09-21 at 19:30 +0530, viresh kumar wrote: > On Fri, Sep 21, 2012 at 5:35 PM, Andy Shevchenko > wrote: > > diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c > > @@ -1385,6 +1375,7 @@ static int __devinit dw_probe(struct platform_device > > *pde

[PATCHv3] dw_dmac: autoconfigure data_width or get it via platform data

2012-09-25 Thread Andy Shevchenko
Not all of the controllers support the 64 bit data width. Make it configurable via platform data. The driver will try to get a value from the component parameters, otherwise it will use the platform data. Signed-off-by: Andy Shevchenko --- Since v2: - sometimes memory-to-memory test is failed

[PATCHv1 0/6] dw_dmac: split the driver and introduce PCI part

2012-09-25 Thread Andy Shevchenko
duplicating a core driver functionality. Andy Shevchenko (2): MAINTAINERS: fix indentation for Viresh Kumar MAINTAINERS: add recently created files to dw_dmac section Heikki Krogerus (4): dmaengine: dw_dmac: Remove clk API dependency dmaengine: dw_dmac: add driver for Atmel AT32 dmaengine

[PATCHv1 3/6] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-25 Thread Andy Shevchenko
From: Heikki Krogerus This is the PCI part of the DesignWare DMAC driver. The controller is usually used in the Intel hardware such as Medfield. Signed-off-by: Heikki Krogerus Signed-off-by: Andy Shevchenko --- drivers/dma/Kconfig|9 +++ drivers/dma/Makefile |1

[PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-25 Thread Andy Shevchenko
From: Heikki Krogerus This driver should be usable on all platforms that depend on clk API. Signed-off-by: Heikki Krogerus Signed-off-by: Andy Shevchenko --- drivers/dma/Kconfig|9 +++ drivers/dma/Makefile |1 + drivers/dma/dw_dmac.c | 23 +-- drivers/dma

[PATCHv1 5/6] MAINTAINERS: fix indentation for Viresh Kumar

2012-09-25 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Viresh Kumar --- MAINTAINERS | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8fa0255..479a655 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -572,7 +572,7 @@ F: drivers/net/appletalk/ F

  1   2   3   4   5   6   7   8   9   10   >