Re: [PATCH] PNPACPI: check return value of pnpacpi_parse_allocated_resource() and pnpacpi_parse_resource_option_data()

2014-07-23 Thread Arjun
ACPI 5.0 resource types like FixedDMA will fail pnpacpi_allocated_resource(). pnpacpi_add_device() has to return error in that case. On 23 July 2014 03:42, Rafael J. Wysocki wrote: > On Wednesday, July 23, 2014 12:43:39 AM Arjun Sreedharan wrote: >> Handle error condit

Re: permission to move definition of struct rpmsg_channel_info

2013-09-10 Thread Arjun Gopalan
On 09/08/2013 05:27 AM, Ohad Ben-Cohen wrote: Hi Arjun, On Fri, Aug 30, 2013 at 9:20 PM, Arjun Gopalan wrote: Hi Ohad/Brian, I have been working on rpmsg and I need to be able to create static rpmsg channels. Channel information needs to be specified by other drivers and for this, the

permission to move definition of struct rpmsg_channel_info

2013-08-30 Thread Arjun Gopalan
drivers/rpmsg/virtio_rpmsg_bus.c to include/linux/rpmsg.h ? I have a patch (enclosed inline) for the same. Please let me know if you have any thoughts on this. Thanks. commit 6b6ddce3bbf89f0e0ae42aae799f7ff9b5c4a05b Author: Arjun Gopalan Date: Mon Jul 8 17:34:52 2013 -0700 rpmsg: Create

[REGRESSION, bisect] pci: cxgb4 probe fails after commit 104daa71b3961434 ("PCI: Determine actual VPD size on first access")

2018-01-23 Thread Arjun Vynipadath
Sending on behalf of "Casey Leedom " Way back on April 11, 2016 we reported a regression in Linux kernel 4.6-rc2 brought on by kernel.org commit 104daa71b396. This commit calculates the size of a PCI Device's VPD area by parsing the VPD Structure at offset 0x000, and restricts accesses to the V

Re: pull request: linux-firmware: update cxgb4 firmware

2018-03-27 Thread Arjun V
Hi, Kindly ignore this pull request. We will be shortly sending pull request for a newer firmware which includes critical fixes. Thanks. On 03/15/2018 06:59 PM, Ganesh Goudar wrote: Hi, Kindly pull the new firmware from the following URL. git://git.chelsio.net/pub/git/linux-firmware.git for-u

Re: linux-next: manual merge of the bpf-next tree with the net-next tree

2021-02-14 Thread Arjun Roy
ve, > > copybuf_address): > > case offsetofend(struct tcp_zerocopy_receive, err): > > goto zerocopy_rcv_sk_err; > > case offsetofend(struct tcp_zerocopy_receive, inq): > > With the merge window about to open, this is a reminder that this > conflict still exists. > Sorry, I was confused from the prior email. Is any action required at the moment, or not? Thanks, -Arjun > -- > Cheers, > Stephen Rothwell

[PATCH] docproc: fix potential memory leak in find_all_symbols()

2014-12-11 Thread Arjun Sreedharan
in case realloc() fails, @data is overwritten by NULL losing reference to the memory. This is avoided by @data_old Signed-off-by: Arjun Sreedharan --- scripts/docproc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/docproc.c b/scripts/docproc.c index

[PATCH] calloc/xcalloc: fix argument order

2014-12-06 Thread Arjun Sreedharan
calloc() and xcalloc() takes @nmemb first and then @size. fix all w/ pattern "calloc\s*(\s*sizeof". Signed-off-by: Arjun Sreedharan --- scripts/kconfig/mconf.c| 4 ++-- tools/perf/ui/hist.c | 4 ++-- tools/thermal/tmon/sysfs.c | 6 +++--- 3 files changed, 7 insertions(+), 7

[PATCH] staging: ft1000: Fix code style issue

2015-01-06 Thread Arjun AK
Remove unnecessary braces from single statement blocks. Signed-off-by: Arjun AK --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 101 --- 1 file changed, 35 insertions(+), 66 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging

Re: [PATCH] mn10300: remove redundant hex()

2015-01-26 Thread Arjun Sreedharan
Ping !! On 30 November 2014 at 16:29, Arjun Sreedharan wrote: > replace rendundant hex() with kernel's hex_to_bin() > > Signed-off-by: Arjun Sreedharan > --- > arch/mn10300/kernel/gdb-stub.c | 61 > -- > 1 file changed, 23 i

Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy

2021-01-12 Thread Arjun Roy
On Tue, Jan 12, 2021 at 3:31 PM Roman Gushchin wrote: > > On Tue, Jan 12, 2021 at 01:41:05PM -0800, Shakeel Butt wrote: > > From: Arjun Roy > > > > TCP zerocopy receive is used by high performance network applications to > > further scale. For RX zerocopy, the memo

Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy

2021-01-12 Thread Arjun Roy
On Tue, Jan 12, 2021 at 3:48 PM Roman Gushchin wrote: > > On Tue, Jan 12, 2021 at 03:36:18PM -0800, Arjun Roy wrote: > > On Tue, Jan 12, 2021 at 3:31 PM Roman Gushchin wrote: > > > > > > On Tue, Jan 12, 2021 at 01:41:05PM -0800, Shakeel Butt wrote: > > >

Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy

2021-01-13 Thread Arjun Roy
On Wed, Jan 13, 2021 at 10:48 AM Roman Gushchin wrote: > > On Tue, Jan 12, 2021 at 04:12:08PM -0800, Arjun Roy wrote: > > On Tue, Jan 12, 2021 at 3:48 PM Roman Gushchin wrote: > > > > > > On Tue, Jan 12, 2021 at 03:36:18PM -0800, Arjun Roy wrote: > > >

Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy

2021-01-19 Thread Arjun Roy
> > > > On Tue, Jan 12, 2021 at 04:18:44PM -0800, Shakeel Butt wrote: > > > > > On Tue, Jan 12, 2021 at 4:12 PM Arjun Roy wrote: > > > > > > > > > > > > On Tue, Jan 12, 2021 at 3:48 PM Roman Gushchin wrote: > > > > &

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-24 Thread Arjun Roy
On Wed, Mar 24, 2021 at 2:12 AM Michal Hocko wrote: > > On Tue 23-03-21 11:47:54, Arjun Roy wrote: > > On Tue, Mar 23, 2021 at 7:34 AM Michal Hocko wrote: > > > > > > On Wed 17-03-21 18:12:55, Johannes Weiner wrote: > > > [...] > > > > Here is a

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-24 Thread Arjun Roy
On Wed, Mar 24, 2021 at 11:26 AM Shakeel Butt wrote: > > On Tue, Mar 23, 2021 at 11:42 AM Arjun Roy wrote: > > > [...] > > > > To summarize then, it seems to me that we're on the same page now. > > I'll put together a tentative v3 such that: > >

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-24 Thread Arjun Roy
On Wed, Mar 24, 2021 at 2:24 PM Johannes Weiner wrote: > > On Wed, Mar 24, 2021 at 10:12:46AM +0100, Michal Hocko wrote: > > On Tue 23-03-21 11:47:54, Arjun Roy wrote: > > > On Tue, Mar 23, 2021 at 7:34 AM Michal Hocko wrote: > > > > > > > > On

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-22 Thread Arjun Roy
On Wed, Mar 17, 2021 at 8:21 PM Andrew Morton wrote: > > On Mon, 15 Mar 2021 18:30:03 -0700 Arjun Roy wrote: > > > From: Arjun Roy > > > > TCP zerocopy receive is used by high performance network applications > > to further scale. For RX zerocopy, the memor

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-22 Thread Arjun Roy
On Wed, Mar 17, 2021 at 3:12 PM Johannes Weiner wrote: > > On Tue, Mar 16, 2021 at 11:05:11PM -0700, Arjun Roy wrote: > > On Tue, Mar 16, 2021 at 3:27 AM Johannes Weiner wrote: > > > > > > Hello, > > > > > > On Mon, Mar 15, 2021 at 09:16:45PM

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-23 Thread Arjun Roy
On Tue, Mar 23, 2021 at 10:01 AM Johannes Weiner wrote: > > On Mon, Mar 22, 2021 at 02:35:11PM -0700, Arjun Roy wrote: > > To make sure we're on the same page, then, here's a tentative > > mechanism - I'd rather get buy in before spending too much time on > &

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-23 Thread Arjun Roy
s would be really a nice and useful abstraction because you wouldn't > have to care about the specific type of page. > > But maybe I am just overlooking the real complexity there. > -- For now probably the easiest way is to have network pages be first class with a specific flag as previously discussed and have concrete handling for it, rather than trying to establish the contract across page types. Thanks, -Arjun > Michal Hocko > SUSE Labs

[mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-15 Thread Arjun Roy
From: Arjun Roy TCP zerocopy receive is used by high performance network applications to further scale. For RX zerocopy, the memory containing the network data filled by the network driver is directly mapped into the address space of high performance applications. To keep the TLB cost low, these

[mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-15 Thread Arjun Roy
From: Arjun Roy TCP zerocopy receive is used by high performance network applications to further scale. For RX zerocopy, the memory containing the network data filled by the network driver is directly mapped into the address space of high performance applications. To keep the TLB cost low, these

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-15 Thread Arjun Roy
On Mon, Mar 15, 2021 at 9:16 PM Arjun Roy wrote: > > From: Arjun Roy > > TCP zerocopy receive is used by high performance network applications > to further scale. For RX zerocopy, the memory containing the network > data filled by the network driver is directly mapped into the

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-15 Thread Arjun Roy
On Mon, Mar 15, 2021 at 9:29 PM Shakeel Butt wrote: > > On Mon, Mar 15, 2021 at 9:20 PM Arjun Roy wrote: > > > [...] > > > > > > > Apologies for the spam - looks like I forgot to rebase the first time > > I sent this out. > > > > Actually

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-15 Thread Arjun Roy
On Mon, Mar 15, 2021 at 11:22 PM Arjun Roy wrote: > > On Mon, Mar 15, 2021 at 9:29 PM Shakeel Butt wrote: > > > > On Mon, Mar 15, 2021 at 9:20 PM Arjun Roy wrote: > > > > > [...] > > > > > > > > > > Apologies for the spam - loo

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-13 Thread Arjun Roy
> > > Mathieu > > > > > > > > > > >> > > >> Thanks, > > >> > > >> Mathieu > > >> If we're special-casing 64-bit architectures anyways - unrolling the 32B copy_from_user() for struct rseq_cs appears t

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-13 Thread Arjun Roy
ves a measurable improvement for writev("/dev/null"). > I must sort those patches out again. > > David > In this case I mean replacing copy_from_user(rseq_cs, urseq_cs, sizeof(*rseq_cs)) with 4 (x8B=32 total) unsafe_get_user() (wrapped in user_read_access_begin/end

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-14 Thread Arjun Roy
gt; I'm definitely seeing repeated tests of (IIRC) %rdx. > > > > It may well be because the compiler isn't very new. > > Will be an Ubuntu build of 9.3.0. > > Does that support 'asm goto with outputs' - which > > may be the difference. > > > > Yep, probably. I am using some recent clang version. > On x86-64 I can confirm, for me it (4 x unsafe_get_user()) compiles down to stac + lfence + 8 x mov + clac as straight line code. And results in roughly a 5%-10% speedup over copy_from_user(). -Arjun > > David > > > > - > > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 > > 1PT, UK > > Registration No: 1397386 (Wales)

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-14 Thread Arjun Roy
On Wed, Apr 14, 2021 at 10:35 AM Eric Dumazet wrote: > > On Wed, Apr 14, 2021 at 7:15 PM Arjun Roy wrote: > > > > On Wed, Apr 14, 2021 at 9:10 AM Eric Dumazet wrote: > > > > > > On Wed, Apr 14, 2021 at 6:08 PM David Laight > > > wrote: > >

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-14 Thread Arjun Roy
On Wed, Apr 14, 2021 at 1:25 PM Eric Dumazet wrote: > > On Wed, Apr 14, 2021 at 10:15 PM Arjun Roy wrote: > > > > On Wed, Apr 14, 2021 at 10:35 AM Eric Dumazet wrote: > > > > > > On Wed, Apr 14, 2021 at 7:15 PM Arjun Roy wrote: > > > > >

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-16 Thread Arjun Roy
On Tue, Mar 16, 2021 at 3:27 AM Johannes Weiner wrote: > > Hello, > > On Mon, Mar 15, 2021 at 09:16:45PM -0700, Arjun Roy wrote: > > From: Arjun Roy > > > > TCP zerocopy receive is used by high performance network applications > > to further scale. For RX

Re: linux-next: manual merge of the bpf-next tree with the net-next tree

2021-01-25 Thread Arjun Roy
is concerned, but any non trivial > conflicts should be mentioned to your upstream maintainer when your tree > is submitted for merging. You may also want to consider cooperating > with the maintainer of the conflicting tree to minimise any particularly > complex conflicts. > The fix looks

[PATCH] ACPI: fix test for hex digit.

2014-07-30 Thread Arjun Sreedharan
decimal 0 is ascii for NULL. Hex digit matching should be from '0' (decimal 30 of ascii) to '9' and 'A' to 'F'. Unfixed version returns true for #,$,%,& etc. Signed-off-by: Arjun Sreedharan --- drivers/acpi/acpi_pnp.c | 2 +- 1 file changed, 1 inser

[PATCH] Replace faulty is_hex_digit() by isxdigit()

2014-07-30 Thread Arjun Sreedharan
0 is ascii for NULL. Hex digit matching should be from '0'. Unfixed version returns true for #,$,%,& etc. Signed-off-by: Arjun Sreedharan --- drivers/acpi/acpi_pnp.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/ac

[PATCH] Replace faulty is_hex_digit() by isxdigit()

2014-07-31 Thread Arjun Sreedharan
0 is ascii for NULL. Hex digit matching should be from '0'. Faulty version returns true for #,$,%,& etc. Signed-off-by: Arjun Sreedharan --- drivers/acpi/acpi_pnp.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/acpi/acpi_pnp.c b/drivers/a

[PATCH] Staging: unisys: Fix code style

2014-07-25 Thread Arjun AK
>From 8e7748dd81cf63c62dbef8f102e97da1d4d5d90a Mon Sep 17 00:00:00 2001 From: Arjun AK Date: Fri, 25 Jul 2014 15:09:11 +0530 Subject: [PATCH] Staging: unisys: Fix code style Fixes code style in multiple files Signed-off-by: Arjun AK --- drivers/staging/unisys/channels/chanstu

[PATCH] PNPACPI: check return value of pnpacpi_parse_allocated_resource() and pnpacpi_parse_resource_option_data()

2014-07-22 Thread Arjun Sreedharan
Handle error condition since pnpacpi_parse_allocated_resource() and pnpacpi_parse_resource_option_data() could return -EPERM. Signed-off-by: Arjun Sreedharan --- drivers/pnp/pnpacpi/core.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pnp/pnpacpi/core.c b

Re: [PATCH] PNPACPI: check return value of pnpacpi_parse_allocated_resource() and pnpacpi_parse_resource_option_data()

2014-07-23 Thread Arjun Sreedharan
On 23 July 2014 17:06, Rafael J. Wysocki wrote: > On Wednesday, July 23, 2014 01:56:36 PM Arjun wrote: >> ACPI 5.0 resource types like FixedDMA will fail pnpacpi_allocated_resource(). >> pnpacpi_add_device() has to return error in that case. > > Why? > OK. I presume th

[PATCH] usb: misc: yurex: remove useless casting of private_data

2014-08-18 Thread Arjun Sreedharan
Signed-off-by: Arjun Sreedharan --- drivers/usb/misc/yurex.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/misc/yurex.c b/drivers/usb/misc/yurex.c index 1472805..c3a45da 100644 --- a/drivers/usb/misc/yurex.c +++ b/drivers/usb/misc/yurex.c @@ -358,7

[PATCH] usb: use kcalloc instead of kzalloc

2014-08-19 Thread Arjun Sreedharan
kcalloc has protection from integer overflows which could arise from the multiplication of number of elements and size. Signed-off-by: Arjun Sreedharan --- drivers/usb/core/config.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/core/config.c b

[PATCH] params: fix potential memory leak in add_sysfs_param()

2014-08-20 Thread Arjun Sreedharan
Do not leak memory when attrs is non NULL and krealloc() fails. Without temporary variable, reference to it is lost. Signed-off-by: Arjun Sreedharan --- kernel/params.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/kernel/params.c b/kernel/params.c index

Re: [PATCH] params: fix potential memory leak in add_sysfs_param()

2014-08-20 Thread Arjun Sreedharan
On 21 August 2014 02:19, Rusty Russell wrote: > Arjun Sreedharan writes: >> Do not leak memory when attrs is non NULL and >> krealloc() fails. Without temporary variable, >> reference to it is lost. >> >> Signed-off-by: Arjun Sreedharan > > ... > >&

Re: [PATCH] params: fix potential memory leak in add_sysfs_param()

2014-08-20 Thread Arjun Sreedharan
= NULL; > - return err; > } > > #ifdef CONFIG_MODULES > Ok, what's the harm in releasing {new,mk->mp}->grp.attrs and new/mk->mp on realloc failure ? @David, @Rusty Am i right thinking they are not used after the function returns error ? See module_param_sysfs_se

[PATCH] remove explicit devm_kfree

2014-08-15 Thread Arjun Sreedharan
Memory allocated with devm_kzalloc() is freed automatically when device out of scope. Signed-off-by: Arjun Sreedharan --- drivers/input/misc/soc_button_array.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c index

[PATCH] ata: propagate return value of scc_wait_after_reset

2014-08-16 Thread Arjun Sreedharan
scc_bus_softreset not necessarily should return zero. Propagate the error code. Signed-off-by: Arjun Sreedharan --- drivers/ata/pata_scc.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c index 4e006d7..5618c4518 100644

Re: [PATCH] ata: propagate return value of scc_wait_after_reset

2014-08-16 Thread Arjun Sreedharan
On 16 August 2014 17:07, Tejun Heo wrote: > Hello, > > On Sat, Aug 16, 2014 at 03:47:17PM +0530, Arjun Sreedharan wrote: >> scc_bus_softreset not necessarily should return zero. >> Propagate the error code. >> Signed-off-by: Arjun Sreedharan >> --- >> dri

Re: [PATCH] ata: propagate return value of scc_wait_after_reset

2014-08-16 Thread Arjun Sreedharan
On 16 August 2014 17:51, Tejun Heo wrote: > On Sat, Aug 16, 2014 at 05:34:31PM +0530, Arjun Sreedharan wrote: >> On 16 August 2014 17:07, Tejun Heo wrote: >> > Hello, >> > >> > On Sat, Aug 16, 2014 at 03:47:17PM +0530, Arjun Sreedharan wrote: >> >>

[PATCH] ata: propagate return value of scc_wait_after_reset

2014-08-16 Thread Arjun Sreedharan
scc_bus_softreset not necessarily should return zero. Propagate the error code. Signed-off-by: Arjun Sreedharan --- drivers/ata/pata_scc.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c index 4e006d7..b5013dc

[PATCH] ata: pata_samsung_cf: change ret type to signed

2014-08-16 Thread Arjun Sreedharan
Change return type to signed int since it could be a negative errno. Signed-off-by: Arjun Sreedharan --- drivers/ata/pata_samsung_cf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c index fb52883..0c1c03a 100644

[PATCH] cpufreq: exynos: free memory immediately on unknown SoC

2014-08-16 Thread Arjun Sreedharan
Signed-off-by: Arjun Sreedharan --- drivers/cpufreq/exynos-cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c index 1e0ec57..e47d165 100644 --- a/drivers/cpufreq/exynos-cpufreq.c +++ b/drivers/cpufreq/exynos-cpufreq.c

[PATCH] usb: phy: return -ENODEV on failure of try_module_get

2014-08-17 Thread Arjun Sreedharan
When __usb_find_phy_dev() does not return error and try_module_get() fails, return -ENODEV Signed-off-by: Arjun Sreedharan --- drivers/usb/phy/phy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 36b6bce..8ad3638 100644 --- a/drivers/usb

[PATCH] usb: phy: return -ENODEV on failure of try_module_get

2014-08-17 Thread Arjun Sreedharan
When __usb_find_phy_dev() does not return error and try_module_get() fails, return -ENODEV. Signed-off-by: Arjun Sreedharan --- drivers/usb/phy/phy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 36b6bce..fd0d7f1 100644 --- a/drivers

[PATCH] tools/thermal: fix calloc argument ordering

2014-08-18 Thread Arjun Sreedharan
@number first, @size second argument Signed-off-by: Arjun Sreedharan --- tools/thermal/tmon/sysfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/thermal/tmon/sysfs.c b/tools/thermal/tmon/sysfs.c index dfe4548..1c12536 100644 --- a/tools/thermal/tmon/sysfs.c

Re: [PATCH] cpupower: fix potential memory leak

2015-09-11 Thread Arjun Sreedharan
Ping ! On 22 August 2015 at 17:31, Arjun Sreedharan wrote: > Signed-off-by: Arjun Sreedharan > --- > tools/power/cpupower/bench/parse.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/tools/power/cpupower/bench/parse.c > b/tools/power/c

[PATCH] cpupower: fix potential memory leak

2016-02-13 Thread Arjun Sreedharan
Signed-off-by: Arjun Sreedharan --- tools/power/cpupower/bench/parse.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/power/cpupower/bench/parse.c b/tools/power/cpupower/bench/parse.c index f503fb5..058a351 100644 --- a/tools/power/cpupower/bench/parse.c

[PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-20 Thread Arjun Sreedharan
When __of_usb_find_phy() fails, it returns -ENODEV - its error code has to be returned by devm_usb_get_phy_by_phandle(). Only when the former function succeeds and try_module_get() fails should -EPROBE_DEFER be returned. Signed-off-by: Arjun Sreedharan --- drivers/usb/phy/phy.c | 4 +++- 1 file

[PATCH] mn10300: remove redundant hex()

2014-11-30 Thread Arjun Sreedharan
replace rendundant hex() with kernel's hex_to_bin() Signed-off-by: Arjun Sreedharan --- arch/mn10300/kernel/gdb-stub.c | 61 -- 1 file changed, 23 insertions(+), 38 deletions(-) diff --git a/arch/mn10300/kernel/gdb-stub.c b/arch/mn10300/kernel/gdb-s

[PATCH] arm: early_printk: do bound check independent of @n

2014-11-21 Thread Arjun Sreedharan
Signed-off-by: Arjun Sreedharan --- arch/arm/kernel/early_printk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/early_printk.c b/arch/arm/kernel/early_printk.c index 4307653..9e05f8a 100644 --- a/arch/arm/kernel/early_printk.c +++ b/arch/arm/kernel

Re: [PATCH] x86,boot: standardize strcmp()

2015-03-17 Thread Arjun Sreedharan
On 17 March 2015 at 13:16, Ingo Molnar wrote: > > * Arjun Sreedharan wrote: > >> strcmp() is always expected to return 0 when args are >> same, <0 when arg1 is lesser and >0 otherwise. >> Previously strcmp("a","b") returned 1. Now it give

Re: [PATCH] x86,boot: standardize strcmp()

2015-03-18 Thread Arjun Sreedharan
On 18 March 2015 at 07:06, Bernd Petrovitsch wrote: > On Die, 2015-03-17 at 19:43 +0530, Arjun Sreedharan wrote: > [...] >> On a related note, IMO strcmp() should return {-1,0,1} since many >> programmers just expect this behavior. just my opinion. > > -ENOPATCH

[PATCH] x86,boot: standardize strcmp()

2015-03-18 Thread Arjun Sreedharan
Sorry for the previous messed up email. Here's a patch. -- >8 -- Subject: [PATCH] arm,x86: limit strcmp() rc to {-1,0,1} Signed-off-by: Arjun Sreedharan --- arch/arm/boot/compressed/string.c | 2 +- arch/x86/boot/string.c| 2 +- 2 files changed, 2 insertions(+), 2 d

[PATCH] x86,boot: standardize strcmp()

2015-03-16 Thread Arjun Sreedharan
strcmp() is always expected to return 0 when args are same, <0 when arg1 is lesser and >0 otherwise. Previously strcmp("a","b") returned 1. Now it gives -1. Signed-off-by: Arjun Sreedharan --- arch/x86/boot/string.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] docproc: handle realloc() failure in find_all_symbols()

2015-02-28 Thread Arjun Sreedharan
check realloc rc and avoid potential null dereference and memory leak Signed-off-by: Arjun Sreedharan --- scripts/docproc.c | 8 1 file changed, 8 insertions(+) diff --git a/scripts/docproc.c b/scripts/docproc.c index e267e621..438fc91 100644 --- a/scripts/docproc.c +++ b/scripts

[PATCH] cpupower: fix potential memory leak

2015-08-22 Thread Arjun Sreedharan
Signed-off-by: Arjun Sreedharan --- tools/power/cpupower/bench/parse.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/power/cpupower/bench/parse.c b/tools/power/cpupower/bench/parse.c index f503fb5..058a351 100644 --- a/tools/power/cpupower/bench/parse.c

Re: linux-next: manual merge of the net tree with Linus' tree

2020-06-09 Thread Arjun Roy
Ack, and thank you very much for the fix. -Arjun On Tue, Jun 9, 2020 at 4:30 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net tree got a conflict in: > > net/ipv4/tcp.c > > between commit: > > d8ed45c5dcd4 ("mmap locking

[PATCH] staging: vt6656: Fixed two lines over 80 characters long

2015-06-22 Thread Arjun Krishna Babu
The presence of comments originally caused the two lines to be over 80 characters long. The issue is fixed by moving the comments into a separate line. Signed-off-by: Arjun Krishna Babu --- drivers/staging/vt6656/rxtx.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a

[PATCH] staging: rtl8712: Corrected line that was over 80 characters

2015-06-19 Thread Arjun Krishna Babu
Signed-off-by: Arjun Krishna Babu --- drivers/staging/rtl8712/rtl8712_led.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl8712_led.c b/drivers/staging/rtl8712/rtl8712_led.c index ada8d5d..0df7b0c 100644 --- a/drivers/staging/rtl8712/rtl8712_led.c

[PATCH] staging: vt6656: Fixed two lines over 80 characters long

2015-06-19 Thread Arjun Krishna Babu
The presence of comments originally caused the two lines to be over 80 characters long. The issue is fixed by moving the comments into a separate line. Signed-off-by: Arjun Krishna Babu --- drivers/staging/vt6656/rxtx.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a

[PATCH] staging: vt6655: Fixed two lines over 80 characters

2015-09-29 Thread Arjun Krishna Babu
Two lines of code that were over 80 characters long is fixed by splitting them into multiple lines. This way, the lines of code are now easier to read. Issue found by checkpatch. Signed-off-by: Arjun Krishna Babu --- drivers/staging/vt6655/baseband.c | 13 +++-- 1 file changed, 11

[PATCH] staging: vt6655: Fixed two lines over 80 characters long

2015-09-30 Thread Arjun Krishna Babu
Two lines of code that were over 80 characters long is fixed by splitting them across multiple lines. The lines of code are now easier to comprehend. Issue found by checkpatch. Signed-off-by: Arjun Krishna Babu --- drivers/staging/vt6655/baseband.c | 14 -- 1 file changed, 12

[PATCH] staging: dgnc: Replace macro with flow control statement by a function

2015-07-05 Thread Arjun Krishna Babu
This patch fixes the checkpatch.pl warning: WARNING: Macros with flow control statements should be avoided Replace the macro with a function doing the exact same task as the macro. Signed-off-by: Arjun Krishna Babu --- drivers/staging/dgnc/dgnc_sysfs.c | 22 ++ 1 file

[tip:x86/boot] x86/boot: Standardize strcmp()

2015-03-23 Thread tip-bot for Arjun Sreedharan
Commit-ID: 1c1d046be692493d00a4831d4fbc266745008e09 Gitweb: http://git.kernel.org/tip/1c1d046be692493d00a4831d4fbc266745008e09 Author: Arjun Sreedharan AuthorDate: Mon, 16 Mar 2015 21:07:47 +0530 Committer: Ingo Molnar CommitDate: Mon, 23 Mar 2015 10:24:12 +0100 x86/boot: Standardize

[tip:perf/urgent] calloc/xcalloc: Fix argument order

2014-12-12 Thread tip-bot for Arjun Sreedharan
Commit-ID: e4e458b45c5861808674eebfea94cee2258bb2ea Gitweb: http://git.kernel.org/tip/e4e458b45c5861808674eebfea94cee2258bb2ea Author: Arjun Sreedharan AuthorDate: Sat, 6 Dec 2014 17:10:43 +0530 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 9 Dec 2014 10:06:29 -0300 calloc