Currently the code checking for the ACPI status is mixed along with
the actual HDD protection status check.
This patch splits those two checks are they are not related, printing
an error string in case the ACPI call failed, and then check for
actual HDD protection status.
Signed-off-by: Azael
These two patches make some small changes to the driver code, the first
splits the error check fro the ACPI status and the HDD protection, and
the second simply changes the printing level of two strings from info
to debug.
Azael Avalos (2):
toshiba_haps: Split ACPI status error check from HDD
Two of the internal functions are printing an info message, one
whenever the HDD protection level changes, and another when the
driver receives an ACPI event.
This patch changes those two prints to debug, as that information
is more pertaining to debuging purposes.
Signed-off-by: Azael Avalos
This patch simply decouples te error checking of the ACPI status and
the actual BT status, as those two were nested in an if/else check,
but are completely unrelated.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion
, dropping the TOSHIBA_ prefix, to
better reflect that such GUID is not a Toshiba specific one.
Cc: # 4.4+
Signed-off-by: Azael Avalos
---
Hi Darren,
I was waiting on input from the bug above, but haven't received an
answer (as of yet), so I decided to send this to the mailing list
for feedba
to notice, making the function
responsible for registering the input device to continue.
This issue was found on a Toshiba Portege Z30-B, but there might be
some other models out there affected by this regression as well.
Cc: # 4.1+
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_
ignment to a comparison,
making the laptops with actual support for such feature to work again.
Signed-off-by: Azael Avalos
---
Darren,
Hopefully this patch can go into one of the 4.3 RCs, as the changes are
there and to avoid shipping a broken feature support.
drivers/platform/x86/toshiba_
These two patches make some changes to the hotkeys code, the first
patch unify the hotkey enabling code, and the second changes the default
hotkey enabling parameter.
Azael Avalos (2):
toshiba_acpi: Unify hotkey enabling functions
toshiba_acpi: Change default Hotkey enabling value
drivers
Currently the driver has two functions enabling hotkeys support,
but these two functions can be merged into one.
This patch merges these two functions, moving some checks to the
*enable_hotkeys function, simplifying code in the process.
Signed-off-by: Azael Avalos
---
drivers/platform/x86
ated stuff.
Currently the driver is under the EXPERIMENTAL flag, as the keymap
and the notify function are incomplete (due to lack of hardware to test).
Signed-off-by: Azael Avalos
---
MAINTAINERS| 6 ++
drivers/platform/x86/Kconfig | 18 +
drivers/platform/x8
STEM_EVENT
query can be checked directly from the function.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
ind
.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 9f7ced1..50a2116 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b
vents only.
0x0b - Disable (hotkey and system) events.
This patch changes the default hotkey enabling value from 0x09 to 0x01,
enabling both the hotkey and system events.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
please let me know.
>> >
>> > ------
>> >
>> > From: Azael Avalos
>> >
>> > commit 53147b6cabee5e8d1997b5682fcc0c3b72ddf9c2 upstream.
>> >
>> > Commit a2b3471b5b13 ("toshiba_acpi: Use the Hotkey Event Type function
>
Hi Darren,
2014-12-03 6:12 GMT-07:00 Darren Hart :
> On Wed, Dec 03, 2014 at 11:42:04PM -0700, Azael Avalos wrote:
>> @@ -1971,41 +2008,22 @@ error:
>> static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event)
>> {
>> struct toshiba_acpi_dev *dev
.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 99db763..5e9b298 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b
:
- Removed a left over variable from the split in patch 02 and
moved it to patch 03 (where it belongs)
- A bit more verbose description on patch 03
Azael Avalos (3):
toshiba_acpi: Move hotkey enabling code to own function
toshiba_acpi: Change notify funtion to handle more events
toshiba_acpi
toshiba_acpi_process_hotkeys.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 85 ++---
1 file changed, 51 insertions(+), 34 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 8bb07c7
The hotkey enabling code is being used by
*_setup_keyboard and also by *_resume.
This patch creates a new function called
toshiba_acpi_enable_hotkeys to be used by
these two functions to avoid duplicating
code.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 40
he default return code of the sci_open function
to return one instead of zero, making all those faulty laptops load
all the supported features.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pl
e, however, the machine needs a restart everytime the
function is toggled.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 107
1 file changed, 107 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/tosh
music", accepting parameters zero and one, where
zero disables the feature and one enables it respectively.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 97 +
1 file changed, 97 insertions(+)
diff --git a/drivers/platform/x86/toshiba
disable it.
The sysfs entry accepts three parameters, 0x0, 0x9 and 0x21, beign
disabled, alternate and auto respectively.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 112
1 file changed, 112 insertions(+)
diff --git a/drivers/pl
ntry
named "sleep_functions_on_battery", accepting values from 0-100,
where zero disables the function and 1-100 sets the battery level at
which point the USB Sleep functions will be disabled, and printing
the current state of the functon and also the battery level currently
set.
Signed-
The following patches add support to several USB Sleep functions
found on newer Toshiba laptops, allowing to use th USB ports while
the laptop is asleep or turned off.
Azael Avalos (4):
toshiba_acpi: Add support for USB Sleep and Charge function
toshiba_acpi: Add support for USB Sleep
charging modes mean
- Some misc format and typo changes
Azael Avalos (4):
toshiba_acpi: Add support for USB Sleep and Charge function
toshiba_acpi: Add support for USB Sleep functions under battery
toshiba_acpi: Add support for USB Rapid Charge
toshiba_acpi: Add support for USB Sleep and
disable it.
The sysfs entry accepts three parameters, 0, 1 and 2, beign disabled,
alternate and auto respectively.
The auto mode stands for USB conformant devices (which most are), and
the alternate mode stands for those non USB conformant devices that
require more power.
Signed-off-by: Az
wever, the machine needs a restart everytime the
function is toggled.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 107
1 file changed, 107 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/tosh
a sysfs entry
named "usb_sleep_music", accepting only two values, 0 to disable and
1 to enable.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 97 +
1 file changed, 97 insertions(+)
diff --git a/drivers/platform/x86/toshiba
ntry
named "sleep_functions_on_battery", accepting values from 0-100,
where zero disables the function and 1-100 sets the battery level at
which point the USB Sleep functions will be disabled, and printing
the current state of the functon and also the battery level currently
set.
Signed-
ORTED, and thus, not
registering support for the queried feature.
Signed-off-by: Azael Avalos
---
Darren,
Hopefully this new patch eases some of the concerns of the previous
patch, and this time I added a comment block explaining a bit, but of
course, let me know if there is something else that needs c
Hi Darren,
Any input on this patch?
2015-01-18 19:17 GMT-07:00 Azael Avalos :
> This was "toshiba_acpi: Change sci_open function return value"
>
> Some Toshiba laptops have "poorly implemented" SCI calls on their
> BIOSes and are not checking for sci_{open
This patch adds support to query the "Hotkey Event Type" the system
supports.
There are two main event types (so far), 0x10 and 0x11, with the
first being all those laptops that have the old keyboard layout, and
the latter all those new laptops with the new keyboard layout.
Signed-off
er reflect what the call does, and also the HCI_HOTKEY_EVENT_*
types
- Fixed a typo in the error description
- Added a comment block explaining a bit why we also use the "Special
Functions" as a check for keymap selection
Azael Avalos (3):
toshiba_acpi: Add Hotkey Event Type func
ching list.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 70 +
1 file changed, 32 insertions(+), 38 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index c4edae3..d7dac48 100644
---
EVENT call, but this time
we are using a different parameter to make the "Special Functions"
mode work as expected.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/
Hi Darren,
2015-04-01 23:21 GMT-06:00 Darren Hart :
> On Sun, Mar 29, 2015 at 07:25:39PM -0600, Azael Avalos wrote:
>> This patch fixes the USB Sleep and Charge mode on certain models
>> where the value returned by the BIOS is different, and thus, making
>> this feature
This patch fixes the messages displayed by the USB Sleep Functions,
they were printing wrong messages not associated to the feature
currently queried.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff
This patch fixes the USB Sleep and Charge mode on certain models
where the value returned by the BIOS is different, and thus, making
this feature not to work for those models.
Also, the "Typical" charging mode was added as a supported mode.
Signed-off-by: Azael Avalos
---
drivers/pl
rted value of sleep and charge to zero in case
of an error and added comments.
- Updated the title and commit message of second patch to better
reflect what the patch is doing.
Azael Avalos (3):
toshiba_acpi: Update and fix USB Sleep and Charge modes
toshiba_acpi: Fix pr_* messages from USB S
This patch updates the sysfs-driver-toshiba_acpi entry, adding the
missing entries for USB Sleep functions.
And also, while at the neighborhood, fix some typos and add a note
that some features require a reboot.
Signed-off-by: Azael Avalos
---
.../ABI/testing/sysfs-driver-toshiba_acpi
This patch fixes the messages displayed by the USB Sleep Functions,
they were printing wrong messages not associated to the feature
currently queried.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff
This patch removes the dependency on rfkill for toshiba_acpi from
KConfig, as a previous patch removed all the code related to it.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86
These two patches remove all bluetooth rfkill code from toshiba_acpi
and its build dependencies, as another series of patches will re-add
the rfkill code to toshiba_bluetooth instead.
Azael Avalos (2):
toshiba_acpi: Remove bluetooth rfkill code
platform/x86: Remove RFKILL dependency from
This patch removes all bluetooth rfkill related code residing in
the toshiba_acpi driver.
Separate patches will add (and adapt) the code to toshiba_bluetooth
(where it belongs).
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 123
1
also used by upcomming patches.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 47 +++-
1 file changed, 46 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers/platform/x86/toshiba_bluetooth.c
index
These patches add support to use the rfkill core functionality to the
Toshiba bluetooth driver and adapting the existing code to it.
Azael Avalos (6):
toshiba_bluetooth: Add a container struct named toshiba_bluetooth_dev
toshiba_bluetooth: Add RFKill handler functions
toshiba_bluetooth
This patch simply adds the RFKILL dependency to Kconfig, as we are
now using rfkill code on the driver.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 9752761
This patch adapts toshiba_bt_rfkill_notify and toshiba_bt_resume
functions to update the rfkill status, as they were only calling
toshiba_bluetooth_enable.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 20 ++--
1 file changed, 18 insertions(+), 2
adds a few more debug messages printing the
killswitch, plug and power status of the device as well.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers
This patch removes unneeded code from the toshiba_bluetooth_enable
function as propper rfkill code as been added now.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 27 ---
1 file changed, 27 deletions(-)
diff --git a/drivers/platform/x86
This patch adds RFKill handler functions to the driver, allowing it
to register and update the rfkill switch.
Also, a comment block was moved from the header to the poll function,
as it explains why we need to poll the killswitch on older devices.
Signed-off-by: Azael Avalos
---
drivers
Hi there,
2015-04-28 1:36 GMT-06:00 Bjørn Mork :
> Azael Avalos writes:
>
>> The function toshiba_bluetooth_status s currently printing the status
>> of the device whenever it is queried, but since the introduction of
>> the rfkill poll code, this value will get pr
Hi there
Let me add my two cents on the Toshiba side.
2018-06-04 8:23 GMT-06:00 Hans de Goede :
>
> 1) drivers/platform/x86/toshiba_acpi.c
>
> I don't know how the key on Toshiba's behaves on models where
> it is hardwired / under Windows
With Toshiba we have two types of hardware implementatio
userspace a bit easier.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 32 ++--
1 file changed, 30 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index d7ecef3..226e0b5 100644
registering the toshiba::eco_mode led.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 66 +
1 file changed, 66 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index f97f942..022c6e6 100644
) hotkey.
This patch adds support to enable/disable the touchpad
by exposing the _touchpad_ file in sysfs.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 81 +
1 file changed, 81 insertions(+)
diff --git a/drivers/platform/x86
sysfs file.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 79 +
1 file changed, 79 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 022c6e6..9c718eb 100644
--- a/drivers/platform
Add myself to the copyright list and bump version to
0.20 since several new features have been added.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform
Change the toshiba_illumination_* code to use the newly
introduced sci_read and sci_write functions, and in the
process fix toshiba_illumination_available code, since
it was only opening the SCI and the return value was
never checked for errors or actual illumination support.
Signed-off-by: Azael
they are shared among the HCI and the SCI.
More information about the SCI can be found at
Jonathan Buzzard's website [1].
[1] http://www.buzzard.me.uk/toshiba/docs.html
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 146 +++-
1
userspace.
This patch adds support to set the desired KBD mode and
timeout via sysfs, creates and registers toshiba::kbd_backlight
led device whenever the mode is set to FN-Z.
The acceptable values for mode are: 1 (Auto) and 2 (Fn-Z)
The time values range are: 1-60 seconds
Signed-off-by: Azael
Up for review, the following patch series add new features
found on newer Toshiba laptops.
The first two fix an illumination detection bug, so consider
applying those to stable.
The rest just add support for touchpad, accelerometer axes,
keyboard backlight and ECO led, plus platform support, bump
HCI/SCI functions
to reflect the change made in this patch.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 51 -
1 file changed, 27 insertions(+), 24 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86
instead
replacing it with TOS (for TOShiba).
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 143 ++--
1 file changed, 72 insertions(+), 71 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
The previous patch changed the return type for the HCI/SCI
read/write functions.
This patch adapts the code for that change, as now the
"result" parameter is returned by those functions, instead
of the ACPI status call.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_a
tion to
tci_raw (for Toshiba Configuration Interface), and
change the comments about it.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 40 ++---
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/platform/x86/toshiba_ac
would like these to be queued for 3.18 if possible.
Azael Avalos (4):
toshiba_acpi: Rename hci_raw to tci_raw
toshiba_acpi: Unify return codes prefix to from HCI/SCI to TOS
toshiba_acpi: Change HCI/SCI functions return code type
toshiba_acpi: Adapt functions to the changes made to HCI/SCI
2014-09-25 21:01 GMT-06:00 Darren Hart :
> On Tue, Sep 23, 2014 at 06:24:25PM -0600, Azael Avalos wrote:
>> The function name hci_raw was used before to reflect
>> a raw (read/write) call to the Toshiba's Hardware
>> Configuration Interface (HCI), however, since the
>
2014-09-25 21:11 GMT-06:00 Darren Hart :
> On Tue, Sep 23, 2014 at 06:24:27PM -0600, Azael Avalos wrote:
>> Currently the HCI/SCI read/write functions are returning
>> the status of the ACPI call and also assigning the
>> returned value of the HCI/SCI function.
>>
type.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 117 +++-
1 file changed, 102 insertions(+), 15 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 4c8fa7b..08147c5 100644
--- a
The function toshiba_touchpad_store is not checking
for invalid values and simply returns silently.
This patch checks for invalid values and returns accordingly.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 14 ++
1 file changed, 10 insertions(+), 4
Hi Darren,
2014-09-11 18:36 GMT-06:00 Darren Hart :
> On Wed, Sep 10, 2014 at 09:01:56PM -0600, Azael Avalos wrote:
>
> Hi Azael,
>
>> Newer Toshiba models now come with a new (and different) keyboard
>> backlight implementation with three modes of operation: TIMER,
>&
type.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 193 +---
1 file changed, 158 insertions(+), 35 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 4c8fa7b..a5d7d83 100644
--- a
Hi Darren,
2014-09-12 14:48 GMT-06:00 Darren Hart :
> On Thu, Sep 11, 2014 at 09:22:25PM -0600, Azael Avalos wrote:
>> Newer Toshiba models now come with a new (and different) keyboard
>> backlight implementation with three modes of operation: TIMER,
>> ON and OFF, and
The position file on sysfs was reporting absolute values
for its axes.
This patch fixes the direction reporting (either negative
or positive), as well as added a mutex lock to it.
Signed-off-by: Azael Avalos
---
This was: Add accelerometer input polled device
Changes since v1:
Dropped polldev
keyboard type.
Signed-off-by: Azael Avalos
---
Changes since v3:
Fixed typos on patch description
Dropped changes to toshiba_kbd_bl_mode_show and simply added the new mode mask
drivers/platform/x86/toshiba_acpi.c | 188 ++--
1 file changed, 156 insertions(+), 32
was never checked on most of the functions.
Changes since v1:
- Be a bit more verbose on patch 1 about the Toshiba
configuration interface
- Merged patches 3 and 4 into a same patch
Azael Avalos (3):
toshiba_acpi: Rename hci_raw to tci_raw
toshiba_acpi: Unify return codes prefix from HCI/
call status,
eliminating one parameter, and returning something
useful that indeed is being checked.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 129 +---
1 file changed, 62 insertions(+), 67 deletions(-)
diff --git a/drivers/platform
instead
replacing it with TOS (for TOShiba).
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 143 ++--
1 file changed, 72 insertions(+), 71 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
tion to
tci_raw (for Toshiba Configuration Interface), and
change the comments about it.
Also, the HCI_WORDS definition was changed to TCI_RAW,
to better reflect that we're no longer using pure HCI
calls, but a combination of HCI and SCI, which form
part of the Toshiba Configuration Interface.
With the introduccion of the new keyboard backlight
implementation, the *_timeout_store function is
broken, as it only supports the first kbd_type.
This patch adapt such function for the new kbd_type,
as well as convert from using sscanf to kstrtoint.
Signed-off-by: Azael Avalos
---
drivers
->8
Intel test builder caught some warnings, one at the
KBD backlight mode store while validating for
correct parameters, and another one that might lead
to not creating the sysfs group
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 4 ++--
1 file changed, 2 inser
Hi there,
2014-09-09 21:35 GMT-06:00 Darren Hart :
>
> I immediately went to a tablet with a marble maze game and it didn't seem too
> crazy, but I don't suppose that is what people are actually doing with it...
>
> What are people actually doing with this thing Azael?
Gaming mostly (supertuxkart
Hi Darren,
2014-09-09 22:11 GMT-06:00 Darren Hart :
> On Fri, Sep 05, 2014 at 11:14:06AM -0600, Azael Avalos wrote:
>
> Hi Azael,
>
> Apologies for the delay. I'm still recovering from a couple weeks of travel
> and
> a nasty conference bug. Thanks for being patient.
Up for review.
This series of patches introduce support for the new
keyboard backlight type found on recent Toshiba laptops,
removes the position sysfs entry and instead creates an
input polled device (joystick), and a few fixes and
additions to the keymap list.
Azael Avalos (5):
toshiba_acpi
Appart from reporting hotkeys, the INFO method is used
as a system wide event notifier for hardware or
software changes.
This patch adds additional "events" to the keymap list,
ignored by now, until we find them a good use.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/tosh
The accelerometer sensor is very sensitive, and having userspace
poll the sysfs position entry is not very battery friendly.
This patch removes the sysfs entry and instead, it creates an
input polled device (joystick) for the built-in accelerometer.
Signed-off-by: Azael Avalos
---
drivers
implementation.
The timeout value range is now 1-60 seconds, and the accepted
modes are now: 0 (OFF), 1 (ON or FN-Z) and 2 (AUTO or TIMER), and
the keyboard_backlight_mode entry now displays two values, the
keyboard backlight type (either 1 or 2) and the current mode.
Signed-off-by: Azael Avalos
The function toshiba_touchpad_store is not checking
for invalid values and simply returns silently.
This patch checks for invalid values and returns accordingly.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 14 ++
1 file changed, 10 insertions(+), 4
.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index a149bc6..4803e7b 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers
Hi there
2014-09-05 20:35 GMT-06:00 Darren Hart :
> On Fri, Sep 05, 2014 at 11:14:04AM -0600, Azael Avalos wrote:
>> Some Toshiba models with illumination support set a different
>> value on the returned codes, thus not allowing the illumination
>> LED to be registere
Hi there,
2014-09-05 20:42 GMT-06:00 Darren Hart :
> On Fri, Sep 05, 2014 at 11:14:05AM -0600, Azael Avalos wrote:
>> The accelerometer sensor is very sensitive, and having userspace
>> poll the sysfs position entry is not very battery friendly.
>>
>> This patch
With the introduccion of the new keyboard backlight
implementation, the *_timeout_store function is
broken, as it only supports the first kbd_type.
This patch adapt such function for the new kbd_type,
as well as convert from using sscanf to kstrtoint.
Signed-off-by: Azael Avalos
---
Changes
Hi there,
2014-10-02 12:32 GMT-06:00 Darren Hart :
> On Mon, Sep 29, 2014 at 08:57:04PM -0600, Azael Avalos wrote:
>> With the introduccion of the new keyboard backlight
>> implementation, the *_timeout_store function is
>> broken, as it only supports the first kbd_type.
&
backlight code.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index ef3a190..e3fed12 100644
--- a/drivers/platform/x86
Hi Darren,
2015-07-22 14:54 GMT-06:00 Darren Hart :
> On Mon, Jul 20, 2015 at 04:49:51PM -0600, Azael Avalos wrote:
>> Hi Darren,
>>
>> 2015-07-20 15:55 GMT-06:00 Darren Hart :
>> > On Thu, Jul 16, 2015 at 05:38:57PM -0600, Azael Avalos wrote:
>> >> Com
hiba_acpi paths and command,
however, it is strongly reccomended to use the new IOCTL for any
SCI command to avoid any buggy BIOS.
Signed-off-by: Azael Avalos
---
Changes since v1:
- Expanded patch comment a bit
Documentation/ioctl/ioctl-number.txt | 2 +-
d
till using that interface,
hotkeys reporting should now work on these devices.
Signed-off-by: Azael Avalos
---
Changes since v1:
- No changes were made, this is simply a resend
drivers/platform/x86/toshiba_acpi.c | 56 +
1 file changed, 20 insertions(+), 36
of it.
Signed-off-by: Azael Avalos
---
Changes since v1:
- Minor typographical corrections in patch description
drivers/platform/x86/toshiba_acpi.c | 30 +++---
1 file changed, 11 insertions(+), 19 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers
1 - 100 of 316 matches
Mail list logo
