Re: [PATCH] HID: rmi: use HID_QUIRK_NO_INPUT_SYNC

On Fri, May 25, 2018 at 2:51 PM, Benjamin Tissoires <benjamin.tissoi...@redhat.com> wrote: > When we receive a RMI4 report, we should not unconditionally send an > input_sync event. Instead, we should let the rmi4 transport layer do it > for us. > > This fixes a situation whe

Re: [PATCH] HID: rmi: use HID_QUIRK_NO_INPUT_SYNC

On Fri, May 25, 2018 at 2:51 PM, Benjamin Tissoires wrote: > When we receive a RMI4 report, we should not unconditionally send an > input_sync event. Instead, we should let the rmi4 transport layer do it > for us. > > This fixes a situation where we might receive X in a repo

Re: [PATCH] HID: steam: select CONFIG_POWER_SUPPLY

("HID: steam: add battery device.") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Looks good: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > --- > drivers/hid/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/Kco

Re: [PATCH] HID: steam: select CONFIG_POWER_SUPPLY

attery device.") > Signed-off-by: Arnd Bergmann Looks good: Reviewed-by: Benjamin Tissoires > --- > drivers/hid/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 8a865e3ccea6..a49a10437c40 100644 > --- a/

[PATCH] HID: rmi: use HID_QUIRK_NO_INPUT_SYNC

://bugs.freedesktop.org/show_bug.cgi?id=100436 Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- Hi, Oscar, do you mind if we add your "Tested-by: Oscar Morante <your@email>"? Andrew, can you check for any sides effects please? Cheers, Benjamin driv

[PATCH] HID: rmi: use HID_QUIRK_NO_INPUT_SYNC

://bugs.freedesktop.org/show_bug.cgi?id=100436 Signed-off-by: Benjamin Tissoires --- Hi, Oscar, do you mind if we add your "Tested-by: Oscar Morante "? Andrew, can you check for any sides effects please? Cheers, Benjamin drivers/hid/hid-rmi.c | 20 1 file changed, 20

Re: Sometimes unusable i2c-hid devices in 4.17-rcX

Hi Mario, On Tue, May 22, 2018 at 6:15 PM, <mario.limoncie...@dell.com> wrote: > Benjamin, > >> -Original Message- >> From: Benjamin Tissoires [mailto:benjamin.tissoi...@gmail.com] >> Sent: Friday, May 18, 2018 1:18 PM >> To: Limonciello, Ma

Re: Sometimes unusable i2c-hid devices in 4.17-rcX

Hi Mario, On Tue, May 22, 2018 at 6:15 PM, wrote: > Benjamin, > >> -Original Message----- >> From: Benjamin Tissoires [mailto:benjamin.tissoi...@gmail.com] >> Sent: Friday, May 18, 2018 1:18 PM >> To: Limonciello, Mario >> Cc: linux-input; linux-k

Re: Sometimes unusable i2c-hid devices in 4.17-rcX

On Thu, May 17, 2018 at 4:44 PM, <mario.limoncie...@dell.com> wrote: >> -Original Message----- >> From: Benjamin Tissoires [mailto:benjamin.tissoi...@gmail.com] >> Sent: Thursday, May 17, 2018 9:28 AM >> To: Limonciello, Mario >> Cc: linux-input; linux-k

Re: Sometimes unusable i2c-hid devices in 4.17-rcX

On Thu, May 17, 2018 at 4:44 PM, wrote: >> -Original Message- >> From: Benjamin Tissoires [mailto:benjamin.tissoi...@gmail.com] >> Sent: Thursday, May 17, 2018 9:28 AM >> To: Limonciello, Mario >> Cc: linux-input; linux-kernel@vger.kernel.org >> Sub

Re: Sometimes unusable i2c-hid devices in 4.17-rcX

Hi Mario, On Wed, May 16, 2018 at 10:00 PM, wrote: > Hi All, > > I've been running 4.16-rc7 on an XPS 9365 for some time and recently moved up > to 4.17-rc5. > Immediately I noticed that i2c-hid devices (both touchscreen and touchpad) > were not working. > Also

Re: Sometimes unusable i2c-hid devices in 4.17-rcX

Hi Mario, On Wed, May 16, 2018 at 10:00 PM, wrote: > Hi All, > > I've been running 4.16-rc7 on an XPS 9365 for some time and recently moved up > to 4.17-rc5. > Immediately I noticed that i2c-hid devices (both touchscreen and touchpad) > were not working. > Also when shutting the system down

Re: [PATCH] HID: i2c-hid: check if device is there before really probing

hromium.org> > --- Looks good. Tested on a Dell XPS with an i2c-hid touchpad: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > drivers/hid/i2c-hid/i2c-hid.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/hid

Re: [PATCH] HID: i2c-hid: check if device is there before really probing

avoid bunch of scary messages when device is not actually present in the > system let's try testing basic communication with it and if there is no > response terminate probe early with -ENXIO. > > Signed-off-by: Dmitry Torokhov > --- Looks good. Tested on a Dell XPS with an i2c

Re: [PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)

Hi Dmitry, This is your monthly reminder of the Lenov 80 pending series :) Could you consider taking this series and Aaron's patch? Cheers, Benjamin On Tue, Apr 17, 2018 at 1:42 PM, Aaron Ma wrote: > Hi Dmitry and Benjamin: > > Could you apply my patch too? > > It add

Re: [PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)

Hi Dmitry, This is your monthly reminder of the Lenov 80 pending series :) Could you consider taking this series and Aaron's patch? Cheers, Benjamin On Tue, Apr 17, 2018 at 1:42 PM, Aaron Ma wrote: > Hi Dmitry and Benjamin: > > Could you apply my patch too? > > It add LEN0096 that Benjamin's

Re: [PATCH] HID: wacom: Release device resource data obtained by devres_alloc()

On Tue, Apr 24, 2018 at 10:03 AM, Arvind Yadav <arvind.yadav...@gmail.com> wrote: > Free device resource data, if __wacom_devm_sysfs_create_group > is not successful. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> > --- Looks good to me: Revi

Re: [PATCH] HID: wacom: Release device resource data obtained by devres_alloc()

On Tue, Apr 24, 2018 at 10:03 AM, Arvind Yadav wrote: > Free device resource data, if __wacom_devm_sysfs_create_group > is not successful. > > Signed-off-by: Arvind Yadav > --- Looks good to me: Reviewed-by: Benjamin Tissoires Cheers, Benjamin > drivers/hid/wacom_sys.c

[PATCH v2 5/6] HID: multitouch: simplify the settings of the various features

-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/hid/hid-multitouch.c | 131 --- 1 file changed, 60 insertions(+), 71 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 43784d31a1a3..8878de

[PATCH v2 4/6] HID: multitouch: make use of HID_QUIRK_INPUT_PER_APP

the Input data, the other one contains the Output data. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/hid/hid-multitouch.c | 72 1 file changed, 33 insertions(+), 39 deletions(-) diff --git a/drivers/hid/hid-multitou

[PATCH v2 5/6] HID: multitouch: simplify the settings of the various features

-off-by: Benjamin Tissoires --- drivers/hid/hid-multitouch.c | 131 --- 1 file changed, 60 insertions(+), 71 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 43784d31a1a3..8878de9eedba 100644 --- a/drivers/hid/hid

[PATCH v2 4/6] HID: multitouch: make use of HID_QUIRK_INPUT_PER_APP

the Input data, the other one contains the Output data. Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-multitouch.c | 72 1 file changed, 33 insertions(+), 39 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c

[PATCH v2 3/6] HID: input: append a suffix matching the application

Given that we create one input node per application, we should name the input node accordingly to not lose userspace. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/hid/hid-input.c | 67 +++-- include/linux/hid.h

[PATCH v2 2/6] HID: generic: create one input report per application type

'unsigned' to 'unsigned int'. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/hid/hid-core.c | 19 +-- drivers/hid/hid-generic.c| 15 +++ drivers/hid/hid-gfrm.c | 2 +- drivers/hid/hid-input.c

[PATCH v2 3/6] HID: input: append a suffix matching the application

Given that we create one input node per application, we should name the input node accordingly to not lose userspace. Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-input.c | 67 +++-- include/linux/hid.h | 1 + 2 files changed, 60

[PATCH v2 2/6] HID: generic: create one input report per application type

'unsigned' to 'unsigned int'. Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-core.c | 19 +-- drivers/hid/hid-generic.c| 15 +++ drivers/hid/hid-gfrm.c | 2 +- drivers/hid/hid-input.c | 17 + drivers/hid/hid-magicmouse.c | 6

[PATCH v2 6/6] HID: multitouch: implement precision touchpad latency and switches

-precision-touchpad-required-hid-top-level-collections Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/hid/hid-multitouch.c | 34 +- include/linux/hid.h | 3 +++ 2 files changed, 32 insertions(+), 5 deletions(-) diff

[PATCH v2 6/6] HID: multitouch: implement precision touchpad latency and switches

-precision-touchpad-required-hid-top-level-collections Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-multitouch.c | 34 +- include/linux/hid.h | 3 +++ 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b

[PATCH v2 0/6] HID: input cleanups and mt additions

Benjamin Tissoires (6): HID: store the full list of reports in the hidinput HID: generic: create one input report per application type HID: input: append a suffix matching the application HID: multitouch: make use of HID_QUIRK_INPUT_PER_APP HID: multitouch: simplify the settings of the various

[PATCH v2 1/6] HID: store the full list of reports in the hidinput

for the Input reports and the Output reports. Storing the full list allows the drivers to have all the data. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/hid/hid-input.c | 6 ++ include/linux/hid.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/d

[PATCH v2 0/6] HID: input cleanups and mt additions

Benjamin Tissoires (6): HID: store the full list of reports in the hidinput HID: generic: create one input report per application type HID: input: append a suffix matching the application HID: multitouch: make use of HID_QUIRK_INPUT_PER_APP HID: multitouch: simplify the settings of the various

[PATCH v2 1/6] HID: store the full list of reports in the hidinput

for the Input reports and the Output reports. Storing the full list allows the drivers to have all the data. Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-input.c | 6 ++ include/linux/hid.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/hid/hid-input.c b/drivers/hid

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

, Benjamin Benjamin Tissoires (2): HID: generic: create one input report per application type HID: input: append a suffix matching the application drivers/hid/hid-core.c | 10 -- drivers/hid/hid-generic.c| 15 drivers/hid/hid-gfrm.c | 2 +- drivers/hid/hid-input.c

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

, Benjamin Benjamin Tissoires (2): HID: generic: create one input report per application type HID: input: append a suffix matching the application drivers/hid/hid-core.c | 10 -- drivers/hid/hid-generic.c| 15 drivers/hid/hid-gfrm.c | 2 +- drivers/hid/hid-input.c

[PATCH 2/2] HID: input: append a suffix matching the application

Given that we create one input node per application, we should name the input node accordingly to not lose userspace. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/hid/hid-input.c | 64 ++-- drivers/hid/hid-multit

[PATCH 2/2] HID: input: append a suffix matching the application

Given that we create one input node per application, we should name the input node accordingly to not lose userspace. Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-input.c | 64 ++-- drivers/hid/hid-multitouch.c | 30

[PATCH 1/2] HID: generic: create one input report per application type

think of split nicely the devices inputs into application, it is a good thing to split the devices by default based on this assumption. Also make hid-multitouch following this rule, to not have to deal with too many input created Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.

[PATCH 1/2] HID: generic: create one input report per application type

think of split nicely the devices inputs into application, it is a good thing to split the devices by default based on this assumption. Also make hid-multitouch following this rule, to not have to deal with too many input created Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-core.c

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

On Tue, Apr 17, 2018 at 2:11 PM, Jiri Kosina wrote: > On Mon, 16 Apr 2018, Dmitry Torokhov wrote: > >> So what is happening with this series? I think we should get it them >> in; there is really no reason for bumping ABS_MISC till it gets into >> ABS_MT_* range on some devices

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

On Tue, Apr 17, 2018 at 2:11 PM, Jiri Kosina wrote: > On Mon, 16 Apr 2018, Dmitry Torokhov wrote: > >> So what is happening with this series? I think we should get it them >> in; there is really no reason for bumping ABS_MISC till it gets into >> ABS_MT_* range on some devices that are out there.

Re: [PATCH v6] Fix modifier keys for Redragon Asura Keyboard

> the creation of a second, not working, keyboard device. > > Signed-off-by: Robert Munteanu <romb...@apache.org> > --- Looks good to me now: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Thanks Robert for respinning the series! Cheers, Benja

Re: [PATCH v6] Fix modifier keys for Redragon Asura Keyboard

of a second, not working, keyboard device. > > Signed-off-by: Robert Munteanu > --- Looks good to me now: Reviewed-by: Benjamin Tissoires Thanks Robert for respinning the series! Cheers, Benjamin > drivers/hid/Kconfig| 7 > drivers/hid/Makefile | 1 + > d

Re: [PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)

that the laptops are shipping from Lenovo. Cheers, Benjamin On Mon, Apr 9, 2018 at 11:10 AM, Benjamin Tissoires <benjamin.tissoi...@redhat.com> wrote: > Hi Dmitry, > > Here is the v2 of the Lenovo 80 series. > Changes from v1: > - included patch to convert a function to static f

Re: [PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)

that the laptops are shipping from Lenovo. Cheers, Benjamin On Mon, Apr 9, 2018 at 11:10 AM, Benjamin Tissoires wrote: > Hi Dmitry, > > Here is the v2 of the Lenovo 80 series. > Changes from v1: > - included patch to convert a function to static from build bot > - use of device property i

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

On Mon, Apr 16, 2018 at 12:14 PM, Robert Munteanu <romb...@apache.org> wrote: > Hi Benjamin and Jiri, > > On Mon, 2018-04-16 at 12:02 +0200, Benjamin Tissoires wrote: >> Hi Robert, >> >> On Wed, Apr 11, 2018 at 11:49 AM, Robert Munteanu <romb...@a

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

On Mon, Apr 16, 2018 at 12:14 PM, Robert Munteanu wrote: > Hi Benjamin and Jiri, > > On Mon, 2018-04-16 at 12:02 +0200, Benjamin Tissoires wrote: >> Hi Robert, >> >> On Wed, Apr 11, 2018 at 11:49 AM, Robert Munteanu > > wrote: >> > Changelog: >> &g

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

for user, > rebased on top of 4.15 > - v5: fix the HID descriptor as suggested by Benjamin Tissoires, > use existing USB vendor id, update comment style, add SPDX > license identifier, rename to hid-redragon, stop registering > two input devices, rebased on top of 4.16 As

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

sed on top of 4.15 > - v5: fix the HID descriptor as suggested by Benjamin Tissoires, > use existing USB vendor id, update comment style, add SPDX > license identifier, rename to hid-redragon, stop registering > two input devices, rebased on top of 4.16 As Jiri said, please provide a c

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

t; - v4: remove most debugging calls, make init info useful for user, >> rebased on top of 4.15 >> - v5: fix the HID descriptor as suggested by Benjamin Tissoires, >> use existing USB vendor id, update comment style, add SPDX >> license identifier, rename to hid-redrago

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

bugging calls, make init info useful for user, >> rebased on top of 4.15 >> - v5: fix the HID descriptor as suggested by Benjamin Tissoires, >> use existing USB vendor id, update comment style, add SPDX >> license identifier, rename to hid-redragon, stop registering &g

Re: [PATCH 0/8] Input: support for latest Lenovo thinkpads (series 80)

y's next branch I do not see such issues. > > Do you have any idea about it? If reloading elan_i2c doesn't fix the situation, it must be in i2c_i801. But this is weird that this happens on your platform but not on my t480s going into S3. Cheers, Benjamin > > Thanks > KT > -Ori

Re: [PATCH 0/8] Input: support for latest Lenovo thinkpads (series 80)

see such issues. > > Do you have any idea about it? If reloading elan_i2c doesn't fix the situation, it must be in i2c_i801. But this is weird that this happens on your platform but not on my t480s going into S3. Cheers, Benjamin > > Thanks > KT > -Original Message- >

[PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)

to do so. You were of tremendous help :) Cheers, Benjamin Benjamin Tissoires (9): Input: synaptics - add Lenovo 80 series ids to SMBus input: elan_i2c_smbus - fix corrupted stack Input: elan_i2c - add trackstick report Input: elantech - split device info into a separate structure Input

[PATCH v2 2/9] input: elan_i2c_smbus - fix corrupted stack

4.15.x, v4.16.x Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- no changes in v2 drivers/input/mouse/elan_i2c_smbus.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/input/mouse/elan_i2c_smbus.c b/drivers/input/mouse/elan

[PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)

to do so. You were of tremendous help :) Cheers, Benjamin Benjamin Tissoires (9): Input: synaptics - add Lenovo 80 series ids to SMBus input: elan_i2c_smbus - fix corrupted stack Input: elan_i2c - add trackstick report Input: elantech - split device info into a separate structure Input

[PATCH v2 2/9] input: elan_i2c_smbus - fix corrupted stack

-by: Benjamin Tissoires --- no changes in v2 drivers/input/mouse/elan_i2c_smbus.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/input/mouse/elan_i2c_smbus.c b/drivers/input/mouse/elan_i2c_smbus.c index 29f99529b187..cfcb32559925 100644 --- a/drivers

[PATCH v2 5/9] Input: elantech_query_info() can be static

Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- new in v2, raised by kbuild test robot --- drivers/input/mouse/elantech.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 5/9] Input: elantech_query_info() can be static

Signed-off-by: Fengguang Wu Signed-off-by: Benjamin Tissoires --- new in v2, raised by kbuild test robot --- drivers/input/mouse/elantech.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index d485664f1563

[PATCH v2 4/9] Input: elantech - split device info into a separate structure

In preparation for SMBus device support, move static device information that we query form the touchpad upon initialization into separate structure. This will allow us to query the device without allocating memory first. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.

[PATCH v2 4/9] Input: elantech - split device info into a separate structure

In preparation for SMBus device support, move static device information that we query form the touchpad upon initialization into separate structure. This will allow us to query the device without allocating memory first. Signed-off-by: Benjamin Tissoires --- no changes in v2 drivers/input

[PATCH v2 7/9] Input: elantech - add support for SMBus devices

to individually expose those hardware over SMBus. the parameter mentioned above is elantech_smbus from the psmouse module. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- changes in v2: - use of device property instead of platform data --- drivers/input/mouse/Kconfig

[PATCH v2 7/9] Input: elantech - add support for SMBus devices

to individually expose those hardware over SMBus. the parameter mentioned above is elantech_smbus from the psmouse module. Signed-off-by: Benjamin Tissoires --- changes in v2: - use of device property instead of platform data --- drivers/input/mouse/Kconfig | 12 +++ drivers/input/mouse/elantech.c

[PATCH v2 8/9] Input: elantech - detect new ICs and setup Host Notify for them

fingers every 8 ms, instead of having a limit of 2 every 8 ms. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- no changes in v2 drivers/input/mouse/elantech.c | 11 +++ drivers/input/mouse/elantech.h | 15 +++ 2 files changed, 22 insertions(+), 4 del

[PATCH v2 8/9] Input: elantech - detect new ICs and setup Host Notify for them

fingers every 8 ms, instead of having a limit of 2 every 8 ms. Signed-off-by: Benjamin Tissoires --- no changes in v2 drivers/input/mouse/elantech.c | 11 +++ drivers/input/mouse/elantech.h | 15 +++ 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/drivers/input

[PATCH v2 9/9] input: psmouse-smbus: allow to control psmouse_deactivate

This seems to be Synaptics specific, as some Elan touchpads are not correctly switching to SMBus if we call deactivate before switching to SMBus on cold boot and on resume. Tested with the T480s Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- changes in v2: - r

[PATCH v2 9/9] input: psmouse-smbus: allow to control psmouse_deactivate

This seems to be Synaptics specific, as some Elan touchpads are not correctly switching to SMBus if we call deactivate before switching to SMBus on cold boot and on resume. Tested with the T480s Signed-off-by: Benjamin Tissoires --- changes in v2: - rebased on top of previous --- drivers

[PATCH v2 6/9] Input: elantech - query the resolution in query_info

The command ETP_RESOLUTION_QUERY also contains the bus information. It is better to fetch it once, while we are querying for device information. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- no changes in v2 drivers/input/mouse/elantech.

[PATCH v2 3/9] Input: elan_i2c - add trackstick report

Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- changes in v2: - use of generic device property instead of platform data so device tree can also make use of it --- .../devicetree/bindings/input/elan_i2c.txt | 1 + drivers/input/mouse/elan_i2c_

[PATCH v2 3/9] Input: elan_i2c - add trackstick report

Signed-off-by: Benjamin Tissoires --- changes in v2: - use of generic device property instead of platform data so device tree can also make use of it --- .../devicetree/bindings/input/elan_i2c.txt | 1 + drivers/input/mouse/elan_i2c_core.c| 90 +- 2

[PATCH v2 6/9] Input: elantech - query the resolution in query_info

The command ETP_RESOLUTION_QUERY also contains the bus information. It is better to fetch it once, while we are querying for device information. Signed-off-by: Benjamin Tissoires --- no changes in v2 drivers/input/mouse/elantech.c | 27 +++ drivers/input/mouse

[PATCH v2 1/9] Input: synaptics - add Lenovo 80 series ids to SMBus

xed it so upstream now works fine with or without RMI4, and there is no point not using RMI4 - the T480s is using an Elan touchpad, so that's a different story Cc: <sta...@vger.kernel.org> # v4.14.x, v4.15.x, v4.16.x Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>

[PATCH v2 1/9] Input: synaptics - add Lenovo 80 series ids to SMBus

xed it so upstream now works fine with or without RMI4, and there is no point not using RMI4 - the T480s is using an Elan touchpad, so that's a different story Cc: # v4.14.x, v4.15.x, v4.16.x Signed-off-by: Benjamin Tissoires --- no changes in v2 drivers/input/mouse/synaptics.c | 3 ++

Re: [PATCH 3/8] Input: elan_i2c - add trackstick report

On Fri, Apr 6, 2018 at 1:46 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > Hi Benjamin, > > On Thu, Apr 05, 2018 at 03:25:32PM +0200, Benjamin Tissoires wrote: >> The Elan touchpads over I2C/SMBus also can handle a >> trackstick. Unfortunately, nothing tells u

Re: [PATCH 3/8] Input: elan_i2c - add trackstick report

On Fri, Apr 6, 2018 at 1:46 AM, Dmitry Torokhov wrote: > Hi Benjamin, > > On Thu, Apr 05, 2018 at 03:25:32PM +0200, Benjamin Tissoires wrote: >> The Elan touchpads over I2C/SMBus also can handle a >> trackstick. Unfortunately, nothing tells us if the >> device supports

Re: [PATCH 0/8] Input: support for latest Lenovo thinkpads (series 80)

Hi Dmitry, On Fri, Apr 6, 2018 at 1:51 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > Hi Benjamin, > > On Thu, Apr 05, 2018 at 03:25:29PM +0200, Benjamin Tissoires wrote: >> Hi Dmitry, >> >> well, this year, Lenovo gave us a surprise and decide

Re: [PATCH 0/8] Input: support for latest Lenovo thinkpads (series 80)

Hi Dmitry, On Fri, Apr 6, 2018 at 1:51 AM, Dmitry Torokhov wrote: > Hi Benjamin, > > On Thu, Apr 05, 2018 at 03:25:29PM +0200, Benjamin Tissoires wrote: >> Hi Dmitry, >> >> well, this year, Lenovo gave us a surprise and decided to not use >> the same tou

[PATCH 0/8] Input: support for latest Lenovo thinkpads (series 80)

was lacking tests from users with SMBus as all the laptops I tried where puer PS/2. Anyway, it would be cool if you could have a look at the series. Cheers, Benjamin Benjamin Tissoires (8): Input: synaptics - add Lenovo 80 series ids to SMBus input: elan_i2c_smbus - fix corrupted stack

[PATCH 0/8] Input: support for latest Lenovo thinkpads (series 80)

was lacking tests from users with SMBus as all the laptops I tried where puer PS/2. Anyway, it would be cool if you could have a look at the series. Cheers, Benjamin Benjamin Tissoires (8): Input: synaptics - add Lenovo 80 series ids to SMBus input: elan_i2c_smbus - fix corrupted stack

[PATCH 2/8] input: elan_i2c_smbus - fix corrupted stack

(I2C_SMBUS_BLOCK_MAX) and there is no safeguard on how many bytes are provided in the return value. Ensure we always have enough space for any future firmware. Also 0-initialize the values to prevent any access to uninitialized memory. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.

[PATCH 2/8] input: elan_i2c_smbus - fix corrupted stack

(I2C_SMBUS_BLOCK_MAX) and there is no safeguard on how many bytes are provided in the return value. Ensure we always have enough space for any future firmware. Also 0-initialize the values to prevent any access to uninitialized memory. Signed-off-by: Benjamin Tissoires --- drivers/input/mouse

[PATCH 1/8] Input: synaptics - add Lenovo 80 series ids to SMBus

xed it so upstream now works fine with or without RMI4, and there is no point not using RMI4 - the T480s is using an Elan touchpad, so that's a different story Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/input/mouse/synaptics.c | 3 +++ 1 file change

[PATCH 1/8] Input: synaptics - add Lenovo 80 series ids to SMBus

xed it so upstream now works fine with or without RMI4, and there is no point not using RMI4 - the T480s is using an Elan touchpad, so that's a different story Signed-off-by: Benjamin Tissoires --- drivers/input/mouse/synaptics.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/driv

[PATCH 4/8] Input: elantech - split device info into a separate structure

In preparation for SMBus device support, move static device information that we query form the touchpad upon initialization into separate structure. This will allow us to query the device without allocating memory first. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.

[PATCH 4/8] Input: elantech - split device info into a separate structure

In preparation for SMBus device support, move static device information that we query form the touchpad upon initialization into separate structure. This will allow us to query the device without allocating memory first. Signed-off-by: Benjamin Tissoires --- drivers/input/mouse/elantech.c | 271

[PATCH 3/8] Input: elan_i2c - add trackstick report

Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- changes in v2: - renamed ETP_PT_REPORT_ID into ETP_TP_REPORT_ID (pass-through to track-point) to stay more in line with the rest - removed Host Notify support so amended to match parent --- drivers/input/mouse/elan

[PATCH 3/8] Input: elan_i2c - add trackstick report

Signed-off-by: Benjamin Tissoires --- changes in v2: - renamed ETP_PT_REPORT_ID into ETP_TP_REPORT_ID (pass-through to track-point) to stay more in line with the rest - removed Host Notify support so amended to match parent --- drivers/input/mouse/elan_i2c.h | 10 drivers/input/mouse

[PATCH 6/8] Input: elantech - add support for SMBus devices

to individually expose those hardware over SMBus. the parameter mentioned above is elantech_smbus from the psmouse module. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/input/mouse/Kconfig| 12 +++ drivers/input/mouse/elantech.c

[PATCH 7/8] Input: elantech - detect new ICs and setup Host Notify for them

fingers every 8 ms, instead of having a limit of 2 every 8 ms. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/input/mouse/elantech.c | 11 +++ drivers/input/mouse/elantech.h | 15 +++ 2 files changed, 22 insertions(+), 4 deletions(-) diff

[PATCH 7/8] Input: elantech - detect new ICs and setup Host Notify for them

fingers every 8 ms, instead of having a limit of 2 every 8 ms. Signed-off-by: Benjamin Tissoires --- drivers/input/mouse/elantech.c | 11 +++ drivers/input/mouse/elantech.h | 15 +++ 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/drivers/input/mouse/elantech.c b

[PATCH 6/8] Input: elantech - add support for SMBus devices

to individually expose those hardware over SMBus. the parameter mentioned above is elantech_smbus from the psmouse module. Signed-off-by: Benjamin Tissoires --- drivers/input/mouse/Kconfig| 12 +++ drivers/input/mouse/elantech.c | 184 - drivers/input/mouse

[PATCH 5/8] Input: elantech - query the resolution in query_info

The command ETP_RESOLUTION_QUERY also contains the bus information. It is better to fetch it once, while we are querying for device information. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/input/mouse/elantech.c | 27 +++ drivers

[PATCH 5/8] Input: elantech - query the resolution in query_info

The command ETP_RESOLUTION_QUERY also contains the bus information. It is better to fetch it once, while we are querying for device information. Signed-off-by: Benjamin Tissoires --- drivers/input/mouse/elantech.c | 27 +++ drivers/input/mouse/elantech.h | 2 ++ 2 files

[PATCH 8/8] input: psmouse-smbus: allow to control psmouse_deactivate

This seems to be Synaptics specific, as some Elan touchpads are not correctly switching to SMBus if we call deactivate before switching to SMBus on cold boot and on resume. Tested with the T480s Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/input/mouse/elan

[PATCH 8/8] input: psmouse-smbus: allow to control psmouse_deactivate

This seems to be Synaptics specific, as some Elan touchpads are not correctly switching to SMBus if we call deactivate before switching to SMBus on cold boot and on resume. Tested with the T480s Signed-off-by: Benjamin Tissoires --- drivers/input/mouse/elantech.c | 2 +- drivers/input

Re: [PATCH v7 1/2] HID: add driver for Valve Steam Controller

Hi Rodrigo, few comments inlined. On Sun, Mar 25, 2018 at 6:07 PM, Rodrigo Rivas Costa wrote: > There are two ways to connect the Steam Controller: directly to the USB > or with the USB wireless adapter. Both methods are similar, but the > wireless adapter can

Re: [PATCH v7 1/2] HID: add driver for Valve Steam Controller

Hi Rodrigo, few comments inlined. On Sun, Mar 25, 2018 at 6:07 PM, Rodrigo Rivas Costa wrote: > There are two ways to connect the Steam Controller: directly to the USB > or with the USB wireless adapter. Both methods are similar, but the > wireless adapter can connect up to 4 devices at the

Re: [PATCH v7 0/2] hid-steam driver with user mode client dection

Hi Rodrigo, On Sun, Mar 25, 2018 at 6:07 PM, Rodrigo Rivas Costa wrote: > This is a reroll of the Steam Controller driver. > > This time the client usage is detected by using exposing a custom hidraw > device (hid_ll_driver) to userland and forwarding that to the

Re: [PATCH v7 0/2] hid-steam driver with user mode client dection

Hi Rodrigo, On Sun, Mar 25, 2018 at 6:07 PM, Rodrigo Rivas Costa wrote: > This is a reroll of the Steam Controller driver. > > This time the client usage is detected by using exposing a custom hidraw > device (hid_ll_driver) to userland and forwarding that to the real one. That is actually more

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

On Wed, Mar 21, 2018 at 5:33 PM, Robert Munteanu <romb...@apache.org> wrote: > Hi Benjamin, > > On Wed, 2018-03-21 at 17:12 +0100, Benjamin Tissoires wrote: >> Hi Robert, >> >> First, apologies for not answering to the RFC. I missed it and it >> fell >>

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

On Wed, Mar 21, 2018 at 5:33 PM, Robert Munteanu wrote: > Hi Benjamin, > > On Wed, 2018-03-21 at 17:12 +0100, Benjamin Tissoires wrote: >> Hi Robert, >> >> First, apologies for not answering to the RFC. I missed it and it >> fell >> down in my INBOX. >>

<    2   3   4   5   6   7   8   9   10   11   >