[PATCH v3 1/4] HID: core: move the dynamic quirks handling in core

usbhid has a list of dynamic quirks in addition to a list of static quirks. There is not much USB specific in that, so move this part of the module in core so we can have one central place for quirks. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- changes in v3: - r

[PATCH v3 3/4] HID: core: move the list of ignored devices in hid-quirks.c

. Signed-off-by: Benjamin Tissoires --- no changes in v3 no changes in v2 --- drivers/hid/hid-core.c | 309 -- drivers/hid/hid-quirks.c | 312 +++ 2 files changed, 312 insertions(+), 309 deletions(-) diff

[PATCH v3 0/4] Quirks cleanup and hid-generic niceness

Hi, this is v3 rebased on top of for-next. There are no other changes. Cheers, Benjamin Benjamin Tissoires (4): HID: core: move the dynamic quirks handling in core HID: quirks: move the list of special devices into a quirk HID: core: move the list of ignored devices in hid-quirks.c HID

[PATCH v3 1/4] HID: core: move the dynamic quirks handling in core

usbhid has a list of dynamic quirks in addition to a list of static quirks. There is not much USB specific in that, so move this part of the module in core so we can have one central place for quirks. Signed-off-by: Benjamin Tissoires --- changes in v3: - rebased on top of for-next

Re: [PATCH v2 0/4] Quirks cleanup and hid-generic niceness

Hi Jiri, On Nov 16 2017 or thereabouts, Jiri Kosina wrote: > On Tue, 3 Oct 2017, Benjamin Tissoires wrote: > > > Hi, > > > > Niels found an issue with v1 of the series, while compiling the usbhid > > module > > as a separate .ko. > > > > Se

Re: [PATCH v2 0/4] Quirks cleanup and hid-generic niceness

Hi Jiri, On Nov 16 2017 or thereabouts, Jiri Kosina wrote: > On Tue, 3 Oct 2017, Benjamin Tissoires wrote: > > > Hi, > > > > Niels found an issue with v1 of the series, while compiling the usbhid > > module > > as a separate .ko. > > > > Se

Re: [PATCH] HID: input: enable Totem on the Dell Canvas 27

On Nov 14 2017 or thereabouts, Dmitry Torokhov wrote: > On Tue, Nov 14, 2017 at 06:50:43PM +1000, Peter Hutterer wrote: > > sorry, this one got stuck in my outbox. > > > > On Fri, Nov 10, 2017 at 11:26:35AM +0100, Benjamin Tissoires wrote: > > > The Dell Canvas

Re: [PATCH] HID: input: enable Totem on the Dell Canvas 27

On Nov 14 2017 or thereabouts, Dmitry Torokhov wrote: > On Tue, Nov 14, 2017 at 06:50:43PM +1000, Peter Hutterer wrote: > > sorry, this one got stuck in my outbox. > > > > On Fri, Nov 10, 2017 at 11:26:35AM +0100, Benjamin Tissoires wrote: > > > The Dell Canvas

[PATCH] HID: input: enable Totem on the Dell Canvas 27

and Heigth are groupped together, the FW reports similar values for both and we are out of ABS_* events. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1511846 Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- Hi, This is probably v4.16 material as we are

[PATCH] HID: input: enable Totem on the Dell Canvas 27

and Heigth are groupped together, the FW reports similar values for both and we are out of ABS_* events. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1511846 Signed-off-by: Benjamin Tissoires --- Hi, This is probably v4.16 material as we are close to the merge window (I wouldn't mind

Re: [PATCH v2 3/3] HID: cp2112: fix broken gpio_direction_input callback

ymanski <sebastien.szyman...@armadeus.com> > --- > Changes in v2: > - rework error handling to have only one exit path as suggested by >Benjamin Tissoires <benjamin.tissoi...@redhat.com> Looks good to me now. Thanks for the respin: Reviewed-by: Benjamin Tissoires <benjamin.tissoi

Re: [PATCH v2 3/3] HID: cp2112: fix broken gpio_direction_input callback

ki > --- > Changes in v2: > - rework error handling to have only one exit path as suggested by >Benjamin Tissoires Looks good to me now. Thanks for the respin: Reviewed-by: Benjamin Tissoires Cheers, Benjamin > > drivers/hid/hid-cp2112.c | 8 ++-- > 1 file changed, 6

Re: [PATCH 3/3] HID: cp2112: fix broken gpio_direction_input callback

On Nov 06 2017 or thereabouts, Sébastien Szymanski wrote: > On 11/06/2017 09:11 AM, Benjamin Tissoires wrote: > > On Nov 02 2017 or thereabouts, Sébastien Szymanski wrote: > >> When everything goes smoothly, ret is set to 0 which makes the function > >> to return

Re: [PATCH 3/3] HID: cp2112: fix broken gpio_direction_input callback

On Nov 06 2017 or thereabouts, Sébastien Szymanski wrote: > On 11/06/2017 09:11 AM, Benjamin Tissoires wrote: > > On Nov 02 2017 or thereabouts, Sébastien Szymanski wrote: > >> When everything goes smoothly, ret is set to 0 which makes the function > >> to return

Re: [PATCH] HID: i2c-hid: add reset gpio property

On Oct 30 2017 or thereabouts, Brian Norris wrote: > On Mon, Oct 30, 2017 at 03:15:19PM -0500, Rob Herring wrote: > > On Mon, Oct 30, 2017 at 11:57 AM, Brian Norris > > wrote: > > > On Mon, Oct 30, 2017 at 10:49:49AM +0800, Lin Huang wrote: > > >> ---

Re: [PATCH] HID: i2c-hid: add reset gpio property

On Oct 30 2017 or thereabouts, Brian Norris wrote: > On Mon, Oct 30, 2017 at 03:15:19PM -0500, Rob Herring wrote: > > On Mon, Oct 30, 2017 at 11:57 AM, Brian Norris > > wrote: > > > On Mon, Oct 30, 2017 at 10:49:49AM +0800, Lin Huang wrote: > > >> --- a/drivers/hid/i2c-hid/i2c-hid.c > > >> +++

Re: [PATCH v2 2/2] devicetree: i2c-hid: Add reset property

Hi Rob, On Nov 01 2017 or thereabouts, Rob Herring wrote: > On Tue, Oct 31, 2017 at 11:03:16AM +0800, Lin Huang wrote: > > Document a "reset" and "assert-reset-us", it can be used for > > driver control reset property. And reuse post-power-on-delay-ms > > for deassert reset delay. > >

Re: [PATCH v2 2/2] devicetree: i2c-hid: Add reset property

Hi Rob, On Nov 01 2017 or thereabouts, Rob Herring wrote: > On Tue, Oct 31, 2017 at 11:03:16AM +0800, Lin Huang wrote: > > Document a "reset" and "assert-reset-us", it can be used for > > driver control reset property. And reuse post-power-on-delay-ms > > for deassert reset delay. > >

Re: [PATCH 2/3] HID: cp2112: add HIDRAW dependency

Szymanski <sebastien.szyman...@armadeus.com> Patches 1 and 2 (only) are: Acked-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > --- > drivers/hid/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/

Re: [PATCH 2/3] HID: cp2112: add HIDRAW dependency

Szymanski Patches 1 and 2 (only) are: Acked-by: Benjamin Tissoires > --- > drivers/hid/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 374301f..8c7a0ce 100644 > --- a/drivers/hid/Kconf

Re: [PATCH 3/3] HID: cp2112: fix broken gpio_direction_input callback

On Nov 02 2017 or thereabouts, Sébastien Szymanski wrote: > When everything goes smoothly, ret is set to 0 which makes the function > to return EIO error. > > Fixes: 8e9faa15469e ("HID: cp2112: fix gpio-callback error handling") > Signed-off-by: Sébastien Szymanski

Re: [PATCH 3/3] HID: cp2112: fix broken gpio_direction_input callback

On Nov 02 2017 or thereabouts, Sébastien Szymanski wrote: > When everything goes smoothly, ret is set to 0 which makes the function > to return EIO error. > > Fixes: 8e9faa15469e ("HID: cp2112: fix gpio-callback error handling") > Signed-off-by: Sébastien Szymanski > --- >

Re: [PATCH] HID: Wacom: switch Dell canvas into highres mode

Hi Jason, On Nov 03 2017 or thereabouts, Jason Gerecke wrote: > On November 3, 2017 10:29:47 AM PDT, Benjamin Tissoires > <benjamin.tissoi...@redhat.com> wrote: > >The Dell Canvas exports 2 collections for the Pen part. The only > >difference between the 2 is that

Re: [PATCH] HID: Wacom: switch Dell canvas into highres mode

Hi Jason, On Nov 03 2017 or thereabouts, Jason Gerecke wrote: > On November 3, 2017 10:29:47 AM PDT, Benjamin Tissoires > wrote: > >The Dell Canvas exports 2 collections for the Pen part. The only > >difference between the 2 is that the default one has half the > >res

[PATCH] HID: Wacom: switch Dell canvas into highres mode

The Dell Canvas exports 2 collections for the Pen part. The only difference between the 2 is that the default one has half the resolution of the second one. The Windows driver switches the tablet into the second mode, so we should behave the same. Signed-off-by: Benjamin Tissoires

[PATCH] HID: Wacom: switch Dell canvas into highres mode

The Dell Canvas exports 2 collections for the Pen part. The only difference between the 2 is that the default one has half the resolution of the second one. The Windows driver switches the tablet into the second mode, so we should behave the same. Signed-off-by: Benjamin Tissoires --- Hi

Re: [PATCH] Input: synaptics-rmi4: Limit the range of what GPIOs are buttons

ing the max 6 button count will be blown up? :/ Still, there is not much we can do (or have a whitelist, but it is a pain), so: Acked-By: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > GPIOs which are connected to buttons. Additional GPIOs may be used as > input

Re: [PATCH] Input: synaptics-rmi4: Limit the range of what GPIOs are buttons

ing the max 6 button count will be blown up? :/ Still, there is not much we can do (or have a whitelist, but it is a pain), so: Acked-By: Benjamin Tissoires Cheers, Benjamin > GPIOs which are connected to buttons. Additional GPIOs may be used as > input GPIOs to signal the touch controller

Re: [PATCH] HID: hidraw: Improve a size determination in two functions

; *file) > unsigned long flags; > int err = 0; > > - if (!(list = kzalloc(sizeof(struct hidraw_list), GFP_KERNEL))) { > - err = -ENOMEM; > - goto out; > - } > + list = kzalloc(sizeof(*list), GFP_KERNEL); I am not sure the

Re: [PATCH] HID: hidraw: Improve a size determination in two functions

gt; - if (!(list = kzalloc(sizeof(struct hidraw_list), GFP_KERNEL))) { > - err = -ENOMEM; > - goto out; > - } > + list = kzalloc(sizeof(*list), GFP_KERNEL); I am not sure the change from "if (!a = kzalloc())" to "a = kzalloc(); if (!a)"

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

On Oct 18 2017 or thereabouts, Andrew Duggan wrote: > > > On 10/18/2017 07:13 AM, Jiri Kosina wrote: > > On Wed, 18 Oct 2017, Benjamin Tissoires wrote: > > > > > > The hid-rmi driver may handle non rmi devices on composite USB devices. > > > > Callba

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

On Oct 18 2017 or thereabouts, Andrew Duggan wrote: > > > On 10/18/2017 07:13 AM, Jiri Kosina wrote: > > On Wed, 18 Oct 2017, Benjamin Tissoires wrote: > > > > > > The hid-rmi driver may handle non rmi devices on composite USB devices. > > > > Callba

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

On Oct 17 2017 or thereabouts, Andrew Duggan wrote: > The hid-rmi driver may handle non rmi devices on composite USB devices. > Callbacks need to make sure that the current device is a RMI device before > calling RMI specific functions. Most callbacks already have this check, but > this patch adds

Re: [PATCH] HID: rmi: Check that a device is a RMI device before calling RMI functions

On Oct 17 2017 or thereabouts, Andrew Duggan wrote: > The hid-rmi driver may handle non rmi devices on composite USB devices. > Callbacks need to make sure that the current device is a RMI device before > calling RMI specific functions. Most callbacks already have this check, but > this patch adds

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Oct 11 2017 or thereabouts, Jiri Kosina wrote: > On Wed, 11 Oct 2017, Benjamin Tissoires wrote: > > > I am not sure if libinput even uses ABS_MT_ORIENTATION > > I don't think it does, so that should be okay. However ... I had a meeting this Peter at noon today. The summar

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Oct 11 2017 or thereabouts, Jiri Kosina wrote: > On Wed, 11 Oct 2017, Benjamin Tissoires wrote: > > > I am not sure if libinput even uses ABS_MT_ORIENTATION > > I don't think it does, so that should be okay. However ... I had a meeting this Peter at noon today. The summar

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Oct 10 2017 or thereabouts, Dmitry Torokhov wrote: > On Mon, Oct 9, 2017 at 11:57 PM, Henrik Rydberg wrote: > > Hi Wei-Ning, > > > >> The current hid-multitouch driver only allow the report of two > >> orientations, vertical and horizontal. We use the Azimuth orientation >

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

On Oct 10 2017 or thereabouts, Dmitry Torokhov wrote: > On Mon, Oct 9, 2017 at 11:57 PM, Henrik Rydberg wrote: > > Hi Wei-Ning, > > > >> The current hid-multitouch driver only allow the report of two > >> orientations, vertical and horizontal. We use the Azimuth orientation > >> usage 0x3F under

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

NTATION ABS param range. >- Don't set ABS_MT_ORIENTATION in ABS_DG_HEIGHT when it is already > set by ABS_DG_AZIMUTH. > > Signed-off-by: Wei-Ning Huang <wnhu...@chromium.org> > Reviewed-by: Dmitry Torokhov <d...@chromium.org> Looks good now: Reviewed-by: Benjami

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

;- Don't set ABS_MT_ORIENTATION in ABS_DG_HEIGHT when it is already > set by ABS_DG_AZIMUTH. > > Signed-off-by: Wei-Ning Huang > Reviewed-by: Dmitry Torokhov Looks good now: Reviewed-by: Benjamin Tissoires Cheers, Benjamin > --- > drivers/hid/hid-multitouch.c | 52 > +++

Re: [PATCH v3] HID: hid-multitouch: support fine-grain orientation reporting

Hi, On Oct 05 2017 or thereabouts, Jiri Kosina wrote: > > [ adding Benjamin to CC ] > > On Thu, 28 Sep 2017, Wei-Ning Huang wrote: > > > The current hid-multitouch driver only allow the report of two > > orientations, vertical and horizontal. We use the Azimuth orientation > > usage 0x3F under

Re: [PATCH v3] HID: hid-multitouch: support fine-grain orientation reporting

Hi, On Oct 05 2017 or thereabouts, Jiri Kosina wrote: > > [ adding Benjamin to CC ] > > On Thu, 28 Sep 2017, Wei-Ning Huang wrote: > > > The current hid-multitouch driver only allow the report of two > > orientations, vertical and horizontal. We use the Azimuth orientation > > usage 0x3F under

Re: [PATCH] HID: usbhid: Convert timers to use timer_setup()

; multitouch. > > Cc: Jiri Kosina <ji...@kernel.org> > Cc: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > Cc: linux-in...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Cc: Thomas Gleixner <t...@linutronix.de> > Signed-off-by: Kees Cook <keesc...@c

Re: [PATCH] HID: usbhid: Convert timers to use timer_setup()

; multitouch. > > Cc: Jiri Kosina > Cc: Benjamin Tissoires > Cc: linux-in...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Cc: Thomas Gleixner > Signed-off-by: Kees Cook > --- > This requires commit 686fef928bba ("timer: Prepare to change timer > callback argume

[PATCH v2 1/4] HID: core: move the dynamic quirks handling in core

usbhid has a list of dynamic quirks in addition to a list of static quirks. There is not much USB specific in that, so move this part of the module in core so we can have one central place for quirks. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- changes in v2:

[PATCH v2 1/4] HID: core: move the dynamic quirks handling in core

usbhid has a list of dynamic quirks in addition to a list of static quirks. There is not much USB specific in that, so move this part of the module in core so we can have one central place for quirks. Signed-off-by: Benjamin Tissoires --- changes in v2: - add missing EXPORT_SYMBOL[_GPL

[PATCH v2 3/4] HID: core: move the list of ignored devices in hid-quirks.c

. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- no changes in v2 --- drivers/hid/hid-core.c | 309 -- drivers/hid/hid-quirks.c | 312 +++ 2 files changed, 312 insertions(+

[PATCH v2 3/4] HID: core: move the list of ignored devices in hid-quirks.c

. Signed-off-by: Benjamin Tissoires --- no changes in v2 --- drivers/hid/hid-core.c | 309 -- drivers/hid/hid-quirks.c | 312 +++ 2 files changed, 312 insertions(+), 309 deletions(-) diff --git a/drivers/hid

[PATCH v2 4/4] HID: core: remove the absolute need of hid_have_special_driver[]

hid_have_special_driver[] useless. It still allows to not see a hid-generic driver bound and removed during boot, so we can keep it around. This will also help other people to have a special HID driver without the need of recompiling hid-core. Signed-off-by: Benjamin Tissoires <benjamin.tis

[PATCH v2 4/4] HID: core: remove the absolute need of hid_have_special_driver[]

hid_have_special_driver[] useless. It still allows to not see a hid-generic driver bound and removed during boot, so we can keep it around. This will also help other people to have a special HID driver without the need of recompiling hid-core. Signed-off-by: Benjamin Tissoires --- no changes in v2

[PATCH v2 2/4] HID: quirks: move the list of special devices into a quirk

-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- no changes in v2 --- drivers/hid/hid-core.c| 531 +--- drivers/hid/hid-quirks.c | 552 +- include/linux/hid.h | 1 + net/bluetoot

[PATCH v2 2/4] HID: quirks: move the list of special devices into a quirk

-by: Benjamin Tissoires --- no changes in v2 --- drivers/hid/hid-core.c| 531 +--- drivers/hid/hid-quirks.c | 552 +- include/linux/hid.h | 1 + net/bluetooth/hidp/core.c | 2 +- 4 files changed

[PATCH v2 0/4] Quirks cleanup and hid-generic niceness

Hi, Niels found an issue with v1 of the series, while compiling the usbhid module as a separate .ko. Sending a v2 with the proper From: field fixed now. I also use -M1 to show in 1/4 that usbhid/hid-quirks.c is basically moved to hid-quirks.c. Cheers, Benjamin Benjamin Tissoires (4): HID

[PATCH v2 0/4] Quirks cleanup and hid-generic niceness

Hi, Niels found an issue with v1 of the series, while compiling the usbhid module as a separate .ko. Sending a v2 with the proper From: field fixed now. I also use -M1 to show in 1/4 that usbhid/hid-quirks.c is basically moved to hid-quirks.c. Cheers, Benjamin Benjamin Tissoires (4): HID

Re: [PATCH 0/4] Quirks cleanup and hid-generic niceness

mechanism in hid-core. > For instance, there is a second call of hid_lookup_quirk() in > usbhid/hid-core.c > that I am not sure about the absolute need. > > Niels, please have a look at this and tell me if you are OK to rebase your > series on top of it. > > Cheers, > B

Re: [PATCH 0/4] Quirks cleanup and hid-generic niceness

On Mon, Oct 2, 2017 at 10:18 PM, Fedora Kernel Team wrote: Ouch, I happen to be in a git tree of the Fedora kernel, so git send-email decided to rewrite the 'from:' field. I'll add this to my check list before sending :/ Cheers, Benjamin > From: Benjamin Tissoires >

Re: [PATCH] HID: hid-multitouch: forward MSC_TIMESTAMP

me > > instead of a potentially more fragile difference between > > the 2 deltas. > > Benjamin, any objections on merging this one for 4.15? I like it. > No objections from my side. Acked-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > Thanks, > > -- > Jiri Kosina > SUSE Labs >

Re: [PATCH] HID: hid-multitouch: forward MSC_TIMESTAMP

potentially more fragile difference between > > the 2 deltas. > > Benjamin, any objections on merging this one for 4.15? I like it. > No objections from my side. Acked-by: Benjamin Tissoires Cheers, Benjamin > Thanks, > > -- > Jiri Kosina > SUSE Labs >

Re: [PATCH 1/1] Revert "HID: multitouch: Support ALPS PTP stick with pid 0x120A"

/lists/linux-input/msg53222.html > > Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> Acked-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > --- > drivers/hid/hid-ids.h| 1 - > drivers/hid/hid-multitouch.c | 4 > 2 files c

Re: [PATCH 1/1] Revert "HID: multitouch: Support ALPS PTP stick with pid 0x120A"

/lists/linux-input/msg53222.html > > Signed-off-by: Kai-Heng Feng Acked-by: Benjamin Tissoires Cheers, Benjamin > --- > drivers/hid/hid-ids.h| 1 - > drivers/hid/hid-multitouch.c | 4 > 2 files changed, 5 deletions(-) > > diff --git a/drivers/hid/hid-ids.h b/

Re: [PATCH] Input: synaptics - Disable kernel tracking on SMBus devices

ned-off-by: Andrew Duggan <adug...@synaptics.com> > Tested-by: Kamil Páral <kpa...@redhat.com> Acked-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Thanks Andrew for the patch! Cheers, Benjamin > --- > drivers/input/mouse/synaptics.c | 3 +-- > 1 file

Re: [PATCH] Input: synaptics - Disable kernel tracking on SMBus devices

Signed-off-by: Andrew Duggan > Tested-by: Kamil Páral Acked-by: Benjamin Tissoires Thanks Andrew for the patch! Cheers, Benjamin > --- > drivers/input/mouse/synaptics.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/mouse/synaptics.c

Re: [PATCH] Input: synaptics-rmi4 - pr_err() strings should end with newlines

Hi Arvind, On Sep 26 2017 or thereabouts, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav > --- > drivers/input/rmi4/rmi_f11.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] Input: synaptics-rmi4 - pr_err() strings should end with newlines

Hi Arvind, On Sep 26 2017 or thereabouts, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav > --- > drivers/input/rmi4/rmi_f11.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Jul 24 2017 or thereabouts, Lyude Paul wrote: > On Mon, 2017-07-24 at 10:15 +0200, Benjamin Tissoires wrote: > > On Jul 22 2017 or thereabouts, Lyude wrote: > > > So it looks like that suspend/resume has actually always been > > > broken on > > > hid-rmi. T

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Jul 24 2017 or thereabouts, Lyude Paul wrote: > On Mon, 2017-07-24 at 10:15 +0200, Benjamin Tissoires wrote: > > On Jul 22 2017 or thereabouts, Lyude wrote: > > > So it looks like that suspend/resume has actually always been > > > broken on > > > hid-rmi. T

Re: [PATCH] HID: core: assign usbhid to handle EETI PID=0x0001 HID device

On Aug 11 2017 or thereabouts, JamChen wrote: > From: Jam Chen > > The vendor used the same PID(0x0001) for multiple touch IC controllers. > The newer ICs can support HID class and report the multitouch collection > in the descriptor. So they were handled by the

Re: [PATCH] HID: core: assign usbhid to handle EETI PID=0x0001 HID device

On Aug 11 2017 or thereabouts, JamChen wrote: > From: Jam Chen > > The vendor used the same PID(0x0001) for multiple touch IC controllers. > The newer ICs can support HID class and report the multitouch collection > in the descriptor. So they were handled by the hid-multitouch driver. > But some

Re: [PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

On Aug 18 2017 or thereabouts, Dmitry Torokhov wrote: > The touchpad on Lenovo Carbon X1 Gen 5 (2017 - Kabylake) is accessible over > SMBUS/RMI, so let's activate it by default. > > Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> > --- Reviewed-by: Benjamin Tisso

Re: [PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

On Aug 18 2017 or thereabouts, Dmitry Torokhov wrote: > The touchpad on Lenovo Carbon X1 Gen 5 (2017 - Kabylake) is accessible over > SMBUS/RMI, so let's activate it by default. > > Signed-off-by: Dmitry Torokhov > --- Reviewed-by: Benjamin Tissoires Cheers, Benjamin > d

Re: [PATCH] HID: asus: Add support for Fn keys on Asus ROG G752

Looks good to me: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > drivers/hid/hid-asus.c | 29 + > drivers/hid/hid-core.c | 2 +- > drivers/hid/hid-ids.h | 1 + > 3 files changed, 31 insertions(+), 1 deletion(-) > > diff --gi

Re: [PATCH] HID: asus: Add support for Fn keys on Asus ROG G752

On Aug 20 2017 or thereabouts, Maxime Bellengé wrote: > This patch adds support for Fn keys on Asus ROG G752 laptop. > The report descriptor is broken so I fixed it. > > Tested on an Asus G752VT. > > Signed-off-by: Maxime Bellengé > --- Looks good to me: Reviewed-b

Re: [PATCH 2/2] HID: multitouch: Support Asus T304UA media keys

On Aug 02 2017 or thereabouts, Jiri Kosina wrote: > On Mon, 24 Jul 2017, João Paulo Rechi Vita wrote: > > > The Asus T304UA convertible sports a magnetic detachable keyboard with > > touchpad, which is connected over USB. Most of the keyboard hotkeys are > > exposed through the same USB interface

Re: [PATCH 2/2] HID: multitouch: Support Asus T304UA media keys

On Aug 02 2017 or thereabouts, Jiri Kosina wrote: > On Mon, 24 Jul 2017, João Paulo Rechi Vita wrote: > > > The Asus T304UA convertible sports a magnetic detachable keyboard with > > touchpad, which is connected over USB. Most of the keyboard hotkeys are > > exposed through the same USB interface

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Jul 22 2017 or thereabouts, Lyude wrote: > So it looks like that suspend/resume has actually always been broken on > hid-rmi. The fact it worked was a rather silly coincidence that was > relying on the HID device to already be opened upon resume. This means > that so long as anything was

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Jul 22 2017 or thereabouts, Lyude wrote: > So it looks like that suspend/resume has actually always been broken on > hid-rmi. The fact it worked was a rather silly coincidence that was > relying on the HID device to already be opened upon resume. This means > that so long as anything was

Re: [PATCH] HID: logitech-hidpp: fix spelling mistake, "feeback" -> "feedback"

Colin Ian King <colin.k...@canonical.com> > --- Acked-By: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > drivers/hid/hid-logitech-hidpp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-logitech-hidpp.c > b/drivers/hid/hid-logi

Re: [PATCH] HID: logitech-hidpp: fix spelling mistake, "feeback" -> "feedback"

On Jul 14 2017 or thereabouts, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in hid_info message and add line break > to split an overly long line to clean up a checkpatch warning. > > Signed-off-by: Colin Ian King > --- Acked-By: Benjamin T

Re: [PATCH] HID: usbhid: fix "always poll" quirk

ported-by: Olof Johansson <o...@lixom.net> > Tested-by: Olof Johansson <o...@lixom.net> > Fixes: e399396a6b0 ("HID: usbhid: remove custom locking from usbhid_open...") > Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> > --- slightly reviewed and

Re: [PATCH] HID: usbhid: fix "always poll" quirk

Reported-by: Olof Johansson > Tested-by: Olof Johansson > Fixes: e399396a6b0 ("HID: usbhid: remove custom locking from usbhid_open...") > Signed-off-by: Dmitry Torokhov > --- slightly reviewed and Acked-by: Benjamin Tissoires Cheers, Benjamin > drivers/hid/usbhid/h

[PATCH] HID: ortek: add one more buggy device

The iHome keypad also requires the same tweak we are doing for other Ortek devices. Reported-by: Mairin Duffy <du...@redhat.com> Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + drivers/hid/hid

[PATCH] HID: ortek: add one more buggy device

The iHome keypad also requires the same tweak we are doing for other Ortek devices. Reported-by: Mairin Duffy Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + drivers/hid/hid-ortek.c | 6 -- 3 files changed, 6 insertions(+), 2 deletions

Re: [PATCH] HID: hid-logitech-hidpp: add NULL check on devm_kmemdup() return value

On Jul 07 2017 or thereabouts, Gustavo A. R. Silva wrote: > Check return value from call to devm_kmemdup() > in order to prevent a NULL pointer dereference. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> > --- Reviewed-by: Benjamin Tissoires <benja

Re: [PATCH] HID: hid-logitech-hidpp: add NULL check on devm_kmemdup() return value

On Jul 07 2017 or thereabouts, Gustavo A. R. Silva wrote: > Check return value from call to devm_kmemdup() > in order to prevent a NULL pointer dereference. > > Signed-off-by: Gustavo A. R. Silva > --- Reviewed-by: Benjamin Tissoires > drivers/hid/hid-logitech-hidpp.c

Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.

.com> > --- Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > drivers/hid/wacom_sys.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c > index 838c1eb..ae2408d 100644 > --- a/driv

Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.

On Jul 08 2017 or thereabouts, Christos Gkekas wrote: > Variable mode in method wacom_show_remote_mode() is defined as u8, thus > statement (mode >= 0) is always true and should be removed, simplifying > the logic. > > Signed-off-by: Christos Gkekas > --- Reviewed-b

Re: [PATCH] HID: multitouch: do not blindly set EV_KEY or EV_ABS bits

lease take a look. set_bit(usage->type, input->evbit); is called by hid-input.c when the return code is positive, so we should be safe here. Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > > drivers/hid/hid-multitouch.c | 16 >

Re: [PATCH] HID: multitouch: do not blindly set EV_KEY or EV_ABS bits

s Fend > Cc: sta...@vger.kernel.org > Signed-off-by: Dmitry Torokhov > --- > > Jiri, Benjamin, I marked it for stable as it causes regressions in 4.12 > reported by users. Please take a look. set_bit(usage->type, input->evbit); is called by hid-input.c when the return code

Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation

Hi Andy, Thanks for the review :) On Jun 29 2017 or thereabouts, Andy Shevchenko wrote: > +Cc: Hans (he might give some advice regarding to the below) > > On Thu, Jun 29, 2017 at 3:10 PM, Benjamin Tissoires > <benjamin.tissoi...@redhat.com> wrote: > > MSHW0011 repla

Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation

Hi Andy, Thanks for the review :) On Jun 29 2017 or thereabouts, Andy Shevchenko wrote: > +Cc: Hans (he might give some advice regarding to the below) > > On Thu, Jun 29, 2017 at 3:10 PM, Benjamin Tissoires > wrote: > > MSHW0011 replaces the battery firmware by using ACPI

Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation

ip is used in the end :( > > Judging from the above I believe that implementing the ACPI > OpRegion support for the MSHW0011 devices is a good solution > in this case. Thanks :) > > > On Thu, Jun 29, 2017 at 3:10 PM, Benjamin Tissoires > > <benjamin.tissoi...@redhat.com> wrote

Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation

ip is used in the end :( > > Judging from the above I believe that implementing the ACPI > OpRegion support for the MSHW0011 devices is a good solution > in this case. Thanks :) > > > On Thu, Jun 29, 2017 at 3:10 PM, Benjamin Tissoires > > wrote: > > > MSHW0011 replaces t

Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation

On Jun 29 2017 or thereabouts, Rafael J. Wysocki wrote: > On Thu, Jun 29, 2017 at 4:22 PM, Andy Shevchenko > <andy.shevche...@gmail.com> wrote: > > +Cc: Hans (he might give some advice regarding to the below) > > > > On Thu, Jun 29, 2017 at 3:10 PM, Benjamin

Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation

On Jun 29 2017 or thereabouts, Rafael J. Wysocki wrote: > On Thu, Jun 29, 2017 at 4:22 PM, Andy Shevchenko > wrote: > > +Cc: Hans (he might give some advice regarding to the below) > > > > On Thu, Jun 29, 2017 at 3:10 PM, Benjamin Tissoires > > wrote: > >>

[PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation

to check for changes. Link: https://bugzilla.kernel.org/show_bug.cgi?id=106231 Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Signed-off-by: Stephen Just <stephenj...@gmail.com> --- Hi guys, sorry for taking so long providing a v2 for this one, but it took me a while t

[PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation

to check for changes. Link: https://bugzilla.kernel.org/show_bug.cgi?id=106231 Signed-off-by: Benjamin Tissoires Signed-off-by: Stephen Just --- Hi guys, sorry for taking so long providing a v2 for this one, but it took me a while to understand the acpica process and to get a proper PR done

Re: [PATCH] Input: synaptics - switch t460s 20FN to use RMI4 over SMBus

On Jun 26 2017 or thereabouts, Benjamin Tissoires wrote: > On Jun 26 2017 or thereabouts, Christopher Bachner wrote: > > Hello, > > > > I am assuming that if the inertouch message is not showing up in dmesg, > > then it is working. Is that a correct assumption? > >

Re: [PATCH] Input: synaptics - switch t460s 20FN to use RMI4 over SMBus

On Jun 26 2017 or thereabouts, Benjamin Tissoires wrote: > On Jun 26 2017 or thereabouts, Christopher Bachner wrote: > > Hello, > > > > I am assuming that if the inertouch message is not showing up in dmesg, > > then it is working. Is that a correct assumption? > >

Re: [PATCH] HID: wacom:fix spelling mistake: "exising" -> "existing"

On Jun 26 2017 or thereabouts, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > trivial fix to spelling mistake in hid_warn warning message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > --- Looks good to me: R

Re: [PATCH] HID: wacom:fix spelling mistake: "exising" -> "existing"

On Jun 26 2017 or thereabouts, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in hid_warn warning message > > Signed-off-by: Colin Ian King > --- Looks good to me: Reviewed-by: Benjamin Tissoires Cheers, Benjamin > drivers/hid/wacom_wa

<    4   5   6   7   8   9   10   11   12   13   >