RE: [PATCH v5] Introduce support for Systems Management Driver over WMI for Dell Systems

2020-10-06 Thread Bharathi, Divya
> > Hmm, checkpatch is saying: > > WARNING: Missing Signed-off-by: line by nominal patch author 'Divya > Bharathi ' > > I assume the dell address is the one you want to use ? > > If so try setting the following in ~/.gitconfig: > > [user] > email = divya.bhara...@dell.com > > And t

RE: [PATCH v5] Introduce support for Systems Management Driver over WMI for Dell Systems

2020-10-06 Thread Bharathi, Divya
Sorry for another mail on same patch. I missed to add one response on previous comments > > +/** > > + * init_bios_attributes() - Initialize all attributes for a type > > + * @attr_type: The attribute type to initialize > > + * @guid: The WMI GUID associated with this type to initialize > > + *

RE: [PATCH] MAINTAINERS: rectify DELL WMI SYSMAN DRIVERS section

2020-10-29 Thread Bharathi, Divya
> > Commit e8a60aa7404b ("platform/x86: Introduce support for Systems > Management Driver over WMI for Dell Systems") added a new section DELL > WMI SYSMAN DRIVERS in MAINTAINERS, but slipped in a typo. > > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains: > > warning: no file

RE: [PATCH v2] Introduce support for Systems Management Driver over WMI for Dell Systems

2020-09-17 Thread Bharathi, Divya
> > > > > > > > > + > > > > +/* kept variable names same as in sysfs file name for sysfs_show > > > > +macro > > > definition */ > > > > +struct enumeration_data { > > > > + char display_name_language_code[MAX_BUFF]; > > > > + char attribute_name[MAX_BUFF]; > > > > + char displ

RE: [PATCH v2] Introduce support for Systems Management Driver over WMI for Dell Systems

2020-09-15 Thread Bharathi, Divya
> > > > On 9/4/20 4:28 PM, Divya Bharathi wrote: > > > diff --git a/drivers/platform/x86/dell-wmi-biosattr-interface.c > > b/drivers/platform/x86/dell-wmi-biosattr-interface.c > > > new file mode 100644 > > > index ..dda38d448fec > > > --- /dev/null > > > +++ b/drivers/platform/x86/del