Re: [Xen-devel] 4.4: INFO: rcu_sched self-detected stall on CPU

On 03/25/2016 12:04 PM, Steven Haigh wrote: It may not actually be the full logs. Once the system gets really upset, you can't run anything - as such, grabbing anything from dmesg is not possible. The logs provided above is all that gets spat out to the syslog server. I'll try tinkering with

Re: [PATCH 1/2] xen/x86: Move irq allocation from Xen smp_op.cpu_up()

On 03/25/2016 11:10 AM, Konrad Rzeszutek Wilk wrote: On Thu, Mar 17, 2016 at 09:33:32AM -0400, Boris Ostrovsky wrote: Commit ce0d3c0a6fb1 ("genirq: Revert sparse irq locking around __cpu_up() and move it to x86 for now") reverted irq locking introduced by commit a89941816726

Re: 4.4: INFO: rcu_sched self-detected stall on CPU

On 03/29/2016 02:04 PM, Steven Haigh wrote: Greg, please see below - this is probably more for you... On 03/29/2016 04:56 AM, Steven Haigh wrote: Interestingly enough, this just happened again - but on a different virtual machine. I'm starting to wonder if this may have something to do with

Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

On 04/04/2016 12:30 PM, David Vrabel wrote: On 04/04/16 17:21, Julien Grall wrote: (CC Stefano new e-mail address) Hello Anna-Maria, On 04/04/2016 13:32, Anna-Maria Gleixner wrote: Xen guests do not offline/online CPUs during suspend/resume and therefore FROZEN notifier transitions are not

Re: 4.4: INFO: rcu_sched self-detected stall on CPU

On 03/29/2016 04:56 AM, Steven Haigh wrote: Interestingly enough, this just happened again - but on a different virtual machine. I'm starting to wonder if this may have something to do with the uptime of the machine - as the system that this seems to happen to is always different. Destroying

Re: [Xen-devel] [PATCH v3 0/7] Enhance PAT init to fix Xorg crashes

On 03/29/2016 10:19 AM, Toshi Kani wrote: On Tue, 2016-03-29 at 12:34 +0200, Ingo Molnar wrote: I'd appreciate if someone can test this patch-set on Xen to verify that there is no change in "x86/PAT: Configuration [0-7] .." message in dmesg. So I don't have a Xen setup, but hopefully such

Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence before allocating descs for legacy IRQs

On 04/12/2016 09:27 PM, Boris Ostrovsky wrote: On 04/12/2016 07:15 PM, Stefano Stabellini wrote: On Tue, 12 Apr 2016, Boris Ostrovsky wrote: On 04/12/2016 05:56 PM, Stefano Stabellini wrote: I am not sure, maybe you didn't have CONFIG_SPARSE_IRQ? But I am certain that 4.6-rc2

Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence before allocating descs for legacy IRQs

On 04/13/2016 01:36 PM, Boris Ostrovsky wrote: On 04/12/2016 09:27 PM, Boris Ostrovsky wrote: On 04/12/2016 07:15 PM, Stefano Stabellini wrote: On Tue, 12 Apr 2016, Boris Ostrovsky wrote: On 04/12/2016 05:56 PM, Stefano Stabellini wrote: I am not sure, maybe you didn't have

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

On 04/25/2016 10:11 AM, Borislav Petkov wrote: On Mon, Apr 25, 2016 at 09:54:37AM -0400, Boris Ostrovsky wrote: Yes, those. I don't think the ones in arch/x86/kernel/head_{32,64}.S are ABI. Hmm... I thought that everything specified in boot.txt was ABI. I don't think we can jump

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

On 04/25/2016 09:47 AM, Borislav Petkov wrote: On Mon, Apr 25, 2016 at 09:21:27AM -0400, Boris Ostrovsky wrote: I was following Documentation/x86/boot.txt (plus comments in code preceding those two routines) which I considered to be the API. We are supposed to come to startup_32 with paging

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

On 04/25/2016 11:22 AM, Borislav Petkov wrote: On Mon, Apr 25, 2016 at 10:42:15AM -0400, Boris Ostrovsky wrote: Hmm... I thought that everything specified in boot.txt was ABI. But those are not there. https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/x86

Re: [PATCH 0/2] Reinstate irq alloc/dealloc locking patch

Ping? On 03/17/2016 09:33 AM, Boris Ostrovsky wrote: Original version of that patch (commit a89941816726) had to be reverted due to Xen allocating irqs in its cpu_up ops. The first patch moves allocations into hotplug notifiers and the second one restores the original patch (with minor

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

On 04/27/2016 05:35 AM, David Vrabel wrote: On 27/04/16 06:02, Juergen Gross wrote: On 21/04/16 11:30, Stefano Stabellini wrote: On Thu, 21 Apr 2016, Juergen Gross wrote: On 20/04/16 15:15, Stefano Stabellini wrote: b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number of

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

On 04/27/2016 09:40 AM, David Vrabel wrote: On 27/04/16 14:38, Boris Ostrovsky wrote: int xen_nr_legacy_irqs() { if (xen_hvm_domain()) return nr_legacy_irqs(); if (xen_initial_domain()) return NR_IRQS_LEGACY; return 0; } Yeah, if that does the right thing

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

On 04/24/2016 04:23 PM, Borislav Petkov wrote: On Mon, Feb 01, 2016 at 10:38:48AM -0500, Boris Ostrovsky wrote: Start HVMlite guest at XEN_ELFNOTE_PHYS32_ENTRY address. Setup hypercall page, initialize boot_params, enable early page tables. Since this stub is executed before kernel entry point

Re: [PATCH] xen/privcmd: use vma_pages().

On 05/21/2016 09:09 AM, Muhammad Falak R Wani wrote: > Replace explicit computation of vma page count by a call to > vma_pages() > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/xen/privcmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v3] xen: add steal_clock support on x86

t; able to run due to hypervisor scheduling. > > Add support in Xen arch independent time handling for this feature by > moving it out of the arm arch into drivers/xen and remove the x86 Xen > hack. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Boris Ostrovs

Re: [PATCH v2] xen: use vma_pages().

On 05/23/2016 08:04 PM, Muhammad Falak R Wani wrote: > Replace explicit computation of vma page count by a call to > vma_pages(). > > Signed-off-by: Muhammad Falak R Wani <falakre...@gmail.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

Re: [Xen-devel][PATCH] xen/events: don't migrate disabled IRQs

On 05/20/2016 05:22 PM, Munehisa Kamata wrote: > Commit ff1e22e7a638 ("xen/events: Mask a moving irq") introduced > a crash below. This can be triggered after being resumed from suspend > (e.g. live migration) if there are disabled IRQs with > IRQD_SETAFFINITY_PENDING set. A patch just like this

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

On 05/16/2016 07:23 AM, Stefano Stabellini wrote: > On Wed, 27 Apr 2016, Boris Ostrovsky wrote: >> On 04/27/2016 09:40 AM, David Vrabel wrote: >>> On 27/04/16 14:38, Boris Ostrovsky wrote: >>>> int xen_nr_legacy_irqs() >>>> { >>>> if

Re: [PATCH] xen: add steal_clock support on x86

On 05/18/2016 08:15 AM, Juergen Gross wrote: > } > > +void __init xen_time_setup_guest(void) > +{ > + pv_time_ops.steal_clock = xen_steal_clock; > + > + static_key_slow_inc(_steal_enabled); > + /* > + * We can't set paravirt_steal_rq_enabled as this would require the > + *

Re: [PATCH] xen: add steal_clock support on x86

On 05/18/2016 11:45 AM, David Vrabel wrote: > On 18/05/16 16:42, Juergen Gross wrote: >> On 18/05/16 17:25, Boris Ostrovsky wrote: >>> On 05/18/2016 10:53 AM, Juergen Gross wrote: >>>> On 18/05/16 16:46, Boris Ostrovsky wrote: >>>>>

Re: [PATCH] xen: add steal_clock support on x86

On 05/18/2016 10:53 AM, Juergen Gross wrote: > On 18/05/16 16:46, Boris Ostrovsky wrote: >> On 05/18/2016 08:15 AM, Juergen Gross wrote: >>> } >>> >>> +void __init xen_time_setup_guest(void) >>> +{ >>> + pv_time_ops.steal_cloc

Re: [PATCH] xen: add steal_clock support on x86

On 05/18/2016 12:00 PM, Juergen Gross wrote: > On 18/05/16 17:53, Boris Ostrovsky wrote: >> On 05/18/2016 11:45 AM, David Vrabel wrote: >>> On 18/05/16 16:42, Juergen Gross wrote: >>>> On 18/05/16 17:25, Boris Ostrovsky wrote: >>>>> On 05/18/2016 10:5

Re: [Xen-devel] [PATCH] xen: add steal_clock support on x86

On 05/18/2016 12:10 PM, Dario Faggioli wrote: > On Wed, 2016-05-18 at 16:53 +0200, Juergen Gross wrote: >> On 18/05/16 16:46, Boris Ostrovsky wrote: >>> >>> Won't we be accounting for stolen cycles twice now --- once from >>> steal_account_process_tick()

Re: [v4.6-rc1 Regression] x86/topology: Create logical package id

On 05/06/2016 02:48 PM, Thomas Gleixner wrote: > On Fri, 6 May 2016, Joseph Salisbury wrote: >> A kernel bug report was opened against Ubuntu [0]. After a kernel >> bisect, it was found that reverting the following commit resolved this bug: >> >> commit 1f12e32f4cd5243ae46d8b933181be0d022c6793 >>

Re: [v4.6-rc1 Regression] x86/topology: Create logical package id

On 05/06/2016 03:38 PM, Joseph Salisbury wrote: > On 05/06/2016 03:13 PM, Boris Ostrovsky wrote: >> On 05/06/2016 02:48 PM, Thomas Gleixner wrote: >>> >>> Yuck. That dies with a divide error. And that looks like XEN is supplying >>> crap >>> data in

Re: [v4.6-rc1 Regression] x86/topology: Create logical package id

On 05/06/2016 04:51 PM, Joseph Salisbury wrote: > Thomas' patch does resolve the bug. The cpuid info can be seen here: > https://launchpadlibrarian.net/258234267/cpuid_full.txt Any chance you could post it raw (cpuid -1 -r)? Thanks. -boris

Re: [PATCH] xen/events: Don't move disabled irqs

> [] ? finish_task_switch+0x76/0x220 > [] ? __raw_callee_save___pv_queued_spin_unlock+0x11/0x20 > [] smpboot_thread_fn+0x105/0x160 > [] ? sort_range+0x30/0x30 > [] kthread+0xd8/0xf0 > [] ? kthread_create_on_node+0x1e0/0x1e0 > [] ret_from_fork+0x3f/0x70 > [] ? kth

Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence before allocating descs for legacy IRQs

On 04/14/2016 09:45 AM, David Vrabel wrote: On 12/04/16 19:06, Stefano Stabellini wrote: On Tue, 12 Apr 2016, Boris Ostrovsky wrote: On 04/11/2016 10:08 PM, Stefano Stabellini wrote: Hi all, Unfortunately this patch (now commit 8c058b0b9c34d8c8d7912880956543769323e2d8) causes a regression

Re: Xen regression, Was: [PATCH] x86/irq: Probe for PIC presence before allocating descs for legacy IRQs

On 04/13/2016 06:38 PM, Stefano Stabellini wrote: On Wed, 13 Apr 2016, Boris Ostrovsky wrote: On 04/13/2016 01:36 PM, Boris Ostrovsky wrote: On 04/12/2016 09:27 PM, Boris Ostrovsky wrote: On 04/12/2016 07:15 PM, Stefano Stabellini wrote: On Tue, 12 Apr 2016, Boris Ostrovsky wrote: On 04

Re: [RFC v1 3/4] x86, boot: Implement ASLR for kernel memory sections (x86_64)

On 04/15/2016 06:03 PM, Thomas Garnier wrote: +void __init kernel_randomize_memory(void) +{ + size_t i; + unsigned long addr = memory_rand_start; + unsigned long padding, rand, mem_tb; + struct rnd_state rnd_st; + unsigned long remain_padding = memory_rand_end -

Re: linux-next: manual merge of the xen-tip tree with the block tree

On 07/25/2016 06:19 PM, Stephen Rothwell wrote: > Hi Stefano, > > On Mon, 25 Jul 2016 10:29:11 -0700 (PDT) Stefano Stabellini > wrote: >> The To and CC list for these emails is a bit outdated. I want to make >> sure they reach the right people. Could you please add: >> >>

Re: [tip:smp/hotplug 5/6] arch/x86/xen/enlighten.c:1522:2: error: implicit declaration of function 'xen_pvh_early_cpu_init'

On 07/28/2016 12:14 PM, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp/hotplug head: c713c8cb2055f5f3b32ee4315be589177a2658cc commit: 854e9fa5a56a9771fad4701a427e4844d2cbade1 [5/6] xen/x86: Define stubs for xen_smp_intr_init/xen_smp_intr_free

Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c

On 08/01/2016 07:40 AM, Juergen Gross wrote: > There are two functions with name xen_pmu_init() in the kernel. Rename > the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in > arch/x86/xen/pmu.c > > Signed-off-by: Juergen Gross While at it, how about changing

Re: [PATCH] xen: Make VPMU init message look less scary

or than a normal state. > > Change the message to something less scary in case the hypervisor > returns EOPNOTSUPP when trying to activate VPMU. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c

On 08/01/2016 11:44 AM, Juergen Gross wrote: > On 01/08/16 16:10, Boris Ostrovsky wrote: >> On 08/01/2016 07:40 AM, Juergen Gross wrote: >>> There are two functions with name xen_pmu_init() in the kernel. Rename >>> the one in drivers/xen/sys-hypervisor.c to avoid shadow

Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary

On 08/01/2016 11:48 AM, Juergen Gross wrote: > On 01/08/16 16:11, Konrad Rzeszutek Wilk wrote: >> On Mon, Aug 01, 2016 at 01:41:20PM +0200, Juergen Gross wrote: >>> The default for the Xen hypervisor is to not enable VPMU in order to >>> avoid security issues. In this case the Linux kernel will

Re: linux-next: manual merge of the xen-tip tree with the tip tree

On 07/26/2016 12:01 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the xen-tip tree got a conflict in: > > arch/x86/xen/enlighten.c > > between commit: > > 4c9075835511 ("xen/x86: Move irq allocation from Xen smp_op.cpu_up()") > > from the tip tree and commit: > >

[PATCH] xen/x86: Define stubs for xen_smp_intr_init/xen_smp_intr_free

xen_smp_intr_init() and xen_smp_intr_free() are now called from enlighten.c and therefore not guaranteed to have CONFIG_SMP. Instead of adding multiple ifdefs there provide stubs in smp.h Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> --- The patch is against tip:smp/hotplug

Re: [PATCH v2] xen: rename xen_pmu_init() in sys-hypervisor.c

Gross <jgr...@suse.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

Re: [tip:smp/hotplug] cpu/hotplug: Prevent alloc/free of irq descriptors during CPU up/down (again)

On 08/10/2016 02:10 PM, tip-bot for Boris Ostrovsky wrote: > Commit-ID: aa877175e7a9982233ed8f10cb4bfddd78d82741 > Gitweb: http://git.kernel.org/tip/aa877175e7a9982233ed8f10cb4bfddd78d82741 > Author: Boris Ostrovsky <boris.ostrov...@oracle.com> > AuthorDate: Wed, 3 Aug 2

Re: [tip:smp/hotplug] cpu/hotplug: Prevent alloc/free of irq descriptors during CPU up/down (again)

On 08/11/2016 09:20 AM, Sebastian Andrzej Siewior wrote: > On 2016-08-11 08:53:31 [-0400], Boris Ostrovsky wrote: >> Since this patch requires >> http://marc.info/?l=xen-devel=147024499722041=2 it may be better to >> take it via Xen tree. > > Why are you adding more re

Re: [tip:smp/hotplug] cpu/hotplug: Prevent alloc/free of irq descriptors during CPU up/down (again)

On 08/11/2016 10:17 AM, Sebastian Andrzej Siewior wrote: > On 2016-08-11 10:11:20 [-0400], Boris Ostrovsky wrote: >> Are you asking why this is not using new hotplug infrastructure? > correct. > >> This should indeed be done but not as part of this series. Here we are

Re: [tip:smp/hotplug] cpu/hotplug: Prevent alloc/free of irq descriptors during CPU up/down (again)

On 08/11/2016 10:44 AM, Sebastian Andrzej Siewior wrote: > On 2016-08-11 10:30:57 [-0400], Boris Ostrovsky wrote: >> So you must have converted Xen code already then? Can you post those >> patches (not all 1285, just Xen-related, assuming there are no >> dependencies) and

[PATCH v2 0/2] Reinstate irq alloc/dealloc locking patch

through tip tree but after a couple of failures reportedby kbuild robot (due to various combinations of CONFIG_SMP and CONFIG_XEN_PVH) I decided to take it through Xen tree (with config problems hopefully finally fixed). Boris Ostrovsky (2): xen/x86: Move irq allocation from Xen smp_op.cpu_up

[PATCH v2 1/2] xen/x86: Move irq allocation from Xen smp_op.cpu_up()

up ops. We can move those allocations into CPU notifiers so that original patch can be reinstated. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> --- v2: Add ifdef CONFIG_SMP to smp.h arch/x86/xen/enlighten.c | 61 +--- arc

[PATCH v2 2/2] hotplug: Prevent alloc/free of irq descriptors during cpu up/down (again)

Now that Xen no longer allocates irqs in _cpu_up() we can restore commit a89941816726 ("hotplug: Prevent alloc/free of irq descriptors during cpu up/down") Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Acked-by: Thomas Gleixner <t...@linutronix.de> CC: x...

Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask

On 07/13/2016 03:56 AM, Wei, Jiangang wrote: > On Thu, 2016-07-07 at 11:37 -0400, Boris Ostrovsky wrote: >> On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote: >>> On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote: >>>> verify_local_APIC() had been remov

Re: [PATCH] xen/pvhvm: Support more than 32 VCPUs when migrating (v3).

On 07/21/2016 10:14 AM, Konrad Rzeszutek Wilk wrote: > On Fri, Jul 10, 2015 at 02:57:51PM -0400, Konrad Rzeszutek Wilk wrote: >> On Fri, Jul 10, 2015 at 02:37:46PM -0400, Konrad Rzeszutek Wilk wrote: >>> When Xen migrates an HVM guest, by default its shared_info can >>> only hold up to 32 CPUs. As

Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask

On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote: >> verify_local_APIC() had been removed by >> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"), >> so apic_id_mask isn't used by it. Is anyone actually using this

[PATCH 1/2] xen/x86: Convert to hotplug state machine

Switch to new CPU hotplug infrastructure. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Suggested-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- arch/x86/xen/enlighten.c | 115 +--- include/linux/cpuhotplug.h |

[PATCH 2/2] xen/events: Convert to hotplug state machine

From: Sebastian Andrzej Siewior <bige...@linutronix.de> Install the callbacks via the state machine. Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> --- Changes from Sebastian's original version: * Ren

[PATCH 0/2] Convert to new CPU hotplug framework

tomorrow so may not be able to respond to comments right away) Boris Ostrovsky (2): xen/x86: Convert to hotplug state machine xen/events: Convert to hotplug state machine arch/x86/xen/enlighten.c | 115 + drivers/xen/events/events_fifo.c | 34

Re: [Xen-devel] [PATCH 2/2] xen/events: Convert to hotplug state machine

On 08/15/2016 11:06 AM, David Vrabel wrote: > On 15/08/16 15:46, Boris Ostrovsky wrote: >> From: Sebastian Andrzej Siewior <bige...@linutronix.de> >> >> Install the callbacks via the state machine. > [...] >> +static int

Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

On 01/31/2017 12:47 PM, Boris Ostrovsky wrote: > On 01/30/2017 02:31 PM, Boris Ostrovsky wrote: >> On 01/30/2017 02:06 PM, Eric Dumazet wrote: >>> On Mon, 2017-01-30 at 13:23 -0500, Boris Ostrovsky wrote: >>> >>>> We do netif_carrier_off() f

Re: [PATCH v2 RESEND] xen/manage: correct return value check on xenbus_scanf()

On 02/03/2017 03:54 AM, Jan Beulich wrote: > A negative return value indicates an error; in fact the function at > present won't ever return zero. > > Signed-off-by: Jan Beulich > Reviewed-by: Juergen Gross Applied to for-linus-4.11. -boris

Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

On 01/30/2017 02:31 PM, Boris Ostrovsky wrote: > On 01/30/2017 02:06 PM, Eric Dumazet wrote: >> On Mon, 2017-01-30 at 13:23 -0500, Boris Ostrovsky wrote: >> >>> We do netif_carrier_off() first thing in xennet_disconnect_backend() and >>> the only

Re: [PATCH v3 0/9] PVH v2 support (domU)

On 02/06/2017 12:00 PM, Boris Ostrovsky wrote: > PVHv2 support for unprivileged guests. > > Changes in v3: > * See patches 4 and 5 > Applied to for-linus-4.11 -boris

Re: [PATCH v3 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

On 01/24/2017 11:23 AM, Juergen Gross wrote: > On 24/01/17 14:47, Boris Ostrovsky wrote: >> On 01/23/2017 01:59 PM, Boris Ostrovsky wrote: >>> On 01/23/2017 05:09 AM, Juergen Gross wrote: >>>> Handling of multiple concurrent Xenstore accesses through xenbus driv

Re: [PATCH] xenbus: Neaten xenbus_va_dev_error

On 02/08/2017 06:33 AM, Joe Perches wrote: > This function error patch can be simplified, so do so. > > Remove fail: label and somewhat obfuscating, used once "error_path" > function. > > Signed-off-by: Joe Perches Applied to for-linus-4.11. -boris

Re: [PATCH] xen-netfront: Rework the fix for Rx stall during OOM and network stress

etfront: Fix Rx stall during network stress and OOM) > Reported-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

Re: [PATCH] xenbus: Neaten xenbus_va_dev_error

On 02/08/2017 11:05 AM, Joe Perches wrote: > On Wed, 2017-02-08 at 10:33 -0500, Boris Ostrovsky wrote: >> On 02/08/2017 06:33 AM, Joe Perches wrote: >>> This function error patch can be simplified, so do so. >>> >>> Remove fail: label and somewhat obfuscating,

Re: [PATCH v2] xen-netfront: Improve error handling during initialization

On 02/07/2017 09:55 AM, Ross Lagerwall wrote: > This fixes a crash when running out of grant refs when creating many > queues across many netdevs. > > * If creating queues fails (i.e. there are no grant refs available), > call xenbus_dev_fatal() to ensure that the xenbus device is set to the >

Re: [PATCH v3 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

On 02/07/2017 12:51 PM, Boris Ostrovsky wrote: > On 01/24/2017 11:23 AM, Juergen Gross wrote: >> On 24/01/17 14:47, Boris Ostrovsky wrote: >>> On 01/23/2017 01:59 PM, Boris Ostrovsky wrote: >>>> On 01/23/2017 05:09 AM, Juergen Gross wrote: >>>>> Hand

Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

On 02/02/2017 10:35 AM, Roger Pau Monné wrote: > On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: >> Make sure they don't use these devices since they are not emulated >> for unprivileged PVH guest. > This description seems weird for what it's actuall

Re: [PATCH] xen-netfront: Improve error handling during initialization

On 02/02/2017 09:54 AM, Ross Lagerwall wrote: > On 02/01/2017 06:54 PM, Boris Ostrovsky wrote: >> On 02/01/2017 10:50 AM, Ross Lagerwall wrote: >>> Improve error handling during initialization. This fixes a crash when >>> running out of grant refs when creating many que

[PATCH v3 4/9] xen/pvh: Bootstrap PVH guest

into .data. While adjusting xen_hvm_init_shared_info() make it use cpuid_e?x() instead of cpuid() (wherever possible). Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> --- Changes in v3: * Fix gdt definition (correct base address and use GDT_ENTRY()). * Increase stack size to 256

[PATCH v3 0/9] PVH v2 support (domU)

PVHv2 support for unprivileged guests. Changes in v3: * See patches 4 and 5 Boris Ostrovsky (9): x86/boot/32: Convert the 32-bit pgtable setup code from assembly to C xen/x86: Remove PVH support xen/pvh: Import PVH-related Xen public interfaces xen/pvh: Bootstrap PVH guest xen/pvh

[PATCH v3 2/9] xen/x86: Remove PVH support

by 'if (xen_pvh_domain())'. (We will also need a noop xen_pvh_domain() for !CONFIG_XEN_PVH). Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- arch/x86/xen/enlight

[PATCH v3 7/9] xen/pvh: PVH guests always have PV devices

Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- arch/x86/xen/platform-pci-unplug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arc

[PATCH v3 3/9] xen/pvh: Import PVH-related Xen public interfaces

Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- include/xen/interface/elfnote.h| 12 ++- include/xen/interface/hvm/

[PATCH v3 6/9] xen/pvh: Initialize grant table for PVH guests

Like PV guests, PVH does not have PCI devices and therefore cannot use MMIO space to store grants. Instead it balloons out memory and keeps grants there. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Juergen Gross <jgr...@suse.com> --- drivers/xen/grant

[PATCH v3 9/9] xen/pvh: Use Xen's emergency_restart op for PVH guests

Using native_machine_emergency_restart (called during reboot) will lead PVH guests to machine_real_restart() where we try to use real_mode_header which is not initialized. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Juergen Gross <jgr...@suse.com> ---

[PATCH v3 1/9] x86/boot/32: Convert the 32-bit pgtable setup code from assembly to C

code to C. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Andy Lutomirski <l...@kernel.org> Cc: Borislav Petkov <b...@alien8.de> Cc: Brian Gerst <brge...@gmail.com> Cc: Denys Vlasenko <dvlas...@redhat.com> Cc: H. Peter Anvin <h...@zytor.com> Cc: Jos

[PATCH v3 8/9] xen/pvh: Enable CPU hotplug

PVH guests don't (yet) receive ACPI hotplug interrupts and therefore need to monitor xenstore for CPU hotplug event. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Juergen Gross <jgr...@suse.com> --- drivers/xen/cpu_hotplug.c | 2 +- 1 file changed, 1 ins

[PATCH v3 5/9] xen/pvh: Make sure we don't use ACPI_IRQ_MODEL_PIC for SCI

. Instead we set the model to ACPI_IRQ_MODEL_PLATFORM which will prevent this from happening. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> --- Changes in v3: * Moved update of acpi_irq_model to x86_init.oem.arch_setup() (i.e. after ACPI has been initialized so we know whether or

Re: [Xen-devel] [PATCH v3 4/9] xen/pvh: Bootstrap PVH guest

lp improve the system] > > url: > https://github.com/0day-ci/linux/commits/Boris-Ostrovsky/x86-boot-32-Convert-the-32-bit-pgtable-setup-code-from-assembly-to-C/20170207-014642 > base: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next > config: x86_64-randconf

Re: [PATCH v3] xen-netfront: Improve error handling during initialization

;queues); > + info->queues = NULL; > + goto out; > + } I think it might be better to kfree() in xennet_create_queues() (and set num_queues to zero, while at it). But either way: Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> > >

Re: [PATCH v2 4/9] xen/pvh: Bootstrap PVH guest

>> + >> +__HEAD >> + >> +/* Entry point for PVH guests. */ > Could you add some comments about register conetnts at entry? Reference to Xen's docs/misc/hvmlite.markdown would be sifficient? >> +gdt: >> +.word gdt_end - gdt >> +.long _pa(gdt) > This is a rather strange

Re: [PATCH] xen-netfront: Improve error handling during initialization

On 02/01/2017 10:50 AM, Ross Lagerwall wrote: > Improve error handling during initialization. This fixes a crash when > running out of grant refs when creating many queues across many netdevs. > > * Delay timer creation so that if initializing a queue fails, the timer > has not been setup yet. > *

Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

On 02/02/2017 11:40 AM, Roger Pau Monné wrote: > On Thu, Feb 02, 2017 at 11:30:19AM -0500, Boris Ostrovsky wrote: >> On 02/02/2017 10:35 AM, Roger Pau Monné wrote: >>> On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: >>>> Make sure they

Re: [PATCH v3 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

waste of kernel resources. > > - An out of memory situation while writing to or reading from the > xenstore ring buffer no longer will lead to a possible loss of > synchronization with xenstore. > > - The user read and write part are now interruptible by signals. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

Re: [PATCH v3 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

On 01/24/2017 11:23 AM, Juergen Gross wrote: > On 24/01/17 14:47, Boris Ostrovsky wrote: >> On 01/23/2017 01:59 PM, Boris Ostrovsky wrote: >>> On 01/23/2017 05:09 AM, Juergen Gross wrote: >>>> Handling of multiple concurrent Xenstore accesses through xenbus driv

[PATCH v2 8/9] xen/pvh: Enable CPU hotplug

PVH guests don't (yet) receive ACPI hotplug interrupts and therefore need to monitor xenstore for CPU hotplug event. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> --- drivers/xen/cpu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH v2 9/9] xen/pvh: Use Xen's emergency_restart op for PVH guests

Using native_machine_emergency_restart (called during reboot) will lead PVH guests to machine_real_restart() where we try to use real_mode_header which is not initialized. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> --- New in v2 arch/x86/xen/enlighten.c | 3 +++ 1 file c

[PATCH v2 7/9] xen/pvh: PVH guests always have PV devices

Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- arch/x86/xen/platform-pci-unplug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arc

Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 01/30/2017 11:47 AM, Vineeth Remanan Pillai wrote: > >> 2. It tickles a latent bug during resume where the timer triggers >> before we re-connect. The trouble is that we now try to dereference >> queue->rx.sring which is NULL since we disconnect in >> netfront_resume(). (Curiously, I only

[PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

rx_refill_timer should be deleted as soon as we disconnect from the backend since otherwise it is possible for the timer to go off before we get to xennet_destroy_queues(). If this happens we may dereference queue->rx.sring which is set to NULL in xennet_disconnect_backend(). Signed-off-by: Bo

Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

On 01/30/2017 01:07 PM, Eric Dumazet wrote: > On Mon, 2017-01-30 at 12:45 -0500, Boris Ostrovsky wrote: >> rx_refill_timer should be deleted as soon as we disconnect from the >> backend since otherwise it is possible for the timer to go off before >> we get to

Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

On 01/30/2017 02:06 PM, Eric Dumazet wrote: > On Mon, 2017-01-30 at 13:23 -0500, Boris Ostrovsky wrote: > >> We do netif_carrier_off() first thing in xennet_disconnect_backend() and >> the only place where the timer is rearmed is xennet_alloc_rx_buffers(), >> which is gua

Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 01/19/2017 11:35 AM, Vineeth Remanan Pillai wrote: From: Vineeth Remanan Pillai During an OOM scenario, request slots could not be created as skb allocation fails. So the netback cannot pass in packets and netfront wrongly assumes that there is no more work to be done

Re: [PATCH 0/2] xen/net: limit number of tx/rx queues

On 01/10/2017 08:32 AM, Juergen Gross wrote: The Xen network frontend/backend supports multiple tx/rx queues for one virtual interface. The number of queues supported by the backend is set to the number of cpus of the backend driver domain (usually dom0) and the number of queues requested by

Re: [PATCH] x86/xen: Fix APIC id mismatch warning on Intel

On 01/26/2017 01:12 PM, Mohit Gambhir wrote: This patch fixes the following warning message seen when booting the kernel as Dom0 with Xen on Intel machines. [0.003000] [Firmware Bug]: CPU1: APIC id mismatch. Firmware: 0 APIC: 1] The code generating the warning in

Re: [PATCH] tpm: Restore functionality to xen vtpm driver.

the > regression point was located. > > Cc: <sta...@vger.kernel.org> # 4.1- 4.1+, I believe. > Suggested-by: Daniel De Graaf <dgde...@tycho.nsa.gov> > Signed-off-by: Dr. Greg Wettstein <g...@enjellic.com> Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> &g

[PATCH v2 1/9] x86/boot/32: Convert the 32-bit pgtable setup code from assembly to C

code to C. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Andy Lutomirski <l...@kernel.org> Cc: Borislav Petkov <b...@alien8.de> Cc: Brian Gerst <brge...@gmail.com> Cc: Denys Vlasenko <dvlas...@redhat.com> Cc: H. Peter Anvin <h...@zytor.com> Cc: Jos

[PATCH v2 2/9] xen/x86: Remove PVH support

by 'if (xen_pvh_domain())'. (We will also need a noop xen_pvh_domain() for !CONFIG_XEN_PVH). Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- Changes in v2: * Added

[PATCH v2 0/9] PVH v2 support (domU)

PVH v2 support for unprivileged guests. Now that we decided to defer ACPI CPU hotplug until we understand better what to do about it in dom0 I am sending v2 with PV-style CPU hotplug, with v1 comments addressed. Boris Ostrovsky (9): x86/boot/32: Convert the 32-bit pgtable setup code from

[PATCH v2 6/9] xen/pvh: Initialize grant table for PVH guests

Like PV guests, PVH does not have PCI devices and therefore cannot use MMIO space to store grants. Instead it balloons out memory and keeps grants there. Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> --- Changes in v2: * Updated commit message drivers/xen/grant-table

[PATCH v2 3/9] xen/pvh: Import PVH-related Xen public interfaces

Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- include/xen/interface/elfnote.h| 12 ++- include/xen/interface/hvm/

<    2   3   4   5   6   7   8   9   10   11   >