Re: [PATCH block/for-linus] block: export bio_associate_*() and wbc_account_io()

2015-07-23 Thread Chris Mason
On Thu, Jul 23, 2015 at 02:27:09PM -0400, Tejun Heo wrote: > bio_associate_blkcg(), bio_associate_current() and wbc_account_io() > are used to implement cgroup writeback support for filesystems and > thus need to be exported. Export them. Thanks, these were the only three I needed on the btrfs

Re: [Ksummit-discuss] [CORE TOPIC] lightweight per-cpu locks / restartable sequences

2015-07-09 Thread Chris Mason
On Thu, Jul 09, 2015 at 11:32:45AM -0700, Andy Lutomirski wrote: > Several people have suggested that Linux should provide users with a > lightweight mechanism that allows light-weight fancy per-cpu > operations. This could be used to implement free lists or counters > without any barriers or

[GIT PULL] Btrfs

2015-07-17 Thread Chris Mason
Hi Linus, We have some fixes in my for-linus-4.2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.2 These are all from Filipe, and cover a few problems we've had reported on the list recently (along with ones he found on his own). Filipe Manana (5)

Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-20 Thread Chris Mason
On 04/20/2015 01:27 AM, NeilBrown wrote: > This allows fscache to cachefiles in a btrfs filesystem. Thanks for working on this Neil. Signed-off-by: Chris Mason -chris > > Signed-off-by: NeilBrown > --- > fs/btrfs/super.c |3 ++- > 1 file changed, 2 inserti

[GIT PULL] Btrfs for 4.1

2015-04-23 Thread Chris Mason
(+3/-6) btrfs: Fix NO_SPACE bug caused by delayed-iput (+13/-1) btrfs: Support busy loop of write and delete (+14/-12) btrfs: fix condition of commit transaction (+15/-7) Chris Mason (9) commits (+656/-128): Btrfs: allow block group cache writeout outside critical section in commit (+3

[GIT PULL] Btrfs fixes

2015-05-15 Thread Chris Mason
Hi Linus, I have a few more fixes in my for-linus-4.1 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 The first commit is a fix from Filipe for a very old extent buffer reuse race that triggered a BUG_ON. It hasn't come up often, I looked through old

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-19 Thread Chris Mason
On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: > Hi all > > I am seeing the following crash on my btrfs filesystem with nfs export. > If I disable the nfs share and reboot, I do not hit the crash. Look like > the crash happens on btrfs with nfs export. > > Is this a known issue? Has

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-19 Thread Chris Mason
On 05/19/2015 09:54 AM, Piotr Szymaniak wrote: > On Tue, May 19, 2015 at 09:43:10AM -0400, Chris Mason wrote: >> On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: >>> 2286--->BUG_ON(!PageLocked(page)); >>> >>> [ 166.769868] BTRFS info (device sdf):

[GIT PULL] Btrfs for 4.3

2015-09-04 Thread Chris Mason
) btrfs: use __GFP_NOFAIL in alloc_btrfs_bio (+1/-3) Liu Bo (2) commits (+7/-7): Btrfs: fix defrag to merge tail file extent (+5/-1) Btrfs: fix warning in backref walking (+2/-6) Chris Mason (2) commits (+33/-4): btrfs: fix compile when block cgroups are not enabled (+5/-0)

Re: [RFC -v2 7/8] btrfs: Prevent from early transaction abort

2015-08-18 Thread Chris Mason
On Tue, Aug 18, 2015 at 12:40:32PM +0200, Michal Hocko wrote: > From: Michal Hocko > > Btrfs relies on GFP_NOFS allocation when commiting the transaction but > since "mm: page_alloc: do not lock up GFP_NOFS allocations upon OOM" > those allocations are allowed to fail which can lead to a

[GIT PULL] Btrfs

2015-09-11 Thread Chris Mason
Hi Linus, We have a few more for the btrfs tree in my for-linus-4.3 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.3 These are small cleanups, and also some fixes for our async worker thread initialization. I was having some trouble testing these, but

[PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-11 Thread Chris Mason
259] [] btrfs_raid_unplug+0x23/0x70 [btrfs] [ 2854.307334] [] blk_flush_plug_list+0x82/0x1f0 [ 2854.319542] [] blk_finish_plug+0x34/0x50 [ 2854.330878] [] writeback_sb_inodes+0x122/0x580 [ 2854.343256] [] wb_writeback+0x136/0x4e0 Signed-off-by: Chris Mason Reviewed-by: Jens Axboe --- fs/fs-writeback.c

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-11 Thread Chris Mason
On Fri, Sep 11, 2015 at 02:04:13PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 1:40 PM, Josef Bacik wrote: > > > > So we talked about this when we were trying to figure out a solution. The > > problem with this approach is now we have a plug that covers multiple super > > blocks

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-11 Thread Chris Mason
On Fri, Sep 11, 2015 at 03:06:18PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 2:04 PM, Linus Torvalds > wrote: > > > > Of course, actual numbers would be the deciding factor if this really > > is noticeable. But "cleaner code and saner locking" is definitely an > > issue at least for

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-11 Thread Chris Mason
On Fri, Sep 11, 2015 at 05:52:27PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 4:36 PM, Linus Torvalds > wrote: > > > > Are we really ok with waiting synchronously for an inode while holding > > the plug? No chance of deadlock (waiting for IO that we've plugged)? > > That issue is true

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-12 Thread Chris Mason
On Fri, Sep 11, 2015 at 04:36:39PM -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 4:16 PM, Chris Mason wrote: > > > > For 4.3 timeframes, what runs do you want to see numbers for: > > > > 1) revert > > 2) my hack > > 3) plug over multiple sbs (on

[GIT PULL] Btrfs

2015-08-08 Thread Chris Mason
Hi Linus, We have a btrfs quota regression fix in my for-linus-4.2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.2 I merged this one on Thursday and have run it through tests against current master. Normally I wouldn't have sent this while you were

Re: [PATCH 2/2] ubifs: Allow O_DIRECT

2015-08-24 Thread Chris Mason
On Tue, Aug 25, 2015 at 09:46:11AM +1000, Dave Chinner wrote: > On Mon, Aug 24, 2015 at 01:19:24PM -0400, Jeff Moyer wrote: > > Brian Norris writes: > > > > > On Mon, Aug 24, 2015 at 10:13:25AM +0300, Artem Bityutskiy wrote: > > >> Now, some user-space fails when direct I/O is not supported. > >

Re: [PATCH 2/2] ubifs: Allow O_DIRECT

2015-08-25 Thread Chris Mason
On Tue, Aug 25, 2015 at 10:00:58AM -0400, Jeff Moyer wrote: > Dave Chinner writes: > > > On Mon, Aug 24, 2015 at 01:19:24PM -0400, Jeff Moyer wrote: > >> Brian Norris writes: > >> > >> > On Mon, Aug 24, 2015 at 10:13:25AM +0300, Artem Bityutskiy wrote: > >> >> Now, some user-space fails when

Re: [PATCH 0/2] btrfs: fortification for GFP_NOFS allocations

2015-08-19 Thread Chris Mason
On Wed, Aug 19, 2015 at 02:17:39PM +0200, mho...@kernel.org wrote: > Hi, > these two patches were sent as a part of a larger RFC which aims at > allowing GFP_NOFS allocations to fail to help sort out memory reclaim > issues bound to the current behavior >

linux-next conflict resolution branch for btrfs

2015-08-20 Thread Chris Mason
Hi Stephen, There are a few conflicts for btrfs in linux-next this time. They are small, but I pushed out the merge commit I'm using here: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git next-merge -chris -- To unsubscribe from this list: send the line "unsubscribe

Re: linux-next conflict resolution branch for btrfs

2015-08-21 Thread Chris Mason
On Fri, Aug 21, 2015 at 10:45:24AM +1000, Stephen Rothwell wrote: > Hi Chris, > > On Thu, 20 Aug 2015 13:39:18 -0400 Chris Mason wrote: > > > > There are a few conflicts for btrfs in linux-next this time. They are > > small, but I pushed out the merge commit I

Re: linux-next conflict resolution branch for btrfs

2015-08-21 Thread Chris Mason
On Fri, Aug 21, 2015 at 10:45:24AM +1000, Stephen Rothwell wrote: > Hi Chris, > > On Thu, 20 Aug 2015 13:39:18 -0400 Chris Mason wrote: > > > > There are a few conflicts for btrfs in linux-next this time. They are > > small, but I pushed out the merge commit I

[GIT PULL] Btrfs

2015-07-10 Thread Chris Mason
Hi Linus, Please pull my for-linus-4.2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.2 This is an assortment of fixes. Most of the commits are from Filipe (fsync, the inode allocation cache and a few others). Mark kicked in a series fixing corners in

Re: [PATCH] Btrfs: avoid build warning on 32-bit

2015-01-13 Thread Chris Mason
On Tue, Jan 13, 2015 at 7:16 PM, David Sterba wrote: On Tue, Jan 13, 2015 at 03:09:03PM +0100, Arnd Bergmann wrote: A recent change introduced a type cast from a private 64-bit value to a pointer, which works fine on 64-bit architectures, but not on 32-bit ones, where it produces a harmless

Re: linux-next: build warning after merge of the akpm-current tree

2015-01-19 Thread Chris Mason
On Mon, Jan 19, 2015 at 2:45 AM, Stephen Rothwell wrote: Hi Andrew, After merging the akpm-current tree, today's linux-next build (x86_64 allmodconfig) produced this warning: fs/eventfd.c: In function 'eventfd_poll': fs/eventfd.c:121:16: warning: unused variable 'flags'

Re: Linux 3.19-rc3

2015-01-16 Thread Chris Mason
: On Tue, Jan 06, 2015 at 10:57:19AM +0100, Sedat Dilek wrote: [ 88.028739] [] aio_read_events+0x4f/0x2d0 Ah, that one. Chris Mason and Kent Overstreet were looking at that one. I'm not touching the AIO code either ;-) I know, I was so excited when I see nearly the same output. Can you

[GIT PULL] Btrfs fixes

2015-01-23 Thread Chris Mason
Hi Linus, We have a few fixes in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Qu Wenruo's batch fix a regression between some our merge window pull and the inode_cache feature. The rest are smaller bugs. Qu Wenruo (2) commits (+11/-1):

Re: __might_sleep() warnings on v3.19-rc6

2015-02-05 Thread Chris Mason
On Sat, Jan 31, 2015 at 07:43:15PM -0800, Fengguang Wu wrote: > Hi all, > > I see 2 __might_sleep() warnings on when running LKP tests on > v3.19-rc6, one related to raid5 and another related to btrfs. > > They might be exposed by this patch. > FSUse%Count SizeFiles/sec

[GIT PULL] Btrfs for 3.19-rc

2014-12-12 Thread Chris Mason
ure for btrfsic_state structure (+11/-5) Btrfs: fix incorrect compression ratio detection (+8/-8) Chris Mason (1) commits (+1/-0): Btrfs: include vmalloc.h in check-integrity.c Gui Hecheng (1) commits (+60/-30): btrfs: fix dead lock while running replace and defrag concurrently Eryu Guan (1) comm

Re: [GIT PULL] Btrfs for 3.19-rc

2014-12-12 Thread Chris Mason
On Fri, Dec 12, 2014 at 2:24 PM, Linus Torvalds wrote: On Fri, Dec 12, 2014 at 11:07 AM, Chris Mason wrote: From a feature point of view, most of the code here comes from Miao Xie and others at Fujitsu to implement scrubbing and replacing devices on raid56. This has been

Re: Bug Fixed?

2014-12-12 Thread Chris Mason
On Fri, Dec 12, 2014 at 12:59 PM, nick wrote: Greetings Chris and Josef, I am wondering if the bug at this URL,

Re: [PATCH 3/3] X86: Add a thread cpu time implementation to vDSO

2014-12-15 Thread Chris Mason
On Thu, Dec 11, 2014 at 1:36 AM, Ingo Molnar wrote: * Andy Lutomirski wrote: On Wed, Dec 10, 2014 at 2:56 PM, Shaohua Li wrote: > On Wed, Dec 10, 2014 at 02:13:23PM -0800, Andy Lutomirski wrote: >> On Wed, Dec 10, 2014 at 1:57 PM, Shaohua Li wrote: >> > On Wed, Dec 10, 2014 at

Re: [GIT PULL] Btrfs corruption fix

2014-10-17 Thread Chris Mason
On 10/16/2014 03:51 AM, Chris Mason wrote: > Hi Linus, > > I'm testing a pull with more fixes, but wanted to get this one out so > Greg can pick it up. The corruption isn't easy to hit, you have to do a > readonly snapshot and have orphans in the snapshot. But my review and &

Re: [PATCH v5] Move BTRFS RCU string to common library

2014-11-07 Thread Chris Mason
On Fri, Nov 7, 2014 at 3:17 PM, Omar Sandoval wrote: The RCU-friendly string API used internally by BTRFS is generic enough for common use. This doesn't add any new functionality, but instead just moves the code and documents the existing API. Reviewed-by: Josh Triplett Acked-by: Paul E.

[GIT PULL] Btrfs

2014-11-08 Thread Chris Mason
Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus It's a one liner for an error cleanup path that leads to crashes. Chris Mason (1) commits (+1/-1): Btrfs: fix kfree on list_head in btrfs_lookup_csums_range error

New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
Hi everyone, I was running some tests on Saturday before my pull, and I'm now hitting this consistently across two boxes. One box has plain linus git: commit cb95413971d605b0d152d3ceecc47ba8991d66fb Merge: ecde006 6bab4a8 Author: Linus Torvalds Date: Sat Nov 22 14:33:11 2014 -0800 The other

[GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Chris Mason
reacquires locks in the btree. Chris Mason (1) commits (+25/-15): btrfs: fix lockups from btrfs_clear_path_blocking Total: (1) commits (+25/-15) fs/btrfs/ctree.c | 14 ++ fs/btrfs/locking.c | 24 +--- fs/btrfs/locking.h | 2 ++ 3 files changed, 25 insertions

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason wrote: Since it looks like a race between process exit and /proc, I'll try to hammer on that for a better reproduction. But, here's hoping that someone has already seen this one: It falls over in less than 5 minutes with a fork bomb going. I'll

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:11 AM, Borislav Petkov wrote: On Sun, Nov 23, 2014 at 10:56:27AM -0500, Chris Mason wrote: On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason wrote: >Since it looks like a race between process exit and /proc, I'll try to >hammer on that for a better reprod

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: It must be: commit 6e998916dfe327e785e7c2447959b2c1a3ea4930 Author: Stanislaw Gruszka Date: Wed Nov 12 16:58:44 2014 +0100 sched/cputime: Fix clock_nanosleep

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: It must be: commit 6e998916dfe327e785e7c2447959b2c1a3ea4930 Author: Stanislaw Gruszka Date: Wed Nov 12 16:58:44 2014 +0100 sched/cputime: Fix clock_nanosleep

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 4:05 PM, Thomas Gleixner wrote: On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: > On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: > > It must be: > &g

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 4:11 PM, Chris Mason wrote: On Sun, Nov 23, 2014 at 4:05 PM, Thomas Gleixner wrote: On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: > On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: > >

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 4:38 PM, Thomas Gleixner wrote: On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 4:05 PM, Thomas Gleixner wrote: > On Sun, 23 Nov 2014, Chris Mason wrote: > > On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: > > > On

Re: [GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 7:23 PM, Benjamin Herrenschmidt wrote: On Sun, 2014-11-23 at 10:14 -0500, Chris Mason wrote: Hi Linus, My for-linus branch: Not sure if this is related, but with -rc4, on this ppc64el box, when grub updates (it starts trying to mount everything under the sun

Re: [GIT PULL] Btrfs deadlock fix

2014-11-24 Thread Chris Mason
On Mon, Nov 24, 2014 at 12:39 PM, David Sterba wrote: Hi Chris, I thought the fix for the scrub/replace deadlock would be included in this pull, I can reproduce it on each run of xfstests with 3.18-rc. btrfs: fix dead lock while running replace and defrag concurrently

Re: btrfs: kernel BUG at fs/btrfs/extent_io.c:676!

2014-10-14 Thread Chris Mason
On Sun, Oct 12, 2014 at 10:15 PM, Sasha Levin wrote: Ping? This BUG_ON()ing due to GFP_ATOMIC allocation failure is really silly :( Agreed, I have a patch for this in testing. It didn't make my first pull but I'll get it fixed up. -chris -- To unsubscribe from this list: send the line

[GIT PULL] Btrfs corruption fix

2014-10-16 Thread Chris Mason
it. Please pull: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Chris Mason (1) commits (+33/-36): Revert "Btrfs: race free update of commit root for ro snapshots" Total: (1) commits (+33/-36) fs/btrfs/inode.c | 36

[GIT PULL] Btrfs fixes

2014-11-01 Thread Chris Mason
Hi Linus, We have a few fixes in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Filipe is nailing down some problems with our skinny extent variation, and Dave's patch fixes endian problems in the new super block checks. Filipe Manana (2)

Re: [4.1-rc7] btrfs related VM_BUG_ON in filemap.c

2015-06-16 Thread Chris Mason
On 06/16/2015 01:14 PM, David Sterba wrote: > On Wed, Jun 10, 2015 at 01:43:31PM -0400, Chris Mason wrote: >> On 06/10/2015 09:40 AM, Dave Jones wrote: >>> Found this on serial console this morning. The machine had rebooted itself >>> shortly >>> afterwards (

[GIT PULL] Btrfs

2015-06-29 Thread Chris Mason
Hi Linus, Please pull my for-linus-4.2 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.2 Outside of our usual batch of fixes, this integrates the subvolume quota updates that Qu Wenruo from Fujitsu has been working on for a few releases now. He gets an

Re: [4.1-rc7] btrfs related VM_BUG_ON in filemap.c

2015-06-10 Thread Chris Mason
On 06/10/2015 09:40 AM, Dave Jones wrote: > Found this on serial console this morning. The machine had rebooted itself > shortly > afterwards (surprising, given I don't have panic-on-oops or similar set). > We had one other report of this a few months ago. Josef and I read through all of this

Re: [PATCH RFC 3/3] btrfs: add .copy_file_range file operation

2015-04-14 Thread Chris Mason
on. It retains > the core btrfs error checks that should be shared. > Thanks Zach, the btrfs bits look reasonable Signed-off-by: Chris Mason -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.o

[GIT PULL] Btrfs fixes

2015-04-26 Thread Chris Mason
Hi Linus, Filipe hit two problems in my block group cache patches. We finalized the fixes last week and ran through more tests. Can you please pull: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 Chris Mason (2) commits (+25/-17): Btrfs: prevent list

[GIT PULL] Btrfs fix

2015-05-08 Thread Chris Mason
Hi Linus, When an arm user reported crashes near page_address(page) in my new code, it became clear that I can't be trusted with GFP masks. Filipe beat me to the patch, and I'll just be in the corner with my dunce cap on. git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git

[GIT PULL] Btrfs fixes

2015-05-01 Thread Chris Mason
writeout and bg deletion (+27/-17) Btrfs: fix deadlock when starting writeback of bg caches (+1/-1) Yang Dongsheng (1) commits (+14/-9): Btrfs: fill ->last_trans for delayed inode in btrfs_fill_inode. Chris Mason (1) commits (+1/-2): Btrfs: don't check for delalloc_by

[GIT PULL] Btrfs

2014-10-10 Thread Chris Mason
OGI (1) commits (+2/-2): Btrfs: use BUG_ON Sage Weil (1) commits (+9/-3): Btrfs: fix race in WAIT_SYNC ioctl Filipe David Borba Manana (1) commits (+3/-2): Btrfs: set default max_inline to 8KiB instead of 8MiB Li RongQing (1) commits (+0/-4): btrfs: remove the wrong comments Chris Ma

Re: [RFC PATCH 05/17] btrfs: remove bio splitting and merge_bvec_fn() calls

2014-12-23 Thread Chris Mason
dle arbitrarily sized bios. So clean up unnecessary code paths. Signed-off-by: Kent Overstreet [dpark: add more description in commit message] Signed-off-by: Dongsu Park Cc: Chris Mason Cc: Josef Bacik Cc: linux-bt...@vger.kernel.org --- Looks good, I'll test it here too. Thanks! Signed-off-by: Ch

[GIT PULL] Btrfs fix

2015-02-06 Thread Chris Mason
Hi Linus, Forrest Liu tracked down a missing blk_finish_plug in the btrfs logging code. This isn't a new bug, and it's hard to hit. But, it's safe enough for inclusion now, and in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus I missed the

Re: frequent lockups in 3.18rc4

2014-12-05 Thread Chris Mason
On Fri, Dec 5, 2014 at 1:38 PM, Linus Torvalds wrote: On Fri, Dec 5, 2014 at 9:15 AM, Dave Jones wrote: A bisect later, and I landed on a kernel that ran for a day, before spewing NMI messages, recovering, and then..

[GIT PULL] Btrfs fix

2015-01-30 Thread Chris Mason
Hi Linus, We have one more fix for btrfs in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus This was a bug in the new raid5/6 scrubbing support. Gui Hecheng (1) commits (+2/-0): btrfs: fix raid56 scrub failed in xfstests btrfs/072 Total:

[GIT PULL] Btrfs

2015-02-25 Thread Chris Mason
Hi Linus, I'm still testing more fixes, but I wanted to get out the fix for the btrfs raid5/6 memory corruption I mentioned in my merge window pull. Please pull my for-linus: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Chris Mason (1) commits (+8/-1

Re: [PATCH] Btrfs:__add_inode_ref: out of bounds memory read when looking for extended ref.

2015-03-03 Thread Chris Mason
On Tue, Mar 3, 2015 at 9:38 AM, David Sterba wrote: Adding linux-btrfs to CC On Thu, Feb 26, 2015 at 05:00:37PM +0100, Quentin Casasnovas wrote: Improper arithmetics when calculting the address of the extended ref could lead to an out of bounds memory read and kernel panic.

Re: [PATCH] Btrfs:__add_inode_ref: out of bounds memory read when looking for extended ref.

2015-03-03 Thread Chris Mason
On Tue, Mar 3, 2015 at 10:31 AM, Quentin Casasnovas wrote: Improper arithmetics when calculting the address of the extended ref could lead to an out of bounds memory read and kernel panic. Signed-off-by: Quentin Casasnovas --- fs/btrfs/tree-log.c | 2 +- 1 file changed, 1 insertion(+), 1

[GIT PULL] Btrfs

2015-03-06 Thread Chris Mason
Hi Linus, My for-linus branch has some btrfs fixes: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus I did rebase a patch out of the queue last night after tracking down some problems Dave Sterba was seeing during xfstests (the top three are obviously rebased). It

[GIT PULL] Btrfs

2015-02-19 Thread Chris Mason
Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus This was held up a little trying to track down a use-after-free in btrfs raid5/6. It's not clear yet if this is just made easier to trigger with this pull or if its a new

[GIT PULL] Btrfs

2016-09-23 Thread Chris Mason
Hi Linus, We have two fixes in my for-linus-4.8 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.8 Josef is fixing a problem when quotas are enabled with his latest ENOSPC rework, and Jeff is adding more checks into the subvol ioctls to avoid tripping up

Re: bio linked list corruption.

2016-10-23 Thread Chris Mason
On 10/22/2016 11:20 AM, Dave Jones wrote: On Fri, Oct 21, 2016 at 04:02:45PM -0400, Dave Jones wrote: > > It could be worth trying this, too: > > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=x86/vmap_stack=174531fef4e8 > > > > It occurred to me that the

Re: bio linked list corruption.

2016-10-24 Thread Chris Mason
On 10/24/2016 12:40 AM, Dave Jones wrote: On Sun, Oct 23, 2016 at 05:32:21PM -0400, Chris Mason wrote: > > > On 10/22/2016 11:20 AM, Dave Jones wrote: > > On Fri, Oct 21, 2016 at 04:02:45PM -0400, Dave Jones wrote: > > > > > > I

Reminder: Linux Foundation Technical Advisory Board Elections and Nomination process

2016-10-24 Thread Chris Mason
and mailing lists, so get your nomination in early). Chris Mason, TAB Chair [1] TAB members sit for a term of two years, and half of the board is up for election every year. Five of the seats are up for election now. The other five are halfway through their term and will be up for election next year.

Re: bio linked list corruption.

2016-10-24 Thread Chris Mason
On 10/24/2016 05:50 PM, Linus Torvalds wrote: On Mon, Oct 24, 2016 at 2:17 PM, Linus Torvalds wrote: The vmalloc/vfree code itself is a bit scary. In particular, we have a rather insane model of TLB flushing. We leave the virtual area on a lazy purge-list, and we delay flushing the TLB and

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On 10/26/2016 03:06 PM, Linus Torvalds wrote: > On Wed, Oct 26, 2016 at 11:42 AM, Dave Jones wrote: >> >> The stacks show nearly all of them are stuck in sync_inodes_sb > > That's just wb_wait_for_completion(), and it means that some IO isn't > completing. > > There's also a lot of processes

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On 10/26/2016 04:00 PM, Chris Mason wrote: > > > On 10/26/2016 03:06 PM, Linus Torvalds wrote: >> On Wed, Oct 26, 2016 at 11:42 AM, Dave Jones wrote: >>> >>> The stacks show nearly all of them are stuck in sync_inodes_sb >> >> That's just wb_wai

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On Wed, Oct 26, 2016 at 03:07:10PM -0700, Linus Torvalds wrote: On Wed, Oct 26, 2016 at 1:00 PM, Chris Mason wrote: Today I turned off every CONFIG_DEBUG_* except for list debugging, and ran dbench 2048: [ 2759.118711] WARNING: CPU: 2 PID: 31039 at lib/list_debug.c:33 __list_add+0xbe/0xd0

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On Wed, Oct 26, 2016 at 05:03:45PM -0600, Jens Axboe wrote: On 10/26/2016 04:58 PM, Linus Torvalds wrote: On Wed, Oct 26, 2016 at 3:51 PM, Linus Torvalds wrote: Dave: it might be a good idea to split that "WARN_ON_ONCE()" in blk_mq_merge_queue_io() into two I did that myself too, since

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On Wed, Oct 26, 2016 at 05:20:01PM -0600, Jens Axboe wrote: On 10/26/2016 05:08 PM, Linus Torvalds wrote: On Wed, Oct 26, 2016 at 4:03 PM, Jens Axboe wrote: Actually, I think I see what might trigger it. You are on nvme, iirc, and that has a deep queue. Yes. I have long since moved on from

Re: bio linked list corruption.

2016-10-27 Thread Chris Mason
On 10/26/2016 08:00 PM, Jens Axboe wrote: > On 10/26/2016 05:47 PM, Dave Jones wrote: >> On Wed, Oct 26, 2016 at 07:38:08PM -0400, Chris Mason wrote: >> >> > >-hctx->queued++; >> > >-data->hctx = hctx; >> > >-

[GIT PULL] Btrfs

2016-10-28 Thread Chris Mason
no longer able to trigger problems. Filipe is fixing a difficult old bug between snapshots, balance and send. Dave is cooking a few more for the next rc, but these are tested and ready: Chris Mason (1) commits (+6/-14): btrfs: fix races on root_log_ctx lists Filipe Manana (1) commits (+58/-0

Linux Foundation Technical Advisory Board Elections updates and location

2016-10-28 Thread Chris Mason
. The nominees so far: Josh Triplett Rik van Riel Dave Taht Chris Mason Dan Williams Steve Rostedt is maintaining a list of the nominees and their statements at the URL below. He promises to stay at the keyboard and keep updating it until 12pm EDT Oct 30th: https://goo.gl/xlAoJl The elections

[GIT PULL] Btrfs

2016-12-16 Thread Chris Mason
in btrfs_should_throttle_delayed_refs() (+1/-1) btrfs: add necessary comments about tickets_id (+4/-0) btrfs: improve delayed refs iterations (+37/-6) Liu Bo (2) commits (+12/-6): Btrfs: adjust len of writes if following a preallocated extent (+5/-3) Btrfs: fix BUG_ON in btrfs_ma

Re: OOM: Better, but still there on 4.9

2016-12-16 Thread Chris Mason
On 12/16/2016 02:39 AM, Michal Hocko wrote: [CC linux-mm and btrfs guys] On Thu 15-12-16 23:57:04, Nils Holland wrote: [...] Of course, none of this are workloads that are new / special in any way - prior to 4.8, I never experienced any issues doing the exact same things. Dec 15 19:02:16

Re: OOM: Better, but still there on 4.9

2016-12-16 Thread Chris Mason
On 12/16/2016 02:39 AM, Michal Hocko wrote: [CC linux-mm and btrfs guys] On Thu 15-12-16 23:57:04, Nils Holland wrote: [...] Of course, none of this are workloads that are new / special in any way - prior to 4.8, I never experienced any issues doing the exact same things. Dec 15 19:02:16

Re: OOM: Better, but still there on 4.9

2016-12-16 Thread Chris Mason
On 12/16/2016 05:14 PM, Michal Hocko wrote: On Fri 16-12-16 13:15:18, Chris Mason wrote: On 12/16/2016 02:39 AM, Michal Hocko wrote: [...] I believe the right way to go around this is to pursue what I've started in [1]. I will try to prepare something for testing today for you. Stay tuned

Re: [PATCH] btrfs: limit async_work allocation and worker func duration

2016-12-13 Thread Chris Mason
On 12/12/2016 03:35 PM, Maxim Patlasov wrote: On 12/12/2016 06:54 AM, David Sterba wrote: As far as we don't have any NO_THRESHOLD users of btrfs_workqueue_normal_congested for now, I tend to think it's better to add a descriptive comment and simply return "false" from

Re: btrfs: still lockdep splat for 4.9-rc5+ (btrfs_log_inode)

2016-11-26 Thread Chris Mason
On Fri, Nov 25, 2016 at 10:03:25AM +0100, Christian Borntraeger wrote: FWIW, I still see the lockdep splat in btrfs in 4.9-rc5+ Filipe reworked the code to avoid taking the same lock twice. As far as I can tell, this just needs some annotation. -chris

[GIT PULL] Btrfs

2017-03-23 Thread Chris Mason
Hi Linus We have a small set of fixes for the next RC: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.11 Zygo tracked down a very old bug with inline compressed extents. I didn't tag this one for stable because I want to do individual tested backports. It's

Re: [Regression 4.7-rc1] btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl

2017-01-06 Thread Chris Mason
On 01/06/2017 12:22 PM, Joseph Salisbury wrote: Hi Luke, A kernel bug report was opened against Ubuntu [0]. This bug was fixed by the following commit in v4.7-rc1: commit 4c63c2454eff996c5e27991221106eb511f7db38 Author: Luke Dashjr Date: Thu Oct 29 08:22:21 2015 + btrfs: bugfix:

Re: hackbench vs select_idle_sibling; was: [tip:sched/core] sched/fair, cpumask: Export for_each_cpu_wrap()

2017-05-17 Thread Chris Mason
On 05/17/2017 06:53 AM, Peter Zijlstra wrote: On Mon, May 15, 2017 at 02:03:11AM -0700, tip-bot for Peter Zijlstra wrote: sched/fair, cpumask: Export for_each_cpu_wrap() -static int cpumask_next_wrap(int n, const struct cpumask *mask, int start, int *wrapped) -{ - next =

[GIT PULL] Btrfs

2017-04-14 Thread Chris Mason
Hi Linus Dave Sterba collected a few more fixes for the last rc: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.11 These aren't marked for stable, but I'm putting them in with a batch were testing/sending by hand for this release. Liu Bo (3) commits

Re: [PATCH] btrfs: always write superblocks synchronously

2017-05-03 Thread Chris Mason
On 05/03/2017 04:36 AM, Jan Kara wrote: On Tue 02-05-17 09:28:13, Davidlohr Bueso wrote: Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as synchronous" removed REQ_SYNC flag from WRITE_FUA implementation. Since REQ_FUA and REQ_FLUSH flags are stripped from submitted IO when the

Re: btrfs bio linked list corruption.

2016-10-12 Thread Chris Mason
On 10/12/2016 10:40 AM, Dave Jones wrote: On Wed, Oct 12, 2016 at 09:47:17AM -0400, Dave Jones wrote: > On Tue, Oct 11, 2016 at 11:54:09AM -0400, Chris Mason wrote: > > > > > > On 10/11/2016 10:45 AM, Dave Jones wrote: > > > This is from Linus' curren

Re: btrfs bio linked list corruption.

2016-10-13 Thread Chris Mason
On 10/13/2016 02:16 PM, Dave Jones wrote: On Wed, Oct 12, 2016 at 10:42:46AM -0400, Chris Mason wrote: > On 10/12/2016 10:40 AM, Dave Jones wrote: > > On Wed, Oct 12, 2016 at 09:47:17AM -0400, Dave Jones wrote: > > > On Tue, Oct 11, 2016 at 11:54:09AM -0400,

[GIT PULL] Btrfs

2016-10-14 Thread Chris Mason
Hi Linus, My for-linus-4.9 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.9 Has some fixes from Omar and Dave Sterba for our new free space tree. This isn't heavily used yet, but as we move toward making it the new default we wanted to nail down an

Linux Foundation Technical Advisory Board Elections and Nomination process

2016-10-14 Thread Chris Mason
and mailing lists, so get your nomination in early). Chris Mason, TAB Chair [1] TAB members sit for a term of two years, and half of the board is up for election every year. Five of the seats are up for election now. The other five are halfway through their term and will be up for election next year.

Re: lockdep warning in btrfs in 4.8-rc3

2016-09-08 Thread Chris Mason
On 09/08/2016 07:50 AM, Christian Borntraeger wrote: On 09/08/2016 01:48 PM, Christian Borntraeger wrote: Chris, with 4.8-rc3 I get the following on an s390 box: Sorry for the noise, just saw the fix in your pull request. The lockdep splat is still there, we'll need to annotate this one a

Re: lockdep warning in btrfs in 4.8-rc3

2016-09-09 Thread Chris Mason
On 09/08/2016 08:50 PM, Dave Jones wrote: On Thu, Sep 08, 2016 at 08:58:48AM -0400, Chris Mason wrote: > On 09/08/2016 07:50 AM, Christian Borntraeger wrote: > > On 09/08/2016 01:48 PM, Christian Borntraeger wrote: > >> Chris, > >> > >> with 4.8-rc

[GIT PULL] Btrfs

2016-09-09 Thread Chris Mason
for these problems were actually fine (sorry Filipe). Wang Xiaoguang (2) commits (+16/-8): btrfs: introduce tickets_id to determine whether asynchronous metadata reclaim work makes progress (+7/-5) btrfs: do not decrease bytes_may_use when replaying extents (+9/-3) Chris Mason (1) commits (+1/-0

Re: btrfs btree_ctree_super fault

2016-11-08 Thread Chris Mason
On 11/08/2016 09:59 AM, Dave Jones wrote: On Sun, Nov 06, 2016 at 11:55:39AM -0500, Dave Jones wrote: > > > On Mon, Oct 31, 2016 at 01:44:55PM -0600, Chris Mason wrote: > > On Mon, Oct 31, 2016 at 12:35:16PM -0700, Linus Torvalds wrote: > > >On Mon, Oct 31, 2016

Re: [PATCH 26/60] btrfs: set NO_MP for request queues behind BTRFS

2016-10-31 Thread Chris Mason
On Mon, Oct 31, 2016 at 08:36:44AM -0700, Christoph Hellwig wrote: On Sat, Oct 29, 2016 at 04:08:25PM +0800, Ming Lei wrote: There are lots of direct access to .bi_vcnt & .bi_io_vec of bio, and it isn't ready to support multipage bvecs for BTRFS, so set NO_MP for these request queues. For one

<    9   10   11   12   13   14   15   16   >