Enable CPU opp tables for Tanix TX6.
Also add the fixed regulator that provided vdd-cpu-gpu required for
CPU opp tables.
This voltage has been found using a voltmeter and could be wrong.
Tested-by: Jernej Škrabec
Signed-off-by: Clément Péron
---
.../boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
Hi Steven,
On Thu, 7 May 2020 at 16:30, Steven Price wrote:
>
> On 02/05/2020 23:07, Clément Péron wrote:
> > Hi Steven,
> >
> > On Tue, 14 Apr 2020 at 15:10, Steven Price wrote:
> >>
> >> Hi Clément,
> >>
> >> On 13/04/2020 18:28
On Sat, 9 May 2020 at 18:28, Clément Péron wrote:
>
> Hi Steven,
>
> On Thu, 7 May 2020 at 16:30, Steven Price wrote:
> >
> > On 02/05/2020 23:07, Clément Péron wrote:
> > > Hi Steven,
> > >
> > > On Tue, 14 Apr 2020 at 15:10, Steven Price wrot
We will later introduce regulators managed by OPP.
Only alloc regulators when it's needed. This also help use
to release the regulators only when they are allocated.
Signed-off-by: Clément Péron
---
drivers/gpu/drm/panfrost/panfrost_device.c | 14 +-
drivers/gpu/drm/pan
Add a simple cooling map for the GPU.
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 22
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
index
-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 80
1 file changed, 80 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
index b26f735201c7..85f43a4b651f 100644
--- a/arch/arm64/
Don't include not required headers and sort them.
Signed-off-by: Clément Péron
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
b/drivers/gpu/drm/panfrost/panfrost_devf
Introduce a proper panfrost_devfreq to deal with devfreq variables.
Signed-off-by: Clément Péron
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 76 -
drivers/gpu/drm/panfrost/panfrost_devfreq.h | 20 +-
drivers/gpu/drm/panfrost/panfrost_device.h | 11 +--
drivers/gpu
] decoded fault status: SLAVE FAULT
[ 329.411521] exception type 0xC2: TRANSLATION_FAULT_LEVEL2
[ 329.411521] access type 0x3: WRITE
[ 329.411521] source id 0xAA00
Thanks for your reviews, help on this serie,
Clement
Clément Péron (15):
drm/panfrost: avoid static declaration
drm/panfrost: c
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
index 3f7ceeb1a767..14257f7476b8 100644
Convert busy_count to a simple int protected by spinlock.
Signed-off-by: Clément Péron
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 43 +++--
drivers/gpu/drm/panfrost/panfrost_devfreq.h | 10 -
2 files changed, 41 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu
Introduce a boolean to know if opp table has been added.
With this, we can call panfrost_devfreq_fini() in case of error
and release what has been initialised.
Signed-off-by: Clément Péron
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 25 -
drivers/gpu/drm/panfrost
_init() and devfreq_fini() here.
Signed-off-by: Clément Péron
---
drivers/gpu/drm/panfrost/panfrost_device.c | 37 ++
drivers/gpu/drm/panfrost/panfrost_drv.c| 15 ++---
2 files changed, 25 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/pan
Some SoCs have several clocks defined and the OPP core
needs to know the exact name of the clk to use.
Set the clock name to "core".
Signed-off-by: Clément Péron
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 13 +
drivers/gpu/drm/panfrost/panfrost_devfreq.h | 1
This declaration can be avoided so change it.
Signed-off-by: Clément Péron
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 38 ++---
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
b/drivers/gpu/drm/panfrost
Some OPP tables specify voltage for each frequency. Devfreq can
handle these regulators but they should be get only 1 time to avoid
issue and know who is in charge.
If OPP table is probe don't init regulator.
Signed-off-by: Clément Péron
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c
Devfreq cooling device framework is used in Panfrost
to throttle GPU in order to regulate its temperature.
Enable this driver for ARM64 SoC.
Signed-off-by: Clément Péron
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch
Instead of expecting an error from dev_pm_opp_of_add_table()
do a simple device_property_present() check.
Signed-off-by: Clément Péron
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/panfrost
This use devfreq variable that will be lock with spinlock in future
patches. We should either introduce a function to access this one
but as devfreq is optional let's just remove it.
Signed-off-by: Clément Péron
---
drivers/gpu/drm/panfrost/panfrost_job.c | 4
1 file changed, 4 dele
Hi Ondrej,
On Mon, 4 May 2020 at 14:27, Ondřej Jirman wrote:
>
> Hi Clément,
>
>
> So I guess ignoring the voltage and not disabling this OPP may or may not work
> based on SoC bin.
>
> On Orange Pi One, there's a regulator that supports two voltages (that can't
> support all the listed OPPs f
Hi Maxime,
On Mon, 4 May 2020 at 14:09, Maxime Ripard wrote:
>
> Hi Clement,
>
> On Thu, Apr 30, 2020 at 04:00:14PM +0200, Clément Péron wrote:
> > On Thu, 30 Apr 2020 at 10:46, Maxime Ripard wrote:
> > > On Wed, Apr 29, 2020 at 06:33:00PM +0200, Clément Péron wrote:
r it is configured
> by the OPP core.
>
> Marek, Kamil and Clément: Can you guys please test this out and report
> if this doesn't work as expected ?
I have reviewed the patch and it seems fine for my use case.
Unfortunately I can't test it until next week.
Ac
Hi Maxime,
On Tue, 25 Aug 2020 at 15:35, Maxime Ripard wrote:
>
> Hi Clement,
>
> On Mon, Aug 03, 2020 at 09:54:05AM +0200, Clément Péron wrote:
> > Hi Maxime and All,
> >
> > On Sat, 4 Jul 2020 at 16:56, Clément Péron wrote:
> > >
> > > Hi
Hi Maxime,
On Wed, 29 Jul 2020 at 17:16, Mark Brown wrote:
>
> On Wed, Jul 29, 2020 at 04:39:27PM +0200, Maxime Ripard wrote:
>
> > It really looks like the polarity of LRCK is fine though. The first word
> > is sent with LRCK low, and then high, so we have channel 0 and then
> > channel 1 which
,
Clement
Change since v1:
- rebase on next-20200828
- add revert LRCK polarity
- remove all simple-audio-card,frame-inversion in dts
- add Ondrej patches for Orange Pi board
- Add arm64 defconfig patch
Clément Péron (4):
Revert "ASoC: sun4i-i2s: Fix the LRCK polarity"
ASoC: sun4
This reverts commit dd657eae8164f7e4bafe8b875031a7c6c50646a9.
There was a misinterpretation of the analysis using a scope.
After rechecking this using a logical analyzer the LRCK polarity is
fine.
Fixes: dd657eae8164 ("ASoC: sun4i-i2s: Fix the LRCK polarity")
Signed-off-by: Clé
From: Marcus Cooper
Enable HDMI audio on Pine64.
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
b/arch/arm64
From: Jernej Skrabec
H6 I2S is very similar to that in H3, except it supports up to 16
channels.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 221
1 file changed, 221 insertions
From: Marcus Cooper
Enable HDMI audio on the Beelink X2.
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
---
arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
b/arch/arm/boot/dts/sun8i-h3
Signed-off-by: Clément Péron
Acked-by: Maxime Ripard
---
sound/soc/sunxi/sun4i-i2s.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index acf24f512f2c..1b4482b0f4af 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi
Enable Allwinner I2S driver for arm64 defconfig.
Signed-off-by: Clément Péron
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 5828b42f5243..4eaac49dccbb 100644
--- a/arch/arm64/configs
From: Ondrej Jirman
The board has HDMI output, enable audio on it.
Signed-off-by: Ondrej Jirman
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi
From: Marcus Cooper
Add a simple-soundcard to link audio between HDMI and I2S.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a
From: Ondrej Jirman
The board has HDMI output, enable audio on it.
Signed-off-by: Ondrej Jirman
Signed-off-by: Clément Péron
---
arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 8
arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 8
2 files changed, 16 insertions(+)
diff --git a
From: Marcus Cooper
Enable HDMI audio on the Orange Pi 2.
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
---
arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
b/arch/arm/boot/dts/sun8i
From: Ondrej Jirman
The board has HDMI output, enable audio on it.
Signed-off-by: Ondrej Jirman
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5
From: Jernej Skrabec
Add a simple-soundcard to link audio between HDMI and I2S.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 32
1 file changed, 32 insertions(+)
diff --git a
From: Marcus Cooper
Add the new DAI block for I2S2 which is used for HDMI audio.
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 14 ++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner
From: Marcus Cooper
Add a simple-soundcard to link audio between HDMI and I2S.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm
The FIFO TX reg is volatile and sun8i i2s register
mapping is different from sun4i.
Even if in this case it's doesn't create an issue,
Avoid setting some regs that are undefined in sun8i.
Signed-off-by: Clément Péron
Acked-by: Maxime Ripard
---
sound/soc/sunxi/sun4i-
From: Marcus Cooper
Add the new DAI block for I2S2 which is used for HDMI audio.
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
b/arch/arm
keep consistency and avoid relying on
default.
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 1b4482b0f4af..13e64180e917 1
From: Marcus Cooper
Extend the functionality of the driver to include support of 20 and
24 bits per sample.
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
Acked-by: Maxime Ripard
---
sound/soc/sunxi/sun4i-i2s.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions
Now that HDMI sound node is available in the SoC dtsi.
Enable it for this board.
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
b/arch
From: Jernej Skrabec
H6 I2S is very similar to H3, except that it supports up to 16 channels
and thus few registers have fields on different position.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Signed-off-by: Clément Péron
Acked-by: Maxime Ripard
Acked-by: Rob Herring
Hi Samuel,
On Fri, 4 Sep 2020 at 05:16, Samuel Holland wrote:
>
> Clément,
>
> On 9/3/20 3:30 PM, Clément Péron wrote:
> > From: Jernej Skrabec
> >
> > H6 I2S is very similar to that in H3, except it supports up to 16
> > channels.
> >
> >
From: Marcus Cooper
Extend the functionality of the driver to include support of 20 and
24 bits per sample.
Signed-off-by: Marcus Cooper
Acked-by: Maxime Ripard
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 11 +--
1 file changed, 9
Like A83T the Allwinner H3 doesn't have the DMA reception available for
some audio interfaces.
As it's already documented for A83T convert this to an enum and add the H3
interface.
Acked-by: Rob Herring
Signed-off-by: Clément Péron
---
.../devicetree/bindings/sound/allwinner
patch
Clément Péron (6):
ASoC: sun4i-i2s: Change set_chan_cfg() params
ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit
ASoC: sun4i-i2s: Fix sun8i volatile regs
ASoC: sun4i-i2s: fix coding-style for callback definition
arm64: defconfig: Enable Allwinner i2s driver
dt
Checkpatch script produces warning:
WARNING: function definition argument 'const struct sun4i_i2s *'
should also have an identifier name.
Let's fix this by adding identifier name to get_bclk_parent_rate()
and set_fmt() callback definition.
Acked-by: Maxime Ripard
Signed-off-by
The FIFO TX reg is volatile and sun8i i2s register
mapping is different from sun4i.
Even if in this case it's doesn't create an issue,
Avoid setting some regs that are undefined in sun8i.
Acked-by: Maxime Ripard
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
sound/soc/s
From: Jernej Skrabec
H6 I2S is very similar to that in H3, except it supports up to 16
channels.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Reviewed-by: Chen-Yu Tsai
Acked-by: Maxime Ripard
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 222
From: Jernej Skrabec
Add Allwinner H6 I2S1 node connected to HDMI interface.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Acked-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 13 +
1 file changed, 13 insertions
an error code could be out of range for an s8 and there is
no optim to return a s8 here.
Fixes: 619c15f7fac9 ("ASoC: sun4i-i2s: Change SR and WSS computation")
Reviewed-by: Chen-Yu Tsai
Acked-by: Maxime Ripard
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-
caller. Avoid duplicating this
logic and just pass the required values as params to set_chan_cfg().
Suggested-by: Samuel Holland
Acked-by: Maxime Ripard
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 32 ++--
1 file changed, 18 insertions(+), 14 del
From: Marcus Cooper
Add H3/H5 I2S2 node connected to the HDMI interface.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Acked-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a
Enable Allwinner I2S driver for arm64 defconfig.
Signed-off-by: Clément Péron
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 17a2df6a263e..3f89f427a355 100644
--- a/arch/arm64/configs
From: Marcus Cooper
Add the I2S2 node connected to the HDMI interface.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Acked-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 14 ++
1 file changed, 14 insertions
: Chen-Yu Tsai
Acked-by: Maxime Ripard
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 83537538f8ee..6a3207245ae2 100644
--- a/sound/soc
-by: Clément Péron
---
.../devicetree/bindings/sound/allwinner,sun4i-a10-i2s.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-i2s.yaml
b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-i2s.yaml
index
keep consistency and avoid relying on
default.
Signed-off-by: Marcus Cooper
Reviewed-by: Chen-Yu Tsai
Acked-by: Maxime Ripard
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/
Hi Pierre-Louis,
On Tue, 27 Oct 2020 at 19:59, Pierre-Louis Bossart
wrote:
>
>
> > @@ -452,11 +454,11 @@ static int sun8i_i2s_set_chan_cfg(const struct
> > sun4i_i2s *i2s,
> > case SND_SOC_DAIFMT_DSP_B:
> > case SND_SOC_DAIFMT_LEFT_J:
> > case SND_SOC_DAIFMT_RIGHT_J:
> > -
Hi,
On Sat, 24 Oct 2020 at 20:39, Icenowy Zheng wrote:
>
>
>
> 于 2020年10月25日 GMT+08:00 上午2:30:35, "Jernej Škrabec"
> 写到:
> >Dne sobota, 24. oktober 2020 ob 19:51:06 CEST je Icenowy Zheng
> >napisal(a):
> >> 在 2020-10-25星期日的 00:25 +0800，Chen-Yu Tsai写道：
> >>
> >> > From: Chen-Yu Tsai
> >> >
> >>
From: Jernej Skrabec
Add Allwinner H6 I2S1 node connected to HDMI interface.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Acked-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 13 +
1 file changed, 13 insertions
Checkpatch script produces warning:
WARNING: function definition argument 'const struct sun4i_i2s *'
should also have an identifier name.
Let's fix this by adding identifier name to get_bclk_parent_rate()
and set_fmt() callback definition.
Acked-by: Maxime Ripard
Signed-off-by
for Orange Pi board
- Add arm64 defconfig patch
Clément Péron (6):
ASoC: sun4i-i2s: Change set_chan_cfg() params
ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit
ASoC: sun4i-i2s: Fix sun8i volatile regs
ASoC: sun4i-i2s: fix coding-style for callback definition
arm64
From: Jernej Skrabec
H6 I2S is very similar to that in H3, except it supports up to 16
channels.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 222
1
From: Marcus Cooper
Extend the functionality of the driver to include support of 20 and
24 bits per sample.
Signed-off-by: Marcus Cooper
Acked-by: Maxime Ripard
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 11 +--
1 file changed, 9
The FIFO TX reg is volatile and sun8i i2s register
mapping is different from sun4i.
Even if in this case it's doesn't create an issue,
Avoid setting some regs that are undefined in sun8i.
Acked-by: Maxime Ripard
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
sound/soc/s
: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index dee8688f0d37..703327dc8606 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b
-by: Clément Péron
---
.../devicetree/bindings/sound/allwinner,sun4i-a10-i2s.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-i2s.yaml
b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-i2s.yaml
index
Enable Allwinner I2S driver for arm64 defconfig.
Signed-off-by: Clément Péron
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 17a2df6a263e..3f89f427a355 100644
--- a/arch/arm64/configs
From: Marcus Cooper
Add H3/H5 I2S2 node connected to the HDMI interface.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Acked-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a
From: Marcus Cooper
Add the I2S2 node connected to the HDMI interface.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Acked-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 14 ++
1 file changed, 14 insertions
Like A83T the Allwinner H3 doesn't have the DMA reception available for
some audio interfaces.
As it's already documented for A83T convert this to an enum and add the H3
interface.
Acked-by: Rob Herring
Signed-off-by: Clément Péron
---
.../devicetree/bindings/sound/allwinner
caller. Avoid duplicating this
logic and just pass the required values as params to set_chan_cfg().
Suggested-by: Samuel Holland
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/sou
keep consistency and avoid relying on
default.
Signed-off-by: Marcus Cooper
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
an error code could be out of range for an s8 and there is
no optim to return a s8 here.
Fixes: 619c15f7fac9 ("ASoC: sun4i-i2s: Change SR and WSS computation")
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 69 +++---
Hi Samuel
On Fri, 30 Oct 2020 at 02:20, Samuel Holland wrote:
>
> On 10/27/20 4:43 PM, Clément Péron wrote:
> > Hi Pierre-Louis,
> >
> > On Tue, 27 Oct 2020 at 19:59, Pierre-Louis Bossart
> > wrote:
> >>
> >>
> >>> @@ -452,
an error code could be out of range for an s8 and there is
no optim to return a s8 here.
Fixes: 619c15f7fac9 ("ASoC: sun4i-i2s: Change SR and WSS computation")
Reviewed-by: Chen-Yu Tsai
Acked-by: Maxime Ripard
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-
caller. Avoid duplicating this
logic and just pass the required values as params to set_chan_cfg().
Suggested-by: Samuel Holland
Acked-by: Maxime Ripard
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 32 ++--
1 file changed, 18 insertions(+), 14 del
From: Jernej Skrabec
H6 I2S is very similar to that in H3, except it supports up to 16
channels.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Reviewed-by: Chen-Yu Tsai
Acked-by: Maxime Ripard
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 222
revert LRCK polarity
- remove all simple-audio-card,frame-inversion in dts
- add Ondrej patches for Orange Pi board
- Add arm64 defconfig patch
Clément Péron (7):
ASoC: sun4i-i2s: Fix lrck_period computation for I2S justified mode
ASoC: sun4i-i2s: Change set_chan_cfg() params
ASoC: sun4i-i2s
From: Marcus Cooper
Extend the functionality of the driver to include support of 20 and
24 bits per sample.
Signed-off-by: Marcus Cooper
Acked-by: Maxime Ripard
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 11 +--
1 file changed, 9
individual channel width(Left or Right)
Fix this by using the same formula as the I2S mode.
Fixes: 7ae7834ec446 ("ASoC: sun4i-i2s: Add support for DSP formats")
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
keep consistency and avoid relying on
default.
Signed-off-by: Marcus Cooper
Reviewed-by: Chen-Yu Tsai
Acked-by: Maxime Ripard
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/
From: Marcus Cooper
Add the I2S2 node connected to the HDMI interface.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Acked-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 14 ++
1 file changed, 14 insertions
Enable Allwinner I2S driver for arm64 defconfig.
Acked-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 17a2df6a263e..3f89f427a355 100644
--- a
Checkpatch script produces warning:
WARNING: function definition argument 'const struct sun4i_i2s *'
should also have an identifier name.
Let's fix this by adding identifier name to get_bclk_parent_rate()
and set_fmt() callback definition.
Acked-by: Maxime Ripard
Signed-off-by
From: Jernej Skrabec
Add Allwinner H6 I2S1 node connected to HDMI interface.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Acked-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 13 +
1 file changed, 13 insertions
Like A83T the Allwinner H3 doesn't have the DMA reception available for
some audio interfaces.
As it's already documented for A83T convert this to an enum and add the H3
interface.
Acked-by: Rob Herring
Signed-off-by: Clément Péron
---
.../devicetree/bindings/sound/allwinner
From: Marcus Cooper
Add H3/H5 I2S2 node connected to the HDMI interface.
Signed-off-by: Jernej Skrabec
Signed-off-by: Marcus Cooper
Acked-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a
-by: Clément Péron
---
.../devicetree/bindings/sound/allwinner,sun4i-a10-i2s.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-i2s.yaml
b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-i2s.yaml
index
The FIFO TX reg is volatile and sun8i i2s register
mapping is different from sun4i.
Even if in this case it's doesn't create an issue,
Avoid setting some regs that are undefined in sun8i.
Acked-by: Maxime Ripard
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Clément Péron
---
sound/soc/s
: Chen-Yu Tsai
Acked-by: Maxime Ripard
Signed-off-by: Clément Péron
---
sound/soc/sunxi/sun4i-i2s.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 003610c0badf..4f5cd850752d 100644
--- a/sound/soc
Hi Mark,
On Fri, 30 Oct 2020 at 19:19, Mark Brown wrote:
>
> On Fri, Oct 30, 2020 at 03:46:47PM +0100, Clément Péron wrote:
> > Like A83T the Allwinner H3 doesn't have the DMA reception available for
> > some audio interfaces.
>
> Please if you're going to
Hi Maxime,
On Fri, 30 Oct 2020 at 17:11, Maxime Ripard wrote:
>
> On Fri, Oct 30, 2020 at 03:46:34PM +0100, Clément Péron wrote:
> > Left and Right justified mode are computed using the same formula
> > as DSP_A and DSP_B mode.
> > Which is wrong and the use
Hi Maxime,
On Wed, 30 Sep 2020 at 12:19, Maxime Ripard wrote:
>
> On Mon, Sep 28, 2020 at 04:27:42PM +0200, Clément Péron wrote:
> > On Mon, 28 Sep 2020 at 10:43, Maxime Ripard wrote:
> > >
> > > On Mon, Sep 21, 2020 at 08:37:09PM +0200, Jernej Škrabec wro
Hi device-tree and sound Maintainers,
I have a question regarding multi-lane i2S representation.
On the Allwinner SoC the I2S/PCM Interface can handle up to four lanes
as output or input.
For each lane we can enable up to sixteen slots.
And for each output slot we can choose which slot to map.
T
-off-by: Clément Péron
---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 80
1 file changed, 80 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
index 8f514a2169aa..a69f9e09a829 100644
--- a/arch/arm64/
401 - 500 of 645 matches
Mail list logo
