On 10/08/2020 18:14, Joe Perches wrote:
> On Mon, 2020-08-10 at 10:25 -0400, Alan Stern wrote:
>> On Mon, Aug 10, 2020 at 09:32:11AM +0100, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> There is a spelling mistake in a usb_stor_dbg debug message. Fix it.
&
Hi,
static analysis with coverity has found a buffer overflow issue with the
brcmstb driver, I believe it may have been introduced with the following
commit:
commit a7c25759d8d84b64c437a78f05df7314b02934e5
Author: Markus Mayer
Date: Tue Apr 2 16:01:00 2019 -0700
memory: brcmstb: dpfe: wai
Hi,
static analysis with Coverity has detected a duplicated assignment issue
with the following commit:
commit 2d4bcbed5b7d53e19fc158885e7340b464b64507
Author: Carl Huang
Date: Mon Aug 17 13:31:51 2020 +0300
ath11k: initialize wmi config based on hw_params
The analysis is as follows:
Hi Maximilian,
Static analysis of linux-next with Coverity has found several issues
with the following commit:
commit 178f6ab77e617c984d6520b92e747075a12676ff
Author: Maximilian Luz
Date: Mon Dec 21 19:39:58 2020 +0100
platform/surface: Add Surface Aggregator user-space interface
The ana
On 11/01/2021 13:55, Maximilian Luz wrote:
> On 1/11/21 1:12 PM, Colin Ian King wrote:
>> Hi Maximilian,
>>
>> Static analysis of linux-next with Coverity has found several issues
>> with the following commit:
>>
>> commit 178f6ab77e617c984d6520b92e747075a126
On 11/01/2021 14:37, Maximilian Luz wrote:
> On 1/11/21 3:11 PM, Colin Ian King wrote:
>> On 11/01/2021 13:55, Maximilian Luz wrote:
>>> On 1/11/21 1:12 PM, Colin Ian King wrote:
>>>> Hi Maximilian,
>>>>
>>>> Static analysis of linux-nex
On 11/01/2021 16:35, Mark Brown wrote:
> On Fri, Jan 08, 2021 at 12:35:46PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently when attempting to start the BE fails because the
>> FE is not started the error return variable ret is not initialized
>&
On 11/01/2021 16:35, Mark Brown wrote:
> On Fri, Jan 08, 2021 at 12:35:46PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently when attempting to start the BE fails because the
>> FE is not started the error return variable ret is not initialized
>&
On 12/01/2021 10:22, Dan Carpenter wrote:
> On Mon, Jan 11, 2021 at 05:37:36PM +0000, Colin Ian King wrote:
>> On 11/01/2021 16:35, Mark Brown wrote:
>>> On Fri, Jan 08, 2021 at 12:35:46PM +, Colin King wrote:
>>>> From: Colin Ian King
>>>>
>>&g
On 07/12/2020 19:59, Andrea Mayer wrote:
> On Mon, 7 Dec 2020 14:45:03 +
> Colin King wrote:
>
>> From: Colin Ian King
>>
>> Shifting the integer value 1 is evaluated using 32-bit arithmetic
>> and then used in an expression that expects a unsigned l
Hi,
Static analysis of today's linux-next using Coverity has found a
potential memory leak issue in the following commit:
commit 9ab7e76aefc97a9aa664accb59d6e8dc5e52514a
Author: Pravin B Shelar
Date: Sat Jan 9 23:00:21 2021 -0800
GTP: add support for flow based tunneling API
The analysis
On 12/01/2021 10:07, Dan Carpenter wrote:
> On Mon, Jan 11, 2021 at 11:46:38AM +, Colin King wrote:
>> From: Colin Ian King
>>
>> A recent change added a new BOOTUP_DEFAULT power profile mode
>> to the PP_SMC_POWER_PROFILE enum but omitted updating the
>>
On 15/01/2021 10:07, Christophe JAILLET wrote:
> Le 15/01/2021 à 10:37, Colin Ian King a écrit :
>> On 12/01/2021 10:07, Dan Carpenter wrote:
>>> On Mon, Jan 11, 2021 at 11:46:38AM +, Colin King wrote:
>>>> From: Colin Ian King
>>>>
>>>
Hi,
Static analysis on linux-next using Coverity has detected an issue in
the following commit:
commit 6256e668b7af9d81472e03c6a171630c08f8858a
Author: Masami Hiramatsu
Date: Wed Mar 3 00:25:46 2021 +0900
x86/kprobes: Use int3 instead of debug trap for single-step
The analysis is as foll
On 24/03/2021 16:11, Martin Kaiser wrote:
> Hello Colin,
>
> Thus wrote Colin King (colin.k...@canonical.com):
>
>> From: Colin Ian King
>
>> An unregister_netdev call checks if pnetdev is null, hence a later
>> call to free_netdev can potentially be passing
On 24/03/2021 17:36, Muhammad Usama Anjum wrote:
> The condition in switch statement `opcode & 0xf0` cannot evaluate to
> 0xff. So this case statement will never execute. Remove it.
>
> Fixes: 6256e668b7 ("x86/kprobes: Use int3 instead of debug trap for
> single-step")
> Signed-off-by: Muhammad U
Hi,
Static analysis with Coverity in linux-next has detected an issue in
drivers/gpu/drm/ttm/ttm_bo.c with the follow commit:
commit a1f091f8ef2b680a5184db065527612247cb4cae
Author: Christian König
Date: Tue Oct 6 17:26:42 2020 +0200
drm/ttm: switch to per device LRU lock
Instead of
On 18/03/2021 20:12, Jens Axboe wrote:
> On 3/18/21 9:16 AM, Colin King wrote:
>> From: Colin Ian King
>>
>> The 3rd argument to alloc_workqueue should be the max_active count,
>> however currently it is the lo->lo_number that is intended for the
>> loop
On 19/03/2021 15:54, Dan Schatzberg wrote:
> On Thu, Mar 18, 2021 at 03:16:26PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> The 3rd argument to alloc_workqueue should be the max_active count,
>> however currently it is the lo->lo_number that is intended
Hi,
Static analysis with Coverity had detected an uninitialized pointer read
in function ocelot_flower_parse_key in
drivers/net/ethernet/mscc/ocelot_flower.c introduced by commit:
commit 75944fda1dfe836fdd406bef6cb3cc8a80f7af83
Author: Xiaoliang Yang
Date: Fri Oct 2 15:02:23 2020 +0300
ne
On 30/03/2021 12:48, Mel Gorman wrote:
> Colin Ian King reported the following problem (slightly edited)
>
> Author: Mel Gorman
> Date: Mon Mar 29 11:12:24 2021 +1100
>
> mm/page_alloc: add a bulk page allocator
>
> ...
>
>
Hi,
Static analysis on linux-next with Coverity has detected a potential
issue in the following commit:
commit 3f0638a0333bfdd0549985aa620f2ab69737af47
Author: Jaroslav Kysela
Date: Wed Mar 17 18:29:41 2021 +0100
ALSA: control - add layer registration routines
The static analysis is as f
Hi,
Static analysis on linux-next detected a potential uninitialized
variable dn.node_changed that does not get set when a call to
f2fs_get_node_page() fails. This uninitialized value gets used in the
call to f2fs_balance_fs() that may or not may not balances dirty node
and dentry pages depending
On 03/03/2021 09:46, Miquel Raynal wrote:
> Hi Colin,
>
> Colin King wrote on Wed, 3 Mar 2021
> 09:42:46 +:
>
>> From: Colin Ian King
>>
>> The less than zero comparison with status is always false because status
>> is a u8. Fix this by using
Hi,
Static analysis on linux-next wit Coverity has found a potential null
pointer dereference in commit:
commit 70732504c53b2d3aae2cebc457515a304672d5bb
Author: Yongqiang Sun
Date: Fri Feb 19 14:50:23 2021 -0500
drm/amd/display: Implement dmub trace event
The analysis is as follows:
400
On 03/03/2021 19:44, Jaegeuk Kim wrote:
> On 03/02, Colin Ian King wrote:
>> Hi,
>>
>> Static analysis on linux-next detected a potential uninitialized
>> variable dn.node_changed that does not get set when a call to
>> f2fs_get_node_page() fails. This uninitializ
On 03/03/2021 21:29, Heiko Thiery wrote:
> Hi all,
>
>> On Wed, Mar 3, 2021 at 6:00 PM Colin King wrote:
>>>
>>> From: Colin Ian King
>>>
>>> Currently the null check logic on dwc->usb_psy is inverted as it allows
>>> calls to power_su
Hi,
Static analysis on linux-next with Coverity has found a potential
uninitialized variable issue in function __alloc_pages_bulk with the
following commit:
commit b0e0a469733fa571ddd8fe147247c9561b51b2da
Author: Mel Gorman
Date: Mon Mar 29 11:12:24 2021 +1100
mm/page_alloc: add a bulk pa
On 15/04/2021 10:03, Marc Kleine-Budde wrote:
> On 15.04.2021 09:55:35, Colin King wrote:
>> From: Colin Ian King
>>
>> The pointer cf is being null checked earlier in the code, however the
>> update of the rx_bytes statistics is dereferencing cf without null
>>
On 12/04/2021 17:48, James Bottomley wrote:
> On Mon, 2021-04-12 at 17:01 +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> The kzalloc call can return null with the GFP_KERNEL flag so
>> add a null check and exit via a new error exit label. Use the
>> same e
Hi,
Static analysis with Coverity on Linux-next has detected a potential
issue with the following commit:
commit 480ae79537b28f30ef6e07b7de69a9ae2599daa7
Author: Maarten Lankhorst
Date: Tue Mar 23 16:50:49 2021 +0100
drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal
The ana
Hi,
Static analysis with Coverity on linux-next has found a potential issue
in drivers/net/phy/nxp-c45-tja11xx.c, function nxp_c45_get_phase_shift.
The analysis by Coverity is as follows:
350 static u64 nxp_c45_get_phase_shift(u64 phase_offset_raw)
351 {
352/* The delay in degree phase is
On 11/02/2021 19:05, Stephen Boyd wrote:
> Quoting Michael Tretter (2021-02-10 23:39:06)
>> On Wed, 10 Feb 2021 19:28:18 -0800, Stephen Boyd wrote:
>>> Quoting Colin King (2021-02-10 10:49:38)
>>>> From: Colin Ian King
>>>>
>>>> The pointer
Hi,
Analysis of linux with Coverity has detected an issue with the
assignment of ictx->xstorm_st_context.common.fla in
drivers/net/ethernet/broadcom/cnic.c in function cnic_setup_bnx2x_ctx.
This was introduced a while back with the following commit:
commit 619c5cb6885b936c44ae1422ef805b69c629148
On 09/04/2021 15:28, Brian Foster wrote:
> On Fri, Apr 09, 2021 at 03:18:34PM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> A previous commit removed a call to xfs_attr3_leaf_read that
>> assigned an error return code to variable error. We now have
>>
On 25/11/2020 18:29, Christoph Hellwig wrote:
> I'll fold this one in as well.
>
OK, so two SoB's disappear?
Hi,
Static analysis on linux-next with Coverity has detected an issue with
the following commit:
529 static int ov02a10_s_stream(struct v4l2_subdev *sd, int on)
530 {
531struct ov02a10 *ov02a10 = to_ov02a10(sd);
532struct i2c_client *client =
v4l2_get_subdevdata(&ov02a10->subdev);
On 03/12/2020 18:10, Andy Shevchenko wrote:
> On Thu, Dec 3, 2020 at 8:03 PM Colin Ian King
> wrote:
>
>> Static analysis on linux-next with Coverity has detected an issue with
>> the following commit:
>
> If you want to fix it properly, see my comments be
ze ret to 0 to avoid uninitialized ret value in first
> loop or reusing ret value from first loop in second.
>
> Addresses-Coverity: ("Uninitialized variables")
> Signed-off-by: Michal Simek
> CC: Colin Ian King
> CC: Dan Carpenter
> ---
>
> drivers/pinctrl/c
On 12/03/2021 12:45, Andy Shevchenko wrote:
> On Thu, Mar 11, 2021 at 1:26 PM Colin Ian King
> wrote:
>> On 11/03/2021 11:16, Michal Simek wrote:
>>> On 3/11/21 11:57 AM, Colin Ian King wrote:
>
>>>> For the PIN_MAP_TYPE_CONFIGS_PIN and PIN_MAP_TYPE_CONFIG
Hi,
Static analysis on linux-next with Coverity has detected an issue in
drivers/scsi/sg.c with the following recent commit:
commit b32ac463cb59e758b4560260fd168a2b4ea6e81a
Author: Douglas Gilbert
Date: Fri Feb 19 21:00:54 2021 -0500
scsi: sg: NO_DXFER move to/from kernel buffers
The ana
Hi,
Static analysis on linux-next with Coverity has found a potential issue
in drivers/pinctrl/core.c with the following commit:
commit 0952b7ec1614abf232e921aac0cc2bca8e60e162
Author: Michal Simek
Date: Wed Mar 10 09:16:54 2021 +0100
pinctrl: core: Handling pinmux and pinconf separately
Hi,
Static analysis on linux-next with Coverity has detected an issue in
drivers/scsi/sg.c in function sg_remove_sfp_usercontext with the
following recent commit:
commit 0c32296d73ec5dec64729eb555f1a29ded8a7272
Author: Douglas Gilbert
Date: Fri Feb 19 21:00:28 2021 -0500
scsi: sg: Replace
On 11/03/2021 11:16, Michal Simek wrote:
>
>
> On 3/11/21 11:57 AM, Colin Ian King wrote:
>> Hi,
>>
>> Static analysis on linux-next with Coverity has found a potential issue
>> in drivers/pinctrl/core.c with the following commit:
>>
>> commit 0952b
On 11/03/2021 11:28, Michal Simek wrote:
>
>
> On 3/11/21 12:24 PM, Colin Ian King wrote:
>> On 11/03/2021 11:16, Michal Simek wrote:
>>>
>>>
>>> On 3/11/21 11:57 AM, Colin Ian King wrote:
>>>> Hi,
>>>>
>>>> Static an
On 11/03/2021 17:12, Doug Anderson wrote:
> Hi,
>
> On Thu, Mar 11, 2021 at 1:53 AM Colin King wrote:
>>
>> From: Colin Ian King
>>
>> The shifting of the u8 integer buf[3] by 24 bits to the left will
>> be promoted to a 32 bit signed int and then sign-
On 02/03/2021 08:44, Krzysztof Kozlowski wrote:
> On Tue, Feb 23, 2021 at 07:38:21PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently the array gpmc_cs is indexed by cs before it cs is range checked
>> and the pointer read from this out-of-index rea
Hi,
Static analysis using Coverity has detected a potential null pointer
dereference after a null check in the following commit:
commit 5fdb322ff2c2b4ad519f490dcb7ebb96c5439af7
Author: Daeho Jeong
Date: Thu Dec 3 15:56:15 2020 +0900
f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS
On 05/01/2021 04:16, Daeho Jeong wrote:
> From: Daeho Jeong
>
> Fixed null page reference when find_lock_page() fails in
> redirty_blocks().
>
> Signed-off-by: Daeho Jeong
> Reported-by: Colin Ian King
> Fixes: 5fdb322ff2c2 ("f2fs: add F2FS_IOC_DECOMPRESS_FILE
On 28/01/2021 14:39, Jeff LaBundy wrote:
> Hi Colin,
>
> On Thu, Jan 28, 2021 at 12:19:03PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently if the call to qs5xx_fw_file_parse fails the error return
>> exit path will read the uninitialized
On 16/12/2020 11:54, Colin King wrote:
> From: Colin Ian King
>
> There is a spelling mistake in the Kconfig help text. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/net/ethernet/ni/Kconfig | 2 +-
> drivers/net/wireless/microchip/wilc1000/K
Hi,
Static analysis on linux-next with Coverity had found a potential null
pointer dereference issue in the following commit:
commit 88a92d6ae4fe09b2b27781178c5c9432d27b1ffb
Author: Can Guo
Date: Wed Dec 2 04:04:01 2020 -0800
scsi: ufs: Serialize eh_work with system PM events and async sc
On 27/11/2020 19:20, Heinrich Schuchardt wrote:
> Since the UEFI 2.8A specification the UEFI enabled firmware provides a
> configuration table EFI_RT_PROPERTIES_TABLE which indicates which runtime
> services are enabled. The EFI stub reads this table and saves the value of
> the field RuntimeServic
On 27/11/2020 19:29, Ard Biesheuvel wrote:
> On Fri, 27 Nov 2020 at 20:28, Colin Ian King wrote:
>>
>> On 27/11/2020 19:20, Heinrich Schuchardt wrote:
>>> Since the UEFI 2.8A specification the UEFI enabled firmware provides a
>>> configuration table EFI_RT_PROPE
On 05/03/14 18:50, Guillaume Morin wrote:
> On 05 Mar 17:51, Colin King wrote:
>> From: Colin Ian King
>>
>> A failed msgget causes the test to return an uninitialised value
>> in ret. Assign ret to -errno on error exit.
>>
>> Signed-off-by: Colin Ian King
On 30/07/14 15:48, Matt Fleming wrote:
> On Wed, 30 Jul, at 12:29:32AM, Borislav Petkov wrote:
>> On Tue, Jul 29, 2014 at 01:09:21PM -0400, Prarit Bhargava wrote:
>>> The current debug print in EFI does
>>>
>>> [0.00] efi: mem84: type=3, attr=0xf,
>>> range=[0x645b5000-0x64
On 30/04/16 23:35, Matt Fleming wrote:
> (Adding Colin and Ricardo)
>
> On Wed, 27 Apr, at 01:23:55PM, Josh Boyer wrote:
>>
>> How is an end user supposed to see such a message and report it to the
>> people that can fix it? They can't. So they report it in their
>> distributions bug tracker and
On 22/05/16 20:42, Max Filippov wrote:
> Hi Colin,
>
> On Sun, May 22, 2016 at 08:08:18PM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> priv is assigned to NULL however all the error exit paths to label 'free'
>> dereference priv, causing a nul
On 16/05/15 08:09, Ingo Molnar wrote:
>
> * Colin King wrote:
>
>> From: Colin Ian King
>>
>> Recent commit 3b8786ff7a1b31645ae2c26a2ec32dbd42ac1094
>> ("ARM: 8352/1: perf: Fix the pmu node name in warning message")
>> introduced a memory leak
On 18/05/15 14:27, Sudeep Holla wrote:
>
>
> On 18/05/15 13:57, Colin King wrote:
>> From: Colin Ian King
>>
>> Recent commit 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about
>> missing interrupt-affinity property for PPIs") introduced a memor
On 10/02/15 13:48, Kalle Valo wrote:
> Eric Dumazet writes:
>
>> On Tue, 2015-02-10 at 08:54 +, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> when running low on memory I noticed rtlwifi was producing a large
>>> quantity of repeate
On 28/02/15 20:38, Uwe Kleine-König wrote:
> Hello,
>
> is the typo in the Subject of your patch intentional?
doh, no, my fail, I'll resend.
>
> Best regards
> Uwe
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
On 16/04/16 13:52, Pavel Machek wrote:
> On Sat 2016-04-16 13:50:03, Colin King wrote:
>> From: Colin Ian King
>>
>> It is entirely possible for of_count_phandle_wit_args to
>> return a -ve error return value so we need to check for this
>> otherwise we end up al
On 26/04/16 17:50, Guenter Roeck wrote:
> On Mon, Apr 25, 2016 at 10:22:19PM -0700, Joe Perches wrote:
>> On Mon, 2016-04-25 at 20:19 +0100, Colin King wrote:
>>> fix spelling mistake, alloacate -> allocate
>> []
>>> diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
>> []
>
On 29/06/15 18:10, Takashi Iwai wrote:
> At Mon, 29 Jun 2015 17:10:22 +0100,
> Colin King wrote:
>>
>> From: Colin Ian King
>>
>> Static analysis with cppcheck found the following error:
>> [sound/core/init.c:118]: (error) Uninitialized variable: err
&
On 01/07/15 18:12, Emil Velikov wrote:
> On 1 July 2015 at 17:56, Ilia Mirkin wrote:
>> On Wed, Jul 1, 2015 at 12:51 PM, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> Various usif_ioctl helper functions do not initialize the
>>> return varia
sage.
>
> Not that it's particularly meaningful for such a trivial fix, but FWIW
:
>
> Reviewed-by: Daniel Axtens
>
> Regards,
> Daniel
>
> Colin King writes:
>
>> From: Colin Ian King
>>
>> pi_buff is being memset before it is sanity chec
On 17/03/2019 23:49, Richard Weinberger wrote:
> Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King:
>> From: Colin Ian King
>>
>> The function link_file declaration in the header file has the order
>> of the two arguments (from, to) swapped when compared to the
Hi,
Static analysis with cppcheck found a couple of interesting issues with
memcpy'ing of an uninitialized variable. Two occurrences of the same
issue are found in drivers/staging/rtl8712/rtl8712_cmd.c in functions
read_bbreg_hdl and read_rfreg_hdl.
For example:
static u8 read_bbreg_hdl(struct _
Hi,
static analysis with cppcheck has detected use of an uninitialized array
tmp_ssid in drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c in
function ieee80211_softmac_new_net()
Array tmp_ssid is only initialized when ssidbroad is non-null, however
it is being copied and the copy of this is
On 19/03/2019 13:29, Greg Kroah-Hartman wrote:
> On Mon, Mar 18, 2019 at 09:32:59PM +, Jeremy Sowden wrote:
>> On 2019-03-18, at 10:57:49 +, Colin King wrote:
>>> The range check on auth_type is redundant as there is a prior
>>> check on the auth_type values and the only way the block is en
On 10/09/2019 13:44, Dan Carpenter wrote:
> On Fri, Aug 30, 2019 at 07:38:00PM +0100, Colin Ian King wrote:
>> Hi,
>>
>> Static analysis on exfat with Coverity has picked up an assignment of
>> FFS_MEDIAERR that gets over-written:
>>
>>
>> 1750
Hi,
Static analysis with Coverity has picked up an issue with commit:
commit 205ee1187a671c3b067d7f1e974903b44036f270
Author: Ilya Dryomov
Date: Mon Jan 27 17:40:20 2014 +0200
libceph: follow redirect replies from osds
Specifically in function ceph_redirect_decode in net/ceph/osd_client.
On 30/08/2019 15:01, David Howells wrote:
> Colin King wrote:
>
>> The expression 1 << nr_slots is evaluated with 32 bit integer arithmetic
>> and can overflow before it is widened.
>
> If it does, it's an error on the part of the caller. See the banner comment:
> 1 <= nr_slots <= 9.
Doh, tota
Hi,
Static analysis on exfat with Coverity has picked up an assignment of
FFS_MEDIAERR that gets over-written:
1750if (is_dir) {
1751if ((fid->dir.dir == p_fs->root_dir) &&
1752(fid->entry == -1)) {
1753if (p_fs->dev_ejected)
Hi,
Static analysis of linux-next picked up an issue with the following commit:
commit 8fc8598e61f6f384f3eaf1d9b09500c12af47b37
Author: Jerry Chuang
Date: Tue Nov 3 07:17:11 2009 -0200
Staging: Added Realtek rtl8192u driver to staging
In drivers/staging/rtl8192u/ieee80211/ieee80211_softm
On 22/08/2019 17:03, Larry Finger wrote:
> On 8/22/19 8:35 AM, Colin King wrote:
>> From: Colin Ian King
>>
>> An earlier commit re-worked the setting of the bitmask and is now
>> assigning v with some bit flags rather than bitwise or-ing them
>> into v, consequen
Hi,
Static analysis with Coverity Scan has detected a potential assignment
bug in ad5380.c:
217case IIO_CHAN_INFO_CALIBBIAS:
218ret = regmap_read(st->regmap,
AD5380_REG_OFFSET(chan->address),
219val);
220if (ret)
221
Hi,
Static analysis with Coverity Scan on linux-next has found an issue with
the following commit:
commit 20cac6d02815edcc0b1c87bc3e8858b3d1fda3fa
Author: Stephen Boyd
Date: Wed Jul 31 12:35:09 2019 -0700
clk: actions: Don't reference clk_init_data after registration
The analysis is as f
On 22/08/2019 17:38, Larry Finger wrote:
> On 8/22/19 11:11 AM, Colin Ian King wrote:
>> On 22/08/2019 17:03, Larry Finger wrote:
>>> On 8/22/19 8:35 AM, Colin King wrote:
>>>> From: Colin Ian King
>>>>
>>>> An earlier commit re-worked the s
On 23/08/2019 12:23, Dan Carpenter wrote:
> On Fri, Aug 23, 2019 at 09:52:30AM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> The subtraction of the two pointers is automatically scaled by the
>> size of the size of the object the pointers point to, so the di
On 05/09/2019 15:52, Dan Carpenter wrote:
> It would be better to remove "n" altogether.
Good point, will resend a V2 later.
>
> regards,
> dan carpenter
>
There are a few more arrays in these drivers than can be fixed up, I'll
send a V2.
On 05/09/2019 18:45, Colin King wrote:
> From: Colin Ian King
>
> Don't populate the array tab on the stack but instead make it
> static const. Makes the object code smaller by 53 bytes.
On 12/09/2019 08:19, Ursula Braun wrote:
>
>
> On 9/11/19 5:35 PM, Colin King wrote:
>> From: Colin Ian King
>>
>> There is a spelling mistake in QETH_CARD_TEXT text. Fix it.
>>
>
> This spelling mistake is intended, because this qeth trace area is defi
On 02/10/2019 13:23, Mark Rutland wrote:
> On Wed, Oct 02, 2019 at 12:55:45PM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Shifting the u32 integer result of (pci_dword & SNR_IMC_MMIO_BASE_MASK)
>> will end up with an overflow when pci_dword greater tha
On 02/10/2019 14:25, Dan Carpenter wrote:
> On Wed, Oct 02, 2019 at 11:08:44AM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Variable pval is being assigned a value that is never read. The
>> assignment is redundant and hence can be removed.
>>
>
On 02/10/2019 14:29, Dan Carpenter wrote:
> On Wed, Oct 02, 2019 at 04:25:06PM +0300, Dan Carpenter wrote:
>> On Wed, Oct 02, 2019 at 11:08:44AM +0100, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> Variable pval is being assigned a value that is never r
On 02/10/2019 14:33, Dan Carpenter wrote:
> On Wed, Oct 02, 2019 at 12:08:49PM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> The expression !(hw_cap & XGMAC_HWFEAT_RAVSEL) >> 10 is always zero, so
>> the masking operation is incorrect. Fix this by
On 02/10/2019 14:42, Dan Carpenter wrote:
> On Wed, Oct 02, 2019 at 04:33:57PM +0300, Dan Carpenter wrote:
>> On Wed, Oct 02, 2019 at 12:08:49PM +0100, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> The expression !(hw_cap & XGMAC_HWFEAT_RAVSEL)
Hi,
Static analysis with Coverity has detected a potential issue in the
Rockchip AXI PCIe endpoint controller driver. The issue is in
drivers/pci/controller/pcie-rockchip-ep.c, function
rockchip_pcie_ep_write_header:
The coverity report is as follows:
124 static int rockchip_pcie_ep_write_heade
Hi there,
Static analysis with Coverity has detected an issue in rr_init1() in
drivers/net/hippi/rrunner.c as follows:
CID 13516 (#1 of 1): Operands don't affect result
(CONSTANT_EXPRESSION_RESULT)
result_independent_of_operands: ((unsigned long)skb->data & 4095) >
18446744073709486295UL /*
On 25/09/2019 21:43, Vinod Koul wrote:
> On 05-09-19, 17:37, Colin King wrote:
>> From: Colin Ian King
>>
>> Don't populate the array 'handler' on the stack but instead make it
>> static const. Makes the object code smaller by 80 bytes.
>>
&g
Hi,
Static analysis with Coverity has detected an potential dereference of a
free'd object with commit:
commit 9f918a728cf86b2757b6a7025e1f46824bfe3155
Author: Lukasz Majewski
Date: Wed Sep 25 11:11:42 2019 +0200
spi: Add call to spi_slave_abort() function when spidev driver is
released
On 26/09/2019 11:14, Lukasz Majewski wrote:
> Hi Colin,
>
>> Hi,
>>
>> Static analysis with Coverity has detected an potential dereference
>> of a free'd object with commit:
>>
>> commit 9f918a728cf86b2757b6a7025e1f46824bfe3155
>> Author: Lukasz Majewski
>> Date: Wed Sep 25 11:11:42 2019 +0200
On 27/09/2019 11:38, Colin King wrote:
> From: Colin Ian King
>
> There is a return statement that is indented too deeply, remove
> the extraneous tab.
>
> Signed-off-by: Colin Ian King
> ---
> sound/soc/amd/raven/acp3x-pcm-dma.c | 2 +-
> 1 file changed,
Hi,
Static analysis with Coverity has detected an issue with setting the
speed control on the e1000 driver. This was introduced back in 2011 with
the following commit:
commit 5377a4160bb65ee4dd11b4b1d081d86d56d92bff
Author: Dirk Brandewie
Date: Thu Jan 6 14:29:54 2011 +
e1000: Add sup
Hi,
Static analysis on linux-next has found a potential issue in commit:
commit 95ededc17e4e55a5fbb106f63cea06defc963a37
Author: AngeloGioacchino Del Regno
Date: Sat Oct 5 12:41:31 2019 +0200
thermal: qcom: tsens-v1: Add support for MSM8956 and MSM8976
Namely in drivers/thermal/qcom/tse
On 29/07/2019 12:24, walter harms wrote:
>
>
> Am 29.07.2019 12:29, schrieb Colin King:
>> From: Colin Ian King
>>
>> The variable val is having the top 8 bits cleared and then the variable
>> is being re-assinged and setting just the top 8 bits. I believe t
On 29/07/2019 13:11, Kieran Bingham wrote:
> Hi Colin,
>
> On 28/07/2019 18:11, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently when the call vsp1_dl_body_get fails and returns null the
>> error return path leaks the allocation of dl. Fix this by
On 15/02/2019 15:32, Thierry Reding wrote:
> On Fri, Feb 15, 2019 at 03:31:26PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> The phrasing in two dev_err messages is using fallbacking which
>> os less understandable than "falling back", so fix thi
101 - 200 of 578 matches
Mail list logo
