[WARNING] stmmac: refcount_t: saturated; leaking memory

2017-08-21 Thread Corentin Labbe
Hello I got on all my stmmac boards the following warning: [12605.062840] [ cut here ] [12605.062956] WARNING: CPU: 0 PID: 15637 at /linux-next/lib/refcount.c:77 refcount_add_not_zero+0xa8/0xb8 [12605.062972] refcount_t: saturated; leaking memory. [12605.062987] Modules

Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-22 Thread Corentin Labbe
On Mon, Aug 21, 2017 at 04:23:21PM +0200, Andrew Lunn wrote: > > All muxes are mostly always represented the same way afaik, or do you > > want to simply introduce a new compatible / property? > > + mdio-mux { > + compatible = "allwinner,sun8i-h3-mdio-switch"; > +

[PATCH v4 1/5] net: stmmac: Handle possible fixed-link with need_mdio_ids

2017-08-26 Thread Corentin Labbe
In case of fixed link, there are no mdio node. This patch add a test for fixed-link for bypassing MDIO node register that match need_mdio_ids. Note that this do not change behaviour for MDIO snps,dwmac-mdio nodes. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drive

Re: [PATCH] net: stmmac: Handle possible fixed-link with need_mdio_ids

2017-08-26 Thread Corentin Labbe
On Fri, Aug 25, 2017 at 09:45:23AM -0700, Florian Fainelli wrote: > On 08/25/2017 09:28 AM, Andrew Lunn wrote: > > On Fri, Aug 25, 2017 at 04:42:08PM +0200, Corentin Labbe wrote: > >> In case of fixed link, there are no mdio node. > >> This patch add a test for fixed-l

[PATCH v4 5/5] net: stmmac: Register parent MDIO in case of fake mdio-mux

2017-08-26 Thread Corentin Labbe
In case of a fake MDIO switch/mux (like Allwinner H3), the registered MDIO node should be the parent of the PHY. Otherwise of_phy_connect will fail. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 13 +++--

[PATCH v4 4/5] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated

2017-08-26 Thread Corentin Labbe
property. Since the internal_phy variable does not need anymore to contain the xMII mode used by the internal PHY, it is still used for knowing the presence of an internal PHY, so it is modified to a boolean soc_has_internal_phy. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>

[PATCH v4 0/5] net: stmmac: Detect PHY location with phy-is-integrated

2017-08-26 Thread Corentin Labbe
patch since another same patch was already merged - Moved phy-is-integrated from SoC dtsi to final board DT. Corentin Labbe (5): net: stmmac: Handle possible fixed-link with need_mdio_ids ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac dt-bindings: net: dwmac-sun

[PATCH v4 3/5] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-08-26 Thread Corentin Labbe
This patch add documentation about the MDIO switch used on sun8i-h3-emac for integrated PHY. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 117 - 1 file changed, 112 insertions(+), 5 deletions(-) diff

[PATCH v4 2/5] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

2017-08-26 Thread Corentin Labbe
Since dwmac-sun8i could use either an integrated PHY or an external PHY (which could be at same MDIO address), we need to represent this selection by a MDIO switch. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 22 +++

Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-24 Thread Corentin Labbe
On Wed, Aug 23, 2017 at 09:31:53AM -0700, Florian Fainelli wrote: > On 08/23/2017 12:49 AM, Maxime Ripard wrote: > > Hi Florian, > > > > On Tue, Aug 22, 2017 at 11:35:01AM -0700, Florian Fainelli wrote: > > So I think what you are saying is either impossible or engineering-wise > > a very

Re: [PATCH v2] arm64: allwinner: h5: add support for NanoPi NEO Plus 2

2017-08-25 Thread Corentin Labbe
ngePi PC 2, sun50i-h5-orangepi-pc2 > Added dwmac-sun8i Gigabit Ethernet support based on > Nano Pi Neo2 DT and the schematics. > > Signed-off-by: Antony Antony <ant...@phenome.org> Hello I do not see changes between v1 to v2. And you need to set your real name in signed-off. Regards Corentin Labbe

[PATCH] net: stmmac: dwmac-sun8i: Use reset exclusive

2017-08-25 Thread Corentin Labbe
The current dwmac_sun8i module cannot be rmmod/modprobe due to that the reset controller was not released when removed. This patch remove ambiguity, by using of_reset_control_get_exclusive and add the missing reset_control_put(). Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.

[PATCH] net: stmmac: Handle possible fixed-link with need_mdio_ids

2017-08-25 Thread Corentin Labbe
In case of fixed link, there are no mdio node. This patch add a test for fixed-link for bypassing MDIO node register. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] net: stmmac: dwmac-sun8i: Use reset exclusive

2017-08-25 Thread Corentin Labbe
On Fri, Aug 25, 2017 at 04:48:32PM +0200, Maxime Ripard wrote: > On Fri, Aug 25, 2017 at 04:38:05PM +0200, Corentin Labbe wrote: > > The current dwmac_sun8i module cannot be rmmod/modprobe due to that > > the reset controller was not released when removed. > > > >

Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-19 Thread Corentin Labbe
On Sat, Aug 19, 2017 at 01:05:21AM +0800, Chen-Yu Tsai wrote: > On Fri, Aug 18, 2017 at 8:21 PM, Corentin Labbe > <clabbe.montj...@gmail.com> wrote: > > In case of a MDIO switch, the registered MDIO node should be > > the parent of the PHY. Otherwise of_phy_connect will

Re: [PATCH v3 4/4] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-08-19 Thread Corentin Labbe
On Sat, Aug 19, 2017 at 12:57:07AM +0800, Chen-Yu Tsai wrote: > On Fri, Aug 18, 2017 at 8:21 PM, Corentin Labbe > <clabbe.montj...@gmail.com> wrote: > > This patch add documentation about the MDIO switch used on sun8i-h3-emac > > for integrated PHY. > > >

Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-20 Thread Corentin Labbe
On Sat, Aug 19, 2017 at 10:38:36PM +0200, Andrew Lunn wrote: > On Sat, Aug 19, 2017 at 08:50:25PM +0200, Corentin Labbe wrote: > > On Sat, Aug 19, 2017 at 01:05:21AM +0800, Chen-Yu Tsai wrote: > > > On Fri, Aug 18, 2017 at 8:21 PM, Corentin Labbe > > > <cl

Re: [PATCH v4 4/5] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated

2017-08-29 Thread Corentin Labbe
On Sat, Aug 26, 2017 at 11:20:51PM +0200, Andrew Lunn wrote: > Hi Corentin > > I think we have now all agreed this is an mdio-mux, plus it is also an > MII mux. We should represent that in device tree. This patchset does > this. However, as it is now, the mux structure in DT is ignored. All > it

Re: [PATCH 0/5] net: mdio-mux: Misc fix

2017-09-01 Thread Corentin Labbe
On Wed, Aug 30, 2017 at 09:01:19PM +0200, Andrew Lunn wrote: > On Wed, Aug 30, 2017 at 07:46:46PM +0200, Corentin Labbe wrote: > > Hello > > > > This patch series fix minor problems found when working on the > > dwmac-sun8i syscon mdio-mux. > > Hi Corentin

[PATCH v2 0/5] net: mdio-mux: Misc fix

2017-09-01 Thread Corentin Labbe
Hello This patch series fix minor problems found when working on the dwmac-sun8i syscon mdio-mux. Regards Changes since v1: - Removed obsolete comment about of_mdio_find_bus/put_device - removed more DRV_VERSION Corentin Labbe (5): net: mdio-mux: Fix NULL Comparison style net: mdio-mux

[PATCH v2 2/5] net: mdio-mux: Remove unnecessary 'out of memory' message

2017-09-01 Thread Corentin Labbe
This patch fix checkpatch warning about unnecessary 'out of memory' message. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Reviewed-by: Andrew Lunn <and...@lunn.ch> --- drivers/net/phy/mdio-mux.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/phy/

[PATCH v2 3/5] net: mdio-mux: printing driver version is useless

2017-09-01 Thread Corentin Labbe
Remove the driver version information because this information is not useful in an upstream kernel driver. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/phy/mdio-mux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/n

[PATCH v2 1/5] net: mdio-mux: Fix NULL Comparison style

2017-09-01 Thread Corentin Labbe
This patch fix checkpatch warning about NULL Comparison style. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Reviewed-by: Andrew Lunn <and...@lunn.ch> --- drivers/net/phy/mdio-mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/

[PATCH 0/3] agp: Misc fix

2017-09-01 Thread Corentin Labbe
Hello The first patch goal is to regroup all miscdevice number in the same place. The two subsequent patch are build warning fix found when working on the first. Corentin Labbe (3): agp: move AGPGART_MINOR to include/linux/miscdevice.h agp: add compat_ioctl.h to frontend.c agp: remove

[PATCH 2/3] agp: add compat_ioctl.h to frontend.c

2017-09-01 Thread Corentin Labbe
and "users" of compat_ioctl.h use them, frontend.c need to include compat_ioctl.h. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/char/agp/frontend.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp/

[PATCH 3/3] agp: remove unused variable num_segments

2017-09-01 Thread Corentin Labbe
This patch fix the following build warning: warning: variable 'num_segments' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/char/agp/frontend.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driver

[PATCH 1/3] agp: move AGPGART_MINOR to include/linux/miscdevice.h

2017-09-01 Thread Corentin Labbe
This patch move the define for AGPGART_MINOR to include/linux/miscdevice.h. It is better that all minor number definitions are in the same place. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- include/linux/agpgart.h| 2 -- include/linux/miscdevice.h | 1 + 2 files chan

[PATCH v2 5/5] net: mdio-mux: fix unbalanced put_device

2017-09-01 Thread Corentin Labbe
her branch of "if (mux_bus)". Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/phy/mdio-mux.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c index 282828551bdd..6f75e9f27fed 100644 --- a/

[PATCH v2 4/5] net: mdio-mux-mmioreg: Can handle 8/16/32 bits registers

2017-09-01 Thread Corentin Labbe
This patch fix an old information that mdio-mux-mmioreg can only handle 8bit registers. This is not true anymore. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Reviewed-by: Andrew Lunn <and...@lunn.ch> --- drivers/net/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+)

[PATCH 0/1] net: mdio-mux: add mdio_mux parameter to mdio_mux_init()

2017-09-04 Thread Corentin Labbe
acceptable. Regards Corentin Labbe (1): net: mdio-mux: add mdio_mux parameter to mdio_mux_init() drivers/net/phy/mdio-mux-bcm-iproc.c | 2 +- drivers/net/phy/mdio-mux-gpio.c | 2 +- drivers/net/phy/mdio-mux-mmioreg.c | 3 ++- drivers/net/phy/mdio-mux.c | 7 --- include/linux/

[PATCH 1/1] net: mdio-mux: add mdio_mux parameter to mdio_mux_init()

2017-09-04 Thread Corentin Labbe
a direct owning device. For example a mdio-mux which is a subnode of a real device. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/phy/mdio-mux-bcm-iproc.c | 2 +- drivers/net/phy/mdio-mux-gpio.c | 2 +- drivers/net/phy/mdio-mux-mmioreg.c | 3 ++- drivers/net/ph

[PATCH] mtd: nand: remove unused blockmask variable

2017-09-02 Thread Corentin Labbe
This patch fix the following build warning: drivers/mtd/nand/nand_base.c:2671:30: attention : variable ‘blockmask’ set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/mtd/nand/nand_base.c | 3 +-- 1 file changed, 1 insertion

[PATCH 2/2] selinux: fix build warning

2017-10-04 Thread Corentin Labbe
This patch make selinux_task_prlimit() static since it is not used anywhere else. This fix the following build warning: security/selinux/hooks.c:3981:5: warning: no previous prototype for 'selinux_task_prlimit' [-Wmissing-prototypes] Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.

[PATCH 1/2] selinux: fix build warning by removing the unused sid variable

2017-10-04 Thread Corentin Labbe
This patch remove the unused variable sid This fix the following build warning: security/selinux/hooks.c:2921:6: warning: variable 'sid' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- security/selinux/hooks.c | 3 +-- 1 file chan

Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-04 Thread Corentin Labbe
On Thu, Sep 28, 2017 at 09:37:08AM +0200, Corentin Labbe wrote: > On Wed, Sep 27, 2017 at 04:02:10PM +0200, Andrew Lunn wrote: > > Hi Corentin > > > > > +Required properties for the mdio-mux node: > > > + - compatible = "mdio-mux" > > &g

[PATCH v7 01/10] dt-bindings: net: Restore sun8i dwmac binding

2017-10-18 Thread Corentin Labbe
ot;dt-bindings: net: Revert sun8i dwmac binding") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 84 ++ 1 file changed, 84 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/dwmac

[PATCH v7 10/10] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes

2017-10-18 Thread Corentin Labbe
] mdio_bus stmmac-0: scan phy mdio-mux at address 1 [...] [ 18.176420] mdio_bus stmmac-0: scan phy mdio-mux at address 30 [ 18.176452] mdio_bus stmmac-0: scan phy mdio-mux at address 31 Since mdio-mux nodes are not PHY, this patch a way to to not scan them. Signed-off-by: Corentin Labbe <clabbe.mo

[PATCH v7 06/10] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

2017-10-18 Thread Corentin Labbe
Since dwmac-sun8i could use either an integrated PHY or an external PHY (which could be at same MDIO address), we need to represent this selection by a MDIO switch. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dts

[PATCH v7 02/10] arm: dts: sunxi: Restore EMAC changes

2017-10-18 Thread Corentin Labbe
evert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 9 arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 19 + arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts | 19 +++

[PATCH v7 00/10] net: stmmac: dwmac-sun8i: Handle integrated PHY

2017-10-18 Thread Corentin Labbe
same patch was already merged - Moved phy-is-integrated from SoC dtsi to final board DT. Corentin Labbe (10): dt-bindings: net: Restore sun8i dwmac binding arm: dts: sunxi: Restore EMAC changes arm64: dts: allwinner: Restore EMAC changes net: stmmac: sun8i: Restore the compatibles dt-bind

[PATCH v7 03/10] arm64: dts: allwinner: Restore EMAC changes

2017-10-18 Thread Corentin Labbe
inner: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 16 .../boot/dts/allwinner/sun50i-a64-pine64-plus.dts| 15 +++ arch/arm64/boot/dts/allwinner/sun50i-a64-

Re: [PATCH v4 2/2] crypto: stm32 - Support for STM32 CRYP crypto module

2017-10-19 Thread Corentin Labbe
Hello I have some minor comment below On Thu, Oct 19, 2017 at 11:03:59AM +0200, Fabien Dessenne wrote: > This module registers block cipher algorithms that make use of the > STMicroelectronics STM32 crypto "CRYP1" hardware. > The following algorithms are supported: > - aes: ecb, cbc, ctr > -

[PATCH v7 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-18 Thread Corentin Labbe
This patch add documentation about the MDIO switch used on sun8i-h3-emac for integrated PHY. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 139 +++-- 1 file changed, 127 insertions(+), 12 deletions(-)

[PATCH v7 09/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

2017-10-18 Thread Corentin Labbe
The Allwinner H3 SoC have two distinct MDIO bus, only one could be active at the same time. The selection of the active MDIO bus are done via some bits in the EMAC register of the system controller. This patch implement this MDIO switch via a custom MDIO-mux. Signed-off-by: Corentin Labbe

[PATCH v7 08/10] net: stmmac: snps,dwmac-mdio MDIOs are automatically registered

2017-10-18 Thread Corentin Labbe
s not need to be in need_mdio_ids. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_

[PATCH v7 04/10] net: stmmac: sun8i: Restore the compatibles

2017-10-18 Thread Corentin Labbe
sun8i: Remove the compatibles") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmm

[PATCH v7 07/10] arm64: dts: allwinner: add snps,dwmac-mdio compatible to emac/mdio

2017-10-18 Thread Corentin Labbe
stmmac bindings docs said that its mdio node must have compatible = "snps,dwmac-mdio"; Since dwmac-sun8i does not have any good reasons to not doing it, all their MDIO node must have it. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner

Re: [PATCH v7 02/10] arm: dts: sunxi: Restore EMAC changes

2017-10-18 Thread Corentin Labbe
On Wed, Oct 18, 2017 at 06:44:50PM +0200, Andrew Lunn wrote: > On Wed, Oct 18, 2017 at 01:44:50PM +0200, Corentin Labbe wrote: > > The original dwmac-sun8i DT bindings have some issue on how to handle > > integrated PHY and was reverted in last RC of 4.13. > > But now we have

[PATCH] clk: sunxi: fix build warning

2017-10-19 Thread Corentin Labbe
This patch fix the following build warning: drivers/clk/sunxi/clk-factors.c:279:14: warning: variable 'name' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/clk/sunxi/clk-factors.c | 2 -- 1 file changed, 2 deletions(-)

Re: [PATCH] clk: sunxi: fix build warning

2017-10-24 Thread Corentin Labbe
On Tue, Oct 24, 2017 at 01:36:28AM -0700, Stephen Boyd wrote: > On 10/20, Maxime Ripard wrote: > > Hi Stephen, Mike, > > > > On Thu, Oct 19, 2017 at 09:09:48PM +0200, Corentin Labbe wrote: > > > This patch fix the following build warning: > > > drivers/

[PATCH v8 02/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-23 Thread Corentin Labbe
This patch add documentation about the MDIO switch used on sun8i-h3-emac for integrated PHY. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 139 +++-- 1 file changed, 127 insertions(+), 12 deletions(-)

[PATCH v8 10/10] net: stmmac: sun8i: Restore the compatibles

2017-10-23 Thread Corentin Labbe
sun8i: Remove the compatibles") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmm

[PATCH v8 03/10] arm: dts: sunxi: h3/h5: Restore EMAC changes

2017-10-23 Thread Corentin Labbe
evert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi index c1bd09dab3

[PATCH v8 04/10] arm: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac

2017-10-23 Thread Corentin Labbe
Since dwmac-sun8i could use either an integrated PHY or an external PHY (which could be at same MDIO address), we need to represent this selection by a MDIO switch. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sunxi-h3-h5.dts

[PATCH v8 01/10] dt-bindings: net: Restore sun8i dwmac binding

2017-10-23 Thread Corentin Labbe
ot;dt-bindings: net: Revert sun8i dwmac binding") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../devicetree/bindings/net/dwmac-sun8i.txt| 84 ++ 1 file changed, 84 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/dwmac

[PATCH v8 05/10] arm: dts: sunxi: Restore EMAC changes (boards)

2017-10-23 Thread Corentin Labbe
: dts: sunxi: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 9 + arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 19 +++ arch/arm/boot/dts/sun8i-h3-nanopi-m1-p

[PATCH v8 07/10] arm64: dts: allwinner: add snps,dwmac-mdio compatible to emac/mdio

2017-10-23 Thread Corentin Labbe
stmmac bindings docs said that its mdio node must have compatible = "snps,dwmac-mdio"; Since dwmac-sun8i does not have any good reasons to not doing it, all their MDIO node must have it. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm64/boot/dts/allwinner

[PATCH v8 09/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

2017-10-23 Thread Corentin Labbe
The Allwinner H3 SoC have two distinct MDIO bus, only one could be active at the same time. The selection of the active MDIO bus are done via some bits in the EMAC register of the system controller. This patch implement this MDIO switch via a custom MDIO-mux. Signed-off-by: Corentin Labbe

[PATCH v8 08/10] net: stmmac: snps,dwmac-mdio MDIOs are automatically registered

2017-10-23 Thread Corentin Labbe
s not need to be in need_mdio_ids. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_

[PATCH v8 06/10] arm64: dts: allwinner: Restore EMAC changes

2017-10-23 Thread Corentin Labbe
inner: Revert EMAC changes") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 16 .../boot/dts/allwinner/sun50i-a64-pine64-plus.dts| 15 +++ arch/arm64/boot/dts/allwinner/sun50i-a64-

[PATCH v8 00/10] net: stmmac: dwmac-sun8i: Handle integrated PHY

2017-10-23 Thread Corentin Labbe
distinction between integrated and external MDIO. - phy-is-integrated is not set in dtsi. Changes since v1: - Dropped phy-is-integrated documentation patch since another same patch was already merged - Moved phy-is-integrated from SoC dtsi to final board DT. Corentin Labbe (10): dt-bindings: ne

[PATCH] mm: shmem: remove unused info variable

2017-11-15 Thread Corentin Labbe
This patch fix the following build warning by simply removing the unused info variable. mm/shmem.c:3205:27: warning: variable 'info' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe <cla...@baylibre.com> --- mm/shmem.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH 2/2] musb: remove unused pipe variable

2017-11-15 Thread Corentin Labbe
This patch fix the following build warning: drivers/usb/musb/musb_host.c:1809:8: warning: variable 'pipe' set but not used [-Wunused-but-set-variable] by removing the pipe variable in musb_host_rx() Signed-off-by: Corentin Labbe <cla...@baylibre.com> --- drivers/usb/musb/musb_host.c | 3

[PATCH 1/2] musb: remove unused frame variable

2017-11-15 Thread Corentin Labbe
This patch fix the following warning drivers/usb/musb/musb_host.c:223:8: warning: variable 'frame' set but not used [-Wunused-but-set-variable] by remove the frame variable in musb_start_urb(). Signed-off-by: Corentin Labbe <cla...@baylibre.com> --- drivers/usb/musb/musb_host.c | 2 --

[PATCH] arm: Remove unused __readwrite_bug function

2017-11-15 Thread Corentin Labbe
The function __readwrite_bug() is not used at all, so this patch remove it. Signed-off-by: Corentin Labbe <cla...@baylibre.com> --- arch/arm/include/asm/io.h | 5 - arch/arm/kernel/traps.c | 7 --- 2 files changed, 12 deletions(-) diff --git a/arch/arm/include/asm/io.h b/ar

[PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

2017-11-28 Thread Corentin Labbe
The driver expect "allwinner,leds-active-low" to be in PHY node, but the binding doc expect it to be in MAC node. Since all board DT use it also in MAC node, the driver need to search allwinner,leds-active-low in MAC node. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com&

[PATCH v2] ARM64: crypto: do not call crypto_unregister_skcipher twice on error

2017-11-24 Thread Corentin Labbe
When a cipher fails to register in aes_init(), the error path goes thought aes_exit() then crypto_unregister_skciphers(). Since aes_exit calls also crypto_unregister_skcipher, this triggers a refcount_t: underflow; use-after-free. Signed-off-by: Corentin Labbe <cla...@baylibre.com> --- C

[PATCH] crypto: arm64/aes - do not call crypto_unregister_skcipher twice on error

2017-11-22 Thread Corentin Labbe
When a cipher fail to register in aes_init(), the error path go thought aes_exit() then crypto_unregister_skciphers(). Since aes_exit calls also crypto_unregister_skcipher, this trigger a refcount_t: underflow; use-after-free. Signed-off-by: Corentin Labbe <cla...@baylibre.com> --- arch

[PATCH RFC 4/4] crypto: stm32: convert to the new crypto engine API

2017-11-29 Thread Corentin Labbe
This patch convert the driver to the new crypto engine API. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/crypto/stm32/stm32-hash.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/stm32/stm32-hash.c b/d

[PATCH RFC 2/4] crypto: omap: convert to new crypto engine API

2017-11-29 Thread Corentin Labbe
This patch convert the driver to the new crypto engine API. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/crypto/omap-aes.c | 21 +++-- drivers/crypto/omap-aes.h | 3 +++ drivers/crypto/omap-des.c | 24 ++-- 3 files chang

[PATCH RFC 1/4] crypto: engine - Permit to enqueue all async requests

2017-11-29 Thread Corentin Labbe
The crypto engine could actually only enqueue hash and ablkcipher request. This patch permit it to enqueue any type of crypto_async_request. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- crypto/crypto_engine.c | 188 +++- i

[PATCH RFC 3/4] crypto: virtio: convert to new crypto engine API

2017-11-29 Thread Corentin Labbe
This patch convert the driver to the new crypto engine API. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/crypto/virtio/virtio_crypto_algs.c | 15 ++- drivers/crypto/virtio/virtio_crypto_common.h | 2 +- drivers/crypto/virtio/virtio_crypto_core.c

[PATCH RFC 0/4] crypto: engine - Permit to enqueue all async requests

2017-11-29 Thread Corentin Labbe
driver. Regards [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1474434.html Corentin Labbe (4): crypto: engine - Permit to enqueue all async requests crypto: omap: convert to new crypto engine API crypto: virtio: convert to new crypto engine API crypto: stm32: convert

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

2017-11-29 Thread Corentin Labbe
On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > The driver expect "allwinner,leds-active-low" to be in PHY node, but > > the binding doc expect it to be in MAC node. > > > >

[PATCH] crypto: stm32: fix module device table name

2017-11-30 Thread Corentin Labbe
replace sti_dt_ids with stm32_dt_ids which is just declared before. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- drivers/crypto/stm32/stm32-cryp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32

[PATCH 2/2] crypto: seqiv - Remove unused alg/spawn variable

2017-12-12 Thread Corentin Labbe
This patch remove two unused variable and some dead "code" using it. Fixes: 92932d03c2b3 ("crypto: seqiv - Remove AEAD compatibility code") Signed-off-by: Corentin Labbe <cla...@baylibre.com> --- crypto/seqiv.c | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH 1/2] crypto: echainiv - Remove unused alg/spawn variable

2017-12-12 Thread Corentin Labbe
This patch remove two unused variable and some dead "code" using it. Fixes: 66008d4230f6 ("crypto: echainiv - Remove AEAD compatibility code") Signed-off-by: Corentin Labbe <cla...@baylibre.com> --- crypto/echainiv.c | 5 - 1 file changed, 5 deletions(-) diff -

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

2017-12-14 Thread Corentin Labbe
On Tue, Dec 12, 2017 at 09:24:25AM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Dec 11, 2017 at 08:35:34PM +0100, Corentin Labbe wrote: > > On Mon, Dec 11, 2017 at 08:49:57AM +0100, Mylène Josserand wrote: > > > This series adds SMP support for Allwinner Sun8i-a83t > &

[PATCH 2/2] arm: dts: sun8i: a83t: Add an unit address to the memory node

2017-12-13 Thread Corentin Labbe
This will fix the following warning: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/2] arm: dts: sun8i: a83t: remove leading zero from cpucfg node address

2017-12-13 Thread Corentin Labbe
This will fix the following warning: Warning (simple_bus_reg): Node /soc/cpucfg@0170 simple-bus unit address format error, expected "170" Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 2 +- 1 file changed, 1 insertio

[PATCH] watchdog: document watchdog_init_timeout() wdd parameter

2017-12-13 Thread Corentin Labbe
All parameters of watchdog_init_timeout() are documented with exception of wdd, thus generating a build warning. This patch document it and so remove the following build warning: drivers/watchdog/watchdog_core.c:113: warning: No description found for parameter 'wdd' Signed-off-by: Corentin

Re: [linux-sunxi] [PATCH] arm64: allwinner: a64: add Ethernet PHY regulator for several boards

2017-11-11 Thread Corentin Labbe
On Fri, Nov 10, 2017 at 05:26:54PM +0800, Icenowy Zheng wrote: > On several A64 boards the Ethernet PHY is powered by the DC1SW regulator > on the AXP803 PMIC. > > Add phy-handle property to these boards' emac node. > > Signed-off-by: Icenowy Zheng <icen...@aosc.io>

UBSAN: Undefined behaviour in mm/sparse.c:81:17

2017-11-05 Thread Corentin Labbe
Hello At least since next-20171102 I hit the following boot crash: [0.00] Booting Linux on physical CPU 0x00 [0x410fd034] [0.00] Linux version 4.14.0-rc7-next-20171103+ (compile@Red) (gcc version 6.4.0 (Gentoo 6.4.0 p1.0)) #227 SMP PREEMPT Sun Nov 5 10:12:13 CET 2017 [

Re: UBSAN: Undefined behaviour in mm/sparse.c:81:17

2017-11-06 Thread Corentin Labbe
On Sun, Nov 05, 2017 at 01:57:33PM +0100, Corentin Labbe wrote: > Hello > > At least since next-20171102 I hit the following boot crash: > [0.00] Booting Linux on physical CPU 0x00 [0x410fd034] > [0.00] Linux version 4.14.0-rc7-next-20171103+ (compile@Red)

[PATCH 1/1] ARM: dts: sunxi: sun8i-h3-nanopi-m1-plus: Add missing regulator

2017-11-01 Thread Corentin Labbe
This patch add the missing regulator for sun8i-h3-nanopi-m1-plus. Fixes: ("ARM: dts: sunxi: Restore EMAC changes (boards)") Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts | 10 ++ 1 file changed, 10 insertion

Re: linux-next: build failure after merge of the sunxi tree

2017-11-01 Thread Corentin Labbe
On Wed, Nov 01, 2017 at 07:43:45AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the sunxi tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dtb: ERROR (phandle_references): > Reference to non-existent node or

[PATCH 0/1] ARM: dts: sunxi: sun8i-h3-nanopi-m1-plus: fix build failure

2017-11-01 Thread Corentin Labbe
Hello The following patch fix the build failure due to "ARM: dts: sunxi: Restore EMAC changes (boards)". A made a mistake when rebasing and a part of sun8i-h3-nanopi-m1-plus emac was added without the needed regulator. Regards Corentin Labbe (1): ARM: dts: sunxi: sun8i-h3-nanopi-m1

[PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver

2017-11-07 Thread Corentin Labbe
The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Reviewed-by: Chen-Yu Tsai <w...@csie.org> --- arch/arm/boot/dts/sun8i-a8

[PATCH 2/2] ARM: sun8i: bananapi-m3: Enable dwmac-sun8i

2017-11-07 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the bananapi m3 It uses an external PHY rtl8211e via RGMII. This patch create the needed emac and phy nodes. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 18 ++ 1 file c

[PATCH v2 2/2] ARM: sun8i: bananapi-m3: Enable dwmac-sun8i

2017-11-09 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the bananapi m3 It uses an external PHY rtl8211e via RGMII. This patch create the needed emac and phy nodes. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 18 ++ 1 file c

[PATCH v2 1/2] ARM: sun8i: a83t: add dwmac-sun8i device node

2017-11-09 Thread Corentin Labbe
The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. This patch add support for it on the Allwinner a83t SoC Device-tree. This patch add the emac device node and the related RGMII pins node. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Reviewed-by: C

[PATCH v2 0/2] Add dwmac-sun8i on A83T DT

2017-11-09 Thread Corentin Labbe
Hello This patch series add some device node for dwmac-sun8i on A83T. Changes since v1: - reworked commit log of patch #1 - added comment on drive strength Corentin Labbe (2): ARM: sun8i: a83t: add dwmac-sun8i device node ARM: sun8i: bananapi-m3: Enable dwmac-sun8i arch/arm/boot/dts/sun8i

Re: [PATCH v2 2/2] ARM: sun8i: bananapi-m3: Enable dwmac-sun8i

2017-11-09 Thread Corentin Labbe
On Fri, Nov 10, 2017 at 11:48:11AM +0800, Chen-Yu Tsai wrote: > On Thu, Nov 9, 2017 at 4:29 PM, Corentin Labbe > <clabbe.montj...@gmail.com> wrote: > > The dwmac-sun8i hardware is present on the bananapi m3 > > It uses an external PHY rtl8211e via RGMII. > > > &g

Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver

2017-11-08 Thread Corentin Labbe
On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote: > On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe > <clabbe.montj...@gmail.com> wrote: > > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. > > This patch enable the dwmac-sun8i on the A

Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver

2017-11-08 Thread Corentin Labbe
On Wed, Nov 08, 2017 at 08:48:58AM +0100, Maxime Ripard wrote: > On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote: > > On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe > > <clabbe.montj...@gmail.com> wrote: > > > The dwmac-sun8i is an ethernet MAC har

Re: [PATCH RFC 0/4] crypto: engine - Permit to enqueue all async requests

2017-12-07 Thread Corentin Labbe
pe that this proposal is fine for > Herbert too. > Thanks for your test, I hope other maintainer will test it also. Regards Corentin Labbe

Re: [PATCH RFC 1/4] crypto: engine - Permit to enqueue all async requests

2017-12-07 Thread Corentin Labbe
On Wed, Dec 06, 2017 at 11:02:23AM +, Fabien DESSENNE wrote: > > > On 29/11/17 09:41, Corentin Labbe wrote: > > The crypto engine could actually only enqueue hash and ablkcipher request. > > This patch permit it to enqueue any type of crypto_async_request. > >

[PATCH] ARM: dts: sun8i-h3: Remove allwinner,leds-active-low for non internal PHY

2017-12-07 Thread Corentin Labbe
allwinner,leds-active-low have effect only on boards which us the internal PHY. So this patch remove it from all boards which do not use the internal PHY. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 1 - arch/arm/boot/dts

Re: [PATCH 0/4] Sunxi: Add SMP support on A83T

2017-12-11 Thread Corentin Labbe
On Mon, Dec 11, 2017 at 08:49:57AM +0100, Mylène Josserand wrote: > Hello everyone, > > This series adds SMP support for Allwinner Sun8i-a83t > with MCPM (Multi-Cluster Power Management). > Series information: > - Based on last linux-next (next-20171211) > - Had dependencies on Chen

[PATCH 3/4] usb: xhci: Fix build warning

2017-10-25 Thread Corentin Labbe
This patch fix the following build warning: drivers/usb/host/xhci-ring.c:1895:19: warning: variable 'urb_priv' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe <cla...@baylibre.com> --- drivers/usb/host/xhci-ring.c | 2 -- 1 file changed, 2 deletions(-) diff

<    3   4   5   6   7   8   9   10   11   12   >