Re: [PATCH] drivers: char: ipmi: Replaced kmalloc and strcpy with kstrdup

2013-03-18 Thread Corey Minyard
n -ENOMEM; } - strcpy(entry->name, name); file = proc_create_data(name, 0, smi->proc_dir, proc_ops, data); if (!file) { Looks good to me. Acked-by: Corey Minyard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] drivers: char: ipmi: Replaced kmalloc and strcpy with kstrdup

2013-03-18 Thread Corey Minyard
On 03/16/2013 09:16 AM, Alexandru Gheorghiu wrote: Replaced calls to kmalloc followed by strcpy with a sincle call to kstrdup. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu --- drivers/char/ipmi/ipmi_msghandler.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: Linux IPMI subsystem hang

2013-03-18 Thread Corey Minyard
On 03/15/2013 01:57 PM, Daniel Kahn Gillmor wrote: On Tue 2013-03-12 22:23:37 -0400, Daniel Kahn Gillmor wrote: I am working with a Lenovo ThinkCentre M78, model 4865-A14, and it seems to have trouble with the IPMI subsystem. udev seems to hang for about 3 minutes at startup, ultimately failin

[PATCH 2/8] IPMI: Change device node ordering to reflect probe order

2008-02-13 Thread Corey Minyard
PROTECTED]> Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> --- --- linux-2.6.24.orig/drivers/firmware/dmi_scan.c 2008-01-30 11:21:55.0 -0800 +++ linux-2.6.24/drivers/firmware/dmi_scan.c2008-01-30 11:18:05.0 -0800 @@ -219,7 +219,7 @@ static void __init dm

[PATCH 7/8] IPMI: convert locked counters to atomics

2008-02-13 Thread Corey Minyard
From: Konstantin Baydarov <[EMAIL PROTECTED]> Atomics are a lot more efficient and neat than using a lock. Signed-off-by: Konstantin Baydarov <[EMAIL PROTECTED]> Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> --- Index: linux-2.6.24/drivers/char/ipmi

[PATCH 6/8] IPMI: Update driver version

2008-02-13 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Enough bug fixes and changes that we need a new driver version. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.23/drivers/char/ipmi/ipmi_msghandler.c === ---

[PATCH 1/8] IPMI: Hold ATTN until upper layer ready

2008-02-13 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Hold handling of ATTN until the upper layer has reported that it is ready. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Cc: Patrick Schoeller <[EMAIL PROTECTED]> --- Index: linux-2.6.24/drivers/char/i

[PATCH 3/8] IPMI: Run to completion fixes

2008-02-13 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> The "run_to_completion" mode was somewhat broken. Locks need to be avoided in run_to_completion mode, and it shouldn't be used by normal users, just internally for panic situations. This patch removes locks in run_to_completion mode

[PATCH 4/8] IPMI: Don't grab locks in run-to-completion mode

2008-02-13 Thread Corey Minyard
From: Konstantin Baydarov <[EMAIL PROTECTED]> This patch prevents deadlocks in IPMI panic handler caused by msg_lock in smi_info structure and waiting_msgs_lock in ipmi_smi structure. Signed-off-by: Konstantin Baydarov <[EMAIL PROTECTED]> Signed-off-by: Corey Minyard <[

[PATCH 5/8] IPMI: Don't print event queue full on every event

2008-02-13 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Don't print out that the event queue is full on every event, only print something out when it becomes full or becomes not full. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> --- Index: linux-2.6.23/drivers/char/ipmi/

[PATCH 8/8] IPMI: Convert locked counters to atomics in the system interface

2008-02-13 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Atomics are faster and neater than locked counters. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> --- Index: linux-2.6.24/drivers/char/ipmi/ipmi_si_intf.c === --- linux-2.6.24.

Re: [PATCH 7/8] IPMI: convert locked counters to atomics

2008-02-13 Thread Corey Minyard
Andrew Morton wrote: The code forgot to initialise all of these. It just so happens that the all-bits-zero pattern works correctly for all current architectures, so the code should work OK. But there is no reason (I hope) why an architecture cannot implement atomic_t as struct atomic_t {

Re: [PATCH 3/8] IPMI: Run to completion fixes

2008-02-13 Thread Corey Minyard
Andrew Morton wrote: On Wed, 13 Feb 2008 10:23:42 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: From: Corey Minyard <[EMAIL PROTECTED]> The "run_to_completion" mode was somewhat broken. Locks need to be avoided in run_to_completion mode, and it shouldn't be

Re: [PATCH 6/8] IPMI: Update driver version

2008-02-14 Thread Corey Minyard
Andrew Morton wrote: On Wed, 13 Feb 2008 10:30:48 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: Enough bug fixes and changes that we need a new driver version. Are none of them serious enough to warrant a 2.6.24.x backport? No, nothing really terribly urgent. Just minor

[PATCH 3/4] IPMI: convert locked counters to atomics

2008-02-14 Thread Corey Minyard
From: Konstantin Baydarov <[EMAIL PROTECTED]> Atomics are a lot more efficient and neat than using a lock. Signed-off-by: Konstantin Baydarov <[EMAIL PROTECTED]> Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> --- Index: linux-2.6.24/drivers/char/ipmi

[PATCH 1/4] IPMI: Change barrier to cpu_relax in poweroff code

2008-02-14 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Change a barrier to cpu_relax(), which is more appropriate for a polling loop. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> --- Index: linux-2.6.24/drivers/char/ipmi/ipm

[PATCH 4/4] IPMI: Convert locked counters to atomics in the system interface

2008-02-14 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Atomics are faster and neater than locked counters. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> --- Index: linux-2.6.24/drivers/char/ipmi/ipmi_si_intf.c === --- linux-2.6.24.

[PATCH 2/4] IPMI: Remove unnecessary memory barriers

2008-02-14 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Remove some unnecessary barriers. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> --- This can be folded into ipmi-dont-grab-locks-in-run-to-completion-mode.patch Index: linux-2.6.24/drivers/char/ipmi/ipmi_

Re: [PATCH 3/4] IPMI: convert locked counters to atomics

2008-02-14 Thread Corey Minyard
Andrew Morton wrote: + for (i = 0; i < IPMI_NUM_STATS; i++) + atomic_set(&intf->stats[i], 0); And this is why it would be very hard for any architecture to ever implement atomic_t as struct atomic_t { int counter; spinlock_t lock; }; The interface assu

Re: [Openipmi-developer] [PATCH 3/4] IPMI: convert locked counters to atomics

2008-02-15 Thread Corey Minyard
Peter Zijlstra wrote: On Thu, 2008-02-14 at 12:30 -0600, Corey Minyard wrote: +/* The command didn't have anyone waiting for it. */ +#define IPMI_STAT_unhandled_commands 23 + +/* Invalid data in an event. */ +#define IPMI_STAT_invalid_events

[PATCH 1/5] IPMI: convert message handler defines to an enum

2008-02-15 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Convert the #defines for statistics into an enum in the IPMI message handler. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Cc: Peter Zijlstra <[EMAIL PROTECTED]> --- Ok to merge into ipmi-convert-locked-counters-to-atomics.patch I

[PATCH 2/5] IPMI: Convert system interface defines to an enum

2008-02-15 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Convert the #defines for statistics into an enum in the IPMI system interface and remove the unused timeout_restart statistic. And comment what these statistics mean. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Cc: Peter Zijlstra <[

[Patch 3/5] IPMI: Style fixes in the base code

2008-02-15 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Lots of style fixes for the base IPMI driver. No functional changes. Basically fixes everything reported by checkpatch and fixes the comment style. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Patch is too big for the list, per the Submit

[Patch 4/5] IPMI: Style fixes in the system interface code

2008-02-15 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Lots of style fixes for the IPMI system interface driver. No functional changes. Basically fixes everything reported by checkpatch and fixes the comment style. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Cc: Rocky Craig <[EMAIL

[Patch 5/5] IPMI: Style fixes in the misc code

2008-02-15 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Lots of style fixes for the miscellaneous IPMI files. No functional changes. Basically fixes everything reported by checkpatch and fixes the comment style. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Patch is too big for the l

Re: [PATCH 1/2] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-09-20 Thread Corey Minyard
On 09/20/2012 08:26 PM, Matthew Garrett wrote: On Thu, Sep 20, 2012 at 08:19:48PM -0500, Corey Minyard wrote: On 09/20/2012 04:46 PM, Matthew Garrett wrote: Drivers may make calls that require the ACPI IPMI driver to have been initialised already, so make sure that it appears earlier in the

Re: [PATCH 4/5] IPMI: Fix some uninitialized warning

2012-10-26 Thread Corey Minyard
On 10/22/2012 06:49 PM, Andrew Morton wrote: On Tue, 16 Oct 2012 15:53:39 -0500 miny...@acm.org wrote: From: Corey Minyard There was a spot where the compiler couldn't tell some variables would be set. So initialize them to make the warning go away. Signed-off-by: Corey Mi

Re: [patch v2] ipmi: info leak in compat_ipmi_ioctl()

2013-05-31 Thread Corey Minyard
On 05/31/2013 07:46 AM, Dan Carpenter wrote: On x86_64 there is a 4 byte hole between ->recv_type and ->addr. Got it, in my tree now. Thanks. Signed-off-by: Dan Carpenter --- v2: fixed the changelog a little. Also added LKML because the openipmi is a moderated list (and the moderator thou

Re: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-25 Thread Corey Minyard
On 07/25/2013 07:06 AM, Rafael J. Wysocki wrote: On Thursday, July 25, 2013 03:09:35 AM Zheng, Lv wrote: -stable according to the previous conversation. From: Rafael J. Wysocki [mailto:r...@sisk.pl] Sent: Thursday, July 25, 2013 7:38 AM On Tuesday, July 23, 2013 04:09:15 PM Lv Zheng wrote: T

Re: [PATCH 03/13] ACPI/IPMI: Fix race caused by the unprotected ACPI IPMI transfers

2013-07-25 Thread Corey Minyard
On 07/25/2013 07:16 PM, Zheng, Lv wrote: If I understand this correctly, the problem would be if: rem_time = wait_for_completion_timeout(&tx_msg->tx_complete, IPMI_TIMEOUT); returns on a timeout, then checks msg_done and races with something setting ms

Re: [PATCH] ipmi: ipmi_devintf: compat_ioctl method failes to take ipmi_mutex

2013-05-16 Thread Corey Minyard
Yes, you are right. I've pulled this in to my tree. Looking at this, ipmi_mutex really should go away and be replaced bu something that scales better, but I guess it's not that critical for IPMI. -corey On 05/13/2013 02:39 PM, Benjamin LaHaise wrote: When a 32 bit version of ipmitool is use

[PATCH 3/4] ipmi: Improve error messages on failed irq enable

2013-05-16 Thread Corey Minyard
When the interrupt enable message returns an error, the messages are not entirely accurate nor helpful. So improve them. Signed-off-by: Corey Minyard Cc: Andy Lutomirski --- drivers/char/ipmi/ipmi_si_intf.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git

[PATCH 1/4] drivers: char: ipmi: Replaced kmalloc and strcpy with kstrdup

2013-05-16 Thread Corey Minyard
From: Alexandru Gheorghiu Replaced calls to kmalloc followed by strcpy with a sincle call to kstrdup. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu Signed-off-by: Corey Minyard --- drivers/char/ipmi/ipmi_msghandler.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH 0/4] ipmi: Some minor fixes

2013-05-16 Thread Corey Minyard
Some minor fixes I had queued up. The last one came in recently (patch 4) and it and patch 2 are candidates for stable-kernel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kern

[PATCH 2/4] drivers/char/ipmi: memcpy, need additional 2 bytes to avoid memory overflow

2013-05-16 Thread Corey Minyard
quot;if (msg_len < 3 || msg_len > IPMI_MAX_MSG_LENGTH)" for operating: "memcpy(data + 2, bt->read_data + 4, msg_len - 2)" Signed-off-by: Chen Gang Signed-off-by: Corey Minyard Cc: sta...@vger.kernel.org --- drivers/char/ipmi/ipmi_bt_sm.c |4 ++-- 1 file changed, 2 insert

[PATCH 4/4] ipmi: ipmi_devintf: compat_ioctl method fails to take ipmi_mutex

2013-05-16 Thread Corey Minyard
ipmi_mutex to fix this. Signed-off-by: Benjamin LaHaise Signed-off-by: Corey Minyard Cc: sta...@vger.kernel.org --- drivers/char/ipmi/ipmi_devintf.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c

Re: [PATCH 3/4] ipmi: Improve error messages on failed irq enable

2013-05-16 Thread Corey Minyard
On 05/16/2013 05:23 PM, Andy Lutomirski wrote: /* We got the flags from the SMI, now handle them. */ smi_info->handlers->get_result(smi_info->si_sm, msg, 4); - if (msg[2] != 0) - dev_warn(smi_info->dev, "Could not enable inter

Re: [PATCH] drivers/char/ipmi: memcpy, need additional 2 bytes to avoid memory overflow

2013-03-29 Thread Corey Minyard
Yes, this is correct, I've pulled it into my tree. -corey On 03/29/2013 02:18 AM, Chen Gang wrote: when calling memcpy, read_data and write_data need additional 2 bytes. write_data: for checking: "if (size > IPMI_MAX_MSG_LENGTH)" for operating: "memcpy(bt->write_data + 3, data

Re: [PATCH] CRIS: Fix I/O macros

2012-08-04 Thread Corey Minyard
Can we get something like this in? It would fix a lot of build regressions. -corey On 07/09/2012 03:22 PM, miny...@acm.org wrote: From: Corey Minyard The inb/outb macros for CRIS are broken from a number of points of view, missing () around parameters and they have an unprotected if

Re: [PATCH 1/2] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-09-20 Thread Corey Minyard
On 09/20/2012 04:46 PM, Matthew Garrett wrote: Drivers may make calls that require the ACPI IPMI driver to have been initialised already, so make sure that it appears earlier in the build order. The IPMI driver uses the ACPI namespace as an option to know the address and characteristics of the

Re: [Openipmi-developer] [PATCH 3/4] IPMI: convert locked counters to atomics

2008-02-20 Thread Corey Minyard
Matt Domsch wrote: On Thu, Feb 14, 2008 at 12:30:51PM -0600, Corey Minyard wrote: From: Konstantin Baydarov <[EMAIL PROTECTED]> Atomics are a lot more efficient and neat than using a lock. per_cpu variables are a lot more efficient and neat than using locks for simple statistic

Re: [PATCH] Move console redirect to pid namespace

2013-02-14 Thread Corey Minyard
On 02/13/2013 01:08 PM, Eric W. Biederman wrote: Bruno Prémont writes: CCing containers list On Fri, 08 February 2013 miny...@acm.org wrote: From: Corey Minyard The console redirect - ioctl(fd, TIOCCONS) - is not in a namespace, thus a container can do a redirect and grab all the I/O on

Re: [PATCH] Move console redirect to pid namespace

2013-02-15 Thread Corey Minyard
On 02/14/2013 10:23 PM, Eric W. Biederman wrote: With recent changes this is tied to the initial user namespace. So the simple solution to this and so many other similiar security problems is to run your container in a user namespace. The permission check currently is capable(CAP_SYS_ADMIN) w

Re: [PATCH] ipmi: add new kernel options to prevent automatic ipmi init

2012-12-13 Thread Corey Minyard
Well, the built-in driver works on systems that have more than one interface and more than one BMC, and multiple IPMBs (and all of the other channel types for that matter, and the driver handles all the multiplexing and nasty addressing). There is, in fact, no arbitrary limit, and IBM tested this

Re: [PATCH] ipmi: add new kernel options to prevent automatic ipmi init

2012-12-14 Thread Corey Minyard
On 12/14/2012 10:25 AM, Evans, Robert wrote: Corey, Thanks for the thoughtful reply. Below I respond in detail to these three points. 1) Why building a variant kernel with ipmi_si as a module is not feasible. 2) User mode access to IPMI on Stratus systems (e.g. ipmitool). 3) ipmi_si hot

Re: [PATCH] namespace: Add an identifier to the namespace file

2012-09-26 Thread Corey Minyard
On 09/26/2012 07:48 PM, Eric W. Biederman wrote: > I have fixed up Serge's email address and the linux-kernel email > address. > > Corey Minyard writes: > >> On 09/26/2012 07:16 PM, Eric W. Biederman wrote: >>> miny...@acm.org writes: >>> >

Re: [PATCH] PM / IPMI: Remove empty legacy PCI PM callbacks

2012-07-06 Thread Corey Minyard
Looks fine to me. Acked-by: Corey Minyard On 07/06/2012 03:02 PM, Rafael J. Wysocki wrote: From: Rafael J. Wysocki The legacy PM callbacks provided by the IPMI PCI driver are empty routines returning 0, so they can be safely dropped. Signed-off-by: Rafael J. Wysocki --- drivers/char

Better precision in rusage and virtual itimers?

2000-11-13 Thread Corey Minyard
I've looked through the scheduling code and searched pretty much everywhere I could think of and I've found nothing on this, so it's time to escalate :-). The measurement of CPU usage and virtual itimers is crude at best. It's actually possible to set a relatively short virtual itimer (say, 50ms)

Problem autonegotiation with tulip driver?

2000-11-13 Thread Corey Minyard
In the current version (and may previous versions) of the tulip driver in media.c in the function tulip_select_media() with mleaf->type being 2 or 4, we have the following code: if (p[1] & 0x40) { /* SIA (CSR13-15) setup values are provided. */ csr13val = setup[0]; csr14val = s

Problem autonegotiation with tulip driver?

2000-11-13 Thread Corey Minyard
In the current version (and may previous versions) of the tulip driver in media.c in the function tulip_select_media() with mleaf->type being 2 or 4, we have the following code: if (p[1] & 0x40) { /* SIA (CSR13-15) setup values are provided. */ csr13val = setup[0]; csr14val = s

[PATCH] Make CPU usage and virtual itimers accurate

2000-11-16 Thread Corey Minyard
I have patches written to improve the accuracy of CPU measurement (getrusage()) and virtual itimers. This lets the amount of CPU used by a process be measured fairly accurately. The patches are on my web page: http://members.home.com/minyard This is if anyone is interested. I don't know if any

[PATCH] Remove redundancy from i2c-core.c

2005-04-06 Thread Corey Minyard
-blocking interface in this area. Having it in one place greatly simplifies the changes. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.12-rc1/drivers/i2c/i2c-core.c === --- linux-2.6.12-rc1.orig/drivers/i2c/i2c-

Re: [PATCH 2.6.11.6] Add power cycle to ipmi_poweroff module

2005-04-08 Thread Corey Minyard
[EMAIL PROTECTED] wrote: Below is a patch to add "power cycle" functionality to the IPMI power off module ipmi_poweroff. A new module param is added to support this: parmtype: do_power_cycle:int parm: do_power_cycle: Set to 1 to enable power cycle instead of power down. Power cycle

Re: [PATCH 2.6.11.6] Add power cycle to ipmi_poweroff module

2005-04-08 Thread Corey Minyard
s talking about what user operation causes the power cycle. It would be nice if you could tie this to reset instead of poweroff, but that's not a huge deal. It would take a while to get that infrastructure into the kernel. -Corey Thanks, -Chris Poblete -Original Message- From: Cor

Re: dmi_table counting in ipmi_si_intf.c

2005-08-09 Thread Corey Minyard
I have no idea why that value was a "1". However, looking at this, the "0" does seem correct; this is a valid patch. -Corey Vernon Mauery wrote: I am working on getting one of the IBM blades to use ipmi and have run into a problem. The driver doesn't load because it says it can't find the d

Re: [PATCH 4/5] 2.6.13-rc5-mm1, IPMI, use dmi_find_device()

2005-08-10 Thread Corey Minyard
Andrew, this patch (along with the patch 3/5) works fine for me and is an obvious improvement to the IPMI driver. You will need to remove the patch named dmi_table-counting-in-ipmi_si_intfc.patch first. Thanks, Andrey. -Corey On Wed, 2005-08-10 at 14:32 +0400, Andrey Panin wrote: > This patch r

[PATCH] Fix panic in the IPMI driver

2005-08-11 Thread Corey Minyard
y kind of message. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> drivers/char/ipmi/ipmi_msghandler.c | 107 ++-- include/linux/ipmi.h|3 - 2 files changed, 69 insertions(+), 41 deletions(-) Index: linux-2.6.13-rc5

Re: [PATCH 2.6.12.4] ACPI oops during ipmi_si driver init

2005-08-17 Thread Corey Minyard
Peter Martuccelli wrote: On Mon, 2005-08-15 at 18:13, Bjorn Helgaas wrote: On Friday 12 August 2005 1:44 pm, Peter Martuccelli wrote: Stumbled into this problem working on the ipmi_si driver. When the ipmi_si driver initialization fails the acpi_tb_get_table call, after rsdt_info has

[PATCH] IPMI driver update part 1, add per-channel IPMB addresses

2005-08-03 Thread Corey Minyard
ipmi-per-channel-slave-address.patch Description: unknown/unknown

[PATCH] IPMI driver update part 3, watchdog/NMI interaction fixes

2005-08-03 Thread Corey Minyard
ipmi_wdog_nmi_fixes.patch Description: unknown/unknown

[PATCH] IPMI driver update part 4, allow userland to include ipmi.h

2005-08-03 Thread Corey Minyard
ipmi_compiler_h_include.patch Description: unknown/unknown

[PATCH] IPMI driver update part 2, high-res timer support fixes

2005-08-03 Thread Corey Minyard
ipmi_hrt_fixes.diff Description: unknown/unknown

[PATCH] IPMI driver update part 6, clean up versioning of the IPMI driver

2005-08-03 Thread Corey Minyard
ipmi-add-module-info-tags.patch Description: unknown/unknown

[PATCH] IPMI driver update part 5, OEM flag handling and hacks for some Dell machines

2005-08-03 Thread Corey Minyard
ipmi-add-per-OEM-data-available-handlers.patch Description: unknown/unknown

Re: [PATCH] IPMI driver update part 1, add per-channel IPMB addresses

2005-08-04 Thread Corey Minyard
Andrew Morton wrote: Corey Minyard <[EMAIL PROTECTED]> wrote: ipmi-per-channel-slave-address.patch unknown/unknown (13533 bytes)] Could you fix up the mimetype, please? It makes it hard for various email clients. Dang, you switch to a new mail client and everything is s

Re: [PATCH] IPMI: driver model and sysfs support

2005-08-30 Thread Corey Minyard
This is very good. I believe the structure is correct, but I'm not a sysfs expert. There are a few things we need to deal with, though. * There are some significant changes to versioning in the driver that are in the mm tree right now (you can pull them from http://www.kernel.org/pub/linux/

Re: [RFC][CFLART] ipmi procfs bogosity

2005-09-01 Thread Corey Minyard
space pointers, it assumed that strings were NULL terminated, and it used the evil sscanf function. This adds a new function to read integers from userspace and uses this function to get the integer in question. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.13/drive

[PATCH] Add hacks for IPMI chassis poweroff for certain Dell servers

2005-09-01 Thread Corey Minyard
omsch <[EMAIL PROTECTED]> Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.13/drivers/char/ipmi/ipmi_poweroff.c === --- linux-2.6.13.orig/drivers/char/ipmi/ipmi_poweroff.c +++ linux-2.6.13/drivers/char/ipm

Re: [RFC][CFLART] ipmi procfs bogosity

2005-09-01 Thread Corey Minyard
[EMAIL PROTECTED] wrote: On Thu, Sep 01, 2005 at 11:41:42AM -0500, Corey Minyard wrote: Indeed, this function is badly written. In rewriting, I couldn't find a nice function for reading integers from userspace, and the proc_dointvec stuff didn't seem terribly suitable. So I wr

[PATCH] part 2 - remove unused fields from the IPMI driver

2005-09-01 Thread Corey Minyard
This removes the unused "all_cmd_rcvr" variable from the IPMI driver. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.13/drivers/char/ipmi/ipmi_msghandler.c === --- linux-2.6.13.orig/d

[PATCH] part 3 - Convert IPMI driver over to use refcounts

2005-09-01 Thread Corey Minyard
The IPMI driver uses read/write locks to ensure that things exist while they are in use. This is bad from a number of points of view. This patch removes the rwlocks and uses refcounts and a special synced list (the entries can be refcounted and removal is blocked while an entry is in use). dri

[PATCH] part 1 - IPMI style cleanups

2005-09-01 Thread Corey Minyard
Clean up various style issues in the IPMI driver. Should be no functional changes. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.13/drivers/char/ipmi/ipmi_poweroff.c === --- linux-2.6.13.orig/drivers/cha

Re: [RFC][CFLART] ipmi procfs bogosity

2005-09-01 Thread Corey Minyard
Andrew Morton wrote: Corey Minyard <[EMAIL PROTECTED]> wrote: Indeed, this function is badly written. In rewriting, I couldn't find a nice function for reading integers from userspace, and the proc_dointvec stuff didn't seem terribly suitable. We write numbers into

Re: [PATCH] part 3 - Convert IPMI driver over to use refcounts

2005-09-02 Thread Corey Minyard
Andrew Morton wrote: The IPMI driver uses read/write locks to ensure that things exist while they are in use. This is bad from a number of points of view. This patch removes the rwlocks and uses refcounts and a special synced list (the entries can be refcounted and removal is blocked while an

[PATCH] ARM: Ignore memory tags with invalid data

2008-01-21 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> The DNS-323 system has several bogus memory entries in the tag table, and it caused the system to crash at startup. Ignore tag entries that are obviously bogus. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> --- arch/arm/kernel/se

Re: [PATCH] ARM: Ignore memory tags with invalid data

2008-01-22 Thread Corey Minyard
Ben Dooks wrote: On Mon, Jan 21, 2008 at 10:05:56PM -0600, Corey Minyard wrote: From: Corey Minyard <[EMAIL PROTECTED]> The DNS-323 system has several bogus memory entries in the tag table, and it caused the system to crash at startup. Ignore tag entries that are obviously

Re: [Openipmi-developer] modprobing ipmi_si on Dell Power Edge 2600 make the terminal hang kernel ver. >= 2.6.20

2008-01-22 Thread Corey Minyard
Matt Domsch wrote: On Tue, Jan 22, 2008 at 06:50:31AM -0600, Matt Domsch wrote: On Mon, Jan 21, 2008 at 09:40:59AM +0800, william cheng wrote: Dear all, We got some problem on modprobing the ipmi_si module on Dell Power Edge 2600. I've asked someone to look into this.

Re: [PATCH 3/4] docs: convert kref semaphore to mutex

2007-12-21 Thread Corey Minyard
Yes, a good idea. Acked-by: Corey Minyard <[EMAIL PROTECTED]> Daniel Walker wrote: Just converting this documentation semaphore reference, since we don't want to promote semaphore usage. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- Documentatio

[PATCH] ipmi: add the standard watchdog timeout ioctls

2007-11-20 Thread Corey Minyard
From: Corey Minyard <[EMAIL PROTECTED]> Add the standard IOCTLs to the IPMI driver for setting and getting the pretimeout. Tested by Benoît Guillon. Signed off by: Corey Minyard <[EMAIL PROTECTED]> Cc: Benoît Guillon <[EMAIL PROTECTED]> --- Index: linux-2.6.23/drivers/char/ip

Re: ipmi_watchdog can not reset the kernel panic machine

2007-11-25 Thread Corey Minyard
The watchdog is "off" by default, meaning that you have to have something actually start resetting the watchdog before it will start running. That's why you are seeing this behavior. There is a start_now option that will start the watchdog when it is loaded, but then it will reset the system

[PATCH] Add sysfs support to the IPMI driver

2005-03-12 Thread Corey Minyard
rface. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.11-mm1/drivers/char/ipmi/ipmi_devintf.c === --- linux-2.6.11-mm1.orig/drivers/char/ipmi/ipmi_devintf.c +++ linux-2.6.11-mm1/drivers/char/ipmi/ipmi_devintf

Re: [PATCH] Add sysfs support to the IPMI driver

2005-03-13 Thread Corey Minyard
Greg KH wrote: On Sat, Mar 12, 2005 at 10:57:24PM -0600, Corey Minyard wrote: The IPMI driver has long needed to tie into the device model (and I've long been hoping someone else would do it). I finally gave up and spent the time to learn how to do it. I think this is right, it see

Re: [PATCH] Add a non-blocking interface to the I2C code, part 1

2005-03-18 Thread Corey Minyard
Greg KH wrote: On Wed, Mar 02, 2005 at 01:58:51PM -0600, Corey Minyard wrote: This patch reorganizes the I2C SMBus formatting code to make it more suitable for the upcoming non-blocking changes. You are changing too much stuff here to claim it's just a reorganization: - variable

Re: [PATCH][alpha] "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!

2005-03-23 Thread Corey Minyard
This is not the right fix. I know of IPMI hardware on ppc and xscale systems. There should be nothing general in the driver that limits it to x86/ia64. pm_power_off is defined in linux/pm.h. Shouldn't it be available everywhere? -Corey Ivan Kokshaysky wrote: On Tue, Mar 22, 2005 at 04:53:12

[PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file

2005-03-23 Thread Corey Minyard
ndant code that was in all three functions. This is important for the non-blocking interfaces because they will have to handle a non-blocking interface in this area. Having it in one place greatly simplifies the changes. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.11-

[PATCH] I2C Part 2 - Break up the formatting code into individual functions

2005-03-23 Thread Corey Minyard
. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.11-mm1/drivers/i2c/i2c-core.c === --- linux-2.6.11-mm1.orig/drivers/i2c/i2c-core.c +++ linux-2.6.11-mm1/drivers/i2c/i2c-core.c @@ -1038,25 +10

[PATCH] I2C Part 3 - Add an operation queue data structure

2005-03-23 Thread Corey Minyard
This patch adds an operation queue structure and converts over the passing around of data to use the operation queue. The op queue entry will be used for queueing in the non-blocking case. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.11-mm1/drivers/i2c/i2c-

[PATCH] Update to IPMI driver to support old DMI spec

2005-02-09 Thread Corey Minyard
the newer versions for the IPMI configuration information. This patch handles the differences between the two. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.11-rc3/drivers/char/ipmi/ipmi_si_intf.c === ---

[PATCH] Fix IPMI SMBus driver to select the I2C layer instead of depend on it

2005-02-09 Thread Corey Minyard
This is on top of the IPMI SMBus driver in the current mm kernel. Thanks, -Corey Make the IPMI SMBus select I2C, not depend on it, so I2C gets enabled properly when the IPMI SMBus is enabled. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.11-rc3/drivers/char/ipmi/K

Re: [PATCH] Update to IPMI driver to support old DMI spec

2005-02-09 Thread Corey Minyard
Bukie Mabayoje wrote: Corey Minyard wrote: BTW, I'm also working with the person who had the trouble with the I2C non-blocking driver updates, but we haven't figured it out yet. Hopefully soon. (Though that has nothing to do with this patch.) Than

Re: Fw: [Bug 4171] New: bttv seems broken here

2005-02-10 Thread Corey Minyard
when I try to access the bttv device : The I2C non-blocking patch would incorrectly return success in some cases because it wasn't updating the proper result variable. This patch fixes the problem. The bttv driver now works properly with the I2C non-blocking patch. Signed-off-by: Cor

Re: 2.6.11-rc3-mm2

2005-02-10 Thread Corey Minyard
Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc3/2.6.11-rc3-mm2/ - Added the mlock and !SCHED_OTHER Linux Security Module for the audio guys. It seems that nothing else is going to come along and this is completely encapsulated. - Various other stuff.

[PATCH] Fix IPMI LAN bridging

2005-02-11 Thread Corey Minyard
The size of LAN bridged messages was not being returned properly from the function that calculated address sizes. This fixes the problem. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.11-rc3/drivers/char/ipmi/ipmi_msghan

Re: Adding an async I2C interface

2005-01-27 Thread Corey Minyard
proper errno values. However, I've only fixed the core code and the drivers I've worked on. Thanks, -Corey Corey Minyard wrote: I have an IPMI interface driver that sits on top of the I2C code. I'd like to get it into the mainstream kernel, but I have a few problems to solve

Re: Adding an async I2C interface

2005-01-28 Thread Corey Minyard
Bukie Mabayoje wrote: I will be glad to work with on this, I have some exposure to the BMC. See text below in blue. bukie Corey Minyard wrote: Mark Studebaker wrote: > is there a way to do this solely in i2c-core without having to > add support to all the drivers? Yes and no. In or

[PATCH] Add a non-blocking I2C interface

2005-01-28 Thread Corey Minyard
Here's the code that I have so far for adding a non-blocking interface to the I2C interface. I've debated whether to do this as a patch or just post the files, because the patch is about half the size of the files. I've decided on the diff for now, it seems to be fairly readable. This is rel

[PATCH] Updates for the i801 driver to support the I2C non-blocking interface

2005-01-28 Thread Corey Minyard
Here's the changes required for the i801 driver. See the previous post for the patch to add a non-blocking interface to the I2C driver. Like the core I2C changes, this is mostly breaking the functions into smaller pieces and calling them from the appropriate places. -Corey Index: linux-2.6.11-

[PATCH] Changes to the I2C driver to support a non-blocking interface

2005-02-01 Thread Corey Minyard
under moderate to heavy load. The changes are rather extensive, but are mostly reorganization and the addition of the async interface. This also adds back in the i2c_smbus_read_block_data() function which is needed by the IPMI SMB driver (coming soon). Signed-off-by: Corey Minyard <[EM

[PATCH] Minor IPMI enhancements

2005-02-01 Thread Corey Minyard
. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.11-rc2/drivers/char/ipmi/ipmi_si_intf.c === --- linux-2.6.11-rc2.orig/drivers/char/ipmi/ipmi_si_intf.c +++ linux-2.6.11-rc2/drivers/char/ipmi/ipmi_si_intf.c @@ -176,6

[PATCH] Modify the i801 I2C driver to use the non-blocking interface.

2005-02-01 Thread Corey Minyard
I just posted my proposed non-blocking changes to the i2c driver. This is the changes for the i801 driver. This patch modifies the I801 SMBus driver to use the non-blocking interface. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.11-rc2/drivers/i2c/busses/i2c-

  1   2   3   4   5   6   7   >