On 06/02/2014 09:01 AM, Alexei Starovoitov wrote:
This patch set splits BPF out of core networking into generic component
patch #1 splits filter.c into two logical pieces: generic BPF core and socket
filters. It only moves functions around. No real changes.
patch #2 adds hidden CONFIG_BPF that
On 06/17/2014 04:24 AM, Guenter Roeck wrote:
mips:allmodconfig fails in 3.16-rc1 with lots of undefined symbols.
arch/mips/net/bpf_jit.c: In function 'is_load_to_a':
arch/mips/net/bpf_jit.c:559:7: error: 'BPF_S_LD_W_LEN' undeclared (first use in
this function)
arch/mips/net/bpf_jit.c:559:7:
On 06/17/2014 10:20 AM, Daniel Borkmann wrote:
On 06/17/2014 04:24 AM, Guenter Roeck wrote:
mips:allmodconfig fails in 3.16-rc1 with lots of undefined symbols.
arch/mips/net/bpf_jit.c: In function 'is_load_to_a':
arch/mips/net/bpf_jit.c:559:7: error: 'BPF_S_LD_W_LEN' undeclared (first use
On 06/17/2014 12:39 PM, Guenter Roeck wrote:
On 06/17/2014 03:16 AM, Daniel Borkmann wrote:
On 06/17/2014 10:20 AM, Daniel Borkmann wrote:
On 06/17/2014 04:24 AM, Guenter Roeck wrote:
mips:allmodconfig fails in 3.16-rc1 with lots of undefined symbols.
arch/mips/net/bpf_jit.c: In function
On 06/17/2014 12:54 PM, Markos Chandras wrote:
...
This fixes the build and seems to work ok (tried with dhcp and tcpdump).
Thanks for fixing it.
Reviewed-by: Markos Chandras markos.chand...@imgtec.com
Tested-by: Markos Chandras markos.chand...@imgtec.com
Great, thanks for your help!
--
To
On 06/17/2014 01:09 PM, Markos Chandras wrote:
...
Thanks for these instructions. I will try them myself once I find some
time since I don't think bpf_jit for MIPS has ever been tested with all
the opcodes.
Sounds great! If you find some tests are missing, please feel free to
submit them as
On 06/02/2014 05:41 PM, Alexei Starovoitov wrote:
...
Glad you brought up this point :)
100% agree that current double verification done by seccomp is far from
being generic and quite hard to maintain, since any change done to
classic BPF verifier needs to be thought through from
On 06/02/2014 06:48 PM, Alexei Starovoitov wrote:
extending cc-list, since I think this thread is related to bpf split thread.
On Mon, Jun 2, 2014 at 5:36 AM, Daniel Borkmann dbork...@redhat.com wrote:
On 05/30/2014 07:12 PM, Chema Gonzalez wrote:
On Thu, May 29, 2014 at 4:54 PM, Daniel
On 06/02/2014 09:02 PM, Alexei Starovoitov wrote:
...
Classic has all sorts of hard coded assumptions. The whole
concept of 'load from magic constant' to mean different things
is flawed. We all got used to it and now think that it's normal
for ld_abs -4056 to mean a ^= x
I think everyone knows
On 06/03/2014 05:44 PM, Alexei Starovoitov wrote:
...
All of your points are valid. They are right questions to ask. I just
don't see why you're still arguing about first step of filter.c split,
whereas your concerns are about steps 2, 3, 4.
Fair enough, lets keep them in mind though for
On 06/03/2014 11:12 PM, Chema Gonzalez wrote:
...
Your approach needs it too. Citing from your pseudo-code:
ld #5 -- indicates to fill the first 5 slots of M[], so M[0] to M[4]
ld #keys -- triggers the extension to fill the M[] slots
ld M[0] -- loads nhoff from M[0] into accu
How does
Sorry for the late answer, this slipped somehow through ...
I think you might want to cc Andrew Morton a...@linux-foundation.org
to let this go via akpm's tree for misc changes, perhaps?
The work from my side went via Dave's net-next tree as it had some
follow-up SCTP work that depended on
On 06/04/2014 08:32 PM, George Spelvin wrote:
Thanks for the nitpicks!
I think you might want to cc Andrew Morton a...@linux-foundation.org
to let this go via akpm's tree for misc changes, perhaps?
I don't care, but akpm is fine by me. I'll send out a v2 after I resolve
one minor point with
On 01/22/2014 08:29 AM, Steven Noonan wrote:
On Wed, Jan 22, 2014 at 12:02:15AM -0500, Konrad Rzeszutek Wilk wrote:
On Tue, Jan 21, 2014 at 07:20:45PM -0800, Steven Noonan wrote:
On Tue, Jan 21, 2014 at 06:47:07PM -0800, Linus Torvalds wrote:
On Tue, Jan 21, 2014 at 5:49 PM, Greg
On 01/22/2014 04:11 PM, Dan Ballard wrote:
Provides a new option for setsockopt SO_MAX_DGRAM_QLEN that sets and
gets a socket specific max datagram queue length. Currently each socket
has one but it's only ever initialized from
/proc/sys/net/unix/max_dgram_qlen and then never adjustable later.
On 01/07/2014 02:54 AM, Stephen Rothwell wrote:
Hi Gustavo,
Today's linux-next merge of the bluetooth tree got a conflict in
net/ieee802154/6lowpan.c between commit 965801e1eb62 (net: 6lowpan: fix
lowpan_header_create non-compression memcpy call) from the tree and
commit 8df8c56a5abc (6lowpan:
[keeping netdev in loop as well]
On 01/15/2014 03:27 PM, Vlastimil Babka wrote:
On 01/13/2014 12:39 PM, Daniel Borkmann wrote:
On 01/13/2014 11:16 AM, Vlastimil Babka wrote:
On 01/11/2014 02:32 PM, Daniel Borkmann wrote:
On 01/11/2014 07:22 AM, Andrew Morton wrote:
On Fri, 10 Jan 2014 19:23
Set is on top of Eric's BPF fix, that is:
http://patchwork.ozlabs.org/patch/311163/
Daniel Borkmann (1):
random32: add prandom_u32_lt_N and convert misuses of reciprocal_divide
Hannes Frederic Sowa (1):
reciprocal_divide: correction/update of the algorithm
drivers/net/bonding
eric.duma...@gmail.com
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org
Signed-off-by: Daniel Borkmann dbork...@redhat.com
---
drivers/net/team/team_mode_random.c | 8 +---
include/linux/random.h | 19 ++-
include/net/codel.h
to normal divide.
Joint work with Daniel Borkmann.
[1] http://www.wireshark.org/~darkjames/reciprocal-buggy.c
[2] http://www.wireshark.org/~darkjames/set-and-dump-filter-k-bug.c
[3] https://gmplib.org/~tege/division-paper.pdf
[4] http://homepage.cs.uiowa.edu/~jones/bcd/divide.html
[5] http
On 01/16/2014 01:29 AM, Joe Perches wrote:
On Thu, 2014-01-16 at 00:23 +0100, Daniel Borkmann wrote:
Many functions have open coded a function that return a random
number in range [0,N-1]. Also, only because we have a function
that is named reciprocal_divide(), it has not much to do
On 01/16/2014 04:14 AM, Eric Dumazet wrote:
On Thu, 2014-01-16 at 00:23 +0100, Daniel Borkmann wrote:
@@ -1220,7 +1219,7 @@ static unsigned int fanout_demux_hash(struct
packet_fanout *f,
struct sk_buff *skb,
unsigned
On 01/17/2014 10:52 AM, David Laight wrote:
From: Hannes Frederic Sowa
...
+/**
+ * trim - perform a reciprocal multiplication in order to clamp a
+ *value into range [0, ep_ro), where the upper interval
+ *endpoint is right-open. This is useful, e.g. for accessing
+ *a
On 01/18/2014 02:08 AM, Li Zefan wrote:
Cc: Daniel Borkmann dbork...@redhat.com
On 2014/1/18 2:11, Tejun Heo wrote:
net_cls and net_prio are the only cgroups which are allowed to be
built as modules. The savings from allowing the two controllers to be
built as modules are tiny especially
On 01/18/2014 04:10 PM, Tejun Heo wrote:
Hey,
On Sat, Jan 18, 2014 at 09:08:49AM +0800, Li Zefan wrote:
Cc: Daniel Borkmann dbork...@redhat.com
On 2014/1/18 2:11, Tejun Heo wrote:
net_cls and net_prio are the only cgroups which are allowed to be
built as modules. The savings from allowing
On 01/18/2014 04:28 PM, Tejun Heo wrote:
On Sat, Jan 18, 2014 at 04:26:24PM +0100, Daniel Borkmann wrote:
Unless there's gonna be another rc, I think it's already a bit too
late for 3.14 anyway. I'll drop the net_cls part and rebase the
changes on top of rc1 later on.
I think that's 1 patch
eric.duma...@gmail.com
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org
Signed-off-by: Daniel Borkmann dbork...@redhat.com
---
drivers/net/team/team_mode_random.c | 8 +---
include/linux/random.h | 18 +-
net/packet
-by: Daniel Borkmann dbork...@redhat.com
---
include/linux/kernel.h | 19 +++
include/net/codel.h| 4 +---
net/packet/af_packet.c | 3 +--
3 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index ecb8754..7afdbd2 100644
work with Daniel Borkmann.
[1] http://www.wireshark.org/~darkjames/reciprocal-buggy.c
[2] http://www.wireshark.org/~darkjames/set-and-dump-filter-k-bug.c
[3] https://gmplib.org/~tege/division-paper.pdf
[4] http://homepage.cs.uiowa.edu/~jones/bcd/divide.html
[5] http://citeseerx.ist.psu.edu
On 12/19/2013 02:15 AM, Fengguang Wu wrote:
CC the list.
On Thu, Dec 19, 2013 at 09:08:34AM +0800, Wanlong Gao wrote:
/git/linux/lib/hash.c: In function 'hashlib_init':
/git/linux/lib/hash.c:35:2: warning: passing argument 1 of
'setup_arch_fast_hash' from incompatible pointer type [enabled by
On 01/27/2014 07:17 PM, Josh Boyer wrote:
Hi All,
When building perf on ARM, we get a build failure because it can't
find #include asm/hash.h from the linux/hash.h file:
gcc -o builtin-kvm.o -c -Wbad-function-cast
-Wdeclaration-after-statement -Wformat-security -Wformat-y2k
-Winit-self
On 12/12/2013 06:54 PM, Nicolas Dichtel wrote:
...
Is it possible to trace that this comes from the DPDK?
At least in the commit log, like it was done in the v1.
Hm, that got lost; but we can put that back into the commit log.
In any case, we properly included the header comment, of course.
Borkmann.
References: http://thread.gmane.org/gmane.linux.kernel/1665858
Signed-off-by: Alexei Starovoitov a...@plumgrid.com
Signed-off-by: Daniel Borkmann dbork...@redhat.com
Cc: Hagen Paul Pfeifer ha...@jauu.net
Cc: Kees Cook keesc...@chromium.org
Cc: Paul Moore pmo...@redhat.com
Cc: Ingo Molnar mi
.
Joint work with Daniel Borkmann.
References: http://thread.gmane.org/gmane.linux.kernel/1665858
Signed-off-by: Alexei Starovoitov a...@plumgrid.com
Signed-off-by: Daniel Borkmann dbork...@redhat.com
Cc: Hagen Paul Pfeifer ha...@jauu.net
Cc: Kees Cook keesc...@chromium.org
Cc: Paul Moore pmo
On 03/26/2014 06:12 PM, Sasha Levin wrote:
Commit 4af712e8df (random32: add prandom_reseed_late() and call when
nonblocking pool becomes initialized) has added a late reseed stage
that happens as soon as the nonblocking pool is marked as initialized.
This fails in the case that the nonblocking
On 03/27/2014 12:35 AM, Sasha Levin wrote:
On 03/26/2014 07:18 PM, Daniel Borkmann wrote:
On 03/26/2014 06:12 PM, Sasha Levin wrote:
Commit 4af712e8df (random32: add prandom_reseed_late() and call when
nonblocking pool becomes initialized) has added a late reseed stage
that happens as soon
.
Signed-off-by: Sasha Levin sasha.le...@oracle.com
Looks better now, thanks!
Fixes: 4af712e8df99 (random32: add prandom_reseed_late() and call when nonblocking
pool becomes initialized)
Acked-by: Daniel Borkmann dbork...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe
On 03/27/2014 03:21 AM, Hannes Frederic Sowa wrote:
On Wed, Mar 26, 2014 at 07:35:01PM -0400, Sasha Levin wrote:
On 03/26/2014 07:18 PM, Daniel Borkmann wrote:
On 03/26/2014 06:12 PM, Sasha Levin wrote:
Commit 4af712e8df (random32: add prandom_reseed_late() and call when
nonblocking pool
On 03/27/2014 10:18 AM, Hannes Frederic Sowa wrote:
On Thu, Mar 27, 2014 at 10:04:03AM +0100, Daniel Borkmann wrote:
On 03/27/2014 03:21 AM, Hannes Frederic Sowa wrote:
On Wed, Mar 26, 2014 at 07:35:01PM -0400, Sasha Levin wrote:
On 03/26/2014 07:18 PM, Daniel Borkmann wrote:
On 03/26/2014
with Daniel Borkmann.
Signed-off-by: Alexei Starovoitov a...@plumgrid.com
Signed-off-by: Daniel Borkmann dbork...@redhat.com
Cc: Hagen Paul Pfeifer ha...@jauu.net
Cc: Kees Cook keesc...@chromium.org
Cc: Paul Moore pmo...@redhat.com
Cc: Ingo Molnar mi...@kernel.org
Cc: H. Peter Anvin h
On 04/06/2014 01:55 PM, Sergei Trofimovich wrote:
From: Sergei Trofimovich sly...@gentoo.org
gcc complains as:
drivers/net/ethernet/ti/cpts.c: In function 'cpts_match':
drivers/net/ethernet/ti/cpts.c:266:12: error: 'ETH_HLEN' undeclared (first
use in this function)
On 04/06/2014 07:34 PM, Vincent Stehlé wrote:
The ETH_HLEN and VLAN_HLEN definitions are not in if.h any more. Add the
necessary includes to fix the following compilation errors:
drivers/net/ethernet/ti/cpts.c: In function ‘cpts_match’:
drivers/net/ethernet/ti/cpts.c:266:12: error:
[Kelly, please also cc netdev]
On 04/07/2014 07:56 AM, Cong Wang wrote:
On Thu, Apr 3, 2014 at 9:24 AM, Cong Wang xiyou.wangc...@gmail.com wrote:
On Wed, Apr 2, 2014 at 7:24 AM, Kelly Anderson ke...@xilka.com wrote:
Hi,
I hit a kernel oops when starting traffic control on my armv7 router, I
On 04/07/2014 07:19 PM, Cong Wang wrote:
On Mon, Apr 7, 2014 at 10:10 AM, Ken O'Brien k...@kenobrien.org wrote:
Ok, so then, is there a way to read per process network statistics in the proc
filesystem?
AFAIK, we only have per-socket and per-netdev statistics, there is no
per-process one,
On 04/14/2014 05:11 PM, Ingo Molnar wrote:
* Jovi Zhangwei jovi.zhang...@gmail.com wrote:
Obviously many people love ktap nowadays even though it's not a
C-family language, [...]
Imagine how much more widespread it would become amongst kernel
developers if it had C syntax - see PeterZ's
/0x3b0
[8107bb6b] SyS_prctl+0x3bb/0x4a0
[8152ef2d] system_call_fastpath+0x1a/0x1f
[] 0x
Reported-by: Masami Ichikawa masami...@gmail.com
Signed-off-by: Kees Cook keesc...@chromium.org
Cc: sta...@vger.kernel.org
Acked-by: Daniel Borkmann
-by: Daniel Borkmann dbork...@redhat.com
Signed-off-by: Alexei Starovoitov a...@plumgrid.com
Cc: Linus Torvalds torva...@linux-foundation.org
Cc: Eric Paris epa...@redhat.com
Cc: James Morris james.l.mor...@oracle.com
Cc: Kees Cook keesc...@chromium.org
---
Dave, do you want to pick this up?
kernel
On 03/31/2014 09:17 AM, Ingo Molnar wrote:
...
2) better BPF integration with networking:
[PATCH net-next v3 8/9] net: filter: rework/optimize internal BPF
interpreter's instruction set
[ ... v4 is now queued in net-next tree btw ]
--
To unsubscribe from this list: send the line
.
Signed-off-by: Daniel Borkmann dbork...@redhat.com
CC: linux-kernel@vger.kernel.org
---
v1-v2:
- Added documentation into printk-formats.txt, thanks Vlad Yasevich
- Changed %pig/%pIg into %piS/%pIS, thanks Joe Perches
- Changed braces/indent in pointer(), thanks Joe Perches
- Also CC lkml
than just SCTP in the kernel to make
use of this extension as well.
[1] http://patchwork.ozlabs.org/patch/31480/
Signed-off-by: Daniel Borkmann dbork...@redhat.com
CC: Joe Perches j...@perches.com
CC: linux-kernel@vger.kernel.org
---
v1-v2:
- Added documentation into printk-formats.txt
This might have been an oversight, as '4' is needed as %pI4/%pi4
are format specifiers and [hnbl] are extensions of it.
Signed-off-by: Daniel Borkmann dbork...@redhat.com
CC: Joe Perches j...@perches.com
---
Documentation/printk-formats.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 06/28/2013 05:44 PM, Joe Perches wrote:
On Fri, 2013-06-28 at 14:05 +0200, Daniel Borkmann wrote:
In order to avoid making code that deals with printing both, IPv4 and
IPv6 addresses, unnecessary complicated as for example ...
Thanks Daniel, seems sensible. Just trivial comments...
Ok
On 06/28/2013 05:53 PM, Daniel Borkmann wrote:
On 06/28/2013 05:44 PM, Joe Perches wrote:
On Fri, 2013-06-28 at 14:05 +0200, Daniel Borkmann wrote:
In order to avoid making code that deals with printing both, IPv4 and
IPv6 addresses, unnecessary complicated as for example ...
Thanks Daniel
On 06/28/2013 06:04 PM, Joe Perches wrote:
On Fri, 2013-06-28 at 17:53 +0200, Daniel Borkmann wrote:
On 06/28/2013 05:44 PM, Joe Perches wrote:
On Fri, 2013-06-28 at 14:05 +0200, Daniel Borkmann wrote:
In order to avoid making code that deals with printing both, IPv4 and
IPv6 addresses
than just SCTP in the kernel to make
use of this extension as well.
[1] http://patchwork.ozlabs.org/patch/31480/
Signed-off-by: Daniel Borkmann dbork...@redhat.com
CC: Joe Perches j...@perches.com
CC: linux-kernel@vger.kernel.org
---
v1-v2:
- Added documentation into printk-formats.txt
On 06/20/2014 11:56 PM, Chema Gonzalez wrote:
...
Anyway as I said before I'm not excited about either.
I don't think we should be adding classic BPF extensions any more.
The long term headache of supporting classic BPF extensions
outweighs the short term benefits.
I see a couple of issues
On 06/23/2014 11:57 PM, Alexei Starovoitov wrote:
On Fri, Jun 20, 2014 at 9:44 AM, Chema Gonzalez ch...@google.com wrote:
...
- nop: I'd like to have a nop. Do I know why? Nope.
nope. Let's not add unnecessary instructions.
A valid nop is a useful instruction: padding, filling up arrays
On 06/18/2014 10:29 PM, David Rientjes wrote:
On Wed, 18 Jun 2014, Jet Chen wrote:
Hi Daniel,
FYI, we noticed the below changes on
commit b58537a1f5629bdc98a8b9dc2051ce0e952f6b4b (net: sctp: fix permissions
for rto_alpha and rto_beta knobs)
There's no way this is legitimate, that commit
: rework/optimize internal BPF interpreter's
instruction set)
Signed-off-by: Kees Cook keesc...@chromium.org
Acked-by: Daniel Borkmann dbork...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
On 06/18/2014 10:41 PM, David Rientjes wrote:
On Wed, 18 Jun 2014, Daniel Borkmann wrote:
One assumption could be that netperf was setting this knob
internally and ignoring the result of it (error/success), but
that we might need to look up in netperf source to confirm.
Confirmed netperf
Hi Kees,
On 06/19/2014 01:28 AM, Kees Cook wrote:
On Wed, Jun 18, 2014 at 4:19 PM, Alexei Starovoitov a...@plumgrid.com wrote:
On Wed, Jun 18, 2014 at 3:55 PM, Kees Cook keesc...@chromium.org wrote:
On Wed, Jun 18, 2014 at 3:48 PM, Alexei Starovoitov a...@plumgrid.com wrote:
On Wed, Jun 18,
On 06/20/2014 06:48 PM, Kees Cook wrote:
...
Are there any plans to put and extend test cases from [1] via user space
side into the kernel self-test directory, i.e. into something like
tools/testing/selftests/seccomp/ so that in future new tests can be added
or run from there? Might be worth to
So almost a month passed, and I don't want this to get lost
somewhere. I have applied the feedback given at that time to
this set, rebased plus tested it against latest net-next. I
decided to route this via netdev as it improves performance
upon library code that provides library bits for SCTP,
From: George Spelvin li...@horizon.com
In case they help the compiler.
Signed-off-by: George Spelvin li...@horizon.com
Signed-off-by: Daniel Borkmann dbork...@redhat.com
---
include/linux/crc32.h | 6 +++---
lib/crc32.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff
From: George Spelvin li...@horizon.com
So it gets discarded after the selftest.
Signed-off-by: George Spelvin li...@horizon.com
Signed-off-by: Daniel Borkmann dbork...@redhat.com
---
lib/crc32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/crc32.c b/lib/crc32.c
is done in inline wrappers.
Signed-off-by: George Spelvin li...@horizon.com
Signed-off-by: Daniel Borkmann dbork...@redhat.com
---
include/linux/crc32.h | 14 -
lib/crc32.c | 147 --
2 files changed, 82 insertions(+), 79 deletions(-)
diff
On 07/23/2014 08:11 AM, Varka Bhadram wrote:
On 07/23/2014 11:31 AM, Alexei Starovoitov wrote:
BPF is used in several kernel components. This split creates logical boundary
between generic eBPF core and the rest
kernel/bpf/core.c: eBPF interpreter
net/core/filter.c: classic-eBPF converter,
On 06/26/2014 12:00 AM, Chema Gonzalez wrote:
...
There's still the problem of whether we want to obsolete classic BPF
in the kernel before the tools (libpcap mainly) accept eBPF. This can
take a lot.
Finally, what's the user's CLI interface you have in mind? Right now,
tcpdump expressions are
On 07/01/2014 01:09 AM, Kees Cook wrote:
On Fri, Jun 27, 2014 at 5:05 PM, Alexei Starovoitov a...@plumgrid.com wrote:
Hi All,
this patch set demonstrates the potential of eBPF.
First patch net: filter: split filter.c into two files splits eBPF interpreter
out of networking into kernel/bpf/.
On 06/28/2014 02:06 AM, Alexei Starovoitov wrote:
Safety of eBPF programs is statically determined by the verifier, which detects:
- loops
- out of range jumps
- unreachable instructions
- invalid instructions
- uninitialized register access
- uninitialized stack access
- misaligned stack access
On 06/28/2014 02:06 AM, Alexei Starovoitov wrote:
User interface:
cat bpf_123 /sys/kernel/debug/tracing/__event__/filter
where 123 is an id of the eBPF program priorly loaded.
__event__ is static tracepoint event.
(kprobe events will be supported in the future patches)
eBPF programs can call
Hi Zi,
On 07/03/2014 09:52 AM, Zi Shen Lim wrote:
load_pointer() is already a static inline function.
Let's move it into filter.h so BPF JIT implementations can reuse this
function.
Signed-off-by: Zi Shen Lim zlim@gmail.com
---
This patch is based on discussion with Alexei in the context
On 07/03/2014 11:14 AM, Will Deacon wrote:
On Wed, Jul 02, 2014 at 06:20:24AM +0100, Zi Shen Lim wrote:
The JIT compiler emits A64 instructions. It supports eBPF only.
Legacy BPF is supported thanks to conversion by BPF core.
JIT is enabled in the same way as for other architectures:
zlim@gmail.com
Reviewed-by: Daniel Borkmann dbork...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
On 12/19/2013 07:36 PM, Haiyang Zhang wrote:
Thank you for the suggestions! I will re-write the send queue selection, enhance
the hash calculation, also fix the initialization sequence.
Btw, Toeplitz hash function should either go into lib/hash.c as well or
include/linux/hash.h to avoid
Hi Alexei,
On 02/06/2014 02:10 AM, Alexei Starovoitov wrote:
Hi All,
this patch set addresses main sticking points of the previous discussion:
http://thread.gmane.org/gmane.linux.kernel/1605783
Main difference:
. all components are now in one place
tools/bpf/llvm - standalone LLVM backend
On 07/16/2014 08:41 AM, Gleb Natapov wrote:
On Tue, Jul 15, 2014 at 07:48:06PM -0700, Andy Lutomirski wrote:
virtio-rng is both too complicated and insufficient for initial rng
seeding. It's far too complicated to use for KASLR or any other
early boot random number needs. It also provides
On 07/17/2014 12:59 AM, H. Peter Anvin wrote:
On 07/16/2014 03:40 PM, Andy Lutomirski wrote:
On Wed, Jul 16, 2014 at 3:13 PM, Andy Lutomirski l...@amacapital.net wrote:
My personal preference is to defer this until some user shows up. I
think that even this would be too complicated for KASLR,
On 08/25/2014 02:13 PM, Rasmus Villemoes wrote:
A 9+ years old comment in hash_64 says that gcc can't optimize
multiplication by GOLDEN_RATIO_PRIME_64. Well, compilers get smarter
and CPUs get faster all the time, so it is perhaps about time to
revisit that assumption.
Seems fine by me, but
...@hotmail.co.uk
Signed-off-by: Daniel Borkmann dbork...@redhat.com
Cc: Hannes Frederic Sowa han...@stressinduktion.org
Cc: Alexey Dobriyan adobri...@gmail.com
---
drivers/char/random.c | 8
include/linux/string.h | 5 +++--
lib/string.c | 16
3 files changed, 23
On 08/25/2014 10:35 PM, Alexey Dobriyan wrote:
On Mon, Aug 25, 2014 at 10:01:39PM +0200, Daniel Borkmann wrote:
+void memzero_explicit(void *s, size_t count)
+{
+ memset(s, 0, count);
+ OPTIMIZER_HIDE_VAR(s);
+}
BSD seems to name it explicit_bzero().
Sure, that's what I wrote
On 08/26/2014 09:46 AM, Ingo Molnar wrote:
* Alexei Starovoitov a...@plumgrid.com wrote:
On Mon, Aug 25, 2014 at 8:52 PM, Stephen Hemminger
step...@networkplumber.org wrote:
Per discussion at Kernel Summit. Every new syscall requires
a manual page and test programs. We have had too many new
In prandom we have already reseeding mechanisms that trigger
periodically from a much better entropy source than just
feeding in jiffies through lpfc_mbx_cmpl_fcf_scan_read_fcf_rec()
[what a function name 8-)]. Therefore, just remove this.
Signed-off-by: Daniel Borkmann dbork...@redhat.com
Cc
khandelwal.deepak.1...@gmail.com
Suggested-by: Vlad Yasevich vyasev...@gmail.com
Suggested-by: Michael Tuexen tue...@fh-muenster.de
Suggested-by: Daniel Borkmann dbork...@redhat.com
Signed-off-by: Zhu Yanjun yanjun@windriver.com
Looks a bit better, thanks!
Acked-by: Daniel Borkmann dbork...@redhat.com
On 08/12/2014 02:57 AM, Alexei Starovoitov wrote:
On Mon, Aug 11, 2014 at 3:00 PM, Benjamin Lee lee...@linux.vnet.ibm.com wrote:
I wanted to know what the current status of my patch is since my
internship will be ending this Friday and I want to know before then. if
there are any problems with
On 08/13/2014 09:57 AM, Alexei Starovoitov wrote:
add BPF_LD_IMM64 instruction to load 64-bit immediate value into register.
All previous instructions were 8-byte. This is first 16-byte instruction.
Two consecutive 'struct bpf_insn' blocks are interpreted as single instruction:
insn[0/1].code =
On 08/13/2014 07:34 PM, Alexei Starovoitov wrote:
On Wed, Aug 13, 2014 at 2:17 AM, Daniel Borkmann dbork...@redhat.com wrote:
On 08/13/2014 09:57 AM, Alexei Starovoitov wrote:
add BPF_LD_IMM64 instruction to load 64-bit immediate value into register.
All previous instructions were 8-byte
On 07/24/2014 11:26 PM, Alexei Starovoitov wrote:
eBPF is used by socket filtering, seccomp and soon by tracing and
exposed to userspace, therefore 'sock_filter_int' name is not accurate.
Rename it to 'bpf_insn'
Signed-off-by: Alexei Starovoitov a...@plumgrid.com
---
...
#define
On 07/25/2014 01:26 AM, Alexei Starovoitov wrote:
...
you mean to align last \ with other lines?
sure. good point.
Yeah, would be good. Otherwise looks good, of course.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
[ also Cc'ing Willem, Pablo ]
On 07/25/2014 10:04 AM, Alexei Starovoitov wrote:
'sk_filter' name is used as 'struct sk_filter', function sk_filter() and
as variable 'sk_filter', which makes code hard to read.
Also it's easily confused with 'struct sock_filter'
Rename 'struct sk_filter' to
On 07/25/2014 01:54 PM, Pablo Neira Ayuso wrote:
On Fri, Jul 25, 2014 at 01:25:35PM +0200, Daniel Borkmann wrote:
[ also Cc'ing Willem, Pablo ]
On 07/25/2014 10:04 AM, Alexei Starovoitov wrote:
'sk_filter' name is used as 'struct sk_filter', function sk_filter() and
as variable 'sk_filter
On 08/15/2014 11:27 AM, Zhu Yanjun wrote:
When a failed probe comes along UNCONFIRMED path, it is not necessary
to send SCTP_PEER_ADDR_CHANGE notification.
I do not find this in the RFC, but it seems reasonable - at least, I would
have liked to see a more elaborate commit message from you
On 08/19/2014 10:15 AM, Sitsofe Wheeler wrote:
After a variety of issues on Hyper-V (host is running Windows 2012 R2) I
updated to the latest kernel (3.17-rc1
7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9), turned on a bunch of kernel
validation options and booted which has resulted in a BUG being
to just have a single term for each.
Anyway, the rest looks good to me, thanks.
I am totally fine of having it under EXPERT for now for the reasons
mentioned above. This can still be lifted later on.
Acked-by: Daniel Borkmann dbork...@redhat.com
--
To unsubscribe from this list: send the line
On 10/20/2014 03:58 PM, Andrey Ryabinin wrote:
On 10/20/2014 04:49 PM, Theodore Ts'o wrote:
On Mon, Oct 20, 2014 at 03:03:22PM +0400, Andrey Ryabinin wrote:
Hi, Theodore.
I've got this while booting kernel with ubsan:
[0.00]
Hi Mikulas,
On 09/05/2014 06:01 PM, Mikulas Patocka wrote:
This patch fixes false positive kmemcheck warning in bpf.
When we try to write the variable len, the compiler generates a code that
reads the 32-bit word, modifies the bits belonging to len and writes the
32-bit word back. The reading
On 09/05/2014 07:00 PM, Hannes Frederic Sowa wrote:
On Fr, 2014-09-05 at 18:20 +0200, Daniel Borkmann wrote:
Hi Mikulas,
On 09/05/2014 06:01 PM, Mikulas Patocka wrote:
This patch fixes false positive kmemcheck warning in bpf.
When we try to write the variable len, the compiler generates
On 09/05/2014 07:13 PM, Mikulas Patocka wrote:
On Fri, 5 Sep 2014, Daniel Borkmann wrote:
On 09/05/2014 07:00 PM, Hannes Frederic Sowa wrote:
On Fr, 2014-09-05 at 18:20 +0200, Daniel Borkmann wrote:
Hi Mikulas,
On 09/05/2014 06:01 PM, Mikulas Patocka wrote:
This patch fixes false positive
On 09/05/2014 07:21 PM, Alexei Starovoitov wrote:
...
imo it's cleaner to convert to bool unconditionally instead
of annotating things everywhere.
Will do, fine as well.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
On 08/27/2014 09:18 PM, Stephen Hemminger wrote:
Something in man page format similar to FreeBSD man page:
http://www.freebsd.org/cgi/man.cgi?bpf(4)
would be more readable and reviewable.
I think at some point, we could perhaps do a section 7 page
with a general overview of the engine and
101 - 200 of 2268 matches
Mail list logo
