Re: [PATCH 07/11] writeback: periodically trim the writeback list

2013-07-31 Thread Dave Chinner
On Wed, Jul 31, 2013 at 05:15:42PM +0200, Jan Kara wrote: > On Wed 31-07-13 14:15:46, Dave Chinner wrote: > > From: Dave Chinner > > > > Inodes are removed lazily from the bdi writeback list, so in the > > absence of sync(2) work inodes will build up on the bdi writbac

Re: [PATCH 00/11] Sync and VFS scalability improvements

2013-07-31 Thread Dave Chinner
On Wed, Jul 31, 2013 at 08:48:40AM +0200, Sedat Dilek wrote: > On Wed, Jul 31, 2013 at 6:15 AM, Dave Chinner wrote: > > Hi folks, > > > > This series of patches is against the curent mmotm tree here: > > > > http://git.cmpxchg.org/cgit/linux-mmotm.git/ > &g

Re: [PATCH 08/11] inode: convert per-sb inode list to a list_lru

2013-08-01 Thread Dave Chinner
don't care for how it's named, located or used - I just want to be able to use the infrastructure it provides. As such renaming and relocating it is not something I'm about to do in this specific patchset Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this l

Re: [PATCH 02/11] inode: add IOP_NOTHASHED to avoid inode hash lock in evict

2013-08-01 Thread Dave Chinner
On Thu, Aug 01, 2013 at 01:12:35AM -0700, Christoph Hellwig wrote: > On Wed, Jul 31, 2013 at 02:15:41PM +1000, Dave Chinner wrote: > > From: Dave Chinner > > > > Some filesystems don't use the VFS inode hash and fake the fact they > > are hashed so that all th

Re: [PATCH 1/3] fs: Introduce new flag FALLOC_FL_COLLAPSE_RANGE

2013-08-01 Thread Dave Chinner
On Thu, Aug 01, 2013 at 02:07:39PM +0900, Namjae Jeon wrote: > 2013/8/1, Dave Chinner : > > On Wed, Jul 31, 2013 at 11:42:00PM +0900, Namjae Jeon wrote: > >> From: Namjae Jeon > >> > >> Fallocate now supports new FALLOC_FL_COLLAPSE_RANGE flag. > >> The

Re: [PATCH 2/3] xfs: Implement FALLOC_FL_COLLAPSE_RANGE

2013-08-01 Thread Dave Chinner
http://oss.sgi.com/archives/xfs/2012-12/msg00124.html Yeah, probably makes sense to do this. I'll have a look at porting it forwards to my current tree as xfs_vnodeops.c has gone away in that series... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list:

Re: [PATCH 2/3] xfs: Implement FALLOC_FL_COLLAPSE_RANGE

2013-08-01 Thread Dave Chinner
On Thu, Aug 01, 2013 at 02:33:09PM +0900, Namjae Jeon wrote: > 2013/8/1, Dave Chinner : > > On Wed, Jul 31, 2013 at 11:42:14PM +0900, Namjae Jeon wrote: > >> From: Namjae Jeon > >> > >> New fallocate flag FALLOC_FL_COLLAPSE_RANGE implementation for XFS.

Re: [RFC/PATCH 0/2] ext4: Transparent Decompression Support

2013-08-04 Thread Dave Chinner
s functionality in robust manner to the VFS And, like all compression formats in the kernel, they last about 3 months before someone comes up with some fancy new one that is 1% faster or smaller at something, and we end up with a proliferation of different supported compression formats. What

Re: [PATCH v3 3/5] mm: Notify filesystems when it's time to apply a deferred cmtime update

2013-08-20 Thread Dave Chinner
writepages call will update the timestamp. Oh, I missed that - I thought you were setting AS_CMTIME during .page_mkwrite. Setting it in clear_page_dirty_for_io() is too late for filesystems to include it in their existing transactions during .writepage, (at least for XFs and ext4) because they do

Re: [PATCH v3 3/5] mm: Notify filesystems when it's time to apply a deferred cmtime update

2013-08-20 Thread Dave Chinner
On Tue, Aug 20, 2013 at 02:54:01PM -0700, Andy Lutomirski wrote: > On Tue, Aug 20, 2013 at 2:48 PM, Dave Chinner wrote: > > On Tue, Aug 20, 2013 at 09:42:34AM -0700, Andy Lutomirski wrote: > >> On Tue, Aug 20, 2013 at 9:00 AM, Jan Kara wrote: > >> > On Mon 19-0

Re: [PATCH v3 3/5] mm: Notify filesystems when it's time to apply a deferred cmtime update

2013-08-20 Thread Dave Chinner
On Tue, Aug 20, 2013 at 05:47:10PM -0700, Andy Lutomirski wrote: > On Tue, Aug 20, 2013 at 3:43 PM, Dave Chinner wrote: > > On Tue, Aug 20, 2013 at 02:54:01PM -0700, Andy Lutomirski wrote: > >> On Tue, Aug 20, 2013 at 2:48 PM, Dave Chinner wrote: > >> > On Tue, Au

Re: splice vs execve lockdep trace.

2013-07-18 Thread Dave Chinner
On Thu, Jul 18, 2013 at 05:21:17PM -0500, Ben Myers wrote: > Dave, > > On Thu, Jul 18, 2013 at 04:16:32PM -0500, Ben Myers wrote: > > On Thu, Jul 18, 2013 at 01:42:03PM +1000, Dave Chinner wrote: > > > On Wed, Jul 17, 2013 at 05:17:36PM -0700, Linus Torvalds wrote: > &g

Re: Linux 3.11-rc2

2013-07-21 Thread Dave Chinner
. Other filesystems will be more efficient, but because they have more scalable/complex orphan inode handling it's going to take longer to implement O_TMPFILE support for them Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscr

Re: Recvfile patch used for Samba.

2013-07-23 Thread Dave Chinner
ds? I'll stop there. This is fundamentally broken. It's an attempt to do a multi-page write operation without any of the supporting structures needed to handle the failure cases properly. The nested page locking has "deadlock" written all over it, and the lack of partial

Re: Recvfile patch used for Samba.

2013-07-23 Thread Dave Chinner
On Tue, Jul 23, 2013 at 02:58:58PM -0700, Jeremy Allison wrote: > On Tue, Jul 23, 2013 at 05:10:27PM +1000, Dave Chinner wrote: > > So, we are nesting up to 32 page locks here. That's bad. And we are > > nesting kmap() calls for all the pages individually - is that even > &g

Re: Linux 3.11-rc2

2013-07-23 Thread Dave Chinner
On Mon, Jul 22, 2013 at 05:06:01AM +0100, Al Viro wrote: > On Mon, Jul 22, 2013 at 11:25:17AM +1000, Dave Chinner wrote: > > > I'll just point out that it can make the whole thing worse, too. > > For example, for ext3/4, the tmpfile being created has to be added > > t

Re: XFS: Assertion failed: xfs_dir2_sf_lookup(args) == ENOENT, file: fs/xfs/xfs_dir2_sf.c, line: 358

2013-07-24 Thread Dave Chinner
-[ cut here ] I just reproduced this by chance. I know exactly what I was doing when it went bang, so I might be able to reduce it from scattergun blast testing to be able to reproduce it on demand. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list

Re: [PATCH] xfs: fix an assertion failure

2013-07-25 Thread Dave Chinner
- is probably doing the wrong this. i.e. that it assumes that a clean buffer item is only referenced in this transaction and so it can unconditionally free it. That's an invalid assumption, and exactly the situation that the above assert was designed to catch. Can you try the patch below? It s

Re: [PATCH] xfs: introduce object readahead to log recovery

2013-07-25 Thread Dave Chinner
y_safe(item, next, &trans->r_itemq, ri_list) { case XLOG_RECOVER_PASS2: if (ra_qdepth++ >= MAX_QDEPTH) { recover_items(log, trans, &buffer_list, &ra_item_list); ra_qdept

Re: Recvfile patch used for Samba.

2013-07-25 Thread Dave Chinner
On Thu, Jul 25, 2013 at 09:17:01AM +0100, Steven Whitehouse wrote: > Hi, > > On Wed, 2013-07-24 at 12:47 +1000, Dave Chinner wrote: > > On Tue, Jul 23, 2013 at 02:58:58PM -0700, Jeremy Allison wrote: > > > Having said that the OEMs that are using it does > > > f

Re: [PATCH] xfs: introduce object readahead to log recovery

2013-07-26 Thread Dave Chinner
On Fri, Jul 26, 2013 at 02:36:15PM +0800, Zhi Yong Wu wrote: > Dave, > > All comments are good to me, and will be applied to next version, thanks a > lot. > > On Fri, Jul 26, 2013 at 10:50 AM, Dave Chinner wrote: > > On Thu, Jul 25, 2013 at 04:23:39PM +0800, zw

Re: [PATCH] xfs: fix an assertion failure

2013-07-26 Thread Dave Chinner
take an event trace with trace-cmd and attach the output of the report? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.k

Re: [PATCH V8 27/33] xfs: add support for read_iter and write_iter

2013-07-26 Thread Dave Chinner
On Thu, Jul 25, 2013 at 12:50:53PM -0500, Dave Kleikamp wrote: > Signed-off-by: Dave Kleikamp > Cc: Ben Myers > Cc: Alex Elder > Cc: x...@oss.sgi.com Looks fine. Acked-by: Dave Chinner -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "

Re: [PATCH v3] xfs: introduce object readahead to log recovery

2013-08-13 Thread Dave Chinner
do not need to be there, and the "out:" label moved to above the call to xlog_recover_free_trans() so the main loop does the right thing when an error occurs. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH v3] xfs: introduce object readahead to log recovery

2013-08-13 Thread Dave Chinner
On Wed, Aug 14, 2013 at 01:59:02PM +0800, Zhi Yong Wu wrote: > On Wed, Aug 14, 2013 at 1:35 PM, Dave Chinner wrote: > > On Wed, Jul 31, 2013 at 04:42:45PM +0800, zwu.ker...@gmail.com wrote: > >> From: Zhi Yong Wu > >> > >> It can take a long time to run

Re: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign()

2013-03-04 Thread Dave Chinner
don't care to look any further because the problem is of your own making. In future, please check first that the bug you are reporting is reproducable on a current upstream kernel and userspace. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the

Re: xfs_efi_item slab corruption. (v3.9-10936-g51a26ae)

2013-05-11 Thread Dave Chinner
On Sat, May 11, 2013 at 04:09:40PM +0400, Dmitry Monakhov wrote: > On Tue, 7 May 2013 09:37:07 -0400, Dave Jones wrote: > > started compiling a kernel, and then... > > > I've bisected this one. > commit 666d644cd72a9ec58b353209ff191d7430f3b357 > Author: Dave Chinner

Re: Tux3 Report: Faster than tmpfs, what?

2013-05-13 Thread Dave Chinner
On Fri, May 10, 2013 at 02:47:35PM +0900, OGAWA Hirofumi wrote: > Dave Chinner writes: > > >> tux3: > >> Operation CountAvgLatMaxLat > >> > >> NTCreateX1477980 0.00312.

Re: [RFC v0 0/4] sys_copy_range() rough draft

2013-05-14 Thread Dave Chinner
7;t the easiest "support all filesystems" hack just be to add a destination offset parameter to do_splice_direct() and call that when the filesystem doesn't supply a ->copy_range method? i.e. use the mechanisms we already have for copying from one file to another via the p

Re: [RFC v0 0/4] sys_copy_range() rough draft

2013-05-14 Thread Dave Chinner
On Tue, May 14, 2013 at 03:04:40PM -0700, Zach Brown wrote: > On Wed, May 15, 2013 at 07:42:51AM +1000, Dave Chinner wrote: > > On Tue, May 14, 2013 at 02:15:22PM -0700, Zach Brown wrote: > > > I'm going to keep hacking away at this. My next step is to get ext4 >

Re: [PATCH v4 05/20] xfs: use ->invalidatepage() length argument

2013-05-15 Thread Dave Chinner
On Tue, May 14, 2013 at 06:37:19PM +0200, Lukas Czerner wrote: > ->invalidatepage() aop now accepts range to invalidate so we can make > use of it in xfs_vm_invalidatepage() > > Signed-off-by: Lukas Czerner > Reviewed-by: Ben Myers > Cc: x...@oss.sgi.com Acked-by: Da

Re: [RFC PATCH 1/2] mm: vmscan: let any negative return value from shrinker mean error

2013-05-15 Thread Dave Chinner
. Just what is the shrinker infrastructure supposed to do with a random error code? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: high-speed disk I/O is CPU-bound?

2013-05-15 Thread Dave Chinner
two hardware RAID > devices does not deliver any improved performance for > single-threaded writes. (Have not thoroughly tested this > configuration fully with multiple writers, though.) Of course not - you are CPU bound and nothing you do to the storage will change that. Cheers, D

Re: [PATCH] mm: vmscan: handle any negative return value from scan_objects

2013-05-16 Thread Dave Chinner
i.e. each specific negative return value needs to have the potential for defining a different behaviour. So if any change needs to be made, it is to change the -1 return value to an enum and have the shrinkers return that enum when they want an abort. -Dave. -- Dave Chinner dchin...@redhat.com -

Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]

2013-04-08 Thread Dave Chinner
s /dev/loop0* > > Note the /dev/loop0p1 node. Run losetup -d /dev/loop0 and see if it is > still there. Jens, can we get one of these fixes merged quickly? xfstests is unusable on any kernel more recent than 3.9-rc4 because of these problems Cheers, Dave. -- Dave Chinner da...@fromor

Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]

2013-04-09 Thread Dave Chinner
On Tue, Apr 09, 2013 at 09:01:39AM +0200, Jens Axboe wrote: > On Tue, Apr 09 2013, Dave Chinner wrote: > > On Thu, Apr 04, 2013 at 04:30:54PM -0400, Phillip Susi wrote: > > > > I have not tested it yet, but I am pretty sure it won't work. It > > > > looks lik

Re: [PATCH 08/10] mm: vmscan: Have kswapd shrink slab only once per priority

2013-04-09 Thread Dave Chinner
cts and the memory > that is freed when slab objects are reclaimed that has to be taken into > account. Node awareness within the shrinker infrastructure and LRUs make the relationship much more direct ;) Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: se

Re: deadlock on vmap_area_lock

2013-05-01 Thread Dave Chinner
ny real > deadlock potential? It sure will. We've been reporting that vm_map_ram is doing GFP_KERNEL allocations from GFP_NOFS context for years, and have reported plenty of lockdep dumps as a result of it. But that's not the problem that is occurring above - lockstat is probably a good thing

Re: Tux3 Report: Faster than tmpfs, what?

2013-05-09 Thread Dave Chinner
re you'll disclose such information with your results, otherwise nobody is ever going to trust anything you say about tux3 Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the xfs tree

2013-04-28 Thread Dave Chinner
d by commit 3fe58f30b4fc ("xfs: add CRC checks for quota > blocks"). > > I have used the xfs tree from next-20130426 for today. CONFIG_XFS_QUOTA=y will fix it. Or, alternatively, apply this patch: http://oss.sgi.com/pipermail/xfs/2013-April/025434.html Cheers, Dave. -- Da

Re: Excessive stall times on ext4 in 3.9-rc2

2013-04-11 Thread Dave Chinner
ads that contain metadata with a flag, so that the > flusher thread can write them back at the same priority as reads. Ext4 is already using REQ_META for this purpose. I'm surprised that no-one has suggested "change the IO elevator" yet. Cheers, Dave. -- Dave Chinner da...@

Re: Excessive stall times on ext4 in 3.9-rc2

2013-04-12 Thread Dave Chinner
On Fri, Apr 12, 2013 at 11:19:52AM -0400, Theodore Ts'o wrote: > On Fri, Apr 12, 2013 at 02:50:42PM +1000, Dave Chinner wrote: > > > If that is the case, one possible solution that comes to mind would be > > > to mark buffer_heads that contain metadata with a flag, so tha

Re: high-speed disk I/O is CPU-bound?

2013-05-16 Thread Dave Chinner
On Thu, May 16, 2013 at 11:35:08AM -0400, David Oostdyk wrote: > On 05/16/13 07:36, Stan Hoeppner wrote: > >On 5/15/2013 7:59 PM, Dave Chinner wrote: > >>[cc xfs list, seeing as that's where all the people who use XFS in > >>these sorts of configurations hang out.

Re: [PATCH] mm: vmscan: handle any negative return value from scan_objects

2013-05-16 Thread Dave Chinner
On Thu, May 16, 2013 at 02:27:52PM +0200, Oskar Andero wrote: > On 13:52 Thu 16 May , Dave Chinner wrote: > > On Thu, May 16, 2013 at 10:42:16AM +0200, Oskar Andero wrote: > > > The shrinkers must return -1 to indicate that it is busy. Instead, treat > > >

Re: [PATCH] mm: vmscan: add BUG_ON on illegal return values from scan_objects

2013-05-21 Thread Dave Chinner
On Mon, May 20, 2013 at 11:14:27AM +0200, Oskar Andero wrote: > Add a BUG_ON to catch any illegal value from the shrinkers. This fixes a > potential bug if scan_objects returns a negative other than -1, which > would lead to undefined behaviour. > > Cc: Glauber Costa > Cc:

Re: [PATCH 0/9] Reduce system disruption due to kswapd V4

2013-05-21 Thread Dave Chinner
thread is not doing the writeback work fast enough when memory is low - can you comment on this at all, Mel? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-21 Thread Dave Chinner
to strip SUID/SGID during the truncate operation? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-in

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-21 Thread Dave Chinner
On Tue, May 21, 2013 at 07:40:16PM -0400, Dave Jones wrote: > On Wed, May 22, 2013 at 09:34:29AM +1000, Dave Chinner wrote: > > On Tue, May 21, 2013 at 06:52:57PM -0400, Dave Jones wrote: > > > [ 464.210598] XFS: Assertion failed: (mask & > (ATTR_MODE|ATT

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-21 Thread Dave Chinner
On Tue, May 21, 2013 at 08:08:03PM -0400, Dave Jones wrote: > On Wed, May 22, 2013 at 09:54:10AM +1000, Dave Chinner wrote: > > On Tue, May 21, 2013 at 07:40:16PM -0400, Dave Jones wrote: > > > On Wed, May 22, 2013 at 09:34:29AM +1000, Dave Chinner wrote: > > > >

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-21 Thread Dave Chinner
On Tue, May 21, 2013 at 10:56:05PM -0400, Dave Jones wrote: > On Wed, May 22, 2013 at 10:16:03AM +1000, Dave Chinner wrote: > > Seems like I can trigger this from paths other than truncate too.. (eg, > sys_open) O_TRUNC? > The mask is always 0xa068 though if that helps. A bi

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-21 Thread Dave Chinner
On Wed, May 22, 2013 at 12:15:21AM -0400, Dave Jones wrote: > On Wed, May 22, 2013 at 02:03:18PM +1000, Dave Chinner wrote: > > > That doesn't make a whole lot of sense to me. What am I missing? > > Are you seeing this fire at all from notify_change()? >

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-21 Thread Dave Chinner
On Wed, May 22, 2013 at 01:29:38AM -0400, Dave Jones wrote: > On Wed, May 22, 2013 at 03:12:43PM +1000, Dave Chinner wrote: > > > > [ 36.339105] XFS (sda2): xfs_setattr_size: mask 0xa068 mismatch on > file 0\xffb8\xffd3-\xff88\x\x > >

Re: 3.9.2: xfstests triggered panic

2013-05-22 Thread Dave Chinner
k overflow. > 15320.364308¨ CPU: 0 Tainted: GF W3.9.2 #1 > 15320.364309¨ Process rhts-test-runne (pid: 625, task: 3dccc890, ksp: > 0 and there you go - a stack overflow. Your kernel stack size is too small. I'd suggest that you need 16k stacks on s390 - II

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-22 Thread Dave Chinner
On Wed, May 22, 2013 at 03:51:47PM +1000, Dave Chinner wrote: > On Wed, May 22, 2013 at 01:29:38AM -0400, Dave Jones wrote: > > On Wed, May 22, 2013 at 03:12:43PM +1000, Dave Chinner wrote: > > > > > > [ 36.339105] XFS (sda2): xfs_setattr_size: mask 0xa068 mismat

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-22 Thread Dave Chinner
On Wed, May 22, 2013 at 12:19:46PM -0400, Dave Jones wrote: > On Wed, May 22, 2013 at 10:22:52AM -0400, Dave Jones wrote: > > On Wed, May 22, 2013 at 03:51:47PM +1000, Dave Chinner wrote: > > > > > > Tomorrow I'll also try running some older kernels with the

Re: 3.9.2: xfstests triggered panic

2013-05-22 Thread Dave Chinner
On Wed, May 22, 2013 at 11:16:56PM -0400, CAI Qian wrote: > - Original Message - > > From: "Dave Chinner" > > To: "CAI Qian" > > Cc: "LKML" , sta...@vger.kernel.org, > > x...@oss.sgi.com > > Sent: Wednesday, May 22, 2

Re: [PATCH 0/3 v3] dcache: make it more scalable on large system

2013-05-23 Thread Dave Chinner
er benchmarks) we can't really determine if this is a good solution or not... IOWs, you need more than one microbenchmark that interacts with some naive monitoring code to justify the complexity these locking changes introduce Cheers, Dave. -- Dave Chinner da...@fromorbit.c

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-23 Thread Dave Chinner
On Thu, May 23, 2013 at 02:49:48PM -0400, Dave Jones wrote: > On Thu, May 23, 2013 at 07:54:54AM +1000, Dave Chinner wrote: > > > Gah, I've got not idea what the hell I was smoking yesterday > > afternoon. 0x2000 is actually ATTR_FILE, and 0x8000 is ATTR_OPEN. > >

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-23 Thread Dave Chinner
On Thu, May 23, 2013 at 08:49:06PM -0400, Dave Jones wrote: > On Fri, May 24, 2013 at 08:30:38AM +1000, Dave Chinner wrote: > > > > > Which I put just before the assert that is firing on your machine. > > > > > > > > And, obviously, it isn&#

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-24 Thread Dave Chinner
On Thu, May 23, 2013 at 11:03:00PM -0400, Dave Jones wrote: > On Thu, May 23, 2013 at 09:52:19PM -0400, Dave Jones wrote: > > On Fri, May 24, 2013 at 11:26:25AM +1000, Dave Chinner wrote: > > > > > You want to print the debug output if the masked value !=

Re: [PATCH 0/3 v3] dcache: make it more scalable on large system

2013-05-26 Thread Dave Chinner
On Thu, May 23, 2013 at 05:34:23PM -0400, Waiman Long wrote: > On 05/23/2013 05:42 AM, Dave Chinner wrote: > >On Wed, May 22, 2013 at 09:37:25PM -0400, Waiman Long wrote: > >>Change log: > >> > >>v2->v3 > >> - Fix the RCU lock problem found by Al V

Re: 3.10-rc3 xfs mount/recovery failure & ext fsck hang.

2013-05-28 Thread Dave Chinner
on error If you haven't already repaired the filesystem, can you send me a metadump of the filesystem in question? > [ 40.642521] BUG: soft lockup - CPU#0 stuck for 22s! [fsck.ext2:294] I'm not sure what this has to do with the XFS problem - it's apparently stuck in invalidat

Re: 3.10-rc3 xfs mount/recovery failure & ext fsck hang.

2013-05-28 Thread Dave Chinner
On Tue, May 28, 2013 at 05:15:44PM -0400, Dave Jones wrote: > On Wed, May 29, 2013 at 07:10:12AM +1000, Dave Chinner wrote: > > On Tue, May 28, 2013 at 12:12:30PM -0400, Dave Jones wrote: > > > box crashed, and needed rebooting. On next bootup, when it found the > dirty

Re: 3.10-rc3 xfs mount/recovery failure & ext fsck hang.

2013-05-28 Thread Dave Chinner
On Tue, May 28, 2013 at 05:41:37PM -0400, Dave Jones wrote: > On Wed, May 29, 2013 at 07:32:48AM +1000, Dave Chinner wrote: > > On Tue, May 28, 2013 at 05:15:44PM -0400, Dave Jones wrote: > > > On Wed, May 29, 2013 at 07:10:12AM +1000, Dave Chinner wrote: > > > >

Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]

2013-04-02 Thread Dave Chinner
since 3.9-rc4: $ glo v3.9-rc4..HEAD -- drivers/block/loop.c c1681bf loop: prevent bdev freeing while device in use 8761a3d loop: cleanup partitions when detaching loop device 183cfb5 loop: fix error return code in loop_add() $ So this looks like someone hasn't been testing their loopback dri

Re: [PATCH 11/12] rwsem: wake all readers when first waiter is a reader

2013-03-08 Thread Dave Chinner
ly to have implicit dependencies on the barrier effect of metadata operations on data IO... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH 11/12] rwsem: wake all readers when first waiter is a reader

2013-03-10 Thread Dave Chinner
On Fri, Mar 08, 2013 at 05:20:34PM -0800, Michel Lespinasse wrote: > On Fri, Mar 8, 2013 at 4:32 PM, Dave Chinner wrote: > > On Wed, Mar 06, 2013 at 03:21:50PM -0800, Michel Lespinasse wrote: > >> When the first queued waiter is a reader, wake all readers instead of > >

Re: [PATCH 11/12] rwsem: wake all readers when first waiter is a reader

2013-03-11 Thread Dave Chinner
On Sun, Mar 10, 2013 at 10:17:42PM -0700, Michel Lespinasse wrote: > On Sun, Mar 10, 2013 at 5:16 PM, Dave Chinner wrote: > > On Fri, Mar 08, 2013 at 05:20:34PM -0800, Michel Lespinasse wrote: > >> On Fri, Mar 8, 2013 at 4:32 PM, Dave Chinner wrote: > >> > Isn&

Re: [PATCH 3/3] HWPOISON: prevent inode cache removal to keep AS_HWPOISON sticky

2012-08-23 Thread Dave Chinner
y(mapping_hwpoison(inode->i_mapping) && !newsize)) > + mapping_clear_hwpoison(inode->i_mapping); So only a truncate to zero size will clear the poison flag? What happens if it is the last page in the mapping that is poisoned, and we truncate that away? Shouldn't tha

Re: [PATCH 3/3] HWPOISON: prevent inode cache removal to keep AS_HWPOISON sticky

2012-08-23 Thread Dave Chinner
On Thu, Aug 23, 2012 at 10:39:32PM -0400, Naoya Horiguchi wrote: > On Fri, Aug 24, 2012 at 11:31:18AM +1000, Dave Chinner wrote: > > On Wed, Aug 22, 2012 at 11:17:35AM -0400, Naoya Horiguchi wrote: > > > "HWPOISON: report sticky EIO for poisoned file" still has a cor

Re: [PATCH 3/3] HWPOISON: prevent inode cache removal to keep AS_HWPOISON sticky

2012-08-26 Thread Dave Chinner
On Fri, Aug 24, 2012 at 01:24:16PM -0400, Naoya Horiguchi wrote: > On Fri, Aug 24, 2012 at 02:39:17PM +1000, Dave Chinner wrote: > > On Thu, Aug 23, 2012 at 10:39:32PM -0400, Naoya Horiguchi wrote: > > > On Fri, Aug 24, 2012 at 11:31:18AM +1000, Dave Chinner wrote: > > >

Re: [RFC v1 00/11] vfs: hot data tracking

2012-09-17 Thread Dave Chinner
ing all of this? I'm not sure that so many new files are needed - putting it all in fs/hot_tracking.[ch] might make more sense, or if all 8 fs/hot* files remain, putting them in their own subdirectory might be an idea (like quota). I'll comment on the code when I get a bit of time to

Re: [RFC v1 00/11] vfs: hot data tracking

2012-09-17 Thread Dave Chinner
On Tue, Sep 18, 2012 at 10:24:55AM +0800, Zhi Yong Wu wrote: > On Tue, Sep 18, 2012 at 5:30 AM, Dave Chinner wrote: > > On Mon, Sep 17, 2012 at 03:18:34PM +0800, zwu.ker...@gmail.com wrote: > >> 20 files changed, 2275 insertions(+), 1 deletions(-) > >> create m

Re: [RFC][PATCH] Make io_submit non-blocking

2012-07-24 Thread Dave Chinner
be effectively undefined - what happens to latencies if you generate memory pressure while the test is running? FWIW, if you are going to change generic code, you need to present results for other filesystems as well (xfs, btrfs are typical), as they may not have the same problems as ext4 or react

Re: [PATCH 3/3] writeback: add dirty_ratio_time per bdi variable (NFS write performance)

2012-08-19 Thread Dave Chinner
. > > Here lies my major concern about dirty_background_time: the write > bandwidth estimation is an _estimation_ and will sure become wildly > wrong in some cases. So the dirty_background_time implementation based > on it will not always work to the user expectations. > > One im

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-11 Thread Dave Chinner
d data quickly" Besides, seek-hole/data is still shiny new and lots of developers aren't even aware of it's presence in recent kernels. Removing new functionality saying "no-one is using it" is like smashing the egg before the chicken hatches (or is it cutting of the chicke

Re: [PATCH V5 00/30] loop: Issue O_DIRECT aio using bio_vec

2013-01-20 Thread Dave Chinner
need to limit xfstests to the aio group here. If the loop device is what you are actually testing, then you probably want to run the auto/quick groups as they will do a whole lot more than just data IO to the loop devices... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe

Re: [RFC, PATCH 00/19] Numa aware LRU lists and shrinkers

2013-01-21 Thread Dave Chinner
On Mon, Jan 21, 2013 at 08:08:53PM +0400, Glauber Costa wrote: > On 11/28/2012 03:14 AM, Dave Chinner wrote: > > [PATCH 09/19] list_lru: per-node list infrastructure > > > > This makes the generic LRU list much more scalable by changing it to > > a {list,lock,count} t

Re: [RFC, PATCH 00/19] Numa aware LRU lists and shrinkers

2013-01-23 Thread Dave Chinner
On Wed, Jan 23, 2013 at 06:36:33PM +0400, Glauber Costa wrote: > On 01/22/2013 03:21 AM, Dave Chinner wrote: > > On Mon, Jan 21, 2013 at 08:08:53PM +0400, Glauber Costa wrote: > >> On 11/28/2012 03:14 AM, Dave Chinner wrote: > >>> [PATCH 09/19] list_lru

Re: [ 68/89] xfs: fix _xfs_buf_find oops on blocks beyond the filesystem end

2013-02-13 Thread Dave Chinner
ons, please let me > > > know. > > > > > > -- > > > > > > From: Dave Chinner > > > > > > commit eb178619f930fa2ba2348de332a1ff1c66a31424 upstream. > > > > > > When _xfs_buf_find is passed an out of range add

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2013-02-13 Thread Dave Chinner
On Wed, Feb 13, 2013 at 10:13:16AM -0800, Eric W. Biederman wrote: > Joel Becker writes: > > > On Wed, Nov 21, 2012 at 10:55:24AM +1100, Dave Chinner wrote: > >> > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c > >> > index 2778258..3656b88 10

Re: [ 68/89] xfs: fix _xfs_buf_find oops on blocks beyond the filesystem end

2013-02-14 Thread Dave Chinner
gt; > > I have that rule in place for some other subsystems that don't want me > > > applying stuff that they aren't aware of, and have no problem doing the > > > same > > > thing here. > > > > > > Just let me know. Sounds like a fine

Re: [ 01/10] Revert: xfs: fix _xfs_buf_find oops on blocks beyond the filesystem end

2013-02-16 Thread Dave Chinner
e332a1ff1c66a31424 upstream. > > It has been reported to cause problems: > http://bugzilla.redhat.com/show_bug.cgi?id=909602 > > Acked-by: Ben Myers > Cc: Dave Chinner > Cc: Brian Foster > Cc: CAI Qian > Cc: Paolo Bonzini > Signed-off-by: Greg Kroah-Hartma

Re: Local DoS through write heavy I/O on CFQ & Deadline

2012-10-14 Thread Dave Chinner
sync_file+0x208/0x2d0 And postgres gets stuck there too. So what you are seeing is likely an ext4 problem, not an IO scheduler problem. Suggestion: try the same test with XFS. If the problem still exists, then it *might* be an ioscheduler problem. If it goes away, then it's an ext4 problem. Che

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-15 Thread Dave Chinner
__u32 num_writes; > + __u32 temperature; > + __u8 live; > + char filename[PATH_MAX]; Don't put the filename in the ioctl and open the file in the kernel. Have userspace open the file directly and issue the ioctl on the fd that is returned. Cheers, Dave. --

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Dave Chinner
e do not want random users to be able to infer what files users are accessing from this information. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Dave Chinner
gt; + } > + > + len = hot_debugfs_copy(data, data->log_work_buff, len); > + spin_unlock(&data->log_lock); > + > + return len; > +} Aren't you just recreating seq_printf() here? i.e. can't you replace all this complexity with generic seq_file/seq

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-15 Thread Dave Chinner
at was the last update that slabtop got, so it is indicative of the impending OOM situation that occurred. > Changelog from v2: > 1.) Converted to Radix trees, not RB-tree [Zhiyong, Dave Chinner] > 2.) Added memory shrinker [Dave Chinner] I haven't looked at the shrinker, but c

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-15 Thread Dave Chinner
esystem. Filesystems can make use of that information how they please (whether in the kernel or via userspace tools), but having filesystem specific interfaces and implementations of the same functionality is extremely wasteful. Let's do it once, and do it right the first time. ;) Cheer

Re: Write is not atomic?

2012-10-15 Thread Dave Chinner
/mnt/scratch/foo ; echo ; done | sort |uniq -c 39 Ouille 9962 OuilleOuille $ XFS, on the same kernel, hardware and block device: $ for i in `seq 0 1`; do ./a.out ; cat /mnt/scratch/foo ; echo ; done | sort |uniq -c 40 Ouille 9961 OuilleOuille $ So both filesystems behave

Re: xfs: fix buffer lookup race on allocation failure

2012-10-15 Thread Dave Chinner
.4? > > commit fe2429b0966a7ec42b5fe3bf96f0f10de0a3b536 > Author: Dave Chinner > Date: Mon Apr 23 15:58:45 2012 +1000 > > xfs: fix buffer lookup race on allocation failure > > When memory allocation fails to add the page array or tht epages to > a buffer during xfs_

[PATCH] xfs: add hot tracking support.

2012-10-15 Thread Dave Chinner
From: Dave Chinner Connect up the VFS hot tracking support so XFS filesystems can make use of it. Signed-off-by: Dave Chinner --- fs/xfs/xfs_mount.h |1 + fs/xfs/xfs_super.c |9 + 2 files changed, 10 insertions(+) diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-15 Thread Dave Chinner
thread+0x93/0xa0 [ 200.064574] [] kernel_thread_helper+0x4/0x10 [ 200.064574] [] ? __init_kthread_worker+0x40/0x40 [ 200.064574] [] ? gs_change+0x13/0x13 Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&

Re: [RFC v3 09/13] vfs: add one wq to update map info periodically

2012-10-15 Thread Dave Chinner
oking at timestamped event traces. Hence 300s (5 minutes) makes a lot more sense as a period for updates... > /* > * The following comments explain what exactly comprises a unit of heat. > * > diff --git a/include/linux/hot_tracking.h b/include/linux/hot_tracking.h > index 711417

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-15 Thread Dave Chinner
and > migration, as described above. I can't see how this is a manageable interface. It is not persistent, so after every filesystem mount you'd have to set the flag on all your inodes again. Hence, for the moment, I'd suggest that dropping per-inode tracking control until all the

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-16 Thread Dave Chinner
On Tue, Oct 16, 2012 at 11:38:35AM +, Arnd Bergmann wrote: > On Tuesday 16 October 2012, Jaegeuk Kim wrote: > > On Monday 15 October 2012, Dave Chinner wrote: > > > On Sun, Oct 14, 2012 at 03:19:37PM +, Arnd Bergmann wrote: > > > > On Sunday 14 October

Re: xfs: fix buffer lookup race on allocation failure

2012-10-16 Thread Dave Chinner
On Tue, Oct 16, 2012 at 11:27:48AM +0200, William Dauchy wrote: > Hello Dave, > > Thanks for your reply. > > On Tue, Oct 16, 2012 at 1:21 AM, Dave Chinner wrote: > > You're running a CONFIG_XFS_DEBUG kernel. If you can reproduce the > > problem with CONFIG_XFS_D

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-16 Thread Dave Chinner
liar with xattrs in depth. > > Unfortunately, "system" is not implemented in f2fs yet. :( If you've already implemented the user.* namespace, then it's trivial to support the other namespaces - it's just prefixing the xattrs with the appropriate string instead of &q

Re: [PATCH 4/9] xfs: honor the O_SYNC flag for aysnchronous direct I/O requests

2012-11-20 Thread Dave Chinner
On Tue, Nov 20, 2012 at 02:42:48PM -0500, Jeff Moyer wrote: > Dave Chinner writes: > > > And requeuing work from one workqueue to the next is something that > > we can avoid. We know at IO submission time (i.e. > > xfs_vm_direct_io)) whether an fsync completion is going

Re: Hang in XFS reclaim on 3.7.0-rc3

2012-11-20 Thread Dave Chinner
On Tue, Nov 20, 2012 at 08:45:03PM +0100, Torsten Kaiser wrote: > On Tue, Nov 20, 2012 at 12:53 AM, Dave Chinner wrote: > >[] mark_held_locks+0x7e/0x130 > >[] lockdep_trace_alloc+0x63/0xc0 > >[] kmem_cache_alloc+0x35/0xe0 > >

<    1   2   3   4   5   6   7   8   9   10   >