Re: [PATCH v6 0/7] vfs: Non-blockling buffered fs read (page cache only)

2014-11-10 Thread Dave Chinner
that exercises this new functionality? I'm not worried about performance, just correctness Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v6 0/7] vfs: Non-blockling buffered fs read (page cache only)

2014-11-11 Thread Dave Chinner
On Tue, Nov 11, 2014 at 11:02:00AM -0500, Milosz Tanski wrote: On Tue, Nov 11, 2014 at 1:44 AM, Dave Chinner da...@fromorbit.com wrote: On Mon, Nov 10, 2014 at 11:40:23AM -0500, Milosz Tanski wrote: This patcheset introduces an ability to perform a non-blocking read from regular files

Re: [PATCH v6 0/7] vfs: Non-blockling buffered fs read (page cache only)

2014-11-11 Thread Dave Chinner
to exercise this functionality and what makes ltp a better choice? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] mm: check memory reclaim bugs caused fs reentrance

2014-11-11 Thread Dave Chinner
pointed out allocation/reclaim context problems in XFS until we fixed them Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [rfc patch] mm: vmscan: invoke slab shrinkers for each lruvec

2014-11-12 Thread Dave Chinner
On Tue, Nov 11, 2014 at 02:53:10PM -0500, Johannes Weiner wrote: On Tue, Nov 11, 2014 at 05:34:19PM +1100, Dave Chinner wrote: On Mon, Nov 10, 2014 at 09:44:05AM -0500, Johannes Weiner wrote: On Mon, Nov 10, 2014 at 05:46:40PM +1100, Dave Chinner wrote: On Thu, Nov 06, 2014 at 06:50:28PM

Re: [PATCH v10 09/21] Replace the XIP page fault handler with the DAX page fault handler

2014-09-24 Thread Dave Chinner
On Wed, Sep 24, 2014 at 11:43:07AM -0400, Matthew Wilcox wrote: On Thu, Sep 11, 2014 at 01:09:26PM +1000, Dave Chinner wrote: On Wed, Sep 10, 2014 at 11:23:37AM -0400, Matthew Wilcox wrote: On Wed, Sep 03, 2014 at 05:47:24PM +1000, Dave Chinner wrote: + error = get_block(inode

Re: your patch mm: Remove false WARN_ON from pagecache_isize_extended()

2014-11-03 Thread Dave Chinner
the locking model for them Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

[GIT PULL] xfs: updates for 3.19-rc1

2014-12-11 Thread Dave Chinner
: merge xfs_inum.h into xfs_format.h Dave Chinner (13): Merge branch 'xfs-misc-fixes-for-3.19-1' into for-next Merge branch 'xfs-consolidate-format-defs' into for-next Merge branch 'xfs-coccinelle-cleanups' into for-next Merge branch 'xfs-coccinelle-cleanups' into xfs-misc-fixes

Re: [PATCHv2 2/3] selftests: Add test of O_BENEATH openat(2)

2014-12-11 Thread Dave Chinner
On Fri, Nov 21, 2014 at 02:19:41PM +, David Drysdale wrote: On Tue, Nov 11, 2014 at 5:36 AM, Dave Chinner da...@fromorbit.com wrote: [cc fste...@vger.kernel.org] On Tue, Nov 04, 2014 at 09:54:43AM +, David Drysdale wrote: Add simple tests of openat(2) variations, including

[GIT PULL] xfs: fixes for 3.18-rc3

2014-11-07 Thread Dave Chinner
. Brian Foster (1): xfs: rework zero range to prevent invalid i_size updates Dave Chinner (7): xfs: bulkstat doesn't release AGI buffer on error xfs: bulkstat btree walk doesn't terminate xfs: bulkstat chunk formatting cursor is broken xfs: bulkstat chunk

Re: [PATCH -mm v2 3/9] vmscan: shrink slab on memcg pressure

2014-11-09 Thread Dave Chinner
VM LRU reclaim code and the shrinker infrastructure could do with some improvement and refinement, but the external interface is consistent with all the other external locality interfaces the VM provides Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send

Re: [RFC PATCH 0/5] Enable use of Solid State Hybrid Drives

2014-11-09 Thread Dave Chinner
[Been distrcted with other issues, so just getting back to this.] On Thu, Oct 30, 2014 at 10:07:47AM -0700, Dan Williams wrote: On Thu, Oct 30, 2014 at 12:21 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 29, 2014 at 03:24:11PM -0700, Dan Williams wrote: On Wed, Oct 29, 2014 at 3:09

Re: [rfc patch] mm: vmscan: invoke slab shrinkers for each lruvec

2014-11-09 Thread Dave Chinner
with the above comments I made about frequency of shrinker calls and batch sizes, so I suspect that the aggregation of shrinker-based reclaim work is necessary to minimise the interference that recalim causes at the filesystem level... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from

Re: [PATCH v1 5/7] dax: Add huge page fault support

2014-10-12 Thread Dave Chinner
, if you want the filesystem to guarantee alignment to the underlying hardware in this way for DAX, we're going to need to make some modifications to the allocator alignment strategy. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux

[GIT PULL] xfs: updates for 3.18-rc1

2014-10-12 Thread Dave Chinner
xfs_zero_remaining_bytes Dave Chinner (39): xfs: don't dirty buffers beyond EOF xfs: don't zero partial page cache pages during O_DIRECT writes xfs: use ranged writeback and invalidation for direct IO xfs: xfs_file_collapse_range is delalloc challenged Merge branch 'xfs-misc-fixes-for-3.18

Re: [GIT PULL] xfs: updates for 3.18-rc1

2014-10-13 Thread Dave Chinner
On Mon, Oct 13, 2014 at 05:48:18AM -0400, Linus Torvalds wrote: On Sun, Oct 12, 2014 at 9:37 PM, Dave Chinner da...@fromorbit.com wrote: i.e. I have generated this pull-req from the base tree I've been working on (3.17-rc2) but there have already been commits merged into a more recent

Re: [PATCH 3.2 019/102] xfs: don't dirty buffers beyond EOF

2014-11-03 Thread Dave Chinner
fairly carefully tested. I very much doubt that there is specific XFS test coverage on these older kernels that would determine if this has introduced problems or not -- From: Dave Chinner dchin...@redhat.com commit 22e757a49cf010703fcb9c9b4ef793248c39b0c2 upstream

Re: [PATCH] x86: defconfig: Enable CONFIG_FHANDLE

2014-11-30 Thread Dave Chinner
/mount contexts (e.g. userspace NFS servers, filesystem backup programs, etc) so I'm curious as to the problem systemd is solving using this interface. I just can't see the problem being solved here, and why path based security checks on every open() aren't necessary... Cheers, Dave. -- Dave

Re: [PATCH 1/1] XFS: Deletion of unnecessary checks before two function calls

2014-11-30 Thread Dave Chinner
around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring elfr...@users.sourceforge.net Looks fine. Reviewed-by: Dave Chinner dchin...@redhat.com -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line

Re: [PATCH] x86: defconfig: Enable CONFIG_FHANDLE

2014-11-30 Thread Dave Chinner
On Sun, Nov 30, 2014 at 10:08:01PM +0100, Richard Weinberger wrote: Am 30.11.2014 um 21:54 schrieb Dave Chinner: On Wed, Nov 26, 2014 at 12:36:52AM +0100, Richard Weinberger wrote: systemd has a hard dependency on CONFIG_FHANDLE. If you run systemd with CONFIG_FHANDLE=n it will somehow

Re: [PATCH] x86: defconfig: Enable CONFIG_FHANDLE

2014-11-30 Thread Dave Chinner
on the same file system... Thus we check the mount id too, if we can get our hands on it. So what you really want in the mount id in st_buf.st_dev, not the underlying device number. i.e. fstatat(dirfd, path, buf, AT_MOUNTID)? Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: [PATCH v12 00/20] DAX: Page cache bypass for filesystems on memory storage

2014-12-10 Thread Dave Chinner
, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [GIT PULL] aio: fix sleeping while TASK_INTERRUPTIBLE

2015-02-03 Thread Dave Chinner
On Mon, Feb 02, 2015 at 10:45:42AM -0800, Linus Torvalds wrote: On Sun, Feb 1, 2015 at 9:54 PM, Dave Chinner da...@fromorbit.com wrote: Simple enough - the patch below removes the warning from generic/036 for me. So because this is a debugging thing, I'd actually prefer

Re: [PATCH v9 4/11] xfsprogs: xfs_io: add finsert command for insert range

2015-02-05 Thread Dave Chinner
Foster bfos...@redhat.com I've just pulled this patch into xfsprogs in preparation for getting this functionality fully reviewed and merged in the 3.21 kernel cycle. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH v9 4/11] xfsprogs: xfs_io: add finsert command for insert range

2015-02-05 Thread Dave Chinner
Hi Namjae, On Fri, Feb 06, 2015 at 10:40:33AM +1100, Dave Chinner wrote: On Thu, Jan 22, 2015 at 12:11:59AM +0900, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com Add finsert command for fallocate FALLOC_FL_INSERT_RANGE flag. Signed-off-by: Namjae Jeon namjae.j

Re: [PATCH] gfs2: use __vmalloc GFP_NOFS for fs-related allocations.

2015-02-03 Thread Dave Chinner
On Mon, Feb 02, 2015 at 10:30:29AM +, Steven Whitehouse wrote: Hi, On 02/02/15 08:11, Dave Chinner wrote: On Mon, Feb 02, 2015 at 01:57:23AM -0500, Oleg Drokin wrote: Hello! On Feb 2, 2015, at 12:37 AM, Dave Chinner wrote: On Sun, Feb 01, 2015 at 10:59:54PM -0500, gr

Re: [RFC PATCH] fs: file freeze support

2015-01-20 Thread Dave Chinner
block on. That way all the nesting semantics are located in one set of code, and it's easy to verify correct. This should also deal with the locking problems you describe above as mnt_want_write() is always called before taking i_mutex. *nod* Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: [RFC PATCH] fs: file freeze support

2015-01-18 Thread Dave Chinner
On Thu, Jan 15, 2015 at 08:36:55PM +0900, Namjae Jeon wrote: We introduce per-file freeze feature for unifying defrag ext4 and xfs as first ingredient. We get the idea courtesy of Dave Chinner (https://lkml.org/lkml/2014/7/14/759) /me pages the context back in per-file freeze will be used

Re: [PATCH RESEND 1/12] fs: Add support FALLOC_FL_INSERT_RANGE for fallocate

2015-02-16 Thread Dave Chinner
in rather than change this code every time we add a new flag? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH RESEND 4/12] xfsprog: xfsio: update xfs_io manpage for FALLOC_FL_INSERT_RANGE

2015-02-16 Thread Dave Chinner
the complaining fstest ;) Reviewed-by: Dave Chinner dchin...@redhat.com -Dave -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH RESEND 11/12] xfstests: fsx: Add fallocate insert range operation

2015-02-16 Thread Dave Chinner
FALLOC_FL_COLLAPSE_RANGE -C: Do not use collapse range calls\n #endif +#ifdef FALLOC_FL_INSERT_RANGE +-i: Do not use insert range calls\n +#endif I'd make that -I rather than -i so it matches with the -C of collapse range. Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: [PATCH RESEND 2/12] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate

2015-02-16 Thread Dave Chinner
= xfs_insert_file_space(ip, offset, len); + out_unlock: xfs_iunlock(ip, XFS_IOLOCK_EXCL); return error; Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH RESEND 3/12] ext4: Add support FALLOC_FL_INSERT_RANGE for fallocate

2015-02-16 Thread Dave Chinner
and XFS code, then I'll leave it out and let Ted merge it inhis own time. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] gfs2: use __vmalloc GFP_NOFS for fs-related allocations.

2015-02-02 Thread Dave Chinner
On Mon, Feb 02, 2015 at 01:57:23AM -0500, Oleg Drokin wrote: Hello! On Feb 2, 2015, at 12:37 AM, Dave Chinner wrote: On Sun, Feb 01, 2015 at 10:59:54PM -0500, gr...@linuxhacker.ru wrote: From: Oleg Drokin gr...@linuxhacker.ru leaf_dealloc uses vzalloc as a fallback to kzalloc

Re: [PATCH] gfs2: use __vmalloc GFP_NOFS for fs-related allocations.

2015-02-01 Thread Dave Chinner
context because the MM devs won't pass the vmalloc gfp context down the stack to the PTE allocations Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [GIT PULL] aio: fix sleeping while TASK_INTERRUPTIBLE

2015-02-01 Thread Dave Chinner
On Sun, Feb 01, 2015 at 09:36:52PM -0800, Linus Torvalds wrote: On Feb 1, 2015 9:29 PM, Dave Chinner da...@fromorbit.com wrote: So what's the outcome here? I'm running v3.19-rc7 kernel and xfstests::generic/036 is still tripping this warning from the aio code: So for the aio case, I

Re: [GIT PULL] aio: fix sleeping while TASK_INTERRUPTIBLE

2015-02-01 Thread Dave Chinner
regression tests, so something needs to be fixed... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHSET RFC block/for-next] writeback: cgroup writeback support

2015-01-09 Thread Dave Chinner
On Fri, Jan 09, 2015 at 04:23:36PM -0500, Tejun Heo wrote: Hello, Dave. On Thu, Jan 08, 2015 at 10:45:32AM +1100, Dave Chinner wrote: Complications mostly arise from filesystems and inodes having to deal with multiple split bdi's instead of one, but those are mostly straight-forward 1

Re: [PATCH v2] xfs: use generic FS_IOC_GOINGDOWN for ioctl

2015-01-08 Thread Dave Chinner
to the same mailing lists. Cc: Dave Chinner da...@fromorbit.com Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/xfs/xfs_fs.h| 9 + fs/xfs/xfs_fsops.c | 6 +++--- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/fs/xfs/xfs_fs.h b/fs/xfs/xfs_fs.h index

Re: [f2fs-dev] [PATCH 2/6 v2] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Dave Chinner
user API. There's no need to change the XFS implementation at all. The second patch then adds the f2fs implementation. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Dave Chinner
On Thu, Jan 08, 2015 at 01:21:29PM -0800, Jaegeuk Kim wrote: On Fri, Jan 09, 2015 at 07:54:16AM +1100, Dave Chinner wrote: On Thu, Jan 08, 2015 at 02:33:17PM -0600, Eric Sandeen wrote: On 1/8/15 2:18 PM, Jaegeuk Kim wrote: On Thu, Jan 08, 2015 at 01:54:20PM -0600, Eric Sandeen wrote

[GIT PULL] xfs: updates for 3.20-rc1

2015-02-09 Thread Dave Chinner
: growfs should use synchronous transactions Dave Chinner (28): Merge branch 'xfs-misc-fixes-for-3.20-1' into for-next xfs: move xfs_fs.h to libxfs xfs: move xfs_types.h to libxfs xfs: move struct xfs_bmalloca to libxfs xfs: move xfs_bmap_finish prototype xfs: remove

Re: [PATCH] gfs2: use __vmalloc GFP_NOFS for fs-related allocations.

2015-02-05 Thread Dave Chinner
On Wed, Feb 04, 2015 at 02:13:29AM -0500, Oleg Drokin wrote: Hello! On Feb 3, 2015, at 5:33 PM, Dave Chinner wrote: I also wonder if vmalloc is still very slow? That was the case some time ago when I noticed a problem in directory access times in gfs2, which made us change to use kmalloc

Re: [PATCH] gfs2: use __vmalloc GFP_NOFS for fs-related allocations.

2015-02-05 Thread Dave Chinner
On Wed, Feb 04, 2015 at 09:49:50AM +, Steven Whitehouse wrote: Hi, On 04/02/15 07:13, Oleg Drokin wrote: Hello! On Feb 3, 2015, at 5:33 PM, Dave Chinner wrote: I also wonder if vmalloc is still very slow? That was the case some time ago when I noticed a problem in directory access

Re: [PATCHSET RFC block/for-next] writeback: cgroup writeback support

2015-01-07 Thread Dave Chinner
? Finally, distros are going to ship with this always enabled, so what is the overall increase in the size of the struct inode on a 64 bit system with it enabled? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Dave Chinner
no need for new ioctls here. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

2015-03-17 Thread Dave Chinner
other problem Cheers, Dave -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCHv3 xfstests 2/3] generic: test openat and new O_BENEATH flag

2015-03-16 Thread Dave Chinner
needing to write new helper functions... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] fstests: generic test for preadv2 behavior on linux

2015-03-16 Thread Dave Chinner
On Mon, Mar 16, 2015 at 06:11:19PM -0400, Milosz Tanski wrote: On Mon, Mar 16, 2015 at 6:02 PM, Dave Chinner da...@fromorbit.com wrote: On Mon, Mar 16, 2015 at 02:34:22PM -0400, Milosz Tanski wrote: preadv2 is a new syscall introduced that is like preadv2 but with flag argument. The first

Re: [PATCH] fstests: generic test for preadv2 behavior on linux

2015-03-16 Thread Dave Chinner
/src/preadv2 -d -n -p 0 -l 1024 $file $XFS_IO_PROG -d -c pread -n 0 1024 $file | _filter_xfs_io And so on Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v7 5/5] xfs: add RWF_NONBLOCK support

2015-03-16 Thread Dave Chinner
Change looks good, but I haven't tested it, so: Acked-by: Dave Chinner da...@fromorbit.com -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

2015-03-17 Thread Dave Chinner
On Tue, Mar 17, 2015 at 09:53:57AM -0700, Linus Torvalds wrote: On Tue, Mar 17, 2015 at 12:06 AM, Dave Chinner da...@fromorbit.com wrote: TO close the loop here, now I'm back home and can run tests: config3.19 4.0-rc1 4.0-rc4 defaults

Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

2015-03-17 Thread Dave Chinner
On Tue, Mar 17, 2015 at 02:30:57PM -0700, Linus Torvalds wrote: On Tue, Mar 17, 2015 at 1:51 PM, Dave Chinner da...@fromorbit.com wrote: On the -o ag_stride=-1 -o bhash=101073 config, the 60s perf stat I was using during steady state shows: 471,752 migrate:mm_migrate_pages

Re: [PATCHv3 xfstests 2/3] generic: test openat and new O_BENEATH flag

2015-03-17 Thread Dave Chinner
On Tue, Mar 17, 2015 at 08:33:27AM -0700, Kees Cook wrote: On Mon, Mar 16, 2015 at 4:24 PM, Dave Chinner da...@fromorbit.com wrote: On Mon, Mar 09, 2015 at 02:00:11PM +, David Drysdale wrote: Test basic openat(2) behaviour. Test that if O_BENEATH flag is set, openat() will only open

Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

2015-03-18 Thread Dave Chinner
%) Hash buckets with 22 entries 1 ( 0%) Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] mm: Use GFP_KERNEL allocation for the page cache in page_cache_read

2015-03-19 Thread Dave Chinner
allocations where the caller cannot pass a gfp_mask need to obey the mapping_gfp_mask that is set by the mapping owner Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

2015-03-19 Thread Dave Chinner
), but otherwise the system libraries are unchanged. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

2015-03-19 Thread Dave Chinner
On Thu, Mar 19, 2015 at 04:05:46PM -0700, Linus Torvalds wrote: On Thu, Mar 19, 2015 at 3:41 PM, Dave Chinner da...@fromorbit.com wrote: My recollection wasn't faulty - I pulled it from an earlier email. That said, the original measurement might have been faulty. I ran the numbers again

Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

2015-03-19 Thread Dave Chinner
( +- 7.43% ) 10.002032292 seconds time elapsed ( +- 0.00% ) Bit more variance there than the pte checking, but runtime difference is in the noise - 5m4s vs 4m54s - and profiles are identical to the pte checking version. Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: [PATCH] mm: Use GFP_KERNEL allocation for the page cache in page_cache_read

2015-03-19 Thread Dave Chinner
they don't own. cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

2015-03-19 Thread Dave Chinner
On Thu, Mar 19, 2015 at 06:29:47PM -0700, Linus Torvalds wrote: On Thu, Mar 19, 2015 at 5:23 PM, Dave Chinner da...@fromorbit.com wrote: Bit more variance there than the pte checking, but runtime difference is in the noise - 5m4s vs 4m54s - and profiles are identical to the pte checking

Re: [PATCH] mm: Use GFP_KERNEL allocation for the page cache in page_cache_read

2015-03-19 Thread Dave Chinner
On Thu, Mar 19, 2015 at 01:44:41PM +0100, Michal Hocko wrote: On Thu 19-03-15 18:14:39, Dave Chinner wrote: On Wed, Mar 18, 2015 at 03:55:28PM +0100, Michal Hocko wrote: On Wed 18-03-15 10:44:11, Rik van Riel wrote: On 03/18/2015 10:09 AM, Michal Hocko wrote: page_cache_read has

Re: [PATCH] mm: Use GFP_KERNEL allocation for the page cache in page_cache_read

2015-03-20 Thread Dave Chinner
On Fri, Mar 20, 2015 at 02:14:53PM +0100, Michal Hocko wrote: On Fri 20-03-15 14:48:20, Dave Chinner wrote: On Thu, Mar 19, 2015 at 01:44:41PM +0100, Michal Hocko wrote: allocations where the caller cannot pass a gfp_mask need to obey the mapping_gfp_mask that is set by the mapping

Re: inconsistent timestamp update in rename() of xfs/fat/gfs2/ramfs/jffs2...

2015-03-20 Thread Dave Chinner
not. Applications which make use of the last file status change timestamp may behave differently with respect to renamed files unless they are designed to allow for either behavior. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

2015-03-09 Thread Dave Chinner
a few minutes to run - if you throw 8p at it then it should run at 100k files/s being created. Then unmount and run xfs_repair -o bhash=101703 /path/to/file.img on the resultant image file. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line

Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

2015-03-10 Thread Dave Chinner
On Mon, Mar 09, 2015 at 09:52:18AM -0700, Linus Torvalds wrote: On Mon, Mar 9, 2015 at 4:29 AM, Dave Chinner da...@fromorbit.com wrote: Also, is there some sane way for me to actually see this behavior on a regular machine with just a single socket? Dave is apparently running in some fake

Re: [PATCH -next] locking/rwsem: don't spin in heavy contention

2015-03-06 Thread Dave Chinner
of time. Especially considering the test has concurrent truncates running which should drain the entire IO queue every couple of seconds at worst Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH 0/3] Reduce system overhead of automatic NUMA balancing

2015-03-24 Thread Dave Chinner
On Mon, Mar 23, 2015 at 12:24:00PM +, Mel Gorman wrote: These are three follow-on patches based on the xfsrepair workload Dave Chinner reported was problematic in 4.0-rc1 due to changes in page table management -- https://lkml.org/lkml/2015/3/1/226. Much of the problem was reduced

Re: [PATCH 4/6] Add stream ID support for buffered writeback

2015-03-24 Thread Dave Chinner
that is being submitted where there is a direct relationship between the inode and the IO being built, rather than at a high layer where the stream id has ambiguous meaning Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 1/6] block: add support for carrying a stream ID in a bio

2015-03-24 Thread Dave Chinner
). Potentially 2 streams - one for the journal which is frequently overwritten, the other for all other long lived persistent metadata. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 3/6] direct-io: add support for write stream IDs

2015-03-24 Thread Dave Chinner
; sdio.block_in_file = offset blkbits; + sdio.streamid = iocb-ki_filp-f_streamid; If iocb-ki_filp-f_streamid is not set, then it should fall back to whatever is set on the inode-i_streamid. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line

Re: [PATCH 6/6] xfs: add support for buffered writeback stream ID

2015-03-24 Thread Dave Chinner
, this is wrong. + bio_set_streamid(bio, ioend-io_inode-i_streamid); is actually what it should be. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v11 21/21] brd: Rename XIP to DAX

2015-03-24 Thread Dave Chinner
block device. Then the backing store will be fully allocated, and .direct_access will never do allocation until you flush the backing store... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH v10 1/12] fs: Add support FALLOC_FL_INSERT_RANGE for fallocate

2015-03-25 Thread Dave Chinner
give your sob or reviewed-by ok I can pull it into my tree. I'll leave it up to you to determine how you want to deal with this. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [patch 00/12] mm: page_alloc: improve OOM mechanism and policy

2015-03-29 Thread Dave Chinner
On Fri, Mar 27, 2015 at 11:05:09AM -0400, Johannes Weiner wrote: On Fri, Mar 27, 2015 at 06:58:22AM +1100, Dave Chinner wrote: On Wed, Mar 25, 2015 at 02:17:04AM -0400, Johannes Weiner wrote: Hi everybody, in the recent past we've had several reports and discussions on how to deal

Re: deadlock between type-i_mutex_dir_key#4 and xfs_dir_ilock_class

2015-03-30 Thread Dave Chinner
I need a FAQ entry for it. problem is, i can't fix it easily because it's a shmem bug... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [LKP] [xfs] 834ffca6f7e: WARNING: CPU: 3 PID: 23390 at fs/xfs/xfs_file.c:700 xfs_file_dio_aio_write+0x27c/0x2e0()

2015-03-27 Thread Dave Chinner
On Fri, Mar 27, 2015 at 08:32:23AM +0800, Huang Ying wrote: On Fri, 2015-03-27 at 08:22 +1100, Dave Chinner wrote: On Thu, Mar 26, 2015 at 02:45:19PM +0800, Huang Ying wrote: FYI, we noticed the below changes on git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

Re: [PATCH] mm: Use GFP_KERNEL allocation for the page cache in page_cache_read

2015-03-31 Thread Dave Chinner
On Mon, Mar 30, 2015 at 10:22:18AM +0200, Michal Hocko wrote: On Fri 27-03-15 08:43:54, Dave Chinner wrote: On Thu, Mar 26, 2015 at 10:53:02AM +0100, Michal Hocko wrote: On Fri 20-03-15 14:48:20, Dave Chinner wrote: On Thu, Mar 19, 2015 at 01:44:41PM +0100, Michal Hocko wrote

Re: [RFC][PATCH 00/10] tracing: Use TRACE_DEFINE_ENUM() to show enum values

2015-03-31 Thread Dave Chinner
), __print_symbolic(__entry-type, XFS_LI_TYPE_DESC), $ And a quick git grep indicates there are a lot that you haven't converted in this patchset... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] xfs: use GFP_NOFS argument in radix_tree_preload

2015-03-22 Thread Dave Chinner
/correcting allocation flags then you need to understand the rules and context in which the allocation is being made... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH v3] fs: record task name which froze superblock

2015-03-02 Thread Dave Chinner
On Mon, Mar 02, 2015 at 05:38:29AM +0100, Mateusz Guzik wrote: On Sun, Mar 01, 2015 at 08:31:26AM +1100, Dave Chinner wrote: On Sat, Feb 28, 2015 at 05:25:57PM +0300, Alexey Dobriyan wrote: Freezing and thawing are separate system calls, task which is supposed to thaw filesystem

Re: [regression v4.0-rc1] mm: IPIs from TLB flushes causing significant performance degradation.

2015-03-02 Thread Dave Chinner
On Mon, Mar 02, 2015 at 11:47:52AM -0800, Linus Torvalds wrote: On Sun, Mar 1, 2015 at 5:04 PM, Dave Chinner da...@fromorbit.com wrote: Across the board the 4.0-rc1 numbers are much slower, and the degradation is far worse when using the large memory footprint configs. Perf points

Re: [regression v4.0-rc1] mm: IPIs from TLB flushes causing significant performance degradation.

2015-03-02 Thread Dave Chinner
% TLB_FLUSH_ON_TASK_SWITCH The difference would appear to be the number of remote TLB shootdowns that are occurring from otherwise identical page fault paths. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v3] fs: record task name which froze superblock

2015-02-28 Thread Dave Chinner
of the user API - it's not defined in the man page which just says can be up to 16 bytes. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [regression v4.0-rc1] mm: IPIs from TLB flushes causing significant performance degradation.

2015-03-03 Thread Dave Chinner
On Tue, Mar 03, 2015 at 01:43:46PM +, Mel Gorman wrote: On Tue, Mar 03, 2015 at 10:34:37PM +1100, Dave Chinner wrote: On Mon, Mar 02, 2015 at 10:56:14PM -0800, Linus Torvalds wrote: On Mon, Mar 2, 2015 at 9:20 PM, Dave Chinner da...@fromorbit.com wrote: But are those migrate-page

Re: [regression v4.0-rc1] mm: IPIs from TLB flushes causing significant performance degradation.

2015-03-04 Thread Dave Chinner
On Thu, Mar 05, 2015 at 12:35:45AM +0100, Ingo Molnar wrote: * Dave Chinner da...@fromorbit.com wrote: After going through the series again, I did not spot why there is a difference. It's functionally similar and I would hate the theory that this is somehow hardware related due

Re: [regression v4.0-rc1] mm: IPIs from TLB flushes causing significant performance degradation.

2015-03-04 Thread Dave Chinner
On Wed, Mar 04, 2015 at 08:00:46PM +, Mel Gorman wrote: On Wed, Mar 04, 2015 at 08:33:53AM +1100, Dave Chinner wrote: On Tue, Mar 03, 2015 at 01:43:46PM +, Mel Gorman wrote: On Tue, Mar 03, 2015 at 10:34:37PM +1100, Dave Chinner wrote: On Mon, Mar 02, 2015 at 10:56:14PM -0800

[regression v4.0-rc1] mm: IPIs from TLB flushes causing significant performance degradation.

2015-03-01 Thread Dave Chinner
+ 3.74% native_send_call_func_single_ipi So either there's been a massive increase in the number of IPIs being sent, or the cost per IPI have greatly increased. Either way, the result is a pretty significant performance degradatation. Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: [regression v4.0-rc1] mm: IPIs from TLB flushes causing significant performance degradation.

2015-03-03 Thread Dave Chinner
On Mon, Mar 02, 2015 at 10:56:14PM -0800, Linus Torvalds wrote: On Mon, Mar 2, 2015 at 9:20 PM, Dave Chinner da...@fromorbit.com wrote: But are those migrate-page calls really common enough to make these things happen often enough on the same pages for this all to matter? It's looking

[GIT PULL] xfs: PNFS block layout support for 3.20-rc1

2015-02-20 Thread Dave Chinner
mode 100644 fs/xfs/xfs_pnfs.c create mode 100644 fs/xfs/xfs_pnfs.h -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v10 10/12] xfstests: fsstress: Add fallocate insert range operation

2015-02-24 Thread Dave Chinner
pattern that results from a specific fsstress random seed. As such, I added this to xfs/068: FSSTRESS_AVOID=-f insert=0 $FSSTRESS_AVOID To turn off the insert operation for that test and hence produce the expected tree of files. Cheers, Dave. -- Dave Chinner da...@fromorbit.com

[GIT PULL] xfs: updates for v4.0-rc2

2015-02-26 Thread Dave Chinner
on truncate extension o fix transaction leak in error handling for new pnfs block layout support o add missing target_ip check to RENAME_EXCHANGE Dave Chinner (1): xfs: ensure truncate forces zeroed blocks to disk Eric Sandeen (2

Re: [patch 00/12] mm: page_alloc: improve OOM mechanism and policy

2015-03-26 Thread Dave Chinner
new XFS: possible deadlock in memory allocation warnings are emitted. If the patch set floods the system with such warnings, then it means the proposed means the fallback for caller handles allocation failure is not making progress. Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: Should implementations of -direct_access be allowed to sleep?

2015-03-26 Thread Dave Chinner
is granted. i.e. .direct_access is the first hook into the persistent device at page fault time Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] mm: Use GFP_KERNEL allocation for the page cache in page_cache_read

2015-03-26 Thread Dave Chinner
On Thu, Mar 26, 2015 at 10:53:02AM +0100, Michal Hocko wrote: On Fri 20-03-15 14:48:20, Dave Chinner wrote: On Thu, Mar 19, 2015 at 01:44:41PM +0100, Michal Hocko wrote: [...] Or did I miss your point? Are you concerned about some fs overloading filemap_fault and do some locking before

Re: [LKP] [xfs] 834ffca6f7e: WARNING: CPU: 3 PID: 23390 at fs/xfs/xfs_file.c:700 xfs_file_dio_aio_write+0x27c/0x2e0()

2015-03-26 Thread Dave Chinner
concurrent O_DIRECT and buffered/mmap IO to the same file. That warning was put there on purpose to tell us that there's a well known reason the user is reporting data corruption Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/8] pmem: Initial version of persistent memory driver

2015-03-26 Thread Dave Chinner
is enabled and data integrity operations are run. i.e. fsync and sync will provide cache flush triggers for DAX enabled devices once we get everything in place. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 2/2] mm: numa: Do not clear PTEs or PMDs for NUMA hinting faults

2015-03-05 Thread Dave Chinner
On Thu, Mar 05, 2015 at 11:54:52PM +, Mel Gorman wrote: Dave Chinner reported the following on https://lkml.org/lkml/2015/3/1/226 Across the board the 4.0-rc1 numbers are much slower, and the degradation is far worse when using the large memory footprint configs. Perf points

Re: [PATCH] xfs: use GFP_NOFS argument in radix_tree_preload

2015-03-23 Thread Dave Chinner
knowledge transfer mechanism in software engineering Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [patch 00/12] mm: page_alloc: improve OOM mechanism and policy

2015-04-13 Thread Dave Chinner
not really see a reason to change GFP_NOFS vs. OOM killer semantic. So, really, what we want is something like: #define __GFP_USE_LOWMEM_RESERVE__GFP_HIGH So that it documents the code that is using it effectively and we can find them easily with cscope/grep? Cheers, Dave. -- Dave Chinner

<    4   5   6   7   8   9   10   11   12   13   >