[PATCH v1] lib: cpu_rmap: avoid flushing all workqueues

uses reference-counting to replace irq_run_affinity_notifiers(). It also removes irq_run_affinity_notifiers() altogether. Signed-off-by: David Decotigny --- include/linux/cpu_rmap.h | 13 include/linux/interrupt.h |5 - lib/cpu_rmap.c| 48

Re: [PATCH v1] lib: cpu_rmap: avoid flushing all workqueues

Thank you, Josh, A few comments below, and the revised version shortly. On Thu, Dec 27, 2012 at 8:04 PM, Josh Triplett wrote: > On Thu, Dec 27, 2012 at 11:24:34AM -0800, David Decotigny wrote: >> In some cases, free_irq_cpu_rmap() is called while holding a lock >> (eg. rtnl). T

[PATCH v2] lib: cpu_rmap: avoid flushing all workqueues

uses reference-counting to replace irq_run_affinity_notifiers(). It also removes irq_run_affinity_notifiers() altogether. Signed-off-by: David Decotigny --- include/linux/cpu_rmap.h | 13 - include/linux/interrupt.h |5 - lib/cpu_rmap.c| 47

Re: [PATCH v2] lib: cpu_rmap: avoid flushing all workqueues

11:03 -0800, David Decotigny wrote: >> In some cases, free_irq_cpu_rmap() is called while holding a lock >> (eg. rtnl). This can lead to deadlocks, because it invokes >> flush_scheduled_work() which ends up waiting for whole system >> workqueue to flush, but some pending works

[PATCH v3] lib: cpu_rmap: avoid flushing all workqueues

uses reference-counting to replace irq_run_affinity_notifiers(). It also removes irq_run_affinity_notifiers() altogether. Signed-off-by: David Decotigny --- include/linux/cpu_rmap.h | 13 --- include/linux/interrupt.h |5 lib/cpu_rmap.c| 56

Re: [PATCH v3] lib: cpu_rmap: avoid flushing all workqueues

Thanks, I appreciate your review and clarification, as I was afraid there could be something I missed. I will send v4 of this patch: an update with the cpu_rmap_get helper that Josh suggested and the "free_cpu_rmap" alias removed. Regards, -- David Decotigny On Wed, Jan 2, 2013 a

Re: [PATCH v3] lib: cpu_rmap: avoid flushing all workqueues

Revising my position: v4 will only have comments update (Ben) and new cpu_rmap_get inetrnal helper (Josh). IMHO, further API rework discussed with Ben and Eric ought to be in a later patch, as they affect drivers. -- David Decotigny On Wed, Jan 2, 2013 at 12:34 PM, David Decotigny wrote

[PATCH v4] lib: cpu_rmap: avoid flushing all workqueues

uses reference-counting to replace irq_run_affinity_notifiers(). It also removes irq_run_affinity_notifiers() altogether. Signed-off-by: David Decotigny --- include/linux/cpu_rmap.h | 13 +++--- include/linux/interrupt.h |5 lib/cpu_rmap.c| 63

Re: [PATCH v4] lib: cpu_rmap: avoid flushing all workqueues

version. And some refactoring will be done in a later patch. Regards, -- David Decotigny On Wed, Jan 2, 2013 at 3:12 PM, Andrew Morton wrote: > On Wed, 2 Jan 2013 13:52:25 -0800 > David Decotigny wrote: > >> In some cases, free_irq_cpu_rmap() is called while holding a lock >>

[PATCH net-next v1 0/3] forcedeth: fix device lock-up for dual-port NICs

ular, please let me know if this should not apply to other hardware. # Patch Set Summary: David Decotigny (3): forcedeth: fix buffer overflow forcedeth: fix TX timeout caused by TX pause on down link forcedeth: prevent TX timeouts after re

[PATCH net-next v1 1/3] forcedeth: fix buffer overflow

Found by manual code inspection. Tested: compile, reboot, ethtool -d ethX Signed-off-by: David Decotigny --- drivers/net/ethernet/nvidia/forcedeth.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia

[PATCH net-next v1 2/3] forcedeth: fix TX timeout caused by TX pause on down link

NvRegTransmitterControl This is what this patch avoids. Signed-off-by: David Decotigny --- drivers/net/ethernet/nvidia/forcedeth.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c inde

[PATCH net-next v1 3/3] forcedeth: prevent TX timeouts after reboot

quot;net-forcedeth: fix TX timeout caused by TX pause on down link") - wait 5mn until ping hangs & TX timeout in dmesg - reboot on kernel with present patch - host is immediatly operational, no TX timeout Signed-off-by: David Decotigny --- drivers/net/ethernet/nvidia/forcede

[PATCH net-next v1 0/7] net: extend ethtool link mode bitmaps to 48 bits

From: David Decotigny This patch series increases the width of the supported/advertising ethtool masks from 32 bits to 48. This should allow to breathe for a couple more years (or... months?). It should not cause any backward compatibility issues for now, as long as non-updated drivers don&#

[PATCH net-next v1 4/7] net: mdio: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/mdio.c | 59 +--- include/linux/mdio.h | 15 +++-- 2 files changed, 42 insertions(+), 32 deletions(-) diff --git a/drivers/net/mdio.c b/drivers/net/mdio.c index

[PATCH net-next v1 7/7] net: mlx4_en: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 67 +++-- 1 file changed, 40 insertions(+), 27 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4

[PATCH net-next v1 6/7] net: tun: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/tun.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index c0df872..88f9078 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -2257,8 +2257,8 @@ static

[PATCH net-next v1 2/7] net: phy: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/phy/phy.c| 29 ++--- drivers/net/phy/phy_device.c | 4 ++-- include/linux/phy.h | 10 +- 3 files changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/net/phy/phy.c

[PATCH net-next v1 5/7] net: veth: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/veth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 8ad5965..902e127 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -49,8 +49,8 @@ static

[PATCH net-next v1 3/7] net: mii: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/mii.c | 52 +--- include/linux/mii.h | 31 --- 2 files changed, 45 insertions(+), 38 deletions(-) diff --git a/drivers/net/mii.c b/drivers/net

[PATCH net-next v1 1/7] net: ethtool: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- include/uapi/linux/ethtool.h | 130 --- 1 file changed, 110 insertions(+), 20 deletions(-) diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 5f66d9c..61e7734 100644

Re: [PATCH net-next v1 0/7] net: extend ethtool link mode bitmaps to 48 bits

Thanks Ben, I will send an updated version. About rejecting high bits in drivers that don't support them: a basic fix (in a separate patch series) could be something like follows in ethtool_set_settings callbacks: if (ecmd->advertising_hi) return -EINVAL; with comments. But I don't find it very n

[PATCH net-next v2 0/8] net: extend ethtool link mode bitmaps to 48 bits

From: David Decotigny History: v2: - added ethtool_ops::get_compat_flags() to be able to check user parameters in generic ethtool layer when a driver does not support a new feature. - in generic ethtool code, EINVAL when userspace sets a link mode with bits 32..47 set

[PATCH net-next v2 1/8] net: ethtool: internal compatibility flags to reject non-zero reserved fields

From: David Decotigny The public ethtool API progressively shrinks "reserved" fields to expand some other fields (eg. link mode masks). This patch allows drivers to declare that they fully support expanded fields. When they don't do so, the generic ethtool layer may reject (-EI

[PATCH net-next v2 3/8] net: phy: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/phy/phy.c| 30 -- drivers/net/phy/phy_device.c | 4 ++-- include/linux/phy.h | 10 +- 3 files changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/net/phy

[PATCH net-next v2 4/8] net: mii: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/mii.c | 52 +--- include/linux/mii.h | 31 --- 2 files changed, 45 insertions(+), 38 deletions(-) diff --git a/drivers/net/mii.c b/drivers/net

[PATCH net-next v2 8/8] net: mlx4_en: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 73 - 1 file changed, 46 insertions(+), 27 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4

[PATCH net-next v2 7/8] net: tun: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/tun.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index c0df872..88f9078 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -2257,8 +2257,8 @@ static

[PATCH net-next v2 5/8] net: mdio: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/mdio.c | 59 +--- include/linux/mdio.h | 15 +++-- 2 files changed, 42 insertions(+), 32 deletions(-) diff --git a/drivers/net/mdio.c b/drivers/net/mdio.c index

[PATCH net-next v2 2/8] net: ethtool: extend link mode support to 48 bits

From: David Decotigny This patch also ensures that requests from userspace asking to advertise >= 32b link mode masks will be rejected, unless the driver explicitly supports this. Signed-off-by: David Decotigny --- include/linux/ethtool.h | 12 +++- include/uapi/linux/ethtool.h |

[PATCH net-next v2 6/8] net: veth: extend link mode support to 48 bits

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/veth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 8ad5965..902e127 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -49,8 +49,8 @@ static

Re: [PATCH net-next v2 0/8] net: extend ethtool link mode bitmaps to 48 bits

/ mask. I can also propose a prototype of the scheme described above, please let me know. On Tue, Jan 6, 2015 at 5:56 AM, Amir Vadai wrote: > On 1/6/2015 4:54 AM, David Decotigny wrote: >> This patch series increases the width of the supported/advertising >> ethtool masks from 32 bits

[PATCH v1] staging: comedi: dmm32at: fix style issues

Before: 1 ERROR: code indent should use tabs where possible 1 WARNING: please, no spaces at the start of a line After: (none) Signed-off-by: David Decotigny --- drivers/staging/comedi/drivers/dmm32at.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH v2] staging: comedi: dmm32at: fix style issues

Before: 1 ERROR: code indent should use tabs where possible 1 WARNING: please, no spaces at the start of a line After: (none) Signed-off-by: David Decotigny --- drivers/staging/comedi/drivers/dmm32at.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v2] staging: comedi: dmm32at: fix style issues

w. On Fri, Dec 26, 2014 at 11:00 PM, Sudip Mukherjee wrote: > On Thu, Dec 25, 2014 at 12:28:28PM -0800, David Decotigny wrote: >> Before: >> 1 ERROR: code indent should use tabs where possible >> 1 WARNING: please, no spaces at the start of a line >> >> Af

[PATCH net-next v1] doc: net: fix txtimestamp build

From: David Decotigny Signed-off-by: David Decotigny --- Documentation/networking/timestamping/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/networking/timestamping/Makefile b/Documentation/networking/timestamping/Makefile index 8c20dfa..80a3ce0 100644 --- a

[PATCH net-next v1] net: bnx2x: avoid macro redefinition

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h index 792ba72..756053c 100644 --- a/drivers/net

Re: [PATCH net-next v1] doc: net: fix txtimestamp build

wrote: > On Sun, Jan 11, 2015 at 11:41:03AM -0800, David Decotigny wrote: >> From: David Decotigny > > FYI, patches for 'net-next' need to be addressed to both the > networking list and to the maintainer. > > Thanks, > Richard -- To unsubscribe from this list: s

Re: [PATCH net-next v2 0/8] net: extend ethtool link mode bitmaps to 48 bits

Vadai wrote: > On 1/6/2015 7:36 PM, David Decotigny wrote: >> Interesting. It seems that the band-aid I was proposing is already >> obsolete. We could still use the remaining reserved 16 bits to encode >> 5 more bits per mask (that is: 53 bits / mask total). But if I >> u

[PATCH net-next v1 14/18] net: bridge: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index b087d27..57282a5 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -35,10 +35,10

[PATCH net-next v1 00/18] RFC: new ETHTOOL_GSETTINGS/SSETTINGS API

From: David Decotigny The main goal of this series is to support ethtool link mode masks larger than 32 bits. It implements a new ioctl pair (ETHTOOL_GSETTINGS/SSETTINGS), its associated callbacks (get/set_settings) and a new struct ethtool_settings, which should eventually replace legacy

[PATCH net-next v1 17/18] net: mlx4: identify predicate for debug messages

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h index 944a112..96bf728

[PATCH net-next v1 18/18] net: mlx4: use new ETHTOOL_G/SSETTINGS API

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 326 drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h| 1 + 3 files changed, 161 insertions(+), 167

[PATCH net-next v1 10/18] net: team: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/team/team.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 4b2bfc5..77576d1 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team

[PATCH net-next v1 16/18] net: ethtool: remove unused __ethtool_get_settings

From: David Decotigny replaced by __ethtool_get_ksettings. Signed-off-by: David Decotigny --- include/linux/ethtool.h | 4 net/core/ethtool.c | 46 -- 2 files changed, 12 insertions(+), 38 deletions(-) diff --git a/include/linux

[PATCH net-next v1 12/18] net: rdma: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index ce55906..782bb8c 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma

[PATCH net-next v1 15/18] net: core: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 9993412..f54ae21 100644 --- a/net

[PATCH net-next v1 07/18] net: bonding: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index f47bc43..7710386 100644 --- a/drivers/net/bonding

[PATCH net-next v1 06/18] net: usnic: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index d71ba62..f6f67c9

[PATCH net-next v1 13/18] net: 8021q: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 1189564..b301bf6 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -655,12

[PATCH net-next v1 11/18] net: fcoe: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/scsi/fcoe/fcoe_transport.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index bdc8989..6097f0d

[PATCH net-next v1 02/18] net: usnic: remove unused call to ethtool_ops::get_settings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 53bd6a2..61337c7c 100644 --- a/drivers

[PATCH net-next v1 09/18] net: macvlan: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 1df38bd..ce934c3 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c

[PATCH net-next v1 01/18] net: ethtool: propagate get_settings error

From: David Decotigny Signed-off-by: David Decotigny --- net/core/ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 91f74f3..52efb7e 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -364,7 +364,7 @@ static int

[PATCH net-next v1 08/18] net: ipvlan: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 4f4099d..79e3516 100644 --- a/drivers/net/ipvlan

[PATCH net-next v1 05/18] net: tx4939: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- arch/mips/txx9/generic/setup_tx4939.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup_tx4939.c b/arch/mips/txx9/generic/setup_tx4939.c index e3733cd..4a3ebf6 100644 --- a/arch/mips

[PATCH net-next v1 03/18] net: usnic: use __ethtool_get_settings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 61337c7c..d71ba62 100644

[PATCH net-next v1 04/18] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

From: David Decotigny This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by the new get_ksettings/set_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable length), and removes

Re: [PATCH net-next v1 05/18] net: tx4939: use __ethtool_get_ksettings

On Tue, Jan 27, 2015 at 4:32 AM, Sergei Shtylyov wrote: > linux-m...@linux-mips.org. Thanks, added mips + usnic + fcoe in my copy for the next wave of reviews. Also updated the subject line. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to maj

[PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion

types) drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:expected unsigned short [unsigned] [usertype] val drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:got restricted __le16 [usertype] BA_timeout_value Signed-off-by: David Decotigny --- drivers/staging/rtl8723au/core

[PATCH v2 0/2] staging: rtl8723au: core: endianness issues

. # Patch Set Summary: David Decotigny (2): staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness staging: rtl8723au: core: remove redundant endianness conversion drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

[PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness

ifferent base types) drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16:expected unsigned short [unsigned] status drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16:got restricted __le16 [usertype] Signed-off-by: David Decotigny --- drivers/staging/rtl8723au/core/rtw_mlme_e

Re: [PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness

This was introduced by kernel bulk commit 5e93f3520 "staging: r8723au: Add source files for new driver - part 1", initially from github according to commit description. On github, this traces back to another bulk commit: 2896bda04353 "Add new files in core directory", which is the 1st version of th

[PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness

93f3520 "staging: r8723au: Add source files for new driver - part 1", initially from github according to commit description. On github, this traces back to another bulk commit: 2896bda04353 "Add new files in core directory", which is the 1st version of the driver. Signed-off-b

[PATCH v2 0/2] staging: rtl8723au: core: endianness issues

correct recipients, only changed commit descriptions (credits to Dan Carpenter) # Patch Set Summary: David Decotigny (2): staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness staging: rtl8723au: core: remove redundant

[PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion

/rtl8723au/core/rtw_mlme_ext.c:3911:56:expected unsigned short [unsigned] [usertype] val drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:got restricted __le16 [usertype] BA_timeout_value Signed-off-by: David Decotigny --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 4 ++-- 1

Re: [PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data

7:27 PM, Greg Kroah-Hartman wrote: > On Mon, May 25, 2015 at 09:40:04PM -0700, David Decotigny wrote: >> This fixes the following sparse warnings: >>drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38: warning: incorrect >> type in argument 1 (different address spaces)

[PATCH] scsi: avoid use of reclaimed reference

This patch avoids to use an object after it was potentially reclaimed by scsi_device_put(). Signed-off-by: David Decotigny --- drivers/scsi/scsi_scan.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 307a811

Re: [PATCH] scsi: avoid use of reclaimed reference

csi_device_put(sdev); // -> reclaimed if (scsi_device_created(sdev)) // test on garbage or unmapped data (#PF) ... On Tue, Nov 12, 2013 at 5:57 PM, James Bottomley wrote: > On Tue, 2013-11-12 at 17:10 -0800, David Decotigny wrote: >> This patch avoids to use an object after it

[PATCH net-next v1 2/2] netpoll: avoid reference leaks

after free" Signed-off-by: David Decotigny --- net/core/netpoll.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 907fb5e..1e10d5d 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -802,6 +802,7

[PATCH net-next v1 1/2] netpoll: fix use after free

ed --> netpoll_rx_disable() + npinfo is garbage #-> down(&ni->dev_lock); Signed-off-by: David Decotigny --- net/core/netpoll.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index e33937f..907fb5e 1006

Re: [PATCH net-next v1 2/2] netpoll: avoid reference leaks

yways: as a consequence, not sure this callback is actually required in its current inception. On Mon, Jul 7, 2014 at 7:35 PM, David Miller wrote: > From: David Decotigny > Date: Mon, 30 Jun 2014 16:50:10 -0700 > >> This ensures that the ndo_netpoll_cleanup callback is called for

Re: [PATCH net-next v1 2/2] netpoll: avoid reference leaks

In that case, that's what the original code does: dropping this patch 2/2. Patch 1/2 "netpoll: fix use after free" is still needed to prevent panics, though. On Tue, Jul 8, 2014 at 2:17 PM, David Miller wrote: > From: David Decotigny > Date: Tue, 8 Jul 2014 12:35:14 -070

[PATCH net-next v2] netpoll: fix use after free

After a bonding master reclaims the netpoll info struct, slaves could still hold a pointer to the reclaimed data. This patch fixes it: as soon as netpoll_async_cleanup is called for a slave (eg. when un-enslaved), we make sure that this slave doesn't point to the data. Signed-off-by:

[PATCH v1] e1000e: honor pause autoneg flag

Before: ifup eth0 ethtool -A eth0 autoneg off rx on ethtool -a eth0 # rx on, as expected ifconfig eth0 up sleep 5 ethtool -a eth0 # rx off, not expected After: rx on with iface up, as expected Signed-off-by: David Decotigny --- drivers/net/ethernet/intel/e1000e/mac.c | 5

[PATCH v1] net-sysfs: expose number of link up/down transitions

Tested: grep . /sys/class/net/*/count_link_* + ip link set dev X down/up Signed-off-by: David Decotigny --- include/linux/netdevice.h | 4 net/core/net-sysfs.c | 18 ++ net/sched/sch_generic.c | 2 ++ 3 files changed, 24 insertions(+) diff --git a/include

Re: [PATCH v1] net-sysfs: expose number of link up/down transitions

Hi all, Thank you all for your feedback. Indeed, these counters are meant to detect link flapping situations, and we prefer to accumulate in the kernel rather than doing it in user space based on the count of up/down transitions. How about I update the patch with a new IFLA_LINK_HEALTH that expose

[PATCH net-next v2] net-sysfs: expose number of carrier on/off changes

iproute2: prints IFLA_CARRIER_CHANGES - iproute2 20121211-2 (debian): unchanged behavior Signed-off-by: David Decotigny --- include/linux/netdevice.h| 3 +++ include/uapi/linux/if_link.h | 1 + net/core/net-sysfs.c | 11 +++ net/core/rtnetlink.c | 6 +- net/sched

Re: [PATCH net-next v2] net-sysfs: expose number of carrier on/off changes

mminger wrote: >> On Sat, 29 Mar 2014 09:48:35 -0700 >> David Decotigny wrote: >> >> > This allows to monitor carrier on/off transitions and detect link >> > flapping issues: >> > - new /sys/class/net/X/carrier_changes >> > - new rtnetlink IF

[PATCH v1] net-sysfs: expose permanent hardware address in sysfs

Tested: grep . /sys/class/net/*/*addr* Signed-off-by: David Decotigny --- net/core/net-sysfs.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 1cac29e..bf57024 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c

Re: [PATCH] scsi: avoid use of reclaimed reference

lowed, then I'd argue that the "if (scsi_device_created(sdev))" on the potentially reclaimed sdev is not right, that's why I was proposing this patch. Regards, On Wed, Nov 13, 2013 at 4:06 AM, Bart Van Assche wrote: > On 11/13/13 02:10, David Decotigny wrote: >> >>

Re: [PATCH v2 1/3] net: core: ethtool: add ethtool_op_{get|set}_link_ksettings

Are you sure this belongs to ethtool.h? For one, I believe you need an #include phy.h somewhere. I would suggest instead to keep this in phy.h, presumably with a more explicit name suggesting that phydev is involved. On Sun, May 8, 2016 at 2:44 PM, Philippe Reynes wrote: > Ethtool callbacks {get|

Re: [PATCH v3 1/3] net: phy: add phy_ethtool_{get|set}_link_ksettings

id phy_ethtool_get_wol(struct phy_device *phydev, > struct ethtool_wolinfo *wol); > +int phy_ethtool_get_link_ksettings(struct net_device *ndev, > + struct ethtool_link_ksettings *cmd); > +int phy_ethtool_set_link_ksettings(struct net_device *ndev, > + const struct ethtool_link_ksettings *cmd); > > int __init mdio_bus_init(void); > void mdio_bus_exit(void); > -- > 1.7.4.4 > Acked-By: David Decotigny

Re: [PATCH net-next v5 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

you think it's preferred. On Wed, Dec 16, 2015 at 8:38 AM, David Miller wrote: > From: David Decotigny > Date: Mon, 14 Dec 2015 13:03:52 -0800 > >> +static int ethtool_get_ksettings(struct net_device *dev, void __user >> *useraddr) >> +{ &g

[PATCH net-next v3 00/17] RFC: new ETHTOOL_GSETTINGS/SSETTINGS API

From: David Decotigny History: v3 - rebased v2 on top of latest net-next, minor checkpatch/printf %*pb updates v2 - keep return 0 in get_settings when successful, instead of propagating positive result from driver's get_settings callback. v1 - original submission The main go

[PATCH net-next v3 07/17] net: ipvlan: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index a9268db..63b3aa5 100644 --- a/drivers/net/ipvlan

[PATCH net-next v3 13/17] net: bridge: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index ec02f58..e6de008 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -36,10 +36,10

[PATCH net-next v3 01/17] net: usnic: remove unused call to ethtool_ops::get_settings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index f8e3211..5b60579 100644 --- a/drivers

[PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

From: David Decotigny This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by the new get_ksettings/set_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable length), and removes

[PATCH net-next v3 17/17] net: mlx4: use new ETHTOOL_G/SSETTINGS API

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 323 drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h| 1 + 3 files changed, 157 insertions(+), 168

[PATCH net-next v3 14/17] net: core: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index f88a62a..3dd4bb1 100644 --- a/net

[PATCH net-next v3 16/17] net: mlx4: convenience predicate for debug messages

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h index 35de7d2..b04054d

[PATCH net-next v3 15/17] net: ethtool: remove unused __ethtool_get_settings

From: David Decotigny replaced by __ethtool_get_ksettings. Signed-off-by: David Decotigny --- include/linux/ethtool.h | 4 net/core/ethtool.c | 49 ++--- 2 files changed, 14 insertions(+), 39 deletions(-) diff --git a/include/linux

[PATCH net-next v3 11/17] net: rdma: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index 1152859..1820f26 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma

[PATCH net-next v3 12/17] net: 8021q: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index fded865..e607fee 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -620,12

[PATCH net-next v3 08/17] net: macvlan: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 06c8bfe..a95b793 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c

[PATCH net-next v3 09/17] net: team: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/team/team.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 651d35e..288ca01 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team

[PATCH net-next v3 10/17] net: fcoe: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/scsi/fcoe/fcoe_transport.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index d7597c0..9049197

[PATCH net-next v3 05/17] net: usnic: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index e082170..e0d12d4

[PATCH net-next v3 06/17] net: bonding: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 9e0f8a7..67d724d 100644 --- a/drivers/net/bonding

  1   2   3   >